circuit-to-canvas 0.0.43 → 0.0.44

package/dist/index.js

@@ -816,6 +816,12 @@ function drawPcbVia(params) {
 }
 
 // lib/drawer/elements/pcb-hole.ts
+function getRotation(hole) {
+  if ("ccw_rotation" in hole && typeof hole.ccw_rotation === "number") {
+    return hole.ccw_rotation;
+  }
+  return 0;
+}
 function drawPcbHole(params) {
   const { ctx, hole, realToCanvasMat, colorMap } = params;
   const hasSoldermask = hole.is_covered_with_solder_mask === true && hole.soldermask_margin !== void 0 && hole.soldermask_margin > 0;
@@ -841,6 +847,7 @@ function drawPcbHole(params) {
     return;
   }
   if (hole.hole_shape === "square") {
+    const rotation = getRotation(hole);
     if (hasSoldermask && margin > 0) {
       drawRect({
         ctx,
@@ -848,7 +855,8 @@ function drawPcbHole(params) {
         width: hole.hole_diameter + margin * 2,
         height: hole.hole_diameter + margin * 2,
         fill: positiveMarginColor,
-        realToCanvasMat
+        realToCanvasMat,
+        rotation
       });
     }
     drawRect({
@@ -857,11 +865,13 @@ function drawPcbHole(params) {
       width: hole.hole_diameter,
       height: hole.hole_diameter,
       fill: colorMap.drill,
-      realToCanvasMat
+      realToCanvasMat,
+      rotation
     });
     return;
   }
   if (hole.hole_shape === "oval") {
+    const rotation = getRotation(hole);
     if (hasSoldermask && margin > 0) {
       drawOval({
         ctx,
@@ -869,7 +879,8 @@ function drawPcbHole(params) {
         radius_x: hole.hole_width / 2 + margin,
         radius_y: hole.hole_height / 2 + margin,
         fill: positiveMarginColor,
-        realToCanvasMat
+        realToCanvasMat,
+        rotation
       });
     }
     drawOval({
@@ -878,11 +889,13 @@ function drawPcbHole(params) {
       radius_x: hole.hole_width / 2,
       radius_y: hole.hole_height / 2,
       fill: colorMap.drill,
-      realToCanvasMat
+      realToCanvasMat,
+      rotation
     });
     return;
   }
   if (hole.hole_shape === "rect") {
+    const rotation = getRotation(hole);
     if (hasSoldermask && margin > 0) {
       drawRect({
         ctx,
@@ -890,7 +903,8 @@ function drawPcbHole(params) {
         width: hole.hole_width + margin * 2,
         height: hole.hole_height + margin * 2,
         fill: positiveMarginColor,
-        realToCanvasMat
+        realToCanvasMat,
+        rotation
       });
     }
     drawRect({
@@ -899,11 +913,13 @@ function drawPcbHole(params) {
       width: hole.hole_width,
       height: hole.hole_height,
       fill: colorMap.drill,
-      realToCanvasMat
+      realToCanvasMat,
+      rotation
     });
     return;
   }
   if (hole.hole_shape === "pill") {
+    const rotation = getRotation(hole);
     if (hasSoldermask && margin > 0) {
       drawPill({
         ctx,
@@ -911,7 +927,8 @@ function drawPcbHole(params) {
         width: hole.hole_width + margin * 2,
         height: hole.hole_height + margin * 2,
         fill: positiveMarginColor,
-        realToCanvasMat
+        realToCanvasMat,
+        rotation
       });
     }
     drawPill({
@@ -920,12 +937,13 @@ function drawPcbHole(params) {
       width: hole.hole_width,
       height: hole.hole_height,
       fill: colorMap.drill,
-      realToCanvasMat
+      realToCanvasMat,
+      rotation
     });
     return;
   }
   if (hole.hole_shape === "rotated_pill") {
-    const rotation = hole.ccw_rotation ?? 0;
+    const rotation = getRotation(hole);
     if (hasSoldermask && margin > 0) {
       drawPill({
         ctx,

package/lib/drawer/elements/pcb-hole.ts

@@ -13,6 +13,14 @@ export interface DrawPcbHoleParams {
   colorMap: PcbColorMap
 }
 
+// Helper function to safely access ccw_rotation property
+function getRotation(hole: PCBHole): number {
+  if ("ccw_rotation" in hole && typeof hole.ccw_rotation === "number") {
+    return hole.ccw_rotation
+  }
+  return 0
+}
+
 export function drawPcbHole(params: DrawPcbHoleParams): void {
   const { ctx, hole, realToCanvasMat, colorMap } = params
 
@@ -47,6 +55,7 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
   }
 
   if (hole.hole_shape === "square") {
+    const rotation = getRotation(hole)
     // For positive margins, draw extended mask area first
     if (hasSoldermask && margin > 0) {
       drawRect({
@@ -56,6 +65,7 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
         height: hole.hole_diameter + margin * 2,
         fill: positiveMarginColor,
         realToCanvasMat,
+        rotation,
       })
     }
 
@@ -67,11 +77,13 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
       height: hole.hole_diameter,
       fill: colorMap.drill,
       realToCanvasMat,
+      rotation,
     })
     return
   }
 
   if (hole.hole_shape === "oval") {
+    const rotation = getRotation(hole)
     // For positive margins, draw extended mask area first
     if (hasSoldermask && margin > 0) {
       drawOval({
@@ -81,6 +93,7 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
         radius_y: hole.hole_height / 2 + margin,
         fill: positiveMarginColor,
         realToCanvasMat,
+        rotation,
       })
     }
 
@@ -92,11 +105,13 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
       radius_y: hole.hole_height / 2,
       fill: colorMap.drill,
       realToCanvasMat,
+      rotation,
     })
     return
   }
 
   if (hole.hole_shape === "rect") {
+    const rotation = getRotation(hole)
     // For positive margins, draw extended mask area first
     if (hasSoldermask && margin > 0) {
       drawRect({
@@ -106,6 +121,7 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
         height: hole.hole_height + margin * 2,
         fill: positiveMarginColor,
         realToCanvasMat,
+        rotation,
       })
     }
 
@@ -117,11 +133,13 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
       height: hole.hole_height,
       fill: colorMap.drill,
       realToCanvasMat,
+      rotation,
     })
     return
   }
 
   if (hole.hole_shape === "pill") {
+    const rotation = getRotation(hole)
     // For positive margins, draw extended mask area first
     if (hasSoldermask && margin > 0) {
       drawPill({
@@ -131,6 +149,7 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
         height: hole.hole_height + margin * 2,
         fill: positiveMarginColor,
         realToCanvasMat,
+        rotation,
       })
     }
 
@@ -142,12 +161,13 @@ export function drawPcbHole(params: DrawPcbHoleParams): void {
       height: hole.hole_height,
       fill: colorMap.drill,
       realToCanvasMat,
+      rotation,
     })
     return
   }
 
   if (hole.hole_shape === "rotated_pill") {
-    const rotation = (hole as any).ccw_rotation ?? 0
+    const rotation = getRotation(hole)
 
     // For positive margins, draw extended mask area first
     if (hasSoldermask && margin > 0) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "circuit-to-canvas",
   "main": "dist/index.js",
-  "version": "0.0.43",
+  "version": "0.0.44",
   "type": "module",
   "scripts": {
     "build": "tsup-node ./lib/index.ts --format esm --dts",

package/tests/elements/pcb-hole.test.ts

@@ -103,3 +103,110 @@ test("draw pill hole", async () => {
     "pill-hole",
   )
 })
+
+test("draw rotated oval hole", async () => {
+  const canvas = createCanvas(100, 100)
+  const ctx = canvas.getContext("2d")
+  const drawer = new CircuitToCanvasDrawer(ctx)
+
+  ctx.fillStyle = "#1a1a1a"
+  ctx.fillRect(0, 0, 100, 100)
+
+  const hole: PCBHole & { ccw_rotation?: number } = {
+    type: "pcb_hole",
+    pcb_hole_id: "hole1",
+    hole_shape: "oval",
+    hole_width: 50,
+    hole_height: 30,
+    x: 50,
+    y: 50,
+    ccw_rotation: 45,
+  }
+
+  drawer.drawElements([hole])
+
+  await expect(canvas.toBuffer("image/png")).toMatchPngSnapshot(
+    import.meta.path,
+    "rotated-oval-hole",
+  )
+})
+
+test("draw rotated rect hole", async () => {
+  const canvas = createCanvas(100, 100)
+  const ctx = canvas.getContext("2d")
+  const drawer = new CircuitToCanvasDrawer(ctx)
+
+  ctx.fillStyle = "#1a1a1a"
+  ctx.fillRect(0, 0, 100, 100)
+
+  const hole: PCBHole & { ccw_rotation?: number } = {
+    type: "pcb_hole",
+    pcb_hole_id: "hole1",
+    hole_shape: "rect",
+    hole_width: 50,
+    hole_height: 30,
+    x: 50,
+    y: 50,
+    ccw_rotation: 45,
+  }
+
+  drawer.drawElements([hole])
+
+  await expect(canvas.toBuffer("image/png")).toMatchPngSnapshot(
+    import.meta.path,
+    "rotated-rect-hole",
+  )
+})
+
+test("draw rotated square hole", async () => {
+  const canvas = createCanvas(100, 100)
+  const ctx = canvas.getContext("2d")
+  const drawer = new CircuitToCanvasDrawer(ctx)
+
+  ctx.fillStyle = "#1a1a1a"
+  ctx.fillRect(0, 0, 100, 100)
+
+  const hole: PCBHole & { ccw_rotation?: number } = {
+    type: "pcb_hole",
+    pcb_hole_id: "hole1",
+    hole_shape: "square",
+    hole_diameter: 30,
+    x: 50,
+    y: 50,
+    ccw_rotation: 45,
+  }
+
+  drawer.drawElements([hole])
+
+  await expect(canvas.toBuffer("image/png")).toMatchPngSnapshot(
+    import.meta.path,
+    "rotated-square-hole",
+  )
+})
+
+test("draw rotated pill hole", async () => {
+  const canvas = createCanvas(100, 100)
+  const ctx = canvas.getContext("2d")
+  const drawer = new CircuitToCanvasDrawer(ctx)
+
+  ctx.fillStyle = "#1a1a1a"
+  ctx.fillRect(0, 0, 100, 100)
+
+  const hole: PCBHole & { ccw_rotation?: number } = {
+    type: "pcb_hole",
+    pcb_hole_id: "hole1",
+    hole_shape: "pill",
+    hole_width: 60,
+    hole_height: 30,
+    x: 50,
+    y: 50,
+    ccw_rotation: 45,
+  }
+
+  drawer.drawElements([hole])
+
+  await expect(canvas.toBuffer("image/png")).toMatchPngSnapshot(
+    import.meta.path,
+    "rotated-pill-hole",
+  )
+})