circuit-json-to-step 0.0.13 → 0.0.15

package/dist/index.js

@@ -722,7 +722,7 @@ function normalizeStepNumericExponents(stepText) {
 var package_default = {
   name: "circuit-json-to-step",
   main: "dist/index.js",
-  version: "0.0.12",
+  version: "0.0.13",
   type: "module",
   scripts: {
     "pull-reference": `git clone https://github.com/tscircuit/circuit-json.git && find circuit-json/tests -name '*.test.ts' -exec bash -c 'mv "$0" "\${0%.test.ts}.ts"' {} \\; && git clone https://github.com/tscircuit/stepts.git && find stepts/tests -name '*.test.ts' -exec bash -c 'mv "$0" "\${0%.test.ts}.ts"' {} \\;`,
@@ -743,7 +743,7 @@ var package_default = {
     "circuit-json": "^0.0.286",
     "looks-same": "^10.0.1",
     "occt-import-js": "^0.0.23",
-    poppygl: "^0.0.13",
+    poppygl: "^0.0.17",
     stepts: "^0.0.2",
     tsup: "^8.5.0"
   },
@@ -753,8 +753,8 @@ var package_default = {
   },
   dependencies: {
     "circuit-json-to-connectivity-map": "^0.0.22",
-    "circuit-json-to-gltf": "^0.0.19",
-    "circuit-to-svg": "^0.0.248",
+    "circuit-json-to-gltf": "^0.0.62",
+    "circuit-to-svg": "^0.0.327",
     "schematic-symbols": "^0.0.202"
   }
 };
@@ -844,7 +844,23 @@ async function circuitJsonToStep(circuitJson, options = {}) {
   let bottomVertices;
   let topVertices;
   if (outline && Array.isArray(outline) && outline.length >= 3) {
-    bottomVertices = outline.map(
+    const cleanedOutline = [];
+    for (let i = 0; i < outline.length; i++) {
+      const current = outline[i];
+      const next = outline[(i + 1) % outline.length];
+      const dx = next.x - current.x;
+      const dy = next.y - current.y;
+      const dist = Math.sqrt(dx * dx + dy * dy);
+      if (dist > 1e-6) {
+        cleanedOutline.push(current);
+      }
+    }
+    if (cleanedOutline.length < 3) {
+      throw new Error(
+        `Outline has too few unique vertices after removing duplicates (${cleanedOutline.length}). Need at least 3.`
+      );
+    }
+    bottomVertices = cleanedOutline.map(
       (point) => repo.add(
         new VertexPoint2(
           "",
@@ -852,7 +868,7 @@ async function circuitJsonToStep(circuitJson, options = {}) {
         )
       )
     );
-    topVertices = outline.map(
+    topVertices = cleanedOutline.map(
       (point) => repo.add(
         new VertexPoint2(
           "",
@@ -884,10 +900,20 @@ async function circuitJsonToStep(circuitJson, options = {}) {
   function createEdge(v1, v2) {
     const p1 = v1.resolve(repo).pnt.resolve(repo);
     const p2 = v2.resolve(repo).pnt.resolve(repo);
+    const dx = p2.x - p1.x;
+    const dy = p2.y - p1.y;
+    const dz = p2.z - p1.z;
+    const length = Math.sqrt(dx * dx + dy * dy + dz * dz);
+    if (length < 1e-10) {
+      const dir2 = repo.add(new Direction3("", 1, 0, 0));
+      const vec2 = repo.add(new Vector2("", dir2, 1e-10));
+      const line2 = repo.add(new Line2("", v1.resolve(repo).pnt, vec2));
+      return repo.add(new EdgeCurve2("", v1, v2, line2, true));
+    }
     const dir = repo.add(
-      new Direction3("", p2.x - p1.x, p2.y - p1.y, p2.z - p1.z)
+      new Direction3("", dx / length, dy / length, dz / length)
     );
-    const vec = repo.add(new Vector2("", dir, 1));
+    const vec = repo.add(new Vector2("", dir, length));
     const line = repo.add(new Line2("", v1.resolve(repo).pnt, vec));
     return repo.add(new EdgeCurve2("", v1, v2, line, true));
   }

package/lib/index.ts

@@ -168,7 +168,27 @@ export async function circuitJsonToStep(
 
   if (outline && Array.isArray(outline) && outline.length >= 3) {
     // Use custom outline (points are already relative to board center)
-    bottomVertices = outline.map((point) =>
+    // Filter out duplicate consecutive vertices (including first/last wrap-around)
+    const cleanedOutline: { x: number; y: number }[] = []
+    for (let i = 0; i < outline.length; i++) {
+      const current = outline[i]!
+      const next = outline[(i + 1) % outline.length]!
+      const dx = next.x - current.x
+      const dy = next.y - current.y
+      const dist = Math.sqrt(dx * dx + dy * dy)
+      // Only add vertex if it's not a duplicate of the next one
+      if (dist > 1e-6) {
+        cleanedOutline.push(current)
+      }
+    }
+
+    if (cleanedOutline.length < 3) {
+      throw new Error(
+        `Outline has too few unique vertices after removing duplicates (${cleanedOutline.length}). Need at least 3.`,
+      )
+    }
+
+    bottomVertices = cleanedOutline.map((point) =>
       repo.add(
         new VertexPoint(
           "",
@@ -176,7 +196,7 @@ export async function circuitJsonToStep(
         ),
       ),
     )
-    topVertices = outline.map((point) =>
+    topVertices = cleanedOutline.map((point) =>
       repo.add(
         new VertexPoint(
           "",
@@ -214,10 +234,26 @@ export async function circuitJsonToStep(
   ): Ref<EdgeCurve> {
     const p1 = v1.resolve(repo).pnt.resolve(repo)
     const p2 = v2.resolve(repo).pnt.resolve(repo)
+    const dx = p2.x - p1.x
+    const dy = p2.y - p1.y
+    const dz = p2.z - p1.z
+    const length = Math.sqrt(dx * dx + dy * dy + dz * dz)
+
+    // Handle zero-length edges (duplicate vertices)
+    if (length < 1e-10) {
+      // Use arbitrary direction for degenerate edge
+      const dir = repo.add(new Direction("", 1, 0, 0))
+      const vec = repo.add(new Vector("", dir, 1e-10))
+      const line = repo.add(new Line("", v1.resolve(repo).pnt, vec))
+      return repo.add(new EdgeCurve("", v1, v2, line, true))
+    }
+
+    // Direction must be normalized (unit vector)
     const dir = repo.add(
-      new Direction("", p2.x - p1.x, p2.y - p1.y, p2.z - p1.z),
+      new Direction("", dx / length, dy / length, dz / length),
     )
-    const vec = repo.add(new Vector("", dir, 1))
+    // Vector magnitude is the actual edge length
+    const vec = repo.add(new Vector("", dir, length))
     const line = repo.add(new Line("", v1.resolve(repo).pnt, vec))
     return repo.add(new EdgeCurve("", v1, v2, line, true))
   }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "circuit-json-to-step",
   "main": "dist/index.js",
-  "version": "0.0.13",
+  "version": "0.0.15",
   "type": "module",
   "scripts": {
     "pull-reference": "git clone https://github.com/tscircuit/circuit-json.git && find circuit-json/tests -name '*.test.ts' -exec bash -c 'mv \"$0\" \"${0%.test.ts}.ts\"' {} \\; && git clone https://github.com/tscircuit/stepts.git && find stepts/tests -name '*.test.ts' -exec bash -c 'mv \"$0\" \"${0%.test.ts}.ts\"' {} \\;",
@@ -22,7 +22,7 @@
     "circuit-json": "^0.0.286",
     "looks-same": "^10.0.1",
     "occt-import-js": "^0.0.23",
-    "poppygl": "^0.0.13",
+    "poppygl": "^0.0.17",
     "stepts": "^0.0.2",
     "tsup": "^8.5.0"
   },
@@ -32,8 +32,8 @@
   },
   "dependencies": {
     "circuit-json-to-connectivity-map": "^0.0.22",
-    "circuit-json-to-gltf": "^0.0.19",
-    "circuit-to-svg": "^0.0.248",
+    "circuit-json-to-gltf": "^0.0.62",
+    "circuit-to-svg": "^0.0.327",
     "schematic-symbols": "^0.0.202"
   }
 }

package/test/repros/repro02/repro02.json

@@ -0,0 +1,816 @@
+[
+  {
+    "type": "source_project_metadata",
+    "source_project_metadata_id": "source_project_metadata_0",
+    "software_used_string": "@tscircuit/core@0.0.1010"
+  },
+  {
+    "type": "source_group",
+    "source_group_id": "source_group_0",
+    "is_subcircuit": true,
+    "was_automatically_named": true,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_0",
+    "ftype": "simple_chip",
+    "name": "MP1",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_1",
+    "ftype": "simple_chip",
+    "name": "MP2",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_2",
+    "ftype": "simple_chip",
+    "name": "MP3",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_3",
+    "ftype": "simple_chip",
+    "name": "MP4",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_4",
+    "ftype": "simple_chip",
+    "name": "Xpattern1",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_5",
+    "ftype": "simple_chip",
+    "name": "Xpattern2",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_6",
+    "ftype": "simple_chip",
+    "name": "Xpattern3",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_component",
+    "source_component_id": "source_component_7",
+    "ftype": "simple_chip",
+    "name": "Xpattern4",
+    "supplier_part_numbers": {},
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "source_board",
+    "source_board_id": "source_board_0",
+    "source_group_id": "source_group_0"
+  },
+  {
+    "type": "pcb_board",
+    "pcb_board_id": "pcb_board_0",
+    "source_board_id": "source_board_0",
+    "center": {
+      "x": 0,
+      "y": 0
+    },
+    "thickness": 1.4,
+    "num_layers": 2,
+    "width": 63,
+    "height": 63,
+    "outline": [
+      {
+        "x": -30.5,
+        "y": -31.5
+      },
+      {
+        "x": 30.5,
+        "y": -31.5
+      },
+      {
+        "x": 30.59801714032956,
+        "y": -31.495184726672196
+      },
+      {
+        "x": 30.695090322016128,
+        "y": -31.480785280403232
+      },
+      {
+        "x": 30.790284677254462,
+        "y": -31.45694033573221
+      },
+      {
+        "x": 30.88268343236509,
+        "y": -31.423879532511286
+      },
+      {
+        "x": 30.971396736825998,
+        "y": -31.381921264348357
+      },
+      {
+        "x": 31.0555702330196,
+        "y": -31.331469612302545
+      },
+      {
+        "x": 31.134393284163647,
+        "y": -31.273010453362737
+      },
+      {
+        "x": 31.207106781186546,
+        "y": -31.207106781186546
+      },
+      {
+        "x": 31.273010453362737,
+        "y": -31.134393284163647
+      },
+      {
+        "x": 31.331469612302545,
+        "y": -31.0555702330196
+      },
+      {
+        "x": 31.381921264348357,
+        "y": -30.971396736825998
+      },
+      {
+        "x": 31.423879532511286,
+        "y": -30.88268343236509
+      },
+      {
+        "x": 31.45694033573221,
+        "y": -30.790284677254462
+      },
+      {
+        "x": 31.480785280403232,
+        "y": -30.695090322016128
+      },
+      {
+        "x": 31.495184726672196,
+        "y": -30.59801714032956
+      },
+      {
+        "x": 31.5,
+        "y": -30.5
+      },
+      {
+        "x": 31.5,
+        "y": 30.5
+      },
+      {
+        "x": 31.495184726672196,
+        "y": 30.59801714032956
+      },
+      {
+        "x": 31.480785280403232,
+        "y": 30.695090322016128
+      },
+      {
+        "x": 31.45694033573221,
+        "y": 30.790284677254462
+      },
+      {
+        "x": 31.423879532511286,
+        "y": 30.88268343236509
+      },
+      {
+        "x": 31.381921264348357,
+        "y": 30.971396736825998
+      },
+      {
+        "x": 31.331469612302545,
+        "y": 31.0555702330196
+      },
+      {
+        "x": 31.273010453362737,
+        "y": 31.134393284163647
+      },
+      {
+        "x": 31.207106781186546,
+        "y": 31.207106781186546
+      },
+      {
+        "x": 31.134393284163647,
+        "y": 31.273010453362737
+      },
+      {
+        "x": 31.0555702330196,
+        "y": 31.331469612302545
+      },
+      {
+        "x": 30.971396736825998,
+        "y": 31.381921264348357
+      },
+      {
+        "x": 30.88268343236509,
+        "y": 31.423879532511286
+      },
+      {
+        "x": 30.790284677254462,
+        "y": 31.45694033573221
+      },
+      {
+        "x": 30.695090322016128,
+        "y": 31.480785280403232
+      },
+      {
+        "x": 30.59801714032956,
+        "y": 31.495184726672196
+      },
+      {
+        "x": 30.5,
+        "y": 31.5
+      },
+      {
+        "x": -30.5,
+        "y": 31.5
+      },
+      {
+        "x": -30.59801714032956,
+        "y": 31.495184726672196
+      },
+      {
+        "x": -30.695090322016128,
+        "y": 31.480785280403232
+      },
+      {
+        "x": -30.790284677254462,
+        "y": 31.45694033573221
+      },
+      {
+        "x": -30.88268343236509,
+        "y": 31.423879532511286
+      },
+      {
+        "x": -30.971396736825998,
+        "y": 31.381921264348357
+      },
+      {
+        "x": -31.0555702330196,
+        "y": 31.331469612302545
+      },
+      {
+        "x": -31.134393284163647,
+        "y": 31.273010453362737
+      },
+      {
+        "x": -31.207106781186546,
+        "y": 31.207106781186546
+      },
+      {
+        "x": -31.273010453362737,
+        "y": 31.134393284163647
+      },
+      {
+        "x": -31.331469612302545,
+        "y": 31.0555702330196
+      },
+      {
+        "x": -31.381921264348357,
+        "y": 30.971396736825998
+      },
+      {
+        "x": -31.423879532511286,
+        "y": 30.88268343236509
+      },
+      {
+        "x": -31.45694033573221,
+        "y": 30.790284677254462
+      },
+      {
+        "x": -31.480785280403232,
+        "y": 30.695090322016128
+      },
+      {
+        "x": -31.495184726672196,
+        "y": 30.59801714032956
+      },
+      {
+        "x": -31.5,
+        "y": 30.5
+      },
+      {
+        "x": -31.5,
+        "y": -30.5
+      },
+      {
+        "x": -31.495184726672196,
+        "y": -30.59801714032956
+      },
+      {
+        "x": -31.480785280403232,
+        "y": -30.695090322016128
+      },
+      {
+        "x": -31.45694033573221,
+        "y": -30.790284677254462
+      },
+      {
+        "x": -31.423879532511286,
+        "y": -30.88268343236509
+      },
+      {
+        "x": -31.381921264348357,
+        "y": -30.971396736825998
+      },
+      {
+        "x": -31.331469612302545,
+        "y": -31.0555702330196
+      },
+      {
+        "x": -31.273010453362737,
+        "y": -31.134393284163647
+      },
+      {
+        "x": -31.207106781186546,
+        "y": -31.207106781186546
+      },
+      {
+        "x": -31.134393284163647,
+        "y": -31.273010453362737
+      },
+      {
+        "x": -31.0555702330196,
+        "y": -31.331469612302545
+      },
+      {
+        "x": -30.971396736825998,
+        "y": -31.381921264348357
+      },
+      {
+        "x": -30.88268343236509,
+        "y": -31.423879532511286
+      },
+      {
+        "x": -30.790284677254462,
+        "y": -31.45694033573221
+      },
+      {
+        "x": -30.695090322016128,
+        "y": -31.48078528040323
+      },
+      {
+        "x": -30.59801714032956,
+        "y": -31.495184726672196
+      },
+      {
+        "x": -30.5,
+        "y": -31.5
+      }
+    ],
+    "material": "fr4"
+  },
+  {
+    "type": "pcb_plated_hole",
+    "pcb_plated_hole_id": "pcb_plated_hole_0",
+    "outer_diameter": 5.2,
+    "hole_diameter": 3.45,
+    "shape": "circle",
+    "port_hints": ["unnamed_platedhole1", "1"],
+    "x": -16,
+    "y": -16,
+    "layers": ["top", "bottom"],
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_0",
+    "layer": "top",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": -16,
+    "y": -16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_1",
+    "layer": "bottom",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": -16,
+    "y": -16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_note_text",
+    "pcb_note_text_id": "pcb_note_text_0",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "font": "tscircuit2024",
+    "font_size": 0.5,
+    "text": "MP1",
+    "anchor_position": {
+      "x": -16,
+      "y": -16
+    },
+    "anchor_alignment": "center"
+  },
+  {
+    "type": "pcb_note_rect",
+    "pcb_note_rect_id": "pcb_note_rect_0",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "center": {
+      "x": -16,
+      "y": -16
+    },
+    "width": 5.95,
+    "height": 5.95,
+    "stroke_width": 0.05,
+    "is_filled": false,
+    "has_stroke": true,
+    "is_stroke_dashed": false,
+    "color": "#ffd700"
+  },
+  {
+    "type": "pcb_plated_hole",
+    "pcb_plated_hole_id": "pcb_plated_hole_1",
+    "outer_diameter": 5.2,
+    "hole_diameter": 3.45,
+    "shape": "circle",
+    "port_hints": ["unnamed_platedhole2", "1"],
+    "x": -16,
+    "y": 16,
+    "layers": ["top", "bottom"],
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_2",
+    "layer": "top",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": -16,
+    "y": 16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_3",
+    "layer": "bottom",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": -16,
+    "y": 16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_note_text",
+    "pcb_note_text_id": "pcb_note_text_1",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "font": "tscircuit2024",
+    "font_size": 0.5,
+    "text": "MP2",
+    "anchor_position": {
+      "x": -16,
+      "y": 16
+    },
+    "anchor_alignment": "center"
+  },
+  {
+    "type": "pcb_note_rect",
+    "pcb_note_rect_id": "pcb_note_rect_1",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "center": {
+      "x": -16,
+      "y": 16
+    },
+    "width": 5.95,
+    "height": 5.95,
+    "stroke_width": 0.05,
+    "is_filled": false,
+    "has_stroke": true,
+    "is_stroke_dashed": false,
+    "color": "#ffd700"
+  },
+  {
+    "type": "pcb_plated_hole",
+    "pcb_plated_hole_id": "pcb_plated_hole_2",
+    "outer_diameter": 5.2,
+    "hole_diameter": 3.45,
+    "shape": "circle",
+    "port_hints": ["unnamed_platedhole3", "1"],
+    "x": 16,
+    "y": 16,
+    "layers": ["top", "bottom"],
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_4",
+    "layer": "top",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": 16,
+    "y": 16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_5",
+    "layer": "bottom",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": 16,
+    "y": 16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_note_text",
+    "pcb_note_text_id": "pcb_note_text_2",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "font": "tscircuit2024",
+    "font_size": 0.5,
+    "text": "MP3",
+    "anchor_position": {
+      "x": 16,
+      "y": 16
+    },
+    "anchor_alignment": "center"
+  },
+  {
+    "type": "pcb_note_rect",
+    "pcb_note_rect_id": "pcb_note_rect_2",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "center": {
+      "x": 16,
+      "y": 16
+    },
+    "width": 5.95,
+    "height": 5.95,
+    "stroke_width": 0.05,
+    "is_filled": false,
+    "has_stroke": true,
+    "is_stroke_dashed": false,
+    "color": "#ffd700"
+  },
+  {
+    "type": "pcb_plated_hole",
+    "pcb_plated_hole_id": "pcb_plated_hole_3",
+    "outer_diameter": 5.2,
+    "hole_diameter": 3.45,
+    "shape": "circle",
+    "port_hints": ["unnamed_platedhole4", "1"],
+    "x": 16,
+    "y": -16,
+    "layers": ["top", "bottom"],
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_6",
+    "layer": "top",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": 16,
+    "y": -16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_solder_paste",
+    "pcb_solder_paste_id": "pcb_solder_paste_7",
+    "layer": "bottom",
+    "shape": "circle",
+    "radius": 2.6,
+    "x": 16,
+    "y": -16,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_note_text",
+    "pcb_note_text_id": "pcb_note_text_3",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "font": "tscircuit2024",
+    "font_size": 0.5,
+    "text": "MP4",
+    "anchor_position": {
+      "x": 16,
+      "y": -16
+    },
+    "anchor_alignment": "center"
+  },
+  {
+    "type": "pcb_note_rect",
+    "pcb_note_rect_id": "pcb_note_rect_3",
+    "subcircuit_id": "subcircuit_source_group_0",
+    "center": {
+      "x": 16,
+      "y": -16
+    },
+    "width": 5.95,
+    "height": 5.95,
+    "stroke_width": 0.05,
+    "is_filled": false,
+    "has_stroke": true,
+    "is_stroke_dashed": false,
+    "color": "#ffd700"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_0",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -8,
+    "y": -8,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_1",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -24,
+    "y": -8,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_2",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -24,
+    "y": -24,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_3",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -8,
+    "y": -24,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_4",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 24,
+    "y": -8,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_5",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 8,
+    "y": -8,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_6",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 8,
+    "y": -24,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_7",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 24,
+    "y": -24,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_8",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -8,
+    "y": 24,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_9",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -24,
+    "y": 24,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_10",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -24,
+    "y": 8,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_11",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": -8,
+    "y": 8,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_12",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 24,
+    "y": 24,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_13",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 8,
+    "y": 24,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_14",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 8,
+    "y": 8,
+    "ccw_rotation": 45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  },
+  {
+    "type": "pcb_hole",
+    "pcb_hole_id": "pcb_hole_15",
+    "hole_shape": "rotated_pill",
+    "hole_width": 8,
+    "hole_height": 4,
+    "x": 24,
+    "y": 8,
+    "ccw_rotation": -45,
+    "is_covered_with_solder_mask": false,
+    "subcircuit_id": "subcircuit_source_group_0"
+  }
+]

package/test/repros/repro02/repro02.test.ts

@@ -0,0 +1,78 @@
+import { expect, test } from "bun:test"
+import { renderGLTFToPNGBufferFromGLBBuffer } from "poppygl"
+import { circuitJsonToStep } from "../../../lib/index"
+import { importStepWithOcct } from "../../utils/occt/importer"
+import circuitJson from "./repro02.json"
+
+test("repro02: convert circuit json with rotated pill holes to STEP", async () => {
+  const stepText = await circuitJsonToStep(circuitJson as any, {
+    includeComponents: true,
+    productName: "Repro02",
+  })
+
+  const gltfModule = "circuit-json-to-gltf"
+  const { convertCircuitJsonTo3D, convertSceneToGLTF } = await import(
+    /* @vite-ignore */ gltfModule
+  )
+  const scene3d = await convertCircuitJsonTo3D(circuitJson as any, {
+    renderBoardTextures: false,
+    showBoundingBoxes: false,
+  })
+  const glb = await convertSceneToGLTF(scene3d, { binary: true })
+  expect(glb).toBeInstanceOf(ArrayBuffer)
+  expect((glb as ArrayBuffer).byteLength).toBeGreaterThan(0)
+
+  const cameraOptions = scene3d.camera
+    ? {
+        camPos: [
+          scene3d.camera.position.x,
+          scene3d.camera.position.y,
+          scene3d.camera.position.z,
+        ] as const,
+        lookAt: [
+          scene3d.camera.target.x,
+          scene3d.camera.target.y,
+          scene3d.camera.target.z,
+        ] as const,
+        fov: scene3d.camera.fov ?? 60,
+      }
+    : undefined
+  const gltfPng = await renderGLTFToPNGBufferFromGLBBuffer(
+    glb as ArrayBuffer,
+    cameraOptions,
+  )
+  await expect(gltfPng).toMatchPngSnapshot(import.meta.path, "repro02-gltf")
+
+  // Verify STEP format
+  expect(stepText).toContain("ISO-10303-21")
+  expect(stepText).toContain("END-ISO-10303-21")
+
+  // Verify product structure
+  expect(stepText).toContain("Repro02")
+  expect(stepText).toContain("MANIFOLD_SOLID_BREP")
+
+  // Verify holes are created
+  expect(stepText).toContain("CIRCLE")
+  expect(stepText).toContain("CYLINDRICAL_SURFACE")
+
+  // Write STEP file to debug-output
+  const outputPath = "debug-output/repro02.step"
+  await Bun.write(outputPath, stepText)
+
+  console.log("✓ STEP file generated successfully")
+  console.log(`  - STEP text length: ${stepText.length} bytes`)
+  console.log(`  - Output: ${outputPath}`)
+
+  // Validate STEP file can be imported with occt-import-js
+  const occtResult = await importStepWithOcct(stepText)
+  expect(occtResult.success).toBe(true)
+  expect(occtResult.meshes.length).toBeGreaterThan(0)
+
+  const [firstMesh] = occtResult.meshes
+  expect(firstMesh.attributes.position.array.length).toBeGreaterThan(0)
+  expect(firstMesh.index.array.length).toBeGreaterThan(0)
+
+  console.log("✓ STEP file successfully validated with occt-import-js")
+
+  await expect(stepText).toMatchStepSnapshot(import.meta.path, "repro02")
+}, 30000)