circuit-json-to-lbrn 0.0.1 → 0.0.2

package/tests/examples/lga-interconnect.test.ts

@@ -12,6 +12,10 @@ test("lga-interconnect", async () => {
 
   const project = convertCircuitJsonToLbrn(circuitJson)
 
+  Bun.write("debug-output/lga-interconnect.lbrn2", project.getString(), {
+    createPath: true,
+  })
+
   const lbrnSvg = await generateLightBurnSvg(project)
 
   expect(stackSvgsVertically([pcbSvg, lbrnSvg])).toMatchSvgSnapshot(

package/tests/examples/single-trace.test.ts

@@ -0,0 +1,67 @@
+import { test, expect } from "bun:test"
+import { convertCircuitJsonToPcbSvg } from "circuit-to-svg"
+import { generateLightBurnSvg } from "lbrnts"
+import { convertCircuitJsonToLbrn } from "../../lib"
+import { stackSvgsVertically } from "stack-svgs"
+import type { CircuitJson, SourceTrace } from "circuit-json"
+
+/**
+ * This test demonstrates a bug where standalone traces (traces not connected
+ * to any ports/nets) are not being converted to cut shapes in the LightBurn output.
+ *
+ * Expected: The trace should appear as a cut shape in the bottom SVG
+ * Actual: The trace is missing from the LightBurn output (only CutSetting is present)
+ *
+ * Root cause: addPcbTrace gets netId=undefined for unconnected traces, and
+ * netGeoms.get(undefined) returns undefined, so the trace polygon is never added.
+ */
+test("single-trace", async () => {
+  const circuitJson = [
+    {
+      type: "pcb_board",
+      pcb_board_id: "board_1",
+      width: 20,
+      height: 20,
+      center: { x: 0, y: 0 },
+    },
+    {
+      type: "pcb_trace",
+      pcb_trace_id: "trace_1",
+      source_trace_id: "trace_1",
+      route: [
+        {
+          x: -5,
+          y: -5,
+          width: 0.5,
+          layer: "top",
+        },
+        {
+          x: 5,
+          y: 5,
+          width: 0.5,
+          layer: "top",
+        },
+      ],
+    },
+    {
+      type: "source_trace",
+      source_trace_id: "trace_2",
+      connected_source_net_ids: [],
+      connected_source_port_ids: [],
+    } as SourceTrace,
+  ] as CircuitJson
+
+  const pcbSvg = await convertCircuitJsonToPcbSvg(circuitJson)
+
+  const project = convertCircuitJsonToLbrn(circuitJson)
+
+  Bun.write("debug-output/single-trace.lbrn2", project.getString(), {
+    createPath: true,
+  })
+
+  const lbrnSvg = await generateLightBurnSvg(project)
+
+  expect(stackSvgsVertically([pcbSvg, lbrnSvg])).toMatchSvgSnapshot(
+    import.meta.filename,
+  )
+})

package/tests/fixtures/preload.ts

@@ -1 +1 @@
-import "bun-match-svg"
+import "bun-match-svg"

package/tests/svg.test.ts

@@ -1,12 +1,11 @@
-import { expect, test } from "bun:test"                                                             
-                                                                                                                           
- const testSvg = `<svg width="100" height="100" xmlns="http://www.w3.org/2000/svg">                                       
+import { expect, test } from "bun:test"
+
+const testSvg = `<svg width="100" height="100" xmlns="http://www.w3.org/2000/svg">                                       
    <circle cx="50" cy="50" r="40" stroke="black" stroke-width="3" fill="red" />                                            
- </svg>`                                                                                                                  
-                                                                                                                           
- test("svg snapshot example", async () => {                                                                                
-   // First run will create the snapshot                                                                                   
-   // Subsequent runs will compare against the saved snapshot                                                              
-   await expect(testSvg).toMatchSvgSnapshot(import.meta.path)                                                   
- })                                                                                                                        
- 
+ </svg>`
+
+test("svg snapshot example", async () => {
+  // First run will create the snapshot
+  // Subsequent runs will compare against the saved snapshot
+  await expect(testSvg).toMatchSvgSnapshot(import.meta.path)
+})

package/.claude/settings.local.json

@@ -1,9 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(bun pm:*)"
-    ],
-    "deny": [],
-    "ask": []
-  }
-}

package/tests/plated-hole.test.ts

@@ -1,70 +0,0 @@
-import { test, expect } from "bun:test"
-import { convertCircuitJsonToLbrn } from "../lib/index"
-import type { CircuitJson } from "circuit-json"
-
-test("plated hole generates circular path", () => {
-  const circuitJson: CircuitJson = [
-    {
-      type: "pcb_board",
-      pcb_board_id: "test_board",
-      width: 100,
-      height: 100,
-      center: { x: 0, y: 0 },
-      thickness: 1.6,
-      num_layers: 2,
-      material: "fr4",
-    },
-    {
-      type: "pcb_plated_hole",
-      shape: "circle",
-      pcb_plated_hole_id: "test_hole",
-      outer_diameter: 2,
-      hole_diameter: 1,
-      x: 10,
-      y: 20,
-      layers: ["top"],
-    },
-  ]
-
-  const project = convertCircuitJsonToLbrn(circuitJson)
-
-  // Should have 1 CutSetting and 1 ShapePath
-  expect(project.children.length).toBe(2)
-
-  // First child should be CutSetting
-  const cutSetting = project.children.find(
-    (child) => child.token === "CutSetting",
-  )!
-  expect(cutSetting.token).toBe("CutSetting")
-
-  // Second child should be ShapePath (the plated hole)
-  const shapePath = project.children.find(
-    (child) => child.token === "Shape.Path",
-  )!
-  expect(shapePath.token).toBe("Shape.Path")
-
-  // Verify the shape path has the expected properties
-  if (shapePath.token === "Shape.Path") {
-    expect((shapePath as any).isClosed).toBe(true)
-    expect((shapePath as any).cutIndex).toBe(0)
-    expect((shapePath as any).verts).toBeDefined()
-    expect((shapePath as any).prims).toBeDefined()
-
-    // Should have 5 vertices (4 bezier curve points + 1 to close)
-    const vertsLength = (shapePath as any).verts?.length
-    const primsLength = (shapePath as any).prims?.length
-    expect(vertsLength).toBe(5)
-    expect(primsLength).toBe(4)
-
-    // Verify all primitives are bezier curves
-    const prims = (shapePath as any).prims || []
-    for (const prim of prims) {
-      expect(prim.type).toBe(1) // 1 = BezierTo
-    }
-
-    // Verify the circle is centered at (10, 20) with radius 1
-    const firstVert = (shapePath as any).verts?.[0]
-    expect(firstVert?.x).toBeCloseTo(11, 5) // 10 + 1 (radius)
-    expect(firstVert?.y).toBeCloseTo(20, 5)
-  }
-})