circle-ir 3.51.0 → 3.53.0

package/configs/sinks/path.yaml

@@ -668,22 +668,6 @@
       "arg_positions": [0],
       "note": "Unzip operation - zip slip"
     },
-    {
-      "method": "getPath",
-      "class": "ZipEntry",
-      "type": "path_traversal",
-      "cwe": "CWE-022",
-      "severity": "high",
-      "note": "Zip entry path - may contain ../"
-    },
-    {
-      "method": "getName",
-      "class": "ZipEntry",
-      "type": "path_traversal",
-      "cwe": "CWE-022",
-      "severity": "high",
-      "note": "Zip entry name - may contain ../"
-    },
     {
       "method": "getEnvironment",
       "class": "ConfigServicePropertySourceLocator",

package/configs/sources/file_sources.yaml

@@ -144,6 +144,38 @@
       "return_tainted": true,
       "note": "File content as InputStream"
     },
+    {
+      "method": "getName",
+      "class": "ZipEntry",
+      "type": "file_input",
+      "severity": "high",
+      "return_tainted": true,
+      "note": "Zip entry name - may contain ../ (Zip-Slip CWE-22, issue #52)"
+    },
+    {
+      "method": "getName",
+      "class": "ZipArchiveEntry",
+      "type": "file_input",
+      "severity": "high",
+      "return_tainted": true,
+      "note": "Apache Commons Compress zip entry name - may contain ../ (Zip-Slip)"
+    },
+    {
+      "method": "getName",
+      "class": "TarArchiveEntry",
+      "type": "file_input",
+      "severity": "high",
+      "return_tainted": true,
+      "note": "Apache Commons Compress tar entry name - may contain ../ (Tar-Slip)"
+    },
+    {
+      "method": "getName",
+      "class": "ArchiveEntry",
+      "type": "file_input",
+      "severity": "high",
+      "return_tainted": true,
+      "note": "Generic archive entry name - may contain ../ (Zip/Tar-Slip)"
+    },
     {
       "method": "getProperty",
       "class": "Properties",

package/dist/analysis/config-loader.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"config-loader.d.ts","sourceRoot":"","sources":["../../src/analysis/config-loader.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,KAAK,EACV,YAAY,EACZ,UAAU,EACV,WAAW,EACX,aAAa,EACb,WAAW,EACX,gBAAgB,EAChB,UAAU,EACX,MAAM,oBAAoB,CAAC;AAE5B;;;GAGG;AACH,wBAAgB,WAAW,CAAC,CAAC,EAAE,OAAO,EAAE,MAAM,GAAG,CAAC,CAEjD;AAED;;GAEG;AACH,wBAAgB,iBAAiB,CAAC,OAAO,EAAE,YAAY,EAAE,GAAG,aAAa,EAAE,CAiB1E;AAED;;GAEG;AACH,wBAAgB,eAAe,CAAC,OAAO,EAAE,UAAU,EAAE,GAAG;IACtD,KAAK,EAAE,WAAW,EAAE,CAAC;IACrB,UAAU,EAAE,gBAAgB,EAAE,CAAC;CAChC,CAcA;AAED;;GAEG;AACH,wBAAgB,iBAAiB,CAC/B,cAAc,EAAE,MAAM,EAAE,EACxB,YAAY,EAAE,MAAM,EAAE,GACrB,WAAW,CAQb;AAED;;;GAGG;AACH,eAAO,MAAM,eAAe,EAAE,aAAa,EA4a1C,CAAC;AAEF,eAAO,MAAM,aAAa,EAAE,WAAW,EA4xCtC,CAAC;AAEF,eAAO,MAAM,kBAAkB,EAAE,gBAAgB,EAoMhD,CAAC;AAEF;;GAEG;AACH,wBAAgB,gBAAgB,IAAI,WAAW,CAM9C;AAMD;;;;;;;;GAQG;AACH,eAAO,MAAM,oBAAoB,EAAE,UAAU,EA8F5C,CAAC"}
+{"version":3,"file":"config-loader.d.ts","sourceRoot":"","sources":["../../src/analysis/config-loader.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,KAAK,EACV,YAAY,EACZ,UAAU,EACV,WAAW,EACX,aAAa,EACb,WAAW,EACX,gBAAgB,EAChB,UAAU,EACX,MAAM,oBAAoB,CAAC;AAE5B;;;GAGG;AACH,wBAAgB,WAAW,CAAC,CAAC,EAAE,OAAO,EAAE,MAAM,GAAG,CAAC,CAEjD;AAED;;GAEG;AACH,wBAAgB,iBAAiB,CAAC,OAAO,EAAE,YAAY,EAAE,GAAG,aAAa,EAAE,CAiB1E;AAED;;GAEG;AACH,wBAAgB,eAAe,CAAC,OAAO,EAAE,UAAU,EAAE,GAAG;IACtD,KAAK,EAAE,WAAW,EAAE,CAAC;IACrB,UAAU,EAAE,gBAAgB,EAAE,CAAC;CAChC,CAcA;AAED;;GAEG;AACH,wBAAgB,iBAAiB,CAC/B,cAAc,EAAE,MAAM,EAAE,EACxB,YAAY,EAAE,MAAM,EAAE,GACrB,WAAW,CAQb;AAED;;;GAGG;AACH,eAAO,MAAM,eAAe,EAAE,aAAa,EAob1C,CAAC;AAEF,eAAO,MAAM,aAAa,EAAE,WAAW,EA8wCtC,CAAC;AAEF,eAAO,MAAM,kBAAkB,EAAE,gBAAgB,EAoMhD,CAAC;AAEF;;GAEG;AACH,wBAAgB,gBAAgB,IAAI,WAAW,CAM9C;AAMD;;;;;;;;GAQG;AACH,eAAO,MAAM,oBAAoB,EAAE,UAAU,EA8F5C,CAAC"}

package/dist/analysis/config-loader.js

@@ -176,6 +176,13 @@ export const DEFAULT_SOURCES = [
     { method: 'getFileName', class: 'BodyPart', type: 'file_input', severity: 'high', return_tainted: true },
     { method: 'getFileName', class: 'MimeBodyPart', type: 'file_input', severity: 'high', return_tainted: true },
     { method: 'getDisposition', class: 'Part', type: 'file_input', severity: 'medium', return_tainted: true },
+    // Archive entry names (Zip-Slip / Tar-Slip CWE-22, issue #52)
+    // entry.getName() returns a path that may contain ../ — flowing into File()/FileOutputStream()
+    // is a classic Zip-Slip vulnerability.
+    { method: 'getName', class: 'ZipEntry', type: 'file_input', severity: 'high', return_tainted: true },
+    { method: 'getName', class: 'ZipArchiveEntry', type: 'file_input', severity: 'high', return_tainted: true },
+    { method: 'getName', class: 'TarArchiveEntry', type: 'file_input', severity: 'high', return_tainted: true },
+    { method: 'getName', class: 'ArchiveEntry', type: 'file_input', severity: 'high', return_tainted: true },
     // Command line arguments
     { method: 'getArgs', type: 'io_input', severity: 'high', return_tainted: true },
     { method: 'getOptionValue', class: 'CommandLine', type: 'io_input', severity: 'high', return_tainted: true },
@@ -610,7 +617,7 @@ export const DEFAULT_SINKS = [
     { method: 'staticFileLocation', type: 'path_traversal', cwe: 'CWE-22', severity: 'high', arg_positions: [0] },
     // Zip/archive handling
     { method: 'getEntry', class: 'ZipFile', type: 'path_traversal', cwe: 'CWE-22', severity: 'high', arg_positions: [0] },
-    { method: 'getName', class: 'ZipEntry', type: 'path_traversal', cwe: 'CWE-22', severity: 'high', arg_positions: [] },
+    // ZipEntry.getName moved to file_sources.yaml as a taint SOURCE (type=archive_entry, issue #52)
     // Resource loading classes (various frameworks)
     { method: 'ClassPathResource', class: 'constructor', type: 'path_traversal', cwe: 'CWE-22', severity: 'high', arg_positions: [0] },
     { method: 'FileSystemResource', class: 'constructor', type: 'path_traversal', cwe: 'CWE-22', severity: 'high', arg_positions: [0] },
@@ -1086,26 +1093,16 @@ export const DEFAULT_SINKS = [
     { method: 'get', class: 'WebClient', type: 'ssrf', cwe: 'CWE-918', severity: 'high', arg_positions: [] },
     { method: 'post', class: 'WebClient', type: 'ssrf', cwe: 'CWE-918', severity: 'high', arg_positions: [] },
     // =============================================================================
-    // Weak Cryptography Sinks (no taint flow required - presence alone is vulnerability)
+    // Config / Absence Vulnerabilities (handled by dedicated pattern passes)
     // =============================================================================
-    // Weak Random (CWE-330) - java.util.Random is not cryptographically secure
-    { method: 'Random', class: 'constructor', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    { method: 'nextInt', class: 'Random', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    { method: 'nextLong', class: 'Random', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    { method: 'nextFloat', class: 'Random', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    { method: 'nextDouble', class: 'Random', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    { method: 'nextBoolean', class: 'Random', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    { method: 'nextBytes', class: 'Random', type: 'weak_random', cwe: 'CWE-330', severity: 'medium', arg_positions: [] },
-    // Weak Hash (CWE-328) - MD5/SHA1 are cryptographically broken
-    // Note: Detection requires checking algorithm argument - handled in runner
-    { method: 'getInstance', class: 'MessageDigest', type: 'weak_hash', cwe: 'CWE-328', severity: 'medium', arg_positions: [0] },
-    // Weak Crypto (CWE-327) - DES/RC4/Blowfish are weak ciphers
-    // Note: Detection requires checking algorithm argument - handled in runner
-    { method: 'getInstance', class: 'Cipher', type: 'weak_crypto', cwe: 'CWE-327', severity: 'high', arg_positions: [0] },
-    { method: 'getInstance', class: 'KeyGenerator', type: 'weak_crypto', cwe: 'CWE-327', severity: 'high', arg_positions: [0] },
-    // Insecure Cookie (CWE-614) - cookies without secure/httpOnly flags
-    // Note: Detection requires checking if setSecure(true)/setHttpOnly(true) called - handled in runner
-    { method: 'Cookie', class: 'constructor', type: 'insecure_cookie', cwe: 'CWE-614', severity: 'medium', arg_positions: [] },
+    // weak_random  → WeakRandomPass        (src/analysis/passes/weak-random-pass.ts)
+    // weak_hash    → WeakHashPass          (src/analysis/passes/weak-hash-pass.ts)
+    // weak_crypto  → WeakCryptoPass        (src/analysis/passes/weak-crypto-pass.ts)
+    // insecure_cookie → InsecureCookiePass (src/analysis/passes/insecure-cookie-pass.ts)
+    // tls_verify_disabled → TlsVerifyDisabledPass
+    // These patterns are detected by call-site literal inspection, not taint flow,
+    // so they are NOT registered here as sinks (they could never match a "tainted
+    // value flowing into a sink" because the bad value is a hard-coded constant).
     // Trust Boundary (CWE-501) - using untrusted data as session attribute NAME
     // The vulnerability is attacker controlling which key to use, not the value
     { method: 'setAttribute', class: 'HttpSession', type: 'trust_boundary', cwe: 'CWE-501', severity: 'medium', arg_positions: [0] },