cicy-desktop 2.1.335 → 2.1.336

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cicy-desktop",
-  "version": "2.1.335",
+  "version": "2.1.336",
   "description": "CiCy - AI-powered operating system browser",
   "main": "src/main.js",
   "bin": {

package/src/app-updater.js

@@ -340,11 +340,40 @@ async function downloadUpdate() {
 
 // 用户点「安装」:拉起原生安装器(win NSIS / mac pkg)并退出 app;linux AppImage 在
 // 文件管理器里定位(AppImage 非安装器,用户自行替换运行)。
+// Windows install + relaunch, as ONE detached chain.
+//
+// shell.openPath() ran the NSIS installer INTERACTIVELY: on a machine with
+// nobody at the keyboard that is a wizard waiting forever for a click, and even
+// when it did install, nothing started the app again — NSIS runAfterFinish does
+// not fire on a /S install. Both together are why an unattended node that took
+// an update simply never came back; it had to be started by hand, and a headless
+// box has no hand. Observed on most of the fleet.
+//
+// So: /S for the install, and we own the relaunch. The chain is detached and in
+// its own process group, so it outlives the app the installer is about to kill;
+// cmd waits for the installer (no `start` on that leg), then gives Windows a
+// moment to release the files before launching the new exe hidden.
+function installWindows(installer) {
+  const { spawn } = require("child_process");
+  const exe = process.execPath;
+  const chain = `"${installer}" /S & timeout /t 20 /nobreak >nul & start "" "${exe}" --hidden`;
+  const ch = spawn(process.env.COMSPEC || "cmd.exe", ["/c", chain], {
+    detached: true,
+    stdio: "ignore",
+    windowsHide: true,
+  });
+  ch.unref();
+  log.info(`[app-updater] silent install + relaunch chain started (pid ${ch.pid})`);
+  // Quit so the installer can replace the files it is about to overwrite.
+  setTimeout(() => { try { app.quit(); } catch {} }, 1500);
+}
+
 function installNow() {
   const f = _state.filePath;
   if (!f) return;
   try {
     if (process.platform === "linux") { shell.showItemInFolder(f); return; }
+    if (process.platform === "win32") { installWindows(f); return; }
     shell.openPath(f).then((err) => {
       if (err) log.warn("[app-updater] openPath failed:", err);
       else setTimeout(() => { try { app.quit(); } catch {} }, 800);

package/test/app-updater-install-relaunch.test.js

@@ -0,0 +1,59 @@
+// Copyright 2026 CiCy AI
+// SPDX-License-Identifier: Apache-2.0
+
+// installNow() used shell.openPath() on the NSIS installer. On a machine with
+// nobody at the keyboard that is an interactive wizard waiting forever for a
+// click; and even when it did install, nothing started the app again, because
+// NSIS runAfterFinish does not fire on a /S install. Both together are why an
+// unattended node that took an update never came back — observed across most of
+// the fleet, each box needing a manual start.
+const test = require("node:test");
+const assert = require("node:assert/strict");
+const fs = require("node:fs");
+const path = require("node:path");
+
+const src = fs.readFileSync(path.join(__dirname, "..", "src", "app-updater.js"), "utf8");
+const win = src.slice(src.indexOf("function installWindows"), src.indexOf("function installNow"));
+
+test("windows installs silently instead of opening a wizard nobody can click", () => {
+  assert.match(win, /"\$\{installer\}" \/S/);
+  const now = src.slice(src.indexOf("function installNow"), src.indexOf("module.exports"));
+  assert.match(now, /if \(process\.platform === "win32"\) \{ installWindows\(f\); return; \}/);
+  // the interactive path must no longer be what Windows takes
+  assert.ok(
+    now.indexOf('process.platform === "win32"') < now.indexOf("shell.openPath"),
+    "win32 must be handled before the openPath fallback"
+  );
+});
+
+test("the relaunch is part of the same detached chain, so it outlives the app", () => {
+  // The installer kills this process; a child in this process group would die
+  // with it and the machine would stay down.
+  assert.match(win, /detached: true/);
+  assert.match(win, /ch\.unref\(\)/);
+  assert.match(win, /start "" "\$\{exe\}" --hidden/);
+  assert.match(win, /windowsHide: true/);
+});
+
+test("the chain waits for the installer before relaunching", () => {
+  // No `start` on the installer leg → cmd blocks on it; then a pause so Windows
+  // releases the replaced files before the new exe runs.
+  assert.doesNotMatch(win, /start "" "\$\{installer\}"/);
+  assert.match(win, /timeout \/t 20 \/nobreak/);
+  const order = [win.indexOf("/S"), win.indexOf("timeout /t"), win.indexOf('start "" "${exe}"')];
+  assert.ok(order[0] < order[1] && order[1] < order[2], "install → wait → relaunch, in that order");
+});
+
+test("the app quits so the installer can replace its files", () => {
+  assert.match(win, /app\.quit\(\)/);
+  assert.match(win, /setTimeout\(\(\) => \{ try \{ app\.quit\(\); \} catch \{\} \}, 1500\)/);
+});
+
+test("mac and linux keep their existing behaviour", () => {
+  const now = src.slice(src.indexOf("function installNow"), src.indexOf("module.exports"));
+  assert.match(
+    now,
+    /if \(process\.platform === "linux"\) \{ shell\.showItemInFolder\(f\); return; \}/
+  );
+  assert.match(now, /shell\.openPath\(f\)/); // mac pkg still opens the GUI installer
+});