cht-conf 3.9.4 → 3.9.5

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [3.9.5](https://github.com/medic/cht-conf/compare/v3.9.4...v3.9.5) (2022-01-30)
+
+
+### Bug Fixes
+
+* **#458:** return non-zero code when exiting with failure ([516bff0](https://github.com/medic/cht-conf/commit/516bff0eabec2d3c13a16a994212280d77358c7e)), closes [#458](https://github.com/medic/cht-conf/issues/458)
+
 ## [3.9.4](https://github.com/medic/cht-conf/compare/v3.9.3...v3.9.4) (2022-01-05)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cht-conf",
-  "version": "3.9.4",
+  "version": "3.9.5",
   "description": "Configure CHT deployments",
   "main": "./src/lib/main.js",
   "engines": {

package/src/bin/index.js

@@ -12,7 +12,7 @@ const main = require('../lib/main');
   }
   catch (e) {
     error(e);
-    returnCode = -1;
+    returnCode = 1;
   }
   finally {
     process.exit(returnCode);

package/src/fn/check-git.js

@@ -18,7 +18,7 @@ module.exports = {
         warn('Changes untracked or to be committed:\n' + status);
         if (!userPrompt.keyInYN('Are you sure you want to continue?')) {
           error('User failed to confirm action.');
-          process.exit(-1);
+          process.exit(1);
         }
       }
       info('Fetching git upstream...');
@@ -27,7 +27,7 @@ module.exports = {
         warn(syncStatus);
         if (!userPrompt.keyInYN('Are you sure you want to continue?')) {
           error('User failed to confirm action.');
-          process.exit(-1);
+          process.exit(1);
         }
       }
     }

package/src/fn/move-contacts.js

@@ -126,7 +126,7 @@ const prepareDocumentDirectory = ({ docDirectoryPath, force }) => {
       fs.deleteFilesInFolder(docDirectoryPath);
     } else {
       error('User failed to confirm action.');
-      process.exit(-1);
+      process.exit(1);
     }
   }
 };

package/src/fn/upload-custom-translations.js

@@ -66,7 +66,7 @@ const execute = async () => {
           errMsg += '\nYou can use messages-ex.properties to add placeholders missing from the reference context.';
         }
         log.error(errMsg);
-        return process.exit(-1);
+        return process.exit(1);
       }
     } else {
       throw err;
@@ -78,7 +78,7 @@ const execute = async () => {
     const languageCode = id.substring('messages-'.length);
     if (!isLanguageCodeValid(languageCode)) {
       log.error(`The language code '${languageCode}' is not valid. It must begin with a letter(a–z, A-Z), followed by any number of hyphens, underscores, letters, or numbers.`);
-      return process.exit(-1);
+      return process.exit(1);
     }
 
     let languageName = iso639.getName(languageCode);

package/src/lib/main.js

@@ -57,7 +57,7 @@ module.exports = async (argv, env) => {
 
   if(argv.length <= 2) {
     usage(0);
-    return -1;
+    return 1;
   }
 
   const cmdArgs = require('minimist')(argv.slice(2), {
@@ -94,7 +94,7 @@ module.exports = async (argv, env) => {
 
   if (cmdArgs.archive && !cmdArgs.destination) {
     error('--destination=<path to save files> is required with --archive.');
-    return -1;
+    return 1;
   }
 
   if (cmdArgs['accept-self-signed-certs']) {
@@ -131,7 +131,7 @@ module.exports = async (argv, env) => {
   const unsupported = actions.filter(a => !supportedActions.includes(a));
   if(unsupported.length) {
     error(`Unsupported action(s): ${unsupported.join(' ')}`);
-    return -1;
+    return 1;
   }
 
   if (cmdArgs['skip-git-check']) {
@@ -164,7 +164,7 @@ module.exports = async (argv, env) => {
     apiUrl = getApiUrl(cmdArgs, env);
     if (!apiUrl) {
       error('Failed to obtain a url to the API');
-      return -1;
+      return 1;
     }
   }
 
@@ -184,7 +184,7 @@ module.exports = async (argv, env) => {
   );
 
   if (apiUrl && !await api().available()) {
-    return false;
+    return 1;
   }
 
   const productionUrlMatch = environment.instanceUrl && environment.instanceUrl.match(/^https:\/\/(?:[^@]*@)?(.*)\.(app|dev)\.medicmobile\.org(?:$|\/)/);
@@ -194,7 +194,7 @@ module.exports = async (argv, env) => {
         `against non-matching instance: \x1b[31m${redactBasicAuth(environment.instanceUrl)}\x1b[33m`);
     if(!userPrompt.keyInYN()) {
       error('User failed to confirm action.');
-      return false;
+      return 1;
     }
   }
 
@@ -218,6 +218,8 @@ module.exports = async (argv, env) => {
   if (actions.length > 1) {
     await info('All actions completed.');
   }
+
+  return 0;
 };
 
 // Exists for generic mocking purposes