cht-conf 3.10.2 → 3.12.0

package/.eslintignore

@@ -1 +1,2 @@
-**/build
+**/build
+test/data/**

package/.releaserc.json

@@ -18,5 +18,5 @@
       }
     ]
   ],
-  "branches": ["master"]
+  "branches": ["main"]
 }

package/CHANGELOG.md

@@ -1,3 +1,24 @@
+# [3.12.0](https://github.com/medic/cht-conf/compare/v3.11.1...v3.12.0) (2022-06-23)
+
+
+### Features
+
+* **#484:** add actions for validating forms ([f2a6a8e](https://github.com/medic/cht-conf/commit/f2a6a8ef75561426ce2a6b542cdf1a255c869c6e)), closes [#484](https://github.com/medic/cht-conf/issues/484) [#481](https://github.com/medic/cht-conf/issues/481)
+
+## [3.11.1](https://github.com/medic/cht-conf/compare/v3.11.0...v3.11.1) (2022-06-13)
+
+
+### Bug Fixes
+
+* **#482:** move-contacts usage docs ([5fa86c8](https://github.com/medic/cht-conf/commit/5fa86c8e98797d8920ee20f2e7f16c98aa969201)), closes [#482](https://github.com/medic/cht-conf/issues/482)
+
+# [3.11.0](https://github.com/medic/cht-conf/compare/v3.10.2...v3.11.0) (2022-04-19)
+
+
+### Features
+
+* **#477:** adds watch-project action ([7a3efc5](https://github.com/medic/cht-conf/commit/7a3efc5efcbd98d8a6b03e801945201ed17ac00f)), closes [#477](https://github.com/medic/cht-conf/issues/477)
+
 ## [3.10.2](https://github.com/medic/cht-conf/compare/v3.10.1...v3.10.2) (2022-03-29)
 
 
@@ -199,7 +220,7 @@ As of this release no docs on the server will be touched unless some configurati
 
 ### New action to bulk-edit contacts
 
-You can now bulk edit contacts at once by providing a CSV. For more information, read [the documentation](https://github.com/medic/cht-conf/blob/master/README.md#editing-contacts-across-the-hierarchy).
+You can now bulk edit contacts at once by providing a CSV. For more information, read [the documentation](https://github.com/medic/cht-conf/blob/main/README.md#editing-contacts-across-the-hierarchy).
 
 [#297](https://github.com/medic/cht-conf/issues/297)
 

package/README.md

@@ -317,7 +317,7 @@ Breaking| perf(#2): remove reporting rates feature <br/> BREAKING CHANGE: report
 
 ### Releasing betas
 
-1. Checkout `master`
+1. Checkout the default branch, for example `main`
 1. Run `npm version --no-git-tag-version <major>.<minor>.<patch>-beta.1`. This will only update the versions in `package.json` and `package-lock.json`. It will not create a git tag and not create an associated commit.
 1. Run `npm publish --tag beta`. This will publish your beta tag to npm's beta channel.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cht-conf",
-  "version": "3.10.2",
+  "version": "3.12.0",
   "description": "Configure CHT deployments",
   "main": "./src/lib/main.js",
   "engines": {
@@ -8,7 +8,7 @@
   },
   "scripts": {
     "clean": "rm -rf ./build/",
-    "eslint": "eslint src/**/*.js test/*.js test/**/*.js",
+    "eslint": "eslint 'src/**/*.js' test/*.js 'test/**/*.js'",
     "docker-start-couchdb": "npm run docker-stop-couchdb && docker run -d -p 6984:5984 --rm --name cht-conf-couchdb couchdb:2.3.1 && sh test/scripts/wait_for_response_code.sh 6984 200 CouchDB",
     "docker-stop-couchdb": "docker stop cht-conf-couchdb || true",
     "test": "npm run eslint && npm run docker-start-couchdb && npm run clean && mkdir -p build/test && cp -r test/data build/test/data && cd build/test && nyc --reporter=html mocha --forbid-only ../../test/**/*.spec.js && cd ../.. && npm run docker-stop-couchdb",
@@ -37,6 +37,7 @@
   "dependencies": {
     "@hapi/joi": "^16.1.8",
     "@medic/translation-checker": "^1.0.1",
+    "@parcel/watcher": "^2.0.5",
     "canonical-json": "0.0.4",
     "csv-parse": "^4.16.0",
     "dom-compare": "^0.6.0",
@@ -56,6 +57,7 @@
     "pouchdb-core": "^7.2.2",
     "pouchdb-mapreduce": "^7.2.2",
     "properties": "^1.2.1",
+    "queue-promise": "^2.2.1",
     "readline-sync": "^1.4.10",
     "redact-basic-auth": "^1.0.1",
     "request": "^2.88.2",
@@ -86,6 +88,7 @@
     "pouchdb-adapter-memory": "^7.2.2",
     "rewire": "^5.0.0",
     "semantic-release": "^18.0.0",
-    "sinon": "^7.3.2"
+    "sinon": "^7.3.2",
+    "fs-extra": "8.1.0"
   }
 }

package/release-notes.md

@@ -134,7 +134,7 @@ As of this release no docs on the server will be touched unless some configurati
 
 ### New action to bulk-edit contacts
 
-You can now bulk edit contacts at once by providing a CSV. For more information, read [the documentation](https://github.com/medic/cht-conf/blob/master/README.md#editing-contacts-across-the-hierarchy).
+You can now bulk edit contacts at once by providing a CSV. For more information, read [the documentation](https://github.com/medic/cht-conf/blob/main/README.md#editing-contacts-across-the-hierarchy).
 
 [#297](https://github.com/medic/cht-conf/issues/297)
 

package/src/cli/usage.js

@@ -63,6 +63,9 @@ ${bold('OPTIONS')}
   --skip-translation-check
     Skips checking message translations
 
+  --skip-validate
+    Skips form validation  
+
   --force
     CAN BE DANGEROUS! Passes yes to all commands and any where that would prompt to overwrite changes will overwrite automatically. 
 `);

package/src/fn/compile-app-settings.js

@@ -8,6 +8,21 @@ const parseTargets = require('../lib/parse-targets');
 const { warn } = require('../lib/log');
 const parsePurge = require('../lib/parse-purge');
 const validateAppSettings = require('../lib/validate-app-settings');
+const { APP_SETTINGS_DIR_PATH, APP_SETTINGS_JSON_PATH } = require('../lib/project-paths');
+
+// we can't used named capture groups yet
+const JS_FILE_MATCHER = /^(.+)(\.js)$/; // 2 groups get the file name and extension
+const JSON_FILE_MATCHER = /^(.+)(\.json)$/;
+const configFileMatcher = (fileName) => {
+  const jsFileMatchResult = fileName.match(JS_FILE_MATCHER);
+  // the first element is always the whole matched string, then our first file name group
+  if (jsFileMatchResult) return jsFileMatchResult[1];
+
+  const jsonFileMatchResult = fileName.match(JSON_FILE_MATCHER);
+  if (jsonFileMatchResult) return jsonFileMatchResult[1];
+
+  return null;
+};
 
 const compileAppSettings = async () => {
   const options = parseExtraArgs(environment.extraArgs);
@@ -23,7 +38,7 @@ const compileAppSettings = async () => {
     appSettings = await compileAppSettingsForProject(projectDir, options);
   }
 
-  fs.writeJson(path.join(projectDir, 'app_settings.json'), appSettings);
+  fs.writeJson(path.join(projectDir, APP_SETTINGS_JSON_PATH), appSettings);
 };
 
 const compileAppSettingsForProject = async (projectDir, options) => {
@@ -41,8 +56,8 @@ const compileAppSettingsForProject = async (projectDir, options) => {
 
   const readOptionalJson = path => fs.exists(path) ? fs.readJson(path) : undefined;
   let appSettings;
-  const baseSettingsPath = path.join(projectDir, 'app_settings/base_settings.json');
-  const appSettingsPath = path.join(projectDir, 'app_settings.json');
+  const baseSettingsPath = path.join(projectDir, `${APP_SETTINGS_DIR_PATH}/base_settings.json`);
+  const appSettingsPath = path.join(projectDir, APP_SETTINGS_JSON_PATH);
   const esLintFilePath = path.join(projectDir, '.eslintrc');
 
   // Fail if no eslintrc file is found
@@ -56,10 +71,10 @@ const compileAppSettingsForProject = async (projectDir, options) => {
   if (fs.exists(baseSettingsPath)) {
     // using modular config so should override anything already defined in app_settings.json
     appSettings = fs.readJson(baseSettingsPath);
-    if(appSettings.forms) {
+    if (appSettings.forms) {
       warn('forms should be defined in a separate <config_repo>/app_settings/forms.json file.');
     }
-    if(appSettings.schedules) {
+    if (appSettings.schedules) {
       warn('schedules should be defined in a separate <config_repo>/app_settings/schedules.json file.');
     }
     const formSettings = readOptionalJson(path.join(projectDir, 'app_settings/forms.json'));
@@ -107,7 +122,7 @@ function applyTransforms(app_settings, inherited) {
     rules.forEach(k => {
       const parts = k.split('.');
       let t = target;
-      while(parts.length > 1) {
+      while (parts.length > 1) {
         t = t[parts[0]];
         parts.shift();
       }
@@ -122,7 +137,7 @@ function applyTransforms(app_settings, inherited) {
       .forEach(k => {
         const parts = k.split('.');
         let t = target;
-        while(parts.length > 1) {
+        while (parts.length > 1) {
           t = t[parts[0]];
           parts.shift();
         }
@@ -146,7 +161,7 @@ function applyTransforms(app_settings, inherited) {
       .forEach(k => {
         const parts = k.split('.');
         let t = target;
-        while(parts.length > 1) {
+        while (parts.length > 1) {
           t = t[parts[0]];
           parts.shift();
         }
@@ -178,5 +193,7 @@ const parseExtraArgs = (extraArgs = []) => {
 
 module.exports = {
   requiresInstance: false,
+  APP_SETTINGS_DIR_PATH,
+  configFileMatcher,
   execute: compileAppSettings
 };

package/src/fn/compress-svgs.js

@@ -16,6 +16,6 @@ module.exports = {
           .then(() => svgo.optimize(fs.read(path), { path }))
           .then(result => fs.write(path, result.data))
           .then(() => trace('Compressed', path))
-          .then(() => warn('Make sure you compare the content of your SVG files before merging to the master branch - sometimes optimising can change their contents!')),
+          .then(() => warn('Make sure you compare the content of your SVG files before merging to the default branch - sometimes optimising can change their contents!')),
         Promise.resolve())
 };

package/src/fn/convert-app-forms.js

@@ -1,11 +1,18 @@
-const convertForms = require('../lib/convert-forms');
+const convertForms = require('../lib/convert-forms').execute;
 const environment = require('../lib/environment');
+const { APP_FORMS_PATH } = require('../lib/project-paths');
 
-module.exports = {
-  requiresInstance: false,
-  execute: () => convertForms(environment.pathToProject, 'app', {
+const convertAppForms = (forms) => {
+  return convertForms(environment.pathToProject, 'app', {
     enketo: true,
-    forms: environment.extraArgs,
+    forms: forms,
     transformer: xml => xml.replace('</instance>', '</instance>\n      <instance id="contact-summary"/>'),
-  })
+  });
+};
+
+module.exports = {
+  requiresInstance: false,
+  convertAppForms,
+  APP_FORMS_PATH,
+  execute: () => convertAppForms(environment.extraArgs)
 };

package/src/fn/convert-collect-forms.js

@@ -1,9 +1,16 @@
-const convertForms = require('../lib/convert-forms');
+const convertForms = require('../lib/convert-forms').execute;
 const environment = require('../lib/environment');
+const { COLLECT_FORMS_PATH } = require('../lib/project-paths');
+
+const convertCollectForms = (forms) => {
+  return convertForms(environment.pathToProject, 'collect', {
+    forms: forms,
+  });
+};
 
 module.exports = {
   requiresInstance: false,
-  execute: () => convertForms(environment.pathToProject, 'collect', {
-    forms: environment.extraArgs,
-  })
+  COLLECT_FORMS_PATH,
+  convertCollectForms,
+  execute: () => convertCollectForms(environment.extraArgs)
 };

package/src/fn/convert-contact-forms.js

@@ -1,92 +1,95 @@
-const convertForms = require('../lib/convert-forms');
+const convertForms = require('../lib/convert-forms').execute;
 const environment = require('../lib/environment');
 const fs = require('../lib/sync-fs');
+const { CONTACT_FORMS_PATH } = require('../lib/project-paths');
 
-const execute = () => {
-  const dir = `${environment.pathToProject}/forms/contact`;
+const convertContactForm = (forms) => {
+  const dir = `${environment.pathToProject}/${CONTACT_FORMS_PATH}`;
   const placeTypesJson = `${dir}/place-types.json`;
 
   let PLACE_TYPES;
-  if(fs.exists(placeTypesJson)) {
+  if (fs.exists(placeTypesJson)) {
     PLACE_TYPES = fs.readJson(placeTypesJson);
     Object.keys(PLACE_TYPES)
       .forEach(type => {
-        fs.copy(`${dir}/PLACE_TYPE-create.xlsx`, `${dir}/${type}-create.xlsx`,{ overwrite: false });
+        fs.copy(`${dir}/PLACE_TYPE-create.xlsx`, `${dir}/${type}-create.xlsx`, { overwrite: false });
         fs.copy(`${dir}/PLACE_TYPE-edit.xlsx`, `${dir}/${type}-edit.xlsx`, { overwrite: false });
       });
   }
 
   return convertForms(environment.pathToProject, 'contact', {
-      enketo: true,
-      force_data_node: 'data',
-      forms: environment.extraArgs,
-      transformer: (xml, path) => {
-        const type = path.replace(/.*\/(.*?)(-(create|edit))?\.xml/, '$1');
+    enketo: true,
+    force_data_node: 'data',
+    forms: forms,
+    transformer: (xml, path) => {
+      const type = path.replace(/.*\/(.*?)(-(create|edit))?\.xml/, '$1');
 
-        if(PLACE_TYPES) {
-          xml = xml
-              .replace(/PLACE_TYPE/g, type)
-              .replace(/PLACE_NAME/g, PLACE_TYPES[type]);
-        }
+      if (PLACE_TYPES) {
+        xml = xml
+          .replace(/PLACE_TYPE/g, type)
+          .replace(/PLACE_NAME/g, PLACE_TYPES[type]);
+      }
 
-        // The ordering of elements in the <model> has an arcane affect on the
-        // order that docs are saved in the database when processing a form.
-        // Move the main doc's element down to the bottom.
-        // For templated PLACE_TYPE forms, shifting must be done _after_ templating.
-        if(xml.includes('</inputs>')) {
-          let matchedBlock;
-          const matcher = new RegExp(`\\s*<${type}>[\\s\\S]*</${type}>\\s*(\\r|\\n)`);
+      // The ordering of elements in the <model> has an arcane affect on the
+      // order that docs are saved in the database when processing a form.
+      // Move the main doc's element down to the bottom.
+      // For templated PLACE_TYPE forms, shifting must be done _after_ templating.
+      if (xml.includes('</inputs>')) {
+        let matchedBlock;
+        const matcher = new RegExp(`\\s*<${type}>[\\s\\S]*</${type}>\\s*(\\r|\\n)`);
 
-          xml = xml.replace(matcher, match => {
-            matchedBlock = match;
-            return '\n';
-          });
+        xml = xml.replace(matcher, match => {
+          matchedBlock = match;
+          return '\n';
+        });
 
-          if(matchedBlock) {
-            xml = xml.replace(/<\/inputs>(\r|\n)/, '</inputs>' + matchedBlock);
-          }
+        if (matchedBlock) {
+          xml = xml.replace(/<\/inputs>(\r|\n)/, '</inputs>' + matchedBlock);
         }
+      }
 
-        if(xml.includes('/data/init/custom_place_name')) {
-          let matchedBlock;
-          xml = xml.replace(/\s*<input ref="\/data\/init\/custom_place_name">[^]*?<\/input>/, match => {
-            matchedBlock = match;
-            return '';
-          });
+      if (xml.includes('/data/init/custom_place_name')) {
+        let matchedBlock;
+        xml = xml.replace(/\s*<input ref="\/data\/init\/custom_place_name">[^]*?<\/input>/, match => {
+          matchedBlock = match;
+          return '';
+        });
 
-          if(matchedBlock) {
-            const targetMatcher = new RegExp(`\\s*<input ref="/data/${type}/external_id">\\s*(\\r|\\n)`);
-            xml = xml.replace(targetMatcher, match => matchedBlock + match);
-          }
+        if (matchedBlock) {
+          const targetMatcher = new RegExp(`\\s*<input ref="/data/${type}/external_id">\\s*(\\r|\\n)`);
+          xml = xml.replace(targetMatcher, match => matchedBlock + match);
         }
+      }
 
-        if(xml.includes('ref="/data/contact"')) {
-          const groupRegex = name => new RegExp(`(\\s*)<group(\\s.*)?\\sref="${name}"(\\s.*)?>[^]*?</group>`);
-          let matchedBlock;
+      if (xml.includes('ref="/data/contact"')) {
+        const groupRegex = name => new RegExp(`(\\s*)<group(\\s.*)?\\sref="${name}"(\\s.*)?>[^]*?</group>`);
+        let matchedBlock;
 
-          if(xml.match(groupRegex('/data/init'))) {
-            xml = xml.replace(groupRegex('/data/contact'), match => {
-              matchedBlock = match;
-              return '';
-            });
+        if (xml.match(groupRegex('/data/init'))) {
+          xml = xml.replace(groupRegex('/data/contact'), match => {
+            matchedBlock = match;
+            return '';
+          });
 
-            if(matchedBlock) {
-              const stripTrailingGroup = s => s.replace(/[\r\n\s]*<\/group>$/, '');
-              xml = xml.replace(groupRegex('/data/init'), match => {
-                return stripTrailingGroup(match) +
-                       stripTrailingGroup(matchedBlock).replace(/\n/g, '\n  ') +
-                       '\n        </group>\n      </group>';
-              });
-            }
+          if (matchedBlock) {
+            const stripTrailingGroup = s => s.replace(/[\r\n\s]*<\/group>$/, '');
+            xml = xml.replace(groupRegex('/data/init'), match => {
+              return stripTrailingGroup(match) +
+                stripTrailingGroup(matchedBlock).replace(/\n/g, '\n  ') +
+                '\n        </group>\n      </group>';
+            });
           }
         }
+      }
 
-        return xml;
-      },
-    });
+      return xml;
+    },
+  });
 };
 
 module.exports = {
   requiresInstance: false,
-  execute
+  convertContactForm,
+  CONTACT_FORMS_PATH,
+  execute: () => convertContactForm(environment.extraArgs)
 };

package/src/fn/delete-forms.js

@@ -2,22 +2,23 @@ const environment = require('../lib/environment');
 const { info, warn } = require('../lib/log');
 const pouch = require('../lib/db');
 
+const deleteForms = (forms) => {
+  if (!forms || !forms.length) {
+    warn('No forms specified for deleting.');
+    return;
+  }
+  const db = pouch();
+  return Promise.all(forms.map(formName => {
+    const docId = `form:${formName}`;
+    return db.get(docId)
+      .then(doc => db.remove(doc))
+      .then(() => info('Deleted form:', formName))
+      .catch(e => warn(`Failed to remove form with doc ID ${docId}`, e));
+  }));
+};
+
 module.exports = {
   requiresInstance: true,
-  execute: () => {
-    const db = pouch();
-    const { extraArgs } = environment;
-    if (!extraArgs || !extraArgs.length) {
-      warn('No forms specified for deleting.');
-      return;
-    }
-
-    return Promise.all(extraArgs.map(formName => {
-      const docId = `form:${formName}`;
-      return db.get(docId)
-        .then(doc => db.remove(doc))
-        .then(() => info('Deleted form:', formName))
-        .catch(e => warn(`Failed to remove form with doc ID ${docId}`, e));
-    }));
-  }
+  execute: () => deleteForms(environment.extraArgs),
+  deleteForms,
 };

package/src/fn/move-contacts.js

@@ -101,7 +101,7 @@ const parseExtraArgs = (projectDir, extraArgs = []) => {
 
   if (contactIds.length === 0) {
     usage();
-    throw Error('Action "move-contacts" is missing required list of contact_id to be moved');
+    throw Error('Action "move-contacts" is missing required list of contacts to be moved');
   }
 
   if (!args.parent) {
@@ -137,7 +137,7 @@ ${bold('cht-conf\'s move-contacts action')}
 When combined with 'upload-docs' this action effectively moves a contact from one place in the hierarchy to another.
 
 ${bold('USAGE')}
-cht --local move-contacts -- --contactIds=<id1>,<id2> --parent=<parent_id>
+cht --local move-contacts -- --contacts=<id1>,<id2> --parent=<parent_id>
 
 ${bold('OPTIONS')}
 --contacts=<id1>,<id2>

package/src/fn/upload-app-forms.js

@@ -1,9 +1,16 @@
 const environment = require('../lib/environment');
-const uploadForms = require('../lib/upload-forms');
+const uploadForms = require('../lib/upload-forms').execute;
+const { APP_FORMS_PATH } = require('../lib/project-paths');
+
+const uploadAppForms = (forms) => {
+  return uploadForms(environment.pathToProject, 'app', {
+    forms: forms,
+  });
+};
 
 module.exports = {
   requiresInstance: true,
-  execute: () => uploadForms(environment.pathToProject, 'app', {
-    forms: environment.extraArgs,
-  })
+  uploadAppForms,
+  APP_FORMS_PATH: APP_FORMS_PATH,
+  execute: () => uploadAppForms(environment.extraArgs)
 };

package/src/fn/upload-app-settings.js

@@ -2,29 +2,35 @@ const api = require('../lib/api');
 const environment = require('../lib/environment');
 const fs = require('../lib/sync-fs');
 const { info } = require('../lib/log');
+const { APP_SETTINGS_DIR_PATH, APP_SETTINGS_JSON_PATH } = require('../lib/project-paths');
 
-module.exports = {
-  requiresInstance: true,
-  execute: () => {
-    const settings = fs.read(`${environment.pathToProject}/app_settings.json`);
-    return api().updateAppSettings(settings)
-      .then(JSON.parse)
-      .then(json => {
-        // As per https://github.com/medic/cht-core/issues/3674, this endpoint
-        // will return 200 even when upload fails.
-        if (!json.success) {
-          throw new Error(json.error);
-        }
+const uploadAppSettings = (api) => {
+  const settings = fs.read(`${environment.pathToProject}/${APP_SETTINGS_JSON_PATH}`);
+  return api.updateAppSettings(settings)
+    .then(JSON.parse)
+    .then(json => {
+      // As per https://github.com/medic/cht-core/issues/3674, this endpoint
+      // will return 200 even when upload fails.
+      if (!json.success) {
+        throw new Error(json.error);
+      }
 
-        if ('updated' in json) {
-          // the `updated` param was added in 3.9
-          // https://github.com/medic/cht-core/issues/6315
-          if (!json.updated) {
-            info('Settings not updated - no changes detected');
-          } else {
-            info('Settings updated successfully');
-          }
+      if ('updated' in json) {
+        // the `updated` param was added in 3.9
+        // https://github.com/medic/cht-core/issues/6315
+        if (!json.updated) {
+          info('Settings not updated - no changes detected');
+        } else {
+          info('Settings updated successfully');
         }
-      });
-  }
+      }
+    });
+};
+
+module.exports = {
+  uploadAppSettings,
+  APP_SETTINGS_DIR_PATH,
+  APP_SETTINGS_JSON_PATH,
+  requiresInstance: true,
+  execute: () => uploadAppSettings(api())
 };

package/src/fn/upload-collect-forms.js

@@ -1,10 +1,15 @@
 const environment = require('../lib/environment');
-const uploadForms = require('../lib/upload-forms');
+const uploadForms = require('../lib/upload-forms').execute;
+
+const uploadCollectForms = (forms) => {
+  return uploadForms(environment.pathToProject, 'collect', {
+    forms: forms,
+    default_context: { collect: true },
+  });
+};
 
 module.exports = {
   requiresInstance: true,
-  execute: () => uploadForms(environment.pathToProject, 'collect', {
-    forms: environment.extraArgs,
-    default_context: { collect:true },
-  })
+  uploadCollectForms,
+  execute: () => uploadCollectForms(environment.extraArgs)
 };

package/src/fn/upload-contact-forms.js

@@ -1,11 +1,18 @@
 const environment = require('../lib/environment');
-const uploadForms = require('../lib/upload-forms');
+const uploadForms = require('../lib/upload-forms').execute;
+const CONTACT_FORMS_PATH = require('../lib/project-paths');
+
+const uploadContactForms = (forms) => {
+  return uploadForms(environment.pathToProject, 'contact', {
+    id_prefix: 'contact:',
+    forms: forms,
+    default_context: { person: false, place: false },
+  });
+};
 
 module.exports = {
   requiresInstance: true,
-  execute: () => uploadForms(environment.pathToProject, 'contact', {
-    id_prefix: 'contact:',
-    forms: environment.extraArgs,
-    default_context: { person:false, place:false },
-  })
+  uploadContactForms,
+  CONTACT_FORMS_PATH,
+  execute: () => uploadContactForms(environment.extraArgs)
 };

package/src/fn/upload-custom-translations.js

@@ -13,10 +13,12 @@ const {
   TranslationException
 } = require('@medic/translation-checker');
 
+const { TRANSLATIONS_DIR_PATH } = require('../lib/project-paths');
+
 const execute = async () => {
   const db = pouch(environment.apiUrl);
 
-  const dir = `${environment.pathToProject}/translations`;
+  const dir = `${environment.pathToProject}/${TRANSLATIONS_DIR_PATH}`;
 
   let fileNames;
   let formatErrorsFound = 0;
@@ -85,7 +87,7 @@ const execute = async () => {
       languageName = 'TODO: please ask admin to set this in settings UI';
     } else {
       let languageNativeName = iso639.getNativeName(languageCode);
-      if (languageNativeName !== languageName){
+      if (languageNativeName !== languageName) {
         languageName = `${languageNativeName} (${languageName})`;
       }
     }
@@ -95,7 +97,7 @@ const execute = async () => {
     let doc;
     try {
       doc = await db.get(id);
-    } catch(e) {
+    } catch (e) {
       if (e.status === 404) {
         doc = await newDocFor(fileName, db, languageName, languageCode);
       }
@@ -127,7 +129,7 @@ function parse(filePath, options) {
 }
 
 function overwriteProperties(doc, props) {
-  if(doc.generic) {
+  if (doc.generic) {
     // 3.4.0 translation structure
     doc.custom = props;
   } else if (doc.values) {
@@ -179,5 +181,6 @@ async function genericTranslationsStructure(db) {
 
 module.exports = {
   requiresInstance: true,
+  TRANSLATIONS_DIR_PATH,
   execute
 };