chrometools-mcp 2.4.2 → 3.1.2

package/recorder/scenario-executor.js

@@ -159,10 +159,22 @@ async function executeSingleScenario(scenario, page, params = {}, options = {})
   };
 
   try {
-    for (const action of scenario.chain) {
+    for (let i = 0; i < scenario.chain.length; i++) {
+      const action = scenario.chain[i];
+
       // Substitute parameters in action
       const resolvedAction = substituteParameters(action, params);
 
+      // Special handling for openTab with empty URL: look ahead to next action's URL
+      if (resolvedAction.type === 'openTab' && (!resolvedAction.data.url || resolvedAction.data.url === '')) {
+        const nextAction = scenario.chain[i + 1];
+        if (nextAction && nextAction.tabUrl && nextAction.tabUrl !== '') {
+          // Next action has a real URL, use it for openTab
+          debugLog(`[Executor] openTab has empty URL, using next action's URL: ${nextAction.tabUrl}`);
+          resolvedAction.data.url = nextAction.tabUrl;
+        }
+      }
+
       // Execute action with retry
       const actionResult = await executeActionWithRetry(
         resolvedAction,
@@ -178,6 +190,11 @@ async function executeSingleScenario(scenario, page, params = {}, options = {})
         return result;
       }
 
+      // Update page if action returned a new page (e.g., openTab switched tabs)
+      if (actionResult.page) {
+        page = actionResult.page;
+      }
+
       // Store outputs if action produces any
       if (actionResult.output) {
         Object.assign(result.outputs, actionResult.output);
@@ -270,6 +287,7 @@ async function executeActionWithRetry(action, page, maxRetries, timeout) {
 
       result.success = true;
       result.output = actionResult.output;
+      result.page = actionResult.page; // Pass through the updated page
       attemptInfo.success = true;
       result.errorDetails.attempts.push(attemptInfo);
       return result;
@@ -491,7 +509,7 @@ function formatDetailedError(action, errorDetails) {
  * Execute single action
  */
 async function executeAction(action, page, timeout) {
-  const result = { output: null };
+  const result = { output: null, page: page }; // Return page in result
 
   switch (action.type) {
     case 'click':
@@ -538,6 +556,14 @@ async function executeAction(action, page, timeout) {
       result.output = await executeExtract(action, page);
       break;
 
+    case 'openTab':
+      // openTab may return a new page to switch to
+      const newPage = await executeOpenTab(action, page, timeout);
+      if (newPage) {
+        result.page = newPage;
+      }
+      break;
+
     default:
       throw new Error(`Unknown action type: ${action.type}`);
   }
@@ -948,6 +974,58 @@ function substituteParameters(action, params) {
   return resolved;
 }
 
+/**
+ * Open a tab with URL and optionally switch to it
+ * This ensures the tab exists during playback
+ */
+async function executeOpenTab(action, page, timeout) {
+  const { url, switchToTab } = action.data;
+
+  // Skip openTab actions with empty URL or about:blank (after look-ahead failed to find URL)
+  if (!url || url === '' || url === 'about:blank') {
+    debugLog(`[openTab] Skipping empty/blank tab switch - keeping current page`);
+    return null; // Don't switch, keep current page
+  }
+
+  // Wait for previous tab's processes to complete before switching
+  // This prevents issues with pending navigations, AJAX calls, or form submissions
+  debugLog(`[openTab] Waiting 500ms for previous tab to settle...`);
+  await new Promise(resolve => setTimeout(resolve, 500));
+
+  debugLog(`[openTab] Opening tab: ${url}, switchToTab: ${switchToTab}`);
+
+  // Get browser instance
+  const browser = page.browser();
+
+  // Check if tab with this URL already exists
+  const pages = await browser.pages();
+  let targetPage = pages.find(p => p.url() === url);
+
+  if (targetPage) {
+    // Tab already exists, just switch to it
+    debugLog(`[openTab] Tab with URL ${url} already exists, switching to it`);
+  } else {
+    // Create new tab
+    targetPage = await browser.newPage();
+
+    await targetPage.goto(url, {
+      waitUntil: 'domcontentloaded', // Less strict for sites with continuous loading
+      timeout
+    });
+
+    debugLog(`[openTab] New tab created: ${url}`);
+  }
+
+  // If switchToTab is true, bring the tab to front and return the new page
+  if (switchToTab && targetPage) {
+    await targetPage.bringToFront();
+    debugLog(`[openTab] Switched to tab: ${url}`);
+    return targetPage; // Return the new page for subsequent actions
+  }
+
+  return null; // Don't switch page if switchToTab is false
+}
+
 /**
  * Substitute {{param}} in string
  */