chrome-tools 1.1.9 → 1.1.10

package/dist/src/core/db.js

@@ -47,7 +47,14 @@ export function queryDatabase(dbFilePath, sql, params = []) {
         sourceDb = new Database(dbFilePath, {
             readonly: true,
             fileMustExist: true,
-            timeout: 5000,
+            // No wait. A running Chrome holds these stores in `locking_mode =
+            // EXCLUSIVE` for as long as it is open, so a busy timeout here buys
+            // nothing that waiting longer would win — the lock is not transient, and
+            // the copy below is the answer to it either way. Five seconds *per store*
+            // was the whole cost of reading a saved login while the browser was up:
+            // two stores, ten seconds, spent to arrive at the fallback that then
+            // succeeded instantly.
+            timeout: 0,
         });
         sourceDb.prepare("VACUUM INTO ?").run(tmpDb);
     }

package/dist/src/modules/passwords.js

@@ -160,7 +160,21 @@ export function getPasswords({ chromeDir, profilePath, profile, search, browser,
                     const rows = queryDatabase(dbPath, `SELECT origin_url, username_value, password_value, date_last_used
              FROM logins ORDER BY origin_url`);
                     for (const row of rows) {
-                        const entry = {
+                        // Matched before anything is decrypted. Both columns the search
+                        // looks at — the origin and the username — are stored in the clear,
+                        // so a row that cannot match never needs its password read at all.
+                        //
+                        // Decrypting first cost one platform decryption per stored login on
+                        // the way to finding one: a store with a few hundred entries spent
+                        // upwards of ten seconds answering "what is the password for this
+                        // one site", and every one of those decryptions was thrown away by
+                        // the filter immediately below.
+                        if (term &&
+                            !(row.origin_url && row.origin_url.toLowerCase().includes(term)) &&
+                            !(row.username_value && row.username_value.toLowerCase().includes(term))) {
+                            continue;
+                        }
+                        results.push({
                             profile: p.name,
                             source: store.source,
                             url: row.origin_url,
@@ -169,14 +183,7 @@ export function getPasswords({ chromeDir, profilePath, profile, search, browser,
                                 ? decryptValue(row.password_value, derivedKey ??= deriveEncryptionKey(root, browser))
                                 : "",
                             lastUsed: chromeTimeToDate(row.date_last_used || 0),
-                        };
-                        if (term) {
-                            if (!(entry.url && entry.url.toLowerCase().includes(term)) &&
-                                !(entry.username && entry.username.toLowerCase().includes(term))) {
-                                continue;
-                            }
-                        }
-                        results.push(entry);
+                        });
                     }
                 }
                 catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "chrome-tools",
-  "version": "1.1.9",
+  "version": "1.1.10",
   "description": "CLI & Node.js library for chrome",
   "type": "module",
   "main": "./dist/src/index.js",