chrome-devtools-frontend 1.0.998142 → 1.0.999279

package/.clang-format

@@ -7,3 +7,4 @@ CommentPragmas: .*\@.*
 AllowShortBlocksOnASingleLine: false
 AllowShortFunctionsOnASingleLine: None
 ReflowComments: false
+JavaScriptWrapImports: true

package/front_end/core/common/Color.ts

@@ -33,7 +33,15 @@
 
 import * as Platform from '../platform/platform.js';
 
-import {blendColors, contrastRatioAPCA, desiredLuminanceAPCA, luminance, luminanceAPCA, rgbaToHsla, rgbaToHwba} from './ColorUtils.js';
+import {
+  blendColors,
+  contrastRatioAPCA,
+  desiredLuminanceAPCA,
+  luminance,
+  luminanceAPCA,
+  rgbaToHsla,
+  rgbaToHwba,
+} from './ColorUtils.js';
 
 export class Color {
   #hslaInternal: number[]|undefined;

package/front_end/core/common/Object.ts

@@ -28,7 +28,8 @@
  */
 
 import type * as Platform from '../platform/platform.js';
-import type {EventDescriptor, EventListener, EventTarget, EventTargetEvent, EventPayloadToRestParameters} from './EventTarget.js';
+import type {
+  EventDescriptor, EventListener, EventTarget, EventTargetEvent, EventPayloadToRestParameters} from './EventTarget.js';
 
 export interface ListenerCallbackTuple<Events, T extends keyof Events> {
   thisObject?: Object;

package/front_end/core/common/Settings.ts

@@ -36,7 +36,19 @@ import {Format} from './Color.js';
 import {Console} from './Console.js';
 import type {GenericEvents, EventDescriptor, EventTargetEvent} from './EventTarget.js';
 import {ObjectWrapper} from './Object.js';
-import {getLocalizedSettingsCategory, getRegisteredSettings, maybeRemoveSettingExtension, type RegExpSettingItem, registerSettingExtension, registerSettingsForTest, resetSettings, SettingCategory, type SettingExtensionOption, type SettingRegistration, SettingType} from './SettingRegistration.js';
+import {
+  getLocalizedSettingsCategory,
+  getRegisteredSettings,
+  maybeRemoveSettingExtension,
+  type RegExpSettingItem,
+  registerSettingExtension,
+  registerSettingsForTest,
+  resetSettings,
+  SettingCategory,
+  type SettingExtensionOption,
+  type SettingRegistration,
+  SettingType,
+} from './SettingRegistration.js';
 
 let settingsInstance: Settings|undefined;
 

package/front_end/core/host/InspectorFrontendHost.ts

@@ -36,7 +36,10 @@ import * as i18n from '../i18n/i18n.js';
 import * as Platform from '../platform/platform.js';
 import * as Root from '../root/root.js';
 
-import type {CanShowSurveyResult, ContextMenuDescriptor, EnumeratedHistogram, EventTypes, ExtensionDescriptor, InspectorFrontendHostAPI, LoadNetworkResourceResult, ShowSurveyResult, SyncInformation} from './InspectorFrontendHostAPI.js';
+import type {
+  CanShowSurveyResult, ContextMenuDescriptor, EnumeratedHistogram, EventTypes, ExtensionDescriptor,
+  InspectorFrontendHostAPI, LoadNetworkResourceResult, ShowSurveyResult,
+  SyncInformation} from './InspectorFrontendHostAPI.js';
 import {EventDescriptors, Events} from './InspectorFrontendHostAPI.js';
 import {streamWrite as resourceLoaderStreamWrite} from './ResourceLoader.js';
 

package/front_end/core/host/UserMetrics.ts

@@ -549,7 +549,8 @@ export enum KeyboardShortcutAction {
   'layers.left' = 104,
   'layers.right' = 105,
   'help.report-translation-issue' = 106,
-  MaxValue = 107,
+  'rendering.toggle-prefers-color-scheme' = 107,
+  MaxValue = 108,
 }
 /* eslint-enable @typescript-eslint/naming-convention */
 

package/front_end/core/i18n/locales/en-US.json

@@ -899,6 +899,9 @@
   "entrypoints/inspector_main/inspector_main-meta.ts | showRendering": {
     "message": "Show Rendering"
   },
+  "entrypoints/inspector_main/inspector_main-meta.ts | toggleCssPrefersColorSchemeMedia": {
+    "message": "Toggle forces CSS prefers-color-scheme color"
+  },
   "entrypoints/inspector_main/inspector_main-meta.ts | visionDeficiency": {
     "message": "vision deficiency"
   },
@@ -7479,7 +7482,7 @@
     "message": "Unknown"
   },
   "panels/network/RequestTimingView.ts | waitingTtfb": {
-    "message": "Waiting (TTFB)"
+    "message": "Waiting for server response"
   },
   "panels/network/RequestTimingView.ts | waterfall": {
     "message": "Waterfall"

package/front_end/core/i18n/locales/en-XL.json

@@ -899,6 +899,9 @@
   "entrypoints/inspector_main/inspector_main-meta.ts | showRendering": {
     "message": "Ŝh́ôẃ R̂én̂d́êŕîńĝ"
   },
+  "entrypoints/inspector_main/inspector_main-meta.ts | toggleCssPrefersColorSchemeMedia": {
+    "message": "T̂óĝǵl̂é f̂ór̂ćêś ĈŚŜ ṕr̂éf̂ér̂ś-ĉól̂ór̂-śĉh́êḿê ćôĺôŕ"
+  },
   "entrypoints/inspector_main/inspector_main-meta.ts | visionDeficiency": {
     "message": "v̂íŝíôń d̂éf̂íĉíêńĉý"
   },
@@ -7479,7 +7482,7 @@
     "message": "Ûńk̂ńôẃn̂"
   },
   "panels/network/RequestTimingView.ts | waitingTtfb": {
-    "message": "Ŵáît́îńĝ (T́T̂F́B̂)"
+    "message": "Ŵáît́îńĝ f́ôŕ ŝér̂v́êŕ r̂éŝṕôńŝé"
   },
   "panels/network/RequestTimingView.ts | waterfall": {
     "message": "Ŵát̂ér̂f́âĺl̂"

package/front_end/core/sdk/CSSProperty.ts

@@ -163,8 +163,8 @@ export class CSSProperty {
 
     const range = this.range.relativeTo(this.ownerStyle.range.startLine, this.ownerStyle.range.startColumn);
     const indentation = this.ownerStyle.cssText ?
-    this.detectIndentation(this.ownerStyle.cssText) :
-    Common.Settings.Settings.instance().moduleSetting('textEditorIndent').get();
+        this.detectIndentation(this.ownerStyle.cssText) :
+        Common.Settings.Settings.instance().moduleSetting('textEditorIndent').get();
     const endIndentation = this.ownerStyle.cssText ? indentation.substring(0, this.ownerStyle.range.endColumn) : '';
     const text = new TextUtils.Text.Text(this.ownerStyle.cssText || '');
     const newStyleText = text.replaceRange(range, Platform.StringUtilities.sprintf(';%s;', propertyText));
@@ -172,8 +172,7 @@ export class CSSProperty {
     return this.ownerStyle.setText(styleText, majorChange);
   }
 
-  static async formatStyle(
-    styleText: string, indentation: string, endIndentation: string): Promise<string> {
+  static async formatStyle(styleText: string, indentation: string, endIndentation: string): Promise<string> {
     const doubleIndent = indentation.substring(endIndentation.length) + indentation;
     if (indentation) {
       indentation = '\n' + indentation;
@@ -197,7 +196,7 @@ export class CSSProperty {
         const disabledProperty = tokenType?.includes('comment') && isDisabledProperty(token);
         const isPropertyStart =
             (tokenType?.includes('string') || tokenType?.includes('meta') || tokenType?.includes('property') ||
-            tokenType?.includes('variableName'));
+             tokenType?.includes('variableName'));
         if (disabledProperty) {
           result = result.trimEnd() + indentation + token;
         } else if (isPropertyStart) {
@@ -222,8 +221,8 @@ export class CSSProperty {
         // implementation takes special care to restore a single
         // whitespace token in this edge case. https://crbug.com/1071296
         const trimmedPropertyText = propertyText.trim();
-        result =
-            result.trimEnd() + indentation + trimmedPropertyText + (trimmedPropertyText.endsWith(':') ? ' ' : '') + token;
+        result = result.trimEnd() + indentation + trimmedPropertyText + (trimmedPropertyText.endsWith(':') ? ' ' : '') +
+            token;
         needsSemi = false;
         insideProperty = false;
         propertyName = '';

package/front_end/core/sdk/ChildTargetManager.ts

@@ -142,9 +142,6 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
     }
     const target = this.#targetManager.createTarget(
         targetInfo.targetId, targetName, type, this.#parentTarget, sessionId, undefined, undefined, targetInfo);
-    if (type === Type.Worker || type === Type.ServiceWorker || type === Type.SharedWorker) {
-      target.setInspectedURL(this.#parentTarget.inspectedURL());
-    }
     this.#childTargetsBySessionId.set(sessionId, target);
     this.#childTargetsById.set(target.id(), target);
 

package/front_end/core/sdk/ConsoleModel.ts

@@ -44,7 +44,8 @@ import {Events as DebuggerModelEvents} from './DebuggerModel.js';
 import {LogModel} from './LogModel.js';
 import {RemoteObject} from './RemoteObject.js';
 import {Events as ResourceTreeModelEvents, ResourceTreeModel} from './ResourceTreeModel.js';
-import type {ConsoleAPICall, ExceptionWithTimestamp, ExecutionContext, QueryObjectRequestedEvent} from './RuntimeModel.js';
+import type {
+  ConsoleAPICall, ExceptionWithTimestamp, ExecutionContext, QueryObjectRequestedEvent} from './RuntimeModel.js';
 import {Events as RuntimeModelEvents, RuntimeModel} from './RuntimeModel.js';
 import type {Target} from './Target.js';
 import {TargetManager} from './TargetManager.js';

package/front_end/core/sdk/DebuggerModel.ts

@@ -245,9 +245,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     if (!Common.Settings.Settings.instance().moduleSetting('breakpointsActive').get()) {
       this.breakpointsActiveChanged();
     }
-    if (_scheduledPauseOnAsyncCall) {
-      void this.pauseOnAsyncCall(_scheduledPauseOnAsyncCall);
-    }
     this.dispatchEventToListeners(Events.DebuggerWasEnabled, this);
     const [enableResult] = await Promise.all([enablePromise, instrumentationPromise]);
     this.registerDebugger(enableResult);
@@ -422,10 +419,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     void this.agent.invoke_pause();
   }
 
-  private pauseOnAsyncCall(parentStackTraceId: Protocol.Runtime.StackTraceId): Promise<Object> {
-    return this.agent.invoke_pauseOnAsyncCall({parentStackTraceId: parentStackTraceId});
-  }
-
   async setBreakpointByURL(
       url: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber?: number,
       condition?: string): Promise<SetBreakpointResult> {
@@ -659,8 +652,7 @@ export class DebuggerModel extends SDKModel<EventTypes> {
   async pausedScript(
       callFrames: Protocol.Debugger.CallFrame[], reason: Protocol.Debugger.PausedEventReason, auxData: Object|undefined,
       breakpointIds: string[], asyncStackTrace?: Protocol.Runtime.StackTrace,
-      asyncStackTraceId?: Protocol.Runtime.StackTraceId,
-      asyncCallStackTraceId?: Protocol.Runtime.StackTraceId): Promise<void> {
+      asyncStackTraceId?: Protocol.Runtime.StackTraceId): Promise<void> {
     if (reason === Protocol.Debugger.PausedEventReason.Instrumentation) {
       const script = this.scriptForId(callFrames[0].location.scriptId);
       if (this.#synchronizeBreakpointsCallback && script) {
@@ -670,18 +662,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
       return;
     }
 
-    if (asyncCallStackTraceId) {
-      // Note: this is only to support old backends. Newer ones do not send asyncCallStackTraceId.
-      _scheduledPauseOnAsyncCall = asyncCallStackTraceId;
-      const promises = [];
-      for (const model of _debuggerIdToModel.values()) {
-        promises.push(model.pauseOnAsyncCall(asyncCallStackTraceId));
-      }
-      await Promise.all(promises);
-      this.resume();
-      return;
-    }
-
     const pausedDetails =
         new DebuggerPausedDetails(this, callFrames, reason, auxData, breakpointIds, asyncStackTrace, asyncStackTraceId);
 
@@ -706,8 +686,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     } else {
       Common.EventTarget.fireEvent('DevTools.DebuggerPaused');
     }
-
-    _scheduledPauseOnAsyncCall = null;
   }
 
   resumedScript(): void {
@@ -989,10 +967,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export const _debuggerIdToModel = new Map<string, DebuggerModel>();
 
-// TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-// eslint-disable-next-line @typescript-eslint/naming-convention
-export let _scheduledPauseOnAsyncCall: Protocol.Runtime.StackTraceId|null = null;
-
 /**
  * Keep these in sync with WebCore::V8Debugger
  */
@@ -1037,13 +1011,13 @@ class DebuggerDispatcher implements ProtocolProxyApi.DebuggerDispatcher {
     this.#debuggerModel = debuggerModel;
   }
 
-  paused({callFrames, reason, data, hitBreakpoints, asyncStackTrace, asyncStackTraceId, asyncCallStackTraceId}:
-             Protocol.Debugger.PausedEvent): void {
+  paused({callFrames, reason, data, hitBreakpoints, asyncStackTrace, asyncStackTraceId}: Protocol.Debugger.PausedEvent):
+      void {
     if (!this.#debuggerModel.debuggerEnabled()) {
       return;
     }
     void this.#debuggerModel.pausedScript(
-        callFrames, reason, data, hitBreakpoints || [], asyncStackTrace, asyncStackTraceId, asyncCallStackTraceId);
+        callFrames, reason, data, hitBreakpoints || [], asyncStackTrace, asyncStackTraceId);
   }
 
   resumed(): void {

package/front_end/core/sdk/NetworkManager.ts

@@ -41,7 +41,9 @@ import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import * as Protocol from '../../generated/protocol.js';
 
 import {Cookie} from './Cookie.js';
-import type {BlockedCookieWithReason, ContentData, ExtraRequestInfo, ExtraResponseInfo, MIME_TYPE, NameValue, WebBundleInfo, WebBundleInnerRequestInfo} from './NetworkRequest.js';
+import type {
+  BlockedCookieWithReason, ContentData, ExtraRequestInfo, ExtraResponseInfo, MIME_TYPE, NameValue, WebBundleInfo,
+  WebBundleInnerRequestInfo} from './NetworkRequest.js';
 import {Events as NetworkRequestEvents, NetworkRequest} from './NetworkRequest.js';
 import type {Target} from './Target.js';
 import {Capability} from './Target.js';

package/front_end/core/sdk/RuntimeModel.ts

@@ -41,7 +41,13 @@ import type {FunctionDetails} from './DebuggerModel.js';
 import {DebuggerModel} from './DebuggerModel.js';
 import {HeapProfilerModel} from './HeapProfilerModel.js';
 import type {ScopeRef} from './RemoteObject.js';
-import {RemoteFunction, RemoteObject, RemoteObjectImpl, RemoteObjectProperty, ScopeRemoteObject} from './RemoteObject.js';
+import {
+  RemoteFunction,
+  RemoteObject,
+  RemoteObjectImpl,
+  RemoteObjectProperty,
+  ScopeRemoteObject,
+} from './RemoteObject.js';
 import type {Target} from './Target.js';
 import {Capability, Type} from './Target.js';
 import {SDKModel} from './SDKModel.js';

package/front_end/core/sdk/SourceMapManager.ts

@@ -8,6 +8,7 @@ import * as Platform from '../platform/platform.js';
 
 import type {FrameAssociated} from './FrameAssociated.js';
 import type {Target} from './Target.js';
+import {Type} from './Target.js';
 import {Events as TargetManagerEvents, TargetManager} from './TargetManager.js';
 import type {SourceMap} from './SourceMap.js';
 import {TextSourceMap} from './SourceMap.js';
@@ -66,6 +67,14 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
     }
   }
 
+  private getBaseUrl(): Platform.DevToolsPath.UrlString {
+    let target: Target|null = this.#target;
+    while (target && target.type() !== Type.Frame) {
+      target = target.parentTarget();
+    }
+    return target?.inspectedURL() ?? Platform.DevToolsPath.EmptyUrlString;
+  }
+
   private inspectedURLChanged(event: Common.EventTarget.EventTargetEvent<Target>): void {
     if (event.data !== this.#target) {
       return;
@@ -156,7 +165,7 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
   }|null {
     // |#sourceURL| can be a random string, but is generally an absolute path.
     // Complete it to inspected page url for relative links.
-    const resolvedSourceURL = Common.ParsedURL.ParsedURL.completeURL(this.#target.inspectedURL(), sourceURL);
+    const resolvedSourceURL = Common.ParsedURL.ParsedURL.completeURL(this.getBaseUrl(), sourceURL);
     if (!resolvedSourceURL) {
       return null;
     }

package/front_end/entrypoints/formatter_worker/FormatterWorker.ts

@@ -31,7 +31,11 @@
 import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as Acorn from '../../third_party/acorn/acorn.js';
-import type * as CodeMirrorModule from '../../third_party/codemirror/codemirror-legacy.js'; // eslint-disable-line @typescript-eslint/no-unused-vars
+
+// This file is required to bring some types into scope, even though it
+// is not used.
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+import type * as CodeMirrorModule from '../../third_party/codemirror/codemirror-legacy.js';
 
 import {AcornTokenizer, ECMA_VERSION} from './AcornTokenizer.js';
 import {CSSFormatter} from './CSSFormatter.js';

package/front_end/entrypoints/inspector_main/RenderingOptions.ts

@@ -346,3 +346,34 @@ export class RenderingOptionsView extends UI.Widget.VBox {
     this.registerCSSFiles([renderingOptionsStyles]);
   }
 }
+
+let reloadActionDelegateInstance: ReloadActionDelegate;
+
+export class ReloadActionDelegate implements UI.ActionRegistration.ActionDelegate {
+  static instance(opts: {
+    forceNew: boolean|null,
+  } = {forceNew: null}): ReloadActionDelegate {
+    const {forceNew} = opts;
+    if (!reloadActionDelegateInstance || forceNew) {
+      reloadActionDelegateInstance = new ReloadActionDelegate();
+    }
+
+    return reloadActionDelegateInstance;
+  }
+
+  handleAction(context: UI.Context.Context, actionId: string): boolean {
+    const emulatedCSSMediaFeaturePrefersColorSchemeSetting =
+        Common.Settings.Settings.instance().moduleSetting('emulatedCSSMediaFeaturePrefersColorScheme');
+
+    switch (actionId) {
+      case 'rendering.toggle-prefers-color-scheme':
+        if (emulatedCSSMediaFeaturePrefersColorSchemeSetting.get() === 'light') {
+          emulatedCSSMediaFeaturePrefersColorSchemeSetting.set('dark');
+        } else {
+          emulatedCSSMediaFeaturePrefersColorSchemeSetting.set('light');
+        }
+        return true;
+    }
+    return false;
+  }
+}

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -99,6 +99,11 @@ const UIStrings = {
   * setting turns off this overlay.
   */
   disablePaused: 'Disable paused state overlay',
+  /**
+  * @description Title of an action that toggle
+  * "forces CSS prefers-color-scheme" color
+  */
+  toggleCssPrefersColorSchemeMedia: 'Toggle forces CSS prefers-color-scheme color',
 };
 const str_ = i18n.i18n.registerUIStrings('entrypoints/inspector_main/inspector_main-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
@@ -191,6 +196,16 @@ UI.ActionRegistration.registerActionExtension({
   ],
 });
 
+UI.ActionRegistration.registerActionExtension({
+  actionId: 'rendering.toggle-prefers-color-scheme',
+  category: UI.ActionRegistration.ActionCategory.RENDERING,
+  title: i18nLazyString(UIStrings.toggleCssPrefersColorSchemeMedia),
+  async loadActionDelegate() {
+    const InspectorMain = await loadInspectorMainModule();
+    return InspectorMain.RenderingOptions.ReloadActionDelegate.instance();
+  },
+});
+
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.NETWORK,
   title: i18nLazyString(UIStrings.forceAdBlocking),

package/front_end/entrypoints/lighthouse_worker/LighthouseWorkerService.ts

@@ -118,6 +118,12 @@ async function invokeLH(action: string, args: any): Promise<unknown> {
     flags.channel = 'devtools';
     flags.locale = locale;
 
+    // TODO: Remove this filter once pubads is mode restricted
+    // https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/339
+    if (action === 'startTimespan' || action === 'snapshot') {
+      args.categoryIDs = args.categoryIDs.filter((c: string) => c !== 'lighthouse-plugin-publisher-ads');
+    }
+
     // @ts-expect-error https://github.com/GoogleChrome/lighthouse/issues/11628
     const config = self.createConfig(args.categoryIDs, flags.emulatedFormFactor);
     const url = args.url;

package/front_end/generated/InspectorBackendCommands.js

@@ -273,7 +273,6 @@ export function registerCommands(inspectorBackend) {
       'Audits.GenericIssueErrorType', {CrossOriginPortalPostMessageError: 'CrossOriginPortalPostMessageError'});
   inspectorBackend.registerEnum('Audits.DeprecationIssueType', {
     AuthorizationCoveredByWildcard: 'AuthorizationCoveredByWildcard',
-    BatteryStatusInsecureOrigin: 'BatteryStatusInsecureOrigin',
     CanRequestURLHTTPContainingNewline: 'CanRequestURLHTTPContainingNewline',
     ChromeLoadTimesConnectionInfo: 'ChromeLoadTimesConnectionInfo',
     ChromeLoadTimesFirstPaintAfterLoadTime: 'ChromeLoadTimesFirstPaintAfterLoadTime',

package/front_end/generated/protocol.ts

@@ -1020,7 +1020,6 @@ export namespace Audits {
 
   export const enum DeprecationIssueType {
     AuthorizationCoveredByWildcard = 'AuthorizationCoveredByWildcard',
-    BatteryStatusInsecureOrigin = 'BatteryStatusInsecureOrigin',
     CanRequestURLHTTPContainingNewline = 'CanRequestURLHTTPContainingNewline',
     ChromeLoadTimesConnectionInfo = 'ChromeLoadTimesConnectionInfo',
     ChromeLoadTimesFirstPaintAfterLoadTime = 'ChromeLoadTimesFirstPaintAfterLoadTime',

package/front_end/legacy/legacy-defs.d.ts

@@ -122,8 +122,8 @@ interface DOMError {
 }
 
 interface ShadowRoot {
-  elementFromPoint(x: number, y: number): Element | null;
-  getSelection(): Selection | null;
+  elementFromPoint(x: number, y: number): Element|null;
+  getSelection(): Selection|null;
 }
 
 interface HTMLDialogElement {

package/front_end/models/formatter/ScriptFormatter.ts

@@ -30,7 +30,9 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Platform from '../../core/platform/platform.js';
-import type * as FormatterActions from '../../entrypoints/formatter_worker/FormatterActions.js'; // eslint-disable-line rulesdir/es_modules_import
+
+// eslint-disable-next-line rulesdir/es_modules_import
+import type * as FormatterActions from '../../entrypoints/formatter_worker/FormatterActions.js';
 
 import {formatterWorkerPool} from './FormatterWorkerPool.js';