chrome-devtools-frontend 1.0.998045 → 1.0.998787

package/front_end/core/host/UserMetrics.ts

@@ -549,7 +549,8 @@ export enum KeyboardShortcutAction {
   'layers.left' = 104,
   'layers.right' = 105,
   'help.report-translation-issue' = 106,
-  MaxValue = 107,
+  'rendering.toggle-prefers-color-scheme' = 107,
+  MaxValue = 108,
 }
 /* eslint-enable @typescript-eslint/naming-convention */
 

package/front_end/core/i18n/locales/en-US.json

@@ -899,6 +899,9 @@
   "entrypoints/inspector_main/inspector_main-meta.ts | showRendering": {
     "message": "Show Rendering"
   },
+  "entrypoints/inspector_main/inspector_main-meta.ts | toggleCssPrefersColorSchemeMedia": {
+    "message": "Toggle forces CSS prefers-color-scheme color"
+  },
   "entrypoints/inspector_main/inspector_main-meta.ts | visionDeficiency": {
     "message": "vision deficiency"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -899,6 +899,9 @@
   "entrypoints/inspector_main/inspector_main-meta.ts | showRendering": {
     "message": "Ŝh́ôẃ R̂én̂d́êŕîńĝ"
   },
+  "entrypoints/inspector_main/inspector_main-meta.ts | toggleCssPrefersColorSchemeMedia": {
+    "message": "T̂óĝǵl̂é f̂ór̂ćêś ĈŚŜ ṕr̂éf̂ér̂ś-ĉól̂ór̂-śĉh́êḿê ćôĺôŕ"
+  },
   "entrypoints/inspector_main/inspector_main-meta.ts | visionDeficiency": {
     "message": "v̂íŝíôń d̂éf̂íĉíêńĉý"
   },

package/front_end/core/sdk/DebuggerModel.ts

@@ -245,9 +245,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     if (!Common.Settings.Settings.instance().moduleSetting('breakpointsActive').get()) {
       this.breakpointsActiveChanged();
     }
-    if (_scheduledPauseOnAsyncCall) {
-      void this.pauseOnAsyncCall(_scheduledPauseOnAsyncCall);
-    }
     this.dispatchEventToListeners(Events.DebuggerWasEnabled, this);
     const [enableResult] = await Promise.all([enablePromise, instrumentationPromise]);
     this.registerDebugger(enableResult);
@@ -422,10 +419,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     void this.agent.invoke_pause();
   }
 
-  private pauseOnAsyncCall(parentStackTraceId: Protocol.Runtime.StackTraceId): Promise<Object> {
-    return this.agent.invoke_pauseOnAsyncCall({parentStackTraceId: parentStackTraceId});
-  }
-
   async setBreakpointByURL(
       url: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber?: number,
       condition?: string): Promise<SetBreakpointResult> {
@@ -659,8 +652,7 @@ export class DebuggerModel extends SDKModel<EventTypes> {
   async pausedScript(
       callFrames: Protocol.Debugger.CallFrame[], reason: Protocol.Debugger.PausedEventReason, auxData: Object|undefined,
       breakpointIds: string[], asyncStackTrace?: Protocol.Runtime.StackTrace,
-      asyncStackTraceId?: Protocol.Runtime.StackTraceId,
-      asyncCallStackTraceId?: Protocol.Runtime.StackTraceId): Promise<void> {
+      asyncStackTraceId?: Protocol.Runtime.StackTraceId): Promise<void> {
     if (reason === Protocol.Debugger.PausedEventReason.Instrumentation) {
       const script = this.scriptForId(callFrames[0].location.scriptId);
       if (this.#synchronizeBreakpointsCallback && script) {
@@ -670,18 +662,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
       return;
     }
 
-    if (asyncCallStackTraceId) {
-      // Note: this is only to support old backends. Newer ones do not send asyncCallStackTraceId.
-      _scheduledPauseOnAsyncCall = asyncCallStackTraceId;
-      const promises = [];
-      for (const model of _debuggerIdToModel.values()) {
-        promises.push(model.pauseOnAsyncCall(asyncCallStackTraceId));
-      }
-      await Promise.all(promises);
-      this.resume();
-      return;
-    }
-
     const pausedDetails =
         new DebuggerPausedDetails(this, callFrames, reason, auxData, breakpointIds, asyncStackTrace, asyncStackTraceId);
 
@@ -706,8 +686,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     } else {
       Common.EventTarget.fireEvent('DevTools.DebuggerPaused');
     }
-
-    _scheduledPauseOnAsyncCall = null;
   }
 
   resumedScript(): void {
@@ -989,10 +967,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export const _debuggerIdToModel = new Map<string, DebuggerModel>();
 
-// TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-// eslint-disable-next-line @typescript-eslint/naming-convention
-export let _scheduledPauseOnAsyncCall: Protocol.Runtime.StackTraceId|null = null;
-
 /**
  * Keep these in sync with WebCore::V8Debugger
  */
@@ -1037,13 +1011,13 @@ class DebuggerDispatcher implements ProtocolProxyApi.DebuggerDispatcher {
     this.#debuggerModel = debuggerModel;
   }
 
-  paused({callFrames, reason, data, hitBreakpoints, asyncStackTrace, asyncStackTraceId, asyncCallStackTraceId}:
-             Protocol.Debugger.PausedEvent): void {
+  paused({callFrames, reason, data, hitBreakpoints, asyncStackTrace, asyncStackTraceId}: Protocol.Debugger.PausedEvent):
+      void {
     if (!this.#debuggerModel.debuggerEnabled()) {
       return;
     }
     void this.#debuggerModel.pausedScript(
-        callFrames, reason, data, hitBreakpoints || [], asyncStackTrace, asyncStackTraceId, asyncCallStackTraceId);
+        callFrames, reason, data, hitBreakpoints || [], asyncStackTrace, asyncStackTraceId);
   }
 
   resumed(): void {

package/front_end/entrypoints/inspector_main/RenderingOptions.ts

@@ -346,3 +346,34 @@ export class RenderingOptionsView extends UI.Widget.VBox {
     this.registerCSSFiles([renderingOptionsStyles]);
   }
 }
+
+let reloadActionDelegateInstance: ReloadActionDelegate;
+
+export class ReloadActionDelegate implements UI.ActionRegistration.ActionDelegate {
+  static instance(opts: {
+    forceNew: boolean|null,
+  } = {forceNew: null}): ReloadActionDelegate {
+    const {forceNew} = opts;
+    if (!reloadActionDelegateInstance || forceNew) {
+      reloadActionDelegateInstance = new ReloadActionDelegate();
+    }
+
+    return reloadActionDelegateInstance;
+  }
+
+  handleAction(context: UI.Context.Context, actionId: string): boolean {
+    const emulatedCSSMediaFeaturePrefersColorSchemeSetting =
+        Common.Settings.Settings.instance().moduleSetting('emulatedCSSMediaFeaturePrefersColorScheme');
+
+    switch (actionId) {
+      case 'rendering.toggle-prefers-color-scheme':
+        if (emulatedCSSMediaFeaturePrefersColorSchemeSetting.get() === 'light') {
+          emulatedCSSMediaFeaturePrefersColorSchemeSetting.set('dark');
+        } else {
+          emulatedCSSMediaFeaturePrefersColorSchemeSetting.set('light');
+        }
+        return true;
+    }
+    return false;
+  }
+}

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -99,6 +99,11 @@ const UIStrings = {
   * setting turns off this overlay.
   */
   disablePaused: 'Disable paused state overlay',
+  /**
+  * @description Title of an action that toggle
+  * "forces CSS prefers-color-scheme" color
+  */
+  toggleCssPrefersColorSchemeMedia: 'Toggle forces CSS prefers-color-scheme color',
 };
 const str_ = i18n.i18n.registerUIStrings('entrypoints/inspector_main/inspector_main-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
@@ -191,6 +196,16 @@ UI.ActionRegistration.registerActionExtension({
   ],
 });
 
+UI.ActionRegistration.registerActionExtension({
+  actionId: 'rendering.toggle-prefers-color-scheme',
+  category: UI.ActionRegistration.ActionCategory.RENDERING,
+  title: i18nLazyString(UIStrings.toggleCssPrefersColorSchemeMedia),
+  async loadActionDelegate() {
+    const InspectorMain = await loadInspectorMainModule();
+    return InspectorMain.RenderingOptions.ReloadActionDelegate.instance();
+  },
+});
+
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.NETWORK,
   title: i18nLazyString(UIStrings.forceAdBlocking),

package/front_end/entrypoints/lighthouse_worker/LighthouseWorkerService.ts

@@ -118,6 +118,12 @@ async function invokeLH(action: string, args: any): Promise<unknown> {
     flags.channel = 'devtools';
     flags.locale = locale;
 
+    // TODO: Remove this filter once pubads is mode restricted
+    // https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/339
+    if (action === 'startTimespan' || action === 'snapshot') {
+      args.categoryIDs = args.categoryIDs.filter((c: string) => c !== 'lighthouse-plugin-publisher-ads');
+    }
+
     // @ts-expect-error https://github.com/GoogleChrome/lighthouse/issues/11628
     const config = self.createConfig(args.categoryIDs, flags.emulatedFormFactor);
     const url = args.url;

package/front_end/generated/InspectorBackendCommands.js

@@ -273,7 +273,6 @@ export function registerCommands(inspectorBackend) {
       'Audits.GenericIssueErrorType', {CrossOriginPortalPostMessageError: 'CrossOriginPortalPostMessageError'});
   inspectorBackend.registerEnum('Audits.DeprecationIssueType', {
     AuthorizationCoveredByWildcard: 'AuthorizationCoveredByWildcard',
-    BatteryStatusInsecureOrigin: 'BatteryStatusInsecureOrigin',
     CanRequestURLHTTPContainingNewline: 'CanRequestURLHTTPContainingNewline',
     ChromeLoadTimesConnectionInfo: 'ChromeLoadTimesConnectionInfo',
     ChromeLoadTimesFirstPaintAfterLoadTime: 'ChromeLoadTimesFirstPaintAfterLoadTime',

package/front_end/generated/protocol.ts

@@ -1020,7 +1020,6 @@ export namespace Audits {
 
   export const enum DeprecationIssueType {
     AuthorizationCoveredByWildcard = 'AuthorizationCoveredByWildcard',
-    BatteryStatusInsecureOrigin = 'BatteryStatusInsecureOrigin',
     CanRequestURLHTTPContainingNewline = 'CanRequestURLHTTPContainingNewline',
     ChromeLoadTimesConnectionInfo = 'ChromeLoadTimesConnectionInfo',
     ChromeLoadTimesFirstPaintAfterLoadTime = 'ChromeLoadTimesFirstPaintAfterLoadTime',