chrome-devtools-frontend 1.0.996595 → 1.0.998045

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts

@@ -78,7 +78,7 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
     };
     if (Root.Runtime.experiments.isEnabled(experiment)) {
       this.#legacyTreeDisabled = true;
-      const feedbackURL = 'https://goo.gle/devtools-a11y-tree-feedback';
+      const feedbackURL = 'https://g.co/devtools/a11y-tree-feedback';
       previewToggle.data = {
         name,
         helperText: i18nString(UIStrings.fullTreeExperimentDescription),

package/front_end/panels/css_overview/components/CSSOverviewStartView.ts

@@ -43,7 +43,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 const {render, html} = LitHtml;
 
-const FEEDBACK_LINK = 'https://goo.gle/css-overview-feedback';
+const FEEDBACK_LINK = 'https://g.co/devtools/css-overview-feedback';
 const DOC_LINK = 'https://developer.chrome.com/docs/devtools/css-overview';
 export class OverviewStartRequestedEvent extends Event {
   static readonly eventName = 'overviewstartrequested';

package/front_end/panels/css_overview/cssOverview.css

@@ -7,3 +7,7 @@
 .css-overview-panel {
   overflow: hidden;
 }
+
+devtools-css-overview-start-view {
+  overflow: auto;
+}

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -871,22 +871,32 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
       };
     });
 
-    let pseudoTypes: Protocol.DOM.PseudoType[] = [];
-    const keys = matchedStyles.pseudoTypes();
-    if (keys.delete(Protocol.DOM.PseudoType.Before)) {
-      pseudoTypes.push(Protocol.DOM.PseudoType.Before);
-    }
-    pseudoTypes = pseudoTypes.concat([...keys].sort());
-
     const otherPseudoRulesets: {
       highlightName: string|null,
       pseudoType: Protocol.DOM.PseudoType,
       pseudoStyles: SDK.CSSStyleDeclaration.CSSStyleDeclaration[],
-    }[] = pseudoTypes.map(pseudoType => {
+    }[] = [...matchedStyles.pseudoTypes()].map(pseudoType => {
       return {'highlightName': null, 'pseudoType': pseudoType, 'pseudoStyles': matchedStyles.pseudoStyles(pseudoType)};
     });
 
-    const pseudoRulesets = customHighlightPseudoRulesets.concat(otherPseudoRulesets);
+    const pseudoRulesets = customHighlightPseudoRulesets.concat(otherPseudoRulesets).sort((a, b) => {
+      // We want to show the ::before pseudos first, followed by the remaining pseudos
+      // in alphabetical order.
+      if (a.pseudoType === Protocol.DOM.PseudoType.Before && b.pseudoType !== Protocol.DOM.PseudoType.Before) {
+        return -1;
+      }
+      if (a.pseudoType !== Protocol.DOM.PseudoType.Before && b.pseudoType === Protocol.DOM.PseudoType.Before) {
+        return 1;
+      }
+      if (a.pseudoType < b.pseudoType) {
+        return -1;
+      }
+      if (a.pseudoType > b.pseudoType) {
+        return 1;
+      }
+      return 0;
+    });
+
     for (const pseudo of pseudoRulesets) {
       lastParentNode = null;
       for (let i = 0; i < pseudo.pseudoStyles.length; ++i) {

package/front_end/panels/elements/components/adornerSettingsPane.css

@@ -57,6 +57,11 @@
   border-radius: 2px;
 }
 
+.close:hover,
+.close:focus {
+  background-color: var(--color-background-elevation-2);
+}
+
 .close::before {
   transform: rotate(45deg);
 }

package/front_end/panels/elements/stylesSectionTree.css

@@ -126,6 +126,10 @@ ol.expanded {
   opacity: 50%;
 }
 
+.changed {
+  background-color: var(--color-accent-green-background);
+}
+
 .changed::after {
   content: "";
   position: absolute;
@@ -140,10 +144,6 @@ ol.expanded {
   display: none;
 }
 
-.changed:hover {
-  background-color: var(--color-accent-green-background);
-}
-
 .changed:hover .copy {
   position: absolute;
   right: -4px;

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -536,6 +536,10 @@ export class DebuggerPlugin extends Plugin {
     return true;
   }
 
+  private isVariableIdentifier(tokenType: string): boolean {
+    return tokenType === 'VariableName' || tokenType === 'VariableDefinition';
+  }
+
   private isIdentifier(tokenType: string): boolean {
     return tokenType === 'VariableName' || tokenType === 'VariableDefinition' || tokenType === 'PropertyName' ||
         tokenType === 'PropertyDefinition';
@@ -962,8 +966,8 @@ export class DebuggerPlugin extends Plugin {
     tree.iterate({
       from: fromPos,
       to: toPos,
-      enter(node): void {
-        const varName = node.name === 'VariableName' && editorState.sliceDoc(node.from, node.to);
+      enter: node => {
+        const varName = this.isVariableIdentifier(node.name) && editorState.sliceDoc(node.from, node.to);
         if (varName && variableMap.has(varName)) {
           if (node.from > curLine.to) {
             curLine = editorState.doc.lineAt(node.from);

package/front_end/panels/sources/SourcesPanel.ts

@@ -439,6 +439,14 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
     return this.sourcesViewInternal.searchableView();
   }
 
+  toggleNavigatorSidebar(): void {
+    this.editorView.toggleSidebar();
+  }
+
+  toggleDebuggerSidebar(): void {
+    this.splitWidget.toggleSidebar();
+  }
+
   private debuggerPaused(event: Common.EventTarget.EventTargetEvent<SDK.DebuggerModel.DebuggerModel>): void {
     const debuggerModel = event.data;
     const details = debuggerModel.debuggerPausedDetails();
@@ -1285,18 +1293,18 @@ export class RevealingActionDelegate implements UI.ActionRegistration.ActionDele
   }
 }
 
-let debuggingActionDelegateInstance: DebuggingActionDelegate;
+let actionDelegateInstance: ActionDelegate;
 
-export class DebuggingActionDelegate implements UI.ActionRegistration.ActionDelegate {
+export class ActionDelegate implements UI.ActionRegistration.ActionDelegate {
   static instance(opts: {
     forceNew: boolean|null,
-  } = {forceNew: null}): DebuggingActionDelegate {
+  } = {forceNew: null}): ActionDelegate {
     const {forceNew} = opts;
-    if (!debuggingActionDelegateInstance || forceNew) {
-      debuggingActionDelegateInstance = new DebuggingActionDelegate();
+    if (!actionDelegateInstance || forceNew) {
+      actionDelegateInstance = new ActionDelegate();
     }
 
-    return debuggingActionDelegateInstance;
+    return actionDelegateInstance;
   }
   handleAction(context: UI.Context.Context, actionId: string): boolean {
     const panel = SourcesPanel.instance();
@@ -1340,6 +1348,14 @@ export class DebuggingActionDelegate implements UI.ActionRegistration.ActionDele
         }
         return true;
       }
+      case 'sources.toggle-navigator-sidebar': {
+        panel.toggleNavigatorSidebar();
+        return true;
+      }
+      case 'sources.toggle-debugger-sidebar': {
+        panel.toggleDebuggerSidebar();
+        return true;
+      }
     }
     return false;
   }

package/front_end/panels/sources/sources-legacy.ts

@@ -189,7 +189,7 @@ Sources.SourcesPanel.DebuggerPausedDetailsRevealer = SourcesModule.SourcesPanel.
 Sources.SourcesPanel.RevealingActionDelegate = SourcesModule.SourcesPanel.RevealingActionDelegate;
 
 /** @constructor */
-Sources.SourcesPanel.DebuggingActionDelegate = SourcesModule.SourcesPanel.DebuggingActionDelegate;
+Sources.SourcesPanel.ActionDelegate = SourcesModule.SourcesPanel.ActionDelegate;
 
 /** @constructor */
 Sources.SourcesPanel.WrapperView = SourcesModule.SourcesPanel.WrapperView;

package/front_end/panels/sources/sources-meta.ts

@@ -378,6 +378,14 @@ const UIStrings = {
   * comes to a halt.
   */
   enableAutoFocusOnDebuggerPaused: 'Focus Sources panel when triggering a breakpoint',
+  /**
+  * @description Text for command of toggling navigator sidebar in Sources panel
+  */
+  toggleNavigatorSidebar: 'Toggle navigator sidebar',
+  /**
+  * @description Text for command of toggling debugger sidebar in Sources panel
+  */
+  toggleDebuggerSidebar: 'Toggle debugger sidebar',
 
 };
 const str_ = i18n.i18n.registerUIStrings('panels/sources/sources-meta.ts', UIStrings);
@@ -567,7 +575,7 @@ UI.ActionRegistration.registerActionExtension({
   actionId: 'debugger.step-over',
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
 
   title: i18nLazyString(UIStrings.stepOverNextFunctionCall),
@@ -599,7 +607,7 @@ UI.ActionRegistration.registerActionExtension({
   actionId: 'debugger.step-into',
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
   title: i18nLazyString(UIStrings.stepIntoNextFunctionCall),
   iconClass: UI.ActionRegistration.IconClass.LARGE_ICON_STEP_INTO,
@@ -630,7 +638,7 @@ UI.ActionRegistration.registerActionExtension({
   actionId: 'debugger.step',
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
   title: i18nLazyString(UIStrings.step),
   iconClass: UI.ActionRegistration.IconClass.LARGE_ICON_STEP,
@@ -652,7 +660,7 @@ UI.ActionRegistration.registerActionExtension({
   actionId: 'debugger.step-out',
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
   title: i18nLazyString(UIStrings.stepOutOfCurrentFunction),
   iconClass: UI.ActionRegistration.IconClass.LARGE_ICON_STEP_OUT,
@@ -683,7 +691,7 @@ UI.ActionRegistration.registerActionExtension({
   category: UI.ActionRegistration.ActionCategory.DEBUGGER,
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
   title: i18nLazyString(UIStrings.runSnippet),
   iconClass: UI.ActionRegistration.IconClass.LARGEICON_PLAY,
@@ -709,7 +717,7 @@ UI.ActionRegistration.registerActionExtension({
   toggleable: true,
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
   contextTypes() {
     return maybeRetrieveContextTypes(Sources => [Sources.SourcesView.SourcesView]);
@@ -764,7 +772,7 @@ UI.ActionRegistration.registerActionExtension({
   category: UI.ActionRegistration.ActionCategory.DEBUGGER,
   async loadActionDelegate() {
     const Sources = await loadSourcesModule();
-    return Sources.SourcesPanel.DebuggingActionDelegate.instance();
+    return Sources.SourcesPanel.ActionDelegate.instance();
   },
   title: i18nLazyString(UIStrings.evaluateSelectedTextInConsole),
   contextTypes() {
@@ -1240,6 +1248,52 @@ UI.ActionRegistration.registerActionExtension({
   ],
 });
 
+UI.ActionRegistration.registerActionExtension({
+  actionId: 'sources.toggle-navigator-sidebar',
+  category: UI.ActionRegistration.ActionCategory.SOURCES,
+  title: i18nLazyString(UIStrings.toggleNavigatorSidebar),
+  async loadActionDelegate() {
+    const Sources = await loadSourcesModule();
+    return Sources.SourcesPanel.ActionDelegate.instance();
+  },
+  contextTypes() {
+    return maybeRetrieveContextTypes(Sources => [Sources.SourcesView.SourcesView]);
+  },
+  bindings: [
+    {
+      platform: UI.ActionRegistration.Platforms.WindowsLinux,
+      shortcut: 'Ctrl+Shift+y',
+    },
+    {
+      platform: UI.ActionRegistration.Platforms.Mac,
+      shortcut: 'Meta+Shift+y',
+    },
+  ],
+});
+
+UI.ActionRegistration.registerActionExtension({
+  actionId: 'sources.toggle-debugger-sidebar',
+  category: UI.ActionRegistration.ActionCategory.SOURCES,
+  title: i18nLazyString(UIStrings.toggleDebuggerSidebar),
+  async loadActionDelegate() {
+    const Sources = await loadSourcesModule();
+    return Sources.SourcesPanel.ActionDelegate.instance();
+  },
+  contextTypes() {
+    return maybeRetrieveContextTypes(Sources => [Sources.SourcesView.SourcesView]);
+  },
+  bindings: [
+    {
+      platform: UI.ActionRegistration.Platforms.WindowsLinux,
+      shortcut: 'Ctrl+Shift+h',
+    },
+    {
+      platform: UI.ActionRegistration.Platforms.Mac,
+      shortcut: 'Meta+Shift+h',
+    },
+  ],
+});
+
 Common.Settings.registerSettingExtension({
   settingName: 'navigatorGroupByFolder',
   settingType: Common.Settings.SettingType.BOOLEAN,

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -29,7 +29,7 @@ export const markdownLinks = new Map<string, string>([
   ['sameSiteAndSameOrigin', 'https://web.dev/same-site-same-origin/'],
   // Link URLs for deprecation issues (see blink::Deprecation)
   ['https://xhr.spec.whatwg.org/', 'https://xhr.spec.whatwg.org/'],
-  ['https://goo.gl/rStTGz', 'https://goo.gl/rStTGz'],
+  ['https://goo.gle/chrome-insecure-origins', 'https://goo.gle/chrome-insecure-origins'],
   ['https://webrtc.org/web-apis/chrome/unified-plan/', 'https://webrtc.org/web-apis/chrome/unified-plan/'],
   [
     'https://developer.chrome.com/blog/enabling-shared-array-buffer/',

package/front_end/ui/legacy/SplitWidget.ts

@@ -61,6 +61,8 @@ export class SplitWidget extends Common.ObjectWrapper.eventMixin<EventTypes, typ
   private animationCallback: (() => void)|null;
   private showSidebarButtonTitle: Common.UIString.LocalizedString;
   private hideSidebarButtonTitle: Common.UIString.LocalizedString;
+  private shownSidebarString: Common.UIString.LocalizedString;
+  private hiddenSidebarString: Common.UIString.LocalizedString;
   private showHideSidebarButton: ToolbarButton|null;
   private isVerticalInternal: boolean;
   private sidebarMinimized: boolean;
@@ -111,6 +113,8 @@ export class SplitWidget extends Common.ObjectWrapper.eventMixin<EventTypes, typ
     this.animationCallback = null;
     this.showSidebarButtonTitle = Common.UIString.LocalizedEmptyString;
     this.hideSidebarButtonTitle = Common.UIString.LocalizedEmptyString;
+    this.shownSidebarString = Common.UIString.LocalizedEmptyString;
+    this.hiddenSidebarString = Common.UIString.LocalizedEmptyString;
     this.showHideSidebarButton = null;
     this.isVerticalInternal = false;
     this.sidebarMinimized = false;
@@ -821,23 +825,29 @@ export class SplitWidget extends Common.ObjectWrapper.eventMixin<EventTypes, typ
       shownString: Common.UIString.LocalizedString, hiddenString: Common.UIString.LocalizedString): ToolbarButton {
     this.showSidebarButtonTitle = showTitle;
     this.hideSidebarButtonTitle = hideTitle;
+    this.shownSidebarString = shownString;
+    this.hiddenSidebarString = hiddenString;
     this.showHideSidebarButton = new ToolbarButton('', '');
     this.showHideSidebarButton.addEventListener(ToolbarButton.Events.Click, buttonClicked, this);
     this.updateShowHideSidebarButton();
 
     function buttonClicked(this: SplitWidget): void {
-      if (this.showModeInternal !== ShowMode.Both) {
-        this.showBoth(true);
-        ARIAUtils.alert(shownString);
-      } else {
-        this.hideSidebar(true);
-        ARIAUtils.alert(hiddenString);
-      }
+      this.toggleSidebar();
     }
 
     return this.showHideSidebarButton;
   }
 
+  toggleSidebar(): void {
+    if (this.showModeInternal !== ShowMode.Both) {
+      this.showBoth(true);
+      ARIAUtils.alert(this.shownSidebarString);
+    } else {
+      this.hideSidebar(true);
+      ARIAUtils.alert(this.hiddenSidebarString);
+    }
+  }
+
   private updateShowHideSidebarButton(): void {
     if (!this.showHideSidebarButton) {
       return;

package/front_end/ui/legacy/themeColors.css

@@ -124,6 +124,7 @@
   --color-button-primary-background-hovering: rgb(77 134 225 / 100%);
   --color-button-primary-background-pressed: rgb(88 132 205);
   --color-button-primary-text: rgb(255 255 255);
+  --color-button-primary-text-hover: rgb(218 220 224);
   --color-button-secondary-background-hovering: rgb(26 115 232 / 10%);
   --color-button-secondary-background-pressed: rgb(26 92 178 / 25%);
   --color-button-secondary-border: rgb(218 220 224);
@@ -272,6 +273,7 @@
   --color-button-primary-background-hovering: rgb(174 203 250 / 100%);
   --color-button-primary-background-pressed: rgb(210 227 252 / 100%);
   --color-button-primary-text: rgb(0 0 0);
+  --color-button-primary-text-hover: rgb(60 61 65);
   --color-button-secondary-background-hovering: rgb(138 180 248 / 15%);
   --color-button-secondary-background-pressed: rgb(138 180 248 / 23%);
   --color-button-secondary-border: rgb(60 61 65);

package/front_end/ui/legacy/toolbar.css

@@ -459,10 +459,14 @@ input[is="history-input"]:not(:placeholder-shown) {
   z-index: -1;
 }
 
-.toolbar-item.highlight {
+.toolbar-item.highlight > .title {
   color: var(--color-button-primary-text);
 }
 
+.toolbar-item.highlight:hover:not(:active) > .title {
+  color: var(--color-button-primary-text-hover);
+}
+
 .toolbar-item.highlight:focus-visible {
   background: var(--color-primary-variant);
 }

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.996595"
+  "version": "1.0.998045"
 }

package/scripts/eslint_rules/lib/lit_template_result_or_nothing.js

@@ -0,0 +1,140 @@
+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+module.exports = {
+  meta: {
+    type: 'problem',
+
+    docs: {
+      description: 'Enforce use of LitHtml.LitTemplate type rather than union with LitHtml.nothing',
+      category: 'Possible Errors',
+    },
+    fixable: 'code',
+    messages: {
+      useLitTemplateOverEmptyObject:
+          'Prefer LitHtml.LitTemplate type over a union with {}',
+      useLitTemplateOverTypeOfNothing:
+          'Prefer LitHtml.LitTemplate type over a union with LitHtml.nothing',
+    },
+    schema: []  // no options
+  },
+  create: function(context) {
+    const sourceCode = context.getSourceCode();
+    const UNION_TYPE_FOR_LIT_TEMPLATE = 'LitHtml.LitTemplate';
+
+    function checkUnionReturnTypeForLit(node) {
+      // We want to go through the types in the union and match if:
+      // 1. We find `LitHtml.TemplateResult` and `{}`
+      // 2. We find `LitHtml.TemplateResult` and `LitHtml.nothing`.
+      // Otherwise, this node is OK.
+
+      let templateResultNode = null;
+      let literalEmptyObjectNode = null;
+      let litNothingNode = null;
+
+      const nonLitRelatedNodesInUnion = new Set();
+
+      for (const typeNode of node.types) {
+        // This matches a type reference of X.y. Now we see if X === 'LitHtml' and y === 'TemplateResult'
+        if (typeNode.type === 'TSTypeReference' && typeNode.typeName.type === 'TSQualifiedName') {
+          const leftText = typeNode.typeName.left.name;
+          const rightText = typeNode.typeName.right.name;
+          if (leftText === 'LitHtml' && rightText === 'TemplateResult') {
+            templateResultNode = typeNode;
+            continue;
+          }
+        } else if (typeNode.type === 'TSTypeLiteral') {
+          // The TSTypeLiteral type matches against the literal `{}` type.
+          literalEmptyObjectNode = typeNode;
+          continue;
+        } else if (typeNode.type === 'TSTypeQuery' && typeNode.exprName.type === 'TSQualifiedName') {
+          // matches `typeof X.y`
+          const leftText = typeNode.exprName.left.name;
+          const rightText = typeNode.exprName.right.name;
+          if (leftText === 'LitHtml' && rightText === 'nothing') {
+            litNothingNode = typeNode;
+            continue;
+          }
+        }
+
+        nonLitRelatedNodesInUnion.add(typeNode);
+      }
+
+      // We didn't find LitHtml.TemplateResult, so bail.
+      if (!templateResultNode) {
+        return;
+      }
+
+      if (!litNothingNode && !literalEmptyObjectNode) {
+        // We found TemplateResult with no `typeof LitHtml.nothing` or `{}`, so
+        // bail.
+        return;
+      }
+
+      // If we found a union type of:
+      // LitHtml.TemplateResult|{}|number
+      // That needs to become:
+      // LitHtml.LitTemplate|number
+      // So we capture all the non-lit related types in the union, and get
+      // their text content, so we can keep them around when we run the fixer.
+      const nonLitRelatedTypesToKeep = Array.from(nonLitRelatedNodesInUnion, node => {
+        return sourceCode.getText(node);
+      });
+      const newText = [UNION_TYPE_FOR_LIT_TEMPLATE, ...nonLitRelatedTypesToKeep].join('|');
+
+      context.report({
+        node,
+        messageId: litNothingNode ? 'useLitTemplateOverTypeOfNothing' : 'useLitTemplateOverEmptyObject',
+        fix(fixer) {
+          return fixer.replaceText(node, newText);
+        }
+      });
+    }
+
+    function checkTSTypeAnnotationForPotentialIssue(node) {
+      const annotation = node.typeAnnotation;
+      if (annotation.type === 'TSUnionType') {
+        // matches foo(): X|Y
+        checkUnionReturnTypeForLit(annotation);
+      } else if (annotation.type === 'TSTypeReference') {
+        // matches many things, including foo(): Promise<X|Y>, which we do want
+        // to check.
+
+        if (annotation.typeName.name !== 'Promise') {
+          // If it's not a promise, bail out.
+          return;
+        }
+        // Represents the generic type passed to the promise: if our code is
+        // Promise<X>, this node represents the X.
+        const promiseGenericNode = annotation.typeParameters.params[0];
+        if (promiseGenericNode && promiseGenericNode.type === 'TSUnionType') {
+          checkUnionReturnTypeForLit(promiseGenericNode);
+        }
+      }
+    }
+
+    function checkFunctionDeclarationOrExpressionForUnionType(node) {
+      if (node.returnType.type !== 'TSTypeAnnotation') {
+        return;
+      }
+      checkTSTypeAnnotationForPotentialIssue(node.returnType);
+    }
+
+    return {
+      // function() {}
+      FunctionDeclaration(node) {
+        checkFunctionDeclarationOrExpressionForUnionType(node);
+      },
+      // Match functions defined inside classes
+      FunctionExpression(node) {
+        checkFunctionDeclarationOrExpressionForUnionType(node);
+      },
+      // Match values in interfaces or types.
+      TSPropertySignature(node) {
+        checkTSTypeAnnotationForPotentialIssue(node.typeAnnotation);
+      },
+    };
+  }
+};

package/scripts/eslint_rules/lib/no_only_eslint_tests.js

@@ -17,6 +17,10 @@ module.exports = {
   create: function(context) {
     function checkForOnlyInTestCases(testCaseObjects) {
       for (const testCase of testCaseObjects) {
+        if (!testCase || !testCase.properties) {
+          continue;
+        }
+
         const onlyKeyProp = testCase.properties.find(prop => {
           return prop.key.name === 'only';
         });
@@ -37,7 +41,7 @@ module.exports = {
         // second argument = rule itself
         // third argument = the object containing the test cases - what we want!
         const tests = node.arguments[2];
-        if (!tests) {
+        if (!tests || !tests.properties) {
           return;
         }