chrome-devtools-frontend 1.0.980193 → 1.0.981004

package/front_end/panels/sources/NavigatorView.ts

@@ -28,6 +28,8 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+// TODO(crbug.com/1253323): Casts to Branded Types will be removed from this file when migration to branded types is complete.
+
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
@@ -843,7 +845,7 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
   }
 
   handleFolderContextMenu(event: Event, node: NavigatorTreeNode): void {
-    const path = (node as NavigatorFolderTreeNode).folderPath || '';
+    const path = (node as NavigatorFolderTreeNode).folderPath || Platform.DevToolsPath.EmptyEncodedPathString;
     const project = (node as NavigatorFolderTreeNode).project || null;
 
     const contextMenu = new UI.ContextMenu.ContextMenu(event);
@@ -914,7 +916,7 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
     if (uiSourceCodeToCopy) {
       content = (await uiSourceCodeToCopy.requestContent()).content || '';
     }
-    const uiSourceCode = await project.createFile(path, null, content);
+    const uiSourceCode = await project.createFile(path as Platform.DevToolsPath.EncodedPathString, null, content);
     if (!uiSourceCode) {
       return;
     }
@@ -1413,7 +1415,9 @@ export class NavigatorUISourceCodeTreeNode extends NavigatorTreeNode {
         if (this.treeElement) {
           this.treeElement.title = newTitle;
         }
-        void this.uiSourceCodeInternal.rename(newTitle).then(renameCallback.bind(this));
+        // necessary cast to RawPathString as alternative would be altering type of Config<T>
+        void this.uiSourceCodeInternal.rename(newTitle as Platform.DevToolsPath.RawPathString)
+            .then(renameCallback.bind(this));
         return;
       }
       afterEditing.call(this, true);
@@ -1453,7 +1457,7 @@ export class NavigatorUISourceCodeTreeNode extends NavigatorTreeNode {
 
 export class NavigatorFolderTreeNode extends NavigatorTreeNode {
   project: Workspace.Workspace.Project|null;
-  readonly folderPath: string;
+  readonly folderPath: Platform.DevToolsPath.EncodedPathString;
   title: string;
   treeElement!: NavigatorFolderTreeElement|null;
   constructor(
@@ -1461,7 +1465,7 @@ export class NavigatorFolderTreeNode extends NavigatorTreeNode {
       folderPath: string, title: string) {
     super(navigatorView, id, type);
     this.project = project;
-    this.folderPath = folderPath;
+    this.folderPath = folderPath as Platform.DevToolsPath.EncodedPathString;
     this.title = title;
   }
 

package/front_end/panels/sources/SourcesNavigator.ts

@@ -31,9 +31,9 @@
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Persistence from '../../models/persistence/persistence.js';
-import type * as Platform from '../../core/platform/platform.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Snippets from '../snippets/snippets.js';
@@ -406,7 +406,7 @@ export class ActionDelegate implements UI.ActionRegistration.ActionDelegate {
     switch (actionId) {
       case 'sources.create-snippet':
         void Snippets.ScriptSnippetFileSystem.findSnippetsProject()
-            .createFile('', null, '')
+            .createFile(Platform.DevToolsPath.EmptyEncodedPathString, null, '')
             .then(uiSourceCode => Common.Revealer.reveal(uiSourceCode));
         return true;
       case 'sources.add-folder-to-workspace':

package/front_end/ui/components/buttons/Button.ts

@@ -18,6 +18,7 @@ export const enum Variant {
   PRIMARY = 'primary',
   SECONDARY = 'secondary',
   TOOLBAR = 'toolbar',
+  ROUND = 'round',
 }
 
 export const enum Size {
@@ -40,7 +41,7 @@ interface ButtonState {
 }
 
 export type ButtonData = {
-  variant: Variant.TOOLBAR,
+  variant: Variant.TOOLBAR|Variant.ROUND,
   iconUrl: string,
   size?: Size,
   disabled?: boolean,
@@ -199,10 +200,19 @@ export class Button extends HTMLElement {
         throw new Error('Tooblar button does not accept children');
       }
     }
+    if (this.#props.variant === Variant.ROUND) {
+      if (!this.#props.iconUrl) {
+        throw new Error('Round button requires an icon');
+      }
+      if (!this.#isEmpty) {
+        throw new Error('Round button does not accept children');
+      }
+    }
     const classes = {
       primary: this.#props.variant === Variant.PRIMARY,
       secondary: this.#props.variant === Variant.SECONDARY,
       toolbar: this.#props.variant === Variant.TOOLBAR,
+      round: this.#props.variant === Variant.ROUND,
       'text-with-icon': Boolean(this.#props.iconUrl) && !this.#isEmpty,
       'only-icon': Boolean(this.#props.iconUrl) && this.#isEmpty,
       small: Boolean(this.#props.size === Size.SMALL),

package/front_end/ui/components/buttons/button.css

@@ -49,7 +49,8 @@ button:focus-visible {
   box-shadow: 0 0 0 2px var(--color-button-outline-focus);
 }
 
-button.toolbar {
+button.toolbar,
+button.round {
   background: transparent;
   border-radius: 2px;
   border: none;
@@ -60,11 +61,22 @@ button.toolbar {
   white-space: nowrap;
 }
 
+button.round {
+  border-radius: 100%;
+  height: 30px;
+  width: 30px;
+}
+
 button.toolbar.small {
   height: 18px;
   width: 18px;
 }
 
+button.round.small {
+  height: 24px;
+  width: 24px;
+}
+
 button.primary {
   border: 1px solid var(--color-primary);
   background: var(--color-primary);
@@ -123,21 +135,27 @@ button.secondary:active:focus-visible {
   border: 1px solid var(--color-button-secondary-background-pressed);
 }
 
-button.toolbar:hover {
-  background-color: var(--color-button-secondary-background-hovering);
+button.toolbar:hover,
+button.round:hover {
+  background-color: var(--color-iconbutton-hover);
 }
 
 button.toolbar.active,
-button.toolbar:active {
-  background-color: var(--color-button-secondary-background-pressed);
+button.toolbar:active,
+button.round.active,
+button.round:active {
+  background-color: var(--color-iconbutton-pressed);
 }
 
-button.toolbar:focus-visible {
+button.toolbar:focus-visible,
+button.round:focus-visible {
   background-color: var(--color-background-elevation-2);
 }
 
 button.toolbar:disabled,
-button.toolbar:disabled:hover {
+button.toolbar:disabled:hover,
+button.round:disabled,
+button.round:disabled:hover {
   background: var(--color-background);
   color: var(--color-text-disabled);
   cursor: not-allowed;
@@ -160,7 +178,8 @@ button devtools-icon {
   height: 19px;
 }
 
-button.toolbar devtools-icon {
+button.toolbar devtools-icon,
+button.round devtools-icon {
   width: 24px;
   height: 24px;
 
@@ -180,7 +199,8 @@ button.small devtools-icon {
   height: 14px;
 }
 
-button.toolbar.small devtools-icon {
+button.toolbar.small devtools-icon,
+button.round.small devtools-icon {
   width: 18px;
   height: 18px;
 }
@@ -194,7 +214,8 @@ button.toolbar:hover devtools-icon {
   --icon-color: var(--color-text-primary);
 }
 
-button.toolbar:disabled devtools-icon {
+button.toolbar:disabled devtools-icon,
+button.round:disabled devtools-icon {
   --icon-color: var(--color-text-disabled);
 }
 

package/front_end/ui/components/docs/button/basic.ts

@@ -190,7 +190,7 @@ disabledPrimaryIconButton.data = {
 disabledPrimaryIconButton.onclick = () => alert('clicked');
 appendButton(disabledPrimaryIconButton);
 
-// Disabled Secondary Icon Only
+// Small Disabled Secondary Icon Only
 const disabledSecondaryIconOnlyButton = new Buttons.Button.Button();
 disabledSecondaryIconOnlyButton.onclick = () => alert('clicked');
 disabledSecondaryIconOnlyButton.style.width = '18px';
@@ -202,6 +202,50 @@ disabledSecondaryIconOnlyButton.data = {
 };
 appendButton(disabledSecondaryIconOnlyButton);
 
+// Round Button
+const roundButton = new Buttons.Button.Button();
+roundButton.data = {
+  variant: Buttons.Button.Variant.ROUND,
+  iconUrl: testIcon,
+};
+roundButton.title = 'Round Button';
+roundButton.onclick = () => alert('clicked');
+appendButton(roundButton);
+
+// Disabled Round Button
+const roundButtonDisabled = new Buttons.Button.Button();
+roundButtonDisabled.data = {
+  variant: Buttons.Button.Variant.ROUND,
+  iconUrl: testIcon,
+  disabled: true,
+};
+roundButtonDisabled.title = 'Disabled Round Button';
+roundButtonDisabled.onclick = () => alert('clicked');
+appendButton(roundButtonDisabled);
+
+// Small Round Button
+const smallRoundButton = new Buttons.Button.Button();
+smallRoundButton.data = {
+  variant: Buttons.Button.Variant.ROUND,
+  iconUrl: testIcon,
+  size: Buttons.Button.Size.SMALL,
+};
+smallRoundButton.title = 'Small Round Button';
+smallRoundButton.onclick = () => alert('clicked');
+appendButton(smallRoundButton);
+
+// Small Disabled Round Button
+const smallRoundButtonDisabled = new Buttons.Button.Button();
+smallRoundButtonDisabled.data = {
+  variant: Buttons.Button.Variant.ROUND,
+  iconUrl: testIcon,
+  disabled: true,
+  size: Buttons.Button.Size.SMALL,
+};
+smallRoundButtonDisabled.title = 'Small Disabled Round Button';
+smallRoundButtonDisabled.onclick = () => alert('clicked');
+appendButton(smallRoundButtonDisabled);
+
 for (let i = 0; i < 6; i++) {
   // Regular Toolbar Button
   const toolbarButton = new Buttons.Button.Button();
@@ -245,6 +289,7 @@ for (let i = 0; i < 6; i++) {
   }
 }
 
+// Submit Button
 const submitButton = new Buttons.Button.Button();
 submitButton.data = {
   variant: Buttons.Button.Variant.PRIMARY,
@@ -253,6 +298,7 @@ submitButton.data = {
 submitButton.innerText = 'Submit';
 document.querySelector('#form')?.append(submitButton);
 
+// Reset Button
 const resetButton = new Buttons.Button.Button();
 resetButton.data = {
   variant: Buttons.Button.Variant.SECONDARY,

package/front_end/ui/legacy/themeColors.css

@@ -127,6 +127,8 @@
   --color-button-secondary-background-hovering: rgb(26 115 232 / 10%);
   --color-button-secondary-background-pressed: rgb(26 92 178 / 25%);
   --color-button-secondary-border: rgb(218 220 224);
+  --color-iconbutton-hover: rgb(0 0 0 / 10%);
+  --color-iconbutton-pressed: rgb(0 0 0 / 15%);
 
   /* Colors for file icons */
   --color-ic-file-document: rgb(39 116 240);
@@ -273,6 +275,8 @@
   --color-button-secondary-background-hovering: rgb(138 180 248 / 15%);
   --color-button-secondary-background-pressed: rgb(138 180 248 / 23%);
   --color-button-secondary-border: rgb(60 61 65);
+  --color-iconbutton-hover: rgb(255 255 255 / 12%);
+  --color-iconbutton-pressed: rgb(255 255 255 / 20%);
 
   /* Colors for file icons */
   --color-ic-file-document: rgb(39 116 240);

package/package.json

@@ -54,5 +54,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.980193"
+  "version": "1.0.981004"
 }