chrome-devtools-frontend 1.0.977952 → 1.0.978673

package/front_end/core/sdk/CSSRule.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import type * as Platform from '../platform/platform.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as TextUtils from '../../models/text_utils/text_utils.js';
 
@@ -44,9 +45,9 @@ export class CSSRule {
     this.style.rebase(edit);
   }
 
-  resourceURL(): string {
+  resourceURL(): Platform.DevToolsPath.UrlString {
     if (!this.styleSheetId) {
-      return '';
+      return '' as Platform.DevToolsPath.UrlString;
     }
     const styleSheetHeader = this.getStyleSheetHeader(this.styleSheetId);
     return styleSheetHeader.resourceURL();

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -423,15 +423,15 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
   }
 
   async fetchAppManifest(): Promise<{
-    url: string,
+    url: Platform.DevToolsPath.UrlString,
     data: string|null,
     errors: Array<Protocol.Page.AppManifestError>,
   }> {
     const response = await this.agent.invoke_getAppManifest();
     if (response.getError()) {
-      return {url: response.url, data: null, errors: []};
+      return {url: response.url as Platform.DevToolsPath.UrlString, data: null, errors: []};
     }
-    return {url: response.url, data: response.data || null, errors: response.errors};
+    return {url: response.url as Platform.DevToolsPath.UrlString, data: response.data || null, errors: response.errors};
   }
 
   async getInstallabilityErrors(): Promise<Protocol.Page.InstallabilityError[]> {

package/front_end/panels/application/AppManifestView.ts

@@ -16,8 +16,6 @@ import * as UI from '../../ui/legacy/legacy.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 
-// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
-
 const UIStrings = {
   /**
   *@description Text in App Manifest View of the Application panel
@@ -543,7 +541,7 @@ export class AppManifestView extends UI.Widget.VBox implements SDK.TargetManager
   }
 
   private async renderManifest(
-      url: string, data: string|null, errors: Protocol.Page.AppManifestError[],
+      url: Platform.DevToolsPath.UrlString, data: string|null, errors: Protocol.Page.AppManifestError[],
       installabilityErrors: Protocol.Page.InstallabilityError[], manifestIcons: {
         primaryIcon: string|null,
       },
@@ -642,12 +640,13 @@ export class AppManifestView extends UI.Widget.VBox implements SDK.TargetManager
 
     this.startURLField.removeChildren();
     if (startURL) {
-      const completeURL =
-          (Common.ParsedURL.ParsedURL.completeURL(url as Platform.DevToolsPath.UrlString, startURL) as string);
-      const link = Components.Linkifier.Linkifier.linkifyURL(
-          completeURL, ({text: startURL} as Components.Linkifier.LinkifyURLOptions));
-      link.tabIndex = 0;
-      this.startURLField.appendChild(link);
+      const completeURL = Common.ParsedURL.ParsedURL.completeURL(url, startURL);
+      if (completeURL) {
+        const link = Components.Linkifier.Linkifier.linkifyURL(
+            completeURL, ({text: startURL} as Components.Linkifier.LinkifyURLOptions));
+        link.tabIndex = 0;
+        this.startURLField.appendChild(link);
+      }
     }
 
     this.themeColorSwatch.classList.toggle('hidden', !stringProperty('theme_color'));
@@ -694,8 +693,7 @@ export class AppManifestView extends UI.Widget.VBox implements SDK.TargetManager
     this.newNoteUrlField.parentElement?.classList.toggle('hidden', !hasNewNoteUrl);
     this.newNoteUrlField.removeChildren();
     if (hasNewNoteUrl) {
-      const completeURL =
-          (Common.ParsedURL.ParsedURL.completeURL(url as Platform.DevToolsPath.UrlString, newNoteUrl) as string);
+      const completeURL = (Common.ParsedURL.ParsedURL.completeURL(url, newNoteUrl) as string);
       const link = Components.Linkifier.Linkifier.linkifyURL(
           completeURL, ({text: newNoteUrl} as Components.Linkifier.LinkifyURLOptions));
       link.tabIndex = 0;
@@ -765,8 +763,7 @@ export class AppManifestView extends UI.Widget.VBox implements SDK.TargetManager
         shortcutSection.appendFlexedField('Description', shortcut.description);
       }
       const urlField = shortcutSection.appendFlexedField('URL');
-      const shortcutUrl =
-          (Common.ParsedURL.ParsedURL.completeURL(url as Platform.DevToolsPath.UrlString, shortcut.url) as string);
+      const shortcutUrl = (Common.ParsedURL.ParsedURL.completeURL(url, shortcut.url) as string);
       const link = Components.Linkifier.Linkifier.linkifyURL(
           shortcutUrl, ({text: shortcut.url} as Components.Linkifier.LinkifyURLOptions));
       link.tabIndex = 0;
@@ -1018,7 +1015,8 @@ export class AppManifestView extends UI.Widget.VBox implements SDK.TargetManager
   private async appendImageResourceToSection(
       // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      baseUrl: string, imageResource: any, section: UI.ReportView.Section, isScreenshot: boolean):
+      baseUrl: Platform.DevToolsPath.UrlString, imageResource: any, section: UI.ReportView.Section,
+      isScreenshot: boolean):
       Promise<{imageResourceErrors: Platform.UIString.LocalizedString[], squareSizedIconAvailable?: boolean}> {
     const imageResourceErrors: Platform.UIString.LocalizedString[] = [];
     const resourceName = isScreenshot ? i18nString(UIStrings.screenshot) : i18nString(UIStrings.icon);
@@ -1026,8 +1024,7 @@ export class AppManifestView extends UI.Widget.VBox implements SDK.TargetManager
       imageResourceErrors.push(i18nString(UIStrings.sSrcIsNotSet, {PH1: resourceName}));
       return {imageResourceErrors};
     }
-    const imageUrl =
-        Common.ParsedURL.ParsedURL.completeURL(baseUrl as Platform.DevToolsPath.UrlString, imageResource['src']);
+    const imageUrl = Common.ParsedURL.ParsedURL.completeURL(baseUrl, imageResource['src']);
     if (!imageUrl) {
       imageResourceErrors.push(
           i18nString(UIStrings.sUrlSFailedToParse, {PH1: resourceName, PH2: imageResource['src']}));

package/front_end/panels/console/ErrorStackParser.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import type * as Platform from '../../core/platform/platform.js';
 import type * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 
@@ -81,10 +80,7 @@ export function parseSourcePositionsFromErrorStack(
     }
     let url = parseOrScriptMatch(debuggerModel, splitResult.url);
     if (!url && Common.ParsedURL.ParsedURL.isRelativeURL(splitResult.url)) {
-      // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
-      url = parseOrScriptMatch(
-          debuggerModel,
-          Common.ParsedURL.ParsedURL.completeURL(baseURL as Platform.DevToolsPath.UrlString, splitResult.url));
+      url = parseOrScriptMatch(debuggerModel, Common.ParsedURL.ParsedURL.completeURL(baseURL, splitResult.url));
     }
     if (!url) {
       return null;

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -3461,8 +3461,7 @@ export class StylesSidebarPropertyRenderer {
     UI.UIUtils.createTextChild(container, 'url(');
     let hrefUrl: (string|null)|null = null;
     if (this.rule && this.rule.resourceURL()) {
-      // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
-      hrefUrl = Common.ParsedURL.ParsedURL.completeURL(this.rule.resourceURL() as Platform.DevToolsPath.UrlString, url);
+      hrefUrl = Common.ParsedURL.ParsedURL.completeURL(this.rule.resourceURL(), url);
     } else if (this.node) {
       hrefUrl = this.node.resolveURL(url);
     }

package/front_end/panels/snippets/ScriptSnippetFileSystem.ts

@@ -13,6 +13,8 @@ import type * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 
+// TODO(crbug.com/1253323): Cast to EncodedPathString will be removed from this file when migration to branded types is complete.
+
 const UIStrings = {
   /**
   *@description Default snippet name when a new snippet is created in the Sources panel
@@ -40,7 +42,6 @@ export class SnippetFileSystem extends Persistence.PlatformFileSystem.PlatformFi
   private readonly lastSnippetIdentifierSetting: Common.Settings.Setting<number>;
   private readonly snippetsSetting: Common.Settings.Setting<Snippet[]>;
   constructor() {
-    // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
     super('snippet://', 'snippets');
     this.lastSnippetIdentifierSetting =
         Common.Settings.Settings.instance().createSetting('scriptSnippets_lastIdentifier', 0);

package/front_end/ui/legacy/components/utils/ImagePreview.ts

@@ -178,7 +178,7 @@ export class ImagePreview {
 
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // @ts-expect-error
-    const featuresObject = object.callFunctionJSON(features, undefined);
+    const featuresObject = await object.callFunctionJSON(features, undefined);
     object.release();
     return featuresObject;
 

package/package.json

@@ -54,5 +54,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.977952"
+  "version": "1.0.978673"
 }