chrome-devtools-frontend 1.0.970539 → 1.0.972865

package/front_end/ui/legacy/ViewManager.ts

@@ -423,7 +423,7 @@ export class _ExpandableContainerWidget extends VBox {
 
     this.titleElement = document.createElement('div');
     this.titleElement.classList.add('expandable-view-title');
-    ARIAUtils.markAsButton(this.titleElement);
+    ARIAUtils.markAsTab(this.titleElement);
     this.titleExpandIcon = Icon.create('smallicon-triangle-right', 'title-expand-icon');
     this.titleElement.appendChild(this.titleExpandIcon);
     const titleText = view.title();
@@ -847,6 +847,7 @@ class _StackLocation extends Location implements ViewLocation {
     const vbox = new VBox();
     super(manager, vbox, revealCallback);
     this.vbox = vbox;
+    ARIAUtils.markAsTablist(vbox.element);
 
     this.expandableContainers = new Map();
 

package/front_end/ui/legacy/closeButton.css

@@ -7,7 +7,6 @@
 .close-button {
   width: 14px;
   height: 14px;
-  cursor: default;
   display: flex;
   align-items: center;
   justify-content: center;

package/front_end/ui/legacy/components/source_frame/BinaryResourceViewFactory.ts

@@ -3,10 +3,13 @@
 // found in the LICENSE file.
 
 import type * as Common from '../../../../core/common/common.js';
+import type * as Platform from '../../../../core/platform/platform.js';
 import * as TextUtils from '../../../../models/text_utils/text_utils.js';
 
 import {ResourceSourceFrame} from './ResourceSourceFrame.js';
 
+// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
+
 export class BinaryResourceViewFactory {
   private base64content: string;
   private readonly contentUrl: string;
@@ -67,8 +70,8 @@ export class BinaryResourceViewFactory {
   }
 
   createHexView(): ResourceSourceFrame {
-    const hexViewerContentProvider =
-        new TextUtils.StaticContentProvider.StaticContentProvider(this.contentUrl, this.resourceType, async () => {
+    const hexViewerContentProvider = new TextUtils.StaticContentProvider.StaticContentProvider(
+        this.contentUrl as Platform.DevToolsPath.UrlString, this.resourceType, async () => {
           const contentAsArray = await this.fetchContentAsArray();
           const content = BinaryResourceViewFactory.uint8ArrayToHexViewer(contentAsArray);
           return {content, isEncoded: false};
@@ -79,8 +82,8 @@ export class BinaryResourceViewFactory {
 
   createUtf8View(): ResourceSourceFrame {
     const utf8fn = this.utf8.bind(this);
-    const utf8ContentProvider =
-        new TextUtils.StaticContentProvider.StaticContentProvider(this.contentUrl, this.resourceType, utf8fn);
+    const utf8ContentProvider = new TextUtils.StaticContentProvider.StaticContentProvider(
+        this.contentUrl as Platform.DevToolsPath.UrlString, this.resourceType, utf8fn);
     return new ResourceSourceFrame(
         utf8ContentProvider, this.resourceType.canonicalMimeType(), {lineNumbers: true, lineWrapping: true});
   }

package/front_end/ui/legacy/components/source_frame/FontView.ts

@@ -51,7 +51,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/source_frame/FontView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export class FontView extends UI.View.SimpleView {
-  private readonly url: string;
+  private readonly url: Platform.DevToolsPath.UrlString;
   private readonly mimeType: string;
   private readonly contentProvider: TextUtils.ContentProvider.ContentProvider;
   private readonly mimeTypeLabel: UI.Toolbar.ToolbarText;

package/front_end/ui/legacy/components/source_frame/ImageView.ts

@@ -84,7 +84,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/source_frame/ImageView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export class ImageView extends UI.View.SimpleView {
-  private url: string;
+  private url: Platform.DevToolsPath.UrlString;
   private parsedURL: Common.ParsedURL.ParsedURL;
   private readonly mimeType: string;
   private readonly contentProvider: TextUtils.ContentProvider.ContentProvider;

package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts

@@ -120,9 +120,8 @@ export function buildStackTraceRows(
       const rowCountHide = regularRowCount > 30 && stackTrace.callFrames.length > 31;
       let ignoreListHide = false;
       const functionName = UI.UIUtils.beautifyFunctionName(stackFrame.functionName);
-      const link = linkifier.maybeLinkifyConsoleCallFrame(
-          target, stackFrame,
-          {tabStop: Boolean(tabStops), className: undefined, columnNumber: undefined, inlineFrameIndex: 0});
+      const link =
+          linkifier.maybeLinkifyConsoleCallFrame(target, stackFrame, {tabStop: Boolean(tabStops), inlineFrameIndex: 0});
       if (link) {
         link.addEventListener('contextmenu', populateContextMenu.bind(null, link));
         // TODO(crbug.com/1183325): fix race condition with uiLocation still being null here

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -195,17 +195,14 @@ export class Linkifier implements SDK.TargetManager.Observer {
       target: SDK.Target.Target|null, scriptId: Protocol.Runtime.ScriptId|null, sourceURL: string,
       lineNumber: number|undefined, options?: LinkifyOptions): HTMLElement|null {
     let fallbackAnchor: HTMLElement|null = null;
-    const linkifyURLOptions = {
+    const linkifyURLOptions: LinkifyURLOptions = {
       lineNumber,
       maxLength: this.maxLength,
-      columnNumber: options ? options.columnNumber : undefined,
+      columnNumber: options?.columnNumber,
       showColumnNumber: Boolean(options?.showColumnNumber),
-      className: options ? options.className : undefined,
-      tabStop: options ? options.tabStop : undefined,
-      inlineFrameIndex: options ? options.inlineFrameIndex : 0,
-      text: undefined,
-      preventClick: undefined,
-      bypassURLTrimming: undefined,
+      className: options?.className,
+      tabStop: options?.tabStop,
+      inlineFrameIndex: options?.inlineFrameIndex ?? 0,
     };
     const {columnNumber, className = ''} = linkifyURLOptions;
     if (sourceURL) {
@@ -230,13 +227,8 @@ export class Linkifier implements SDK.TargetManager.Observer {
       return fallbackAnchor;
     }
 
-    const createLinkOptions = {
-      maxLength: undefined,
-      title: undefined,
-      href: undefined,
-      preventClick: undefined,
-      bypassURLTrimming: undefined,
-      tabStop: options ? options.tabStop : undefined,
+    const createLinkOptions: _CreateLinkOptions = {
+      tabStop: options?.tabStop,
     };
     // Not initialising the anchor element with 'zero width space' (\u200b) causes a crash
     // in the layout engine.
@@ -275,17 +267,14 @@ export class Linkifier implements SDK.TargetManager.Observer {
       target: SDK.Target.Target|null, scriptId: Protocol.Runtime.ScriptId|null, sourceURL: string,
       lineNumber: number|undefined, options?: LinkifyOptions): HTMLElement {
     const scriptLink = this.maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, options);
-    const linkifyURLOptions = {
+    const linkifyURLOptions: LinkifyURLOptions = {
       lineNumber,
       maxLength: this.maxLength,
-      className: options ? options.className : undefined,
-      columnNumber: options ? options.columnNumber : undefined,
+      className: options?.className,
+      columnNumber: options?.columnNumber,
       showColumnNumber: Boolean(options?.showColumnNumber),
-      inlineFrameIndex: options ? options.inlineFrameIndex : 0,
-      tabStop: options ? options.tabStop : undefined,
-      text: undefined,
-      preventClick: undefined,
-      bypassURLTrimming: undefined,
+      inlineFrameIndex: options?.inlineFrameIndex ?? 0,
+      tabStop: options?.tabStop,
     };
 
     return scriptLink || Linkifier.linkifyURL(sourceURL, linkifyURLOptions);
@@ -296,7 +285,6 @@ export class Linkifier implements SDK.TargetManager.Observer {
         rawLocation.debuggerModel.target(), rawLocation.scriptId, fallbackUrl, rawLocation.lineNumber, {
           columnNumber: rawLocation.columnNumber,
           className,
-          tabStop: undefined,
           inlineFrameIndex: rawLocation.inlineFrameIndex,
         });
   }
@@ -304,12 +292,12 @@ export class Linkifier implements SDK.TargetManager.Observer {
   maybeLinkifyConsoleCallFrame(
       target: SDK.Target.Target|null, callFrame: Protocol.Runtime.CallFrame, options?: LinkifyOptions): HTMLElement
       |null {
-    const linkifyOptions = {
+    const linkifyOptions: LinkifyOptions = {
       columnNumber: callFrame.columnNumber,
       showColumnNumber: Boolean(options?.showColumnNumber),
-      inlineFrameIndex: options ? options.inlineFrameIndex : 0,
-      tabStop: options ? options.tabStop : undefined,
-      className: options ? options.className : undefined,
+      inlineFrameIndex: options?.inlineFrameIndex ?? 0,
+      tabStop: options?.tabStop,
+      className: options?.className,
     };
     return this.maybeLinkifyScriptLocation(
         target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, linkifyOptions);
@@ -327,10 +315,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
       showColumnNumber: false,
       inlineFrameIndex: 0,
       maxLength: this.maxLength,
-      text: undefined,
       preventClick: true,
-      tabStop: undefined,
-      bypassURLTrimming: undefined,
     });
 
     // The contract is that disposed targets don't have a LiveLocationPool
@@ -373,12 +358,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 
   linkifyCSSLocation(rawLocation: SDK.CSSModel.CSSLocation, classes?: string): Element {
-    const createLinkOptions = {
-      maxLength: undefined,
-      title: undefined,
-      href: undefined,
-      preventClick: undefined,
-      bypassURLTrimming: undefined,
+    const createLinkOptions: _CreateLinkOptions = {
       tabStop: true,
     };
     // Not initialising the anchor element with 'zero width space' (\u200b) causes a crash
@@ -454,7 +434,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
     const text = uiLocation.linkText(true /* skipTrim */, options.showColumnNumber);
     Linkifier.setTrimmedText(anchor, text, this.maxLength);
 
-    let titleText = uiLocation.uiSourceCode.url();
+    let titleText: string = uiLocation.uiSourceCode.url();
     if (uiLocation.uiSourceCode.mimeType() === 'application/wasm') {
       // For WebAssembly locations, we follow the conventions described in
       // github.com/WebAssembly/design/blob/master/Web.md#developer-facing-display-conventions
@@ -497,16 +477,8 @@ export class Linkifier implements SDK.TargetManager.Observer {
 
   static linkifyURL(url: string, options?: LinkifyURLOptions): HTMLElement {
     options = options || {
-      text: undefined,
-      className: undefined,
-      lineNumber: undefined,
-      columnNumber: undefined,
       showColumnNumber: false,
       inlineFrameIndex: 0,
-      preventClick: undefined,
-      maxLength: undefined,
-      tabStop: undefined,
-      bypassURLTrimming: undefined,
     };
     const text = options.text;
     const className = options.className || '';
@@ -547,29 +519,18 @@ export class Linkifier implements SDK.TargetManager.Observer {
   static linkifyRevealable(
       revealable: Object, text: string|HTMLElement, fallbackHref?: string, title?: string,
       className?: string): HTMLElement {
-    const createLinkOptions = {
+    const createLinkOptions: _CreateLinkOptions = {
       maxLength: UI.UIUtils.MaxLengthForDisplayedURLs,
       href: fallbackHref,
       title,
-      preventClick: undefined,
-      tabStop: undefined,
-      bypassURLTrimming: undefined,
     };
     const {link, linkInfo} = Linkifier.createLink(text, className || '', createLinkOptions);
     linkInfo.revealable = revealable;
     return link;
   }
 
-  private static createLink(text: string|HTMLElement, className: string, options?: _CreateLinkOptions):
+  private static createLink(text: string|HTMLElement, className: string, options: _CreateLinkOptions = {}):
       {link: HTMLElement, linkInfo: _LinkInfo} {
-    options = options || {
-      maxLength: undefined,
-      title: undefined,
-      href: undefined,
-      preventClick: undefined,
-      tabStop: undefined,
-      bypassURLTrimming: undefined,
-    };
     const {maxLength, title, href, preventClick, tabStop, bypassURLTrimming} = options;
     const link = document.createElement('span');
     if (className) {

package/front_end/ui/legacy/tabbedPane.css

@@ -194,7 +194,6 @@
 .tabbed-pane-header-tabs-drop-down-container {
   float: left;
   opacity: 80%;
-  cursor: pointer;
   display: flex;
   align-items: center;
   height: 100%;
@@ -347,7 +346,6 @@
 
   width: 14px;
   height: 14px;
-  cursor: default;
   display: flex;
   align-items: center;
   justify-content: center;

package/front_end/ui/legacy/toolbar.css

@@ -7,12 +7,14 @@
 :host {
   flex: none;
   padding: 0 2px;
+
+  --toolbar-height: 26px;
 }
 
 .toolbar-shadow {
   position: relative;
   white-space: nowrap;
-  height: 26px;
+  height: var(--toolbar-height);
   overflow: hidden;
   z-index: 12;
   display: flex;
@@ -43,7 +45,7 @@
   align-items: center;
   justify-content: center;
   padding: 0;
-  height: 26px;
+  height: var(--toolbar-height);
   border: none;
   white-space: pre;
 }
@@ -55,7 +57,7 @@
 
 .toolbar-shadow.vertical .toolbar-item {
   height: auto;
-  min-height: 26px;
+  min-height: var(--toolbar-height);
   white-space: normal;
 }
 
@@ -175,6 +177,29 @@ it. */
   margin-inline-end: 28px;
 }
 
+.toolbar-button.copied-to-clipboard::after {
+  content: attr(data-content);
+  position: fixed;
+  top: var(--toolbar-height);
+  padding: 3px 5px;
+  color: var(--color-text-secondary);
+  background: var(--color-background-elevation-1);
+  animation: 2s fade-out;
+  font-weight: normal;
+  border: 1px solid var(--color-details-hairline);
+  border-radius: 3px;
+}
+
+@keyframes fade-out {
+  from {
+    opacity: 100%;
+  }
+
+  to {
+    opacity: 0%;
+  }
+}
+
 .toolbar-button.toolbar-state-on .toolbar-glyph {
   background-color: var(--color-primary);
 }

package/package.json

@@ -54,5 +54,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.970539"
+  "version": "1.0.972865"
 }

package/scripts/hosted_mode/server.js

@@ -177,6 +177,19 @@ async function requestHandler(request, response) {
       // This is fine to do given that test invocations run against fresh Chrome profiles.
       headers.set('Cache-Control', 'max-age=3600');
     }
+    if (!headers.get('Access-Control-Allow-Origin')) {
+      // The DevTools frontend in hosted-mode uses regular fetch to get source maps etc.
+      // Disable CORS only for the DevTools frontend, not for resource/target pages.
+      // Since Chrome will cache resources, we have to indicate that CORS can still vary
+      // based on the origin that made the request. E.g. the target page loads a script first
+      // but then DevTools also wants to load it. In the former, we disallow cross-origin requests by default,
+      // while for the latter we allow it.
+      const requestedByDevTools = request.headers.origin?.includes('devtools-frontend.test');
+      if (requestedByDevTools) {
+        headers.set('Access-Control-Allow-Origin', request.headers.origin);
+      }
+      headers.set('Vary', 'Origin');
+    }
     headers.forEach((value, header) => {
       response.setHeader(header, value);
     });

package/scripts/npm_test.js

@@ -91,7 +91,7 @@ function runTests(buildDirectoryPath, useDebugDevtools) {
 
   if (IS_DEBUG_ENABLED) {
     testArgs.push('--additional-driver-flag=--remote-debugging-port=9222');
-    testArgs.push('--time-out-ms=6000000');
+    testArgs.push('--timeout-ms=6000000');
     console.log('\n=============================================');
     const unitTest = testArgs.find(arg => arg.includes('http/tests/devtools/unit/'));
     if (unitTest) {

package/front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownHttpNotFound.md

@@ -1 +0,0 @@
-# The provider's .well-known configuration cannot be found.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownInvalidResponse.md

@@ -1 +0,0 @@
-# Provider's .well-known configuration is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownNoResponse.md

@@ -1 +0,0 @@
-# The response body is empty when fetching the provider's .well-known configuration.