chrome-devtools-frontend 1.0.969345 → 1.0.970539

package/front_end/services/puppeteer/PuppeteerConnection.ts

@@ -0,0 +1,107 @@
+// Copyright (c) 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as puppeteer from '../../third_party/puppeteer/puppeteer.js';
+import type * as Protocol from '../../generated/protocol.js';
+import type * as SDK from '../../core/sdk/sdk.js';
+
+export class Transport implements puppeteer.ConnectionTransport {
+  #connection: SDK.Connections.ParallelConnectionInterface;
+  #knownIds = new Set<number>();
+
+  constructor(connection: SDK.Connections.ParallelConnectionInterface) {
+    this.#connection = connection;
+  }
+
+  send(message: string): void {
+    const data = JSON.parse(message);
+    this.#knownIds.add(data.id);
+    this.#connection.sendRawMessage(JSON.stringify(data));
+  }
+
+  close(): void {
+    void this.#connection.disconnect();
+  }
+
+  set onmessage(cb: (message: string) => void) {
+    this.#connection.setOnMessage((message: Object) => {
+      if (!cb) {
+        return;
+      }
+      const data = (message) as {id: number, method: string, params: unknown, sessionId?: string};
+      if (data.id && !this.#knownIds.has(data.id)) {
+        return;
+      }
+      this.#knownIds.delete(data.id);
+      if (!data.sessionId) {
+        return;
+      }
+      return cb(JSON.stringify({
+        ...data,
+        // Puppeteer is expecting to use the default session, but we give it a non-default session in #connection.
+        // Replace that sessionId with undefined so Puppeteer treats it as default.
+        sessionId: data.sessionId === this.#connection.getSessionId() ? undefined : data.sessionId,
+      }));
+    });
+  }
+
+  set onclose(cb: () => void) {
+    const prev = this.#connection.getOnDisconnect();
+    this.#connection.setOnDisconnect(reason => {
+      if (prev) {
+        prev(reason);
+      }
+      if (cb) {
+        cb();
+      }
+    });
+  }
+}
+
+export class PuppeteerConnection extends puppeteer.Connection {
+  // Overriding Puppeteer's API here.
+  // eslint-disable-next-line rulesdir/no_underscored_properties
+  async _onMessage(message: string): Promise<void> {
+    const msgObj = JSON.parse(message) as {id: number, method: string, params: unknown, sessionId?: string};
+    if (msgObj.sessionId && !this._sessions.has(msgObj.sessionId)) {
+      return;
+    }
+    void super._onMessage(message);
+  }
+}
+
+export async function getPuppeteerConnection(
+    rawConnection: SDK.Connections.ParallelConnectionInterface,
+    mainFrameId: string,
+    mainTargetId: string,
+    ): Promise<{page: puppeteer.Page | null, browser: puppeteer.Browser}> {
+  const transport = new Transport(rawConnection);
+
+  // url is an empty string in this case parallel to:
+  // https://github.com/puppeteer/puppeteer/blob/f63a123ecef86693e6457b07437a96f108f3e3c5/src/common/BrowserConnector.ts#L72
+  const connection = new PuppeteerConnection('', transport);
+
+  const targetFilterCallback = (targetInfo: Protocol.Target.TargetInfo): boolean => {
+    if (targetInfo.type !== 'page' && targetInfo.type !== 'iframe') {
+      return false;
+    }
+    // TODO only connect to iframes that are related to the main target. This requires refactoring in Puppeteer: https://github.com/puppeteer/puppeteer/issues/3667.
+    return targetInfo.targetId === mainTargetId || targetInfo.openerId === mainTargetId || targetInfo.type === 'iframe';
+  };
+
+  const browser = await puppeteer.Browser.create(
+      connection,
+      [] /* contextIds */,
+      false /* ignoreHTTPSErrors */,
+      undefined /* defaultViewport */,
+      undefined /* process */,
+      undefined /* closeCallback */,
+      targetFilterCallback,
+  );
+
+  const pages = await browser.pages();
+  const page = pages.find(p => p.mainFrame()._id === mainFrameId) || null;
+
+  return {page, browser};
+}

package/front_end/services/puppeteer/puppeteer.ts

@@ -0,0 +1,9 @@
+// Copyright (c) 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as PuppeteerConnection from './PuppeteerConnection.js';
+
+export {
+  PuppeteerConnection,
+};

package/front_end/third_party/codemirror/package/addon/fold/foldgutter.css

@@ -3,15 +3,11 @@
   text-shadow: #b9f 1px 1px 2px, #b9f -1px -1px 2px, #b9f 1px -1px 2px, #b9f -1px 1px 2px;
   font-family: arial;
   line-height: .3;
-  cursor: pointer;
 }
 .CodeMirror-foldgutter {
   width: .7em;
 }
-.CodeMirror-foldgutter-open,
-.CodeMirror-foldgutter-folded {
-  cursor: pointer;
-}
+
 .CodeMirror-foldgutter-open:after {
   content: "\25BE";
 }

package/front_end/ui/components/adorners/adorner.css

@@ -12,10 +12,6 @@
   display: none;
 }
 
-:host(.clickable) {
-  cursor: pointer;
-}
-
 slot {
   display: inline-flex;
   box-sizing: border-box;

package/front_end/ui/components/buttons/button.css

@@ -49,10 +49,6 @@ button:focus-visible {
   box-shadow: 0 0 0 2px var(--color-button-outline-focus);
 }
 
-button:hover {
-  cursor: pointer;
-}
-
 button.toolbar {
   background: transparent;
   border-radius: 2px;

package/front_end/ui/components/data_grid/dataGrid.css

@@ -115,10 +115,6 @@ th.firstVisibleColumn {
   padding: 1px;
 }
 
-[aria-sort]:hover {
-  cursor: pointer;
-}
-
 [aria-sort="descending"]::after {
   content: "";
   width: 0;

package/front_end/ui/components/icon_button/iconButton.css

@@ -21,7 +21,6 @@
 }
 
 .icon-button.with-click-handler {
-  cursor: pointer;
   border: 1px solid var(--color-details-hairline);
   border-radius: 2px;
 }

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -37,8 +37,8 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['https://developer.chrome.com/docs/extensions/mv3/', 'https://developer.chrome.com/docs/extensions/mv3/'],
   [
-    'https://developer.chrome.com/blog/immutable-document-domain',
-    'https://developer.chrome.com/blog/immutable-document-domain',
+    'https://developer.chrome.com/blog/immutable-document-domain/',
+    'https://developer.chrome.com/blog/immutable-document-domain/',
   ],
 ]);
 

package/front_end/ui/legacy/TabbedPane.ts

@@ -1144,7 +1144,7 @@ export class TabbedPaneTab {
       if (this.tabbedPane.allowTabReorder) {
         installDragHandle(
             tabElement, this.startTabDragging.bind(this), this.tabDragging.bind(this), this.endTabDragging.bind(this),
-            '-webkit-grabbing', 'pointer', 200);
+            null, null, 200);
       }
     }
 

package/front_end/ui/legacy/tabbedPane.css

@@ -269,10 +269,6 @@
   align-items: center;
 }
 
-.tabbed-pane-shadow.vertical-tab-layout .tabbed-pane-header-tab:not(.selected) {
-  cursor: pointer !important; /* stylelint-disable-line declaration-no-important */
-}
-
 /* stylelint-disable no-descending-specificity */
 .tabbed-pane-shadow.vertical-tab-layout .tabbed-pane-header-tab.selected {
   --override-vertical-tab-selected-border-color: #666;

package/front_end/ui/legacy/textButton.css

@@ -27,7 +27,6 @@
 .text-button:not(:disabled):active {
   background-color: var(--color-background-elevation-1);
   box-shadow: 0 1px 2px var(--divider-line);
-  cursor: pointer;
 }
 
 .text-button:not(:disabled):active {

package/front_end/ui/legacy/toolbar.css

@@ -80,7 +80,6 @@ select.toolbar-item:disabled + .toolbar-dropdown-arrow {
   min-width: 28px;
   background: transparent;
   border-radius: 0;
-  cursor: pointer;
 }
 
 .toolbar-text {

package/package.json

@@ -23,7 +23,7 @@
     "auto-debug-interactionstest": "autoninja -C out/Default && npm run debug-interactionstest --",
     "auto-debug-unittest": "DEBUG_TEST=1 npm run auto-unittest --",
     "auto-e2etest": "autoninja -C out/Default && npm run e2etest --",
-    "auto-interactionstest": "autoninja -C out/Default && npm run interactionstest",
+    "auto-interactionstest": "autoninja -C out/Default && npm run interactionstest --",
     "auto-unittest": "scripts/test/run_auto_unittests.py --no-text-coverage",
     "build": "autoninja -C out/Default",
     "build-release": "autoninja -C out/Release",
@@ -54,5 +54,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.969345"
+  "version": "1.0.970539"
 }

package/scripts/hosted_mode/server.js

@@ -172,6 +172,11 @@ async function requestHandler(request, response) {
         headers.set('Content-Type', inferredContentType);
       }
     }
+    if (!headers.get('Cache-Control')) {
+      // Lets reduce Disk I/O by allowing clients to cache resources.
+      // This is fine to do given that test invocations run against fresh Chrome profiles.
+      headers.set('Cache-Control', 'max-age=3600');
+    }
     headers.forEach((value, header) => {
       response.setHeader(header, value);
     });