chrome-devtools-frontend 1.0.968254 → 1.0.970302

package/front_end/third_party/codemirror.next/package.json

@@ -5,9 +5,9 @@
   "dependencies": {
     "@codemirror/autocomplete": "0.19.12",
     "@codemirror/closebrackets": "0.19.0",
-    "@codemirror/commands": "0.19.7",
+    "@codemirror/commands": "0.19.8",
     "@codemirror/comment": "0.19.0",
-    "@codemirror/fold": "0.19.2",
+    "@codemirror/fold": "0.19.3",
     "@codemirror/gutter": "0.19.9",
     "@codemirror/highlight": "0.19.7",
     "@codemirror/history": "0.19.2",
@@ -15,11 +15,11 @@
     "@codemirror/lang-css": "0.19.3",
     "@codemirror/lang-html": "0.19.4",
     "@codemirror/lang-java": "0.19.1",
-    "@codemirror/lang-javascript": "0.19.6",
+    "@codemirror/lang-javascript": "0.19.7",
     "@codemirror/lang-json": "0.19.1",
-    "@codemirror/lang-markdown": "0.19.4",
+    "@codemirror/lang-markdown": "0.19.6",
     "@codemirror/lang-php": "0.19.1",
-    "@codemirror/lang-python": "0.19.2",
+    "@codemirror/lang-python": "0.19.4",
     "@codemirror/lang-wast": "0.19.0",
     "@codemirror/lang-xml": "0.19.2",
     "@codemirror/language": "0.19.7",
@@ -27,14 +27,14 @@
     "@codemirror/matchbrackets": "0.19.3",
     "@codemirror/panel": "0.19.1",
     "@codemirror/rangeset": "0.19.6",
-    "@codemirror/search": "0.19.5",
+    "@codemirror/search": "0.19.6",
     "@codemirror/state": "0.19.6",
-    "@codemirror/stream-parser": "0.19.3",
-    "@codemirror/text": "0.19.5",
-    "@codemirror/tooltip": "0.19.12",
-    "@codemirror/view": "0.19.39",
+    "@codemirror/stream-parser": "0.19.5",
+    "@codemirror/text": "0.19.6",
+    "@codemirror/tooltip": "0.19.13",
+    "@codemirror/view": "0.19.42",
     "@lezer/common": "0.15.11",
-    "@lezer/lr": "0.15.6",
+    "@lezer/lr": "0.15.8",
     "@rollup/plugin-node-resolve": "^13.0.4",
     "rollup-plugin-dts": "^4.0.0",
     "rollup-plugin-terser": "^7.0.2",

package/front_end/ui/components/adorners/adorner.css

@@ -12,10 +12,6 @@
   display: none;
 }
 
-:host(.clickable) {
-  cursor: pointer;
-}
-
 slot {
   display: inline-flex;
   box-sizing: border-box;

package/front_end/ui/components/buttons/button.css

@@ -49,10 +49,6 @@ button:focus-visible {
   box-shadow: 0 0 0 2px var(--color-button-outline-focus);
 }
 
-button:hover {
-  cursor: pointer;
-}
-
 button.toolbar {
   background: transparent;
   border-radius: 2px;

package/front_end/ui/components/data_grid/dataGrid.css

@@ -115,10 +115,6 @@ th.firstVisibleColumn {
   padding: 1px;
 }
 
-[aria-sort]:hover {
-  cursor: pointer;
-}
-
 [aria-sort="descending"]::after {
   content: "";
   width: 0;

package/front_end/ui/components/icon_button/iconButton.css

@@ -21,7 +21,6 @@
 }
 
 .icon-button.with-click-handler {
-  cursor: pointer;
   border: 1px solid var(--color-details-hairline);
   border-radius: 2px;
 }

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -37,8 +37,8 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['https://developer.chrome.com/docs/extensions/mv3/', 'https://developer.chrome.com/docs/extensions/mv3/'],
   [
-    'https://developer.chrome.com/blog/immutable-document-domain',
-    'https://developer.chrome.com/blog/immutable-document-domain',
+    'https://developer.chrome.com/blog/immutable-document-domain/',
+    'https://developer.chrome.com/blog/immutable-document-domain/',
   ],
 ]);
 

package/front_end/ui/legacy/TabbedPane.ts

@@ -1144,7 +1144,7 @@ export class TabbedPaneTab {
       if (this.tabbedPane.allowTabReorder) {
         installDragHandle(
             tabElement, this.startTabDragging.bind(this), this.tabDragging.bind(this), this.endTabDragging.bind(this),
-            '-webkit-grabbing', 'pointer', 200);
+            null, null, 200);
       }
     }
 

package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts

@@ -388,8 +388,8 @@ export class TimelineOverviewBase extends UI.Widget.VBox implements TimelineOver
   reset(): void {
   }
 
-  overviewInfoPromise(_x: number): Promise<Element|null> {
-    return Promise.resolve((null as Element | null));
+  async overviewInfoPromise(_x: number): Promise<Element|null> {
+    return null;
   }
 
   setCalculator(calculator: TimelineOverviewCalculator): void {

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -578,8 +578,10 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     if (this.lineToScrollTo !== null) {
       if (this.loaded && this.isShowing()) {
         const {textEditor} = this;
-        const position = textEditor.toOffset({lineNumber: this.lineToScrollTo, columnNumber: 0});
-        textEditor.dispatch({effects: CodeMirror.EditorView.scrollTo.of(CodeMirror.EditorSelection.cursor(position))});
+        // DevTools history items are 0-based, but CodeMirror is 1-based, so we have to increment the
+        // line we want to scroll to by 1.
+        const position = textEditor.toOffset({lineNumber: this.lineToScrollTo + 1, columnNumber: 0});
+        textEditor.dispatch({effects: CodeMirror.EditorView.scrollIntoView(position, {y: 'start'})});
         this.lineToScrollTo = null;
       }
     }

package/front_end/ui/legacy/tabbedPane.css

@@ -269,10 +269,6 @@
   align-items: center;
 }
 
-.tabbed-pane-shadow.vertical-tab-layout .tabbed-pane-header-tab:not(.selected) {
-  cursor: pointer !important; /* stylelint-disable-line declaration-no-important */
-}
-
 /* stylelint-disable no-descending-specificity */
 .tabbed-pane-shadow.vertical-tab-layout .tabbed-pane-header-tab.selected {
   --override-vertical-tab-selected-border-color: #666;

package/front_end/ui/legacy/textButton.css

@@ -27,7 +27,6 @@
 .text-button:not(:disabled):active {
   background-color: var(--color-background-elevation-1);
   box-shadow: 0 1px 2px var(--divider-line);
-  cursor: pointer;
 }
 
 .text-button:not(:disabled):active {

package/front_end/ui/legacy/toolbar.css

@@ -80,7 +80,6 @@ select.toolbar-item:disabled + .toolbar-dropdown-arrow {
   min-width: 28px;
   background: transparent;
   border-radius: 0;
-  cursor: pointer;
 }
 
 .toolbar-text {

package/package.json

@@ -23,7 +23,7 @@
     "auto-debug-interactionstest": "autoninja -C out/Default && npm run debug-interactionstest --",
     "auto-debug-unittest": "DEBUG_TEST=1 npm run auto-unittest --",
     "auto-e2etest": "autoninja -C out/Default && npm run e2etest --",
-    "auto-interactionstest": "autoninja -C out/Default && npm run interactionstest",
+    "auto-interactionstest": "autoninja -C out/Default && npm run interactionstest --",
     "auto-unittest": "scripts/test/run_auto_unittests.py --no-text-coverage",
     "build": "autoninja -C out/Default",
     "build-release": "autoninja -C out/Release",
@@ -54,5 +54,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.968254"
+  "version": "1.0.970302"
 }

package/scripts/build/devtools_plugin.js

@@ -111,4 +111,35 @@ function devtoolsPlugin(source, importer) {
   };
 }
 
-module.exports = {devtoolsPlugin};
+function esbuildPlugin(outdir) {
+  return args => {
+    // args.importer is absolute path in esbuild.
+    const res = devtoolsPlugin(args.path, args.importer);
+    if (!res) {
+      return null;
+    }
+
+    if (res.external) {
+      // res.id can be both of absolutized local JavaScript path or node's
+      // builtin module (e.g. 'fs', 'path'), and only relativize the path in
+      // former case.
+      if (path.isAbsolute(res.id)) {
+        res.id = './' + path.relative(outdir, res.id);
+      }
+
+      return {
+        external: res.external,
+        path: res.id,
+      };
+    }
+
+    return {
+      path: res.id,
+    };
+  };
+}
+
+module.exports = {
+  devtoolsPlugin,
+  esbuildPlugin
+};

package/scripts/build/esbuild.js

@@ -21,30 +21,7 @@ const plugin = {
   name: 'devtools-plugin',
   setup(build) {
     // https://esbuild.github.io/plugins/#on-resolve
-    build.onResolve({filter: /.*/}, args => {
-      const res = devtools_plugin.devtoolsPlugin(args.path, args.importer);
-      if (!res) {
-        return null;
-      }
-
-      if (res.external) {
-        // res.id can be both of absolutized local JavaScript path or node's
-        // builtin module (e.g. 'fs', 'path'), and only relativize the path in
-        // former case.
-        if (path.isAbsolute(res.id)) {
-          res.id = './' + path.relative(outdir, res.id);
-        }
-
-        return {
-          external: res.external,
-          path: res.id,
-        };
-      }
-
-      return {
-        path: res.id,
-      };
-    });
+    build.onResolve({filter: /.*/}, devtools_plugin.esbuildPlugin(outdir));
   },
 };
 

package/scripts/build/tests/plugins_test.js

@@ -5,7 +5,7 @@
 const {assert} = require('chai');
 const path = require('path');
 
-const {devtoolsPlugin} = require('../devtools_plugin.js');
+const {devtoolsPlugin, esbuildPlugin} = require('../devtools_plugin.js');
 
 describe('devtools_plugin can compute paths with', () => {
   it('same directory import', () => {
@@ -27,4 +27,63 @@ describe('devtools_plugin can compute paths with', () => {
   it('importing generated files', () => {
     assert.strictEqual(devtoolsPlugin('../../generated/Protocol.js', 'front_end/core/sdk/FirstFile.js'), null);
   });
+
+  it('importing lighthouse files', () => {
+    assert.deepEqual(
+        devtoolsPlugin('./front_end/third_party/lighthouse/lighthouse-dt-bundle.js', 'front_end/core/sdk/FirstFile.js'),
+        {
+          id: path.join(
+              'front_end', 'core', 'sdk', 'front_end', 'third_party', 'lighthouse', 'lighthouse-dt-bundle.js'),
+          external: true,
+        });
+  });
+});
+
+describe('esbuild_plugin can compute paths with', () => {
+  const srcdir = __dirname;
+  const outdir = path.join(srcdir, 'out');
+  const plugin = esbuildPlugin(outdir);
+  it('same directory import', () => {
+    assert.deepEqual(
+        plugin({path: './AnotherFile.js', importer: path.join(srcdir, 'front_end/core/sdk/FirstFile.js')}),
+        {path: path.join(srcdir, 'front_end', 'core', 'sdk', 'AnotherFile.js')});
+  });
+
+  it('different directory import', () => {
+    assert.deepEqual(
+        plugin({path: '../common/common.js', importer: path.join(srcdir, 'front_end/core/sdk/FirstFile.js')}),
+        {path: './' + path.join('..', 'front_end', 'core', 'common', 'common.js'), external: true});
+  });
+
+  it('node built-in modules', () => {
+    assert.deepEqual(
+        plugin({path: 'fs', importer: path.join(srcdir, 'scripts/some-script.js')}), {path: 'fs', external: true});
+  });
+
+  it('codemirror modules', () => {
+    assert.deepEqual(
+        plugin({path: '../../lib/codemirror', importer: path.join(srcdir, 'scripts/some-script.js')}),
+        {path: '../../lib/codemirror', external: true});
+  });
+
+  it('importing generated files', () => {
+    assert.strictEqual(
+        plugin({path: '../../generated/Protocol.js', importer: path.join(srcdir, 'front_end/core/sdk/FirstFile.js')}),
+        null);
+  });
+
+  it('importing lighthouse files', () => {
+    assert.deepEqual(
+        plugin({
+          path: './front_end/third_party/lighthouse/lighthouse-dt-bundle.js',
+          importer: path.join(srcdir, 'front_end/core/sdk/FirstFile.js')
+        }),
+        {
+          path: './' +
+              path.join(
+                  '..', 'front_end', 'core', 'sdk', 'front_end', 'third_party', 'lighthouse',
+                  'lighthouse-dt-bundle.js'),
+          external: true,
+        });
+  });
 });

package/scripts/hosted_mode/server.js

@@ -172,6 +172,11 @@ async function requestHandler(request, response) {
         headers.set('Content-Type', inferredContentType);
       }
     }
+    if (!headers.get('Cache-Control')) {
+      // Lets reduce Disk I/O by allowing clients to cache resources.
+      // This is fine to do given that test invocations run against fresh Chrome profiles.
+      headers.set('Cache-Control', 'max-age=3600');
+    }
     headers.forEach((value, header) => {
       response.setHeader(header, value);
     });