chrome-devtools-frontend 1.0.967610 → 1.0.969345

package/config/gni/devtools_grd_files.gni

@@ -304,6 +304,25 @@ grd_files_release_sources = [
   "front_end/models/issues_manager/descriptions/cspURLViolation.md",
   "front_end/models/issues_manager/descriptions/deprecation.md",
   "front_end/models/issues_manager/descriptions/deprecationNavigatorUserAgent.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestAccountsHttpNotFound.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestAccountsInvalidResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestAccountsNoResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestApprovalDeclined.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestCanceled.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestClientIdMetadataHttpNotFound.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestClientIdMetadataInvalidResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestClientIdMetadataNoResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestErrorFetchingSignin.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestErrorIdToken.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenHttpNotFound.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenInvalidRequest.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenInvalidResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenNoResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestInvalidSigninResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestTooManyRequests.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownHttpNotFound.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownInvalidResponse.md",
+  "front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownNoResponse.md",
   "front_end/models/issues_manager/descriptions/genericCrossOriginPortalPostMessageError.md",
   "front_end/models/issues_manager/descriptions/heavyAd.md",
   "front_end/models/issues_manager/descriptions/mixedContent.md",
@@ -703,6 +722,7 @@ grd_files_debug_sources = [
   "front_end/models/issues_manager/CorsIssue.js",
   "front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.js",
   "front_end/models/issues_manager/DeprecationIssue.js",
+  "front_end/models/issues_manager/FederatedAuthRequestIssue.js",
   "front_end/models/issues_manager/GenericIssue.js",
   "front_end/models/issues_manager/HeavyAdIssue.js",
   "front_end/models/issues_manager/Issue.js",

package/front_end/core/host/UserMetrics.ts

@@ -585,7 +585,8 @@ export enum DevtoolsExperiments {
   'preciseChanges' = 53,
   'bfcacheDisplayTree' = 54,
   'stylesPaneCSSChanges' = 55,
-  'MaxValue' = 56,
+  'headerOverrides' = 56,
+  'MaxValue' = 57,
 }
 /* eslint-enable @typescript-eslint/naming-convention */
 

package/front_end/core/i18n/locales/en-US.json

@@ -1337,6 +1337,9 @@
   "models/issues_manager/CrossOriginEmbedderPolicyIssue.ts | samesiteAndSameorigin": {
     "message": "Same-Site and Same-Origin"
   },
+  "models/issues_manager/FederatedAuthRequestIssue.ts | fedCm": {
+    "message": "Federated Credential Management API"
+  },
   "models/issues_manager/GenericIssue.ts | crossOriginPortalPostMessage": {
     "message": "Portals - Same-origin communication channels"
   },
@@ -3200,6 +3203,9 @@
   "panels/application/InterestGroupStorageView.ts | clickToDisplayBody": {
     "message": "Click on any interest group event to display the group's current state"
   },
+  "panels/application/InterestGroupStorageView.ts | noDataAvailable": {
+    "message": "No details available for the selected interest group. The browser may have left the group."
+  },
   "panels/application/InterestGroupTreeElement.ts | interestGroups": {
     "message": "Interest Groups"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -1337,6 +1337,9 @@
   "models/issues_manager/CrossOriginEmbedderPolicyIssue.ts | samesiteAndSameorigin": {
     "message": "Ŝám̂é-Ŝít̂é âńd̂ Śâḿê-Ór̂íĝín̂"
   },
+  "models/issues_manager/FederatedAuthRequestIssue.ts | fedCm": {
+    "message": "F̂éd̂ér̂át̂éd̂ Ćr̂éd̂én̂t́îál̂ Ḿâńâǵêḿêńt̂ ÁP̂Í"
+  },
   "models/issues_manager/GenericIssue.ts | crossOriginPortalPostMessage": {
     "message": "P̂ór̂t́âĺŝ - Śâḿê-ór̂íĝín̂ ćôḿm̂ún̂íĉát̂íôń ĉh́âńn̂él̂ś"
   },
@@ -3200,6 +3203,9 @@
   "panels/application/InterestGroupStorageView.ts | clickToDisplayBody": {
     "message": "Ĉĺîćk̂ ón̂ án̂ý îńt̂ér̂éŝt́ ĝŕôúp̂ év̂én̂t́ t̂ó d̂íŝṕl̂áŷ t́ĥé ĝŕôúp̂'ś ĉúr̂ŕêńt̂ śt̂át̂é"
   },
+  "panels/application/InterestGroupStorageView.ts | noDataAvailable": {
+    "message": "N̂ó d̂ét̂áîĺŝ áv̂áîĺâb́l̂é f̂ór̂ t́ĥé ŝél̂éĉt́êd́ îńt̂ér̂éŝt́ ĝŕôúp̂. T́ĥé b̂ŕôẃŝér̂ ḿâý ĥáv̂é l̂éf̂t́ t̂h́ê ǵr̂óûṕ."
+  },
   "panels/application/InterestGroupTreeElement.ts | interestGroups": {
     "message": "Îńt̂ér̂éŝt́ Ĝŕôúp̂ś"
   },

package/front_end/core/root/Runtime.ts

@@ -274,6 +274,7 @@ export enum ExperimentName {
   FULL_ACCESSIBILITY_TREE = 'fullAccessibilityTree',
   PRECISE_CHANGES = 'preciseChanges',
   STYLES_PANE_CSS_CHANGES = 'stylesPaneCSSChanges',
+  HEADER_OVERRIDES = 'headerOverrides',
 }
 
 // TODO(crbug.com/1167717): Make this a const enum again

package/front_end/core/sdk/CSSMatchedStyles.ts

@@ -273,7 +273,7 @@ export class CSSMatchedStyles {
   async recomputeMatchingSelectors(rule: CSSStyleRule): Promise<void> {
     const node = this.nodeForStyle(rule.style);
     if (!node) {
-      return Promise.resolve();
+      return;
     }
     const promises = [];
     for (const selector of rule.selectors) {

package/front_end/devtools_compatibility.js

@@ -1481,42 +1481,6 @@
       installObjectObserve();
     }
 
-    if (majorVersion <= 45) {
-      /**
-       * @param {string} property
-       * @return {!CSSValue|null}
-       * @this {CSSStyleDeclaration}
-       */
-      function getValue(property) {
-        // Note that |property| comes from another context, so we can't use === here.
-        // eslint-disable-next-line eqeqeq
-        if (property == 'padding-left') {
-          return /** @type {!CSSValue} */ ({
-            /**
-             * @return {number}
-             * @this {!{__paddingLeft: number}}
-             */
-            getFloatValue: function() {
-              return this.__paddingLeft;
-            },
-            __paddingLeft: parseFloat(this.paddingLeft)
-          });
-        }
-        throw new Error('getPropertyCSSValue is undefined');
-      }
-
-      window.CSSStyleDeclaration.prototype.getPropertyCSSValue = getValue;
-
-      function CSSPrimitiveValue() {
-      }
-      CSSPrimitiveValue.CSS_PX = 5;
-      window.CSSPrimitiveValue = CSSPrimitiveValue;
-    }
-
-    if (majorVersion <= 45) {
-      styleRules.push('* { min-width: 0; min-height: 0; }');
-    }
-
     if (majorVersion <= 71) {
       styleRules.push(
           '.coverage-toolbar-container, .animation-timeline-toolbar-container, .computed-properties { flex-basis: auto; }');

package/front_end/entrypoints/main/MainImpl.ts

@@ -372,6 +372,10 @@ export class MainImpl {
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.STYLES_PANE_CSS_CHANGES, 'Sync CSS changes in the Styles pane');
 
+    // Local overrides for response headers
+    Root.Runtime.experiments.register(
+        Root.Runtime.ExperimentName.HEADER_OVERRIDES, 'Local overrides for response headers');
+
     Root.Runtime.experiments.enableExperimentsByDefault([
       'sourceOrderViewer',
       'hideIssuesFeature',

package/front_end/models/issues_manager/FederatedAuthRequestIssue.ts

@@ -0,0 +1,265 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as i18n from '../../core/i18n/i18n.js';
+import type * as SDK from '../../core/sdk/sdk.js';
+import * as Protocol from '../../generated/protocol.js';
+
+import {Issue, IssueCategory, IssueKind} from './Issue.js';
+import type {MarkdownIssueDescription, LazyMarkdownIssueDescription} from './MarkdownIssueDescription.js';
+import {resolveLazyDescription} from './MarkdownIssueDescription.js';
+
+const UIStrings = {
+  /**
+  *@description Title for Client Hint specification url link
+  */
+  fedCm: 'Federated Credential Management API',
+};
+const str_ = i18n.i18n.registerUIStrings('models/issues_manager/FederatedAuthRequestIssue.ts', UIStrings);
+const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
+
+export class FederatedAuthRequestIssue extends Issue {
+  readonly #issueDetails: Protocol.Audits.FederatedAuthRequestIssueDetails;
+
+  constructor(
+      issueDetails: Protocol.Audits.FederatedAuthRequestIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
+    super(
+        {
+          code: Protocol.Audits.InspectorIssueCode.FederatedAuthRequestIssue,
+          umaCode: [
+            Protocol.Audits.InspectorIssueCode.FederatedAuthRequestIssue,
+            issueDetails.federatedAuthRequestIssueReason,
+          ].join('::'),
+        },
+        issuesModel);
+    this.#issueDetails = issueDetails;
+  }
+
+  getCategory(): IssueCategory {
+    return IssueCategory.Other;
+  }
+
+  details(): Protocol.Audits.FederatedAuthRequestIssueDetails {
+    return this.#issueDetails;
+  }
+
+  getDescription(): MarkdownIssueDescription|null {
+    const description = issueDescriptions.get(this.#issueDetails.federatedAuthRequestIssueReason);
+    if (!description) {
+      return null;
+    }
+    return resolveLazyDescription(description);
+  }
+
+  primaryKey(): string {
+    return JSON.stringify(this.#issueDetails);
+  }
+
+  getKind(): IssueKind {
+    return IssueKind.PageError;
+  }
+
+  static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):
+      FederatedAuthRequestIssue[] {
+    const details = inspectorIssue.details.federatedAuthRequestIssueDetails;
+    if (!details) {
+      console.warn('Federated auth request issue without details received.');
+      return [];
+    }
+    return [new FederatedAuthRequestIssue(details, issuesModel)];
+  }
+}
+
+const issueDescriptions: Map<Protocol.Audits.FederatedAuthRequestIssueReason, LazyMarkdownIssueDescription> = new Map([
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.ApprovalDeclined,
+    {
+      file: 'federatedAuthRequestApprovalDeclined.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.TooManyRequests,
+    {
+      file: 'federatedAuthRequestTooManyRequests.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.WellKnownHttpNotFound,
+    {
+      file: 'federatedAuthRequestWellKnownHttpNotFound.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.WellKnownNoResponse,
+    {
+      file: 'federatedAuthRequestWellKnownNoResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.WellKnownInvalidResponse,
+    {
+      file: 'federatedAuthRequestWellKnownInvalidResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.ClientIdMetadataHttpNotFound,
+    {
+      file: 'federatedAuthRequestClientIdMetadataHttpNotFound.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.ClientIdMetadataNoResponse,
+    {
+      file: 'federatedAuthRequestClientIdMetadataNoResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.ClientIdMetadataInvalidResponse,
+    {
+      file: 'federatedAuthRequestClientIdMetadataInvalidResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.ErrorFetchingSignin,
+    {
+      file: 'federatedAuthRequestErrorFetchingSignin.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.InvalidSigninResponse,
+    {
+      file: 'federatedAuthRequestInvalidSigninResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.AccountsHttpNotFound,
+    {
+      file: 'federatedAuthRequestAccountsHttpNotFound.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.AccountsNoResponse,
+    {
+      file: 'federatedAuthRequestAccountsNoResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.AccountsInvalidResponse,
+    {
+      file: 'federatedAuthRequestAccountsInvalidResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.IdTokenHttpNotFound,
+    {
+      file: 'federatedAuthRequestIdTokenHttpNotFound.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.IdTokenNoResponse,
+    {
+      file: 'federatedAuthRequestIdTokenNoResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.IdTokenInvalidResponse,
+    {
+      file: 'federatedAuthRequestIdTokenInvalidResponse.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.IdTokenInvalidRequest,
+    {
+      file: 'federatedAuthRequestIdTokenInvalidRequest.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.ErrorIdToken,
+    {
+      file: 'federatedAuthRequestErrorIdToken.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+  [
+    Protocol.Audits.FederatedAuthRequestIssueReason.Canceled,
+    {
+      file: 'federatedAuthRequestCanceled.md',
+      links: [{
+        link: 'https://fedidcg.github.io/FedCM/',
+        linkTitle: i18nLazyString(UIStrings.fedCm),
+      }],
+    },
+  ],
+]);

package/front_end/models/issues_manager/IssuesManager.ts

@@ -13,6 +13,7 @@ import {ContentSecurityPolicyIssue} from './ContentSecurityPolicyIssue.js';
 import {CorsIssue} from './CorsIssue.js';
 import {CrossOriginEmbedderPolicyIssue, isCrossOriginEmbedderPolicyIssue} from './CrossOriginEmbedderPolicyIssue.js';
 import {DeprecationIssue} from './DeprecationIssue.js';
+import {FederatedAuthRequestIssue} from './FederatedAuthRequestIssue.js';
 import {GenericIssue} from './GenericIssue.js';
 import {HeavyAdIssue} from './HeavyAdIssue.js';
 import type {Issue, IssueKind} from './Issue.js';
@@ -104,6 +105,10 @@ const issueCodeHandlers = new Map<
     Protocol.Audits.InspectorIssueCode.ClientHintIssue,
     ClientHintIssue.fromInspectorIssue,
   ],
+  [
+    Protocol.Audits.InspectorIssueCode.FederatedAuthRequestIssue,
+    FederatedAuthRequestIssue.fromInspectorIssue,
+  ],
 ]);
 
 /**

package/front_end/models/issues_manager/descriptions/federatedAuthRequestAccountsHttpNotFound.md

@@ -0,0 +1 @@
+# The provider's accounts list endpoint cannot be found.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestAccountsInvalidResponse.md

@@ -0,0 +1 @@
+# Provider's accounts list is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestAccountsNoResponse.md

@@ -0,0 +1 @@
+# The response body is empty when fetching the provider's accounts list.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestApprovalDeclined.md

@@ -0,0 +1 @@
+# User declined the sign-in attempt.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestCanceled.md

@@ -0,0 +1 @@
+# The request has been aborted.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestClientIdMetadataHttpNotFound.md

@@ -0,0 +1 @@
+# The provider's client metadata endpoint cannot be found.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestClientIdMetadataInvalidResponse.md

@@ -0,0 +1 @@
+# Provider's client metadata is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestClientIdMetadataNoResponse.md

@@ -0,0 +1 @@
+# The response body is empty when fetching the provider's client metadata.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestErrorFetchingSignin.md

@@ -0,0 +1 @@
+# Error attempting to reach the provider's sign-in endpoint.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestErrorIdToken.md

@@ -0,0 +1 @@
+# Error retrieving an id token.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenHttpNotFound.md

@@ -0,0 +1 @@
+# The provider's id token endpoint cannot be found.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenInvalidRequest.md

@@ -0,0 +1 @@
+# The id token fetching request is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenInvalidResponse.md

@@ -0,0 +1 @@
+# Provider's id token is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestIdTokenNoResponse.md

@@ -0,0 +1 @@
+# The response body is empty when fetching the provider's id token.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestInvalidSigninResponse.md

@@ -0,0 +1 @@
+# Provider's sign-in response is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestTooManyRequests.md

@@ -0,0 +1 @@
+# Only one navigator.credentials.get request may be outstanding at one time.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownHttpNotFound.md

@@ -0,0 +1 @@
+# The provider's .well-known configuration cannot be found.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownInvalidResponse.md

@@ -0,0 +1 @@
+# Provider's .well-known configuration is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestWellKnownNoResponse.md

@@ -0,0 +1 @@
+# The response body is empty when fetching the provider's .well-known configuration.

package/front_end/panels/application/InterestGroupStorageView.ts

@@ -18,8 +18,10 @@ const UIStrings = {
   */
   clickToDisplayBody: 'Click on any interest group event to display the group\'s current state',
   /**
-  interestGroupStorageItems: 'InterestGroup Storage Items',
+  *@description Placeholder text telling the user no details are available for
+  *the selected interest group.
   */
+  noDataAvailable: 'No details available for the selected interest group. The browser may have left the group.',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/application/InterestGroupStorageView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -37,24 +39,33 @@ export class InterestGroupStorageView extends UI.SplitWidget.SplitWidget {
   private readonly interestGroupGrid = new ApplicationComponents.InterestGroupAccessGrid.InterestGroupAccessGrid();
   private events: Protocol.Storage.InterestGroupAccessedEvent[] = [];
   private detailsGetter: InterestGroupDetailsGetter;
+  private noDataView: UI.Widget.VBox;
+  private noDisplayView: UI.Widget.VBox;
 
   constructor(detailsGetter: InterestGroupDetailsGetter) {
     super(/* isVertical */ false, /* secondIsSidebar: */ true);
     this.detailsGetter = detailsGetter;
 
     const topPanel = new UI.Widget.VBox();
-    const bottomPanel = new UI.Widget.VBox();
+    this.noDisplayView = new UI.Widget.VBox();
+    this.noDataView = new UI.Widget.VBox();
+
     topPanel.setMinimumSize(0, 80);
     this.setMainWidget(topPanel);
-    bottomPanel.setMinimumSize(0, 40);
-    this.setSidebarWidget(bottomPanel);
+    this.noDisplayView.setMinimumSize(0, 40);
+    this.setSidebarWidget(this.noDisplayView);
+    this.noDataView.setMinimumSize(0, 40);
 
     topPanel.contentElement.appendChild(this.interestGroupGrid);
     this.interestGroupGrid.addEventListener('cellfocused', this.onFocus.bind(this));
 
-    bottomPanel.contentElement.classList.add('placeholder');
-    const centered = bottomPanel.contentElement.createChild('div');
-    centered.textContent = i18nString(UIStrings.clickToDisplayBody);
+    this.noDisplayView.contentElement.classList.add('placeholder');
+    const noDisplayDiv = this.noDisplayView.contentElement.createChild('div');
+    noDisplayDiv.textContent = i18nString(UIStrings.clickToDisplayBody);
+
+    this.noDataView.contentElement.classList.add('placeholder');
+    const noDataDiv = this.noDataView.contentElement.createChild('div');
+    noDataDiv.textContent = i18nString(UIStrings.noDataAvailable);
   }
 
   wasShown(): void {
@@ -77,6 +88,7 @@ export class InterestGroupStorageView extends UI.SplitWidget.SplitWidget {
   clearEvents(): void {
     this.events = [];
     this.interestGroupGrid.data = this.events;
+    this.setSidebarWidget(this.noDisplayView);
   }
 
   private async onFocus(event: Event): Promise<void> {
@@ -99,6 +111,8 @@ export class InterestGroupStorageView extends UI.SplitWidget.SplitWidget {
       if (jsonView) {
         this.setSidebarWidget(jsonView);
       }
+    } else {
+      this.setSidebarWidget(this.noDataView);
     }
   }
 

package/front_end/panels/console/ConsoleViewMessage.ts

@@ -1470,10 +1470,8 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
         continue;
       }
       const formattedLine = document.createElement('span');
-      const prefix = line.substring(0, link.positionLeft);
-      const suffix = `${line.substring(link.positionRight)}${newline}`;
-
-      formattedLine.appendChild(this.linkifyStringAsFragment(prefix));
+      const suffix = `${link.suffix}${newline}`;
+      formattedLine.appendChild(this.linkifyStringAsFragment(link.prefix));
       const scriptLocationLink = this.linkifier.linkifyScriptLocation(
           debuggerModel.target(), link.scriptId || null, link.url, link.lineNumber, {
             columnNumber: link.columnNumber,
@@ -1492,7 +1490,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
         continue;
       }
 
-      const prefixWithoutFunction = prefix.substring(0, prefix.lastIndexOf(' ', prefix.length - 3));
+      const prefixWithoutFunction = link.prefix.substring(0, link.prefix.lastIndexOf(' ', link.prefix.length - 3));
 
       // If we were able to parse the function name from the stack trace line, try to replace it with an expansion of
       // any inline frames.

package/front_end/panels/console/ErrorStackParser.ts

@@ -10,8 +10,10 @@ export interface ParsedErrorFrame {
   line: string;
   link?: {
     url: string,
+    prefix: string,
+    suffix: string,
     lineNumber?: number,
-    columnNumber?: number, enclosedInBraces: boolean, positionLeft: number, positionRight: number,
+    columnNumber?: number, enclosedInBraces: boolean,
     scriptId?: Protocol.Runtime.ScriptId,
   };
 }
@@ -88,9 +90,9 @@ export function parseSourcePositionsFromErrorStack(
       line,
       link: {
         url,
+        prefix: line.substring(0, left),
+        suffix: line.substring(right),
         enclosedInBraces: hasOpenBracket,
-        positionLeft: left,
-        positionRight: right,
         lineNumber: splitResult.lineNumber,
         columnNumber: splitResult.columnNumber,
       },

package/front_end/panels/lighthouse/LighthouseReportRenderer.ts

@@ -140,9 +140,12 @@ export class LighthouseReportRenderer extends LighthouseReport.ReportRenderer {
   }
 
   static handleDarkMode(el: Element): void {
-    if (ThemeSupport.ThemeSupport.instance().themeName() === 'dark') {
-      el.classList.add('lh-dark');
-    }
+    const updateDarkModeIfNecessary = (): void => {
+      el.classList.toggle('lh-dark', ThemeSupport.ThemeSupport.instance().themeName() === 'dark');
+    };
+    ThemeSupport.ThemeSupport.instance().addEventListener(
+        ThemeSupport.ThemeChangeEvent.eventName, updateDarkModeIfNecessary);
+    updateDarkModeIfNecessary();
   }
 }
 

package/front_end/panels/sources/CSSPlugin.ts

@@ -238,12 +238,14 @@ function createCSSTooltip(active: ActiveTooltip): CodeMirror.Tooltip {
             changes: text === active.text ? undefined :
                                             {from: active.pos, to: active.pos + text.length, insert: active.text},
           });
+          widget.hideWidget();
           view.focus();
         }
       });
       widget.element.addEventListener('focusout', event => {
         if (event.relatedTarget && !widget.element.contains(event.relatedTarget as Node)) {
           view.dispatch({effects: setTooltip.of(null)});
+          widget.hideWidget();
         }
       }, false);
       widget.element.addEventListener('mousedown', event => event.consume());