chrome-devtools-frontend 1.0.963415 → 1.0.963960

package/docs/resource_management.md

@@ -0,0 +1,119 @@
+# Resource management in DevTools
+
+This document outlines how DevTools keeps track of resources like scripts and
+HTML files, and how they interact with other features such as the Debugger.
+The source code lives in the bindings/, persistence/ and workspace/ directories.
+
+## Core concepts and classes
+
+* **Project:** Interface to a collection of resources. DevTools supports
+  different project **types**. For example “filesystem”, for resources
+  originating from the developers local machine, and “network”, for actual page
+  resources. The **Project** interface abstracts away rudimentary file
+  operations. Depending on the **type**, a **Project** may be able to create,
+  rename or delete resources, or change the contents.
+
+* **Workspace**: A collection of all the **Projects** currently in use.
+  Implemented as a singleton in WorkspaceImpl.ts.
+
+* **UISourceCode:** An actual resource identified by its URL. Scripts and
+  stylesheets are prominent examples, but DevTools also uses more esoteric
+  **ResourceTypes** such as XHR, WebSocket or EventSource.
+
+## Project types
+
+A short overview over the different Project types and what **kind of resources**
+they contain.
+
+* **Network:** All resources loaded from the network are stored in network
+  projects. Different targets and/or **Resource** **types** may use different
+  projects. E.g. Each target has their own project containing only JavaScript
+  source maps.
+
+* **Filesystem:** Resources stored on the developers local machine.
+  * Snippets are managed with a single Project just for snippets.
+  * Each local directory mapped into DevTools with the “Workspaces” feature has
+    its own project.
+  * Each directory used for the “Overrides” feature has a corresponding project
+    to manage the local files.
+
+* **Formatter:** A single project of this type manages the formatted version of
+  script resources. That is the “pretty-print” feature for minified JS files.
+
+* **ContentScripts**: Scripts from extensions running in the context of the page
+  itself. One project per target. Source maps for content scripts are managed by
+  separate, per target, projects. The source map projects also have the
+  **ContentScripts** type.
+
+* **Service:** One project of this type per target. It holds placeholder
+  UISourceCodes for source maps while they are loaded. Once a source map
+  finishes loading, the placeholder is removed from the **Service** project.
+
+* **Debugger:** One project of this type per target. Debugger projects store
+  parsed JS scripts (see next section).
+
+## The “Debugger” project type
+
+When V8 parses scripts, it sends out a
+[“Debugger.ScriptParsed”](https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#event-scriptParsed)
+event with some details, including a unique script ID and the URL of the script.
+For each “Debugger.ScriptParsed” event, DevTools creates a **Script** object and
+an associated **UISourceCode** in the “debugger” project. It is important to
+note that the URL of this “debugger” UISourceCode contains both the script ID as
+well as the script name (not URL!) to uniquely identify it. This is because:
+
+_The relationship between network/filesystem UISourceCodes and **Script**
+**objects**/debugger UISourceCodes is 1:n._
+
+For example if the same script is included twice on a page with <script>
+elements, it will result in a single UISourceCode in the **Network** project but
+**two Script** **objects** and two UISourceCodes in the **Debugger** project.
+Similarly, every invocation of a Snippet will result in a separate **Script**
+object per invocation while the Snippet itself is stored in a **Filesystem**
+project.
+
+## Mappings and bindings
+
+As can be seen above, UISourceCodes in different projects can potentially be
+related to one another. A minified script resource in a **scripts Network project**
+might have a pretty-printed version in the **Formatter project** while the
+source map for the minified script is stored in the **source map Network project**.
+Once the minified script is parsed/executed by V8, it also has a corresponding
+**Script object** and a UISourceCode in the **Debugger project**.
+
+This brings us to mappings and bindings. The terminology is roughly:
+
+* _A **binding** ties different UISourceCodes together and determines which
+  UISourceCodes relate to one another._
+* _A **mapping** translates source positions between bound UISourceCodes._
+
+## Binding implementations
+
+There are a couple of classes tasked with establishing bindings between
+UISourceCodes:
+
+* **DebuggerWorkspaceBinding:** Responsible for scripts and source maps.
+  It ties together network/filesystem UISourceCodes with **Script** objects and
+  the debugger USourceCodes. Script source maps are also partially implemented
+  by this class.
+
+* **CSSWorkspaceBinding:** Responsible for CSS and CSS source maps. DevTools can
+  handle source mapped CSS when it was authored in SASS and this class is
+  responsible for binding the corresponding UISourceCodes.
+
+* **PersistenceBinding/PersistenceImpl/Automapping**: Responsible for the
+  [“Workspaces”](https://developer.chrome.com/docs/devtools/workspaces/)
+  feature. When a developer adds a local directory to DevTools that corresponds
+  to the pages sources, these classes establish and manage the binding between
+  the corresponding **Filesystem** and **Network** resources.
+
+* **NetworkPersistenceManager**: Responsible for the
+  [“Local Overrides”](https://developer.chrome.com/blog/new-in-devtools-65/#overrides)
+  feature. It connects the **Network** resources with the corresponding
+  overwritten version in a **Filesystem** project. This class also handles
+  network request interceptions and determines whether to serve the original or
+  the overwritten UISourceCode.
+
+Please keep in mind that many of these classes have gathered additional
+responsibilities over the years, so the concepts presented above might not
+always cleanly apply or be apparent in code.

package/front_end/core/i18n/locales/en-US.json

@@ -4809,10 +4809,10 @@
     "message": "Copy selector"
   },
   "panels/elements/StylesSidebarPane.ts | cssPropertyName": {
-    "message": "CSS property name"
+    "message": "CSS property name: {PH1}"
   },
   "panels/elements/StylesSidebarPane.ts | cssPropertyValue": {
-    "message": "CSS property value"
+    "message": "CSS property value: {PH1}"
   },
   "panels/elements/StylesSidebarPane.ts | cssSelector": {
     "message": "CSS selector"

package/front_end/core/i18n/locales/en-XL.json

@@ -4809,10 +4809,10 @@
     "message": "Ĉóp̂ý selector"
   },
   "panels/elements/StylesSidebarPane.ts | cssPropertyName": {
-    "message": "CSS p̂ŕôṕêŕt̂ý n̂ám̂é"
+    "message": "CSS p̂ŕôṕêŕt̂ý n̂ám̂é: {PH1}"
   },
   "panels/elements/StylesSidebarPane.ts | cssPropertyValue": {
-    "message": "CSS p̂ŕôṕêŕt̂ý v̂ál̂úê"
+    "message": "CSS p̂ŕôṕêŕt̂ý v̂ál̂úê: {PH1}"
   },
   "panels/elements/StylesSidebarPane.ts | cssSelector": {
     "message": "CSS ŝél̂éĉt́ôŕ"

package/front_end/core/sdk/DOMModel.ts

@@ -1038,7 +1038,7 @@ export class DOMModel extends SDKModel<EventTypes> {
     this.#pendingDocumentRequestPromise = null;
 
     if (!target.suspended()) {
-      void this.agent.invoke_enable();
+      void this.agent.invoke_enable({});
     }
 
     if (Root.Runtime.experiments.isEnabled('captureNodeCreationStacks')) {
@@ -1497,7 +1497,7 @@ export class DOMModel extends SDKModel<EventTypes> {
   }
 
   async resumeModel(): Promise<void> {
-    await this.agent.invoke_enable();
+    await this.agent.invoke_enable({});
   }
 
   dispose(): void {

package/front_end/generated/InspectorBackendCommands.js

@@ -295,7 +295,6 @@ export function registerCommands(inspectorBackend) {
     AttributionReportingIssue: 'AttributionReportingIssue',
     QuirksModeIssue: 'QuirksModeIssue',
     NavigatorUserAgentIssue: 'NavigatorUserAgentIssue',
-    WasmCrossOriginModuleSharingIssue: 'WasmCrossOriginModuleSharingIssue',
     GenericIssue: 'GenericIssue',
     DeprecationIssue: 'DeprecationIssue',
     ClientHintIssue: 'ClientHintIssue'
@@ -681,7 +680,9 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerCommand('DOM.disable', [], []);
   inspectorBackend.registerCommand(
       'DOM.discardSearchResults', [{'name': 'searchId', 'type': 'string', 'optional': false}], []);
-  inspectorBackend.registerCommand('DOM.enable', [], []);
+  inspectorBackend.registerEnum('DOM.EnableRequestIncludeWhitespace', {None: 'none', All: 'all'});
+  inspectorBackend.registerCommand(
+      'DOM.enable', [{'name': 'includeWhitespace', 'type': 'string', 'optional': true}], []);
   inspectorBackend.registerCommand(
       'DOM.focus',
       [
@@ -2114,7 +2115,7 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerEnum(
       'Page.NavigationType', {Navigation: 'Navigation', BackForwardCacheRestore: 'BackForwardCacheRestore'});
   inspectorBackend.registerEnum('Page.BackForwardCacheNotRestoredReason', {
-    NotMainFrame: 'NotMainFrame',
+    NotPrimaryMainFrame: 'NotPrimaryMainFrame',
     BackForwardCacheDisabled: 'BackForwardCacheDisabled',
     RelatedActiveContentsExist: 'RelatedActiveContentsExist',
     HTTPStatusNotOK: 'HTTPStatusNotOK',
@@ -2637,7 +2638,7 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerEvent('Storage.cacheStorageListUpdated', ['origin']);
   inspectorBackend.registerEvent('Storage.indexedDBContentUpdated', ['origin', 'databaseName', 'objectStoreName']);
   inspectorBackend.registerEvent('Storage.indexedDBListUpdated', ['origin']);
-  inspectorBackend.registerEvent('Storage.interestGroupAccessed', ['type', 'ownerOrigin', 'name']);
+  inspectorBackend.registerEvent('Storage.interestGroupAccessed', ['accessTime', 'type', 'ownerOrigin', 'name']);
   inspectorBackend.registerCommand(
       'Storage.clearDataForOrigin',
       [
@@ -3488,6 +3489,9 @@ export function registerCommands(inspectorBackend) {
       []);
   inspectorBackend.registerCommand(
       'Runtime.removeBinding', [{'name': 'name', 'type': 'string', 'optional': false}], []);
+  inspectorBackend.registerCommand(
+      'Runtime.getExceptionDetails', [{'name': 'errorObjectId', 'type': 'string', 'optional': false}],
+      ['exceptionDetails']);
 
   // Schema.
   inspectorBackend.registerCommand('Schema.getDomains', [], ['domains']);

package/front_end/generated/protocol-mapping.d.ts

@@ -1138,7 +1138,7 @@ export namespace ProtocolMapping {
     /**
      * Enables DOM agent for the given page.
      */
-    'DOM.enable': {paramsType: []; returnType: void;};
+    'DOM.enable': {paramsType: [Protocol.DOM.EnableRequest?]; returnType: void;};
     /**
      * Focuses the given element.
      */
@@ -3115,6 +3115,17 @@ export namespace ProtocolMapping {
      * unsubscribes current runtime agent from Runtime.bindingCalled notifications.
      */
     'Runtime.removeBinding': {paramsType: [Protocol.Runtime.RemoveBindingRequest]; returnType: void;};
+    /**
+     * This method tries to lookup and populate exception details for a
+     * JavaScript Error object.
+     * Note that the stackTrace portion of the resulting exceptionDetails will
+     * only be populated if the Runtime domain was enabled at the time when the
+     * Error was thrown.
+     */
+    'Runtime.getExceptionDetails': {
+      paramsType: [Protocol.Runtime.GetExceptionDetailsRequest];
+      returnType: Protocol.Runtime.GetExceptionDetailsResponse;
+    };
     /**
      * Returns supported domains.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -824,7 +824,7 @@ declare namespace ProtocolProxyApi {
     /**
      * Enables DOM agent for the given page.
      */
-    invoke_enable(): Promise<Protocol.ProtocolResponseWithError>;
+    invoke_enable(params: Protocol.DOM.EnableRequest): Promise<Protocol.ProtocolResponseWithError>;
 
     /**
      * Focuses the given element.
@@ -4050,6 +4050,16 @@ declare namespace ProtocolProxyApi {
      * unsubscribes current runtime agent from Runtime.bindingCalled notifications.
      */
     invoke_removeBinding(params: Protocol.Runtime.RemoveBindingRequest): Promise<Protocol.ProtocolResponseWithError>;
+
+    /**
+     * This method tries to lookup and populate exception details for a
+     * JavaScript Error object.
+     * Note that the stackTrace portion of the resulting exceptionDetails will
+     * only be populated if the Runtime domain was enabled at the time when the
+     * Error was thrown.
+     */
+    invoke_getExceptionDetails(params: Protocol.Runtime.GetExceptionDetailsRequest):
+        Promise<Protocol.Runtime.GetExceptionDetailsResponse>;
   }
   export interface RuntimeDispatcher {
     /**

package/front_end/generated/protocol.ts

@@ -1011,13 +1011,6 @@ export namespace Audits {
     location?: SourceCodeLocation;
   }
 
-  export interface WasmCrossOriginModuleSharingIssueDetails {
-    wasmModuleUrl: string;
-    sourceOrigin: string;
-    targetOrigin: string;
-    isWarning: boolean;
-  }
-
   export const enum GenericIssueErrorType {
     CrossOriginPortalPostMessageError = 'CrossOriginPortalPostMessageError',
   }
@@ -1086,7 +1079,6 @@ export namespace Audits {
     AttributionReportingIssue = 'AttributionReportingIssue',
     QuirksModeIssue = 'QuirksModeIssue',
     NavigatorUserAgentIssue = 'NavigatorUserAgentIssue',
-    WasmCrossOriginModuleSharingIssue = 'WasmCrossOriginModuleSharingIssue',
     GenericIssue = 'GenericIssue',
     DeprecationIssue = 'DeprecationIssue',
     ClientHintIssue = 'ClientHintIssue',
@@ -1110,7 +1102,6 @@ export namespace Audits {
     attributionReportingIssueDetails?: AttributionReportingIssueDetails;
     quirksModeIssueDetails?: QuirksModeIssueDetails;
     navigatorUserAgentIssueDetails?: NavigatorUserAgentIssueDetails;
-    wasmCrossOriginModuleSharingIssue?: WasmCrossOriginModuleSharingIssueDetails;
     genericIssueDetails?: GenericIssueDetails;
     deprecationIssueDetails?: DeprecationIssueDetails;
     clientHintIssueDetails?: ClientHintIssueDetails;
@@ -3245,6 +3236,18 @@ export namespace DOM {
     searchId: string;
   }
 
+  export const enum EnableRequestIncludeWhitespace {
+    None = 'none',
+    All = 'all',
+  }
+
+  export interface EnableRequest {
+    /**
+     * Whether to include whitespaces in the children array of returned Nodes.
+     */
+    includeWhitespace?: EnableRequestIncludeWhitespace;
+  }
+
   export interface FocusRequest {
     /**
      * Identifier of the node.
@@ -5927,7 +5930,7 @@ export namespace Input {
     /**
      * Editing commands to send with the key event (e.g., 'selectAll') (default: []).
      * These are related to but not equal the command names used in `document.execCommand` and NSStandardKeyBindingResponding.
-     * See https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/editing/commands/editor_command_names.h for valid command names.
+     * See https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/editing/commands/editor_command_names.h for valid command names.
      */
     commands?: string[];
   }
@@ -10597,7 +10600,7 @@ export namespace Page {
    * List of not restored reasons for back-forward cache.
    */
   export const enum BackForwardCacheNotRestoredReason {
-    NotMainFrame = 'NotMainFrame',
+    NotPrimaryMainFrame = 'NotPrimaryMainFrame',
     BackForwardCacheDisabled = 'BackForwardCacheDisabled',
     RelatedActiveContentsExist = 'RelatedActiveContentsExist',
     HTTPStatusNotOK = 'HTTPStatusNotOK',
@@ -12492,7 +12495,7 @@ export namespace Storage {
   export interface InterestGroupDetails {
     ownerOrigin: string;
     name: string;
-    expirationTime: number;
+    expirationTime: Network.TimeSinceEpoch;
     joiningOrigin: string;
     biddingUrl?: string;
     biddingWasmHelperUrl?: string;
@@ -12702,6 +12705,7 @@ export namespace Storage {
    * One of the interest groups was accessed by the associated page.
    */
   export interface InterestGroupAccessedEvent {
+    accessTime: Network.TimeSinceEpoch;
     type: InterestGroupAccessType;
     ownerOrigin: string;
     name: string;
@@ -16618,6 +16622,17 @@ export namespace Runtime {
     name: string;
   }
 
+  export interface GetExceptionDetailsRequest {
+    /**
+     * The error object for which to resolve the exception details.
+     */
+    errorObjectId: RemoteObjectId;
+  }
+
+  export interface GetExceptionDetailsResponse extends ProtocolResponseWithError {
+    exceptionDetails?: ExceptionDetails;
+  }
+
   /**
    * Notification is issued every time when binding is called.
    */

package/front_end/panels/animation/AnimationUI.ts

@@ -279,7 +279,8 @@ export class AnimationUI {
     const iterationWidth = this.duration() * this.#timeline.pixelMsRatio();
     let iteration;
     for (iteration = 1; iteration < this.#animationInternal.source().iterations() &&
-         iterationWidth * (iteration - 1) < this.#timeline.width();
+         iterationWidth * (iteration - 1) < this.#timeline.width() &&
+         (iterationWidth > 0 || this.#animationInternal.source().iterations() !== Infinity);
          iteration++) {
       this.renderIteration(this.#tailGroup, iteration);
     }

package/front_end/panels/application/components/BackForwardCacheStrings.ts

@@ -508,7 +508,7 @@ const str_ = i18n.i18n.registerUIStrings('panels/application/components/BackForw
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export const NotRestoredReasonDescription = {
-  'NotMainFrame': {name: i18nLazyString(UIStrings.notMainFrame)},
+  'NotPrimaryMainFrame': {name: i18nLazyString(UIStrings.notMainFrame)},
   'BackForwardCacheDisabled': {name: i18nLazyString(UIStrings.backForwardCacheDisabled)},
   'RelatedActiveContentsExist': {name: i18nLazyString(UIStrings.relatedActiveContentsExist)},
   'HTTPStatusNotOK': {name: i18nLazyString(UIStrings.HTTPStatusNotOK)},

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -165,12 +165,14 @@ const UIStrings = {
   newStyleRule: 'New Style Rule',
   /**
   *@description Text that is announced by the screen reader when the user focuses on an input field for entering the name of a CSS property in the Styles panel
+  *@example {margin} PH1
   */
-  cssPropertyName: '`CSS` property name',
+  cssPropertyName: '`CSS` property name: {PH1}',
   /**
   *@description Text that is announced by the screen reader when the user focuses on an input field for entering the value of a CSS property in the Styles panel
+  *@example {10px} PH1
   */
-  cssPropertyValue: '`CSS` property value',
+  cssPropertyValue: '`CSS` property value: {PH1}',
   /**
   *@description Text that is announced by the screen reader when the user focuses on an input field for editing the name of a CSS selector in the Styles panel
   */
@@ -3091,7 +3093,7 @@ export class StylesSidebarPropertyRenderer {
 
   renderName(): Element {
     const nameElement = document.createElement('span');
-    UI.ARIAUtils.setAccessibleName(nameElement, i18nString(UIStrings.cssPropertyName));
+    UI.ARIAUtils.setAccessibleName(nameElement, i18nString(UIStrings.cssPropertyName, {PH1: this.propertyName}));
     nameElement.className = 'webkit-css-property';
     nameElement.textContent = this.propertyName;
     nameElement.normalize();
@@ -3100,7 +3102,7 @@ export class StylesSidebarPropertyRenderer {
 
   renderValue(): Element {
     const valueElement = document.createElement('span');
-    UI.ARIAUtils.setAccessibleName(valueElement, i18nString(UIStrings.cssPropertyValue));
+    UI.ARIAUtils.setAccessibleName(valueElement, i18nString(UIStrings.cssPropertyValue, {PH1: this.propertyValue}));
     valueElement.className = 'value';
     if (!this.propertyValue) {
       return valueElement;

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.963415"
+  "version": "1.0.963960"
 }

package/scripts/devtools_paths.js

@@ -59,8 +59,9 @@ function isInChromiumDirectory() {
   }
 
   const normalizedPath = PATH_TO_EXECUTED_FILE.split(path.sep).join('/');
-  const isInChromium = normalizedPath.includes('chromium/src/third_party/devtools-frontend');
-  const potentialChromiumDir = PATH_TO_EXECUTED_FILE.substring(0, PATH_TO_EXECUTED_FILE.indexOf('chromium') + 8);
+  const devtoolsPath = 'src/third_party/devtools-frontend';
+  const isInChromium = normalizedPath.includes(devtoolsPath);
+  const potentialChromiumDir = PATH_TO_EXECUTED_FILE.substring(0, PATH_TO_EXECUTED_FILE.indexOf(devtoolsPath));
   const result = {isInChromium, chromiumDirectory: potentialChromiumDir};
   _lookUpCaches.set('chromium', result);
   return result;

package/scripts/whitespaces.txt

@@ -8,3 +8,4 @@ Surma was here.
 .
 .
 Today's answer to life the universe and everything is 161!
+No good text, but numbers ... 2!