chrome-devtools-frontend 1.0.956975 → 1.0.959105

package/front_end/ui/legacy/toolbar.css

@@ -354,6 +354,7 @@ select.toolbar-item:focus-visible > * {
   overflow: hidden;
   white-space: nowrap;
   cursor: auto;
+  color: var(--color-text-primary);
 }
 /* Separator */
 
@@ -394,6 +395,7 @@ input[is="history-input"] {
   border: 1px solid transparent;
   line-height: 16px;
   padding: 1px;
+  color: var(--color-text-primary);
 }
 
 input[is="history-input"]:hover {

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.956975"
+  "version": "1.0.959105"
 }

package/scripts/build/generate_css_js_files.js

@@ -4,6 +4,7 @@
 const fs = require('fs');
 const path = require('path');
 const CleanCSS = require('clean-css');
+const {writeIfChanged} = require('./ninja/write-if-changed.js');
 const [, , buildTimestamp, isDebugString, legacyString, targetName, srcDir, targetGenDir, files] = process.argv;
 
 const filenames = files.split(',');
@@ -34,21 +35,22 @@ export default styles;`;
   }
 
   const generatedFileName = `${fileName}${isLegacy ? '.legacy' : ''}.js`;
-
-  fs.writeFileSync(
-      path.join(targetGenDir, generatedFileName),
-      `// Copyright ${new Date(Number(buildTimestamp) * 1000).getFullYear()} The Chromium Authors. All rights reserved.
+  const generatedFileLocation = path.join(targetGenDir, generatedFileName);
+  const newContents = `// Copyright ${
+      new Date(Number(buildTimestamp) * 1000).getUTCFullYear()} The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // IMPORTANT: this file is auto generated. Please do not edit this file.
 /* istanbul ignore file */
 ${exportStatement}
-`);
+`;
+
+  writeIfChanged(generatedFileLocation, newContents);
 
   configFiles.push(`\"${generatedFileName}\"`);
 }
 
-fs.writeFileSync(path.join(targetGenDir, `${targetName}-tsconfig.json`), `{
+writeIfChanged(path.join(targetGenDir, `${targetName}-tsconfig.json`), `{
     "compilerOptions": {
         "composite": true,
         "outDir": "."

package/scripts/build/generate_html_entrypoint.js

@@ -5,6 +5,7 @@
 const fs = require('fs');
 const path = require('path');
 const {argv} = require('yargs');
+const {writeIfChanged} = require('./ninja/write-if-changed.js');
 
 const {template} = argv;
 
@@ -32,5 +33,5 @@ const templateContent = fs.readFileSync(template, 'utf-8');
 
 for (const entrypoint of entrypoints) {
   const rewrittenTemplateContent = templateContent.replace(new RegExp('%ENTRYPOINT_NAME%', 'g'), entrypoint);
-  fs.writeFileSync(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
+  writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
 }

package/scripts/build/ninja/copy-file.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('./write-if-changed.js');
 const [, , src, dest] = process.argv;
 
 const srcPath = path.join(process.cwd(), src);
@@ -23,7 +24,7 @@ if (fileExists(destPath)) {
 // Force a write to the target filesystem, since by default the ninja
 // toolchain will create a hardlink, which in turn reflects changes in
 // gen and resources/inspector back to //front_end.
-fs.writeFileSync(destPath, srcContents);
+writeIfChanged(destPath, srcContents);
 
 /**
  * Case sensitive implementation of a file look up.

package/scripts/build/ninja/copy-files.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('./write-if-changed.js');
 const [, , src, dest, files] = process.argv;
 
 for (const file of files.split(',')) {
@@ -24,7 +25,7 @@ for (const file of files.split(',')) {
   // Force a write to the target filesystem, since by default the ninja
   // toolchain will create a hardlink, which in turn reflects changes in
   // gen and resources/inspector back to //front_end.
-  fs.writeFileSync(destPath, srcContents);
+  writeIfChanged(destPath, srcContents);
 }
 
 /**

package/scripts/build/ninja/generate-declaration.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('./write-if-changed.js');
 
 const [, , outputDirectory, entrypointName] = process.argv;
 
@@ -13,4 +14,4 @@ const outputLocation = path.join(outputDirectory, `${rawFileName}.d.ts`);
 // We can't use copy here, as that would maintain the original file timestamps.
 // This can throw off Ninja, which verifies that timestamps of generated files
 // are the same as the timestamp it ran the action on.
-fs.writeFileSync(outputLocation, fs.readFileSync(inputLocation));
+writeIfChanged(outputLocation, fs.readFileSync(inputLocation));

package/scripts/build/ninja/node.gni

@@ -20,7 +20,10 @@ template("node_action") {
 
     _full_script_location = devtools_location_prepend + invoker.script
 
-    inputs += [ _full_script_location ]
+    inputs += [
+      _full_script_location,
+      devtools_location_prepend + "scripts/build/ninja/write-if-changed.js",
+    ]
 
     args = [ rebase_path(_full_script_location, root_build_dir) ] + invoker.args
   }

package/scripts/build/ninja/write-if-changed.js

@@ -0,0 +1,27 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const fs = require('fs');
+
+/**
+ * Only write content to a file if the content is different that what it previously contained.
+ * The reason for only writing when necessary is that GN uses file timestamps to determine freshness.
+ * Therefore, if the file contents hasn't changed, but the timestamp has, GN thinks the file is new.
+ *
+ * Instead, we can only write when the content is changed, meaning we don't touch a file when it is
+ * unchanged. This would preserve the original file timestamps and hence GN can correctly conclude
+ * the file output hasn't changed.
+ *
+ * @param {string} generatedFileLocation Location to write to
+ * @param {string} newContents The contents to write (or noop if unchanged with previous content)
+ */
+module.exports.writeIfChanged = (generatedFileLocation, newContents) => {
+  if (fs.existsSync(generatedFileLocation)) {
+    if (fs.readFileSync(generatedFileLocation, {encoding: 'utf8', flag: 'r'}) === newContents) {
+      return;
+    }
+  }
+
+  fs.writeFileSync(generatedFileLocation, newContents, {encoding: 'utf-8'});
+};

package/front_end/third_party/codemirror/README.md

@@ -1,3 +0,0 @@
-Treat `codemirror.css` like a rolled-in upstream dependency. Instead of changing it directly, consider changing `front_end/text_editor/cmdevtools.css` instead.
-
-[Issue #1076825](https://bugs.chromium.org/p/chromium/issues/detail?id=1076825) tracks the effort to use the upstream file more directly.

package/front_end/third_party/codemirror/codemirror.css

@@ -1,283 +0,0 @@
-/* The rest of this file contains styles related to the mechanics of
-   the editor. You probably shouldn't touch them. */
-
-.CodeMirror {
-  position: relative;
-  overflow: hidden;
-  background: var(--color-background);
-}
-
-.CodeMirror-scroll {
-  overflow: scroll !important; /* Things will break if this is overridden */
-  /* 50px is the magic margin used to hide the element's real scrollbars */
-  /* See overflow: hidden in .CodeMirror */
-  margin-bottom: -50px;
-  margin-right: -50px;
-  padding-bottom: 50px;
-  height: 100%;
-  outline: none; /* Prevent dragging from highlighting the element */
-  position: relative;
-}
-
-.CodeMirror-sizer {
-  position: relative;
-  border-right: 50px solid transparent;
-}
-
-/* The fake, visible scrollbars. Used to force redraw during scrolling
-   before actual scrolling happens, thus preventing shaking and
-   flickering artifacts. */
-.CodeMirror-vscrollbar,
-.CodeMirror-hscrollbar,
-.CodeMirror-scrollbar-filler,
-.CodeMirror-gutter-filler {
-  position: absolute;
-  z-index: 6;
-  display: none;
-  outline: none;
-}
-
-.CodeMirror-vscrollbar {
-  right: 0;
-  top: 0;
-  overflow-x: hidden;
-  overflow-y: scroll;
-}
-
-.CodeMirror-hscrollbar {
-  bottom: 0;
-  left: 0;
-  overflow-y: hidden;
-  overflow-x: scroll;
-}
-
-.CodeMirror-scrollbar-filler {
-  right: 0;
-  bottom: 0;
-}
-
-.CodeMirror-gutter-filler {
-  left: 0;
-  bottom: 0;
-}
-
-.CodeMirror-gutters {
-  position: absolute;
-  left: 0;
-  top: 0;
-  min-height: 100%;
-  z-index: 3;
-}
-
-.CodeMirror-gutter {
-  white-space: normal;
-  height: 100%;
-  display: inline-block;
-  vertical-align: top;
-  margin-bottom: -50px;
-}
-
-.CodeMirror-gutter-wrapper {
-  position: absolute;
-  z-index: 4;
-  background: none !important;
-  border: none !important;
-}
-
-.CodeMirror-gutter-background {
-  position: absolute;
-  top: 0;
-  bottom: 0;
-  z-index: 4;
-}
-
-.CodeMirror-gutter-elt {
-  position: absolute;
-  cursor: default;
-  z-index: 4;
-}
-
-.CodeMirror-gutter-wrapper ::selection {
-  background-color: transparent;
-}
-
-.CodeMirror-gutter-wrapper ::-moz-selection {
-  background-color: transparent;
-}
-
-.CodeMirror-lines {
-  cursor: text;
-  min-height: 1px; /* prevents collapsing before first draw */
-}
-
-.CodeMirror pre.CodeMirror-line,
-.CodeMirror pre.CodeMirror-line-like {
-  /* Reset some styles that the rest of the page might have set */
-  /* stylelint-disable-next-line property-no-vendor-prefix */
-  -moz-border-radius: 0;
-  /* stylelint-disable-next-line property-no-vendor-prefix */
-  -webkit-border-radius: 0;
-  border-radius: 0;
-  border-width: 0;
-  background: transparent;
-  font-family: inherit;
-  font-size: inherit;
-  margin: 0;
-  white-space: pre;
-  word-wrap: normal;
-  line-height: inherit;
-  color: inherit;
-  z-index: 2;
-  position: relative;
-  overflow: visible;
-  -webkit-tap-highlight-color: transparent;
-  /* stylelint-disable-next-line property-no-vendor-prefix */
-  -webkit-font-variant-ligatures: contextual;
-  font-variant-ligatures: contextual;
-}
-
-.CodeMirror-wrap pre.CodeMirror-line,
-.CodeMirror-wrap pre.CodeMirror-line-like {
-  word-wrap: break-word;
-  white-space: pre-wrap;
-  word-break: normal;
-}
-
-.CodeMirror-linebackground {
-  position: absolute;
-  left: 0;
-  right: 0;
-  top: 0;
-  bottom: 0;
-  z-index: 0;
-}
-
-.CodeMirror-linewidget {
-  position: relative;
-  z-index: 2;
-  padding: 0.1px; /* Force widget margins to stay inside of the container */
-}
-
-.CodeMirror-rtl pre {
-  direction: rtl;
-}
-
-.CodeMirror-code {
-  outline: none;
-}
-
-/* Force content-box sizing for the elements where we expect it */
-.CodeMirror-scroll,
-.CodeMirror-sizer,
-.CodeMirror-gutter,
-.CodeMirror-gutters,
-.CodeMirror-linenumber {
-  /* stylelint-disable-next-line property-no-vendor-prefix */
-  -moz-box-sizing: content-box;
-  box-sizing: content-box;
-}
-
-.CodeMirror-measure {
-  position: absolute;
-  width: 100%;
-  height: 0;
-  overflow: hidden;
-  visibility: hidden;
-}
-
-.CodeMirror-cursor {
-  position: absolute;
-  pointer-events: none;
-}
-
-.CodeMirror-measure pre {
-  position: static;
-}
-
-div.CodeMirror-cursors {
-  visibility: hidden;
-  position: relative;
-  z-index: 3;
-}
-
-div.CodeMirror-dragcursors {
-  visibility: visible;
-}
-
-.CodeMirror-focused div.CodeMirror-cursors {
-  visibility: visible;
-}
-
-.CodeMirror-selected {
-  --override-cm-selected-background-color: #d9d9d9;
-
-  background: var(--override-cm-selected-background-color);
-}
-
-.-theme-with-dark-background .CodeMirror-selected,
-:host-context(.-theme-with-dark-background) .CodeMirror-selected {
-  --override-cm-selected-background-color: rgb(38 38 38);
-}
-
-.CodeMirror-focused .CodeMirror-selected {
-  --override-cm-selected-background-color: #d7d4f0;
-}
-
-.-theme-with-dark-background .CodeMirror-focused .CodeMirror-selected,
-:host-context(.-theme-with-dark-background) .CodeMirror-focused .CodeMirror-selected {
-  --override-cm-selected-background-color: rgb(18 15 43);
-}
-
-.CodeMirror-crosshair {
-  cursor: crosshair;
-}
-
-.CodeMirror-line {
-  --override-line-selection-background-color: #d7d4f0;
-}
-
-.CodeMirror-line::selection,
-.CodeMirror-line > span::selection,
-.CodeMirror-line > span > span::selection {
-  background:var(--override-line-selection-background-color);
-}
-
-.CodeMirror-line::-moz-selection,
-.CodeMirror-line > span::-moz-selection,
-.CodeMirror-line > span > span::-moz-selection {
-  background: var(--override-line-selection-background-color);
-}
-
-.-theme-with-dark-background .CodeMirror-line,
-:host-context(.-theme-with-dark-background) .CodeMirror-line {
-  --override-line-selection-background-color: rgb(18 15 43);
-
-}
-
-.cm-searching {
-  --override-searching-background-color: rgb(255 255 0 / 40%);
-
-  background-color: var(--override-searching-background-color);
-}
-
-/* Used to force a border model for a node */
-.cm-force-border {
-  padding-right: 0.1px;
-}
-
-@media print {
-  /* Hide the cursor when printing */
-  .CodeMirror div.CodeMirror-cursors {
-    visibility: hidden;
-  }
-}
-
-/* See issue #2901 */
-.cm-tab-wrap-hack::after {
-  content: "";
-}
-
-/* Help users use markselection to safely style text background */
-span.CodeMirror-selectedtext {
-  background: none;
-}

package/front_end/third_party/codemirror/codemirror.ts

@@ -1,19 +0,0 @@
-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import type * as CodeMirrorLegacy from './codemirror-legacy';
-export {CodeMirrorLegacy};
-
-import './package/lib/codemirror.js';
-import './package/addon/comment/comment.js';
-import './package/addon/edit/closebrackets.js';
-import './package/addon/edit/matchbrackets.js';
-import './package/addon/mode/multiplex.js';
-import './package/addon/mode/overlay.js';
-import './package/addon/mode/simple.js';
-import './package/addon/selection/active-line.js';
-import './package/addon/selection/mark-selection.js';
-import './package/addon/fold/foldcode.js';
-import './package/addon/fold/foldgutter.js';
-import './package/addon/fold/brace-fold.js';