chrome-devtools-frontend 1.0.951864 → 1.0.952784

package/front_end/ui/components/diff_view/DiffView.ts

@@ -189,14 +189,14 @@ class DiffRenderer {
   ) {
   }
 
-  private render(rows: readonly Row[]): LitHtml.TemplateResult {
+  #render(rows: readonly Row[]): LitHtml.TemplateResult {
     return LitHtml.html`
       <div class="diff-listing" aria-label=${i18nString(UIStrings.changesDiffViewer)}>
-        ${rows.map(row => this.renderRow(row))}
+        ${rows.map(row => this.#renderRow(row))}
       </div>`;
   }
 
-  private renderRow(row: Row): LitHtml.TemplateResult {
+  #renderRow(row: Row): LitHtml.TemplateResult {
     const baseNumber =
         row.type === RowType.Equal || row.type === RowType.Deletion ? String(row.originalLineNumber) : '';
     const curNumber = row.type === RowType.Equal || row.type === RowType.Addition ? String(row.currentLineNumber) : '';
@@ -215,10 +215,10 @@ class DiffRenderer {
       <div class="diff-line-number" aria-hidden="true">${curNumber}</div>
       <div class=${markerClass} aria-hidden="true">${marker}</div>
       <div class="diff-line-content diff-line-${row.type}" data-line-number=${curNumber}>${screenReaderText}${
-        this.renderRowContent(row)}</div>`;
+        this.#renderRowContent(row)}</div>`;
   }
 
-  private renderRowContent(row: Row): LitHtml.TemplateResult[] {
+  #renderRowContent(row: Row): LitHtml.TemplateResult[] {
     if (row.type === RowType.Spacer) {
       return row.tokens.map(tok => LitHtml.html`${tok.text}`);
     }
@@ -249,7 +249,7 @@ class DiffRenderer {
         await CodeHighlighter.CodeHighlighter.create(currentLines.join('\n'), mimeType),
         documentMap(currentLines),
     );
-    LitHtml.render(renderer.render(rows), parent, {host: this});
+    LitHtml.render(renderer.#render(rows), parent, {host: this});
   }
 }
 

package/front_end/ui/components/expandable_list/ExpandableList.ts

@@ -19,19 +19,19 @@ export class ExpandableList extends HTMLElement {
 
   set data(data: ExpandableListData) {
     this.#rows = data.rows;
-    this.render();
+    this.#render();
   }
 
-  private onArrowClick(): void {
+  #onArrowClick(): void {
     this.#expanded = !this.#expanded;
-    this.render();
+    this.#render();
   }
 
   connectedCallback(): void {
     this.#shadow.adoptedStyleSheets = [expandableListStyles];
   }
 
-  private render(): void {
+  #render(): void {
     if (this.#rows.length < 1) {
       return;
     }
@@ -44,7 +44,7 @@ export class ExpandableList extends HTMLElement {
         <div>
           ${this.#rows.length > 1 ?
             LitHtml.html`
-              <button @click=${(): void => this.onArrowClick()} class="arrow-icon-button">
+              <button @click=${(): void => this.#onArrowClick()} class="arrow-icon-button">
                 <span class="arrow-icon ${this.#expanded ? 'expanded' : ''}"></span>
               </button>
             `

package/front_end/ui/components/icon_button/Icon.ts

@@ -52,7 +52,7 @@ export class Icon extends HTMLElement {
       this.#iconPath = new URL(`../../../Images/${data.iconName}.svg`, import.meta.url).toString();
       this.#iconName = data.iconName;
     }
-    this.render();
+    this.#render();
   }
 
   get data(): IconData {
@@ -73,7 +73,7 @@ export class Icon extends HTMLElement {
     };
   }
 
-  private getStyles(): {[key: string]: string} {
+  #getStyles(): {[key: string]: string} {
     const iconPath = this.#iconPath;
     const width = this.#width;
     const height = this.#height;
@@ -104,11 +104,11 @@ export class Icon extends HTMLElement {
     };
   }
 
-  private render(): void {
+  #render(): void {
     coordinator.write(() => {
       // clang-format off
       LitHtml.render(LitHtml.html`
-        <div class="icon-basic" style=${LitHtml.Directives.styleMap(this.getStyles())}></div>
+        <div class="icon-basic" style=${LitHtml.Directives.styleMap(this.#getStyles())}></div>
       `, this.#shadow, {host: this});
       // clang-format on
     });

package/front_end/ui/components/icon_button/IconButton.ts

@@ -44,7 +44,7 @@ export class IconButton extends HTMLElement {
     this.#leadingText = data.leadingText ?? '';
     this.#accessibleName = data.accessibleName;
     this.#compact = Boolean(data.compact);
-    this.render();
+    this.#render();
   }
 
   get data(): IconButtonData {
@@ -62,14 +62,14 @@ export class IconButton extends HTMLElement {
     this.#shadow.adoptedStyleSheets = [iconButtonStyles];
   }
 
-  private onClickHandler(event: Event): void {
+  #onClickHandler(event: Event): void {
     if (this.#clickHandler) {
       event.preventDefault();
       this.#clickHandler();
     }
   }
 
-  private render(): void {
+  #render(): void {
     const buttonClasses = LitHtml.Directives.classMap({
       'icon-button': true,
       'with-click-handler': Boolean(this.#clickHandler),
@@ -80,7 +80,7 @@ export class IconButton extends HTMLElement {
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     LitHtml.render(LitHtml.html`
-      <button class=${buttonClasses} @click=${this.onClickHandler} aria-label=${LitHtml.Directives.ifDefined(this.#accessibleName)}>
+      <button class=${buttonClasses} @click=${this.#onClickHandler} aria-label=${LitHtml.Directives.ifDefined(this.#accessibleName)}>
       ${(!this.#compact && this.#leadingText) ? LitHtml.html`<span class="icon-button-title">${this.#leadingText}</span>` : LitHtml.nothing}
       ${filteredGroups.map(counter =>
       LitHtml.html`

package/front_end/ui/components/issue_counter/IssueCounter.ts

@@ -97,9 +97,9 @@ export class IssueCounter extends HTMLElement {
 
   scheduleUpdate(): void {
     if (this.#throttler) {
-      this.#throttler.schedule(async () => this.render());
+      this.#throttler.schedule(async () => this.#render());
     } else {
-      this.render();
+      this.#render();
     }
   }
 
@@ -143,7 +143,7 @@ export class IssueCounter extends HTMLElement {
     };
   }
 
-  private render(): void {
+  #render(): void {
     if (!this.#issuesManager) {
       return;
     }

package/front_end/ui/components/issue_counter/IssueLinkIcon.ts

@@ -75,15 +75,15 @@ export class IssueLinkIcon extends HTMLElement {
       this.#reveal = data.revealOverride;
     }
     if (!this.#issue && this.#issueId) {
-      this.#issueResolvedPromise = this.resolveIssue(this.#issueId);
-      this.#issueTitlePromise = this.#issueResolvedPromise.then(() => this.fetchIssueTitle());
+      this.#issueResolvedPromise = this.#resolveIssue(this.#issueId);
+      this.#issueTitlePromise = this.#issueResolvedPromise.then(() => this.#fetchIssueTitle());
     } else {
-      this.#issueTitlePromise = this.fetchIssueTitle();
+      this.#issueTitlePromise = this.#fetchIssueTitle();
     }
-    this.render();
+    this.#render();
   }
 
-  private async fetchIssueTitle(): Promise<void> {
+  async #fetchIssueTitle(): Promise<void> {
     const description = this.#issue?.getDescription();
     if (!description) {
       return;
@@ -98,7 +98,7 @@ export class IssueLinkIcon extends HTMLElement {
     this.#shadow.adoptedStyleSheets = [IssueLinkIconStyles];
   }
 
-  private resolveIssue(issueId: Protocol.Audits.IssueId): Promise<void> {
+  #resolveIssue(issueId: Protocol.Audits.IssueId): Promise<void> {
     if (!this.#issueResolver) {
       throw new Error('An `IssueResolver` must be provided if an `issueId` is provided.');
     }
@@ -138,7 +138,7 @@ export class IssueLinkIcon extends HTMLElement {
     this.#additionalOnClickAction?.();
   }
 
-  private getTooltip(): Platform.UIString.LocalizedString {
+  #getTooltip(): Platform.UIString.LocalizedString {
     if (this.#issueTitle) {
       return i18nString(UIStrings.clickToShowIssueWithTitle, {title: this.#issueTitle});
     }
@@ -148,25 +148,25 @@ export class IssueLinkIcon extends HTMLElement {
     return i18nString(UIStrings.issueUnavailable);
   }
 
-  private render(): Promise<void> {
+  #render(): Promise<void> {
     return coordinator.write(() => {
       // clang-format off
       LitHtml.render(LitHtml.html`
-        ${LitHtml.Directives.until(this.#issueTitlePromise.then(() => this.renderComponent()), this.#issueResolvedPromise.then(() => this.renderComponent()), this.renderComponent())}
+        ${LitHtml.Directives.until(this.#issueTitlePromise.then(() => this.#renderComponent()), this.#issueResolvedPromise.then(() => this.#renderComponent()), this.#renderComponent())}
       `,
       this.#shadow, {host: this});
       // clang-format on
     });
   }
 
-  private renderComponent(): LitHtml.TemplateResult {
+  #renderComponent(): LitHtml.TemplateResult {
     // clang-format off
     return LitHtml.html`
       <span class=${LitHtml.Directives.classMap({'link': Boolean(this.#issue)})}
             tabindex="0"
             @click=${this.handleClick}>
         <${IconButton.Icon.Icon.litTagName} .data=${this.iconData() as IconButton.Icon.IconData}
-          title=${this.getTooltip()}></${IconButton.Icon.Icon.litTagName}>
+          title=${this.#getTooltip()}></${IconButton.Icon.Icon.litTagName}>
       </span>`;
     // clang-format on
   }

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspector.ts

@@ -141,16 +141,16 @@ export class LinearMemoryInspector extends HTMLElement {
     this.#valueTypeModes = data.valueTypeModes || this.#valueTypeModes;
     this.#valueTypes = data.valueTypes || this.#valueTypes;
     this.#endianness = data.endianness || this.#endianness;
-    this.setAddress(data.address);
-    this.render();
+    this.#setAddress(data.address);
+    this.#render();
   }
 
-  private render(): void {
-    const {start, end} = this.getPageRangeForAddress(this.#address, this.#numBytesPerPage);
+  #render(): void {
+    const {start, end} = this.#getPageRangeForAddress(this.#address, this.#numBytesPerPage);
 
     const navigatorAddressToShow = this.#currentNavigatorMode === Mode.Submitted ? formatAddress(this.#address) :
                                                                                    this.#currentNavigatorAddressLine;
-    const navigatorAddressIsValid = this.isValidAddress(navigatorAddressToShow);
+    const navigatorAddressIsValid = this.#isValidAddress(navigatorAddressToShow);
 
     const invalidAddressMsg = i18nString(
         UIStrings.addressHasToBeANumberBetweenSAnd,
@@ -166,14 +166,14 @@ export class LinearMemoryInspector extends HTMLElement {
       <div class="view">
         <${LinearMemoryNavigator.litTagName}
           .data=${{address: navigatorAddressToShow, valid: navigatorAddressIsValid, mode: this.#currentNavigatorMode, error: errorMsg, canGoBackInHistory, canGoForwardInHistory} as LinearMemoryNavigatorData}
-          @refreshrequested=${this.onRefreshRequest}
-          @addressinputchanged=${this.onAddressChange}
-          @pagenavigation=${this.navigatePage}
-          @historynavigation=${this.navigateHistory}></${LinearMemoryNavigator.litTagName}>
+          @refreshrequested=${this.#onRefreshRequest}
+          @addressinputchanged=${this.#onAddressChange}
+          @pagenavigation=${this.#navigatePage}
+          @historynavigation=${this.#navigateHistory}></${LinearMemoryNavigator.litTagName}>
         <${LinearMemoryViewer.litTagName}
           .data=${{memory: this.#memory.slice(start - this.#memoryOffset, end - this.#memoryOffset), address: this.#address, memoryOffset: start, focus: this.#currentNavigatorMode === Mode.Submitted} as LinearMemoryViewerData}
-          @byteselected=${this.onByteSelected}
-          @resize=${this.resize}>
+          @byteselected=${this.#onByteSelected}
+          @resize=${this.#resize}>
         </${LinearMemoryViewer.litTagName}>
       </div>
       <div class="value-interpreter">
@@ -184,10 +184,10 @@ export class LinearMemoryInspector extends HTMLElement {
             valueTypeModes: this.#valueTypeModes,
             endianness: this.#endianness,
             memoryLength: this.#outerMemoryLength } as LinearMemoryValueInterpreterData}
-          @valuetypetoggled=${this.onValueTypeToggled}
-          @valuetypemodechanged=${this.onValueTypeModeChanged}
-          @endiannesschanged=${this.onEndiannessChanged}
-          @jumptopointeraddress=${this.onJumpToPointerAddress}
+          @valuetypetoggled=${this.#onValueTypeToggled}
+          @valuetypemodechanged=${this.#onValueTypeModeChanged}
+          @endiannesschanged=${this.#onEndiannessChanged}
+          @jumptopointeraddress=${this.#onJumpToPointerAddress}
           >
         </${LinearMemoryValueInterpreter.litTagName}/>
       </div>
@@ -197,49 +197,49 @@ export class LinearMemoryInspector extends HTMLElement {
     // clang-format on
   }
 
-  private onJumpToPointerAddress(e: JumpToPointerAddressEvent): void {
+  #onJumpToPointerAddress(e: JumpToPointerAddressEvent): void {
     // Stop event from bubbling up, since no element further up needs the event.
     e.stopPropagation();
     this.#currentNavigatorMode = Mode.Submitted;
     const addressInRange = Math.max(0, Math.min(e.data, this.#outerMemoryLength - 1));
-    this.jumpToAddress(addressInRange);
+    this.#jumpToAddress(addressInRange);
   }
 
-  private onRefreshRequest(): void {
-    const {start, end} = this.getPageRangeForAddress(this.#address, this.#numBytesPerPage);
+  #onRefreshRequest(): void {
+    const {start, end} = this.#getPageRangeForAddress(this.#address, this.#numBytesPerPage);
     this.dispatchEvent(new MemoryRequestEvent(start, end, this.#address));
   }
 
-  private onByteSelected(e: ByteSelectedEvent): void {
+  #onByteSelected(e: ByteSelectedEvent): void {
     this.#currentNavigatorMode = Mode.Submitted;
     const addressInRange = Math.max(0, Math.min(e.data, this.#outerMemoryLength - 1));
-    this.jumpToAddress(addressInRange);
+    this.#jumpToAddress(addressInRange);
   }
 
-  private createSettings(): Settings {
+  #createSettings(): Settings {
     return {valueTypes: this.#valueTypes, modes: this.#valueTypeModes, endianness: this.#endianness};
   }
 
-  private onEndiannessChanged(e: EndiannessChangedEvent): void {
+  #onEndiannessChanged(e: EndiannessChangedEvent): void {
     this.#endianness = e.data;
-    this.dispatchEvent(new SettingsChangedEvent(this.createSettings()));
-    this.render();
+    this.dispatchEvent(new SettingsChangedEvent(this.#createSettings()));
+    this.#render();
   }
 
-  private isValidAddress(address: string): boolean {
+  #isValidAddress(address: string): boolean {
     const newAddress = parseAddress(address);
     return newAddress !== undefined && newAddress >= 0 && newAddress < this.#outerMemoryLength;
   }
 
-  private onAddressChange(e: AddressInputChangedEvent): void {
+  #onAddressChange(e: AddressInputChangedEvent): void {
     const {address, mode} = e.data;
-    const isValid = this.isValidAddress(address);
+    const isValid = this.#isValidAddress(address);
     const newAddress = parseAddress(address);
     this.#currentNavigatorAddressLine = address;
 
     if (newAddress !== undefined && isValid) {
       this.#currentNavigatorMode = mode;
-      this.jumpToAddress(newAddress);
+      this.#jumpToAddress(newAddress);
       return;
     }
 
@@ -249,75 +249,75 @@ export class LinearMemoryInspector extends HTMLElement {
       this.#currentNavigatorMode = Mode.Edit;
     }
 
-    this.render();
+    this.#render();
   }
 
-  private onValueTypeToggled(e: ValueTypeToggledEvent): void {
+  #onValueTypeToggled(e: ValueTypeToggledEvent): void {
     const {type, checked} = e.data;
     if (checked) {
       this.#valueTypes.add(type);
     } else {
       this.#valueTypes.delete(type);
     }
-    this.dispatchEvent(new SettingsChangedEvent(this.createSettings()));
-    this.render();
+    this.dispatchEvent(new SettingsChangedEvent(this.#createSettings()));
+    this.#render();
   }
 
-  private onValueTypeModeChanged(e: ValueTypeModeChangedEvent): void {
+  #onValueTypeModeChanged(e: ValueTypeModeChangedEvent): void {
     e.stopImmediatePropagation();
     const {type, mode} = e.data;
     this.#valueTypeModes.set(type, mode);
-    this.dispatchEvent(new SettingsChangedEvent(this.createSettings()));
-    this.render();
+    this.dispatchEvent(new SettingsChangedEvent(this.#createSettings()));
+    this.#render();
   }
 
-  private navigateHistory(e: HistoryNavigationEvent): boolean {
+  #navigateHistory(e: HistoryNavigationEvent): boolean {
     return e.data === Navigation.Forward ? this.#history.rollover() : this.#history.rollback();
   }
 
-  private navigatePage(e: PageNavigationEvent): void {
+  #navigatePage(e: PageNavigationEvent): void {
     const newAddress =
         e.data === Navigation.Forward ? this.#address + this.#numBytesPerPage : this.#address - this.#numBytesPerPage;
     const addressInRange = Math.max(0, Math.min(newAddress, this.#outerMemoryLength - 1));
-    this.jumpToAddress(addressInRange);
+    this.#jumpToAddress(addressInRange);
   }
 
-  private jumpToAddress(address: number): void {
+  #jumpToAddress(address: number): void {
     if (address < 0 || address >= this.#outerMemoryLength) {
       console.warn(`Specified address is out of bounds: ${address}`);
       return;
     }
-    this.setAddress(address);
-    this.update();
+    this.#setAddress(address);
+    this.#update();
   }
 
-  private getPageRangeForAddress(address: number, numBytesPerPage: number): {start: number, end: number} {
+  #getPageRangeForAddress(address: number, numBytesPerPage: number): {start: number, end: number} {
     const pageNumber = Math.floor(address / numBytesPerPage);
     const pageStartAddress = pageNumber * numBytesPerPage;
     const pageEndAddress = Math.min(pageStartAddress + numBytesPerPage, this.#outerMemoryLength);
     return {start: pageStartAddress, end: pageEndAddress};
   }
 
-  private resize(event: ResizeEvent): void {
+  #resize(event: ResizeEvent): void {
     this.#numBytesPerPage = event.data;
-    this.update();
+    this.#update();
   }
 
-  private update(): void {
-    const {start, end} = this.getPageRangeForAddress(this.#address, this.#numBytesPerPage);
+  #update(): void {
+    const {start, end} = this.#getPageRangeForAddress(this.#address, this.#numBytesPerPage);
     if (start < this.#memoryOffset || end > this.#memoryOffset + this.#memory.length) {
       this.dispatchEvent(new MemoryRequestEvent(start, end, this.#address));
     } else {
-      this.render();
+      this.#render();
     }
   }
 
-  private setAddress(address: number): void {
+  #setAddress(address: number): void {
     // If we are already showing the address that is requested, no need to act upon it.
     if (this.#address === address) {
       return;
     }
-    const historyEntry = new AddressHistoryEntry(address, () => this.jumpToAddress(address));
+    const historyEntry = new AddressHistoryEntry(address, () => this.#jumpToAddress(address));
     this.#history.push(historyEntry);
     this.#address = address;
     this.dispatchEvent(new AddressChangedEvent(this.#address));

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorController.ts

@@ -81,11 +81,11 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
     super();
     SDK.TargetManager.TargetManager.instance().observeModels(SDK.RuntimeModel.RuntimeModel, this);
     SDK.TargetManager.TargetManager.instance().addModelListener(
-        SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this.onGlobalObjectClear, this);
-    this.#paneInstance.addEventListener(LmiEvents.ViewClosed, this.viewClosed.bind(this));
+        SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this.#onGlobalObjectClear, this);
+    this.#paneInstance.addEventListener(LmiEvents.ViewClosed, this.#viewClosed.bind(this));
 
     SDK.TargetManager.TargetManager.instance().addModelListener(
-        SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this.onDebuggerPause, this);
+        SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this.#onDebuggerPause, this);
 
     const defaultValueTypeModes = getDefaultValueTypeMapping();
     const defaultSettings: SerializableSettings = {
@@ -189,7 +189,7 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
     }
   }
 
-  private onDebuggerPause(event: Common.EventTarget.EventTargetEvent<SDK.DebuggerModel.DebuggerModel>): void {
+  #onDebuggerPause(event: Common.EventTarget.EventTargetEvent<SDK.DebuggerModel.DebuggerModel>): void {
     const debuggerModel = event.data;
     for (const [bufferId, remoteObject] of this.#bufferIdToRemoteObject) {
       if (debuggerModel.runtimeModel() === remoteObject.runtimeModel()) {
@@ -198,11 +198,11 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
     }
   }
 
-  private onGlobalObjectClear(event: Common.EventTarget.EventTargetEvent<SDK.DebuggerModel.DebuggerModel>): void {
+  #onGlobalObjectClear(event: Common.EventTarget.EventTargetEvent<SDK.DebuggerModel.DebuggerModel>): void {
     this.modelRemoved(event.data.runtimeModel());
   }
 
-  private viewClosed({data: bufferId}: Common.EventTarget.EventTargetEvent<string>): void {
+  #viewClosed({data: bufferId}: Common.EventTarget.EventTargetEvent<string>): void {
     const remoteObj = this.#bufferIdToRemoteObject.get(bufferId);
     if (remoteObj) {
       remoteObj.release();

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorPane.ts

@@ -61,7 +61,7 @@ export class LinearMemoryInspectorPaneImpl extends Common.ObjectWrapper.eventMix
     this.#tabbedPane.setPlaceholderElement(placeholder);
     this.#tabbedPane.setCloseableTabs(true);
     this.#tabbedPane.setAllowTabReorder(true, true);
-    this.#tabbedPane.addEventListener(UI.TabbedPane.Events.TabClosed, this.tabClosed, this);
+    this.#tabbedPane.addEventListener(UI.TabbedPane.Events.TabClosed, this.#tabClosed, this);
     this.#tabbedPane.show(this.contentElement);
 
     this.#tabIdToInspectorView = new Map();
@@ -106,7 +106,7 @@ export class LinearMemoryInspectorPaneImpl extends Common.ObjectWrapper.eventMix
     view.refreshData();
   }
 
-  private tabClosed(event: Common.EventTarget.EventTargetEvent<UI.TabbedPane.EventData>): void {
+  #tabClosed(event: Common.EventTarget.EventTargetEvent<UI.TabbedPane.EventData>): void {
     const {tabId} = event.data;
     this.#tabIdToInspectorView.delete(tabId);
     this.dispatchEventToListeners(Events.ViewClosed, tabId);
@@ -137,7 +137,7 @@ class LinearMemoryInspectorView extends UI.Widget.VBox {
     this.#address = address;
     this.#inspector = new LinearMemoryInspector();
     this.#inspector.addEventListener('memoryrequest', (event: MemoryRequestEvent) => {
-      this.memoryRequested(event);
+      this.#memoryRequested(event);
     });
     this.#inspector.addEventListener('addresschanged', (event: AddressChangedEvent) => {
       this.updateAddress(event.data);
@@ -190,7 +190,7 @@ class LinearMemoryInspectorView extends UI.Widget.VBox {
     });
   }
 
-  private memoryRequested(event: MemoryRequestEvent): void {
+  #memoryRequested(event: MemoryRequestEvent): void {
     const {start, end, address} = event.data;
     if (address < start || address >= end) {
       throw new Error('Requested address is out of bounds.');

package/front_end/ui/components/linear_memory_inspector/LinearMemoryNavigator.ts

@@ -115,7 +115,7 @@ export class LinearMemoryNavigator extends HTMLElement {
     this.#valid = data.valid;
     this.#canGoBackInHistory = data.canGoBackInHistory;
     this.#canGoForwardInHistory = data.canGoForwardInHistory;
-    this.render();
+    this.#render();
 
     const addressInput = this.#shadow.querySelector<HTMLInputElement>('.address-input');
     if (addressInput) {
@@ -127,25 +127,25 @@ export class LinearMemoryNavigator extends HTMLElement {
     }
   }
 
-  private render(): void {
+  #render(): void {
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     const result = html`
       <div class="navigator">
         <div class="navigator-item">
-          ${this.createButton({icon: 'ic_undo_16x16_icon', title: i18nString(UIStrings.goBackInAddressHistory),
+          ${this.#createButton({icon: 'ic_undo_16x16_icon', title: i18nString(UIStrings.goBackInAddressHistory),
               event: new HistoryNavigationEvent(Navigation.Backward), enabled: this.#canGoBackInHistory})}
-          ${this.createButton({icon: 'ic_redo_16x16_icon', title: i18nString(UIStrings.goForwardInAddressHistory),
+          ${this.#createButton({icon: 'ic_redo_16x16_icon', title: i18nString(UIStrings.goForwardInAddressHistory),
               event: new HistoryNavigationEvent(Navigation.Forward), enabled: this.#canGoForwardInHistory})}
         </div>
         <div class="navigator-item">
-          ${this.createButton({icon: 'ic_page_prev_16x16_icon', title: i18nString(UIStrings.previousPage),
+          ${this.#createButton({icon: 'ic_page_prev_16x16_icon', title: i18nString(UIStrings.previousPage),
               event: new PageNavigationEvent(Navigation.Backward), enabled: true})}
-          ${this.createAddressInput()}
-          ${this.createButton({icon: 'ic_page_next_16x16_icon', title: i18nString(UIStrings.nextPage),
+          ${this.#createAddressInput()}
+          ${this.#createButton({icon: 'ic_page_next_16x16_icon', title: i18nString(UIStrings.nextPage),
               event: new PageNavigationEvent(Navigation.Forward), enabled: true})}
         </div>
-        ${this.createButton({icon: 'refresh_12x12_icon', title: i18nString(UIStrings.refresh),
+        ${this.#createButton({icon: 'refresh_12x12_icon', title: i18nString(UIStrings.refresh),
             event: new RefreshRequestedEvent(), enabled: true})}
       </div>
       `;
@@ -153,7 +153,7 @@ export class LinearMemoryNavigator extends HTMLElement {
     // clang-format on
   }
 
-  private createAddressInput(): LitHtml.TemplateResult {
+  #createAddressInput(): LitHtml.TemplateResult {
     const classMap = {
       'address-input': true,
       invalid: !this.#valid,
@@ -161,15 +161,15 @@ export class LinearMemoryNavigator extends HTMLElement {
     return html`
       <input class=${LitHtml.Directives.classMap(classMap)} data-input="true" .value=${this.#address}
         title=${this.#valid ? i18nString(UIStrings.enterAddress) : this.#error} @change=${
-        this.onAddressChange.bind(this, Mode.Submitted)} @input=${this.onAddressChange.bind(this, Mode.Edit)}/>`;
+        this.#onAddressChange.bind(this, Mode.Submitted)} @input=${this.#onAddressChange.bind(this, Mode.Edit)}/>`;
   }
 
-  private onAddressChange(mode: Mode, event: Event): void {
+  #onAddressChange(mode: Mode, event: Event): void {
     const addressInput = event.target as HTMLInputElement;
     this.dispatchEvent(new AddressInputChangedEvent(addressInput.value, mode));
   }
 
-  private createButton(data: {icon: string, title: string, event: Event, enabled: boolean}): LitHtml.TemplateResult {
+  #createButton(data: {icon: string, title: string, event: Event, enabled: boolean}): LitHtml.TemplateResult {
     const iconColor = data.enabled ? 'var(--color-text-secondary)' : 'var(--color-background-highlight)';
     return html`
       <button class="navigator-button" ?disabled=${!data.enabled}

package/front_end/ui/components/linear_memory_inspector/LinearMemoryValueInterpreter.ts

@@ -83,17 +83,17 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
     this.#valueTypes = data.valueTypes;
     this.#valueTypeModeConfig = data.valueTypeModes || new Map();
     this.#memoryLength = data.memoryLength;
-    this.render();
+    this.#render();
   }
 
-  private render(): void {
+  #render(): void {
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     render(html`
       <div class="value-interpreter">
         <div class="settings-toolbar">
-          ${this.renderEndiannessSetting()}
-          <button data-settings="true" class="settings-toolbar-button ${this.#showSettings ? 'active' : ''}" title=${i18nString(UIStrings.toggleValueTypeSettings)} @click=${this.onSettingsToggle}>
+          ${this.#renderEndiannessSetting()}
+          <button data-settings="true" class="settings-toolbar-button ${this.#showSettings ? 'active' : ''}" title=${i18nString(UIStrings.toggleValueTypeSettings)} @click=${this.#onSettingsToggle}>
             <${IconButton.Icon.Icon.litTagName}
               .data=${{ iconName: 'settings_14x14_icon', color: 'var(--color-text-secondary)', width: '14px' } as IconButton.Icon.IconWithName}>
             </${IconButton.Icon.Icon.litTagName}>
@@ -105,7 +105,7 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
             html`
               <${ValueInterpreterSettings.litTagName}
                 .data=${{ valueTypes: this.#valueTypes } as ValueInterpreterSettingsData}
-                @typetoggle=${this.onTypeToggle}>
+                @typetoggle=${this.#onTypeToggle}>
               </${ValueInterpreterSettings.litTagName}>` :
             html`
               <${ValueInterpreterDisplay.litTagName}
@@ -125,15 +125,15 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
     // clang-format on
   }
 
-  private onEndiannessChange(event: Event): void {
+  #onEndiannessChange(event: Event): void {
     event.preventDefault();
     const select = event.target as HTMLInputElement;
     const endianness = select.value as Endianness;
     this.dispatchEvent(new EndiannessChangedEvent(endianness));
   }
 
-  private renderEndiannessSetting(): LitHtml.TemplateResult {
-    const onEnumSettingChange = this.onEndiannessChange.bind(this);
+  #renderEndiannessSetting(): LitHtml.TemplateResult {
+    const onEnumSettingChange = this.#onEndiannessChange.bind(this);
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     return html`
@@ -151,12 +151,12 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
     // clang-format on
   }
 
-  private onSettingsToggle(): void {
+  #onSettingsToggle(): void {
     this.#showSettings = !this.#showSettings;
-    this.render();
+    this.#render();
   }
 
-  private onTypeToggle(e: TypeToggleEvent): void {
+  #onTypeToggle(e: TypeToggleEvent): void {
     this.dispatchEvent(new ValueTypeToggledEvent(e.data.type, e.data.checked));
   }
 }