chrome-devtools-frontend 1.0.950850 → 1.0.952284

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (379) hide show
  1. package/config/gni/devtools_grd_files.gni +3 -3
  2. package/extension-api/ExtensionAPI.d.ts +1 -1
  3. package/front_end/.eslintrc.js +6 -0
  4. package/front_end/Tests.js +10 -0
  5. package/front_end/core/common/App.ts +0 -3
  6. package/front_end/core/common/AppProvider.ts +0 -3
  7. package/front_end/core/common/JavaScriptMetaData.ts +0 -3
  8. package/front_end/core/common/QueryParamHandler.ts +0 -3
  9. package/front_end/core/common/Runnable.ts +0 -3
  10. package/front_end/core/common/SimpleHistoryManager.ts +0 -3
  11. package/front_end/core/i18n/locales/en-US.json +183 -183
  12. package/front_end/core/i18n/locales/en-XL.json +183 -183
  13. package/front_end/core/sdk/CSSRule.ts +1 -1
  14. package/front_end/core/sdk/DOMModel.ts +12 -37
  15. package/front_end/core/sdk/OverlayModel.ts +18 -34
  16. package/front_end/core/sdk/OverlayPersistentHighlighter.ts +0 -12
  17. package/front_end/core/sdk/RuntimeModel.ts +0 -1
  18. package/front_end/core/sdk/SourceMap.ts +1 -1
  19. package/front_end/core/sdk/TracingManager.ts +0 -3
  20. package/front_end/entrypoints/formatter_worker/AcornTokenizer.ts +36 -36
  21. package/front_end/entrypoints/formatter_worker/CSSFormatter.ts +53 -53
  22. package/front_end/entrypoints/formatter_worker/ESTreeWalker.ts +11 -11
  23. package/front_end/entrypoints/formatter_worker/FormattedContentBuilder.ts +43 -43
  24. package/front_end/entrypoints/formatter_worker/HTMLFormatter.ts +106 -105
  25. package/front_end/entrypoints/formatter_worker/JavaScriptFormatter.ts +26 -26
  26. package/front_end/entrypoints/heap_snapshot_worker/AllocationProfile.ts +51 -56
  27. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +201 -204
  28. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshotLoader.ts +84 -83
  29. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshotWorkerDispatcher.ts +16 -16
  30. package/front_end/entrypoints/inspector_main/InspectorMain.ts +21 -21
  31. package/front_end/entrypoints/main/ExecutionContextSelector.ts +30 -30
  32. package/front_end/entrypoints/main/MainImpl.ts +12 -12
  33. package/front_end/entrypoints/node_app/NodeConnectionsPanel.ts +33 -33
  34. package/front_end/entrypoints/node_app/NodeMain.ts +35 -35
  35. package/front_end/generated/InspectorBackendCommands.js +5 -1
  36. package/front_end/generated/protocol.d.ts +16 -0
  37. package/front_end/models/bindings/CSSWorkspaceBinding.ts +0 -3
  38. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +1 -2
  39. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +1 -4
  40. package/front_end/models/bindings/FileUtils.ts +0 -4
  41. package/front_end/models/bindings/IgnoreListManager.ts +1 -2
  42. package/front_end/models/bindings/NetworkProject.ts +1 -2
  43. package/front_end/models/extensions/ExtensionAPI.ts +2 -2
  44. package/front_end/models/extensions/ExtensionTraceProvider.ts +0 -3
  45. package/front_end/models/issues_manager/ContentSecurityPolicyIssue.ts +6 -6
  46. package/front_end/models/issues_manager/ContrastCheckTrigger.ts +15 -15
  47. package/front_end/models/issues_manager/CorsIssue.ts +9 -9
  48. package/front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.ts +5 -5
  49. package/front_end/models/issues_manager/DeprecationIssue.ts +7 -7
  50. package/front_end/models/issues_manager/GenericIssue.ts +5 -5
  51. package/front_end/models/issues_manager/HeavyAdIssue.ts +5 -5
  52. package/front_end/models/issues_manager/Issue.ts +10 -10
  53. package/front_end/models/issues_manager/IssueResolver.ts +11 -10
  54. package/front_end/models/issues_manager/IssuesManager.ts +56 -56
  55. package/front_end/models/issues_manager/LowTextContrastIssue.ts +4 -4
  56. package/front_end/models/issues_manager/MixedContentIssue.ts +7 -7
  57. package/front_end/models/issues_manager/NavigatorUserAgentIssue.ts +7 -7
  58. package/front_end/models/issues_manager/QuirksModeIssue.ts +4 -4
  59. package/front_end/models/issues_manager/SameSiteCookieIssue.ts +17 -18
  60. package/front_end/models/issues_manager/SharedArrayBufferIssue.ts +5 -5
  61. package/front_end/models/issues_manager/SourceFrameIssuesManager.ts +32 -31
  62. package/front_end/models/issues_manager/TrustedWebActivityIssue.ts +5 -5
  63. package/front_end/models/issues_manager/WasmCrossOriginModuleSharingIssue.ts +5 -5
  64. package/front_end/models/timeline_model/TimelineModel.ts +1 -1
  65. package/front_end/models/timeline_model/TracingLayerTree.ts +0 -1
  66. package/front_end/panels/accessibility/ARIAMetadata.ts +0 -1
  67. package/front_end/panels/accessibility/AXBreadcrumbsPane.ts +2 -2
  68. package/front_end/panels/accessibility/AccessibilityNodeView.ts +1 -2
  69. package/front_end/panels/animation/AnimationTimeline.ts +0 -1
  70. package/front_end/panels/application/ApplicationPanelCacheSection.ts +3 -4
  71. package/front_end/panels/application/ServiceWorkerUpdateCycleView.ts +0 -2
  72. package/front_end/panels/application/StorageView.ts +2 -6
  73. package/front_end/panels/application/{BackForwardCacheStrings.ts → components/BackForwardCacheStrings.ts} +2 -2
  74. package/front_end/panels/application/{BackForwardCacheView.ts → components/BackForwardCacheView.ts} +96 -62
  75. package/front_end/panels/application/components/EndpointsGrid.ts +12 -12
  76. package/front_end/panels/application/components/FrameDetailsView.ts +108 -110
  77. package/front_end/panels/application/components/OriginTrialTreeView.ts +45 -45
  78. package/front_end/panels/application/components/PermissionsPolicySection.ts +19 -19
  79. package/front_end/panels/application/components/ReportsGrid.ts +30 -30
  80. package/front_end/panels/application/components/StackTrace.ts +48 -47
  81. package/front_end/panels/application/components/TrustTokensView.ts +31 -31
  82. package/front_end/panels/application/{backForwardCacheView.css → components/backForwardCacheView.css} +9 -0
  83. package/front_end/panels/application/components/components.ts +2 -0
  84. package/front_end/panels/console/ConsoleViewMessage.ts +1 -25
  85. package/front_end/panels/console/consoleView.css +5 -0
  86. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +41 -52
  87. package/front_end/panels/css_overview/CSSOverviewController.ts +2 -2
  88. package/front_end/panels/css_overview/CSSOverviewPanel.ts +18 -27
  89. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  90. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +6 -6
  91. package/front_end/panels/css_overview/components/CSSOverviewStartView.ts +4 -4
  92. package/front_end/panels/elements/ComputedStyleModel.ts +2 -2
  93. package/front_end/panels/elements/ElementsPanel.ts +1 -5
  94. package/front_end/panels/elements/ElementsTreeElement.ts +2 -6
  95. package/front_end/panels/elements/ElementsTreeOutline.ts +2 -2
  96. package/front_end/panels/elements/StylesSidebarPane.ts +1 -1
  97. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +17 -17
  98. package/front_end/panels/elements/components/AdornerManager.ts +21 -21
  99. package/front_end/panels/elements/components/AdornerSettingsPane.ts +14 -14
  100. package/front_end/panels/elements/components/CSSQuery.ts +16 -16
  101. package/front_end/panels/elements/components/ComputedStyleProperty.ts +14 -14
  102. package/front_end/panels/elements/components/ComputedStyleTrace.ts +15 -15
  103. package/front_end/panels/elements/components/ElementsBreadcrumbs.ts +78 -78
  104. package/front_end/panels/elements/components/ElementsPanelLink.ts +16 -16
  105. package/front_end/panels/elements/components/LayoutPane.ts +47 -47
  106. package/front_end/panels/elements/components/NodeText.ts +18 -18
  107. package/front_end/panels/elements/components/QueryContainer.ts +40 -40
  108. package/front_end/panels/elements/components/StylePropertyEditor.ts +18 -18
  109. package/front_end/panels/emulation/components/DeviceSizeInputElement.ts +4 -4
  110. package/front_end/panels/event_listeners/EventListenersUtils.ts +2 -1
  111. package/front_end/panels/issues/AffectedBlockedByResponseView.ts +4 -4
  112. package/front_end/panels/issues/AffectedCookiesView.ts +4 -5
  113. package/front_end/panels/issues/AffectedDirectivesView.ts +19 -19
  114. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +7 -8
  115. package/front_end/panels/issues/AffectedElementsView.ts +4 -4
  116. package/front_end/panels/issues/AffectedElementsWithLowContrastView.ts +7 -8
  117. package/front_end/panels/issues/AffectedHeavyAdView.ts +8 -8
  118. package/front_end/panels/issues/AffectedResourcesView.ts +25 -26
  119. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +8 -8
  120. package/front_end/panels/issues/AffectedSourcesView.ts +4 -4
  121. package/front_end/panels/issues/AffectedTrustedWebActivityIssueDetailsView.ts +4 -4
  122. package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts +17 -17
  123. package/front_end/panels/issues/CSPViolationsListView.ts +22 -23
  124. package/front_end/panels/issues/CSPViolationsView.ts +17 -17
  125. package/front_end/panels/issues/ComboBoxOfCheckBoxes.ts +13 -13
  126. package/front_end/panels/issues/CorsIssueDetailsView.ts +23 -23
  127. package/front_end/panels/issues/GenericIssueDetailsView.ts +4 -4
  128. package/front_end/panels/issues/HiddenIssuesRow.ts +7 -7
  129. package/front_end/panels/issues/IssueAggregator.ts +95 -95
  130. package/front_end/panels/issues/IssueKindView.ts +14 -14
  131. package/front_end/panels/issues/IssueView.ts +98 -98
  132. package/front_end/panels/issues/IssuesPane.ts +102 -102
  133. package/front_end/panels/issues/WasmCrossOriginModuleSharingAffectedResourcesView.ts +5 -5
  134. package/front_end/panels/issues/components/HideIssuesMenu.ts +10 -10
  135. package/front_end/panels/layer_viewer/Layers3DView.ts +3 -9
  136. package/front_end/panels/lighthouse/LighthouseController.ts +4 -5
  137. package/front_end/panels/media/PlayerListView.ts +160 -97
  138. package/front_end/panels/media/PlayerMessagesView.ts +1 -0
  139. package/front_end/panels/media/TickingFlameChart.ts +1 -2
  140. package/front_end/panels/media/playerListView.css +58 -0
  141. package/front_end/panels/network/NetworkLogView.ts +2 -6
  142. package/front_end/panels/network/NetworkLogViewColumns.ts +1 -1
  143. package/front_end/panels/network/NetworkWaterfallColumn.ts +2 -4
  144. package/front_end/panels/network/components/RequestTrustTokensView.ts +40 -40
  145. package/front_end/panels/network/components/WebBundleInfoView.ts +9 -9
  146. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +6 -12
  147. package/front_end/panels/profiler/HeapProfileView.ts +1 -1
  148. package/front_end/panels/profiler/HeapSnapshotDataGrids.ts +0 -1
  149. package/front_end/panels/profiler/HeapSnapshotView.ts +1 -2
  150. package/front_end/panels/profiler/heapProfiler.css +1 -1
  151. package/front_end/panels/search/SearchConfig.ts +0 -6
  152. package/front_end/panels/security/SecurityModel.ts +2 -4
  153. package/front_end/panels/security/SecurityPanel.ts +2 -2
  154. package/front_end/panels/settings/KeybindsSettingsTab.ts +4 -0
  155. package/front_end/panels/settings/components/SyncSection.ts +14 -14
  156. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +96 -96
  157. package/front_end/panels/settings/settingsScreen.css +8 -3
  158. package/front_end/panels/sources/BreakpointEditDialog.ts +4 -3
  159. package/front_end/panels/sources/FilteredUISourceCodeListProvider.ts +2 -2
  160. package/front_end/panels/sources/NavigatorView.ts +4 -10
  161. package/front_end/panels/sources/ScopeChainSidebarPane.ts +2 -3
  162. package/front_end/panels/sources/SourceMapNamesResolver.ts +3 -3
  163. package/front_end/panels/sources/SourcesPanel.ts +1 -3
  164. package/front_end/panels/sources/SourcesView.ts +0 -3
  165. package/front_end/panels/sources/TabbedEditorContainer.ts +1 -4
  166. package/front_end/panels/timeline/TimelineFlameChartDataProvider.ts +2 -5
  167. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +0 -1
  168. package/front_end/panels/timeline/TimelineFlameChartView.ts +0 -1
  169. package/front_end/panels/timeline/TimelineLoader.ts +0 -3
  170. package/front_end/panels/timeline/TimelinePanel.ts +2 -3
  171. package/front_end/panels/timeline/TimelineUIUtils.ts +1 -1
  172. package/front_end/panels/timeline/components/WebVitalsLane.ts +77 -76
  173. package/front_end/panels/timeline/components/WebVitalsTimeline.ts +133 -133
  174. package/front_end/panels/timeline/components/WebVitalsTooltip.ts +9 -9
  175. package/front_end/panels/webauthn/WebauthnPane.ts +203 -205
  176. package/front_end/third_party/codemirror.next/bundle.ts +3 -3
  177. package/front_end/third_party/codemirror.next/chunk/codemirror.js +1 -1
  178. package/front_end/third_party/codemirror.next/chunk/markdown.js +2 -1
  179. package/front_end/third_party/codemirror.next/codemirror.next.d.ts +10 -1
  180. package/front_end/third_party/codemirror.next/codemirror.next.js +2 -1
  181. package/front_end/third_party/codemirror.next/package.json +3 -3
  182. package/front_end/third_party/puppeteer/package/README.md +11 -11
  183. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/api-docs-entry.d.ts +4 -5
  184. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/AriaQueryHandler.js +2 -2
  185. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/AriaQueryHandler.js.map +1 -1
  186. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Browser.d.ts +4 -6
  187. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/BrowserConnector.d.ts +1 -2
  188. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Connection.d.ts +1 -4
  189. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Coverage.d.ts +1 -4
  190. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/DOMWorld.d.ts +9 -7
  191. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/DOMWorld.d.ts.map +1 -1
  192. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/DOMWorld.js +21 -12
  193. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/DOMWorld.js.map +1 -1
  194. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Dialog.d.ts +1 -3
  195. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/EvalTypes.d.ts +1 -2
  196. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/ExecutionContext.d.ts +3 -5
  197. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/FileChooser.d.ts +1 -3
  198. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/FrameManager.d.ts +8 -10
  199. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/FrameManager.js +3 -3
  200. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/FrameManager.js.map +1 -1
  201. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPRequest.d.ts +50 -11
  202. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPRequest.d.ts.map +1 -1
  203. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPRequest.js +70 -33
  204. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPRequest.js.map +1 -1
  205. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPResponse.d.ts +12 -5
  206. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPResponse.d.ts.map +1 -1
  207. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPResponse.js +25 -5
  208. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/HTTPResponse.js.map +1 -1
  209. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Input.d.ts +2 -4
  210. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/JSHandle.d.ts +39 -6
  211. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/JSHandle.d.ts.map +1 -1
  212. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/JSHandle.js +36 -0
  213. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/JSHandle.js.map +1 -1
  214. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/LifecycleWatcher.d.ts +3 -4
  215. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/LifecycleWatcher.d.ts.map +1 -1
  216. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/LifecycleWatcher.js +2 -1
  217. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/LifecycleWatcher.js.map +1 -1
  218. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkEventManager.d.ts +46 -0
  219. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkEventManager.d.ts.map +1 -0
  220. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkEventManager.js +124 -0
  221. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkEventManager.js.map +1 -0
  222. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkManager.d.ts +27 -10
  223. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkManager.d.ts.map +1 -1
  224. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkManager.js +144 -74
  225. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/NetworkManager.js.map +1 -1
  226. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Puppeteer.d.ts +5 -6
  227. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/QueryHandler.d.ts +1 -2
  228. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/Target.d.ts +4 -6
  229. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/common/WebWorker.d.ts +3 -5
  230. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/BrowserRunner.d.ts +4 -5
  231. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/BrowserRunner.d.ts.map +1 -1
  232. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/BrowserRunner.js +43 -17
  233. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/BrowserRunner.js.map +1 -1
  234. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/LaunchOptions.d.ts +1 -1
  235. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/Launcher.d.ts +1 -3
  236. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/Launcher.d.ts.map +1 -1
  237. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/Launcher.js +101 -34
  238. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/Launcher.js.map +1 -1
  239. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/NodeWebSocketTransport.d.ts +1 -3
  240. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/PipeTransport.d.ts +1 -2
  241. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/Puppeteer.d.ts +5 -7
  242. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.js +1 -1
  243. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/api-docs-entry.d.ts +4 -5
  244. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/AriaQueryHandler.js +2 -2
  245. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/AriaQueryHandler.js.map +1 -1
  246. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Browser.d.ts +4 -6
  247. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Browser.js +2 -3
  248. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/BrowserConnector.d.ts +1 -2
  249. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/BrowserConnector.js +3 -5
  250. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Connection.d.ts +1 -4
  251. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Coverage.d.ts +1 -4
  252. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Coverage.js +1 -2
  253. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/DOMWorld.d.ts +9 -7
  254. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/DOMWorld.d.ts.map +1 -1
  255. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/DOMWorld.js +24 -17
  256. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/DOMWorld.js.map +1 -1
  257. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Dialog.d.ts +1 -3
  258. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/EvalTypes.d.ts +1 -2
  259. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/ExecutionContext.d.ts +3 -5
  260. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/FileChooser.d.ts +1 -3
  261. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/FrameManager.d.ts +8 -10
  262. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/FrameManager.js +7 -8
  263. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/FrameManager.js.map +1 -1
  264. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPRequest.d.ts +50 -11
  265. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPRequest.d.ts.map +1 -1
  266. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPRequest.js +70 -34
  267. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPRequest.js.map +1 -1
  268. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPResponse.d.ts +12 -5
  269. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPResponse.d.ts.map +1 -1
  270. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPResponse.js +26 -7
  271. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/HTTPResponse.js.map +1 -1
  272. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Input.d.ts +2 -4
  273. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/JSHandle.d.ts +39 -6
  274. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/JSHandle.d.ts.map +1 -1
  275. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/JSHandle.js +38 -4
  276. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/JSHandle.js.map +1 -1
  277. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/LifecycleWatcher.d.ts +3 -4
  278. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/LifecycleWatcher.d.ts.map +1 -1
  279. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/LifecycleWatcher.js +4 -4
  280. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/LifecycleWatcher.js.map +1 -1
  281. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkEventManager.d.ts +46 -0
  282. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkEventManager.d.ts.map +1 -0
  283. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkEventManager.js +120 -0
  284. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkEventManager.js.map +1 -0
  285. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkManager.d.ts +27 -10
  286. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkManager.d.ts.map +1 -1
  287. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkManager.js +144 -75
  288. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/NetworkManager.js.map +1 -1
  289. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Page.js +12 -14
  290. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Puppeteer.d.ts +5 -6
  291. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Puppeteer.js +3 -4
  292. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/QueryHandler.d.ts +1 -2
  293. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/Target.d.ts +4 -6
  294. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/WebWorker.d.ts +3 -5
  295. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/WebWorker.js +1 -2
  296. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/common/helper.js +3 -5
  297. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/initialize-node.js +1 -3
  298. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/BrowserFetcher.js +10 -12
  299. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/BrowserRunner.d.ts +4 -5
  300. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/BrowserRunner.d.ts.map +1 -1
  301. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/BrowserRunner.js +43 -20
  302. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/BrowserRunner.js.map +1 -1
  303. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/LaunchOptions.d.ts +1 -1
  304. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/Launcher.d.ts +1 -3
  305. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/Launcher.d.ts.map +1 -1
  306. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/Launcher.js +104 -40
  307. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/Launcher.js.map +1 -1
  308. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/NodeWebSocketTransport.d.ts +1 -3
  309. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/PipeTransport.d.ts +1 -2
  310. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/PipeTransport.js +1 -2
  311. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/Puppeteer.d.ts +5 -7
  312. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/Puppeteer.js +1 -3
  313. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/install.js +3 -5
  314. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node-puppeteer-core.js +1 -2
  315. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node.js +1 -2
  316. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.js +1 -1
  317. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/web.js +1 -2
  318. package/front_end/third_party/puppeteer/package/lib/types.d.ts +173 -36
  319. package/front_end/third_party/puppeteer/package/package.json +3 -3
  320. package/front_end/ui/components/adorners/Adorner.ts +2 -2
  321. package/front_end/ui/components/buttons/Button.ts +9 -9
  322. package/front_end/ui/components/data_grid/DataGrid.ts +62 -62
  323. package/front_end/ui/components/data_grid/DataGridController.ts +22 -22
  324. package/front_end/ui/components/diff_view/DiffView.ts +6 -6
  325. package/front_end/ui/components/expandable_list/ExpandableList.ts +5 -5
  326. package/front_end/ui/components/icon_button/Icon.ts +4 -4
  327. package/front_end/ui/components/icon_button/IconButton.ts +4 -4
  328. package/front_end/ui/components/issue_counter/IssueCounter.ts +3 -3
  329. package/front_end/ui/components/issue_counter/IssueLinkIcon.ts +11 -11
  330. package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspector.ts +50 -50
  331. package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorController.ts +6 -6
  332. package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorPane.ts +4 -4
  333. package/front_end/ui/components/linear_memory_inspector/LinearMemoryNavigator.ts +12 -12
  334. package/front_end/ui/components/linear_memory_inspector/LinearMemoryValueInterpreter.ts +11 -11
  335. package/front_end/ui/components/linear_memory_inspector/LinearMemoryViewer.ts +40 -39
  336. package/front_end/ui/components/linear_memory_inspector/ValueInterpreterDisplay.ts +18 -18
  337. package/front_end/ui/components/linear_memory_inspector/ValueInterpreterSettings.ts +6 -6
  338. package/front_end/ui/components/linkifier/LinkifierImpl.ts +4 -4
  339. package/front_end/ui/components/markdown_view/MarkdownImage.ts +5 -5
  340. package/front_end/ui/components/markdown_view/MarkdownLink.ts +2 -2
  341. package/front_end/ui/components/markdown_view/MarkdownView.ts +4 -5
  342. package/front_end/ui/components/panel_feedback/FeedbackButton.ts +2 -2
  343. package/front_end/ui/components/panel_feedback/PanelFeedback.ts +2 -2
  344. package/front_end/ui/components/panel_feedback/PreviewToggle.ts +4 -4
  345. package/front_end/ui/components/render_coordinator/RenderCoordinator.ts +22 -22
  346. package/front_end/ui/components/report_view/ReportView.ts +16 -16
  347. package/front_end/ui/components/request_link_icon/RequestLinkIcon.ts +14 -14
  348. package/front_end/ui/components/settings/SettingCheckbox.ts +5 -5
  349. package/front_end/ui/components/survey_link/SurveyLink.ts +8 -8
  350. package/front_end/ui/components/text_editor/TextEditor.ts +9 -9
  351. package/front_end/ui/components/text_editor/cursor_tooltip.ts +7 -1
  352. package/front_end/ui/components/text_prompt/TextPrompt.ts +18 -18
  353. package/front_end/ui/components/tree_outline/TreeOutline.ts +69 -70
  354. package/front_end/ui/legacy/ContextFlavorListener.ts +0 -4
  355. package/front_end/ui/legacy/ContextMenu.ts +2 -3
  356. package/front_end/ui/legacy/InspectorView.ts +1 -1
  357. package/front_end/ui/legacy/ReportView.ts +3 -4
  358. package/front_end/ui/legacy/SearchableView.ts +1 -2
  359. package/front_end/ui/legacy/SplitWidget.ts +2 -3
  360. package/front_end/ui/legacy/SuggestBox.ts +0 -3
  361. package/front_end/ui/legacy/TextPrompt.ts +1 -1
  362. package/front_end/ui/legacy/UIUtils.ts +1 -1
  363. package/front_end/ui/legacy/XLink.ts +1 -1
  364. package/front_end/ui/legacy/components/color_picker/Spectrum.ts +2 -2
  365. package/front_end/ui/legacy/components/data_grid/DataGrid.ts +9 -9
  366. package/front_end/ui/legacy/components/data_grid/dataGrid.css +7 -7
  367. package/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts +1 -1
  368. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +1 -5
  369. package/front_end/ui/legacy/components/source_frame/SourceFrame.ts +0 -1
  370. package/front_end/ui/legacy/components/utils/Linkifier.ts +2 -2
  371. package/front_end/ui/legacy/themeColors.css +2 -0
  372. package/front_end/ui/legacy/theme_support/theme_support_impl.ts +24 -1
  373. package/inspector_overlay/main.ts +16 -2
  374. package/package.json +1 -1
  375. package/scripts/eslint_rules/lib/use_private_class_members.js +41 -0
  376. package/scripts/eslint_rules/tests/use_private_class_members_test.js +62 -0
  377. package/scripts/migration/class-fields/migrate.js +2 -3
  378. package/scripts/migration/class-fields/migrate.sh +1 -3
  379. package/scripts/migration/class-fields/package.json +1 -1
@@ -89,8 +89,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
89
89
  this.scaleHeight = 16;
90
90
  /** @const */
91
91
  this.graphHeight = 90;
92
- this.gridColor = ThemeSupport.ThemeSupport.instance().patchColorText(
93
- 'rgba(0, 0, 0, 0.08)', ThemeSupport.ThemeSupport.ColorUsage.Foreground);
92
+ this.gridColor = ThemeSupport.ThemeSupport.instance().getComputedValue('--divider-line');
94
93
  this.controlPane = new ControlPane(this.contentElement);
95
94
  const chartContainer = this.contentElement.createChild('div', 'perfmon-chart-container');
96
95
  this.canvas = chartContainer.createChild('canvas') as HTMLCanvasElement;
@@ -220,11 +219,9 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
220
219
 
221
220
  private drawHorizontalGrid(ctx: CanvasRenderingContext2D): void {
222
221
  const labelDistanceSeconds = 10;
223
- const lightGray = ThemeSupport.ThemeSupport.instance().patchColorText(
224
- 'rgba(0, 0, 0, 0.02)', ThemeSupport.ThemeSupport.ColorUsage.Foreground);
222
+ const lightGray = ThemeSupport.ThemeSupport.instance().getComputedValue('--color-background-inverted-opacity-2');
225
223
  ctx.font = '10px ' + Host.Platform.fontFamily();
226
- ctx.fillStyle = ThemeSupport.ThemeSupport.instance().patchColorText(
227
- 'rgba(0, 0, 0, 0.55)', ThemeSupport.ThemeSupport.ColorUsage.Foreground);
224
+ ctx.fillStyle = ThemeSupport.ThemeSupport.instance().getComputedValue('--color-background-inverted-opacity-50');
228
225
  const currentTime = Date.now() / 1000;
229
226
  for (let sec = Math.ceil(currentTime);; --sec) {
230
227
  const x = this.width - ((currentTime - sec) * 1000 - this.pollIntervalMs) * this.pixelsPerMs;
@@ -277,8 +274,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
277
274
  ctx.restore();
278
275
  }
279
276
  }
280
- ctx.fillStyle = ThemeSupport.ThemeSupport.instance().patchColorText(
281
- 'rgba(0, 0, 0, 0.55)', ThemeSupport.ThemeSupport.ColorUsage.Foreground);
277
+ ctx.fillStyle = ThemeSupport.ThemeSupport.instance().getComputedValue('--color-background-inverted-opacity-50');
282
278
  ctx.font = `10px ${Host.Platform.fontFamily()}`;
283
279
  ctx.fillText(chartInfo.title, 8, 10);
284
280
  this.drawVerticalGrid(ctx, height - bottomPadding, max, chartInfo);
@@ -327,8 +323,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
327
323
  const span = max;
328
324
  const topPadding = 18;
329
325
  const visibleHeight = height - topPadding;
330
- ctx.fillStyle = ThemeSupport.ThemeSupport.instance().patchColorText(
331
- 'rgba(0, 0, 0, 0.55)', ThemeSupport.ThemeSupport.ColorUsage.Foreground);
326
+ ctx.fillStyle = ThemeSupport.ThemeSupport.instance().getComputedValue('--color-background-inverted-opacity-50');
332
327
  ctx.strokeStyle = this.gridColor;
333
328
  ctx.beginPath();
334
329
  for (let i = 0; i < 2; ++i) {
@@ -345,8 +340,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
345
340
  ctx.beginPath();
346
341
  ctx.moveTo(0, height + 0.5);
347
342
  ctx.lineTo(this.width, height + 0.5);
348
- ctx.strokeStyle = ThemeSupport.ThemeSupport.instance().patchColorText(
349
- 'rgba(0, 0, 0, 0.2)', ThemeSupport.ThemeSupport.ColorUsage.Foreground);
343
+ ctx.strokeStyle = ThemeSupport.ThemeSupport.instance().getComputedValue('--color-background-inverted-opacity-2');
350
344
  ctx.stroke();
351
345
  function calcY(value: number): number {
352
346
  return Math.round(height - visibleHeight * value / span) + 0.5;
@@ -255,7 +255,7 @@ export class SamplingHeapProfileTypeBase extends
255
255
  }
256
256
 
257
257
  profileBeingRecorded(): SamplingHeapProfileHeader|null {
258
- return /** @type {?SamplingHeapProfileHeader} */ super.profileBeingRecorded() as SamplingHeapProfileHeader | null;
258
+ return super.profileBeingRecorded() as SamplingHeapProfileHeader | null;
259
259
  }
260
260
 
261
261
  typeName(): string {
@@ -472,7 +472,6 @@ export class HeapSnapshotViewportDataGrid extends HeapSnapshotSortableDataGrid {
472
472
  if (selectedNode.parent) {
473
473
  selectedNode.select(true);
474
474
  } else {
475
- /** @type {?HeapSnapshotGridNode} */
476
475
  this.selectedNode = selectedNode;
477
476
  }
478
477
  }
@@ -861,8 +861,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
861
861
  }
862
862
 
863
863
  getPopoverRequest(event: Event): UI.PopoverHelper.PopoverRequest|null {
864
- const span =
865
- /** @type {?HTMLElement} */ (UI.UIUtils.enclosingNodeOrSelfWithNodeName((event.target as Node), 'span'));
864
+ const span = UI.UIUtils.enclosingNodeOrSelfWithNodeName((event.target as Node), 'span');
866
865
  const row = UI.UIUtils.enclosingNodeOrSelfWithNodeName((event.target as Node), 'tr');
867
866
  if (!row) {
868
867
  return null;
@@ -137,7 +137,7 @@
137
137
  color: var(--color-text-secondary);
138
138
  }
139
139
 
140
- .cycled-ancessor-node {
140
+ .heap-snapshot-view tr:not(.selected) .cycled-ancessor-node {
141
141
  opacity: 60%;
142
142
  }
143
143
 
@@ -159,9 +159,6 @@ export class QueryTerm {
159
159
  }
160
160
  }
161
161
 
162
- /**
163
- * @interface
164
- */
165
162
  export interface SearchResult {
166
163
  label(): string;
167
164
 
@@ -176,9 +173,6 @@ export interface SearchResult {
176
173
  matchRevealable(index: number): Object;
177
174
  }
178
175
 
179
- /**
180
- * @interface
181
- */
182
176
  export interface SearchScope {
183
177
  performSearch(
184
178
  searchConfig: SearchConfig, progress: Common.Progress.Progress,
@@ -53,13 +53,11 @@ export class SecurityModel extends SDK.SDKModel.SDKModel<EventTypes> {
53
53
  }
54
54
 
55
55
  resourceTreeModel(): SDK.ResourceTreeModel.ResourceTreeModel {
56
- return /** @type {!SDK.ResourceTreeModel.ResourceTreeModel} */ this.target().model(
57
- SDK.ResourceTreeModel.ResourceTreeModel) as SDK.ResourceTreeModel.ResourceTreeModel;
56
+ return this.target().model(SDK.ResourceTreeModel.ResourceTreeModel) as SDK.ResourceTreeModel.ResourceTreeModel;
58
57
  }
59
58
 
60
59
  networkManager(): SDK.NetworkManager.NetworkManager {
61
- return /** @type {!SDK.NetworkManager.NetworkManager} */ this.target().model(SDK.NetworkManager.NetworkManager) as
62
- SDK.NetworkManager.NetworkManager;
60
+ return this.target().model(SDK.NetworkManager.NetworkManager) as SDK.NetworkManager.NetworkManager;
63
61
  }
64
62
 
65
63
  // eslint-disable-next-line @typescript-eslint/naming-convention
@@ -797,11 +797,11 @@ export class SecurityPanelSidebarTree extends UI.TreeOutline.TreeOutlineInShadow
797
797
  }
798
798
 
799
799
  private originGroupTitle(originGroup: OriginGroup): string {
800
- return /** @type {string} */ this.originGroupTitles.get(originGroup) as string;
800
+ return this.originGroupTitles.get(originGroup) as string;
801
801
  }
802
802
 
803
803
  private originGroupElement(originGroup: OriginGroup): UI.TreeOutline.TreeElement {
804
- return /** @type {!UI.TreeOutline.TreeElement} */ this.originGroups.get(originGroup) as UI.TreeOutline.TreeElement;
804
+ return this.originGroups.get(originGroup) as UI.TreeOutline.TreeElement;
805
805
  }
806
806
 
807
807
  private createOriginGroupElement(originGroupTitle: string): UI.TreeOutline.TreeElement {
@@ -249,6 +249,10 @@ export class KeybindsSettingsTab extends UI.Widget.VBox implements UI.ListContro
249
249
 
250
250
  let currentCategory: string;
251
251
  actions.forEach(action => {
252
+ if (action.id() === 'elements.toggle-element-search') {
253
+ return;
254
+ }
255
+
252
256
  if (currentCategory !== action.category()) {
253
257
  items.push(action.category());
254
258
  }
@@ -44,40 +44,40 @@ export interface SyncSectionData {
44
44
 
45
45
  export class SyncSection extends HTMLElement {
46
46
  static readonly litTagName = LitHtml.literal`devtools-sync-section`;
47
- private readonly shadow = this.attachShadow({mode: 'open'});
47
+ readonly #shadow = this.attachShadow({mode: 'open'});
48
48
 
49
- private syncInfo: Host.InspectorFrontendHostAPI.SyncInformation = {isSyncActive: false};
50
- private syncSetting?: Common.Settings.Setting<boolean>;
49
+ #syncInfo: Host.InspectorFrontendHostAPI.SyncInformation = {isSyncActive: false};
50
+ #syncSetting?: Common.Settings.Setting<boolean>;
51
51
 
52
- private boundRender = this.render.bind(this);
52
+ #boundRender = this.#render.bind(this);
53
53
 
54
54
  connectedCallback(): void {
55
- this.shadow.adoptedStyleSheets = [syncSectionStyles];
55
+ this.#shadow.adoptedStyleSheets = [syncSectionStyles];
56
56
  }
57
57
 
58
58
  set data(data: SyncSectionData) {
59
- this.syncInfo = data.syncInfo;
60
- this.syncSetting = data.syncSetting;
61
- ComponentHelpers.ScheduledRender.scheduleRender(this, this.boundRender);
59
+ this.#syncInfo = data.syncInfo;
60
+ this.#syncSetting = data.syncSetting;
61
+ ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
62
62
  }
63
63
 
64
- private render(): void {
65
- if (!this.syncSetting) {
64
+ #render(): void {
65
+ if (!this.#syncSetting) {
66
66
  throw new Error('SyncSection not properly initialized');
67
67
  }
68
68
 
69
- const checkboxDisabled = !this.syncInfo.isSyncActive || !this.syncInfo.arePreferencesSynced;
69
+ const checkboxDisabled = !this.#syncInfo.isSyncActive || !this.#syncInfo.arePreferencesSynced;
70
70
  // Disabled until https://crbug.com/1079231 is fixed.
71
71
  // clang-format off
72
72
  LitHtml.render(LitHtml.html`
73
73
  <fieldset>
74
74
  <legend>${Common.Settings.getLocalizedSettingsCategory(Common.Settings.SettingCategory.SYNC)}</legend>
75
- ${renderAccountInfoOrWarning(this.syncInfo)}
75
+ ${renderAccountInfoOrWarning(this.#syncInfo)}
76
76
  <${Settings.SettingCheckbox.SettingCheckbox.litTagName} .data=${
77
- {setting: this.syncSetting, disabled: checkboxDisabled} as Settings.SettingCheckbox.SettingCheckboxData}>
77
+ {setting: this.#syncSetting, disabled: checkboxDisabled} as Settings.SettingCheckbox.SettingCheckboxData}>
78
78
  </${Settings.SettingCheckbox.SettingCheckbox.litTagName}>
79
79
  </fieldset>
80
- `, this.shadow, {host: this});
80
+ `, this.#shadow, {host: this});
81
81
  // clang-format on
82
82
  }
83
83
  }
@@ -183,66 +183,66 @@ const DEFAULT_METADATA = {
183
183
  // eslint-disable-next-line rulesdir/custom_element_definitions_location
184
184
  export class UserAgentClientHintsForm extends HTMLElement {
185
185
  static readonly litTagName = LitHtml.literal`devtools-user-agent-client-hints-form`;
186
- private readonly shadow = this.attachShadow({mode: 'open'});
186
+ readonly #shadow = this.attachShadow({mode: 'open'});
187
187
 
188
- private isFormOpened: boolean = false;
189
- private isFormDisabled: boolean = false;
190
- private metaData: Protocol.Emulation.UserAgentMetadata = DEFAULT_METADATA;
191
- private showMobileCheckbox: boolean = false;
192
- private showSubmitButton: boolean = false;
193
- private brandsModifiedAriaMessage: string = '';
188
+ #isFormOpened: boolean = false;
189
+ #isFormDisabled: boolean = false;
190
+ #metaData: Protocol.Emulation.UserAgentMetadata = DEFAULT_METADATA;
191
+ #showMobileCheckbox: boolean = false;
192
+ #showSubmitButton: boolean = false;
193
+ #brandsModifiedAriaMessage: string = '';
194
194
 
195
195
  connectedCallback(): void {
196
- this.shadow.adoptedStyleSheets = [userAgentClientHintsFormStyles];
196
+ this.#shadow.adoptedStyleSheets = [userAgentClientHintsFormStyles];
197
197
  }
198
198
 
199
199
  set value(data: UserAgentClientHintsFormData) {
200
200
  const {metaData = DEFAULT_METADATA, showMobileCheckbox = false, showSubmitButton = false} = data;
201
- this.metaData = {
202
- ...this.metaData,
201
+ this.#metaData = {
202
+ ...this.#metaData,
203
203
  ...metaData,
204
204
  };
205
- this.showMobileCheckbox = showMobileCheckbox;
206
- this.showSubmitButton = showSubmitButton;
207
- this.render();
205
+ this.#showMobileCheckbox = showMobileCheckbox;
206
+ this.#showSubmitButton = showSubmitButton;
207
+ this.#render();
208
208
  }
209
209
 
210
210
  get value(): UserAgentClientHintsFormData {
211
211
  return {
212
- metaData: this.metaData,
212
+ metaData: this.#metaData,
213
213
  };
214
214
  }
215
215
 
216
216
  set disabled(disableForm: boolean) {
217
- this.isFormDisabled = disableForm;
218
- this.isFormOpened = false;
219
- this.render();
217
+ this.#isFormDisabled = disableForm;
218
+ this.#isFormOpened = false;
219
+ this.#render();
220
220
  }
221
221
 
222
222
  get disabled(): boolean {
223
- return this.isFormDisabled;
223
+ return this.#isFormDisabled;
224
224
  }
225
225
 
226
- private handleTreeExpand = (event: KeyboardEvent): void => {
226
+ #handleTreeExpand = (event: KeyboardEvent): void => {
227
227
  if (event.code === 'Space' || event.code === 'Enter' || event.code === 'ArrowLeft' || event.code === 'ArrowRight') {
228
228
  event.stopPropagation();
229
- this.handleTreeClick(event.code);
229
+ this.#handleTreeClick(event.code);
230
230
  }
231
231
  };
232
232
 
233
- private handleTreeClick = (key: string): void => {
234
- if (this.isFormDisabled) {
233
+ #handleTreeClick = (key: string): void => {
234
+ if (this.#isFormDisabled) {
235
235
  return;
236
236
  }
237
- if ((key === 'ArrowLeft' && !this.isFormOpened) || (key === 'ArrowRight' && this.isFormOpened)) {
237
+ if ((key === 'ArrowLeft' && !this.#isFormOpened) || (key === 'ArrowRight' && this.#isFormOpened)) {
238
238
  return;
239
239
  }
240
- this.isFormOpened = !this.isFormOpened;
241
- this.render();
240
+ this.#isFormOpened = !this.#isFormOpened;
241
+ this.#render();
242
242
  };
243
243
 
244
- private handleBrandInputChange = (value: string, index: number, brandInputType: 'brandName'|'brandVersion'): void => {
245
- const updatedBrands = this.metaData.brands?.map((browserBrand, brandIndex) => {
244
+ #handleBrandInputChange = (value: string, index: number, brandInputType: 'brandName'|'brandVersion'): void => {
245
+ const updatedBrands = this.#metaData.brands?.map((browserBrand, brandIndex) => {
246
246
  if (brandIndex === index) {
247
247
  const {brand, version} = browserBrand;
248
248
  if (brandInputType === 'brandName') {
@@ -258,24 +258,24 @@ export class UserAgentClientHintsForm extends HTMLElement {
258
258
  }
259
259
  return browserBrand;
260
260
  });
261
- this.metaData = {
262
- ...this.metaData,
261
+ this.#metaData = {
262
+ ...this.#metaData,
263
263
  brands: updatedBrands,
264
264
  };
265
265
  this.dispatchEvent(new ClientHintsChangeEvent());
266
- this.render();
266
+ this.#render();
267
267
  };
268
268
 
269
- private handleBrandDelete = (index: number): void => {
270
- const {brands = []} = this.metaData;
269
+ #handleBrandDelete = (index: number): void => {
270
+ const {brands = []} = this.#metaData;
271
271
  brands.splice(index, 1);
272
- this.metaData = {
273
- ...this.metaData,
272
+ this.#metaData = {
273
+ ...this.#metaData,
274
274
  brands,
275
275
  };
276
276
  this.dispatchEvent(new ClientHintsChangeEvent());
277
- this.brandsModifiedAriaMessage = i18nString(UIStrings.deletedBrand);
278
- this.render();
277
+ this.#brandsModifiedAriaMessage = i18nString(UIStrings.deletedBrand);
278
+ this.#render();
279
279
 
280
280
  // after deleting a brand row, focus on next Brand input if available,
281
281
  // otherwise focus on the "Add Brand" button
@@ -286,10 +286,10 @@ export class UserAgentClientHintsForm extends HTMLElement {
286
286
  (nextFocusElement as HTMLElement)?.focus();
287
287
  };
288
288
 
289
- private handleAddBrandClick = (): void => {
290
- const {brands} = this.metaData;
291
- this.metaData = {
292
- ...this.metaData,
289
+ #handleAddBrandClick = (): void => {
290
+ const {brands} = this.#metaData;
291
+ this.#metaData = {
292
+ ...this.#metaData,
293
293
  brands: [
294
294
  ...(Array.isArray(brands) ? brands : []),
295
295
  {
@@ -299,8 +299,8 @@ export class UserAgentClientHintsForm extends HTMLElement {
299
299
  ],
300
300
  };
301
301
  this.dispatchEvent(new ClientHintsChangeEvent());
302
- this.brandsModifiedAriaMessage = i18nString(UIStrings.addedBrand);
303
- this.render();
302
+ this.#brandsModifiedAriaMessage = i18nString(UIStrings.addedBrand);
303
+ this.#render();
304
304
  const brandInputElements = this.shadowRoot?.querySelectorAll('.brand-name-input');
305
305
  if (brandInputElements) {
306
306
  const lastBrandInputElement = Array.from(brandInputElements).pop();
@@ -310,45 +310,45 @@ export class UserAgentClientHintsForm extends HTMLElement {
310
310
  }
311
311
  };
312
312
 
313
- private handleAddBrandKeyPress = (event: KeyboardEvent): void => {
313
+ #handleAddBrandKeyPress = (event: KeyboardEvent): void => {
314
314
  if (event.code === 'Space' || event.code === 'Enter') {
315
315
  event.preventDefault();
316
- this.handleAddBrandClick();
316
+ this.#handleAddBrandClick();
317
317
  }
318
318
  };
319
319
 
320
- private handleInputChange = (stateKey: keyof Protocol.Emulation.UserAgentMetadata, value: string|boolean): void => {
321
- if (stateKey in this.metaData) {
322
- this.metaData = {
323
- ...this.metaData,
320
+ #handleInputChange = (stateKey: keyof Protocol.Emulation.UserAgentMetadata, value: string|boolean): void => {
321
+ if (stateKey in this.#metaData) {
322
+ this.#metaData = {
323
+ ...this.#metaData,
324
324
  [stateKey]: value,
325
325
  };
326
- this.render();
326
+ this.#render();
327
327
  }
328
328
  this.dispatchEvent(new ClientHintsChangeEvent());
329
329
  };
330
330
 
331
- private handleLinkPress = (event: KeyboardEvent): void => {
331
+ #handleLinkPress = (event: KeyboardEvent): void => {
332
332
  if (event.code === 'Space' || event.code === 'Enter') {
333
333
  event.preventDefault();
334
334
  (event.target as HTMLAnchorElement).click();
335
335
  }
336
336
  };
337
337
 
338
- private handleSubmit = (event: Event): void => {
338
+ #handleSubmit = (event: Event): void => {
339
339
  event.preventDefault();
340
- if (this.showSubmitButton) {
341
- this.dispatchEvent(new ClientHintsSubmitEvent(this.metaData));
342
- this.render();
340
+ if (this.#showSubmitButton) {
341
+ this.dispatchEvent(new ClientHintsSubmitEvent(this.#metaData));
342
+ this.#render();
343
343
  }
344
344
  };
345
345
 
346
- private renderInputWithLabel(
346
+ #renderInputWithLabel(
347
347
  label: string, placeholder: string, value: string,
348
348
  stateKey: keyof Protocol.Emulation.UserAgentMetadata): LitHtml.TemplateResult {
349
349
  const handleInputChange = (event: KeyboardEvent): void => {
350
350
  const value = (event.target as HTMLInputElement).value;
351
- this.handleInputChange(stateKey, value);
351
+ this.#handleInputChange(stateKey, value);
352
352
  };
353
353
  return LitHtml.html`
354
354
  <label class="full-row label input-field-label-container">
@@ -364,15 +364,15 @@ export class UserAgentClientHintsForm extends HTMLElement {
364
364
  `;
365
365
  }
366
366
 
367
- private renderPlatformSection(): LitHtml.TemplateResult {
368
- const {platform, platformVersion} = this.metaData;
367
+ #renderPlatformSection(): LitHtml.TemplateResult {
368
+ const {platform, platformVersion} = this.#metaData;
369
369
  const handlePlatformNameChange = (event: KeyboardEvent): void => {
370
370
  const value = (event.target as HTMLInputElement).value;
371
- this.handleInputChange('platform', value);
371
+ this.#handleInputChange('platform', value);
372
372
  };
373
373
  const handlePlatformVersionChange = (event: KeyboardEvent): void => {
374
374
  const value = (event.target as HTMLInputElement).value;
375
- this.handleInputChange('platformVersion', value);
375
+ this.#handleInputChange('platformVersion', value);
376
376
  };
377
377
  return LitHtml.html`
378
378
  <span class="full-row label">${i18nString(UIStrings.platformLabel)}</span>
@@ -397,28 +397,28 @@ export class UserAgentClientHintsForm extends HTMLElement {
397
397
  `;
398
398
  }
399
399
 
400
- private renderDeviceModelSection(): LitHtml.TemplateResult {
401
- const {model, mobile} = this.metaData;
400
+ #renderDeviceModelSection(): LitHtml.TemplateResult {
401
+ const {model, mobile} = this.#metaData;
402
402
  const handleDeviceModelChange = (event: KeyboardEvent): void => {
403
403
  const value = (event.target as HTMLInputElement).value;
404
- this.handleInputChange('model', value);
404
+ this.#handleInputChange('model', value);
405
405
  };
406
406
  const handleMobileChange = (event: KeyboardEvent): void => {
407
407
  const value = (event.target as HTMLInputElement).checked;
408
- this.handleInputChange('mobile', value);
408
+ this.#handleInputChange('mobile', value);
409
409
  };
410
- const mobileCheckboxInput = this.showMobileCheckbox ? LitHtml.html`
410
+ const mobileCheckboxInput = this.#showMobileCheckbox ? LitHtml.html`
411
411
  <label class="mobile-checkbox-container">
412
412
  <input type="checkbox" @input=${handleMobileChange} .checked=${mobile} />
413
413
  ${i18nString(UIStrings.mobileCheckboxLabel)}
414
414
  </label>
415
415
  ` :
416
- LitHtml.html``;
416
+ LitHtml.html``;
417
417
  return LitHtml.html`
418
418
  <span class="full-row label">${i18nString(UIStrings.deviceModel)}</span>
419
419
  <div class="full-row brand-row" aria-label=${i18nString(UIStrings.deviceProperties)} role="group">
420
420
  <input
421
- class="input-field ${this.showMobileCheckbox ? 'device-model-input' : 'full-row'}"
421
+ class="input-field ${this.#showMobileCheckbox ? 'device-model-input' : 'full-row'}"
422
422
  type="text"
423
423
  @input=${handleDeviceModelChange}
424
424
  .value=${model}
@@ -429,7 +429,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
429
429
  `;
430
430
  }
431
431
 
432
- private renderBrands(): LitHtml.TemplateResult {
432
+ #renderBrands(): LitHtml.TemplateResult {
433
433
  const {
434
434
  brands =
435
435
  [
@@ -438,11 +438,11 @@ export class UserAgentClientHintsForm extends HTMLElement {
438
438
  version: '',
439
439
  },
440
440
  ],
441
- } = this.metaData;
441
+ } = this.#metaData;
442
442
  const brandElements = brands.map((brandRow, index) => {
443
443
  const {brand, version} = brandRow;
444
444
  const handleDeleteClick = (): void => {
445
- this.handleBrandDelete(index);
445
+ this.#handleBrandDelete(index);
446
446
  };
447
447
  const handleKeyPress = (event: KeyboardEvent): void => {
448
448
  if (event.code === 'Space' || event.code === 'Enter') {
@@ -452,11 +452,11 @@ export class UserAgentClientHintsForm extends HTMLElement {
452
452
  };
453
453
  const handleBrandBrowserChange = (event: KeyboardEvent): void => {
454
454
  const value = (event.target as HTMLInputElement).value;
455
- this.handleBrandInputChange(value, index, 'brandName');
455
+ this.#handleBrandInputChange(value, index, 'brandName');
456
456
  };
457
457
  const handleBrandVersionChange = (event: KeyboardEvent): void => {
458
458
  const value = (event.target as HTMLInputElement).value;
459
- this.handleBrandInputChange(value, index, 'brandVersion');
459
+ this.#handleBrandInputChange(value, index, 'brandVersion');
460
460
  };
461
461
  return LitHtml.html`
462
462
  <div class="full-row brand-row" aria-label=${i18nString(UIStrings.brandProperties)} role="group">
@@ -508,8 +508,8 @@ export class UserAgentClientHintsForm extends HTMLElement {
508
508
  tabindex="0"
509
509
  id="add-brand-button"
510
510
  aria-label=${i18nString(UIStrings.addBrand)}
511
- @click=${this.handleAddBrandClick}
512
- @keypress=${this.handleAddBrandKeyPress}
511
+ @click=${this.#handleAddBrandClick}
512
+ @keypress=${this.#handleAddBrandKeyPress}
513
513
  >
514
514
  <${IconButton.Icon.Icon.litTagName}
515
515
  aria-hidden="true"
@@ -522,18 +522,18 @@ export class UserAgentClientHintsForm extends HTMLElement {
522
522
  `;
523
523
  }
524
524
 
525
- private render(): void {
526
- const {fullVersion, architecture} = this.metaData;
527
- const brandSection = this.renderBrands();
528
- const fullBrowserInput = this.renderInputWithLabel(
525
+ #render(): void {
526
+ const {fullVersion, architecture} = this.#metaData;
527
+ const brandSection = this.#renderBrands();
528
+ const fullBrowserInput = this.#renderInputWithLabel(
529
529
  i18nString(UIStrings.fullBrowserVersion), i18nString(UIStrings.fullBrowserVersionPlaceholder),
530
530
  fullVersion || '', 'fullVersion');
531
- const platformSection = this.renderPlatformSection();
532
- const architectureInput = this.renderInputWithLabel(
531
+ const platformSection = this.#renderPlatformSection();
532
+ const architectureInput = this.#renderInputWithLabel(
533
533
  i18nString(UIStrings.architecture), i18nString(UIStrings.architecturePlaceholder), architecture,
534
534
  'architecture');
535
- const deviceModelSection = this.renderDeviceModelSection();
536
- const submitButton = this.showSubmitButton ? LitHtml.html`
535
+ const deviceModelSection = this.#renderDeviceModelSection();
536
+ const submitButton = this.#showSubmitButton ? LitHtml.html`
537
537
  <${Buttons.Button.Button.litTagName}
538
538
  .variant=${Buttons.Button.Variant.SECONDARY}
539
539
  .type=${'submit'}
@@ -541,23 +541,23 @@ export class UserAgentClientHintsForm extends HTMLElement {
541
541
  ${i18nString(UIStrings.update)}
542
542
  </${Buttons.Button.Button.litTagName}>
543
543
  ` :
544
- LitHtml.html``;
544
+ LitHtml.html``;
545
545
  const output = LitHtml.html`
546
546
  <section class="root">
547
547
  <div
548
548
  class="tree-title"
549
549
  role="button"
550
- @click=${this.handleTreeClick}
550
+ @click=${this.#handleTreeClick}
551
551
  tabindex="0"
552
- @keydown=${this.handleTreeExpand}
553
- aria-expanded=${this.isFormOpened}
552
+ @keydown=${this.#handleTreeExpand}
553
+ aria-expanded=${this.#isFormOpened}
554
554
  aria-controls="form-container"
555
- @disabled=${this.isFormDisabled}
556
- aria-disabled=${this.isFormDisabled}
555
+ @disabled=${this.#isFormDisabled}
556
+ aria-disabled=${this.#isFormDisabled}
557
557
  aria-label=${i18nString(UIStrings.title)}
558
558
  >
559
559
  <${IconButton.Icon.Icon.litTagName}
560
- class=${this.isFormOpened ? '' : 'rotate-icon'}
560
+ class=${this.#isFormOpened ? '' : 'rotate-icon'}
561
561
  .data=${
562
562
  {color: 'var(--client-hints-form-icon-color)', iconName: 'chromeSelect', width: '20px'} as
563
563
  IconButton.Icon.IconData}
@@ -569,7 +569,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
569
569
  href="https://web.dev/user-agent-client-hints/"
570
570
  target="_blank"
571
571
  class="info-link"
572
- @keypress=${this.handleLinkPress}
572
+ @keypress=${this.#handleLinkPress}
573
573
  aria-label=${i18nString(UIStrings.userAgentClientHintsInfo)}
574
574
  >
575
575
  <${IconButton.Icon.Icon.litTagName}
@@ -582,8 +582,8 @@ export class UserAgentClientHintsForm extends HTMLElement {
582
582
  </div>
583
583
  <form
584
584
  id="form-container"
585
- class="form-container ${this.isFormOpened ? '' : 'hide-container'}"
586
- @submit=${this.handleSubmit}
585
+ class="form-container ${this.#isFormOpened ? '' : 'hide-container'}"
586
+ @submit=${this.#handleSubmit}
587
587
  >
588
588
  ${brandSection}
589
589
  ${fullBrowserInput}
@@ -592,18 +592,18 @@ export class UserAgentClientHintsForm extends HTMLElement {
592
592
  ${deviceModelSection}
593
593
  ${submitButton}
594
594
  </form>
595
- <div aria-live="polite" aria-label=${this.brandsModifiedAriaMessage}></div>
595
+ <div aria-live="polite" aria-label=${this.#brandsModifiedAriaMessage}></div>
596
596
  </section>
597
597
  `;
598
598
  // clang-format off
599
- LitHtml.render(output, this.shadow, {host: this});
599
+ LitHtml.render(output, this.#shadow, {host: this});
600
600
  // clang-format on
601
601
  }
602
602
 
603
603
  validate = (): UI.ListWidget.ValidatorResult => {
604
- for (const [metaDataKey, metaDataValue] of Object.entries(this.metaData)) {
604
+ for (const [metaDataKey, metaDataValue] of Object.entries(this.#metaData)) {
605
605
  if (metaDataKey === 'brands') {
606
- const isBrandValid = this.metaData.brands?.every(({brand, version}) => {
606
+ const isBrandValid = this.#metaData.brands?.every(({brand, version}) => {
607
607
  const brandNameResult = EmulationUtils.UserAgentMetadata.validateAsStructuredHeadersString(
608
608
  brand, i18nString(UIStrings.notRepresentable));
609
609
  const brandVersionResult = EmulationUtils.UserAgentMetadata.validateAsStructuredHeadersString(
@@ -137,12 +137,13 @@ fieldset {
137
137
  }
138
138
 
139
139
  #experiments-tab-content .settings-container {
140
- column-width: 470px;
140
+ column-width: auto;
141
141
  }
142
142
 
143
143
  #experiments-tab-content .settings-block {
144
- width: 470px;
144
+ width: auto;
145
145
  margin-left: 0;
146
+ margin-right: 10px;
146
147
  }
147
148
 
148
149
  .settings-tab-container header > h1 {
@@ -172,7 +173,11 @@ fieldset {
172
173
 
173
174
  .settings-experiment {
174
175
  display: grid;
175
- grid-template-columns: auto 1fr;
176
+ grid-template-columns: auto min-content 1fr;
177
+ }
178
+
179
+ .settings-experiment [is="dt-checkbox"] {
180
+ padding-right: 10px;
176
181
  }
177
182
 
178
183
  .settings-experiment .devtools-link {