chrome-devtools-frontend 1.0.950768 → 1.0.951864

package/front_end/ui/legacy/components/color_picker/Spectrum.ts

@@ -347,7 +347,7 @@ export class Spectrum extends Common.ObjectWrapper.eventMixin<EventTypes, typeof
         case 'ArrowUp':
           return elementPosition.right + 1;
         default:
-          return /** @type {!MouseEvent} */ (event as MouseEvent).x;
+          return (event as MouseEvent).x;
       }
     }
 
@@ -1089,7 +1089,7 @@ export class Spectrum extends Common.ObjectWrapper.eventMixin<EventTypes, typeof
   /**
    * If the pasted input is parsable as a color, applies it converting to the current user format
    */
-  private pasted(/** @type {!ClipboardEvent} */ event: ClipboardEvent): void {
+  private pasted(event: ClipboardEvent): void {
     if (!event.clipboardData) {
       return;
     }

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -123,9 +123,9 @@ const elementToIndexMap = new WeakMap<Element, number>();
 export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTypes<T>> {
   element: HTMLDivElement;
   private displayName: string;
-  private editCallback: ((arg0: any, arg1: string, arg2: any, arg3: any) => any)|undefined;
-  private readonly deleteCallback: ((arg0: any) => any)|undefined;
-  private readonly refreshCallback: (() => any)|undefined;
+  private editCallback: ((arg0: any, arg1: string, arg2: any, arg3: any) => void)|undefined;
+  private readonly deleteCallback: ((arg0: any) => void)|undefined;
+  private readonly refreshCallback: (() => void)|undefined;
   private readonly headerTable: Element;
   private headerTableHeaders: {
     [x: string]: Element,
@@ -1258,7 +1258,7 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
       return;
     }
 
-    if (/** @type {!MouseEvent} */ (event as MouseEvent).metaKey) {
+    if ((event as MouseEvent).metaKey) {
       if (gridNode.selected) {
         gridNode.deselect();
       } else {
@@ -1378,13 +1378,13 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     }
 
     if (gridNode.expanded) {
-      if (/** @type {!MouseEvent}*/ (event as MouseEvent).altKey) {
+      if ((event as MouseEvent).altKey) {
         gridNode.collapseRecursively();
       } else {
         gridNode.collapse();
       }
     } else {
-      if (/** @type {!MouseEvent}*/ (event as MouseEvent).altKey) {
+      if ((event as MouseEvent).altKey) {
         gridNode.expandRecursively();
       } else {
         gridNode.expand();
@@ -2371,9 +2371,9 @@ export class DataGridWidget<T> extends UI.Widget.VBox {
 export interface Parameters {
   displayName: string;
   columns: ColumnDescriptor[];
-  editCallback?: ((arg0: any, arg1: string, arg2: any, arg3: any) => any);
-  deleteCallback?: ((arg0: any) => any);
-  refreshCallback?: (() => any);
+  editCallback?: ((arg0: any, arg1: string, arg2: any, arg3: any) => void);
+  deleteCallback?: ((arg0: any) => void);
+  refreshCallback?: (() => void);
 }
 export interface ColumnDescriptor {
   id: string;

package/front_end/ui/legacy/components/data_grid/dataGrid.css

@@ -226,16 +226,16 @@
 }
 
 .data-grid table.data tr.revealed.selected.dirty {
-  color: var(--legacy-selection-fg-color);
+  color: var(--color-selected-option);
 }
 
 .data-grid.no-selection:focus-visible {
-  border: 1px solid var(--legacy-accent-color) !important; /* stylelint-disable-line declaration-no-important */
+  border: 1px solid var(--color-primary) !important; /* stylelint-disable-line declaration-no-important */
 }
 
 .data-grid:focus table.data tr.selected {
-  background-color: var(--legacy-selection-bg-color);
-  color: var(--legacy-selection-fg-color);
+  background-color: var(--color-selected-option-background);
+  color: var(--color-selected-option);
 }
 
 .data-grid:focus tr.selected.dirty {
@@ -249,16 +249,16 @@
 }
 
 .data-grid:focus tr.selected .devtools-link {
-  color: var(--legacy-selection-fg-color);
+  color: var(--color-selected-option);
 }
 
 .data-grid:focus tr.parent.selected td.disclosure::before {
-  background-color: var(--legacy-selection-fg-color);
+  background-color: var(--color-selected-option);
   -webkit-mask-position: 0 0;
 }
 
 .data-grid:focus tr.expanded.selected td.disclosure::before {
-  background-color: var(--legacy-selection-fg-color);
+  background-color: var(--color-selected-option);
   -webkit-mask-position: -16px 0;
 }
 

package/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts

@@ -116,7 +116,7 @@ export class CSSShadowEditor extends Common.ObjectWrapper.eventMixin<EventTypes,
     const slider = UI.UIUtils.createSlider(0, maxRange, -1);
     slider.addEventListener('input', this.onSliderInput.bind(this), false);
     field.appendChild(slider);
-    return /** @type {!HTMLInputElement} */ slider as HTMLInputElement;
+    return slider as HTMLInputElement;
   }
 
   wasShown(): void {

package/front_end/ui/legacy/components/perf_ui/FlameChart.ts

@@ -896,7 +896,7 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
         continue;
       }
       if (pos.x <= x && x < pos.x + pos.width) {
-        return /** @type {number} */ index as number;
+        return index as number;
       }
     }
 
@@ -2204,7 +2204,6 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
     this.highlightedMarkerIndex = -1;
     this.highlightedEntryIndex = -1;
     this.selectedEntryIndex = -1;
-    /** @type {!Map<string,!Map<string,number>>} */
     this.textWidth = new Map();
     this.chartViewport.scheduleUpdate();
   }
@@ -2272,9 +2271,6 @@ export class TimelineData {
   }
 }
 
-/**
- * @interface
- */
 export interface FlameChartDataProvider {
   minimumBoundary(): number;
 

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -461,7 +461,6 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
           }[],
         }>((resolve, reject) => {
           worker.onmessage =
-              /** @type {{event:string, params:{percentage:number}}} */
               // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
               // eslint-disable-next-line @typescript-eslint/no-explicit-any
               ({data}: MessageEvent<any>): void => {

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -678,7 +678,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 
   static linkInfo(link: Element|null): _LinkInfo|null {
-    return /** @type {?_LinkInfo} */ link ? infoByAnchor.get(link) || null : null as _LinkInfo | null;
+    return link ? infoByAnchor.get(link) || null : null as _LinkInfo | null;
   }
 
   private static handleClick(event: Event): boolean {
@@ -801,7 +801,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
     }
 
     if (uiLocation && uiLocation.uiSourceCode) {
-      const contentProvider = /** @type {!Workspace.UISourceCode.UISourceCode} */ uiLocation.uiSourceCode;
+      const contentProvider = uiLocation.uiSourceCode;
       result.push({
         section: 'clipboard',
         title: UI.UIUtils.copyFileNameLabel(),

package/front_end/ui/legacy/theme_support/theme_support_impl.ts

@@ -41,6 +41,8 @@ import inspectorSyntaxHighlightDarkStyles from '../inspectorSyntaxHighlightDark.
 
 let themeSupportInstance: ThemeSupport;
 
+const themeValuesCache = new Map<string, string>();
+
 export class ThemeSupport {
   private readonly themeNameInternal: string;
   private themableProperties: Set<string>;
@@ -101,7 +103,16 @@ export class ThemeSupport {
       throw new Error(`Computed value for property (${variableName}) could not be found on :root.`);
     }
 
-    return computedRoot.getPropertyValue(variableName);
+    // Since theme changes trigger a reload, we can avoid repeatedly looking up color values
+    // dynamically. Instead we can look up the first time and cache them for future use,
+    // knowing that the cache will be invalidated by virtue of a reload when the theme changes.
+    let cachedValue = themeValuesCache.get(variableName);
+    if (!cachedValue) {
+      cachedValue = computedRoot.getPropertyValue(variableName);
+      themeValuesCache.set(variableName, cachedValue);
+    }
+
+    return cachedValue;
   }
 
   hasTheme(): boolean {

package/inspector_overlay/main.ts

@@ -80,10 +80,17 @@ type MessageLookup = {
   drawingFinished: '',
 };
 
+let queue: unknown[][] = [];
+let prevQueue: string = '';
+
 const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLookup[K]]) => {
   const functionName = message[0];
   if (functionName === 'setOverlay') {
     const overlayName = message[1] as keyof Overlays;
+    // No need to swap overlays if it's the same overlay.
+    if (overlays[overlayName] === currentOverlay) {
+      return;
+    }
     if (currentOverlay) {
       currentOverlay.uninstall();
     }
@@ -97,9 +104,16 @@ const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLooku
   } else if (functionName === 'setPlatform') {
     platformName = message[1];
   } else if (functionName === 'drawingFinished') {
-    // TODO The logic needs to be added here once the backend starts sending this event.
+    const currentQueue = JSON.stringify(queue);
+    if (currentQueue !== prevQueue) {
+      for (const message of queue) {
+        currentOverlay.dispatch(message);
+      }
+    }
+    prevQueue = currentQueue;
+    queue = [];
   } else {
-    currentOverlay.dispatch(message);
+    queue.push(message);
   }
 };
 

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.950768"
+  "version": "1.0.951864"
 }