chrome-devtools-frontend 1.0.950484 → 1.0.951410

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -461,7 +461,6 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
           }[],
         }>((resolve, reject) => {
           worker.onmessage =
-              /** @type {{event:string, params:{percentage:number}}} */
               // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
               // eslint-disable-next-line @typescript-eslint/no-explicit-any
               ({data}: MessageEvent<any>): void => {

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -678,7 +678,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 
   static linkInfo(link: Element|null): _LinkInfo|null {
-    return /** @type {?_LinkInfo} */ link ? infoByAnchor.get(link) || null : null as _LinkInfo | null;
+    return link ? infoByAnchor.get(link) || null : null as _LinkInfo | null;
   }
 
   private static handleClick(event: Event): boolean {
@@ -801,7 +801,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
     }
 
     if (uiLocation && uiLocation.uiSourceCode) {
-      const contentProvider = /** @type {!Workspace.UISourceCode.UISourceCode} */ uiLocation.uiSourceCode;
+      const contentProvider = uiLocation.uiSourceCode;
       result.push({
         section: 'clipboard',
         title: UI.UIUtils.copyFileNameLabel(),

package/front_end/ui/legacy/theme_support/theme_support_impl.ts

@@ -41,6 +41,8 @@ import inspectorSyntaxHighlightDarkStyles from '../inspectorSyntaxHighlightDark.
 
 let themeSupportInstance: ThemeSupport;
 
+const themeValuesCache = new Map<string, string>();
+
 export class ThemeSupport {
   private readonly themeNameInternal: string;
   private themableProperties: Set<string>;
@@ -101,7 +103,16 @@ export class ThemeSupport {
       throw new Error(`Computed value for property (${variableName}) could not be found on :root.`);
     }
 
-    return computedRoot.getPropertyValue(variableName);
+    // Since theme changes trigger a reload, we can avoid repeatedly looking up color values
+    // dynamically. Instead we can look up the first time and cache them for future use,
+    // knowing that the cache will be invalidated by virtue of a reload when the theme changes.
+    let cachedValue = themeValuesCache.get(variableName);
+    if (!cachedValue) {
+      cachedValue = computedRoot.getPropertyValue(variableName);
+      themeValuesCache.set(variableName, cachedValue);
+    }
+
+    return cachedValue;
   }
 
   hasTheme(): boolean {

package/inspector_overlay/main.ts

@@ -80,10 +80,17 @@ type MessageLookup = {
   drawingFinished: '',
 };
 
+let queue: unknown[][] = [];
+let prevQueue: string = '';
+
 const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLookup[K]]) => {
   const functionName = message[0];
   if (functionName === 'setOverlay') {
     const overlayName = message[1] as keyof Overlays;
+    // No need to swap overlays if it's the same overlay.
+    if (overlays[overlayName] === currentOverlay) {
+      return;
+    }
     if (currentOverlay) {
       currentOverlay.uninstall();
     }
@@ -97,9 +104,16 @@ const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLooku
   } else if (functionName === 'setPlatform') {
     platformName = message[1];
   } else if (functionName === 'drawingFinished') {
-    // TODO The logic needs to be added here once the backend starts sending this event.
+    const currentQueue = JSON.stringify(queue);
+    if (currentQueue !== prevQueue) {
+      for (const message of queue) {
+        currentOverlay.dispatch(message);
+      }
+    }
+    prevQueue = currentQueue;
+    queue = [];
   } else {
-    currentOverlay.dispatch(message);
+    queue.push(message);
   }
 };
 

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.950484"
+  "version": "1.0.951410"
 }

package/scripts/build/ninja/copy.gni

@@ -16,8 +16,8 @@ template("copy_to_gen") {
 
     script = "scripts/build/ninja/copy-files.js"
 
-    _copy_src = rebase_path(get_path_info(target_name, "dir"))
-    _copy_dest = rebase_path(target_gen_dir)
+    _copy_src = rebase_path(get_path_info(target_name, "dir"), root_build_dir)
+    _copy_dest = rebase_path(target_gen_dir, root_build_dir)
 
     args = [
       _copy_src,

package/front_end/core/platform/utilities.ts

@@ -1,49 +0,0 @@
-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/*
- * Copyright (C) 2007 Apple Inc.  All rights reserved.
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1.  Redistributions of source code must retain the above copyright
- *     notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- *     notice, this list of conditions and the following disclaimer in the
- *     documentation and/or other materials provided with the distribution.
- * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
- *     its contributors may be used to endorse or promote products derived
- *     from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-export function runOnWindowLoad(callback: () => void): void {
-  function windowLoaded(): void {
-    window.removeEventListener('DOMContentLoaded', windowLoaded, false);
-    callback();
-  }
-
-  if (document.readyState === 'complete' || document.readyState === 'interactive') {
-    callback();
-  } else {
-    window.addEventListener('DOMContentLoaded', windowLoaded, false);
-  }
-}
-
-export function assertNever(type: never, message: string): never {
-  throw new Error(message);
-}