chrome-devtools-frontend 1.0.950484 → 1.0.950768

package/config/gni/devtools_grd_files.gni

@@ -554,7 +554,6 @@ grd_files_debug_sources = [
   "front_end/core/platform/set-utilities.js",
   "front_end/core/platform/string-utilities.js",
   "front_end/core/platform/typescript-utilities.js",
-  "front_end/core/platform/utilities.js",
   "front_end/core/protocol_client/InspectorBackend.js",
   "front_end/core/protocol_client/NodeURL.js",
   "front_end/core/root/Runtime.js",

package/docs/triage_guidelines.md

@@ -45,8 +45,8 @@ Issues in the untriaged queue should receive a meaningful response within a busi
 
 - Close issues as `WontFix` if they don't reproduce (in simple cases) or are requests for features we've already concluded not to pursue.
 - Close issues as `Archived` that are valid, but it seems unlikely that we will get there anytime soon.
-- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `Hotlist-DevTools-Triaged` and leave the `Untriaged` status as is.
-- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.  
+- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `DevTools-Triaged` label and leave the `Untriaged` status as is.
+- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.
 - Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
 - Put one of the following labels on it and set the status to `Available`:
   - `Hotlist-DevTools-ProductReview` if it's controversial or clear that consensus needs to be built first.

package/front_end/core/dom_extension/DOMExtension.ts

@@ -457,7 +457,7 @@ Node.prototype.isSelfOrDescendant = function(node: Node|null): boolean {
   return Boolean(node) && (node === this || this.isDescendant(node));
 };
 
-Node.prototype.traverseNextNode = function(stayWithin?: Node, skipShadowRoot?: boolean = false): Node|null {
+Node.prototype.traverseNextNode = function(stayWithin?: Node, skipShadowRoot: boolean = false): Node|null {
   if (!skipShadowRoot && this.shadowRoot) {
     return this.shadowRoot;
   }

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -357,7 +357,6 @@ export enum EnumeratedHistogram {
   IssuesPanelOpenedFrom = 'DevTools.IssuesPanelOpenedFrom',
   IssuesPanelResourceOpened = 'DevTools.IssuesPanelResourceOpened',
   KeybindSetSettingChanged = 'DevTools.KeybindSetSettingChanged',
-  DualScreenDeviceEmulated = 'DevTools.DualScreenDeviceEmulated',
   ExperimentEnabledAtLaunch = 'DevTools.ExperimentEnabledAtLaunch',
   ExperimentEnabled = 'DevTools.ExperimentEnabled',
   ExperimentDisabled = 'DevTools.ExperimentDisabled',

package/front_end/core/host/UserMetrics.ts

@@ -158,12 +158,6 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.IssueCreated, issueCreated, size);
   }
 
-  dualScreenDeviceEmulated(emulationAction: DualScreenDeviceEmulated): void {
-    const size = Object.keys(DualScreenDeviceEmulated).length + 1;
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.DualScreenDeviceEmulated, emulationAction, size);
-  }
-
   experimentEnabledAtLaunch(experimentId: string): void {
     const size = DevtoolsExperiments['__lastValidEnumPosition'] + 1;
     const experiment = DevtoolsExperiments[experimentId];
@@ -537,14 +531,6 @@ export enum IssueOpener {
   CommandMenu = 5,
 }
 
-// TODO(crbug.com/1167717): Make this a const enum again
-// eslint-disable-next-line rulesdir/const_enum
-export enum DualScreenDeviceEmulated {
-  DualScreenDeviceSelected = 0,
-  SpanButtonClicked = 1,
-  PlatformSupportUsed = 2,  // user starts to use platform dual screen support feature.
-}
-
 /**
  * This list should contain the currently active Devtools Experiments.
  * Therefore, it is possible that the id's will no longer be continuous

package/front_end/core/platform/platform.ts

@@ -45,8 +45,7 @@ export {DCHECK} from './dcheck.js';
  * (e.g. `Platform.TypeScriptUtilities.assertNotNull` causes a
  * compiler error)
  */
-export {assertNotNullOrUndefined, assertUnhandled} from './typescript-utilities.js';
-export {assertNever, runOnWindowLoad} from './utilities.js';
+export {assertNever, assertNotNullOrUndefined, assertUnhandled} from './typescript-utilities.js';
 export {
   ArrayUtilities,
   DateUtilities,

package/front_end/core/platform/typescript-utilities.ts

@@ -13,6 +13,10 @@ export function assertNotNullOrUndefined<T>(val: T): asserts val is NonNullable<
   }
 }
 
+export function assertNever(type: never, message: string): never {
+  throw new Error(message);
+}
+
 /**
  * This is useful to check on the type-level that the unhandled cases of
  * a switch are exactly `T` (where T is usually a union type of enum values).

package/front_end/devtools_compatibility.js

@@ -385,7 +385,6 @@
     IssuesPanelOpenedFrom: 'DevTools.IssuesPanelOpenedFrom',
     IssuesPanelResourceOpened: 'DevTools.IssuesPanelResourceOpened',
     KeybindSetSettingChanged: 'DevTools.KeybindSetSettingChanged',
-    DualScreenDeviceEmulated: 'DevTools.DualScreenDeviceEmulated',
     ExperimentEnabledAtLaunch: 'DevTools.ExperimentEnabledAtLaunch',
     ExperimentEnabled: 'DevTools.ExperimentEnabled',
     ExperimentDisabled: 'DevTools.ExperimentDisabled',

package/front_end/entrypoints/device_mode_emulation_frame/device_mode_emulation_frame.ts

@@ -5,13 +5,8 @@
 import '../../core/dom_extension/dom_extension.js';
 import '../../Images/Images.js';
 
-import * as Platform from '../../core/platform/platform.js';
-
-Platform.runOnWindowLoad(() => {
-  if (!window.opener) {
-    return;
-  }
+if (window.opener) {
   // @ts-ignore TypeScript doesn't know about `Emulation` on `Window`.
   const app = window.opener.Emulation.AdvancedApp.instance();
   app.deviceModeEmulationFrameLoaded(document);
-});
+}

package/front_end/entrypoints/main/MainImpl.ts

@@ -118,9 +118,7 @@ export class MainImpl {
 
   constructor() {
     MainImpl.instanceForTest = this;
-    Platform.runOnWindowLoad(() => {
-      this.loaded();
-    });
+    this.loaded();
   }
 
   static time(label: string): void {