chrome-devtools-frontend 1.0.950001 → 1.0.950484

package/front_end/core/host/UserMetrics.ts

@@ -686,6 +686,7 @@ export const IssueCreated: {
   'CorsIssue::CorsDisabledScheme': 53,
   'CorsIssue::PreflightMissingAllowExternal': 54,
   'CorsIssue::PreflightInvalidAllowExternal': 55,
+  'CorsIssue::InvalidResponse': 56,
   'CorsIssue::NoCorsRedirectModeNotFollow': 57,
   'QuirksModeIssue::QuirksMode': 58,
   'QuirksModeIssue::LimitedQuirksMode': 59,

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -81,7 +81,11 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidAttributionSourceEventId:
         return {
           file: 'arInvalidAttributionSourceEventId.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourceeventid-required',
+            linkTitle: 'attributionsourceeventid attribute',
+          }],
         };
       case IssueCode.InvalidAttributionData:
         return {
@@ -101,7 +105,18 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.AttributionSourceUntrustworthyOrigin:
         return {
           file: 'arAttributionSourceUntrustworthyOrigin.md',
-          links: [],
+          links: [
+            {
+              link:
+                  'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributiondestination-required',
+              linkTitle: 'attributiondestination attribute',
+            },
+            {
+              link:
+                  'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionreportto',
+              linkTitle: 'attributionreportto attribute',
+            },
+          ],
         };
       case IssueCode.AttributionUntrustworthyFrameOrigin:
         return {
@@ -126,12 +141,20 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidAttributionSourceExpiry:
         return {
           file: 'arInvalidAttributionSourceExpiry.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionexpiry',
+            linkTitle: 'attributionexpiry attribute',
+          }],
         };
       case IssueCode.InvalidAttributionSourcePriority:
         return {
           file: 'arInvalidAttributionSourcePriority.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourcepriority',
+            linkTitle: 'attributionsourcepriority attribute',
+          }],
         };
       case IssueCode.InvalidEventSourceTriggerData:
         return {
@@ -141,12 +164,20 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidTriggerPriority:
         return {
           file: 'arInvalidTriggerPriority.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#prioritize-specific-conversions',
+            linkTitle: 'Prioritizing specific conversions',
+          }],
         };
       case IssueCode.InvalidTriggerDedupKey:
         return {
           file: 'arInvalidTriggerDedupKey.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#deduplicate-reports',
+            linkTitle: 'Deduplicating reports',
+          }],
         };
     }
   }

package/front_end/panels/animation/animationTimeline.css

@@ -26,7 +26,8 @@
   display: flex;
   flex-direction: column;
   justify-content: space-around;
-  align-items: center;
+  align-items: flex-start;
+  white-space: nowrap;
   flex: 0 0 150px;
 }
 

package/front_end/panels/console/ConsolePrompt.ts

@@ -207,7 +207,14 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
       {key: 'ArrowDown', run: (): boolean => this.moveHistory(1)},
       {mac: 'Ctrl-p', run: (): boolean => this.moveHistory(-1, true)},
       {mac: 'Ctrl-n', run: (): boolean => this.moveHistory(1, true)},
-      {key: 'Enter', run: (): boolean => this.evaluate(), shift: CodeMirror.insertNewlineAndIndent},
+      {
+        key: 'Enter',
+        run: (): boolean => {
+          this.handleEnter();
+          return true;
+        },
+        shift: CodeMirror.insertNewlineAndIndent,
+      },
     ];
   }
 
@@ -242,29 +249,28 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
     return true;
   }
 
-  private enterWillEvaluate(): boolean {
+  private async enterWillEvaluate(): Promise<boolean> {
     const {state} = this.editor;
-    return state.doc.length > 0 && TextEditor.JavaScript.isExpressionComplete(state);
+    return state.doc.length > 0 && await TextEditor.JavaScript.isExpressionComplete(state.doc.toString());
   }
 
-  private evaluate(): boolean {
-    if (this.enterWillEvaluate()) {
+  private async handleEnter(): Promise<void> {
+    if (await this.enterWillEvaluate()) {
       this.appendCommand(this.text(), true);
       this.editor.dispatch({
         changes: {from: 0, to: this.editor.state.doc.length},
         scrollIntoView: true,
       });
     } else if (this.editor.state.doc.length) {
-      return CodeMirror.insertNewlineAndIndent(this.editor.editor);
+      CodeMirror.insertNewlineAndIndent(this.editor.editor);
     } else {
       this.editor.dispatch({scrollIntoView: true});
     }
-    return true;
   }
 
   private updatePromptIcon(): void {
     this.iconThrottler.schedule(async () => {
-      this.promptIcon.classList.toggle('console-prompt-incomplete', !this.enterWillEvaluate());
+      this.promptIcon.classList.toggle('console-prompt-incomplete', !(await this.enterWillEvaluate()));
     });
   }
 

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -106,11 +106,14 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
     const content = oldCondition || '';
     const finishIfComplete = (view: CodeMirror.EditorView): boolean => {
-      if (TextEditor.JavaScript.isExpressionComplete(view.state)) {
-        this.finishEditing(true, this.editor.state.doc.toString());
-        return true;
-      }
-      return false;
+      TextEditor.JavaScript.isExpressionComplete(view.state.doc.toString()).then((complete): void => {
+        if (complete) {
+          this.finishEditing(true, this.editor.state.doc.toString());
+        } else {
+          CodeMirror.insertNewlineAndIndent(view);
+        }
+      });
+      return true;
     };
     const keymap = [
       {

package/front_end/panels/timeline/TimelinePanel.ts

@@ -842,7 +842,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   private recordingFailed(error: string): void {
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1036,7 +1036,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.hideLandingPage();
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1073,7 +1073,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.setState(State.Idle);
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = null;
 
@@ -1405,9 +1405,10 @@ export class StatusPane extends UI.Widget.VBox {
     this.button.disabled = true;
   }
 
-  hide(): void {
+  remove(): void {
     (this.element.parentNode as HTMLElement).classList.remove('tinted');
     this.arrangeDialog((this.element.parentNode as HTMLElement));
+    this.stopTimer();
     this.element.remove();
   }
 

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -27,9 +27,25 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['issueQuirksModeDoctype', 'https://web.dev/doctype/'],
   ['sameSiteAndSameOrigin', 'https://web.dev/same-site-same-origin/'],
+  // Link URLs for deprecation issues (see blink::Deprecation)
+  ['https://xhr.spec.whatwg.org/', 'https://xhr.spec.whatwg.org/'],
+  ['https://goo.gl/rStTGz', 'https://goo.gl/rStTGz'],
+  ['https://webrtc.org/web-apis/chrome/unified-plan/', 'https://webrtc.org/web-apis/chrome/unified-plan/'],
+  [
+    'https://developer.chrome.com/blog/enabling-shared-array-buffer/',
+    'https://developer.chrome.com/blog/enabling-shared-array-buffer/',
+  ],
+  ['https://developer.chrome.com/docs/extensions/mv3/', 'https://developer.chrome.com/docs/extensions/mv3/'],
+  [
+    'https://developer.chrome.com/blog/immutable-document-domain',
+    'https://developer.chrome.com/blog/immutable-document-domain',
+  ],
 ]);
 
 export const getMarkdownLink = (key: string): string => {
+  if (/^https:\/\/www.chromestatus.com\/feature\/\d+$/.test(key)) {
+    return key;
+  }
   const link = markdownLinks.get(key);
   if (!link) {
     throw new Error(`Markdown link with key '${key}' is not available, please check MarkdownLinksMap.ts`);

package/front_end/ui/components/text_editor/javascript.ts

@@ -402,13 +402,22 @@ async function completeExpressionGlobal(): Promise<CompletionSet> {
   return fetchNames;
 }
 
-export function isExpressionComplete(state: CodeMirror.EditorState): boolean {
-  for (const cursor = CodeMirror.syntaxTree(state).cursor(); cursor.next();) {
-    if (cursor.type.isError) {
-      return false;
-    }
-  }
-  return true;
+export async function isExpressionComplete(expression: string): Promise<boolean> {
+  const currentExecutionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
+  if (!currentExecutionContext) {
+    return true;
+  }
+  const result =
+      await currentExecutionContext.runtimeModel.compileScript(expression, '', false, currentExecutionContext.id);
+  if (!result || !result.exceptionDetails || !result.exceptionDetails.exception) {
+    return true;
+  }
+  const description = result.exceptionDetails.exception.description;
+  if (description) {
+    return !description.startsWith('SyntaxError: Unexpected end of input') &&
+        !description.startsWith('SyntaxError: Unterminated template literal');
+  }
+  return false;
 }
 
 export function argumentHints(): CodeMirror.Extension {

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.950001"
+  "version": "1.0.950484"
 }