chrome-devtools-frontend 1.0.948916 → 1.0.949424

package/config/gni/all_devtools_files.gni

@@ -50,6 +50,11 @@ all_devtools_files = [
   "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionData.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md",
+  "front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md",
   "front_end/models/issues_manager/descriptions/arMissingAttributionData.md",
   "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
   "front_end/models/issues_manager/descriptions/CoepCoopSandboxedIframeCannotNavigateToCoopPage.md",

package/config/gni/devtools_grd_files.gni

@@ -274,6 +274,11 @@ grd_files_release_sources = [
   "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionData.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md",
+  "front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md",
   "front_end/models/issues_manager/descriptions/arMissingAttributionData.md",
   "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
   "front_end/models/issues_manager/descriptions/corsAllowCredentialsRequired.md",

package/front_end/core/i18n/locales/en-US.json

@@ -1955,9 +1955,18 @@
   "panels/accessibility/AXBreadcrumbsPane.ts | accessibilityTree": {
     "message": "Accessibility Tree"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentDescription": {
+    "message": "The accessibility tree moved to the top right corner of the DOM tree."
+  },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentName": {
+    "message": "Enable full-page accessibility tree"
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | ignored": {
     "message": "Ignored"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | reloadRequired": {
+    "message": "Reload required before the change takes effect."
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | scrollIntoView": {
     "message": "Scroll into view"
   },
@@ -5189,9 +5198,21 @@
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceEventId": {
     "message": "Invalid attributionsourceeventid"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceExpiry": {
+    "message": "Invalid attributionexpiry"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourcePriority": {
+    "message": "Invalid attributionsourcepriority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerData": {
     "message": "Invalid trigger-data"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerDedupKey": {
+    "message": "Invalid dedup-key"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerPriority": {
+    "message": "Invalid priority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | nViolations": {
     "message": "{n, plural, =1 {# violation} other {# violations}}"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -1955,9 +1955,18 @@
   "panels/accessibility/AXBreadcrumbsPane.ts | accessibilityTree": {
     "message": "Âćĉéŝśîb́îĺît́ŷ T́r̂éê"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentDescription": {
+    "message": "T̂h́ê áĉćêśŝíb̂íl̂ít̂ý t̂ŕêé m̂óv̂éd̂ t́ô t́ĥé t̂óp̂ ŕîǵĥt́ ĉór̂ńêŕ ôf́ t̂h́ê D́ÔḾ t̂ŕêé."
+  },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentName": {
+    "message": "Êńâb́l̂é f̂úl̂ĺ-p̂áĝé âćĉéŝśîb́îĺît́ŷ t́r̂éê"
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | ignored": {
     "message": "Îǵn̂ór̂éd̂"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | reloadRequired": {
+    "message": "R̂él̂óâd́ r̂éq̂úîŕêd́ b̂éf̂ór̂é t̂h́ê ćĥán̂ǵê t́âḱêś êf́f̂éĉt́."
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | scrollIntoView": {
     "message": "Ŝćr̂ól̂ĺ îńt̂ó v̂íêẃ"
   },
@@ -5189,9 +5198,21 @@
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceEventId": {
     "message": "Îńv̂ál̂íd̂ attributionsourceeventid"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceExpiry": {
+    "message": "Îńv̂ál̂íd̂ attributionexpiry"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourcePriority": {
+    "message": "Îńv̂ál̂íd̂ attributionsourcepriority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerData": {
     "message": "Îńv̂ál̂íd̂ trigger-data"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerDedupKey": {
+    "message": "Îńv̂ál̂íd̂ dedup-key"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerPriority": {
+    "message": "Îńv̂ál̂íd̂ priority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | nViolations": {
     "message": "{n, plural, =1 {# v̂íôĺât́îón̂} other {# v́îól̂át̂íôńŝ}}"
   },

package/front_end/core/root/Runtime.ts

@@ -351,6 +351,7 @@ export enum ExperimentName {
   PROTOCOL_MONITOR = 'protocolMonitor',
   WEBAUTHN_PANE = 'webauthnPane',
   SYNC_SETTINGS = 'syncSettings',
+  FULL_ACCESSIBILITY_TREE = 'fullAccessibilityTree',
 }
 
 // TODO(crbug.com/1167717): Make this a const enum again

package/front_end/core/sdk/AccessibilityModel.ts

@@ -291,25 +291,25 @@ export class AccessibilityModel extends SDKModel<EventTypes> implements Protocol
   async requestAXChildren(nodeId: Protocol.Accessibility.AXNodeId, frameId?: Protocol.Page.FrameId):
       Promise<AccessibilityNode[]> {
     const parent = this.#axIdToAXNode.get(nodeId);
-    if (parent && !parent.hasUnloadedChildren()) {
+    if (!parent) {
+      throw Error('Cannot request children before parent');
+    }
+    if (!parent.hasUnloadedChildren()) {
       return parent.children();
     }
 
     let nodes;
     const request = this.#pendingChildRequests.get(nodeId);
     if (request) {
-      nodes = (await request).nodes;
+      await request;
     } else {
       const req = this.agent.invoke_getChildAXNodes({id: nodeId, frameId});
       this.#pendingChildRequests.set(nodeId, req);
       nodes = (await req).nodes;
+      this.createNodesFromPayload(nodes);
       this.#pendingChildRequests.delete(nodeId);
     }
-    if (!nodes) {
-      return [];
-    }
-    const axNodes = this.createNodesFromPayload(nodes);
-    return axNodes;
+    return parent.children();
   }
 
   async requestAndLoadSubTreeToNode(node: DOMNode): Promise<AccessibilityNode[]|null> {

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -124,15 +124,30 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
           links: [],
         };
       case IssueCode.InvalidAttributionSourceExpiry:
-        return null;
+        return {
+          file: 'arInvalidAttributionSourceExpiry.md',
+          links: [],
+        };
       case IssueCode.InvalidAttributionSourcePriority:
-        return null;
+        return {
+          file: 'arInvalidAttributionSourcePriority.md',
+          links: [],
+        };
       case IssueCode.InvalidEventSourceTriggerData:
-        return null;
+        return {
+          file: 'arInvalidEventSourceTriggerData.md',
+          links: [],
+        };
       case IssueCode.InvalidTriggerPriority:
-        return null;
+        return {
+          file: 'arInvalidTriggerPriority.md',
+          links: [],
+        };
       case IssueCode.InvalidTriggerDedupKey:
-        return null;
+        return {
+          file: 'arInvalidTriggerDedupKey.md',
+          links: [],
+        };
     }
   }
 

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md

@@ -0,0 +1,4 @@
+# Ensure attribution source expiry is a valid number
+
+The expiry associated with an attribution source was defaulted to 30 days.
+This happens if the provided value is not a valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md

@@ -0,0 +1,4 @@
+# Ensure attribution source priority is a valid number
+
+The priority associated with an attribution source was defaulted to `0`.
+This happens if the provided value is not a valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md

@@ -0,0 +1,9 @@
+# Ensure the "event-source-trigger-data" query parameter for an attribution redirect is a valid number
+
+The event-source trigger data associated with an attribution was defaulted to `0`.
+This happens if the `event-source-trigger-data` query parameter provided in the `.well-known`
+redirect is not a valid 64-bit unsigned integer.
+
+Note that even if a valid integer is provided, only the lowest 1-bit of the
+`event-source-trigger-data` query parameter is recorded, with a 5% chance of the 1 bit being
+noised.

package/front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md

@@ -0,0 +1,5 @@
+# Ensure the "dedup-key" query parameter for an attribution redirect is a valid number
+
+The dedup key associated with an attribution was defaulted to `null`.
+This happens if the `dedup-key` query parameter provided in the `.well-known` redirect is not a
+valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md

@@ -0,0 +1,5 @@
+# Ensure the "priority" query parameter for an attribution redirect is a valid number
+
+The priority associated with an attribution was defaulted to `0`.
+This happens if the `priority` query parameter provided in the `.well-known` redirect is not a
+valid 64-bit signed integer.

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts

@@ -3,8 +3,11 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
+import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as Feedback from '../../ui/components/panel_feedback/panel_feedback.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import axBreadcrumbsStyles from './axBreadcrumbs.css.js';
@@ -27,6 +30,18 @@ const UIStrings = {
   *@description Ignored node element text content in AXBreadcrumbs Pane of the Accessibility panel
   */
   ignored: 'Ignored',
+  /**
+  *@description Name for experimental tree toggle.
+  */
+  fullTreeExperimentName: 'Enable full-page accessibility tree',
+  /**
+  *@description Description text for experimental tree toggle.
+  */
+  fullTreeExperimentDescription: 'The accessibility tree moved to the top right corner of the DOM tree.',
+  /**
+  *@description Message saying that DevTools must be restarted before the experiment is enabled.
+  */
+  reloadRequired: 'Reload required before the change takes effect.',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/accessibility/AXBreadcrumbsPane.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -37,24 +52,48 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
   private collapsingBreadcrumbId: number;
   private hoveredBreadcrumb: AXBreadcrumb|null;
   private readonly rootElement: HTMLElement;
+  #legacyTreeDisabled = false;
 
   constructor(axSidebarView: AccessibilitySidebarView) {
     super(i18nString(UIStrings.accessibilityTree));
 
     this.element.classList.add('ax-subpane');
-    UI.ARIAUtils.markAsTree(this.element);
     this.element.tabIndex = -1;
 
     this.axSidebarView = axSidebarView;
-
     this.preselectedBreadcrumb = null;
     this.inspectedNodeBreadcrumb = null;
 
     this.collapsingBreadcrumbId = -1;
 
-    this.hoveredBreadcrumb = null;
     this.rootElement = this.element.createChild('div', 'ax-breadcrumbs');
 
+    this.hoveredBreadcrumb = null;
+    const previewToggle = new Feedback.PreviewToggle.PreviewToggle();
+    const name = i18nString(UIStrings.fullTreeExperimentName);
+    const experiment = Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE;
+    const onChangeCallback: (checked: boolean) => void = checked => {
+      Host.userMetrics.experimentChanged(experiment, checked);
+      UI.InspectorView.InspectorView.instance().displayReloadRequiredWarning(i18nString(UIStrings.reloadRequired));
+    };
+    if (Root.Runtime.experiments.isEnabled(experiment)) {
+      this.#legacyTreeDisabled = true;
+      const feedbackURL = 'https://goo.gle/devtools-a11y-tree-feedback';
+      previewToggle.data = {
+        name,
+        helperText: i18nString(UIStrings.fullTreeExperimentDescription),
+        feedbackURL,
+        experiment,
+        onChangeCallback,
+      };
+      this.element.appendChild(previewToggle);
+      return;
+    }
+    previewToggle.data = {name, helperText: null, feedbackURL: null, experiment, onChangeCallback};
+    this.element.prepend(previewToggle);
+
+    UI.ARIAUtils.markAsTree(this.rootElement);
+
     this.rootElement.addEventListener('keydown', this.onKeyDown.bind(this), true);
     this.rootElement.addEventListener('mousemove', this.onMouseMove.bind(this), false);
     this.rootElement.addEventListener('mouseleave', this.onMouseLeave.bind(this), false);
@@ -72,6 +111,9 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
   }
 
   setAXNode(axNode: SDK.AccessibilityModel.AccessibilityNode|null): void {
+    if (this.#legacyTreeDisabled) {
+      return;
+    }
     const hadFocus = this.element.hasFocus();
     super.setAXNode(axNode);
 

package/front_end/panels/accessibility/AccessibilitySidebarView.ts

@@ -31,10 +31,8 @@ export class AccessibilitySidebarView extends UI.ThrottledWidget.ThrottledWidget
     this.axNodeInternal = null;
     this.skipNextPullNode = false;
     this.sidebarPaneStack = UI.ViewManager.ViewManager.instance().createStackLocation();
-    if (!Root.Runtime.experiments.isEnabled('fullAccessibilityTree')) {
-      this.breadcrumbsSubPane = new AXBreadcrumbsPane(this);
-      this.sidebarPaneStack.showView(this.breadcrumbsSubPane);
-    }
+    this.breadcrumbsSubPane = new AXBreadcrumbsPane(this);
+    this.sidebarPaneStack.showView(this.breadcrumbsSubPane);
     this.ariaSubPane = new ARIAAttributesPane();
     this.sidebarPaneStack.showView(this.ariaSubPane);
     this.axNodeSubPane = new AXNodeSubPane();

package/front_end/panels/accessibility/axBreadcrumbs.css

@@ -99,6 +99,10 @@
   background-color: var(--color-background-elevation-0);
 }
 
+.ax-breadcrumbs .ax-node:not(.inspected):focus {
+  background-color: var(--color-background-elevation-1);
+}
+
 .ax-breadcrumbs .ax-node.inspected:focus * {
   color: inherit;
 }

package/front_end/panels/elements/AccessibilityTreeView.ts

@@ -120,16 +120,14 @@ export class AccessibilityTreeView extends UI.Widget.VBox implements
 
   // Selected node in the DOM tree has changed.
   async selectedNodeChanged(inspectedNode: SDK.DOMModel.DOMNode): Promise<void> {
-    if (this.isShowing()) {
+    if (this.isShowing() || (inspectedNode === this.inspectedDOMNode)) {
       return;
     }
     if (inspectedNode.ownerDocument && (inspectedNode.nodeName() === 'HTML' || inspectedNode.nodeName() === 'BODY')) {
-      inspectedNode = inspectedNode.ownerDocument;
+      this.inspectedDOMNode = inspectedNode.ownerDocument;
+    } else {
+      this.inspectedDOMNode = inspectedNode;
     }
-    if (inspectedNode === this.inspectedDOMNode) {
-      return;
-    }
-    this.inspectedDOMNode = inspectedNode;
   }
 
   treeUpdated({data}: Common.EventTarget

package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts

@@ -32,6 +32,16 @@ const UIStrings = {
    * on an anchor HTML element ("a link").
    */
   invalidSourceEventId: 'Invalid `attributionsourceeventid`',
+  /**
+   * @description Label for the column showing the invalid value used as the 'attributionexpiry' attribute
+   * on an anchor HTML element ("a link").
+   */
+  invalidSourceExpiry: 'Invalid `attributionexpiry`',
+  /**
+   * @description Label for the column showing the invalid value used as the 'attributionpriority' attribute
+   * on an anchor HTML element ("a link").
+   */
+  invalidSourcePriority: 'Invalid `attributionsourcepriority`',
   /**
    * @description Label for the column showing the invalid URL used in an HTML anchor element ("a link").
    * A origin is (roughly said) the front part of a URL.
@@ -47,6 +57,16 @@ const UIStrings = {
    * 'event-source-trigger-data' query parameter.
    */
   invalidEventSourceTriggerData: 'Invalid `event-source-trigger-data`',
+  /**
+   * @description Label for the column showing the invalid value used for the
+   * 'priority' query parameter.
+   */
+  invalidTriggerPriority: 'Invalid `priority`',
+  /**
+   * @description Label for the column showing the invalid value used for the
+   * 'dedup-key' query parameter.
+   */
+  invalidTriggerDedupKey: 'Invalid `dedup-key`',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/issues/AttributionReportingIssueDetailsView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -94,15 +114,34 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerData));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEventSourceTriggerData:
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionEventSourceTriggerDataTooLarge:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidEventSourceTriggerData));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerPriority:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerPriority));
+        break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerDedupKey:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerDedupKey));
+        break;
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceEventId:
         this.appendColumnTitle(header, i18nString(UIStrings.frame));
         this.appendColumnTitle(header, i18nString(UIStrings.element));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidSourceEventId));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceExpiry:
+        this.appendColumnTitle(header, i18nString(UIStrings.frame));
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidSourceExpiry));
+        break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourcePriority:
+        this.appendColumnTitle(header, i18nString(UIStrings.frame));
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidSourcePriority));
+        break;
       case IssuesManager.AttributionReportingIssue.IssueCode.MissingAttributionData:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         break;
@@ -144,11 +183,16 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionEventSourceTriggerDataTooLarge:
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionUntrustworthyOrigin:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionData:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEventSourceTriggerData:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerPriority:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerDedupKey:
         this.appendRequestOrEmptyCell(element, details.request);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionSourceUntrustworthyFrameOrigin:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceEventId:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceExpiry:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourcePriority:
         this.appendFrameOrEmptyCell(element, issue);
         await this.appendElementOrEmptyCell(element, issue);
         this.appendIssueDetailCell(element, details.invalidParameter || '');

package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts

@@ -554,6 +554,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
           aria-controls="form-container"
           @disabled=${this.isFormDisabled}
           aria-disabled=${this.isFormDisabled}
+          aria-label=${i18nString(UIStrings.title)}
         >
           <${IconButton.Icon.Icon.litTagName}
             class=${this.isFormOpened ? '' : 'rotate-icon'}