chrome-devtools-frontend 1.0.946351 → 1.0.946920

package/config/gni/all_devtools_files.gni

@@ -10,7 +10,6 @@ all_devtools_files = [
   "front_end/entrypoints/inspector/inspector.js",
   "front_end/entrypoints/js_app/js_app.js",
   "front_end/entrypoints/ndb_app/ndb_app.js",
-  "front_end/entrypoints/node_app/node_app.js",
   "front_end/entrypoints/worker_app/worker_app.js",
   "front_end/legacy_test_runner/accessibility_test_runner/accessibility_test_runner.js",
   "front_end/legacy_test_runner/application_test_runner/application_test_runner.js",
@@ -50,7 +49,6 @@ all_devtools_files = [
   "front_end/legacy_test_runner/layers_test_runner/layers_test_runner.js",
   "front_end/entrypoints/ndb_app/ndb_app.json",
   "front_end/legacy_test_runner/network_test_runner/network_test_runner.js",
-  "front_end/entrypoints/node_main/nodeConnectionsPanel.css",
   "front_end/legacy_test_runner/performance_test_runner/performance_test_runner.js",
   "front_end/legacy_test_runner/performance_test_runner/TimelineDataTestRunner.js",
   "front_end/legacy_test_runner/performance_test_runner/TimelineTestRunner.js",

package/config/gni/devtools_grd_files.gni

@@ -222,10 +222,7 @@ grd_files_release_sources = [
   "front_end/entrypoints/main/main-meta.js",
   "front_end/entrypoints/main/main.js",
   "front_end/entrypoints/ndb_app/ndb_app.js",
-  "front_end/entrypoints/node_app/node_app-meta.js",
   "front_end/entrypoints/node_app/node_app.js",
-  "front_end/entrypoints/node_main/node_main-meta.js",
-  "front_end/entrypoints/node_main/node_main.js",
   "front_end/entrypoints/shell/shell.js",
   "front_end/entrypoints/startup/startup.js",
   "front_end/entrypoints/wasmparser_worker/wasmparser_worker-entrypoint.js",
@@ -653,9 +650,9 @@ grd_files_debug_sources = [
   "front_end/entrypoints/main/ExecutionContextSelector.js",
   "front_end/entrypoints/main/MainImpl.js",
   "front_end/entrypoints/main/SimpleApp.js",
-  "front_end/entrypoints/node_main/NodeConnectionsPanel.js",
-  "front_end/entrypoints/node_main/NodeMain.js",
-  "front_end/entrypoints/node_main/nodeConnectionsPanel.css.js",
+  "front_end/entrypoints/node_app/NodeConnectionsPanel.js",
+  "front_end/entrypoints/node_app/NodeMain.js",
+  "front_end/entrypoints/node_app/nodeConnectionsPanel.css.js",
   "front_end/entrypoints/startup/RuntimeInstantiator.js",
   "front_end/entrypoints/wasmparser_worker/WasmParserWorker.js",
   "front_end/generated/ARIAProperties.js",

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -361,7 +361,6 @@ export enum EnumeratedHistogram {
   ExperimentEnabledAtLaunch = 'DevTools.ExperimentEnabledAtLaunch',
   ExperimentEnabled = 'DevTools.ExperimentEnabled',
   ExperimentDisabled = 'DevTools.ExperimentDisabled',
-  CssEditorOpened = 'DevTools.CssEditorOpened',
   DeveloperResourceLoaded = 'DevTools.DeveloperResourceLoaded',
   DeveloperResourceScheme = 'DevTools.DeveloperResourceScheme',
   LinearMemoryInspectorRevealedFrom = 'DevTools.LinearMemoryInspector.RevealedFrom',

package/front_end/core/host/UserMetrics.ts

@@ -164,18 +164,6 @@ export class UserMetrics {
         EnumeratedHistogram.DualScreenDeviceEmulated, emulationAction, size);
   }
 
-  cssEditorOpened(editorName: string): void {
-    const size = Object.keys(CssEditorOpened).length + 1;
-    const key = editorName;
-    const value = CssEditorOpened[key];
-
-    if (value === undefined) {
-      return;
-    }
-
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.CssEditorOpened, value, size);
-  }
-
   experimentEnabledAtLaunch(experimentId: string): void {
     const size = DevtoolsExperiments['__lastValidEnumPosition'] + 1;
     const experiment = DevtoolsExperiments[experimentId];
@@ -557,15 +545,6 @@ export enum DualScreenDeviceEmulated {
   PlatformSupportUsed = 2,  // user starts to use platform dual screen support feature.
 }
 
-export const CssEditorOpened: {
-  [x: string]: number,
-} = {
-  'colorPicker': 0,
-  'shadowEditor': 1,
-  'bezierEditor': 2,
-  'fontEditor': 3,
-};
-
 /**
  * This list should contain the currently active Devtools Experiments.
  * Therefore, it is possible that the id's will no longer be continuous

package/front_end/core/i18n/locales/en-US.json

@@ -1208,40 +1208,40 @@
   "entrypoints/main/MainImpl.ts | undockIntoSeparateWindow": {
     "message": "Undock into separate window"
   },
-  "entrypoints/node_app/node_app-meta.ts | node": {
-    "message": "Node"
+  "entrypoints/node_app/node_app.ts | connection": {
+    "message": "Connection"
   },
-  "entrypoints/node_app/node_app-meta.ts | showNode": {
+  "entrypoints/node_app/node_app.ts | networkTitle": {
     "message": "Node"
   },
-  "entrypoints/node_main/node_main-meta.ts | connection": {
-    "message": "Connection"
-  },
-  "entrypoints/node_main/node_main-meta.ts | node": {
+  "entrypoints/node_app/node_app.ts | node": {
     "message": "node"
   },
-  "entrypoints/node_main/node_main-meta.ts | showConnection": {
+  "entrypoints/node_app/node_app.ts | showConnection": {
     "message": "Show Connection"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | addConnection": {
+  "entrypoints/node_app/node_app.ts | showNode": {
+    "message": "Node"
+  },
+  "entrypoints/node_app/NodeConnectionsPanel.ts | addConnection": {
     "message": "Add connection"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | networkAddressEgLocalhost": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | networkAddressEgLocalhost": {
     "message": "Network address (e.g. localhost:9229)"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | noConnectionsSpecified": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | noConnectionsSpecified": {
     "message": "No connections specified"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | nodejsDebuggingGuide": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | nodejsDebuggingGuide": {
     "message": "Node.js debugging guide"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | specifyNetworkEndpointAnd": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | specifyNetworkEndpointAnd": {
     "message": "Specify network endpoint and DevTools will connect to it automatically. Read {PH1} to learn more."
   },
-  "entrypoints/node_main/NodeMain.ts | main": {
+  "entrypoints/node_app/NodeMain.ts | main": {
     "message": "Main"
   },
-  "entrypoints/node_main/NodeMain.ts | nodejsS": {
+  "entrypoints/node_app/NodeMain.ts | nodejsS": {
     "message": "Node.js: {PH1}"
   },
   "entrypoints/worker_app/WorkerMain.ts | main": {
@@ -12065,6 +12065,12 @@
   "ui/legacy/InspectorView.ts | drawer": {
     "message": "Tool drawer"
   },
+  "ui/legacy/InspectorView.ts | drawerHidden": {
+    "message": "Drawer hidden"
+  },
+  "ui/legacy/InspectorView.ts | drawerShown": {
+    "message": "Drawer shown"
+  },
   "ui/legacy/InspectorView.ts | mainToolbar": {
     "message": "Main toolbar"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -1208,40 +1208,40 @@
   "entrypoints/main/MainImpl.ts | undockIntoSeparateWindow": {
     "message": "Ûńd̂óĉḱ îńt̂ó ŝép̂ár̂át̂é ŵín̂d́ôẃ"
   },
-  "entrypoints/node_app/node_app-meta.ts | node": {
-    "message": "N̂ód̂é"
+  "entrypoints/node_app/node_app.ts | connection": {
+    "message": "Ĉón̂ńêćt̂íôń"
   },
-  "entrypoints/node_app/node_app-meta.ts | showNode": {
+  "entrypoints/node_app/node_app.ts | networkTitle": {
     "message": "N̂ód̂é"
   },
-  "entrypoints/node_main/node_main-meta.ts | connection": {
-    "message": "Ĉón̂ńêćt̂íôń"
-  },
-  "entrypoints/node_main/node_main-meta.ts | node": {
+  "entrypoints/node_app/node_app.ts | node": {
     "message": "n̂ód̂é"
   },
-  "entrypoints/node_main/node_main-meta.ts | showConnection": {
+  "entrypoints/node_app/node_app.ts | showConnection": {
     "message": "Ŝh́ôẃ Ĉón̂ńêćt̂íôń"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | addConnection": {
+  "entrypoints/node_app/node_app.ts | showNode": {
+    "message": "N̂ód̂é"
+  },
+  "entrypoints/node_app/NodeConnectionsPanel.ts | addConnection": {
     "message": "Âd́d̂ ćôńn̂éĉt́îón̂"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | networkAddressEgLocalhost": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | networkAddressEgLocalhost": {
     "message": "N̂ét̂ẃôŕk̂ ád̂d́r̂éŝś (ê.ǵ. l̂óĉál̂h́ôśt̂:9229)"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | noConnectionsSpecified": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | noConnectionsSpecified": {
     "message": "N̂ó ĉón̂ńêćt̂íôńŝ śp̂éĉíf̂íêd́"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | nodejsDebuggingGuide": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | nodejsDebuggingGuide": {
     "message": "N̂ód̂é.ĵś d̂éb̂úĝǵîńĝ ǵûíd̂é"
   },
-  "entrypoints/node_main/NodeConnectionsPanel.ts | specifyNetworkEndpointAnd": {
+  "entrypoints/node_app/NodeConnectionsPanel.ts | specifyNetworkEndpointAnd": {
     "message": "Ŝṕêćîf́ŷ ńêt́ŵór̂ḱ êńd̂ṕôín̂t́ âńd̂ D́êv́T̂óôĺŝ ẃîĺl̂ ćôńn̂éĉt́ t̂ó ît́ âút̂óm̂át̂íĉál̂ĺŷ. Ŕêád̂ {PH1} t́ô ĺêár̂ń m̂ór̂é."
   },
-  "entrypoints/node_main/NodeMain.ts | main": {
+  "entrypoints/node_app/NodeMain.ts | main": {
     "message": "M̂áîń"
   },
-  "entrypoints/node_main/NodeMain.ts | nodejsS": {
+  "entrypoints/node_app/NodeMain.ts | nodejsS": {
     "message": "N̂ód̂é.ĵś: {PH1}"
   },
   "entrypoints/worker_app/WorkerMain.ts | main": {
@@ -12065,6 +12065,12 @@
   "ui/legacy/InspectorView.ts | drawer": {
     "message": "T̂óôĺ d̂ŕâẃêŕ"
   },
+  "ui/legacy/InspectorView.ts | drawerHidden": {
+    "message": "D̂ŕâẃêŕ ĥíd̂d́êń"
+  },
+  "ui/legacy/InspectorView.ts | drawerShown": {
+    "message": "D̂ŕâẃêŕ ŝh́ôẃn̂"
+  },
   "ui/legacy/InspectorView.ts | mainToolbar": {
     "message": "M̂áîń t̂óôĺb̂ár̂"
   },

package/front_end/devtools_compatibility.js

@@ -389,7 +389,6 @@
     ExperimentEnabledAtLaunch: 'DevTools.ExperimentEnabledAtLaunch',
     ExperimentEnabled: 'DevTools.ExperimentEnabled',
     ExperimentDisabled: 'DevTools.ExperimentDisabled',
-    CssEditorOpened: 'DevTools.CssEditorOpened',
     DeveloperResourceLoaded: 'DevTools.DeveloperResourceLoaded',
     DeveloperResourceScheme: 'DevTools.DeveloperResourceScheme',
     LinearMemoryInspectorRevealedFrom: 'DevTools.LinearMemoryInspector.RevealedFrom',
@@ -401,6 +400,7 @@
     RecordingReplayFinished: 'DevTools.RecordingReplayFinished',
     RecordingReplayStarted: 'DevTools.RecordingReplayStarted',
     RecordingToggled: 'DevTools.RecordingToggled',
+    SyncSetting: 'DevTools.SyncSetting',
   };
 
   /**

package/front_end/entrypoints/{node_main → node_app}/NodeConnectionsPanel.ts

@@ -32,7 +32,7 @@ const UIStrings = {
   */
   networkAddressEgLocalhost: 'Network address (e.g. localhost:9229)',
 };
-const str_ = i18n.i18n.registerUIStrings('entrypoints/node_main/NodeConnectionsPanel.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeConnectionsPanel.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 let nodeConnectionsPanelInstance: NodeConnectionsPanel;

package/front_end/entrypoints/{node_main → node_app}/NodeMain.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Common from '../../core/common/common.js';
+import type * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
@@ -23,7 +23,7 @@ const UIStrings = {
   */
   nodejsS: 'Node.js: {PH1}',
 };
-const str_ = i18n.i18n.registerUIStrings('entrypoints/node_main/NodeMain.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeMain.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 let nodeMainImplInstance: NodeMainImpl;
 
@@ -45,8 +45,6 @@ export class NodeMainImpl implements Common.Runnable.Runnable {
   }
 }
 
-Common.Runnable.registerEarlyInitializationRunnable(NodeMainImpl.instance);
-
 export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implements ProtocolProxyApi.TargetDispatcher {
   private readonly targetManager: SDK.TargetManager.TargetManager;
   private readonly parentTarget: SDK.Target.Target;

package/front_end/entrypoints/node_app/node_app.ts

@@ -0,0 +1,81 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+import '../shell/shell.js';
+import '../../panels/js_profiler/js_profiler-meta.js';
+import type * as Sources from '../../panels/sources/sources.js';
+import * as i18n from '../../core/i18n/i18n.js';
+import * as UI from '../../ui/legacy/legacy.js';
+import * as Common from '../../core/common/common.js';
+import * as Root from '../../core/root/root.js';
+import * as Main from '../main/main.js';
+
+import {NodeMainImpl} from './NodeMain.js';                      // eslint-disable-line rulesdir/es_modules_import
+import {NodeConnectionsPanel} from './NodeConnectionsPanel.js';  // eslint-disable-line rulesdir/es_modules_import
+
+const UIStrings = {
+  /**
+  *@description Text that refers to the network connection
+  */
+  connection: 'Connection',
+  /**
+ *@description A tag of Node.js Connection Panel that can be searched in the command menu
+ */
+  node: 'node',
+  /**
+   *@description Command for showing the Connection tool
+   */
+  showConnection: 'Show Connection',
+  /**
+   *@description Title of the 'Node' tool in the Network Navigator View, which is part of the Sources tool
+  */
+  networkTitle: 'Node',
+  /**
+   *@description Command for showing the 'Node' tool in the Network Navigator View, which is part of the Sources tool
+  */
+  showNode: 'Node',
+};
+
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/node_app.ts', UIStrings);
+const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
+
+let loadedSourcesModule: (typeof Sources|undefined);
+
+async function loadSourcesModule(): Promise<typeof Sources> {
+  if (!loadedSourcesModule) {
+    loadedSourcesModule = await import('../../panels/sources/sources.js');
+  }
+  return loadedSourcesModule;
+}
+
+UI.ViewManager.registerViewExtension({
+  location: UI.ViewManager.ViewLocationValues.PANEL,
+  id: 'node-connection',
+  title: i18nLazyString(UIStrings.connection),
+  commandPrompt: i18nLazyString(UIStrings.showConnection),
+  order: 0,
+  async loadView() {
+    return NodeConnectionsPanel.instance();
+  },
+  tags: [i18nLazyString(UIStrings.node)],
+});
+
+UI.ViewManager.registerViewExtension({
+  location: UI.ViewManager.ViewLocationValues.NAVIGATOR_VIEW,
+  id: 'navigator-network',
+  title: i18nLazyString(UIStrings.networkTitle),
+  commandPrompt: i18nLazyString(UIStrings.showNode),
+  order: 2,
+  persistence: UI.ViewManager.ViewPersistence.PERMANENT,
+  async loadView() {
+    const Sources = await loadSourcesModule();
+    return Sources.SourcesNavigator.NetworkNavigatorView.instance();
+  },
+});
+
+const runtimeInstance = Root.Runtime.Runtime.instance({forceNew: true, moduleDescriptors: []});
+// @ts-ignore Exposed for legacy layout tests
+self.runtime = runtimeInstance;
+Common.Runnable.registerEarlyInitializationRunnable(NodeMainImpl.instance);
+new Main.MainImpl.MainImpl();
+Root.Runtime.appStartedPromiseCallback();

package/front_end/panels/elements/ColorSwatchPopoverIcon.ts

@@ -3,9 +3,7 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import * as ColorPicker from '../../ui/legacy/components/color_picker/color_picker.js';
 import * as InlineEditor from '../../ui/legacy/components/inline_editor/inline_editor.js';
@@ -55,9 +53,6 @@ export class BezierPopoverIcon {
   }
 
   private iconClick(event: Event): void {
-    if (Root.Runtime.experiments.isEnabled('fontEditor')) {
-      Host.userMetrics.cssEditorOpened('bezierEditor');
-    }
     event.consume(true);
     if (this.swatchPopoverHelper.isShowing()) {
       this.swatchPopoverHelper.hide(true);
@@ -163,9 +158,6 @@ export class ColorSwatchPopoverIcon {
   }
 
   private iconClick(event: Event): void {
-    if (Root.Runtime.experiments.isEnabled('fontEditor')) {
-      Host.userMetrics.cssEditorOpened('colorPicker');
-    }
     event.consume(true);
     this.showPopover();
   }
@@ -278,9 +270,6 @@ export class ShadowSwatchPopoverHelper {
   }
 
   private iconClick(event: Event): void {
-    if (Root.Runtime.experiments.isEnabled('fontEditor')) {
-      Host.userMetrics.cssEditorOpened('shadowEditor');
-    }
     event.consume(true);
     this.showPopover();
   }

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -1616,7 +1616,6 @@ export class StylePropertiesSection {
 
   private onFontEditorButtonClicked(): void {
     if (this.fontEditorSectionManager && this.fontEditorButton) {
-      Host.userMetrics.cssEditorOpened('fontEditor');
       this.fontEditorSectionManager.showPopover(this.fontEditorButton.element, this.parentPane);
     }
   }

package/front_end/panels/emulation/DeviceModeToolbar.ts

@@ -225,10 +225,6 @@ export class DeviceModeToolbar {
       showMediaInspectorSetting: Common.Settings.Setting<boolean>,
       showRulersSetting: Common.Settings.Setting<boolean>) {
     this.model = model;
-    const device = model.device();
-    if (device) {
-      this.recordDeviceChange(device, null);
-    }
     this.showMediaInspectorSetting = showMediaInspectorSetting;
     this.showRulersSetting = showRulersSetting;
 
@@ -302,16 +298,6 @@ export class DeviceModeToolbar {
     }
   }
 
-  private recordDeviceChange(
-      device: EmulationModel.EmulatedDevices.EmulatedDevice,
-      oldDevice: EmulationModel.EmulatedDevices.EmulatedDevice|null): void {
-    if (device !== oldDevice && device && device.isDualScreen) {
-      // When we start emulating a device, whether we start a new emulation session, or switch to
-      // a new device, if the device is dual screen, we count this once.
-      Host.userMetrics.dualScreenDeviceEmulated(Host.UserMetrics.DualScreenDeviceEmulated.DualScreenDeviceSelected);
-    }
-  }
-
   private createEmptyToolbarElement(): Element {
     const element = document.createElement('div');
     element.classList.add('device-mode-empty-toolbar-element');
@@ -527,7 +513,6 @@ export class DeviceModeToolbar {
 
   private emulateDevice(device: EmulationModel.EmulatedDevices.EmulatedDevice): void {
     const scale = this.autoAdjustScaleSetting.get() ? undefined : this.model.scaleSetting().get();
-    this.recordDeviceChange(device, this.model.device());
     this.model.emulate(
         EmulationModel.DeviceModeModel.Type.Device, device, this.lastMode.get(device) || device.modes[0], scale);
   }
@@ -615,7 +600,6 @@ export class DeviceModeToolbar {
       return;
     }
 
-    Host.userMetrics.dualScreenDeviceEmulated(Host.UserMetrics.DualScreenDeviceEmulated.SpanButtonClicked);
     const scale = this.autoAdjustScaleSetting.get() ? undefined : this.model.scaleSetting().get();
     const mode = this.model.mode();
     if (!mode) {

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -1302,7 +1302,7 @@ export class DebuggerPlugin extends Plugin {
           Bindings.ResourceScriptMapping.ResourceScriptFile.Events.DidMergeToVM, this.didMergeToVM, this);
       oldScriptFile.removeEventListener(
           Bindings.ResourceScriptMapping.ResourceScriptFile.Events.DidDivergeFromVM, this.didDivergeFromVM, this);
-      if (this.muted && !this.uiSourceCode.isDirty() && this.consistentScripts) {
+      if (this.muted && !this.uiSourceCode.isDirty() && this.consistentScripts()) {
         this.setMuted(false);
       }
     }

package/front_end/panels/timeline/TimelineTreeView.ts

@@ -651,6 +651,7 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
     }
     const cell = this.createTD(columnId);
     cell.className = 'numeric-column';
+    cell.setAttribute('title', i18nString(UIStrings.fms, {PH1: value.toFixed(4)}));
     const textDiv = cell.createChild('div');
     textDiv.createChild('span').textContent = i18nString(UIStrings.fms, {PH1: value.toFixed(1)});