chrome-devtools-frontend 1.0.944903 → 1.0.945884

package/front_end/ui/legacy/InspectorView.ts

@@ -471,7 +471,7 @@ function createLocaleInfobar(): Infobar {
   // @ts-ignore TODO(crbug.com/1163928) Wait for Intl support.
   const locale = new Intl.Locale(closestSupportedLocale);
   const closestSupportedLanguageInCurrentLocale =
-      new Intl.DisplayNames([devtoolsLocale.locale], {type: 'language'}).of(locale.language);
+      new Intl.DisplayNames([devtoolsLocale.locale], {type: 'language'}).of(locale.language || 'en');
 
   const languageSetting = Common.Settings.Settings.instance().moduleSetting<string>('language');
   return new Infobar(

package/front_end/ui/legacy/ListWidget.ts

@@ -276,10 +276,10 @@ export class Editor<T> {
     this.element = document.createElement('div');
     this.element.classList.add('editor-container');
     this.element.addEventListener('keydown', onKeyDown.bind(null, isEscKey, this.cancelClicked.bind(this)), false);
-    this.element.addEventListener(
-        'keydown', onKeyDown.bind(null, event => event.key === 'Enter', this.commitClicked.bind(this)), false);
 
     this.contentElementInternal = this.element.createChild('div', 'editor-content');
+    this.contentElementInternal.addEventListener(
+        'keydown', onKeyDown.bind(null, event => event.key === 'Enter', this.commitClicked.bind(this)), false);
 
     const buttonsRow = this.element.createChild('div', 'editor-buttons');
     this.commitButton = createTextButton('', this.commitClicked.bind(this), '', true /* primary */);

package/front_end/ui/legacy/tabbedPane.css

@@ -134,7 +134,7 @@
 .tabbed-pane-header-tab:hover,
 .tabbed-pane-shadow .tabbed-pane-header-tab:focus-visible {
   color: var(--color-text-primary);
-  background-color: var(--legacy-toolbar-hover-bg-color);
+  background-color: var(--color-background-elevation-1);
 }
 
 .tabbed-pane-header-tab-title {

package/inspector_overlay/main.ts

@@ -77,6 +77,7 @@ let platformName: PlatformName;
 type MessageLookup = {
   'setOverlay': keyof Overlays,
   'setPlatform': PlatformName,
+  drawingFinished: '',
 };
 
 const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLookup[K]]) => {
@@ -95,6 +96,8 @@ const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLooku
     }
   } else if (functionName === 'setPlatform') {
     platformName = message[1];
+  } else if (functionName === 'drawingFinished') {
+    // TODO The logic needs to be added here once the backend starts sending this event.
   } else {
     currentOverlay.dispatch(message);
   }

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.944903"
+  "version": "1.0.945884"
 }

package/scripts/eslint_rules/lib/l10n_filename_matches.js

@@ -5,8 +5,9 @@
 'use strict';
 
 const path = require('path');
+const {devtoolsRootPath} = require('../../devtools_paths.js');
 
-const FRONT_END_DIRECTORY = path.join(__dirname, '..', '..', '..', 'front_end');
+const DEFAULT_FRONT_END_DIRECTORY = path.join(devtoolsRootPath(), 'front_end');
 
 function isModuleScope(context) {
   return context.getScope().type === 'module';
@@ -36,7 +37,15 @@ module.exports = {
       category: 'Possible Errors',
     },
     fixable: 'code',
-    schema: []  // no options
+    schema: [{
+      'type': 'object',
+      'properties': {
+        'rootFrontendDirectory': {
+          'type': 'string',
+        },
+      },
+      additionalProperties: false,
+    }]
   },
   create: function(context) {
     return {
@@ -51,8 +60,12 @@ module.exports = {
           return;
         }
 
+        let frontEndDirectory = DEFAULT_FRONT_END_DIRECTORY;
+        if (context.options && context.options[0]?.rootFrontendDirectory) {
+          frontEndDirectory = context.options[0].rootFrontendDirectory;
+        }
         const currentSourceFile = path.resolve(context.getFilename());
-        const currentFileRelativeToFrontEnd = path.relative(FRONT_END_DIRECTORY, currentSourceFile);
+        const currentFileRelativeToFrontEnd = path.relative(frontEndDirectory, currentSourceFile);
 
         const currentModuleDirectory = path.dirname(currentSourceFile);
         const allowedPathArguments = [
@@ -62,7 +75,7 @@ module.exports = {
         ];
 
         const previousFileLocationArgument = callExpression.arguments[0];
-        const actualPath = path.join(FRONT_END_DIRECTORY, previousFileLocationArgument.value);
+        const actualPath = path.join(frontEndDirectory, previousFileLocationArgument.value);
         if (!allowedPathArguments.includes(actualPath)) {
           const newFileName = currentFileRelativeToFrontEnd.replace(/\\/g, '/');
           context.report({

package/scripts/eslint_rules/tests/l10n_filename_matches_test.js

@@ -4,6 +4,8 @@
 
 'use strict';
 
+const path = require('path');
+
 const rule = require('../lib/l10n_filename_matches.js');
 const ruleTester = new (require('eslint').RuleTester)({
   parserOptions: {ecmaVersion: 9, sourceType: 'module'},
@@ -24,6 +26,16 @@ ruleTester.run('l10n_filename_matches', rule, {
       code: 'const str_ = i18n.i18n.registerUIStrings(\'components/ModuleUIStrings.ts\', UIStrings);',
       filename: 'front_end/components/test.ts',
     },
+    {
+      code: 'const str_ = i18n.i18n.registerUIStrings(\'ModuleUIStrings.ts\', UIStrings);',
+      filename: 'front_end/components/test.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end', 'components')}]
+    },
+    {
+      code: 'const str_ = i18n.i18n.registerUIStrings(\'test.ts\', UIStrings);',
+      filename: 'front_end/components/test.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end', 'components')}]
+    },
   ],
   invalid: [
     {
@@ -35,5 +47,14 @@ ruleTester.run('l10n_filename_matches', rule, {
       }],
       output: 'const str_ = i18n.i18n.registerUIStrings(\'components/test.ts\', UIStrings);',
     },
+    {
+      code: 'const str_ = i18n.i18n.registerUIStrings(\'components/test.ts\', UIStrings);',
+      filename: 'front_end/components/test.ts',
+      errors: [
+        {message: 'First argument to \'registerUIStrings\' call must be \'test.ts\' or the ModuleUIStrings.(js|ts)'}
+      ],
+      output: 'const str_ = i18n.i18n.registerUIStrings(\'test.ts\', UIStrings);',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end', 'components')}]
+    },
   ]
 });