chrome-devtools-frontend 1.0.943182 → 1.0.943709

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -764,6 +764,10 @@ export class TargetBase {
     manager.removeDomainDispatcher(dispatcher);
   }
 
+  registerAccessibilityDispatcher(dispatcher: ProtocolProxyApi.AccessibilityDispatcher): void {
+    this.registerDispatcher('Accessibility', dispatcher);
+  }
+
   registerAnimationDispatcher(dispatcher: ProtocolProxyApi.AnimationDispatcher): void {
     this.registerDispatcher('Animation', dispatcher);
   }

package/front_end/core/sdk/AccessibilityModel.ts

@@ -6,7 +6,6 @@ import type * as Protocol from '../../generated/protocol.js';
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 
 import type {DOMNode} from './DOMModel.js';
-import {DOMModel} from './DOMModel.js';
 import {DeferredDOMNode} from './DOMModel.js';
 import type {Target} from './Target.js';
 import {Capability} from './Target.js';
@@ -39,8 +38,9 @@ export class AccessibilityNode {
   readonly #descriptionInternal: Protocol.Accessibility.AXValue|null;
   readonly #valueInternal: Protocol.Accessibility.AXValue|null;
   readonly #propertiesInternal: Protocol.Accessibility.AXProperty[]|null;
-  #childIds: string[]|null;
-  #parentNodeInternal: AccessibilityNode|null;
+  readonly #parentId: Protocol.Accessibility.AXNodeId|null;
+  readonly #frameId: Protocol.Page.FrameId|null;
+  readonly #childIds: Protocol.Accessibility.AXNodeId[]|null;
 
   constructor(accessibilityModel: AccessibilityModel, payload: Protocol.Accessibility.AXNode) {
     this.#accessibilityModelInternal = accessibilityModel;
@@ -67,7 +67,13 @@ export class AccessibilityNode {
     this.#valueInternal = payload.value || null;
     this.#propertiesInternal = payload.properties || null;
     this.#childIds = payload.childIds || null;
-    this.#parentNodeInternal = null;
+    this.#parentId = payload.parentId || null;
+    if (payload.frameId && !payload.parentId) {
+      this.#frameId = payload.frameId;
+      accessibilityModel.setRootAXNodeForFrameId(payload.frameId, this);
+    } else {
+      this.#frameId = null;
+    }
   }
 
   id(): Protocol.Accessibility.AXNodeId {
@@ -123,11 +129,10 @@ export class AccessibilityNode {
   }
 
   parentNode(): AccessibilityNode|null {
-    return this.#parentNodeInternal;
-  }
-
-  setParentNode(parentNode: AccessibilityNode|null): void {
-    this.#parentNodeInternal = parentNode;
+    if (this.#parentId) {
+      return this.#accessibilityModelInternal.axNodeForId(this.#parentId);
+    }
+    return null;
   }
 
   isDOMNode(): boolean {
@@ -178,38 +183,57 @@ export class AccessibilityNode {
     if (!this.#childIds || !this.#childIds.length) {
       return false;
     }
-
     return this.#childIds.every(id => this.#accessibilityModelInternal.axNodeForId(id) === null);
   }
 
+  hasUnloadedChildren(): boolean {
+    if (!this.#childIds || !this.#childIds.length) {
+      return false;
+    }
+    return this.#childIds.some(id => this.#accessibilityModelInternal.axNodeForId(id) === null);
+  }
   // Only the root node gets a frameId, so nodes have to walk up the tree to find their frameId.
   getFrameId(): Protocol.Page.FrameId|null {
-    const domNode = this.accessibilityModel().domNodeforAXNode(this);
-    if (!domNode) {
-      return null;
-    }
-    return domNode.frameId();
+    return this.#frameId || this.parentNode()?.getFrameId() || null;
   }
 }
 
-export class AccessibilityModel extends SDKModel<void> {
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum Events {
+  TreeUpdated = 'TreeUpdated',
+}
+
+export type EventTypes = {
+  [Events.TreeUpdated]: {root?: AccessibilityNode},
+};
+
+export class AccessibilityModel extends SDKModel<EventTypes> implements ProtocolProxyApi.AccessibilityDispatcher {
   agent: ProtocolProxyApi.AccessibilityApi;
   #axIdToAXNode: Map<string, AccessibilityNode>;
-  readonly #backendDOMNodeIdToAXNode: Map<Protocol.DOM.BackendNodeId, AccessibilityNode>;
-  readonly #backendDOMNodeIdToDOMNode: Map<Protocol.DOM.BackendNodeId, DOMNode|null>;
+  #backendDOMNodeIdToAXNode: Map<Protocol.DOM.BackendNodeId, AccessibilityNode>;
+  #frameIdToAXNode: Map<Protocol.Page.FrameId, AccessibilityNode>;
+  #pendingChildRequests: Map<string, Promise<Protocol.Accessibility.GetChildAXNodesResponse>>;
+  #root: AccessibilityNode|null;
 
   constructor(target: Target) {
     super(target);
+    target.registerAccessibilityDispatcher(this);
     this.agent = target.accessibilityAgent();
     this.resumeModel();
 
     this.#axIdToAXNode = new Map();
     this.#backendDOMNodeIdToAXNode = new Map();
-    this.#backendDOMNodeIdToDOMNode = new Map();
+    this.#frameIdToAXNode = new Map();
+    this.#pendingChildRequests = new Map();
+    this.#root = null;
   }
 
   clear(): void {
+    this.#root = null;
     this.#axIdToAXNode.clear();
+    this.#backendDOMNodeIdToAXNode.clear();
+    this.#frameIdToAXNode.clear();
   }
 
   async resumeModel(): Promise<void> {
@@ -225,60 +249,64 @@ export class AccessibilityModel extends SDKModel<void> {
     if (!nodes) {
       return;
     }
-
+    const axNodes = [];
     for (const payload of nodes) {
-      new AccessibilityNode(this, payload);
+      axNodes.push(new AccessibilityNode(this, payload));
     }
+  }
 
-    for (const axNode of this.#axIdToAXNode.values()) {
-      for (const axChild of axNode.children()) {
-        axChild.setParentNode(axNode);
-      }
-    }
+  loadComplete({root}: Protocol.Accessibility.LoadCompleteEvent): void {
+    this.clear();
+    this.#root = new AccessibilityNode(this, root);
+    this.dispatchEventToListeners(Events.TreeUpdated, {root: this.#root});
   }
 
-  private async pushNodesToFrontend(backendIds: Set<Protocol.DOM.BackendNodeId>): Promise<void> {
-    const domModel = this.target().model(DOMModel);
-    if (!domModel) {
-      return;
-    }
-    const newNodesToTrack = await domModel.pushNodesByBackendIdsToFrontend(backendIds);
-    newNodesToTrack?.forEach((value, key) => this.#backendDOMNodeIdToDOMNode.set(key, value));
+  nodesUpdated({nodes}: Protocol.Accessibility.NodesUpdatedEvent): void {
+    this.createNodesFromPayload(nodes);
+    this.dispatchEventToListeners(Events.TreeUpdated, {});
+    return;
   }
 
   private createNodesFromPayload(payloadNodes: Protocol.Accessibility.AXNode[]): AccessibilityNode[] {
-    const backendIds: Set<Protocol.DOM.BackendNodeId> = new Set();
     const accessibilityNodes = payloadNodes.map(node => {
       const sdkNode = new AccessibilityNode(this, node);
-      const backendId = sdkNode.backendDOMNodeId();
-      if (backendId) {
-        backendIds.add(backendId);
-      }
       return sdkNode;
     });
-    this.pushNodesToFrontend(backendIds);
 
-    for (const sdkNode of accessibilityNodes) {
-      for (const sdkChild of sdkNode.children()) {
-        sdkChild.setParentNode(sdkNode);
-      }
-    }
     return accessibilityNodes;
   }
 
-  async requestRootNode(depth: number = 2, frameId?: Protocol.Page.FrameId): Promise<AccessibilityNode|undefined> {
-    const {nodes} = await this.agent.invoke_getFullAXTree({depth, frameId});
-    if (!nodes) {
+  async requestRootNode(frameId?: Protocol.Page.FrameId): Promise<AccessibilityNode|undefined> {
+    if (frameId && this.#frameIdToAXNode.has(frameId)) {
+      return this.#frameIdToAXNode.get(frameId);
+    }
+    if (!frameId && this.#root) {
+      return this.#root;
+    }
+    const {node} = await this.agent.invoke_getRootAXNode({frameId});
+    if (!node) {
       return;
     }
-    const axNodes = this.createNodesFromPayload(nodes);
-    const root = axNodes[0];
-    return root;
+    return this.createNodesFromPayload([node])[0];
   }
 
   async requestAXChildren(nodeId: Protocol.Accessibility.AXNodeId, frameId?: Protocol.Page.FrameId):
       Promise<AccessibilityNode[]> {
-    const {nodes} = await this.agent.invoke_getChildAXNodes({id: nodeId, frameId});
+    const parent = this.#axIdToAXNode.get(nodeId);
+    if (parent && !parent.hasUnloadedChildren()) {
+      return parent.children();
+    }
+
+    let nodes;
+    const request = this.#pendingChildRequests.get(nodeId);
+    if (request) {
+      nodes = (await request).nodes;
+    } else {
+      const req = this.agent.invoke_getChildAXNodes({id: nodeId, frameId});
+      this.#pendingChildRequests.set(nodeId, req);
+      nodes = (await req).nodes;
+      this.#pendingChildRequests.delete(nodeId);
+    }
     if (!nodes) {
       return [];
     }
@@ -286,36 +314,37 @@ export class AccessibilityModel extends SDKModel<void> {
     return axNodes;
   }
 
-  async requestAndLoadSubTreeToNode(node: DOMNode): Promise<AccessibilityNode|null> {
+  async requestAndLoadSubTreeToNode(node: DOMNode): Promise<AccessibilityNode[]|null> {
     // Node may have already been loaded, so don't bother requesting it again.
-    const loadedAXNode = this.axNodeForDOMNode(node);
-    if (loadedAXNode) {
-      return loadedAXNode;
+    const result = [];
+    let ancestor = this.axNodeForDOMNode(node);
+    while (ancestor) {
+      result.push(ancestor);
+      const parent = ancestor.parentNode();
+      if (!parent) {
+        return result;
+      }
+      ancestor = parent;
     }
-
-    const {nodes} = await this.agent.invoke_getPartialAXTree({nodeId: node.id, fetchRelatives: true});
+    const {nodes} = await this.agent.invoke_getAXNodeAndAncestors({backendNodeId: node.backendNodeId()});
     if (!nodes) {
       return null;
     }
     const ancestors = this.createNodesFromPayload(nodes);
-    // Request top level children nodes.
-    for (const node of ancestors) {
-      await this.requestAXChildren(node.id());
-    }
 
-    return this.axNodeForDOMNode(node);
+    return ancestors;
   }
 
-  async updateSubtreeAndAncestors(backendNodeId: Protocol.DOM.BackendNodeId): Promise<void> {
-    const {nodes} = await this.agent.invoke_getPartialAXTree({backendNodeId, fetchRelatives: true});
-    if (!nodes) {
-      return;
-    }
-    this.createNodesFromPayload(nodes);
+  axNodeForId(axId: Protocol.Accessibility.AXNodeId): AccessibilityNode|null {
+    return this.#axIdToAXNode.get(axId) || null;
   }
 
-  axNodeForId(axId: string): AccessibilityNode|null {
-    return this.#axIdToAXNode.get(axId) || null;
+  setRootAXNodeForFrameId(frameId: Protocol.Page.FrameId, axNode: AccessibilityNode): void {
+    this.#frameIdToAXNode.set(frameId, axNode);
+  }
+
+  axNodeForFrameId(frameId: Protocol.Page.FrameId): AccessibilityNode|null {
+    return this.#frameIdToAXNode.get(frameId) ?? null;
   }
 
   setAXNodeForAXId(axId: string, axNode: AccessibilityNode): void {
@@ -329,14 +358,6 @@ export class AccessibilityModel extends SDKModel<void> {
     return this.#backendDOMNodeIdToAXNode.get(domNode.backendNodeId()) ?? null;
   }
 
-  domNodeforAXNode(axNode: AccessibilityNode): DOMNode|null {
-    const backendDOMNodeId = axNode.backendDOMNodeId();
-    if (!backendDOMNodeId) {
-      return null;
-    }
-    return this.#backendDOMNodeIdToDOMNode.get(backendDOMNodeId) ?? null;
-  }
-
   setAXNodeForBackendDOMNodeId(backendDOMNodeId: Protocol.DOM.BackendNodeId, axNode: AccessibilityNode): void {
     this.#backendDOMNodeIdToAXNode.set(backendDOMNodeId, axNode);
   }

package/front_end/core/sdk/NetworkManager.ts

@@ -1044,6 +1044,9 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     this.#manager.dispatchEventToListeners(Events.ReportingApiReportUpdated, data.report);
   }
 
+  reportingApiEndpointsChangedForOrigin(_data: Protocol.Network.ReportingApiEndpointsChangedForOriginEvent): void {
+  }
+
   /**
    * @deprecated
    * This method is only kept for usage in a web test.

package/front_end/core/sdk/ServiceWorkerCacheModel.ts

@@ -25,13 +25,17 @@ const str_ = i18n.i18n.registerUIStrings('core/sdk/ServiceWorkerCacheModel.ts',
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class ServiceWorkerCacheModel extends SDKModel<EventTypes> implements ProtocolProxyApi.StorageDispatcher {
-  readonly #cachesInternal: Map<string, Cache>;
   readonly cacheAgent: ProtocolProxyApi.CacheStorageApi;
   readonly #storageAgent: ProtocolProxyApi.StorageApi;
   readonly #securityOriginManager: SecurityOriginManager;
-  readonly #originsUpdated: Set<string>;
-  readonly #throttler: Common.Throttler.Throttler;
-  #enabled: boolean;
+
+  readonly #cachesInternal = new Map<string, Cache>();
+  readonly #originsUpdated = new Set<string>();
+  readonly #throttler = new Common.Throttler.Throttler(2000);
+  #enabled = false;
+
+  // Used by tests to remove the Throttler timeout.
+  #scheduleAsSoonAsPossible = false;
 
   /**
    * Invariant: This #model can only be constructed on a ServiceWorker target.
@@ -40,16 +44,9 @@ export class ServiceWorkerCacheModel extends SDKModel<EventTypes> implements Pro
     super(target);
     target.registerStorageDispatcher(this);
 
-    this.#cachesInternal = new Map();
-
     this.cacheAgent = target.cacheStorageAgent();
     this.#storageAgent = target.storageAgent();
     this.#securityOriginManager = (target.model(SecurityOriginManager) as SecurityOriginManager);
-
-    this.#originsUpdated = new Set();
-    this.#throttler = new Common.Throttler.Throttler(2000);
-
-    this.#enabled = false;
   }
 
   enable(): void {
@@ -240,7 +237,7 @@ export class ServiceWorkerCacheModel extends SDKModel<EventTypes> implements Pro
       const promises = Array.from(this.#originsUpdated, origin => this.loadCacheNames(origin));
       this.#originsUpdated.clear();
       return Promise.all(promises);
-    });
+    }, this.#scheduleAsSoonAsPossible);
   }
 
   cacheStorageContentUpdated({origin, cacheName}: Protocol.Storage.CacheStorageContentUpdatedEvent): void {
@@ -252,6 +249,10 @@ export class ServiceWorkerCacheModel extends SDKModel<EventTypes> implements Pro
 
   indexedDBContentUpdated(_event: Protocol.Storage.IndexedDBContentUpdatedEvent): void {
   }
+
+  setThrottlerSchedulesAsSoonAsPossibleForTest(): void {
+    this.#scheduleAsSoonAsPossible = true;
+  }
 }
 
 // TODO(crbug.com/1167717): Make this a const enum again

package/front_end/entrypoints/main/MainImpl.ts

@@ -299,8 +299,8 @@ export class MainImpl {
         'keyboardShortcutEditor', 'Enable keyboard shortcut editor', true,
         'https://developer.chrome.com/blog/new-in-devtools-88/#keyboard-shortcuts');
 
-    // Back-Forward Cache
-    Root.Runtime.experiments.register('bfcacheDebugging', 'Enable Back-Forward Cache debugging support');
+    // Back/forward cache
+    Root.Runtime.experiments.register('bfcacheDebugging', 'Enable back/forward cache debugging support');
 
     // Timeline
     Root.Runtime.experiments.register('timelineEventInitiators', 'Timeline: event initiators');

package/front_end/generated/InspectorBackendCommands.js

@@ -1700,6 +1700,7 @@ export function registerCommands(inspectorBackend) {
       ['innerRequestId', 'innerRequestURL', 'errorMessage', 'bundleRequestId']);
   inspectorBackend.registerEvent('Network.reportingApiReportAdded', ['report']);
   inspectorBackend.registerEvent('Network.reportingApiReportUpdated', ['report']);
+  inspectorBackend.registerEvent('Network.reportingApiEndpointsChangedForOrigin', ['origin', 'endpoints']);
   inspectorBackend.registerCommand(
       'Network.setAcceptedEncodings', [{'name': 'encodings', 'type': 'object', 'optional': false}], []);
   inspectorBackend.registerCommand('Network.clearAcceptedEncodingsOverride', [], []);
@@ -1791,7 +1792,8 @@ export function registerCommands(inspectorBackend) {
         {'name': 'priority', 'type': 'string', 'optional': true},
         {'name': 'sameParty', 'type': 'boolean', 'optional': true},
         {'name': 'sourceScheme', 'type': 'string', 'optional': true},
-        {'name': 'sourcePort', 'type': 'number', 'optional': true}
+        {'name': 'sourcePort', 'type': 'number', 'optional': true},
+        {'name': 'partitionKey', 'type': 'string', 'optional': true}
       ],
       ['success']);
   inspectorBackend.registerCommand(

package/front_end/generated/protocol-mapping.d.ts

@@ -305,6 +305,7 @@ export namespace ProtocolMapping {
      */
     'Network.reportingApiReportAdded': [Protocol.Network.ReportingApiReportAddedEvent];
     'Network.reportingApiReportUpdated': [Protocol.Network.ReportingApiReportUpdatedEvent];
+    'Network.reportingApiEndpointsChangedForOrigin': [Protocol.Network.ReportingApiEndpointsChangedForOriginEvent];
     /**
      * Fired when the node should be inspected. This happens after call to `setInspectMode` or when
      * user manually inspects an element.

package/front_end/generated/protocol-proxy-api.d.ts

@@ -2182,6 +2182,8 @@ declare namespace ProtocolProxyApi {
     reportingApiReportAdded(params: Protocol.Network.ReportingApiReportAddedEvent): void;
 
     reportingApiReportUpdated(params: Protocol.Network.ReportingApiReportUpdatedEvent): void;
+
+    reportingApiEndpointsChangedForOrigin(params: Protocol.Network.ReportingApiEndpointsChangedForOriginEvent): void;
   }
 
   export interface OverlayApi {

package/front_end/generated/protocol.d.ts

@@ -7513,6 +7513,15 @@ declare namespace Protocol {
        * This is a temporary ability and it will be removed in the future.
        */
       sourcePort: integer;
+      /**
+       * Cookie partition key. The site of the top-level URL the browser was visiting at the start
+       * of the request to the endpoint that set the cookie.
+       */
+      partitionKey?: string;
+      /**
+       * True if cookie partition key is opaque.
+       */
+      partitionKeyOpaque?: boolean;
     }
 
     /**
@@ -7653,6 +7662,12 @@ declare namespace Protocol {
        * This is a temporary ability and it will be removed in the future.
        */
       sourcePort?: integer;
+      /**
+       * Cookie partition key. The site of the top-level URL the browser was visiting at the start
+       * of the request to the endpoint that set the cookie.
+       * If not set, the cookie will be set as not partitioned.
+       */
+      partitionKey?: string;
     }
 
     export const enum AuthChallengeSource {
@@ -7976,6 +7991,17 @@ declare namespace Protocol {
       status: ReportStatus;
     }
 
+    export interface ReportingApiEndpoint {
+      /**
+       * The URL of the endpoint to which reports may be delivered.
+       */
+      url: string;
+      /**
+       * Name of the endpoint group.
+       */
+      groupName: string;
+    }
+
     /**
      * An object providing the result of a network resource load.
      */
@@ -8332,6 +8358,12 @@ declare namespace Protocol {
        * This is a temporary ability and it will be removed in the future.
        */
       sourcePort?: integer;
+      /**
+       * Cookie partition key. The site of the top-level URL the browser was visiting at the start
+       * of the request to the endpoint that set the cookie.
+       * If not set, the cookie will be set as not partitioned.
+       */
+      partitionKey?: string;
     }
 
     export interface SetCookieResponse extends ProtocolResponseWithError {
@@ -9098,6 +9130,14 @@ declare namespace Protocol {
     export interface ReportingApiReportUpdatedEvent {
       report: ReportingApiReport;
     }
+
+    export interface ReportingApiEndpointsChangedForOriginEvent {
+      /**
+       * Origin of the document(s) which configured the endpoints.
+       */
+      origin: string;
+      endpoints: ReportingApiEndpoint[];
+    }
   }
 
   /**

package/front_end/panels/application/ApplicationPanelCacheSection.ts

@@ -20,7 +20,7 @@ const UIStrings = {
   /**
   *@description Text in Application Panel Sidebar of the Application panel
   */
-  backForwardCache: 'Back-Forward Cache',
+  backForwardCache: 'Back/forward cache',
   /**
   *@description A context menu item in the Application Panel Sidebar of the Application panel
   */

package/front_end/panels/application/BackForwardCacheView.ts

@@ -17,67 +17,67 @@ import backForwardCacheViewStyles from './backForwardCacheView.css.js';
 
 const UIStrings = {
   /**
-   * @description Title text in Back-Forward Cache view of the Application panel
+   * @description Title text in back/forward cache view of the Application panel
    */
   mainFrame: 'Main Frame',
   /**
-   * @description Title text in Back-Forward Cache view of the Application panel
+   * @description Title text in back/forward cache view of the Application panel
    */
-  backForwardCacheTitle: 'Back-Forward Cache',
+  backForwardCacheTitle: 'Back/forward cache',
   /**
    * @description Status text for the status of the main frame
    */
   unavailable: 'unavailable',
   /**
-   * @description Entry name text in the Back-Forward Cache view of the Application panel
+   * @description Entry name text in the back/forward cache view of the Application panel
    */
   url: 'URL',
   /**
-   * @description Entry name text in the Back-Forward Cache view of the Application panel
+   * @description Entry name text in the back/forward cache view of the Application panel
    */
-  bfcacheStatus: 'Back-Forward Cache Status',
+  bfcacheStatus: 'Back/forward cache Status',
   /**
-   * @description Status text for the status of the Back-Forward Cache status
+   * @description Status text for the status of the back/forward cache status
    */
   unknown: 'unknown',
   /**
-   * @description Status text for the status of the Back-Forward Cache status indicating that
-   * the Back-Forward Cache was not used and a normal navigation occured instead.
+   * @description Status text for the status of the back/forward cache status indicating that
+   * the back/forward cache was not used and a normal navigation occured instead.
    */
-  normalNavigation: 'Normal navigation (Not restored from Back-Forward Cache)',
+  normalNavigation: 'Normal navigation (Not restored from back/forward cache)',
   /**
-   * @description Status text for the status of the Back-Forward Cache status indicating that
-   * the Back-Forward Cache was used to restore the page instead of reloading it.
+   * @description Status text for the status of the back/forward cache status indicating that
+   * the back/forward cache was used to restore the page instead of reloading it.
    */
-  restoredFromBFCache: 'Restored from Back-Forward Cache',
+  restoredFromBFCache: 'Restored from back/forward cache',
   /**
    * @description Label for a list of reasons which prevent the page from being eligible for
-   * Back-Forward Cache. These reasons are actionable i.e. they can be cleaned up to make the
-   * page eligible for Back-Forward Cache.
+   * back/forward cache. These reasons are actionable i.e. they can be cleaned up to make the
+   * page eligible for back/forward cache.
    */
   pageSupportNeeded: 'Actionable',
   /**
    * @description Explanation for actionable items which prevent the page from being eligible
-   * for Back-Forward Cache.
+   * for back/forward cache.
    */
   pageSupportNeededExplanation:
-      'These reasons are actionable i.e. they can be cleaned up to make the page eligible for Back-Forward Cache.',
+      'These reasons are actionable i.e. they can be cleaned up to make the page eligible for back/forward cache.',
   /**
    * @description Label for a list of reasons which prevent the page from being eligible for
-   * Back-Forward Cache. These reasons are circumstantial / not actionable i.e. they cannot be
-   * cleaned up by developers to make the page eligible for Back-Forward Cache.
+   * back/forward cache. These reasons are circumstantial / not actionable i.e. they cannot be
+   * cleaned up by developers to make the page eligible for back/forward cache.
    */
   circumstantial: 'Not Actionable',
   /**
    * @description Explanation for circumstantial/non-actionable items which prevent the page from being eligible
-   * for Back-Forward Cache.
+   * for back/forward cache.
    */
   circumstantialExplanation:
       'These reasons are not actionable i.e. caching was prevented by something outside of the direct control of the page.',
   /**
    * @description Label for a list of reasons which prevent the page from being eligible for
-   * Back-Forward Cache. These reasons are pending support by chrome i.e. in a future version
-   * of chrome they will not prevent Back-Forward Cache usage anymore.
+   * back/forward cache. These reasons are pending support by chrome i.e. in a future version
+   * of chrome they will not prevent back/forward cache usage anymore.
    */
   supportPending: 'Pending Support',
   /**
@@ -86,10 +86,10 @@ const UIStrings = {
   runTest: 'Run Test',
   /**
    * @description Explanation for 'pending support' items which prevent the page from being eligible
-   * for Back-Forward Cache.
+   * for back/forward cache.
    */
   supportPendingExplanation:
-      'Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for Back-Forward Cache in a future version of Chrome.',
+      'Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for back/forward cache in a future version of Chrome.',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/application/BackForwardCacheView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -168,9 +168,9 @@ export class BackForwardCacheView extends UI.ThrottledWidget.ThrottledWidget {
 
       // We can know whether the current page can use BFCache
       // as the browser navigates to another unrelated page and goes back to the current page.
-      // We chose "chrome://version" because it must be cross-site.
+      // We chose "chrome://terms" because it must be cross-site.
       // Ideally, We want to have our own testing page like "chrome: //bfcache-test".
-      resourceTreeModel.navigate('chrome://version/');
+      resourceTreeModel.navigate('chrome://terms');
     }
   }
 

package/front_end/panels/elements/AccessibilityTreeUtils.ts

@@ -44,7 +44,7 @@ export function sdkNodeToAXTreeNode(sdkNode: SDK.AccessibilityModel.Accessibilit
         let localRoot = axmodel.axNodeForDOMNode(document);
         if (!localRoot && frameId) {
           // Request the root node of the iframe document:
-          localRoot = await axmodel.requestRootNode(1, frameId) || null;
+          localRoot = await axmodel.requestRootNode(frameId) || null;
         }
         if (!localRoot) {
           throw new Error('Could not find root node');

package/front_end/panels/elements/AccessibilityTreeView.ts

@@ -104,7 +104,7 @@ export class AccessibilityTreeView extends UI.Widget.VBox {
 
   async update(node: SDK.DOMModel.DOMNode): Promise<void> {
     const axModel = node.domModel().target().model(SDK.AccessibilityModel.AccessibilityModel);
-    await axModel?.updateSubtreeAndAncestors(node.backendNodeId());
+    await axModel?.requestAndLoadSubTreeToNode(node);
     this.renderTree();
   }
 
@@ -140,7 +140,7 @@ export class AccessibilityTreeView extends UI.Widget.VBox {
 
   async refreshAccessibilityTree(accessibilityModel: SDK.AccessibilityModel.AccessibilityModel): Promise<void> {
     // We always expand the root node so we might as well fetch one level of children immediately.
-    const root = await accessibilityModel.requestRootNode(1);
+    const root = await accessibilityModel.requestRootNode();
     if (!root) {
       return;
     }
@@ -169,7 +169,8 @@ export class AccessibilityTreeView extends UI.Widget.VBox {
     //     E
     // Where only A is already loaded into the model, calling requestAndLoadSubTreeToNode(C) will
     // load [A, B, D, C] into the model, and return C.
-    const inspectedAXNode = await this.accessibilityModel.requestAndLoadSubTreeToNode(selectedNode);
+    await this.accessibilityModel.requestAndLoadSubTreeToNode(selectedNode);
+    const inspectedAXNode = this.accessibilityModel.axNodeForDOMNode(selectedNode);
     if (!inspectedAXNode) {
       return;
     }