chrome-devtools-frontend 1.0.941208 → 1.0.942095

package/front_end/models/workspace/UISourceCode.ts

@@ -60,7 +60,7 @@ export class UISourceCode extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
   private nameInternal: string;
   private contentTypeInternal: Common.ResourceType.ResourceType;
   private requestContentPromise: Promise<TextUtils.ContentProvider.DeferredContent>|null;
-  private decorations: Platform.MapUtilities.Multimap<string, LineMarker>|null;
+  private decorations: Map<string, any> = new Map();
   private hasCommitsInternal: boolean;
   private messagesInternal: Set<Message>|null;
   private contentLoadedInternal: boolean;
@@ -94,7 +94,6 @@ export class UISourceCode extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
 
     this.contentTypeInternal = contentType;
     this.requestContentPromise = null;
-    this.decorations = null;
     this.hasCommitsInternal = false;
     this.messagesInternal = null;
     this.contentLoadedInternal = false;
@@ -455,45 +454,15 @@ export class UISourceCode extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
     this.messagesInternal = null;
   }
 
-  addLineDecoration(lineNumber: number, type: string, data: any): void {
-    this.addDecoration(TextUtils.TextRange.TextRange.createFromLocation(lineNumber, 0), type, data);
-  }
-
-  addDecoration(range: TextUtils.TextRange.TextRange, type: string, data: any): void {
-    const marker = new LineMarker(range, type, data);
-    if (!this.decorations) {
-      this.decorations = new Platform.MapUtilities.Multimap();
-    }
-    this.decorations.set(type, marker);
-    this.dispatchEventToListeners(Events.LineDecorationAdded, marker);
-  }
-
-  removeDecorationsForType(type: string): void {
-    if (!this.decorations) {
-      return;
-    }
-    const markers = this.decorations.get(type);
-    this.decorations.deleteAll(type);
-    markers.forEach(marker => {
-      this.dispatchEventToListeners(Events.LineDecorationRemoved, marker);
-    });
-  }
-
-  allDecorations(): LineMarker[] {
-    return this.decorations ? this.decorations.valuesArray() : [];
-  }
-
-  removeAllDecorations(): void {
-    if (!this.decorations) {
-      return;
+  setDecorationData(type: string, data: any): void {
+    if (data !== this.decorations.get(type)) {
+      this.decorations.set(type, data);
+      this.dispatchEventToListeners(Events.DecorationChanged, type);
     }
-    const decorationList = this.decorations.valuesArray();
-    this.decorations.clear();
-    decorationList.forEach(marker => this.dispatchEventToListeners(Events.LineDecorationRemoved, marker));
   }
 
-  decorationsForType(type: string): Set<LineMarker>|null {
-    return this.decorations ? this.decorations.get(type) : null;
+  getDecorationData(type: string): any {
+    return this.decorations.get(type);
   }
 
   disableEdit(): void {
@@ -513,8 +482,7 @@ export enum Events {
   TitleChanged = 'TitleChanged',
   MessageAdded = 'MessageAdded',
   MessageRemoved = 'MessageRemoved',
-  LineDecorationAdded = 'LineDecorationAdded',
-  LineDecorationRemoved = 'LineDecorationRemoved',
+  DecorationChanged = 'DecorationChanged',
 }
 
 export interface WorkingCopyCommitedEvent {
@@ -529,8 +497,7 @@ export type EventTypes = {
   [Events.TitleChanged]: UISourceCode,
   [Events.MessageAdded]: Message,
   [Events.MessageRemoved]: Message,
-  [Events.LineDecorationAdded]: LineMarker,
-  [Events.LineDecorationRemoved]: LineMarker,
+  [Events.DecorationChanged]: string,
 };
 
 export class UILocation {

package/front_end/panels/animation/AnimationTimeline.ts

@@ -438,9 +438,6 @@ export class AnimationTimeline extends UI.Widget.VBox implements SDK.TargetManag
   }
 
   private togglePause(pause: boolean): void {
-    if (this.#scrubberPlayer) {
-      this.#scrubberPlayer.playbackRate = this.effectivePlaybackRate();
-    }
     if (this.#selectedGroup) {
       this.#selectedGroup.togglePause(pause);
       const preview = this.#previewMap.get(this.#selectedGroup);
@@ -448,6 +445,9 @@ export class AnimationTimeline extends UI.Widget.VBox implements SDK.TargetManag
         preview.element.classList.toggle('paused', pause);
       }
     }
+    if (this.#scrubberPlayer) {
+      this.#scrubberPlayer.playbackRate = this.effectivePlaybackRate();
+    }
     this.updateControlButton();
   }
 

package/front_end/panels/application/ApplicationPanelSidebar.ts

@@ -1970,13 +1970,13 @@ export class FrameResourceTreeElement extends ApplicationPanelTreeElement {
     contextMenu.show();
   }
 
-  async revealResource(line?: number, column?: number): Promise<void> {
+  async revealResource(lineNumber?: number, columnNumber?: number): Promise<void> {
     this.revealAndSelect(true);
     const view = await this.panel.scheduleShowView(this.preparePreview());
-    if (!(view instanceof SourceFrame.ResourceSourceFrame.ResourceSourceFrame) || typeof line !== 'number') {
+    if (!(view instanceof SourceFrame.ResourceSourceFrame.ResourceSourceFrame) || typeof lineNumber !== 'number') {
       return;
     }
-    view.revealPosition(line, column, true);
+    view.revealPosition({lineNumber, columnNumber}, true);
   }
 }
 

package/front_end/panels/application/application-meta.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
@@ -47,8 +46,6 @@ let loadedResourcesModule: (typeof Resources|undefined);
 
 async function loadResourcesModule(): Promise<typeof Resources> {
   if (!loadedResourcesModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/application');
     loadedResourcesModule = await import('./application.js');
   }
   return loadedResourcesModule;

package/front_end/panels/console/ConsolePinPane.ts

@@ -5,11 +5,11 @@
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
+import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 import * as ObjectUI from '../../ui/legacy/components/object_ui/object_ui.js';
 // eslint-disable-next-line rulesdir/es_modules_import
 import objectValueStyles from '../../ui/legacy/components/object_ui/objectValue.css.js';
-import type * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
-import type * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import consolePinPaneStyles from './consolePinPane.css.js';
@@ -171,11 +171,10 @@ export class ConsolePin {
   private readonly pinPreview: HTMLElement;
   private lastResult: SDK.RuntimeModel.EvaluationResult|null;
   private lastExecutionContext: SDK.RuntimeModel.ExecutionContext|null;
-  private editor: TextEditor.TextEditor.TextEditor|null;
+  private editor: TextEditor.TextEditor.TextEditor;
   private committedExpression: string;
   private hovered: boolean;
   private lastNode: SDK.RemoteObject.RemoteObject|null;
-  private readonly editorPromise: Promise<TextEditor.TextEditor.TextEditor>;
   private consolePinNumber: number;
   private deletePinIcon: UI.UIUtils.DevToolsCloseButton;
 
@@ -209,10 +208,10 @@ export class ConsolePin {
 
     this.lastResult = null;
     this.lastExecutionContext = null;
-    this.editor = null;
     this.committedExpression = expression;
     this.hovered = false;
     this.lastNode = null;
+    this.editor = this.createEditor(expression, nameElement);
 
     this.pinPreview.addEventListener('mouseenter', this.setHovered.bind(this, true), false);
     this.pinPreview.addEventListener('mouseleave', this.setHovered.bind(this, false), false);
@@ -229,22 +228,19 @@ export class ConsolePin {
         event.consume();
       }
     });
-    this.editorPromise = this.createEditor(expression, nameElement);
   }
 
-  async createEditor(expression: string, parent: HTMLElement): Promise<TextEditor.TextEditor.TextEditor> {
-    const CM = await import('../../third_party/codemirror.next/codemirror.next.js');
-    const TE = await import('../../ui/components/text_editor/text_editor.js');
-    this.editor = new TE.TextEditor.TextEditor(CM.EditorState.create({
+  createEditor(expression: string, parent: HTMLElement): TextEditor.TextEditor.TextEditor {
+    const editor = new TextEditor.TextEditor.TextEditor(CodeMirror.EditorState.create({
       doc: expression,
       extensions: [
-        CM.EditorView.contentAttributes.of({'aria-label': i18nString(UIStrings.liveExpressionEditor)}),
-        CM.EditorView.lineWrapping,
-        (await CM.javascript()).javascriptLanguage,
-        await TE.JavaScript.completion(),
-        TE.Config.showCompletionHint,
-        CM.placeholder(i18nString(UIStrings.expression)),
-        CM.keymap.of([
+        CodeMirror.EditorView.contentAttributes.of({'aria-label': i18nString(UIStrings.liveExpressionEditor)}),
+        CodeMirror.EditorView.lineWrapping,
+        CodeMirror.javascript.javascriptLanguage,
+        TextEditor.JavaScript.completion(),
+        TextEditor.Config.showCompletionHint,
+        CodeMirror.placeholder(i18nString(UIStrings.expression)),
+        CodeMirror.keymap.of([
           {
             key: 'Escape',
             run: (view: CodeMirror.EditorView): boolean => {
@@ -261,13 +257,13 @@ export class ConsolePin {
             },
           },
         ]),
-        CM.EditorView.domEventHandlers({blur: (_e, view) => this.onBlur(view)}),
-        TE.Config.baseConfiguration(expression),
-        TE.Config.autocompletion,
+        CodeMirror.EditorView.domEventHandlers({blur: (_e, view) => this.onBlur(view)}),
+        TextEditor.Config.baseConfiguration(expression),
+        TextEditor.Config.autocompletion,
       ],
     }));
-    parent.appendChild(this.editor);
-    return this.editor;
+    parent.appendChild(editor);
+    return editor;
   }
 
   onBlur(editor: CodeMirror.EditorView): void {
@@ -305,9 +301,9 @@ export class ConsolePin {
   }
 
   async focus(): Promise<void> {
-    const editor = this.editor || await this.editorPromise;
+    const editor = this.editor;
     editor.editor.focus();
-    editor.editor.dispatch({selection: {anchor: editor.state.doc.length}});
+    editor.dispatch({selection: {anchor: editor.state.doc.length}});
   }
 
   appendToContextMenu(contextMenu: UI.ContextMenu.ContextMenu): void {
@@ -322,8 +318,7 @@ export class ConsolePin {
     if (!this.editor) {
       return;
     }
-    const TE = await import('../../ui/components/text_editor/text_editor.js');
-    const text = TE.Config.contentIncludingHint(this.editor.editor);
+    const text = TextEditor.Config.contentIncludingHint(this.editor.editor);
     const isEditing = this.pinElement.hasFocus();
     const throwOnSideEffect = isEditing && text !== this.committedExpression;
     const timeout = throwOnSideEffect ? 250 : undefined;

package/front_end/panels/coverage/CoverageDecorationManager.ts

@@ -24,7 +24,7 @@ export class CoverageDecorationManager {
     this.uiSourceCodeByContentProvider = new Platform.MapUtilities.Multimap();
 
     for (const uiSourceCode of Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodes()) {
-      uiSourceCode.addLineDecoration(0, decoratorType, this);
+      uiSourceCode.setDecorationData(decoratorType, this);
     }
     Workspace.Workspace.WorkspaceImpl.instance().addEventListener(
         Workspace.Workspace.Events.UISourceCodeAdded, this.onUISourceCodeAdded, this);
@@ -32,7 +32,7 @@ export class CoverageDecorationManager {
 
   reset(): void {
     for (const uiSourceCode of Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodes()) {
-      uiSourceCode.removeDecorationsForType(decoratorType);
+      uiSourceCode.setDecorationData(decoratorType, undefined);
     }
   }
 
@@ -45,8 +45,7 @@ export class CoverageDecorationManager {
   update(updatedEntries: CoverageInfo[]): void {
     for (const entry of updatedEntries) {
       for (const uiSourceCode of this.uiSourceCodeByContentProvider.get(entry.getContentProvider())) {
-        uiSourceCode.removeDecorationsForType(decoratorType);
-        uiSourceCode.addLineDecoration(0, decoratorType, this);
+        uiSourceCode.setDecorationData(decoratorType, this);
       }
     }
   }
@@ -185,7 +184,7 @@ export class CoverageDecorationManager {
 
   private onUISourceCodeAdded(event: Common.EventTarget.EventTargetEvent<Workspace.UISourceCode.UISourceCode>): void {
     const uiSourceCode = event.data;
-    uiSourceCode.addLineDecoration(0, decoratorType, this);
+    uiSourceCode.setDecorationData(decoratorType, this);
   }
 }
 export interface RawLocation {

package/front_end/panels/coverage/CoverageView.ts

@@ -8,15 +8,12 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Bindings from '../../models/bindings/bindings.js';
-import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
+import {CoverageDecorationManager} from './CoverageDecorationManager.js';
+import {CoverageListView} from './CoverageListView.js';
 import coverageViewStyles from './coverageView.css.js';
 
-import type * as Workspace from '../../models/workspace/workspace.js';
-
-import {CoverageDecorationManager, decoratorType} from './CoverageDecorationManager.js';
-import {CoverageListView} from './CoverageListView.js';
 import type {CoverageInfo, URLCoverageInfo} from './CoverageModel.js';
 import {CoverageModel, Events, CoverageType} from './CoverageModel.js';
 
@@ -564,103 +561,3 @@ export class ActionDelegate implements UI.ActionRegistration.ActionDelegate {
     }
   }
 }
-let lineDecoratorInstance: LineDecorator;
-export class LineDecorator implements SourceFrame.SourceFrame.LineDecorator {
-  static instance({forceNew}: {forceNew: boolean} = {forceNew: false}): LineDecorator {
-    if (!lineDecoratorInstance || forceNew) {
-      lineDecoratorInstance = new LineDecorator();
-    }
-
-    return lineDecoratorInstance;
-  }
-
-  private readonly listeners: WeakMap<
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      SourceFrame.SourcesTextEditor.SourcesTextEditor, (arg0: Common.EventTarget.EventTargetEvent<any>) => void>;
-  constructor() {
-    this.listeners = new WeakMap();
-  }
-
-  decorate(
-      uiSourceCode: Workspace.UISourceCode.UISourceCode,
-      textEditor: SourceFrame.SourcesTextEditor.SourcesTextEditor): void {
-    const decorations = uiSourceCode.decorationsForType(decoratorType);
-    if (!decorations || !decorations.size) {
-      this.uninstallGutter(textEditor);
-      return;
-    }
-    const decorationManager = decorations.values().next().value.data() as CoverageDecorationManager;
-    decorationManager.usageByLine(uiSourceCode).then(lineUsage => {
-      textEditor.operation(() => this.innerDecorate(uiSourceCode, textEditor, lineUsage));
-    });
-  }
-
-  private innerDecorate(
-      uiSourceCode: Workspace.UISourceCode.UISourceCode, textEditor: SourceFrame.SourcesTextEditor.SourcesTextEditor,
-      lineUsage: (boolean|undefined)[]): void {
-    const gutterType = LineDecorator.GUTTER_TYPE;
-    this.uninstallGutter(textEditor);
-    if (lineUsage.length) {
-      this.installGutter(textEditor, uiSourceCode.url());
-    }
-    for (let line = 0; line < lineUsage.length; ++line) {
-      // Do not decorate the line if we don't have data.
-      if (typeof lineUsage[line] !== 'boolean') {
-        continue;
-      }
-      const className = lineUsage[line] ? 'text-editor-coverage-used-marker' : 'text-editor-coverage-unused-marker';
-      const gutterElement = document.createElement('div');
-      gutterElement.classList.add(className);
-      textEditor.setGutterDecoration(line, gutterType, gutterElement);
-    }
-  }
-
-  makeGutterClickHandler(url: string):
-      (arg0: Common.EventTarget.EventTargetEvent<SourceFrame.SourcesTextEditor.GutterClickEventData>) => void {
-    function handleGutterClick(
-        event: Common.EventTarget.EventTargetEvent<SourceFrame.SourcesTextEditor.GutterClickEventData>): void {
-      if (event.data.gutterType !== LineDecorator.GUTTER_TYPE) {
-        return;
-      }
-      const coverageViewId = 'coverage';
-      UI.ViewManager.ViewManager.instance()
-          .showView(coverageViewId)
-          .then(() => {
-            const view = UI.ViewManager.ViewManager.instance().view(coverageViewId);
-            return view && view.widget();
-          })
-          .then(widget => {
-            const matchFormattedSuffix = url.match(/(.*):formatted$/);
-            const urlWithoutFormattedSuffix = (matchFormattedSuffix && matchFormattedSuffix[1]) || url;
-            (widget as CoverageView).selectCoverageItemByUrl(urlWithoutFormattedSuffix);
-          });
-    }
-    return handleGutterClick;
-  }
-
-  private installGutter(textEditor: SourceFrame.SourcesTextEditor.SourcesTextEditor, url: string): void {
-    let listener = this.listeners.get(textEditor);
-    if (!listener) {
-      listener = this.makeGutterClickHandler(url);
-      this.listeners.set(textEditor, listener);
-    }
-    textEditor.installGutter(LineDecorator.GUTTER_TYPE, false);
-    textEditor.addEventListener(SourceFrame.SourcesTextEditor.Events.GutterClick, listener, this);
-  }
-
-  private uninstallGutter(textEditor: SourceFrame.SourcesTextEditor.SourcesTextEditor): void {
-    textEditor.uninstallGutter(LineDecorator.GUTTER_TYPE);
-    const listener = this.listeners.get(textEditor);
-    if (listener) {
-      textEditor.removeEventListener(SourceFrame.SourcesTextEditor.Events.GutterClick, listener, this);
-      this.listeners.delete(textEditor);
-    }
-  }
-
-  static readonly GUTTER_TYPE = 'CodeMirror-gutter-coverage';
-}
-
-SourceFrame.SourceFrame.registerLineDecorator({
-  lineDecorator: LineDecorator.instance,
-  decoratorType: SourceFrame.SourceFrame.DecoratorType.COVERAGE,
-});

package/front_end/panels/css_overview/components/CSSOverviewStartView.ts

@@ -5,8 +5,7 @@
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Buttons from '../../../ui/components/buttons/buttons.js';
 import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
-import * as IconButton from '../../../ui/components/icon_button/icon_button.js';
-import * as Legacy from '../../../ui/legacy/legacy.js';
+import * as PanelFeedback from '../../../ui/components/panel_feedback/panel_feedback.js';
 import * as LitHtml from '../../../ui/lit-html/lit-html.js';
 
 import cssOverviewStartViewStyles from './cssOverviewStartView.css.js';
@@ -34,30 +33,9 @@ const UIStrings = {
   */
   locateAffectedElements: 'Locate the affected elements in the Elements panel',
   /**
-  *@description Title of the "Preview feature" reminder box
-  */
-  previewFeature: 'Preview feature',
-  /**
-  *@description Sentence to convey the feature is being actively worked on and we are looking for feedback
-  *@example {https://goo.gle/css-overview-feedback} PH1
-  */
-  activelyWorkingAndLookingForS: 'Our team is actively working on this feature and we are looking for your {PH1}!',
-  /**
-  *@description Link text of the inline anchor to navigate to a feedback page
-  */
-  feedbackInline: 'feedback',
-  /**
-  *@description Title of the section to the quick start video and documentation to CSS Overview panel
-  */
-  videoAndDocumentation: 'Video and documentation',
-  /**
   *@description Title of the link to the quick start video and documentation to CSS Overview panel
   */
   quickStartWithCSSOverview: 'Quick start: get started with the new CSS Overview panel',
-  /**
-  *@description Link text of the standalone button to navigate to a feedback page
-  */
-  feedbackStandalone: 'Feedback',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/css_overview/components/CSSOverviewStartView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -77,13 +55,6 @@ export class OverviewStartRequestedEvent extends Event {
 export class CSSOverviewStartView extends HTMLElement {
   static readonly litTagName = LitHtml.literal`devtools-css-overview-start-view`;
   readonly #shadow = this.attachShadow({mode: 'open'});
-  #feedbackLink: HTMLElement;
-
-  constructor() {
-    super();
-    this.#feedbackLink =
-        Legacy.XLink.XLink.create(FEEDBACK_LINK, i18nString(UIStrings.feedbackInline), 'devtools-link');
-  }
 
   connectedCallback(): void {
     this.#shadow.adoptedStyleSheets = [cssOverviewStartViewStyles];
@@ -121,32 +92,16 @@ export class CSSOverviewStartView extends HTMLElement {
             ${i18nString(UIStrings.captureOverview)}
           </${Buttons.Button.Button.litTagName}>
         </div>
-        <section class="preview-feature">
-          <h1 class="preview-header">
-            <${IconButton.Icon.Icon.litTagName} class="preview-icon" .data=${{
-                iconName: 'ic_preview_feature',
-                width: '24px',
-                height: '24px',
-                color: 'var(--color-primary)',
-              } as IconButton.Icon.IconData}></${IconButton.Icon.Icon.litTagName}>
-              ${i18nString(UIStrings.previewFeature)}
-          </h1>
-          <div class="feedback-prompt">${i18n.i18n.getFormatLocalizedString(str_, UIStrings.activelyWorkingAndLookingForS, {PH1: this.#feedbackLink})}</div>
-          <div class="resources">
-            <div class="thumbnail-wrapper">
-              <${IconButton.Icon.Icon.litTagName} .data=${{
-                iconName: 'preview_feature_video_thumbnail',
-                width: '144px',
-                height: '92px',
-              } as IconButton.Icon.IconData}></${IconButton.Icon.Icon.litTagName}>
-            </div>
-            <div>
-              <h1 class="video-doc-header">${i18nString(UIStrings.videoAndDocumentation)}</h1>
-              <x-link class="devtools-link" href=${DOC_LINK}>${i18nString(UIStrings.quickStartWithCSSOverview)}</x-link>
-            </div>
-          </div>
-        </section>
-        <x-link class="feedback-standalone" href=${FEEDBACK_LINK}>${i18nString(UIStrings.feedbackStandalone)}</x-link>
+        <${PanelFeedback.PanelFeedback.PanelFeedback.litTagName} .data=${{
+            feedbackUrl: FEEDBACK_LINK,
+            quickStartUrl: DOC_LINK,
+            quickStartLinkText: i18nString(UIStrings.quickStartWithCSSOverview),
+          } as PanelFeedback.PanelFeedback.PanelFeedbackData}>
+        </${PanelFeedback.PanelFeedback.PanelFeedback.litTagName}>
+        <${PanelFeedback.FeedbackButton.FeedbackButton.litTagName} .data=${{
+          feedbackUrl: FEEDBACK_LINK,
+          } as PanelFeedback.FeedbackButton.FeedbackButtonData}>
+        </${PanelFeedback.FeedbackButton.FeedbackButton.litTagName}>
       </div>
     `, this.#shadow, {
       host: this,

package/front_end/panels/css_overview/components/cssOverviewStartView.css

@@ -120,15 +120,8 @@ h1 {
   margin-bottom: 2px;
 }
 
-.feedback-standalone {
-  width: fit-content;
-  padding: 0.5em;
+devtools-feedback-button {
   align-self: flex-end;
-  color: var(--color-primary);
-  border: 1px solid var(--color-details-hairline);
-  border-radius: 2px;
-  text-decoration: none;
-  font-weight: bold;
 }
 
 .resources .devtools-link {

package/front_end/panels/elements/ElementsTreeElement.ts

@@ -38,10 +38,10 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
 import * as Adorners from '../../ui/components/adorners/adorners.js';
 import * as CodeHighlighter from '../../ui/components/code_highlighter/code_highlighter.js';
-
-import type * as TextEditor from '../../ui/components/text_editor/text_editor.js';
+import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Emulation from '../emulation/emulation.js';
@@ -679,8 +679,6 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
     const isEditable = this.hasEditableNode();
     // clang-format off
     if (isEditable && !this.editing) {
-      // Eagerly load CodeMirror to avoid a delay when opening the "Edit as HTML" editor when the user actually clicks on it
-      import('../../ui/components/text_editor/text_editor.js');
       contextMenu.editSection().appendItem(i18nString(UIStrings.editAsHtml), this.editAsHTML.bind(this));
     }
     // clang-format on
@@ -1026,9 +1024,6 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
       }
     });
 
-    const TextEditor = await import('../../ui/components/text_editor/text_editor.js');
-    const CodeMirror = await import('../../third_party/codemirror.next/codemirror.next.js');
-    const {html} = await CodeMirror.html();
     const editor = new TextEditor.TextEditor.TextEditor(CodeMirror.EditorState.create({
       doc: initialValue,
       extensions: [
@@ -1050,8 +1045,8 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
         ]),
         TextEditor.Config.baseConfiguration(initialValue),
         TextEditor.Config.autocompletion,
-        html(),
-        TextEditor.Config.domWordWrap,
+        CodeMirror.html.html(),
+        TextEditor.Config.domWordWrap.instance(),
         CodeMirror.EditorView.theme({
           '&.cm-editor': {maxHeight: '300px'},
           '.cm-scroller': {overflowY: 'auto'},

package/front_end/panels/elements/components/adornerSettingsPane.css

@@ -65,7 +65,3 @@
 .close::after {
   transform: rotate(-45deg);
 }
-
-:host-context(.-theme-with-dark-background) input[type="checkbox"] {
-  filter: invert(80%);
-}

package/front_end/panels/emulation/emulation-meta.ts

@@ -47,11 +47,11 @@ const UIStrings = {
   /**
   *@description Command that shows measuring rulers next to the emulated device.
   */
-  showRulers: 'Show rulers',
+  showRulers: 'Show rulers in the Device Mode toolbar',
   /**
   *@description Command that hides measuring rulers next to the emulated device.
   */
-  hideRulers: 'Hide rulers',
+  hideRulers: 'Hide rulers in the Device Mode toolbar',
   /**
   *@description Command that shows a frame (like a picture frame) around the emulated device.
   */

package/front_end/panels/issues/issues-meta.ts

@@ -35,8 +35,6 @@ let loadedIssuesModule: (typeof Issues|undefined);
 
 async function loadIssuesModule(): Promise<typeof Issues> {
   if (!loadedIssuesModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/issues');
     loadedIssuesModule = await import('./issues.js');
   }
   return loadedIssuesModule;

package/front_end/panels/layers/module.json

@@ -1,5 +1,4 @@
 {
   "dependencies": [
-    "panels/layer_viewer"
   ]
 }

package/front_end/panels/lighthouse/lighthouseStartView.css

@@ -74,6 +74,10 @@ input[type="radio"]:focus {
   outline-width: 2px;
 }
 
+:host-context(.-theme-with-dark-background) input[type="radio"] {
+  accent-color: var(--color-checkbox-accent-color);
+}
+
 .lighthouse-radio-text {
   margin-left: 3px;
 }

package/front_end/panels/media/media-meta.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 // eslint-disable-next-line rulesdir/es_modules_import
@@ -30,8 +29,6 @@ let loadedMediaModule: (typeof Media|undefined);
 
 async function loadMediaModule(): Promise<typeof Media> {
   if (!loadedMediaModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/media');
     loadedMediaModule = await import('./media.js');
   }
   return loadedMediaModule;

package/front_end/panels/network/ResourceWebSocketFrameView.ts

@@ -331,7 +331,8 @@ export class ResourceWebSocketFrameView extends UI.Widget.VBox {
 
     this.splitWidget.setSidebarWidget(new SourceFrame.ResourceSourceFrame.ResourceSourceFrame(
         TextUtils.StaticContentProvider.StaticContentProvider.fromString(
-            this.request.url(), Common.ResourceType.resourceTypes.WebSocket, content)));
+            this.request.url(), Common.ResourceType.resourceTypes.WebSocket, content),
+        ''));
   }
 
   private onFrameDeselected(): void {