npm - chrome-devtools-frontend - Versions diffs - 1.0.939473 → 1.0.940255 - Mend

chrome-devtools-frontend 1.0.939473 → 1.0.940255

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (25) hide show

package/docs/triage_guidelines.md CHANGED Viewed

@@ -47,15 +47,15 @@ Issues in the untriaged queue should receive a meaningful response within a busi
 - Close issues as `Archived` that are valid, but it seems unlikely that we will get there anytime soon.
 - Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `Hotlist-DevTools-Triaged` and leave the `Untriaged` status as is.
 - Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.
-  - Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
-  - Put one of the following labels on it and set the status to "Available":
+- Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
+- Put one of the following labels on it and set the status to `Available`:
   - `Hotlist-DevTools-ProductReview` if it's controversial or clear that consensus needs to be built first.
   - `Hotlist-DevTools-BrowserAutomation-Backlog` if it's an issue related to ChromeDriver or puppeteer.
   - `Hotlist-DevTools-Debugging-Backlog` if it's a debugging issue.
   - `Hotlist-DevTools-DesignAccessibility-Backlog` if it's a design or accessibility issue.
   - `Hotlist-DevTools-Performance-Backlog` if the issue is related to our performance tooling (i.e. Performance panel, Lighthouse).
   - `Hotlist-DevTools-Backlog` if it's a general DevTools issue that is not specific to one of the core areas.
-- Also remember to put the Needs-UX label on it, if help from a designer is likely to be required.
+- Also remember to put the `Needs-UX` label on it, if help from a designer is likely to be required.
 ### Setting Assigned or Available

package/front_end/core/host/InspectorFrontendHostAPI.ts CHANGED Viewed

@@ -369,4 +369,9 @@ export enum EnumeratedHistogram {
   Language = 'DevTools.Language',
   ConsoleShowsCorsErrors = 'DevTools.ConsoleShowsCorsErrors',
   SyncSetting = 'DevTools.SyncSetting',
+  RecordingEdited = 'DevTools.RecordingEdited',
+  RecordingExported = 'DevTools.RecordingExported',
+  RecordingReplayFinished = 'DevTools.RecordingReplayFinished',
+  RecordingReplayStarted = 'DevTools.RecordingReplayStarted',
+  RecordingToggled = 'DevTools.RecordingToggled',
 }

package/front_end/core/host/UserMetrics.ts CHANGED Viewed

@@ -261,6 +261,31 @@ export class UserMetrics {
       InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.SyncSetting, settingValue, size);
     });
   }
+  recordingToggled(value: RecordingToggled): void {
+    const size = Object.keys(RecordingToggled).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingToggled, value, size);
+  }
+  recordingReplayFinished(value: RecordingReplayFinished): void {
+    const size = Object.keys(RecordingReplayFinished).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingReplayFinished, value, size);
+  }
+  recordingReplayStarted(value: RecordingReplayStarted): void {
+    const size = Object.keys(RecordingReplayStarted).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingReplayStarted, value, size);
+  }
+  recordingEdited(value: RecordingEdited): void {
+    const size = Object.keys(RecordingEdited).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingEdited, value, size);
+  }
+  recordingExported(value: RecordingExported): void {
+    const size = Object.keys(RecordingExported).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingExported, value, size);
+  }
 }
 // Codes below are used to collect UMA histograms in the Chromium port.
@@ -687,6 +712,7 @@ export const IssueCreated: {
   'CorsIssue::NoCorsRedirectModeNotFollow': 57,
   'QuirksModeIssue::QuirksMode': 58,
   'QuirksModeIssue::LimitedQuirksMode': 59,
+  DeprecationIssue: 60,
 };
 // TODO(crbug.com/1167717): Make this a const enum again
@@ -826,3 +852,48 @@ export enum SyncSetting {
   DevToolsSyncSettingDisabled = 3,
   DevToolsSyncSettingEnabled = 4,
 }
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingToggled {
+  RecordingStarted = 1,
+  RecordingFinished = 2,
+}
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingReplayFinished {
+  Success = 1,
+  TimeoutErrorSelectors = 2,
+  TimeoutErrorTarget = 3,
+  OtherError = 4,
+}
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingReplayStarted {
+  ReplayOnly = 1,
+  ReplayWithPerformanceTracing = 2,
+}
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingEdited {
+  SelectorPickerUsed = 1,
+  StepAdded = 2,
+  StepRemoved = 3,
+  SelectorAdded = 4,
+  SelectorRemoved = 5,
+  SelectorPartAdded = 6,
+  SelectorPartEdited = 7,
+  SelectorPartRemoved = 8,
+  TypeChanged = 9,
+  OtherEditing = 10,
+}
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingExported {
+  ToPuppeteer = 1,
+  ToJSON = 2,
+}

package/front_end/core/i18n/locales/en-US.json CHANGED Viewed

@@ -2052,7 +2052,7 @@
     "message": "Stop recording events"
   },
   "panels/application/ApplicationPanelCacheSection.ts | backForwardCache": {
-    "message": "Back-forward Cache"
+    "message": "Back-Forward Cache"
   },
   "panels/application/ApplicationPanelCacheSection.ts | cacheStorage": {
     "message": "Cache Storage"
@@ -2688,10 +2688,10 @@
     "message": "Pages that use WebXR are not currently eligible for back/forward cache."
   },
   "panels/application/BackForwardCacheView.ts | backForwardCacheTitle": {
-    "message": "Back-forward Cache"
+    "message": "Back-Forward Cache"
   },
   "panels/application/BackForwardCacheView.ts | bfcacheStatus": {
-    "message": "Back-forward Cache Status"
+    "message": "Back-Forward Cache Status"
   },
   "panels/application/BackForwardCacheView.ts | circumstantial": {
     "message": "Not Actionable"
@@ -2703,16 +2703,16 @@
     "message": "Main Frame"
   },
   "panels/application/BackForwardCacheView.ts | normalNavigation": {
-    "message": "Normal navigation (Not restored from back-forward cache)"
+    "message": "Normal navigation (Not restored from Back-Forward Cache)"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeeded": {
     "message": "Actionable"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeededExplanation": {
-    "message": "These reasons are actionable i.e. they can be cleaned up to make the page eligible for back-forward cache."
+    "message": "These reasons are actionable i.e. they can be cleaned up to make the page eligible for Back-Forward Cache."
   },
   "panels/application/BackForwardCacheView.ts | restoredFromBFCache": {
-    "message": "Restored from back-forward cache"
+    "message": "Restored from Back-Forward Cache"
   },
   "panels/application/BackForwardCacheView.ts | runTest": {
     "message": "Run Test"
@@ -2721,7 +2721,7 @@
     "message": "Pending Support"
   },
   "panels/application/BackForwardCacheView.ts | supportPendingExplanation": {
-    "message": "Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for back-forward cache in a future version of Chrome."
+    "message": "Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for Back-Forward Cache in a future version of Chrome."
   },
   "panels/application/BackForwardCacheView.ts | unavailable": {
     "message": "unavailable"

package/front_end/core/i18n/locales/en-XL.json CHANGED Viewed

@@ -2052,7 +2052,7 @@
     "message": "Ŝt́ôṕ r̂éĉór̂d́îńĝ év̂én̂t́ŝ"
   },
   "panels/application/ApplicationPanelCacheSection.ts | backForwardCache": {
-    "message": "B̂áĉḱ-f̂ór̂ẃâŕd̂ Ćâćĥé"
+    "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé"
   },
   "panels/application/ApplicationPanelCacheSection.ts | cacheStorage": {
     "message": "Ĉáĉh́ê Śt̂ór̂áĝé"
@@ -2688,10 +2688,10 @@
     "message": "P̂áĝéŝ t́ĥát̂ úŝé Ŵéb̂X́R̂ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê."
   },
   "panels/application/BackForwardCacheView.ts | backForwardCacheTitle": {
-    "message": "B̂áĉḱ-f̂ór̂ẃâŕd̂ Ćâćĥé"
+    "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé"
   },
   "panels/application/BackForwardCacheView.ts | bfcacheStatus": {
-    "message": "B̂áĉḱ-f̂ór̂ẃâŕd̂ Ćâćĥé Ŝt́ât́ûś"
+    "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé Ŝt́ât́ûś"
   },
   "panels/application/BackForwardCacheView.ts | circumstantial": {
     "message": "N̂ót̂ Áĉt́îón̂áb̂ĺê"
@@ -2703,16 +2703,16 @@
     "message": "M̂áîń F̂ŕâḿê"
   },
   "panels/application/BackForwardCacheView.ts | normalNavigation": {
-    "message": "N̂ór̂ḿâĺ n̂áv̂íĝát̂íôń (N̂ót̂ ŕêśt̂ór̂éd̂ f́r̂óm̂ b́âćk̂-f́ôŕŵár̂d́ ĉáĉh́ê)"
+    "message": "N̂ór̂ḿâĺ n̂áv̂íĝát̂íôń (N̂ót̂ ŕêśt̂ór̂éd̂ f́r̂óm̂ B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê)"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeeded": {
     "message": "Âćt̂íôńâb́l̂é"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeededExplanation": {
-    "message": "T̂h́êśê ŕêáŝón̂ś âŕê áĉt́îón̂áb̂ĺê í.ê. t́ĥéŷ ćâń b̂é ĉĺêán̂éd̂ úp̂ t́ô ḿâḱê t́ĥé p̂áĝé êĺîǵîb́l̂é f̂ór̂ b́âćk̂-f́ôŕŵár̂d́ ĉáĉh́ê."
+    "message": "T̂h́êśê ŕêáŝón̂ś âŕê áĉt́îón̂áb̂ĺê í.ê. t́ĥéŷ ćâń b̂é ĉĺêán̂éd̂ úp̂ t́ô ḿâḱê t́ĥé p̂áĝé êĺîǵîb́l̂é f̂ór̂ B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê."
   },
   "panels/application/BackForwardCacheView.ts | restoredFromBFCache": {
-    "message": "R̂éŝt́ôŕêd́ f̂ŕôḿ b̂áĉḱ-f̂ór̂ẃâŕd̂ ćâćĥé"
+    "message": "R̂éŝt́ôŕêd́ f̂ŕôḿ B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé"
   },
   "panels/application/BackForwardCacheView.ts | runTest": {
     "message": "R̂ún̂ T́êśt̂"
@@ -2721,7 +2721,7 @@
     "message": "P̂én̂d́îńĝ Śûṕp̂ór̂t́"
   },
   "panels/application/BackForwardCacheView.ts | supportPendingExplanation": {
-    "message": "Ĉh́r̂óm̂é ŝúp̂ṕôŕt̂ f́ôŕ t̂h́êśê ŕêáŝón̂ś îś p̂én̂d́îńĝ í.ê. t́ĥéŷ ẃîĺl̂ ńôt́ p̂ŕêv́êńt̂ t́ĥé p̂áĝé f̂ŕôḿ b̂éîńĝ él̂íĝíb̂ĺê f́ôŕ b̂áĉḱ-f̂ór̂ẃâŕd̂ ćâćĥé îń â f́ût́ûŕê v́êŕŝíôń ôf́ Ĉh́r̂óm̂é."
+    "message": "Ĉh́r̂óm̂é ŝúp̂ṕôŕt̂ f́ôŕ t̂h́êśê ŕêáŝón̂ś îś p̂én̂d́îńĝ í.ê. t́ĥéŷ ẃîĺl̂ ńôt́ p̂ŕêv́êńt̂ t́ĥé p̂áĝé f̂ŕôḿ b̂éîńĝ él̂íĝíb̂ĺê f́ôŕ B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé îń â f́ût́ûŕê v́êŕŝíôń ôf́ Ĉh́r̂óm̂é."
   },
   "panels/application/BackForwardCacheView.ts | unavailable": {
     "message": "ûńâv́âíl̂áb̂ĺê"

package/front_end/devtools_compatibility.js CHANGED Viewed

@@ -396,6 +396,11 @@
     LinearMemoryInspectorTarget: 'DevTools.LinearMemoryInspector.Target',
     Language: 'DevTools.Language',
     ConsoleShowsCorsErrors: 'DevTools.ConsoleShowsCorsErrors',
+    RecordingEdited: 'DevTools.RecordingEdited',
+    RecordingExported: 'DevTools.RecordingExported',
+    RecordingReplayFinished: 'DevTools.RecordingReplayFinished',
+    RecordingReplayStarted: 'DevTools.RecordingReplayStarted',
+    RecordingToggled: 'DevTools.RecordingToggled',
   };
   /**

package/front_end/entrypoints/main/MainImpl.ts CHANGED Viewed

@@ -149,7 +149,10 @@ export class MainImpl {
     this.createSettings(prefs);
     await this.requestAndRegisterLocaleData();
-    Host.userMetrics.syncSetting(Common.Settings.Settings.instance().moduleSetting<boolean>('sync_preferences').get());
+    if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.SYNC_SETTINGS)) {
+      Host.userMetrics.syncSetting(
+          Common.Settings.Settings.instance().moduleSetting<boolean>('sync_preferences').get());
+    }
     this.createAppUI();
   }
@@ -270,8 +273,8 @@ export class MainImpl {
         'keyboardShortcutEditor', 'Enable keyboard shortcut editor', true,
         'https://developer.chrome.com/blog/new-in-devtools-88/#keyboard-shortcuts');
-    // Back-forward cache
-    Root.Runtime.experiments.register('bfcacheDebugging', 'Enable back-forward cache debugging support');
+    // Back-Forward Cache
+    Root.Runtime.experiments.register('bfcacheDebugging', 'Enable Back-Forward Cache debugging support');
     // Timeline
     Root.Runtime.experiments.register('timelineEventInitiators', 'Timeline: event initiators');

package/front_end/entrypoints/main/main-meta.ts CHANGED Viewed

@@ -752,6 +752,7 @@ function filterLocalesForSettings(): string[] {
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.APPEARANCE,
+  storageType: Common.Settings.SettingStorageType.Synced,
   settingName: 'language',
   settingType: Common.Settings.SettingType.ENUM,
   title: i18nLazyString(UIStrings.language),

package/front_end/models/logs/LogManager.ts CHANGED Viewed

@@ -49,6 +49,7 @@ export class LogManager implements SDK.TargetManager.SDKModelObserver<SDK.LogMod
       timestamp: entry.timestamp,
       workerId: entry.workerId,
       category: entry.category,
+      affectedResources: entry.networkRequestId ? {requestId: entry.networkRequestId} : undefined,
     };
     const consoleMessage = new SDK.ConsoleModel.ConsoleMessage(
         target.model(SDK.RuntimeModel.RuntimeModel), entry.source, entry.level, entry.text, details);

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts CHANGED Viewed

@@ -446,7 +446,7 @@ export class AXBreadcrumb {
       }
     }
-    if (this.axNodeInternal.hasOnlyUnloadedChildren()) {
+    if (!this.axNodeInternal.ignored() && this.axNodeInternal.hasOnlyUnloadedChildren()) {
       this.nodeElementInternal.classList.add('children-unloaded');
       UI.ARIAUtils.setExpanded(this.nodeElementInternal, false);
     }

package/front_end/panels/accessibility/AccessibilityNodeView.ts CHANGED Viewed

@@ -673,7 +673,7 @@ export class AXNodeIgnoredReasonTreeElement extends AXNodePropertyTreeElement {
         reasonElement = i18n.i18n.getFormatLocalizedString(str_, UIStrings.elementIsNotVisible, {});
         break;
       case 'presentationalRole': {
-        const role = axNode && axNode.role() || '';
+        const role = axNode && axNode.role()?.value || '';
         const rolePresentationSpan = document.createElement('span', {is: 'source-code'}).textContent = 'role=' + role;
         reasonElement =
             i18n.i18n.getFormatLocalizedString(str_, UIStrings.elementHasPlaceholder, {PH1: rolePresentationSpan});

package/front_end/panels/application/ApplicationPanelCacheSection.ts CHANGED Viewed

@@ -20,7 +20,7 @@ const UIStrings = {
   /**
   *@description Text in Application Panel Sidebar of the Application panel
   */
-  backForwardCache: 'Back-forward Cache',
+  backForwardCache: 'Back-Forward Cache',
   /**
   *@description A context menu item in the Application Panel Sidebar of the Application panel
   */

package/front_end/panels/application/BackForwardCacheView.ts CHANGED Viewed

@@ -17,67 +17,67 @@ import backForwardCacheViewStyles from './backForwardCacheView.css.js';
 const UIStrings = {
   /**
-   * @description Title text in Back-forward Cache view of the Application panel
+   * @description Title text in Back-Forward Cache view of the Application panel
    */
   mainFrame: 'Main Frame',
   /**
-   * @description Title text in Back-forward Cache view of the Application panel
+   * @description Title text in Back-Forward Cache view of the Application panel
    */
-  backForwardCacheTitle: 'Back-forward Cache',
+  backForwardCacheTitle: 'Back-Forward Cache',
   /**
    * @description Status text for the status of the main frame
    */
   unavailable: 'unavailable',
   /**
-   * @description Entry name text in the Back-forward Cache view of the Application panel
+   * @description Entry name text in the Back-Forward Cache view of the Application panel
    */
   url: 'URL',
   /**
-   * @description Entry name text in the Back-forward Cache view of the Application panel
+   * @description Entry name text in the Back-Forward Cache view of the Application panel
    */
-  bfcacheStatus: 'Back-forward Cache Status',
+  bfcacheStatus: 'Back-Forward Cache Status',
   /**
-   * @description Status text for the status of the back-forward cache status
+   * @description Status text for the status of the Back-Forward Cache status
    */
   unknown: 'unknown',
   /**
-   * @description Status text for the status of the back-forward cache status indicating that
-   * the back-forward cache was not used and a normal navigation occured instead.
+   * @description Status text for the status of the Back-Forward Cache status indicating that
+   * the Back-Forward Cache was not used and a normal navigation occured instead.
    */
-  normalNavigation: 'Normal navigation (Not restored from back-forward cache)',
+  normalNavigation: 'Normal navigation (Not restored from Back-Forward Cache)',
   /**
-   * @description Status text for the status of the back-forward cache status indicating that
-   * the back-forward cache was used to restore the page instead of reloading it.
+   * @description Status text for the status of the Back-Forward Cache status indicating that
+   * the Back-Forward Cache was used to restore the page instead of reloading it.
    */
-  restoredFromBFCache: 'Restored from back-forward cache',
+  restoredFromBFCache: 'Restored from Back-Forward Cache',
   /**
    * @description Label for a list of reasons which prevent the page from being eligible for
-   * back-forward cache. These reasons are actionable i.e. they can be cleaned up to make the
-   * page eligible for back-forward cache.
+   * Back-Forward Cache. These reasons are actionable i.e. they can be cleaned up to make the
+   * page eligible for Back-Forward Cache.
    */
   pageSupportNeeded: 'Actionable',
   /**
    * @description Explanation for actionable items which prevent the page from being eligible
-   * for back-forward cache.
+   * for Back-Forward Cache.
    */
   pageSupportNeededExplanation:
-      'These reasons are actionable i.e. they can be cleaned up to make the page eligible for back-forward cache.',
+      'These reasons are actionable i.e. they can be cleaned up to make the page eligible for Back-Forward Cache.',
   /**
    * @description Label for a list of reasons which prevent the page from being eligible for
-   * back-forward cache. These reasons are circumstantial / not actionable i.e. they cannot be
-   * cleaned up by developers to make the page eligible for back-forward cache.
+   * Back-Forward Cache. These reasons are circumstantial / not actionable i.e. they cannot be
+   * cleaned up by developers to make the page eligible for Back-Forward Cache.
    */
   circumstantial: 'Not Actionable',
   /**
    * @description Explanation for circumstantial/non-actionable items which prevent the page from being eligible
-   * for back-forward cache.
+   * for Back-Forward Cache.
    */
   circumstantialExplanation:
       'These reasons are not actionable i.e. caching was prevented by something outside of the direct control of the page.',
   /**
    * @description Label for a list of reasons which prevent the page from being eligible for
-   * back-forward cache. These reasons are pending support by chrome i.e. in a future version
-   * of chrome they will not prevent back-forward cache usage anymore.
+   * Back-Forward Cache. These reasons are pending support by chrome i.e. in a future version
+   * of chrome they will not prevent Back-Forward Cache usage anymore.
    */
   supportPending: 'Pending Support',
   /**
@@ -86,10 +86,10 @@ const UIStrings = {
   runTest: 'Run Test',
   /**
    * @description Explanation for 'pending support' items which prevent the page from being eligible
-   * for back-forward cache.
+   * for Back-Forward Cache.
    */
   supportPendingExplanation:
-      'Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for back-forward cache in a future version of Chrome.',
+      'Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for Back-Forward Cache in a future version of Chrome.',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/application/BackForwardCacheView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

package/front_end/panels/css_overview/components/CSSOverviewStartView.ts CHANGED Viewed

@@ -6,6 +6,7 @@ import * as i18n from '../../../core/i18n/i18n.js';
 import * as Buttons from '../../../ui/components/buttons/buttons.js';
 import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
 import * as IconButton from '../../../ui/components/icon_button/icon_button.js';
+import * as Legacy from '../../../ui/legacy/legacy.js';
 import * as LitHtml from '../../../ui/lit-html/lit-html.js';
 import cssOverviewStartViewStyles from './cssOverviewStartView.css.js';
@@ -76,14 +77,12 @@ export class OverviewStartRequestedEvent extends Event {
 export class CSSOverviewStartView extends HTMLElement {
   static readonly litTagName = LitHtml.literal`devtools-css-overview-start-view`;
   readonly #shadow = this.attachShadow({mode: 'open'});
-  #feedbackLink: HTMLAnchorElement;
+  #feedbackLink: HTMLElement;
   constructor() {
     super();
-    this.#feedbackLink = document.createElement('a');
-    this.#feedbackLink.href = FEEDBACK_LINK;
-    this.#feedbackLink.target = '_blank';
-    this.#feedbackLink.innerText = i18nString(UIStrings.feedbackInline);
+    this.#feedbackLink =
+        Legacy.XLink.XLink.create(FEEDBACK_LINK, i18nString(UIStrings.feedbackInline), 'devtools-link');
   }
   connectedCallback(): void {
@@ -106,7 +105,6 @@ export class CSSOverviewStartView extends HTMLElement {
   private render(): void {
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
-    // eslint-disable-next-line rulesdir/ban_a_tags_in_lit_html
     render(html`
       <div class="css-overview-start-view">
         <h1 class="summary-header">${i18nString(UIStrings.identifyCSSImprovements)}</h1>
@@ -144,11 +142,11 @@ export class CSSOverviewStartView extends HTMLElement {
             </div>
             <div>
               <h1 class="video-doc-header">${i18nString(UIStrings.videoAndDocumentation)}</h1>
-              <a href=${DOC_LINK} target="_blank">${i18nString(UIStrings.quickStartWithCSSOverview)}</a>
+              <x-link class="devtools-link" href=${DOC_LINK}>${i18nString(UIStrings.quickStartWithCSSOverview)}</x-link>
             </div>
           </div>
         </section>
-        <a class="feedback-standalone" href=${FEEDBACK_LINK} target="_blank">${i18nString(UIStrings.feedbackStandalone)}</a>
+        <x-link class="feedback-standalone" href=${FEEDBACK_LINK}>${i18nString(UIStrings.feedbackStandalone)}</x-link>
       </div>
     `, this.#shadow, {
       host: this,

package/front_end/panels/css_overview/components/cssOverviewStartView.css CHANGED Viewed

@@ -95,6 +95,12 @@ h1 {
   margin-bottom: 24px;
 }
+.feedback-prompt .devtools-link {
+  color: -webkit-link;
+  cursor: pointer;
+  text-decoration: underline;
+}
 .resources {
   display: flex;
   flex-direction: row;
@@ -125,7 +131,7 @@ h1 {
   font-weight: bold;
 }
-.resources a {
+.resources .devtools-link {
   font-size: 14px;
   line-height: 22px;
   letter-spacing: 0.04em;

package/front_end/panels/elements/StylesSidebarPane.ts CHANGED Viewed

@@ -1827,7 +1827,8 @@ export class StylePropertiesSection {
     containerElement.data = {
       container: ElementsComponents.Helper.legacyNodeToElementsComponentsNode(container.containerNode),
       queryName: containerQuery.name,
-      onContainerLinkClick: (): void => {
+      onContainerLinkClick: (event): void => {
+        event.preventDefault();
         ElementsPanel.instance().revealAndSelectNode(container.containerNode, true, true);
         container.containerNode.scrollIntoView();
       },

package/front_end/panels/lighthouse/LighthouseController.ts CHANGED Viewed

@@ -262,42 +262,19 @@ export class LighthouseController extends Common.ObjectWrapper.ObjectWrapper<Eve
       return '';
     }
     const mainTarget = this.manager.target();
-    const runtimeModel = mainTarget.model(SDK.RuntimeModel.RuntimeModel);
-    const executionContext = runtimeModel && runtimeModel.defaultExecutionContext();
-    let inspectedURL = mainTarget.inspectedURL();
-    if (!executionContext) {
-      return inspectedURL;
-    }
+    // target.inspectedURL is reliably populated, however it lacks any url #hash
+    const inspectedURL = mainTarget.inspectedURL();
-    // Evaluate location.href for a more specific URL than inspectedURL provides so that SPA hash navigation routes
-    // will be respected and audited.
-    try {
-      const result = await executionContext.evaluate(
-          {
-            expression: 'window.location.href',
-            objectGroup: 'lighthouse',
-            includeCommandLineAPI: false,
-            silent: false,
-            returnByValue: true,
-            generatePreview: false,
-            allowUnsafeEvalBlockedByCSP: undefined,
-            disableBreaks: undefined,
-            replMode: undefined,
-            throwOnSideEffect: undefined,
-            timeout: undefined,
-          },
-          /* userGesture */ false, /* awaitPromise */ false);
-      if ((!('exceptionDetails' in result) || !result.exceptionDetails) && 'object' in result && result.object) {
-        if (result.object.value) {
-          inspectedURL = result.object.value;
-        }
-        result.object.release();
-      }
-    } catch (err) {
-      console.error(err);
+    // We'll use the navigationHistory to acquire the current URL including hash
+    const resourceTreeModel = mainTarget.model(SDK.ResourceTreeModel.ResourceTreeModel);
+    const navHistory = resourceTreeModel && await resourceTreeModel.navigationHistory();
+    if (!resourceTreeModel || !navHistory) {
+      return inspectedURL;
     }
-    return inspectedURL;
+    const {currentIndex, entries} = navHistory;
+    const navigationEntry = entries[currentIndex];
+    return navigationEntry.url;
   }
   getFlags(): {internalDisableDeviceScreenEmulation: boolean, emulatedFormFactor: (string|undefined)} {

package/front_end/panels/lighthouse/LighthousePanel.ts CHANGED Viewed

@@ -263,7 +263,8 @@ export class LighthousePanel extends UI.Panel.Panel {
     const reportContainer = this.auditResultsElement.createChild('div', 'lh-vars lh-root lh-devtools');
-    const dom = new LighthouseReport.DOM(this.auditResultsElement.ownerDocument as Document);
+    // @ts-ignore: Second argument will soon be required.
+    const dom = new LighthouseReport.DOM(this.auditResultsElement.ownerDocument as Document, reportContainer);
     const renderer = new LighthouseReportRenderer(dom) as LighthouseReport.ReportRenderer;
     const el = renderer.renderReport(lighthouseResult, reportContainer);

package/front_end/panels/lighthouse/LighthouseReportRenderer.ts CHANGED Viewed

@@ -221,8 +221,9 @@ export class LighthouseReportUIFeatures extends LighthouseReport.ReportUIFeature
   }
   getDocument(): Document {
-    return this._document;
+    return this._dom.document();
   }
   resetUIState(): void {
     this._resetUIState();
   }

package/front_end/panels/settings/components/SyncSection.ts CHANGED Viewed

@@ -8,6 +8,7 @@ import type * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as LitHtml from '../../../ui/lit-html/lit-html.js';
 import * as Settings from '../../../ui/components/settings/settings.js';
+import * as SDK from '../../../core/sdk/sdk.js';
 import syncSectionStyles from './syncSection.css.js';
@@ -81,21 +82,31 @@ export class SyncSection extends HTMLElement {
   }
 }
+/* x-link doesn't work with custom click/keydown handlers */
+/* eslint-disable rulesdir/ban_a_tags_in_lit_html */
 function renderAccountInfoOrWarning(syncInfo: Host.InspectorFrontendHostAPI.SyncInformation): LitHtml.TemplateResult {
   if (!syncInfo.isSyncActive) {
+    const link = 'chrome://settings/syncSetup';
+    // Disabled until https://crbug.com/1079231 is fixed.
+    // clang-format off
     return LitHtml.html`
       <span class="warning">
-        ${i18nString(UIStrings.syncDisabled)} <x-link href="chrome://settings/syncSetup" class="link">${
-        i18nString(UIStrings.settings)}</x-link>
+        ${i18nString(UIStrings.syncDisabled)} <a href="${link}" class="link" target="_blank"
+          @click=${(e: Event): void => openSettingsTab(link, e)}
+          @keydown=${(e: Event): void => openSettingsTab(link, e)}>${i18nString(UIStrings.settings)}</x-link>
       </span>`;
+    // clang-format on
   }
   if (!syncInfo.arePreferencesSynced) {
+    const link = 'chrome://settings/syncSetup/advanced';
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     return LitHtml.html`
       <span class="warning">
-        ${i18nString(UIStrings.preferencesSyncDisabled)} <x-link href="chrome://settings/syncSetup/advanced" class="link">${
-        i18nString(UIStrings.settings)}</x-link>
+        ${i18nString(UIStrings.preferencesSyncDisabled)} <a href="${link}" class="link" target="_blank"
+          @click=${(e: Event): void => openSettingsTab(link, e)}
+          @keydown=${(e: Event): void => openSettingsTab(link, e)}>${i18nString(UIStrings.settings)}</x-link>
       </span>`;
     // clang-format on
   }
@@ -109,6 +120,16 @@ function renderAccountInfoOrWarning(syncInfo: Host.InspectorFrontendHostAPI.Sync
     </div>`;
 }
+// Navigating to a chrome:// link via a normal anchor doesn't work, so we "navigate"
+// there using CDP.
+function openSettingsTab(url: string, event: Event): void {
+  if (event.type === 'click' || (event.type === 'keydown' && self.isEnterOrSpaceKey(event))) {
+    const mainTarget = SDK.TargetManager.TargetManager.instance().mainTarget();
+    mainTarget && mainTarget.targetAgent().invoke_createTarget({url});
+    event.consume(true);
+  }
+}
 ComponentHelpers.CustomElements.defineComponent('devtools-sync-section', SyncSection);
 declare global {

package/front_end/third_party/codemirror.next/bundle-tsconfig.json CHANGED Viewed

@@ -16,6 +16,6 @@
     "chunk/php.js",
     "chunk/python.js",
     "chunk/wast.js",
-    "chunk/xml.js",
+    "chunk/xml.js"
   ]
 }

package/front_end/ui/components/buttons/Button.ts CHANGED Viewed

@@ -30,6 +30,7 @@ interface ButtonState {
   variant?: Variant;
   size?: Size;
   disabled: boolean;
+  active: boolean;
 }
 export type ButtonData = {
@@ -37,11 +38,13 @@ export type ButtonData = {
   iconUrl: string,
   size?: Size,
   disabled?: boolean,
+  active?: boolean,
 }|{
   variant: Variant.PRIMARY | Variant.SECONDARY,
   iconUrl?: string,
   size?: Size,
   disabled?: boolean,
+  active?: boolean,
 };
 export class Button extends HTMLElement {
@@ -52,6 +55,7 @@ export class Button extends HTMLElement {
   private readonly props: ButtonState = {
     size: Size.MEDIUM,
     disabled: false,
+    active: false,
   };
   private isEmpty = true;
@@ -69,6 +73,7 @@ export class Button extends HTMLElement {
     this.props.variant = data.variant;
     this.props.iconUrl = data.iconUrl;
     this.props.size = data.size || Size.MEDIUM;
+    this.props.active = Boolean(data.active);
     this.setDisabledProperty(data.disabled || false);
     ComponentHelpers.ScheduledRender.scheduleRender(this, this.boundRender);
   }
@@ -93,6 +98,11 @@ export class Button extends HTMLElement {
     ComponentHelpers.ScheduledRender.scheduleRender(this, this.boundRender);
   }
+  set active(active: boolean) {
+    this.props.active = active;
+    ComponentHelpers.ScheduledRender.scheduleRender(this, this.boundRender);
+  }
   private setDisabledProperty(disabled: boolean): void {
     this.props.disabled = disabled;
     this.toggleAttribute('disabled', disabled);
@@ -140,6 +150,7 @@ export class Button extends HTMLElement {
       'text-with-icon': Boolean(this.props.iconUrl) && !this.isEmpty,
       'only-icon': Boolean(this.props.iconUrl) && this.isEmpty,
       small: Boolean(this.props.size === Size.SMALL),
+      active: this.props.active,
     };
     // clang-format off
     LitHtml.render(

package/front_end/ui/components/buttons/button.css CHANGED Viewed

@@ -80,6 +80,7 @@ button.primary:hover {
   border: 1px solid var(--color-button-primary-background-hovering);
 }
+button.primary.active,
 button.primary:active {
   background: var(--color-button-primary-background-pressed);
   border: 1px solid var(--color-button-primary-background-pressed);
@@ -103,6 +104,7 @@ button.secondary:hover {
   background: var(--color-button-secondary-background-hovering);
 }
+button.secondary.active,
 button.secondary:active {
   background: var(--color-button-secondary-background-pressed);
   border: 1px solid var(--color-button-secondary-background-pressed);
@@ -120,6 +122,7 @@ button.secondary:disabled:hover {
   cursor: not-allowed;
 }
+button.secondary.active:focus-visible,
 button.secondary:active:focus-visible {
   border: 1px solid var(--color-button-secondary-background-pressed);
 }
@@ -128,6 +131,7 @@ button.toolbar:hover {
   background-color: var(--color-button-secondary-background-hovering);
 }
+button.toolbar.active,
 button.toolbar:active {
   background-color: var(--color-button-secondary-background-pressed);
 }

package/front_end/ui/components/docs/button/basic.ts CHANGED Viewed

@@ -32,6 +32,16 @@ primaryButton.innerText = 'Click me';
 primaryButton.onclick = () => alert('clicked');
 appendButton(primaryButton);
+// Primary (forced active)
+const forcedActive = new Buttons.Button.Button();
+forcedActive.data = {
+  variant: Buttons.Button.Variant.PRIMARY,
+  active: true,
+};
+forcedActive.innerText = 'Forced active';
+forcedActive.onclick = () => alert('clicked');
+appendButton(forcedActive);
 // Secondary
 const secondaryButton = new Buttons.Button.Button();
 secondaryButton.innerText = 'Click me';

package/package.json CHANGED Viewed

@@ -31,7 +31,7 @@
     "check-external-links": "third_party/node/node.py --output scripts/check_external_links.js",
     "check-gn": "third_party/node/node.py --output scripts/check_gn.js",
     "check-json": "third_party/node/node.py --output scripts/json_validator/validate_module_json.js",
-    "check-lint": "third_party/node/node.py --output scripts/test/run_lint_check_js.js && third_party/node/node.py --output scripts/test/run_lint_check_css.js",
+    "check-lint": "third_party/node/node.py --output scripts/test/run_lint_check_js.mjs && third_party/node/node.py --output scripts/test/run_lint_check_css.js",
     "check-lint-css": "third_party/node/node.py --output scripts/test/run_lint_check_css.js",
     "collect-strings": "third_party/node/node.py --output third_party/i18n/collect-strings.js front_end",
     "components-server": "third_party/node/node.py --output scripts/component_server/server.js",
@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.939473"
+  "version": "1.0.940255"
 }