chrome-devtools-frontend 1.0.939066 → 1.0.940255

package/.stylelintrc.json

@@ -27,11 +27,5 @@
     "property-no-vendor-prefix": null,
     "value-no-vendor-prefix": null,
     "media-feature-name-no-vendor-prefix": null
-  },
-  "overrides": [
-    {
-      "files": ["**/*.ts"],
-      "customSyntax": "html"
-    }
-  ]
+  }
 }

package/config/gni/all_devtools_files.gni

@@ -58,7 +58,6 @@ all_devtools_files = [
   "front_end/legacy_test_runner/layers_test_runner/layers_test_runner.js",
   "front_end/panels/layer_viewer/module.json",
   "front_end/panels/layers/module.json",
-  "front_end/entrypoints/main/module.json",
   "front_end/panels/media/module.json",
   "front_end/entrypoints/ndb_app/ndb_app.json",
   "front_end/legacy_test_runner/network_test_runner/network_test_runner.js",

package/config/gni/devtools_grd_files.gni

@@ -595,6 +595,7 @@ grd_files_debug_sources = [
   "front_end/core/sdk/CSSRule.js",
   "front_end/core/sdk/CSSStyleDeclaration.js",
   "front_end/core/sdk/CSSStyleSheetHeader.js",
+  "front_end/core/sdk/CategorizedBreakpoint.js",
   "front_end/core/sdk/ChildTargetManager.js",
   "front_end/core/sdk/CompilerSourceMappingContentProvider.js",
   "front_end/core/sdk/Connections.js",
@@ -607,6 +608,7 @@ grd_files_debug_sources = [
   "front_end/core/sdk/DOMModel.js",
   "front_end/core/sdk/DebuggerModel.js",
   "front_end/core/sdk/EmulationModel.js",
+  "front_end/core/sdk/EventBreakpointsModel.js",
   "front_end/core/sdk/FilmStripModel.js",
   "front_end/core/sdk/FrameAssociated.js",
   "front_end/core/sdk/FrameManager.js",

package/docs/triage_guidelines.md

@@ -43,22 +43,24 @@ Issues in the untriaged queue should receive a meaningful response within a busi
 
 ## How should issues be triaged?
 
-An issue is triaged when it meets the following criteria:
-
-- Priority is set correctly
-- Component is set correctly
-- Type is set correctly especially consider Feature vs Bug vs Bug-Regression
-- Status is set correctly (Available most of the time)
-- Request bisection from the Chrome Test Engineer team by adding the label "Needs-Bisect".
+- Close issues as `WontFix` if they don't reproduce (in simple cases) or are requests for features we've already concluded not to pursue.
+- Close issues as `Archived` that are valid, but it seems unlikely that we will get there anytime soon.
+- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `Hotlist-DevTools-Triaged` and leave the `Untriaged` status as is.
+- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.  
+- Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
+- Put one of the following labels on it and set the status to `Available`:
+  - `Hotlist-DevTools-ProductReview` if it's controversial or clear that consensus needs to be built first.
+  - `Hotlist-DevTools-BrowserAutomation-Backlog` if it's an issue related to ChromeDriver or puppeteer.
+  - `Hotlist-DevTools-Debugging-Backlog` if it's a debugging issue.
+  - `Hotlist-DevTools-DesignAccessibility-Backlog` if it's a design or accessibility issue.
+  - `Hotlist-DevTools-Performance-Backlog` if the issue is related to our performance tooling (i.e. Performance panel, Lighthouse).
+  - `Hotlist-DevTools-Backlog` if it's a general DevTools issue that is not specific to one of the core areas.
+- Also remember to put the `Needs-UX` label on it, if help from a designer is likely to be required.
 
 ### Setting Assigned or Available
 
 Set issues to Available if they don’t need immediate action and nobody right now and in the short-term future (an iteration) needs to work on it.
 
-If you think they should be addressed in the short-term please add the label “Hotlist-DevTools-CurrentSprint”.
-
-If you think they should be addressed mid-term or the next iteration, please add the label “Hotlist-DevTools-Backlog”
-
 Issues that are handled by Microsoft have the label “Hotlist-DevTools-MS-Backlog” and “Hotlist-DevTools-MS-CurrentSprint” respectively and can be considered triaged.
 
 If you think they are super urgent, please assign them to yangguo@chromium.org and cc bmeurer@chromium.org and hablich@chromium.org.

package/front_end/Tests.js

@@ -1290,6 +1290,7 @@
 
   TestSuite.prototype.testInspectedElementIs = async function(nodeName) {
     this.takeControl();
+    await self.runtime.loadLegacyModule('panels/elements/elements-legacy.js');
     if (!Elements.ElementsPanel.firstInspectElementNodeNameForTest) {
       await new Promise(f => this.addSniffer(Elements.ElementsPanel, 'firstInspectElementCompletedForTest', f));
     }
@@ -1438,6 +1439,38 @@
     this.releaseControl();
   };
 
+  TestSuite.prototype.testInputDispatchEventsToCorrectTarget = async function() {
+    this.takeControl();
+
+    const mainTarget = self.SDK.targetManager.mainTarget();
+    const otherTarget = await createIsolatedTarget('about:blank');
+
+    const setupLogging = `
+      window.logs = [];
+      ['dragenter', 'keydown', 'mousedown', 'mouseenter', 'mouseleave', 'mousemove', 'mouseout', 'mouseover', 'mouseup',
+       'click', 'touchcancel', 'touchend', 'touchmove', 'touchstart',
+      ].forEach((event) => window.addEventListener(event, (e) => logs.push(e.type)));`;
+    await evalCode(mainTarget, setupLogging);
+    await evalCode(otherTarget, setupLogging);
+
+    const inputAgent = mainTarget.inputAgent();
+    await inputAgent.invoke_dispatchMouseEvent({type: 'mousePressed', button: 'left', clickCount: 1, x: 100, y: 250});
+    await inputAgent.invoke_dispatchMouseEvent({type: 'mouseMoved', button: 'left', clickCount: 1, x: 110, y: 270});
+    await inputAgent.invoke_dispatchMouseEvent({type: 'mouseReleased', button: 'left', clickCount: 1, x: 110, y: 270});
+    await inputAgent.invoke_dispatchDragEvent(
+        {type: 'dragEnter', x: 100, y: 250, data: {items: [], dragOperationsMask: 1}});
+    await inputAgent.invoke_synthesizeTapGesture({x: 100, y: 250});
+    await inputAgent.invoke_dispatchKeyEvent({type: 'keyDown', key: 'a'});
+
+    const mainTargetEvents = await evalCode(mainTarget, ' logs.join(\' \')');
+    const otherTargetEvents = await evalCode(otherTarget, 'logs.join(\' \')');
+    this.assertEquals(
+        'mainTargetEvents: mouseover mousedown mousemove mouseup click dragenter keydown; otherTargetEvents: ',
+        `mainTargetEvents: ${mainTargetEvents}; otherTargetEvents: ${otherTargetEvents}`);
+
+    this.releaseControl();
+  };
+
   TestSuite.prototype.testLoadResourceForFrontend = async function(baseURL, fileURL) {
     const test = this;
     const loggedHeaders = new Set(['cache-control', 'pragma']);

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -369,4 +369,9 @@ export enum EnumeratedHistogram {
   Language = 'DevTools.Language',
   ConsoleShowsCorsErrors = 'DevTools.ConsoleShowsCorsErrors',
   SyncSetting = 'DevTools.SyncSetting',
+  RecordingEdited = 'DevTools.RecordingEdited',
+  RecordingExported = 'DevTools.RecordingExported',
+  RecordingReplayFinished = 'DevTools.RecordingReplayFinished',
+  RecordingReplayStarted = 'DevTools.RecordingReplayStarted',
+  RecordingToggled = 'DevTools.RecordingToggled',
 }

package/front_end/core/host/UserMetrics.ts

@@ -261,6 +261,31 @@ export class UserMetrics {
       InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.SyncSetting, settingValue, size);
     });
   }
+
+  recordingToggled(value: RecordingToggled): void {
+    const size = Object.keys(RecordingToggled).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingToggled, value, size);
+  }
+
+  recordingReplayFinished(value: RecordingReplayFinished): void {
+    const size = Object.keys(RecordingReplayFinished).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingReplayFinished, value, size);
+  }
+
+  recordingReplayStarted(value: RecordingReplayStarted): void {
+    const size = Object.keys(RecordingReplayStarted).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingReplayStarted, value, size);
+  }
+
+  recordingEdited(value: RecordingEdited): void {
+    const size = Object.keys(RecordingEdited).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingEdited, value, size);
+  }
+
+  recordingExported(value: RecordingExported): void {
+    const size = Object.keys(RecordingExported).length + 1;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingExported, value, size);
+  }
 }
 
 // Codes below are used to collect UMA histograms in the Chromium port.
@@ -378,6 +403,7 @@ export const PanelCodes: {
   'issues-pane': 37,
   'settings-keybinds': 38,
   'cssoverview': 39,
+  'chrome_recorder': 40,
 };
 
 export const SidebarPaneCodes: {
@@ -686,6 +712,7 @@ export const IssueCreated: {
   'CorsIssue::NoCorsRedirectModeNotFollow': 57,
   'QuirksModeIssue::QuirksMode': 58,
   'QuirksModeIssue::LimitedQuirksMode': 59,
+  DeprecationIssue: 60,
 };
 
 // TODO(crbug.com/1167717): Make this a const enum again
@@ -825,3 +852,48 @@ export enum SyncSetting {
   DevToolsSyncSettingDisabled = 3,
   DevToolsSyncSettingEnabled = 4,
 }
+
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingToggled {
+  RecordingStarted = 1,
+  RecordingFinished = 2,
+}
+
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingReplayFinished {
+  Success = 1,
+  TimeoutErrorSelectors = 2,
+  TimeoutErrorTarget = 3,
+  OtherError = 4,
+}
+
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingReplayStarted {
+  ReplayOnly = 1,
+  ReplayWithPerformanceTracing = 2,
+}
+
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingEdited {
+  SelectorPickerUsed = 1,
+  StepAdded = 2,
+  StepRemoved = 3,
+  SelectorAdded = 4,
+  SelectorRemoved = 5,
+  SelectorPartAdded = 6,
+  SelectorPartEdited = 7,
+  SelectorPartRemoved = 8,
+  TypeChanged = 9,
+  OtherEditing = 10,
+}
+
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum RecordingExported {
+  ToPuppeteer = 1,
+  ToJSON = 2,
+}

package/front_end/core/i18n/locales/en-US.json

@@ -401,6 +401,21 @@
   "core/sdk/DOMDebuggerModel.ts | xhr": {
     "message": "XHR"
   },
+  "core/sdk/EventBreakpointsModel.ts | auctionWorklet": {
+    "message": "Ad Auction Worklet"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeBidderWorkletBiddingStart": {
+    "message": "Bidder Bidding Phase Start"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeBidderWorkletReportingStart": {
+    "message": "Bidder Reporting Phase Start"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeSellerWorkletReportingStart": {
+    "message": "Seller Reporting Phase Start"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeSellerWorkletScoringStart": {
+    "message": "Seller Scoring Phase Start"
+  },
   "core/sdk/NetworkManager.ts | crossoriginReadBlockingCorb": {
     "message": "Cross-Origin Read Blocking (CORB) blocked cross-origin response {PH1} with MIME type {PH2}. See https://www.chromestatus.com/feature/5629709824032768 for more details."
   },
@@ -2037,7 +2052,7 @@
     "message": "Stop recording events"
   },
   "panels/application/ApplicationPanelCacheSection.ts | backForwardCache": {
-    "message": "Back-forward Cache"
+    "message": "Back-Forward Cache"
   },
   "panels/application/ApplicationPanelCacheSection.ts | cacheStorage": {
     "message": "Cache Storage"
@@ -2673,10 +2688,10 @@
     "message": "Pages that use WebXR are not currently eligible for back/forward cache."
   },
   "panels/application/BackForwardCacheView.ts | backForwardCacheTitle": {
-    "message": "Back-forward Cache"
+    "message": "Back-Forward Cache"
   },
   "panels/application/BackForwardCacheView.ts | bfcacheStatus": {
-    "message": "Back-forward Cache Status"
+    "message": "Back-Forward Cache Status"
   },
   "panels/application/BackForwardCacheView.ts | circumstantial": {
     "message": "Not Actionable"
@@ -2688,16 +2703,16 @@
     "message": "Main Frame"
   },
   "panels/application/BackForwardCacheView.ts | normalNavigation": {
-    "message": "Normal navigation (Not restored from back-forward cache)"
+    "message": "Normal navigation (Not restored from Back-Forward Cache)"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeeded": {
     "message": "Actionable"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeededExplanation": {
-    "message": "These reasons are actionable i.e. they can be cleaned up to make the page eligible for back-forward cache."
+    "message": "These reasons are actionable i.e. they can be cleaned up to make the page eligible for Back-Forward Cache."
   },
   "panels/application/BackForwardCacheView.ts | restoredFromBFCache": {
-    "message": "Restored from back-forward cache"
+    "message": "Restored from Back-Forward Cache"
   },
   "panels/application/BackForwardCacheView.ts | runTest": {
     "message": "Run Test"
@@ -2706,7 +2721,7 @@
     "message": "Pending Support"
   },
   "panels/application/BackForwardCacheView.ts | supportPendingExplanation": {
-    "message": "Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for back-forward cache in a future version of Chrome."
+    "message": "Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for Back-Forward Cache in a future version of Chrome."
   },
   "panels/application/BackForwardCacheView.ts | unavailable": {
     "message": "unavailable"

package/front_end/core/i18n/locales/en-XL.json

@@ -401,6 +401,21 @@
   "core/sdk/DOMDebuggerModel.ts | xhr": {
     "message": "X̂H́R̂"
   },
+  "core/sdk/EventBreakpointsModel.ts | auctionWorklet": {
+    "message": "Âd́ Âúĉt́îón̂ Ẃôŕk̂ĺêt́"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeBidderWorkletBiddingStart": {
+    "message": "B̂íd̂d́êŕ B̂íd̂d́îńĝ Ṕĥáŝé Ŝt́âŕt̂"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeBidderWorkletReportingStart": {
+    "message": "B̂íd̂d́êŕ R̂ép̂ór̂t́îńĝ Ṕĥáŝé Ŝt́âŕt̂"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeSellerWorkletReportingStart": {
+    "message": "Ŝél̂ĺêŕ R̂ép̂ór̂t́îńĝ Ṕĥáŝé Ŝt́âŕt̂"
+  },
+  "core/sdk/EventBreakpointsModel.ts | beforeSellerWorkletScoringStart": {
+    "message": "Ŝél̂ĺêŕ Ŝćôŕîńĝ Ṕĥáŝé Ŝt́âŕt̂"
+  },
   "core/sdk/NetworkManager.ts | crossoriginReadBlockingCorb": {
     "message": "Ĉŕôśŝ-Ór̂íĝín̂ Ŕêád̂ B́l̂óĉḱîńĝ (ĆÔŔB̂) b́l̂óĉḱêd́ ĉŕôśŝ-ór̂íĝín̂ ŕêśp̂ón̂śê {PH1} ẃît́ĥ ḾÎḾÊ t́ŷṕê {PH2}. Śêé ĥt́t̂ṕŝ://ẃŵẃ.ĉh́r̂óm̂éŝt́ât́ûś.ĉóm̂/f́êát̂úr̂é/5629709824032768 f̂ór̂ ḿôŕê d́êt́âíl̂ś."
   },
@@ -2037,7 +2052,7 @@
     "message": "Ŝt́ôṕ r̂éĉór̂d́îńĝ év̂én̂t́ŝ"
   },
   "panels/application/ApplicationPanelCacheSection.ts | backForwardCache": {
-    "message": "B̂áĉḱ-f̂ór̂ẃâŕd̂ Ćâćĥé"
+    "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé"
   },
   "panels/application/ApplicationPanelCacheSection.ts | cacheStorage": {
     "message": "Ĉáĉh́ê Śt̂ór̂áĝé"
@@ -2673,10 +2688,10 @@
     "message": "P̂áĝéŝ t́ĥát̂ úŝé Ŵéb̂X́R̂ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê."
   },
   "panels/application/BackForwardCacheView.ts | backForwardCacheTitle": {
-    "message": "B̂áĉḱ-f̂ór̂ẃâŕd̂ Ćâćĥé"
+    "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé"
   },
   "panels/application/BackForwardCacheView.ts | bfcacheStatus": {
-    "message": "B̂áĉḱ-f̂ór̂ẃâŕd̂ Ćâćĥé Ŝt́ât́ûś"
+    "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé Ŝt́ât́ûś"
   },
   "panels/application/BackForwardCacheView.ts | circumstantial": {
     "message": "N̂ót̂ Áĉt́îón̂áb̂ĺê"
@@ -2688,16 +2703,16 @@
     "message": "M̂áîń F̂ŕâḿê"
   },
   "panels/application/BackForwardCacheView.ts | normalNavigation": {
-    "message": "N̂ór̂ḿâĺ n̂áv̂íĝát̂íôń (N̂ót̂ ŕêśt̂ór̂éd̂ f́r̂óm̂ b́âćk̂-f́ôŕŵár̂d́ ĉáĉh́ê)"
+    "message": "N̂ór̂ḿâĺ n̂áv̂íĝát̂íôń (N̂ót̂ ŕêśt̂ór̂éd̂ f́r̂óm̂ B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê)"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeeded": {
     "message": "Âćt̂íôńâb́l̂é"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeededExplanation": {
-    "message": "T̂h́êśê ŕêáŝón̂ś âŕê áĉt́îón̂áb̂ĺê í.ê. t́ĥéŷ ćâń b̂é ĉĺêán̂éd̂ úp̂ t́ô ḿâḱê t́ĥé p̂áĝé êĺîǵîb́l̂é f̂ór̂ b́âćk̂-f́ôŕŵár̂d́ ĉáĉh́ê."
+    "message": "T̂h́êśê ŕêáŝón̂ś âŕê áĉt́îón̂áb̂ĺê í.ê. t́ĥéŷ ćâń b̂é ĉĺêán̂éd̂ úp̂ t́ô ḿâḱê t́ĥé p̂áĝé êĺîǵîb́l̂é f̂ór̂ B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê."
   },
   "panels/application/BackForwardCacheView.ts | restoredFromBFCache": {
-    "message": "R̂éŝt́ôŕêd́ f̂ŕôḿ b̂áĉḱ-f̂ór̂ẃâŕd̂ ćâćĥé"
+    "message": "R̂éŝt́ôŕêd́ f̂ŕôḿ B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé"
   },
   "panels/application/BackForwardCacheView.ts | runTest": {
     "message": "R̂ún̂ T́êśt̂"
@@ -2706,7 +2721,7 @@
     "message": "P̂én̂d́îńĝ Śûṕp̂ór̂t́"
   },
   "panels/application/BackForwardCacheView.ts | supportPendingExplanation": {
-    "message": "Ĉh́r̂óm̂é ŝúp̂ṕôŕt̂ f́ôŕ t̂h́êśê ŕêáŝón̂ś îś p̂én̂d́îńĝ í.ê. t́ĥéŷ ẃîĺl̂ ńôt́ p̂ŕêv́êńt̂ t́ĥé p̂áĝé f̂ŕôḿ b̂éîńĝ él̂íĝíb̂ĺê f́ôŕ b̂áĉḱ-f̂ór̂ẃâŕd̂ ćâćĥé îń â f́ût́ûŕê v́êŕŝíôń ôf́ Ĉh́r̂óm̂é."
+    "message": "Ĉh́r̂óm̂é ŝúp̂ṕôŕt̂ f́ôŕ t̂h́êśê ŕêáŝón̂ś îś p̂én̂d́îńĝ í.ê. t́ĥéŷ ẃîĺl̂ ńôt́ p̂ŕêv́êńt̂ t́ĥé p̂áĝé f̂ŕôḿ b̂éîńĝ él̂íĝíb̂ĺê f́ôŕ B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé îń â f́ût́ûŕê v́êŕŝíôń ôf́ Ĉh́r̂óm̂é."
   },
   "panels/application/BackForwardCacheView.ts | unavailable": {
     "message": "ûńâv́âíl̂áb̂ĺê"

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -644,6 +644,10 @@ export class TargetBase {
     return this.getAgent('Emulation');
   }
 
+  eventBreakpointsAgent(): ProtocolProxyApi.EventBreakpointsApi {
+    return this.getAgent('EventBreakpoints');
+  }
+
   heapProfilerAgent(): ProtocolProxyApi.HeapProfilerApi {
     return this.getAgent('HeapProfiler');
   }

package/front_end/core/root/Runtime.ts

@@ -232,6 +232,10 @@ export class Runtime {
   getModulesMap(): {[x: string]: Module} {
     return this.modulesMap;
   }
+
+  loadLegacyModule(modulePath: string): Promise<void> {
+    return import(`../../${modulePath}`);
+  }
 }
 
 export class ModuleDescriptor {