chrome-devtools-frontend 1.0.937775 → 1.0.939144

package/scripts/eslint_rules/lib/migrate_create_shadow_root_with_styles.js

@@ -57,13 +57,13 @@ module.exports = {
             const propertyNode = lookForCSSFileProperty(options.properties);
 
             if (propertyNode && propertyNode.value.type === 'Literal') {
-              const filenameWithExtension = propertyNode.value.value;
+              const filenameWithExtension = propertyNode.value.value.replace(/\\/g, '/');
               const filename = path.basename(filenameWithExtension, '.css');
               const newFileName = filename + 'Styles';
 
               const importDir = 'front_end/' + path.dirname(filenameWithExtension);
               const fileDir = path.dirname(context.getFilename());
-              const relativeImport = path.relative(fileDir, importDir);
+              const relativeImport = path.relative(fileDir, importDir).replace(/\\/g, '/');
               const importStatement = relativeImport === '' ?
                   `import ${newFileName} from \'./${filename}.css.js\';\n` :
                   `import ${newFileName} from \'${relativeImport}/${filename}.css.js\';\n`;

package/scripts/eslint_rules/lib/migrate_register_required_css.js

@@ -106,7 +106,7 @@ module.exports = {
 
           const importDir = 'front_end/' + path.dirname(filenameWithExtension);
           const fileDir = path.dirname(context.getFilename());
-          const relativeImport = path.relative(fileDir, importDir);
+          const relativeImport = path.relative(fileDir, importDir).replace(/\\/g, '/');
           const importStatement = relativeImport === '' ?
               `import ${newFileName} from \'./${filename}.css.js\';\n` :
               `import ${newFileName} from \'${relativeImport}/${filename}.css.js\';\n`;

package/scripts/eslint_rules/tests/check_test_definitions_test.js

@@ -62,6 +62,24 @@ ruleTester.run('check_e2e_tests', rule, {
       `,
       filename: 'test/e2e/folder/file.ts',
     },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      // Explaining comment
+      describe.skip('[crbug.com/123456]: e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}],
+    },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      // Explaining comment
+      describe.skipOnPlatforms(['mac'], '[crbug.com/123456]: e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}],
+    },
   ],
 
   invalid: [
@@ -111,5 +129,21 @@ ruleTester.run('check_e2e_tests', rule, {
       filename: 'test/e2e/folder/file.ts',
       errors: [{message: rule.meta.messages.extraBugId}],
     },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      describe.skip('e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}, {message: rule.meta.messages.comment}],
+    },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      describe.skipOnPlatforms(['mac'], 'e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}, {message: rule.meta.messages.comment}],
+    },
   ]
 });

package/scripts/eslint_rules/tests/es_modules_import_test.js

@@ -155,7 +155,8 @@ ruleTester.run('es_modules_import', rule, {
       code: 'import { Exporting } from \'./Exporting.js\';',
       filename: 'front_end/common/common.js',
       errors: [{
-        message: 'Incorrect same-namespace import: "Exporting.js". Use "import * as File from \'./File.js\';" instead.'
+        message:
+            'Incorrect same-namespace import: "./Exporting.js". Use "import * as File from \'./File.js\';" instead.'
       }],
     },
     {
@@ -220,7 +221,7 @@ ruleTester.run('es_modules_import', rule, {
       filename: 'front_end/some_folder/nested_entrypoint/nested_entrypoint.js',
       errors: [{
         message:
-            'Incorrect same-namespace import: "append-style.js". Use "import * as File from \'./File.js\';" instead.'
+            'Incorrect same-namespace import: "./append-style.js". Use "import * as File from \'./File.js\';" instead.'
       }]
     },
     {

package/scripts/eslint_rules/tests/migrate_create_shadow_root_with_styles_test.js

@@ -12,7 +12,7 @@ const ruleTester = new (require('eslint').RuleTester)({
 
 const MIGRATION_ERROR_MESSAGE = 'Import CSS file instead of passing a string into createShadowRootWithStyles';
 const MANUALLY_MIGRATE_ERROR_ESSAGE =
-    'Please manually migrate this file. Got error: Cannot read property \'properties\' of undefined';
+    'Please manually migrate this file. Got error: Cannot read properties of undefined (reading \'properties\')';
 
 ruleTester.run('check_migrate_RegisterRequiredCSS', rule, {
   valid: [

package/scripts/eslint_rules/tests/migrate_register_required_css_test.js

@@ -15,7 +15,7 @@ const ADD_WAS_SHOW_EXPECTED_ERROR_MESSAGE =
 const EDIT_WAS_SHOW_EXPECTED_ERROR_MESSAGE =
     'Import CSS file instead of using registerRequiredCSS and edit wasShown method';
 const MANUALLY_MIGRATE_ERROR_ESSAGE =
-    'Please manually migrate components/test.css as it has edge cases not covered by this script. Got error: Cannot read property \'range\' of undefined.';
+    'Please manually migrate components/test.css as it has edge cases not covered by this script. Got error: Cannot read properties of undefined (reading \'range\').';
 
 ruleTester.run('check_migrate_RegisterRequiredCSS', rule, {
   valid: [

package/front_end/panels/browser_debugger/module.json

@@ -1,6 +0,0 @@
-{
-  "dependencies": [
-    "panels/elements",
-    "panels/sources"
-  ]
-}

package/front_end/panels/elements/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/protocol_monitor/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/sources/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}