npm - chrome-devtools-frontend - Versions diffs - 1.0.937244 → 1.0.939066 - Mend

chrome-devtools-frontend 1.0.937244 → 1.0.939066

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (339) hide show

package/scripts/build/ninja/copy-files.js CHANGED Viewed

@@ -13,7 +13,7 @@ for (const file of files.split(',')) {
   // is because the file in that location might be a hardlinked file, and
   // overwriting it doesn't change the fact that it's hardlinked.
   const srcContents = fs.readFileSync(srcPath);
-  if (fs.existsSync(destPath)) {
+  if (fileExists(destPath)) {
     // Check contents, return early if match
     const destContents = fs.readFileSync(destPath);
     if (srcContents.equals(destContents)) {
@@ -26,3 +26,12 @@ for (const file of files.split(',')) {
   // gen and resources/inspector back to //front_end.
   fs.writeFileSync(destPath, srcContents);
 }
+/**
+ * Case sensitive implementation of a file look up.
+ */
+function fileExists(filePath) {
+  const dir = path.dirname(filePath);
+  const files = fs.readdirSync(dir);
+  return files.includes(path.basename(filePath));
+}

package/scripts/eslint_rules/lib/check_test_definitions.js CHANGED Viewed

@@ -47,7 +47,8 @@ module.exports = {
   create: function(context) {
     return {
       MemberExpression(node) {
-        if (node.object.name === 'it' && (node.property.name === 'skip' || node.property.name === 'skipOnPlatforms') &&
+        if ((node.object.name === 'it' || node.object.name === 'describe') &&
+            (node.property.name === 'skip' || node.property.name === 'skipOnPlatforms') &&
             node.parent.type === 'CallExpression') {
           const testNameNode = node.property.name === 'skip' ? node.parent.arguments[0] : node.parent.arguments[1];

package/scripts/eslint_rules/lib/es_modules_import.js CHANGED Viewed

@@ -16,7 +16,7 @@ const INSPECTOR_OVERLAY_DIRECTORY = path.join(__dirname, '..', '..', '..', 'fron
 const COMPONENT_DOCS_DIRECTORY = path.join(FRONT_END_DIRECTORY, 'ui', 'components', 'docs');
 const CROSS_NAMESPACE_MESSAGE =
-    'Incorrect cross-namespace import: "{{importPath}}". Use "import * as Namespace from \'../namespace/namespace.js\';" instead.';
+    'Incorrect cross-namespace import: "{{importPathForErrorMessage}}". Use "import * as Namespace from \'../namespace/namespace.js\';" instead.';
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -42,7 +42,7 @@ function computeTopLevelFolder(fileName) {
   return namespaceName.substring(0, namespaceName.indexOf(path.sep));
 }
-function checkImportExtension(importPath, context, node) {
+function checkImportExtension(importPath, importPathForErrorMessage, context, node) {
   // import * as fs from 'fs';
   if (!importPath.startsWith('.')) {
     return;
@@ -51,12 +51,12 @@ function checkImportExtension(importPath, context, node) {
   if (!importPath.endsWith('.js') && !importPath.endsWith('.mjs')) {
     context.report({
       node,
-      message: 'Missing file extension for import "{{importPath}}"',
+      message: 'Missing file extension for import "{{importPathForErrorMessage}}"',
       data: {
-        importPath,
+        importPathForErrorMessage,
       },
       fix(fixer) {
-        return fixer.replaceText(node.source, `'${importPath}.js'`);
+        return fixer.replaceText(node.source, `'${importPathForErrorMessage}.js'`);
       }
     });
   }
@@ -67,7 +67,7 @@ function nodeSpecifiersSpecialImportsOnly(specifiers) {
       ['ls', 'assertNotNullOrUndefined'].includes(specifiers[0].imported.name);
 }
-function checkStarImport(context, node, importPath, importingFileName, exportingFileName) {
+function checkStarImport(context, node, importPath, importPathForErrorMessage, importingFileName, exportingFileName) {
   if (isModuleEntrypoint(importingFileName)) {
     return;
   }
@@ -93,9 +93,9 @@ function checkStarImport(context, node, importPath, importingFileName, exporting
     context.report({
       node,
       message:
-          'Incorrect same-namespace import: "{{importPath}}". Use "import { Symbol } from \'./relative-file.js\';" instead.',
+          'Incorrect same-namespace import: "{{importPathForErrorMessage}}". Use "import { Symbol } from \'./relative-file.js\';" instead.',
       data: {
-        importPath,
+        importPathForErrorMessage,
       },
     });
   }
@@ -104,9 +104,7 @@ function checkStarImport(context, node, importPath, importingFileName, exporting
     context.report({
       node,
       message: CROSS_NAMESPACE_MESSAGE,
-      data: {
-        importPath,
-      },
+      data: {importPathForErrorMessage},
     });
   }
 }
@@ -135,12 +133,14 @@ module.exports = {
         }
         const importPath = path.normalize(node.source.value);
-        checkImportExtension(importPath, context, node);
+        const importPathForErrorMessage = node.source.value.replace(/\\/g, '/');
+        checkImportExtension(importPath, importPathForErrorMessage, context, node);
       },
       ImportDeclaration(node) {
-        checkImportExtension(node.source.value, context, node);
         const importPath = path.normalize(node.source.value);
+        const importPathForErrorMessage = node.source.value.replace(/\\/g, '/');
+        checkImportExtension(node.source.value, importPathForErrorMessage, context, node);
         // Accidental relative URL:
         // import * as Root from 'front_end/root/root.js';
@@ -173,7 +173,8 @@ module.exports = {
         const exportingFileName = path.resolve(path.dirname(importingFileName), importPath);
-        if (importPath.includes('/front_end/') && !importingFileIsUnitTestFile && !importingFileIsComponentDocsFile) {
+        if (importPath.replace(/\\/g, '/').includes('/front_end/') && !importingFileIsUnitTestFile &&
+            !importingFileIsComponentDocsFile) {
           context.report({
             node,
             message:
@@ -181,14 +182,14 @@ module.exports = {
           });
         }
-        if (importPath.endsWith(path.join('platform', 'platform.js')) &&
+        if (importPathForErrorMessage.endsWith('platform/platform.js') &&
             nodeSpecifiersSpecialImportsOnly(node.specifiers)) {
           /* We allow direct importing of the ls and assertNotNull utility as it's so frequently used. */
           return;
         }
         if (isStarAsImportSpecifier(node.specifiers)) {
-          checkStarImport(context, node, importPath, importingFileName, exportingFileName);
+          checkStarImport(context, node, importPath, importPathForErrorMessage, importingFileName, exportingFileName);
         } else {
           if (computeTopLevelFolder(importingFileName) !== computeTopLevelFolder(exportingFileName)) {
             let message = CROSS_NAMESPACE_MESSAGE;
@@ -206,7 +207,7 @@ module.exports = {
               node,
               message,
               data: {
-                importPath,
+                importPathForErrorMessage,
               },
             });
           } else if (isModuleEntrypoint(importingFileName)) {
@@ -222,9 +223,9 @@ module.exports = {
             context.report({
               node,
               message:
-                  'Incorrect same-namespace import: "{{importPath}}". Use "import * as File from \'./File.js\';" instead.',
+                  'Incorrect same-namespace import: "{{importPathForErrorMessage}}". Use "import * as File from \'./File.js\';" instead.',
               data: {
-                importPath,
+                importPathForErrorMessage,
               }
             });
           }

package/scripts/eslint_rules/lib/l10n_filename_matches.js CHANGED Viewed

@@ -64,12 +64,13 @@ module.exports = {
         const previousFileLocationArgument = callExpression.arguments[0];
         const actualPath = path.join(FRONT_END_DIRECTORY, previousFileLocationArgument.value);
         if (!allowedPathArguments.includes(actualPath)) {
+          const newFileName = currentFileRelativeToFrontEnd.replace(/\\/g, '/');
           context.report({
             node: callExpression,
-            message: `First argument to 'registerUIStrings' call must be '${
-                currentFileRelativeToFrontEnd}' or the ModuleUIStrings.(js|ts)`,
+            message:
+                `First argument to 'registerUIStrings' call must be '${newFileName}' or the ModuleUIStrings.(js|ts)`,
             fix(fixer) {
-              return fixer.replaceText(previousFileLocationArgument, `'${currentFileRelativeToFrontEnd}'`);
+              return fixer.replaceText(previousFileLocationArgument, `'${newFileName}'`);
             }
           });
         }

package/scripts/eslint_rules/lib/migrate_create_shadow_root_with_styles.js CHANGED Viewed

@@ -57,13 +57,13 @@ module.exports = {
             const propertyNode = lookForCSSFileProperty(options.properties);
             if (propertyNode && propertyNode.value.type === 'Literal') {
-              const filenameWithExtension = propertyNode.value.value;
+              const filenameWithExtension = propertyNode.value.value.replace(/\\/g, '/');
               const filename = path.basename(filenameWithExtension, '.css');
               const newFileName = filename + 'Styles';
               const importDir = 'front_end/' + path.dirname(filenameWithExtension);
               const fileDir = path.dirname(context.getFilename());
-              const relativeImport = path.relative(fileDir, importDir);
+              const relativeImport = path.relative(fileDir, importDir).replace(/\\/g, '/');
               const importStatement = relativeImport === '' ?
                   `import ${newFileName} from \'./${filename}.css.js\';\n` :
                   `import ${newFileName} from \'${relativeImport}/${filename}.css.js\';\n`;

package/scripts/eslint_rules/lib/migrate_register_required_css.js CHANGED Viewed

@@ -106,7 +106,7 @@ module.exports = {
           const importDir = 'front_end/' + path.dirname(filenameWithExtension);
           const fileDir = path.dirname(context.getFilename());
-          const relativeImport = path.relative(fileDir, importDir);
+          const relativeImport = path.relative(fileDir, importDir).replace(/\\/g, '/');
           const importStatement = relativeImport === '' ?
               `import ${newFileName} from \'./${filename}.css.js\';\n` :
               `import ${newFileName} from \'${relativeImport}/${filename}.css.js\';\n`;

package/scripts/eslint_rules/tests/check_test_definitions_test.js CHANGED Viewed

@@ -62,6 +62,24 @@ ruleTester.run('check_e2e_tests', rule, {
       `,
       filename: 'test/e2e/folder/file.ts',
     },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      // Explaining comment
+      describe.skip('[crbug.com/123456]: e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}],
+    },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      // Explaining comment
+      describe.skipOnPlatforms(['mac'], '[crbug.com/123456]: e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}],
+    },
   ],
   invalid: [
@@ -111,5 +129,21 @@ ruleTester.run('check_e2e_tests', rule, {
       filename: 'test/e2e/folder/file.ts',
       errors: [{message: rule.meta.messages.extraBugId}],
     },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      describe.skip('e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}, {message: rule.meta.messages.comment}],
+    },
+    {
+      code: `import {describe, it} from '../../shared/mocha-extensions.js';
+      describe.skipOnPlatforms(['mac'], 'e2e-test', async () => {
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}, {message: rule.meta.messages.comment}],
+    },
   ]
 });

package/scripts/eslint_rules/tests/es_modules_import_test.js CHANGED Viewed

@@ -155,7 +155,8 @@ ruleTester.run('es_modules_import', rule, {
       code: 'import { Exporting } from \'./Exporting.js\';',
       filename: 'front_end/common/common.js',
       errors: [{
-        message: 'Incorrect same-namespace import: "Exporting.js". Use "import * as File from \'./File.js\';" instead.'
+        message:
+            'Incorrect same-namespace import: "./Exporting.js". Use "import * as File from \'./File.js\';" instead.'
       }],
     },
     {
@@ -220,7 +221,7 @@ ruleTester.run('es_modules_import', rule, {
       filename: 'front_end/some_folder/nested_entrypoint/nested_entrypoint.js',
       errors: [{
         message:
-            'Incorrect same-namespace import: "append-style.js". Use "import * as File from \'./File.js\';" instead.'
+            'Incorrect same-namespace import: "./append-style.js". Use "import * as File from \'./File.js\';" instead.'
       }]
     },
     {

package/scripts/eslint_rules/tests/migrate_create_shadow_root_with_styles_test.js CHANGED Viewed

@@ -12,7 +12,7 @@ const ruleTester = new (require('eslint').RuleTester)({
 const MIGRATION_ERROR_MESSAGE = 'Import CSS file instead of passing a string into createShadowRootWithStyles';
 const MANUALLY_MIGRATE_ERROR_ESSAGE =
-    'Please manually migrate this file. Got error: Cannot read property \'properties\' of undefined';
+    'Please manually migrate this file. Got error: Cannot read properties of undefined (reading \'properties\')';
 ruleTester.run('check_migrate_RegisterRequiredCSS', rule, {
   valid: [

package/scripts/eslint_rules/tests/migrate_register_required_css_test.js CHANGED Viewed

@@ -15,7 +15,7 @@ const ADD_WAS_SHOW_EXPECTED_ERROR_MESSAGE =
 const EDIT_WAS_SHOW_EXPECTED_ERROR_MESSAGE =
     'Import CSS file instead of using registerRequiredCSS and edit wasShown method';
 const MANUALLY_MIGRATE_ERROR_ESSAGE =
-    'Please manually migrate components/test.css as it has edge cases not covered by this script. Got error: Cannot read property \'range\' of undefined.';
+    'Please manually migrate components/test.css as it has edge cases not covered by this script. Got error: Cannot read properties of undefined (reading \'range\').';
 ruleTester.run('check_migrate_RegisterRequiredCSS', rule, {
   valid: [