chrome-devtools-frontend 1.0.935332 → 1.0.936736

package/front_end/ui/legacy/components/inline_editor/BezierEditor.ts

@@ -6,6 +6,7 @@ import * as Common from '../../../../core/common/common.js';
 import * as Platform from '../../../../core/platform/platform.js';
 import * as UI from '../../legacy.js';
 
+import bezierEditorStyles from './bezierEditor.css.js';
 import {BezierUI} from './BezierUI.js';
 
 export class BezierEditor extends Common.ObjectWrapper.eventMixin<EventTypes, typeof UI.Widget.VBox>(UI.Widget.VBox) {
@@ -29,7 +30,6 @@ export class BezierEditor extends Common.ObjectWrapper.eventMixin<EventTypes, ty
   constructor(bezier: UI.Geometry.CubicBezier) {
     super(true);
     this.bezierInternal = bezier;
-    this.registerRequiredCSS('ui/legacy/components/inline_editor/bezierEditor.css');
     this.contentElement.tabIndex = 0;
     this.setDefaultFocusedElement(this.contentElement);
 
@@ -79,6 +79,7 @@ export class BezierEditor extends Common.ObjectWrapper.eventMixin<EventTypes, ty
   }
 
   wasShown(): void {
+    this.registerCSSFiles([bezierEditorStyles]);
     this.unselectPresets();
     // Check if bezier matches a preset
     for (const category of this.presetCategories) {

package/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts

@@ -9,6 +9,7 @@ import * as UI from '../../legacy.js';
 
 import type {CSSShadowModel} from './CSSShadowModel.js';
 import {CSSLength} from './CSSShadowModel.js';
+import cssShadowEditorStyles from './cssShadowEditor.css.js';
 
 const UIStrings = {
   /**
@@ -61,7 +62,6 @@ export class CSSShadowEditor extends Common.ObjectWrapper.eventMixin<EventTypes,
   private changedElement?: HTMLInputElement|null;
   constructor() {
     super(true);
-    this.registerRequiredCSS('ui/legacy/components/inline_editor/cssShadowEditor.css');
     this.contentElement.tabIndex = 0;
     this.setDefaultFocusedElement(this.contentElement);
 
@@ -106,7 +106,7 @@ export class CSSShadowEditor extends Common.ObjectWrapper.eventMixin<EventTypes,
     field.appendChild(textInput);
     textInput.id = propertyName;
     textInput.addEventListener('keydown', this.handleValueModification.bind(this), false);
-    textInput.addEventListener('mousewheel', this.handleValueModification.bind(this), false);
+    textInput.addEventListener('wheel', this.handleValueModification.bind(this), false);
     textInput.addEventListener('input', this.onTextInput.bind(this), false);
     textInput.addEventListener('blur', this.onTextBlur.bind(this), false);
     return textInput;
@@ -120,6 +120,7 @@ export class CSSShadowEditor extends Common.ObjectWrapper.eventMixin<EventTypes,
   }
 
   wasShown(): void {
+    this.registerCSSFiles([cssShadowEditorStyles]);
     this.updateUI();
   }
 

package/front_end/ui/legacy/components/inline_editor/FontEditor.ts

@@ -8,6 +8,7 @@ import * as SDK from '../../../../core/sdk/sdk.js';
 import * as IconButton from '../../../components/icon_button/icon_button.js';
 import * as UI from '../../legacy.js';
 
+import fontEditorStyles from './fontEditor.css.js';
 import * as FontEditorUnitConverter from './FontEditorUnitConverter.js';
 import * as FontEditorUtils from './FontEditorUtils.js';
 
@@ -123,7 +124,6 @@ export class FontEditor extends Common.ObjectWrapper.eventMixin<EventTypes, type
 
   constructor(propertyMap: Map<string, string>) {
     super(true);
-    this.registerRequiredCSS('ui/legacy/components/inline_editor/fontEditor.css');
     this.selectedNode = UI.Context.Context.instance().flavor(SDK.DOMModel.DOMNode);
 
     this.propertyMap = propertyMap;
@@ -174,6 +174,10 @@ export class FontEditor extends Common.ObjectWrapper.eventMixin<EventTypes, type
         /** hasUnits= */ true);
   }
 
+  wasShown(): void {
+    this.registerCSSFiles([fontEditorStyles]);
+  }
+
   private async createFontSelectorSection(propertyValue?: string): Promise<void> {
     if (propertyValue) {
       // FIXME(crbug.com/1148434): propertyValue will not be split correctly for font family names that contain commas.

package/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts

@@ -7,6 +7,7 @@ import * as Platform from '../../../../core/platform/platform.js';
 import * as UI from '../../legacy.js';
 
 import {ColorSwatch} from './ColorSwatch.js';
+import swatchPopoverStyles from './swatchPopover.css.js';
 
 export class SwatchPopoverHelper extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   private readonly popover: UI.GlassPane.GlassPane;
@@ -22,7 +23,6 @@ export class SwatchPopoverHelper extends Common.ObjectWrapper.ObjectWrapper<Even
   constructor() {
     super();
     this.popover = new UI.GlassPane.GlassPane();
-    this.popover.registerRequiredCSS('ui/legacy/components/inline_editor/swatchPopover.css');
     this.popover.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);
     this.popover.setMarginBehavior(UI.GlassPane.MarginBehavior.Arrow);
     this.popover.element.addEventListener('mousedown', e => e.consume(), false);
@@ -60,6 +60,7 @@ export class SwatchPopoverHelper extends Common.ObjectWrapper.ObjectWrapper<Even
       this.hide(true);
     }
 
+    this.popover.registerCSSFiles([swatchPopoverStyles]);
     this.dispatchEventToListeners(Events.WillShowPopover);
 
     this.isHidden = false;

package/front_end/ui/legacy/components/inline_editor/Swatches.ts

@@ -8,6 +8,8 @@ import * as UI from '../../legacy.js';
 
 import {ColorSwatch, FormatChangedEvent} from './ColorSwatch.js';
 import type {CSSShadowModel} from './CSSShadowModel.js';
+import bezierSwatchStyles from './bezierSwatch.css.js';
+import cssShadowSwatchStyles from './cssShadowSwatch.css.js';
 
 export class BezierSwatch extends HTMLSpanElement {
   private readonly iconElementInternal: UI.Icon.Icon;
@@ -16,7 +18,7 @@ export class BezierSwatch extends HTMLSpanElement {
   constructor() {
     super();
     const root = UI.Utils.createShadowRootWithCoreStyles(this, {
-      cssFile: 'ui/legacy/components/inline_editor/bezierSwatch.css',
+      cssFile: [bezierSwatchStyles],
       delegatesFocus: undefined,
     });
     this.iconElementInternal = UI.Icon.Icon.create('smallicon-bezier', 'bezier-swatch-icon');
@@ -63,7 +65,7 @@ export class CSSShadowSwatch extends HTMLSpanElement {
   constructor() {
     super();
     const root = UI.Utils.createShadowRootWithCoreStyles(this, {
-      cssFile: 'ui/legacy/components/inline_editor/cssShadowSwatch.css',
+      cssFile: [cssShadowSwatchStyles],
       delegatesFocus: undefined,
     });
     this.iconElementInternal = UI.Icon.Icon.create('smallicon-shadow', 'shadow-swatch-icon');

package/front_end/ui/legacy/inspectorCommon.css

@@ -390,7 +390,7 @@ input::placeholder {
 .chrome-select:enabled:active,
 .chrome-select:enabled:focus,
 .chrome-select:enabled:hover {
-  --override-select-box-shadow: 0 1px 2px rgb(0 0 0 / 10%);
+  --override-select-box-shadow: 0 0 0 2px var(--color-button-outline-focus);
 
   background-color: var(--color-background-elevation-1);
   box-shadow: var(--override-select-box-shadow);
@@ -401,10 +401,7 @@ input::placeholder {
 }
 
 .chrome-select:enabled:focus {
-  --override-extra-box-shadow-focus: 0 0 0 2px rgb(66 133 244 / 40%);
-
   border-color: transparent;
-  box-shadow: var(--override-select-box-shadow), var(--override-extra-box-shadow-focus);
 }
 
 .-theme-with-dark-background .chrome-select:enabled:active,
@@ -413,14 +410,7 @@ input::placeholder {
 :host-context(.-theme-with-dark-background) .chrome-select:enabled:active,
 :host-context(.-theme-with-dark-background) .chrome-select:enabled:focus,
 :host-context(.-theme-with-dark-background) .chrome-select:enabled:hover {
-  --override-select-box-shadow: 0 1px 2px rgb(230 230 230 / 10%);
-}
-
-/* Disabled so we can keep all the selectors above in one block */
-/* stylelint-disable-next-line no-descending-specificity */
-.-theme-with-dark-background .chrome-select:enabled:focus,
-:host-context(.-theme-with-dark-background) .chrome-select:enabled:focus {
-  --override-extra-box-shadow-focus: 0 0 0 2px rgb(11 78 189 / 40%);
+  --override-select-box-shadow: 0 0 0 2px var(--color-button-outline-focus);
 }
 
 .chrome-select-label {

package/front_end/ui/legacy/softDropDownButton.css

@@ -23,17 +23,6 @@ button.soft-dropdown > .title {
   text-overflow: ellipsis;
 }
 
-button.soft-dropdown:focus-visible::before {
-  content: "";
-  position: absolute;
-  top: 2px;
-  left: 2px;
-  right: 2px;
-  bottom: 2px;
-  border-radius: 2px;
-  background: var(--divider-line);
-}
-
 @media (forced-colors: active) {
   button.soft-dropdown {
     border: 1px solid ButtonText;

package/front_end/ui/legacy/themeColors.css

@@ -240,7 +240,7 @@
   --color-input-outline-disabled: rgba(189 193 198 / 20%);
   --color-input-text-disabled: rgba(128 134 139 / 70%);
   /* Colors for styling buttons */
-  --color-button-outline-focus: rgb(138 180 248 / 80%);
+  --color-button-outline-focus: rgb(138 180 248 / 75%);
   --color-button-primary-background-hovering: rgb(174 203 250 / 100%);
   --color-button-primary-background-pressed: rgb(210 227 252 / 100%);
   --color-button-primary-text: rgb(0 0 0);
@@ -265,10 +265,10 @@
   --color-token-builtin: rgb(159 180 214);
   --color-token-variable-special: rgb(0 85 170);
   --color-token-keyword: rgb(154 127 213);
-  --color-token-number: var(--color-token-number);
   --color-token-string: rgb(242 139 84);
   --color-token-string-special: var(--color-token-string);
   --color-token-atom: rgb(161 247 181);
+  --color-token-number: var(--color-token-atom);
   --color-token-comment: rgb(137 137 137);
   --color-token-tag: rgb(93 176 215);
   --color-token-attribute: rgb(155 187 220);

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.935332"
+  "version": "1.0.936736"
 }

package/scripts/build/rollup.config.js

@@ -75,6 +75,9 @@ export default commandLineArgs => ({
       options: {
         strategy: minifyHTMLStrategy,
         minifyOptions: {
+          collapseInlineTagWhitespace: false,
+          collapseWhitespace: true,
+          conservativeCollapse: true,
           minifyCSS: false,
           removeOptionalTags: true,
         },

package/scripts/eslint_rules/lib/ban_a_tags_in_lit_html.js

@@ -0,0 +1,47 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+function isLitHtmlTemplateCall(taggedTemplateExpression) {
+  if (taggedTemplateExpression.name) {
+    // Call to html`` and we assume that html = LitHtml's html function.
+    return taggedTemplateExpression.name === 'html';
+  }
+
+  // Match calls to LitHtml.html``
+  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
+      taggedTemplateExpression.property.name === 'html';
+}
+
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Check for <a> and </a> in Lit templates instead of using x-link.',
+      category: 'Possible Errors',
+    },
+    fixable: 'code',
+    schema: []  // no options
+  },
+  create: function(context) {
+    return {
+      TaggedTemplateExpression(node) {
+        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        if (!isLitHtmlCall) {
+          return;
+        }
+
+        // node.quasi.quasis are all the static parts of the template literal.
+        for (const templatePart of node.quasi.quasis) {
+          if (templatePart.value.raw.includes('<a') || templatePart.value.raw.includes('</a>')) {
+            context.report({
+              node,
+              message: 'Adding links to a component should be done using `front_end/ui/legacy/XLink.ts`',
+            });
+          }
+        }
+      },
+    };
+  }
+};

package/scripts/eslint_rules/tests/ban_a_tags_in_lit_html_test.js

@@ -0,0 +1,60 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+const rule = require('../lib/ban_a_tags_in_lit_html.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+  parser: require.resolve('@typescript-eslint/parser'),
+});
+
+const EXPECTED_ERROR_MESSAGE = 'Adding links to a component should be done using `front_end/ui/legacy/XLink.ts`';
+
+ruleTester.run('ban_a_tags_in_lit_html', rule, {
+  valid: [
+    {
+      code: 'LitHtml.html`<p></p>`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code: 'LitHtml.html`<input />`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code: 'LitHtml.html`<${DataGrid.litTagName}></${DataGrid.litTagName}>`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code: 'LitHtml.html`<p><${DataGrid.litTagName}></${DataGrid.litTagName}></p>`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code:
+          'LitHtml.html`<${DataGrid1.litTagName}><${DataGrid2.litTagName}></${DataGrid2.litTagName}></${DataGrid1.litTagName}>`',
+      filename: 'front_end/components/test.ts',
+    }
+  ],
+  invalid: [
+    {
+      code: 'LitHtml.html`<a />`',
+      filename: 'front_end/components/test.ts',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+    {
+      code: 'LitHtml.html`<a></a>`',
+      filename: 'front_end/components/test.ts',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+    {code: 'LitHtml.html`</a>`', filename: 'front_end/components/test.ts', errors: [{message: EXPECTED_ERROR_MESSAGE}]},
+    {code: 'LitHtml.html`<a >`', filename: 'front_end/components/test.ts', errors: [{message: EXPECTED_ERROR_MESSAGE}]},
+    {
+      code: 'LitHtml.html`<p><${DataGrid.litTagName}></${DataGrid.litTagName}><a></a></p>`',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+    {
+      code: 'LitHtml.html`<${DataGrid.litTagName}><a /></${DataGrid.litTagName}>`',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+  ]
+});

package/front_end/entrypoints/node_main/module.json

@@ -1,8 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "nodeConnectionsPanel.css"
-  ]
-}

package/front_end/panels/console_counters/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/developer_resources/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/event_listeners/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/help/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/input/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/mobile_throttling/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/performance_monitor/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/search/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/settings/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/web_audio/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/webauthn/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/ui/legacy/components/color_picker/module.json

@@ -1,8 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "spectrum.css"
-  ]
-}

package/front_end/ui/legacy/components/cookie_table/module.json

@@ -1,8 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "cookiesTable.css"
-  ]
-}

package/front_end/ui/legacy/components/inline_editor/module.json

@@ -1,14 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "bezierEditor.css",
-    "colorSwatch.css",
-    "bezierSwatch.css",
-    "cssShadowSwatch.css",
-    "cssShadowEditor.css",
-    "fontEditor.css",
-    "swatchPopover.css"
-  ]
-}