chrome-devtools-frontend 1.0.935332 → 1.0.935784

package/config/gni/all_devtools_files.gni

@@ -170,12 +170,10 @@ all_devtools_files = [
   "front_end/models/issues_manager/descriptions/TwaDigitalAssetLinksFailed.md",
   "front_end/models/issues_manager/descriptions/TwaHttpError.md",
   "front_end/models/issues_manager/descriptions/TwaPageUnavailableOffline.md",
-  "front_end/panels/developer_resources/module.json",
   "front_end/panels/protocol_monitor/module.json",
   "front_end/panels/application/module.json",
   "front_end/panels/screencast/module.json",
   "front_end/legacy_test_runner/sdk_test_runner/sdk_test_runner.js",
-  "front_end/panels/search/module.json",
   "front_end/legacy_test_runner/security_test_runner/security_test_runner.js",
   "front_end/panels/security/module.json",
   "front_end/panels/settings/module.json",

package/config/gni/devtools_grd_files.gni

@@ -360,7 +360,6 @@ grd_files_release_sources = [
   "front_end/panels/css_overview/css_overview_module.js",
   "front_end/panels/developer_resources/developer_resources-meta.js",
   "front_end/panels/developer_resources/developer_resources.js",
-  "front_end/panels/developer_resources/developer_resources_module.js",
   "front_end/panels/elements/components/components.js",
   "front_end/panels/elements/elements-legacy.js",
   "front_end/panels/elements/elements-meta.js",
@@ -422,7 +421,6 @@ grd_files_release_sources = [
   "front_end/panels/screencast/screencast.js",
   "front_end/panels/search/search-legacy.js",
   "front_end/panels/search/search.js",
-  "front_end/panels/search/search_module.js",
   "front_end/panels/security/security-legacy.js",
   "front_end/panels/security/security-meta.js",
   "front_end/panels/security/security.js",
@@ -737,7 +735,6 @@ grd_files_debug_sources = [
   "front_end/models/issues_manager/ContrastCheckTrigger.js",
   "front_end/models/issues_manager/CorsIssue.js",
   "front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.js",
-  "front_end/models/issues_manager/DeprecationIssue.js",
   "front_end/models/issues_manager/GenericIssue.js",
   "front_end/models/issues_manager/HeavyAdIssue.js",
   "front_end/models/issues_manager/Issue.js",
@@ -747,6 +744,7 @@ grd_files_debug_sources = [
   "front_end/models/issues_manager/LowTextContrastIssue.js",
   "front_end/models/issues_manager/MarkdownIssueDescription.js",
   "front_end/models/issues_manager/MixedContentIssue.js",
+  "front_end/models/issues_manager/NavigatorUserAgentIssue.js",
   "front_end/models/issues_manager/QuirksModeIssue.js",
   "front_end/models/issues_manager/RelatedIssue.js",
   "front_end/models/issues_manager/SameSiteCookieIssue.js",

package/front_end/Tests.js

@@ -1520,6 +1520,19 @@
     this.evaluateInConsole_(`new WebSocket('ws://127.0.0.1:${websocketPort}')`, () => {});
   };
 
+  TestSuite.prototype.testExtensionWebSocketOfflineNetworkConditions = async function(websocketPort) {
+    self.SDK.multitargetNetworkManager.setNetworkConditions(SDK.NetworkManager.OfflineConditions);
+
+    // TODO(crbug.com/1263900): Currently we don't send loadingFailed for web sockets.
+    // Update this once we do.
+    this.addSniffer(SDK.NetworkDispatcher.prototype, 'webSocketClosed', () => {
+      this.releaseControl();
+    });
+
+    this.takeControl();
+    this.evaluateInConsole_(`new WebSocket('ws://127.0.0.1:${websocketPort}/echo-with-no-extension')`, () => {});
+  };
+
   /**
    * Serializes array of uiSourceCodes to string.
    * @param {!Array.<!Workspace.UISourceCode>} uiSourceCodes

package/front_end/core/i18n/locales/en-US.json

@@ -1331,9 +1331,6 @@
   "models/issues_manager/CrossOriginEmbedderPolicyIssue.ts | samesiteAndSameorigin": {
     "message": "Same-Site and Same-Origin"
   },
-  "models/issues_manager/DeprecationIssue.ts | userAgentReduction": {
-    "message": "User-Agent String Reduction"
-  },
   "models/issues_manager/GenericIssue.ts | crossOriginPortalPostMessage": {
     "message": "Portals - Same-origin communication channels"
   },
@@ -1364,6 +1361,9 @@
   "models/issues_manager/MixedContentIssue.ts | preventingMixedContent": {
     "message": "Preventing mixed content"
   },
+  "models/issues_manager/NavigatorUserAgentIssue.ts | userAgentReduction": {
+    "message": "User-Agent String Reduction"
+  },
   "models/issues_manager/QuirksModeIssue.ts | documentCompatibilityMode": {
     "message": "Document compatibility mode"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -1331,9 +1331,6 @@
   "models/issues_manager/CrossOriginEmbedderPolicyIssue.ts | samesiteAndSameorigin": {
     "message": "Ŝám̂é-Ŝít̂é âńd̂ Śâḿê-Ór̂íĝín̂"
   },
-  "models/issues_manager/DeprecationIssue.ts | userAgentReduction": {
-    "message": "Ûśêŕ-Âǵêńt̂ Śt̂ŕîńĝ Ŕêd́ûćt̂íôń"
-  },
   "models/issues_manager/GenericIssue.ts | crossOriginPortalPostMessage": {
     "message": "P̂ór̂t́âĺŝ - Śâḿê-ór̂íĝín̂ ćôḿm̂ún̂íĉát̂íôń ĉh́âńn̂él̂ś"
   },
@@ -1364,6 +1361,9 @@
   "models/issues_manager/MixedContentIssue.ts | preventingMixedContent": {
     "message": "P̂ŕêv́êńt̂ín̂ǵ m̂íx̂éd̂ ćôńt̂én̂t́"
   },
+  "models/issues_manager/NavigatorUserAgentIssue.ts | userAgentReduction": {
+    "message": "Ûśêŕ-Âǵêńt̂ Śt̂ŕîńĝ Ŕêd́ûćt̂íôń"
+  },
   "models/issues_manager/QuirksModeIssue.ts | documentCompatibilityMode": {
     "message": "D̂óĉúm̂én̂t́ ĉóm̂ṕât́îb́îĺît́ŷ ḿôd́ê"
   },

package/front_end/entrypoints/devtools_app/devtools_app.json

@@ -12,7 +12,6 @@
     { "name": "panels/elements" },
     { "name": "emulated_devices" },
     { "name": "panels/issues" },
-    { "name": "panels/developer_resources" },
     { "name": "panels/help" },
     { "name": "panels/layers" },
     { "name": "panels/layer_viewer" },

package/front_end/entrypoints/shell/shell.json

@@ -13,7 +13,6 @@
     { "name": "ui/legacy/components/perf_ui" },
     { "name": "panels/profiler" },
     { "name": "panels/protocol_monitor"},
-    { "name": "panels/search" },
     { "name": "panels/settings" },
     { "name": "ui/legacy/components/source_frame" },
     { "name": "panels/sources" },

package/front_end/entrypoints/worker_app/worker_app.json

@@ -7,7 +7,6 @@
     { "name": "panels/elements" },
     { "name": "panels/help" },
     { "name": "panels/issues" },
-    { "name": "panels/developer_resources" },
     { "name": "panels/layer_viewer" },
     { "name": "panels/network" },
     { "name": "panels/application" },

package/front_end/models/issues_manager/IssuesManager.ts

@@ -11,13 +11,13 @@ import {AttributionReportingIssue} from './AttributionReportingIssue.js';
 import {ContentSecurityPolicyIssue} from './ContentSecurityPolicyIssue.js';
 import {CorsIssue} from './CorsIssue.js';
 import {CrossOriginEmbedderPolicyIssue, isCrossOriginEmbedderPolicyIssue} from './CrossOriginEmbedderPolicyIssue.js';
-import {DeprecationIssue} from './DeprecationIssue.js';
 import {GenericIssue} from './GenericIssue.js';
 import {HeavyAdIssue} from './HeavyAdIssue.js';
 import type {Issue, IssueKind} from './Issue.js';
 import {Events} from './IssuesManagerEvents.js';
 import {LowTextContrastIssue} from './LowTextContrastIssue.js';
 import {MixedContentIssue} from './MixedContentIssue.js';
+import {NavigatorUserAgentIssue} from './NavigatorUserAgentIssue.js';
 import {QuirksModeIssue} from './QuirksModeIssue.js';
 import {SameSiteCookieIssue} from './SameSiteCookieIssue.js';
 import {SharedArrayBufferIssue} from './SharedArrayBufferIssue.js';
@@ -85,7 +85,7 @@ const issueCodeHandlers = new Map<
   ],
   [
     Protocol.Audits.InspectorIssueCode.NavigatorUserAgentIssue,
-    DeprecationIssue.fromInspectorIssue,
+    NavigatorUserAgentIssue.fromInspectorIssue,
   ],
   [
     Protocol.Audits.InspectorIssueCode.AttributionReportingIssue,

package/front_end/models/issues_manager/{DeprecationIssue.ts → NavigatorUserAgentIssue.ts}

@@ -17,7 +17,7 @@ const UIStrings = {
    */
   userAgentReduction: 'User-Agent String Reduction',
 };
-const str_ = i18n.i18n.registerUIStrings('models/issues_manager/DeprecationIssue.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('models/issues_manager/NavigatorUserAgentIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 // TODO(crbug.com/1167717): Make this a const enum again
@@ -26,7 +26,7 @@ export enum IssueCode {
   NavigatorUserAgentIssue = 'DeprecationIssue::NavigatorUserAgentIssue',
 }
 
-export class DeprecationIssue extends Issue<IssueCode> {
+export class NavigatorUserAgentIssue extends Issue<IssueCode> {
   private issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
@@ -73,12 +73,12 @@ export class DeprecationIssue extends Issue<IssueCode> {
   }
 
   static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):
-      DeprecationIssue[] {
+      NavigatorUserAgentIssue[] {
     const details = inspectorIssue.details.navigatorUserAgentIssueDetails;
     if (!details) {
       console.warn('NavigatorUserAgent issue without details received.');
       return [];
     }
-    return [new DeprecationIssue(details, issuesModel)];
+    return [new NavigatorUserAgentIssue(details, issuesModel)];
   }
 }

package/front_end/models/issues_manager/issues_manager.ts

@@ -7,7 +7,6 @@ import * as ContentSecurityPolicyIssue from './ContentSecurityPolicyIssue.js';
 import * as ContrastCheckTrigger from './ContrastCheckTrigger.js';
 import * as CorsIssue from './CorsIssue.js';
 import * as CrossOriginEmbedderPolicyIssue from './CrossOriginEmbedderPolicyIssue.js';
-import * as DeprecationIssue from './DeprecationIssue.js';
 import * as GenericIssue from './GenericIssue.js';
 import * as HeavyAdIssue from './HeavyAdIssue.js';
 import * as Issue from './Issue.js';
@@ -16,6 +15,7 @@ import * as IssuesManager from './IssuesManager.js';
 import * as LowTextContrastIssue from './LowTextContrastIssue.js';
 import * as MarkdownIssueDescription from './MarkdownIssueDescription.js';
 import * as MixedContentIssue from './MixedContentIssue.js';
+import * as NavigatorUserAgentIssue from './NavigatorUserAgentIssue.js';
 import * as QuirksModeIssue from './QuirksModeIssue.js';
 import * as RelatedIssue from './RelatedIssue.js';
 import * as SameSiteCookieIssue from './SameSiteCookieIssue.js';
@@ -30,7 +30,6 @@ export {
   ContrastCheckTrigger,
   CorsIssue,
   CrossOriginEmbedderPolicyIssue,
-  DeprecationIssue,
   GenericIssue,
   HeavyAdIssue,
   Issue,
@@ -39,6 +38,7 @@ export {
   LowTextContrastIssue,
   MarkdownIssueDescription,
   MixedContentIssue,
+  NavigatorUserAgentIssue,
   QuirksModeIssue,
   RelatedIssue,
   SameSiteCookieIssue,

package/front_end/panels/developer_resources/developer_resources-meta.ts

@@ -26,8 +26,6 @@ let loadedDeveloperResourcesModule: (typeof DeveloperResources|undefined);
 
 async function loadDeveloperResourcesModule(): Promise<typeof DeveloperResources> {
   if (!loadedDeveloperResourcesModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/developer_resources');
     loadedDeveloperResourcesModule = await import('./developer_resources.js');
   }
   return loadedDeveloperResourcesModule;

package/front_end/panels/elements/ElementsTreeElement.ts

@@ -1052,7 +1052,7 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
         html(),
         TextEditor.Config.domWordWrap,
         CodeMirror.EditorView.theme({
-          '.cm-editor': {maxHeight: '300px'},
+          '&.cm-editor': {maxHeight: '300px'},
           '.cm-scroller': {overflowY: 'auto'},
         }),
         CodeMirror.EditorView.domEventHandlers({

package/front_end/panels/emulation/DeviceModeWrapper.ts

@@ -56,6 +56,10 @@ export class DeviceModeWrapper extends UI.Widget.VBox {
     this.showDeviceModeSetting.set(!this.showDeviceModeSetting.get());
   }
 
+  isDeviceModeOn(): boolean {
+    return this.showDeviceModeSetting.get();
+  }
+
   captureScreenshot(fullSize?: boolean, clip?: Protocol.Page.Viewport): boolean {
     if (!this.deviceModeView) {
       this.deviceModeView = new DeviceModeView();

package/front_end/panels/network/module.json

@@ -3,7 +3,6 @@
     "ui/legacy/components/cookie_table",
     "panels/mobile_throttling",
     "ui/legacy/components/perf_ui",
-    "panels/search",
     "ui/legacy/components/source_frame",
     "ui/legacy"
   ]

package/front_end/panels/profiler/profilesPanel.css

@@ -55,7 +55,7 @@
 
 .profile-view .data-grid span.percent-column {
   color: var(--color-text-secondary);
-  width: 50px;
+  width: 55px;
   display: inline-block;
 }
 

package/front_end/panels/sources/module.json

@@ -1,7 +1,6 @@
 {
   "dependencies": [
     "ui/legacy",
-    "panels/search",
     "ui/legacy/components/source_frame",
     "ui/legacy/components/inline_editor",
     "ui/legacy/components/color_picker",

package/front_end/ui/components/text_editor/theme.ts

@@ -57,6 +57,11 @@ export const editorTheme = CM.EditorView.theme({
     padding: '0 3px 0 9px',
   },
 
+  '.cm-matchingBracket, .cm-nonmatchingBracket': {
+    background: 'transparent',
+    borderBottom: 'none',
+  },
+
   '&:focus-within .cm-matchingBracket': {
     color: 'inherit',
     backgroundColor: 'var(--color-matching-bracket-background)',

package/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts

@@ -106,7 +106,7 @@ export class CSSShadowEditor extends Common.ObjectWrapper.eventMixin<EventTypes,
     field.appendChild(textInput);
     textInput.id = propertyName;
     textInput.addEventListener('keydown', this.handleValueModification.bind(this), false);
-    textInput.addEventListener('mousewheel', this.handleValueModification.bind(this), false);
+    textInput.addEventListener('wheel', this.handleValueModification.bind(this), false);
     textInput.addEventListener('input', this.onTextInput.bind(this), false);
     textInput.addEventListener('blur', this.onTextBlur.bind(this), false);
     return textInput;

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.935332"
+  "version": "1.0.935784"
 }

package/front_end/panels/developer_resources/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/search/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}