chrome-devtools-frontend 1.0.934857 → 1.0.936663

package/scripts/eslint_rules/lib/ban_a_tags_in_lit_html.js

@@ -0,0 +1,47 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+function isLitHtmlTemplateCall(taggedTemplateExpression) {
+  if (taggedTemplateExpression.name) {
+    // Call to html`` and we assume that html = LitHtml's html function.
+    return taggedTemplateExpression.name === 'html';
+  }
+
+  // Match calls to LitHtml.html``
+  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
+      taggedTemplateExpression.property.name === 'html';
+}
+
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Check for <a> and </a> in Lit templates instead of using x-link.',
+      category: 'Possible Errors',
+    },
+    fixable: 'code',
+    schema: []  // no options
+  },
+  create: function(context) {
+    return {
+      TaggedTemplateExpression(node) {
+        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        if (!isLitHtmlCall) {
+          return;
+        }
+
+        // node.quasi.quasis are all the static parts of the template literal.
+        for (const templatePart of node.quasi.quasis) {
+          if (templatePart.value.raw.includes('<a') || templatePart.value.raw.includes('</a>')) {
+            context.report({
+              node,
+              message: 'Adding links to a component should be done using `front_end/ui/legacy/XLink.ts`',
+            });
+          }
+        }
+      },
+    };
+  }
+};

package/scripts/eslint_rules/tests/ban_a_tags_in_lit_html_test.js

@@ -0,0 +1,60 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+const rule = require('../lib/ban_a_tags_in_lit_html.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+  parser: require.resolve('@typescript-eslint/parser'),
+});
+
+const EXPECTED_ERROR_MESSAGE = 'Adding links to a component should be done using `front_end/ui/legacy/XLink.ts`';
+
+ruleTester.run('ban_a_tags_in_lit_html', rule, {
+  valid: [
+    {
+      code: 'LitHtml.html`<p></p>`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code: 'LitHtml.html`<input />`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code: 'LitHtml.html`<${DataGrid.litTagName}></${DataGrid.litTagName}>`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code: 'LitHtml.html`<p><${DataGrid.litTagName}></${DataGrid.litTagName}></p>`',
+      filename: 'front_end/components/test.ts',
+    },
+    {
+      code:
+          'LitHtml.html`<${DataGrid1.litTagName}><${DataGrid2.litTagName}></${DataGrid2.litTagName}></${DataGrid1.litTagName}>`',
+      filename: 'front_end/components/test.ts',
+    }
+  ],
+  invalid: [
+    {
+      code: 'LitHtml.html`<a />`',
+      filename: 'front_end/components/test.ts',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+    {
+      code: 'LitHtml.html`<a></a>`',
+      filename: 'front_end/components/test.ts',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+    {code: 'LitHtml.html`</a>`', filename: 'front_end/components/test.ts', errors: [{message: EXPECTED_ERROR_MESSAGE}]},
+    {code: 'LitHtml.html`<a >`', filename: 'front_end/components/test.ts', errors: [{message: EXPECTED_ERROR_MESSAGE}]},
+    {
+      code: 'LitHtml.html`<p><${DataGrid.litTagName}></${DataGrid.litTagName}><a></a></p>`',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+    {
+      code: 'LitHtml.html`<${DataGrid.litTagName}><a /></${DataGrid.litTagName}>`',
+      errors: [{message: EXPECTED_ERROR_MESSAGE}]
+    },
+  ]
+});

package/front_end/entrypoints/node_main/module.json

@@ -1,8 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "nodeConnectionsPanel.css"
-  ]
-}

package/front_end/panels/console_counters/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/developer_resources/module.json

@@ -1,6 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy",
-    "ui/legacy/components/data_grid"
-  ]
-}

package/front_end/panels/event_listeners/module.json

@@ -1,6 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy",
-    "ui/legacy/components/object_ui"
-  ]
-}

package/front_end/panels/help/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/input/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/mobile_throttling/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/performance_monitor/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/search/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/settings/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/web_audio/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}

package/front_end/panels/webauthn/module.json

@@ -1,6 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy/components/data_grid",
-    "ui/legacy"
-  ]
-}

package/front_end/ui/legacy/components/color_picker/module.json

@@ -1,8 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "spectrum.css"
-  ]
-}

package/front_end/ui/legacy/components/cookie_table/module.json

@@ -1,9 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy",
-    "ui/legacy/components/data_grid"
-  ],
-    "resources": [
-    "cookiesTable.css"
-  ]
-}

package/front_end/ui/legacy/components/data_grid/module.json

@@ -1,8 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-  "resources": [
-    "dataGrid.css"
-  ]
-}

package/front_end/ui/legacy/components/inline_editor/module.json

@@ -1,14 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "bezierEditor.css",
-    "colorSwatch.css",
-    "bezierSwatch.css",
-    "cssShadowSwatch.css",
-    "cssShadowEditor.css",
-    "fontEditor.css",
-    "swatchPopover.css"
-  ]
-}

package/front_end/ui/legacy/components/object_ui/module.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ]
-}