chrome-devtools-frontend 1.0.933786 → 1.0.934857

package/config/gni/all_devtools_files.gni

@@ -35,7 +35,6 @@ all_devtools_files = [
   "front_end/legacy_test_runner/bindings_test_runner/OverridesTestRunner.js",
   "front_end/legacy_test_runner/bindings_test_runner/PersistenceTestRunner.js",
   "front_end/panels/browser_debugger/module.json",
-  "front_end/panels/changes/module.json",
   "front_end/third_party/codemirror/codemirror.css",
   "front_end/ui/legacy/components/color_picker/module.json",
   "front_end/ui/legacy/components/color_picker/spectrum.css",
@@ -102,11 +101,7 @@ all_devtools_files = [
   "front_end/panels/network/module.json",
   "front_end/entrypoints/node_main/module.json",
   "front_end/entrypoints/node_main/nodeConnectionsPanel.css",
-  "front_end/ui/legacy/components/object_ui/customPreviewComponent.css",
   "front_end/ui/legacy/components/object_ui/module.json",
-  "front_end/ui/legacy/components/object_ui/objectPopover.css",
-  "front_end/ui/legacy/components/object_ui/objectPropertiesSection.css",
-  "front_end/ui/legacy/components/object_ui/objectValue.css",
   "front_end/ui/legacy/components/perf_ui/chartViewport.css",
   "front_end/ui/legacy/components/perf_ui/filmStripView.css",
   "front_end/ui/legacy/components/perf_ui/flameChart.css",
@@ -180,8 +175,6 @@ all_devtools_files = [
   "front_end/models/issues_manager/descriptions/TwaPageUnavailableOffline.md",
   "front_end/panels/developer_resources/module.json",
   "front_end/panels/protocol_monitor/module.json",
-  "front_end/ui/legacy/components/quick_open/filteredListWidget.css",
-  "front_end/ui/legacy/components/quick_open/module.json",
   "front_end/panels/application/module.json",
   "front_end/panels/screencast/module.json",
   "front_end/legacy_test_runner/sdk_test_runner/sdk_test_runner.js",
@@ -190,7 +183,6 @@ all_devtools_files = [
   "front_end/panels/security/module.json",
   "front_end/panels/settings/module.json",
   "front_end/entrypoints/shell/shell.json",
-  "front_end/panels/snippets/module.json",
   "front_end/ui/legacy/components/source_frame/fontView.css",
   "front_end/ui/legacy/components/source_frame/imageView.css",
   "front_end/ui/legacy/components/source_frame/jsonView.css",

package/config/gni/devtools_grd_files.gni

@@ -344,7 +344,6 @@ grd_files_release_sources = [
   "front_end/panels/changes/changes-legacy.js",
   "front_end/panels/changes/changes-meta.js",
   "front_end/panels/changes/changes.js",
-  "front_end/panels/changes/changes_module.js",
   "front_end/panels/console/console-legacy.js",
   "front_end/panels/console/console-meta.js",
   "front_end/panels/console/console.js",
@@ -441,7 +440,6 @@ grd_files_release_sources = [
   "front_end/panels/settings/settings_module.js",
   "front_end/panels/snippets/snippets-legacy.js",
   "front_end/panels/snippets/snippets.js",
-  "front_end/panels/snippets/snippets_module.js",
   "front_end/panels/sources/sources-legacy.js",
   "front_end/panels/sources/sources-meta.js",
   "front_end/panels/sources/sources.js",
@@ -531,7 +529,6 @@ grd_files_release_sources = [
   "front_end/ui/legacy/components/quick_open/quick_open-legacy.js",
   "front_end/ui/legacy/components/quick_open/quick_open-meta.js",
   "front_end/ui/legacy/components/quick_open/quick_open.js",
-  "front_end/ui/legacy/components/quick_open/quick_open_module.js",
   "front_end/ui/legacy/components/source_frame/source_frame-legacy.js",
   "front_end/ui/legacy/components/source_frame/source_frame-meta.js",
   "front_end/ui/legacy/components/source_frame/source_frame.js",
@@ -1536,6 +1533,8 @@ grd_files_debug_sources = [
   "front_end/ui/legacy/components/object_ui/ObjectPopoverHelper.js",
   "front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.js",
   "front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.js",
+  "front_end/ui/legacy/components/object_ui/customPreviewComponent.css.js",
+  "front_end/ui/legacy/components/object_ui/objectPopover.css.js",
   "front_end/ui/legacy/components/object_ui/objectPropertiesSection.css.js",
   "front_end/ui/legacy/components/object_ui/objectValue.css.js",
   "front_end/ui/legacy/components/perf_ui/ChartViewport.js",
@@ -1556,6 +1555,7 @@ grd_files_debug_sources = [
   "front_end/ui/legacy/components/quick_open/QuickInput.js",
   "front_end/ui/legacy/components/quick_open/QuickOpen.js",
   "front_end/ui/legacy/components/quick_open/QuickPick.js",
+  "front_end/ui/legacy/components/quick_open/filteredListWidget.css.js",
   "front_end/ui/legacy/components/source_frame/BinaryResourceViewFactory.js",
   "front_end/ui/legacy/components/source_frame/FontView.js",
   "front_end/ui/legacy/components/source_frame/ImageView.js",

package/front_end/Tests.js

@@ -145,10 +145,10 @@
    * Run specified test on a fresh instance of the test suite.
    * @param {Array<string>} args method name followed by its parameters.
    */
-  TestSuite.prototype.dispatchOnTestSuite = function(args) {
+  TestSuite.prototype.dispatchOnTestSuite = async function(args) {
     const methodName = args.shift();
     try {
-      this[methodName].apply(this, args);
+      await this[methodName].apply(this, args);
       if (!this.controlTaken_) {
         this.reportOk_();
       }

package/front_end/core/host/UserMetrics.ts

@@ -569,7 +569,6 @@ export const DevtoolsExperiments: {
   'ignoreListJSFramesOnTimeline': 43,
   'contrastIssues': 44,
   'experimentalCookieFeatures': 45,
-  'localizedDevTools': 46,
   'bfcacheDebugging': 47,
   'hideIssuesFeature': 48,
   'reportingApiDebugging': 49,

package/front_end/core/i18n/locales/en-US.json

@@ -9104,6 +9104,9 @@
   "panels/sources/CallStackSidebarPane.ts | addScriptToIgnoreList": {
     "message": "Add script to ignore list"
   },
+  "panels/sources/CallStackSidebarPane.ts | callFrameWarnings": {
+    "message": "Some call frames have warnings"
+  },
   "panels/sources/CallStackSidebarPane.ts | callStack": {
     "message": "Call Stack"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -9104,6 +9104,9 @@
   "panels/sources/CallStackSidebarPane.ts | addScriptToIgnoreList": {
     "message": "Âd́d̂ śĉŕîṕt̂ t́ô íĝńôŕê ĺîśt̂"
   },
+  "panels/sources/CallStackSidebarPane.ts | callFrameWarnings": {
+    "message": "Ŝóm̂é ĉál̂ĺ f̂ŕâḿêś ĥáv̂é ŵár̂ńîńĝś"
+  },
   "panels/sources/CallStackSidebarPane.ts | callStack": {
     "message": "Ĉál̂ĺ Ŝt́âćk̂"
   },

package/front_end/core/root/Runtime.ts

@@ -554,7 +554,6 @@ export enum ExperimentName {
   ALL = '*',
   PROTOCOL_MONITOR = 'protocolMonitor',
   WEBAUTHN_PANE = 'webauthnPane',
-  LOCALIZED_DEVTOOLS = 'localizedDevTools',
   SYNC_SETTINGS = 'syncSettings',
 }
 

package/front_end/core/sdk/ChildTargetManager.ts

@@ -118,14 +118,14 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
     let targetName = '';
     if (targetInfo.type === 'worker' && targetInfo.title && targetInfo.title !== targetInfo.url) {
       targetName = targetInfo.title;
-    } else if (targetInfo.type !== 'iframe') {
+    } else if (targetInfo.type !== 'iframe' && targetInfo.type !== 'webview') {
       const parsedURL = Common.ParsedURL.ParsedURL.fromString(targetInfo.url);
       targetName =
           parsedURL ? parsedURL.lastPathComponentWithFragment() : '#' + (++ChildTargetManager.lastAnonymousTargetId);
     }
 
     let type = Type.Browser;
-    if (targetInfo.type === 'iframe') {
+    if (targetInfo.type === 'iframe' || targetInfo.type === 'webview') {
       type = Type.Frame;
     }
     // TODO(lfg): ensure proper capabilities for child pages (e.g. portals).

package/front_end/core/sdk/DOMModel.ts

@@ -159,14 +159,14 @@ export class DOMNode {
       this.childrenInternal = [];
     }
 
+    const frameOwnerTags = new Set(['EMBED', 'IFRAME', 'OBJECT', 'PORTAL']);
     if (payload.contentDocument) {
       this.contentDocumentInternal = new DOMDocument(this.#domModelInternal, payload.contentDocument);
       this.contentDocumentInternal.parentNode = this;
       this.childrenInternal = [];
-    } else if ((payload.nodeName === 'IFRAME' || payload.nodeName === 'PORTAL') && payload.frameId) {
-      // At this point we know we are in an OOPIF, otherwise #payload.contentDocument would have been set.
-      this.childDocumentPromiseForTesting =
-          this.createChildDocumentPromiseForTesting(payload.frameId, this.#domModelInternal.target());
+    } else if (payload.frameId && frameOwnerTags.has(payload.nodeName)) {
+      // At this point we know we are in an OOPIF, otherwise `payload.contentDocument` would have been set.
+      this.childDocumentPromiseForTesting = this.requestChildDocument(payload.frameId, this.#domModelInternal.target());
       this.childrenInternal = [];
     }
 
@@ -205,14 +205,10 @@ export class DOMNode {
     }
   }
 
-  private async createChildDocumentPromiseForTesting(frameId: Protocol.Page.FrameId, notInTarget: Target):
-      Promise<DOMDocument|null> {
+  private async requestChildDocument(frameId: Protocol.Page.FrameId, notInTarget: Target): Promise<DOMDocument|null> {
     const frame = await FrameManager.instance().getOrWaitForFrame(frameId, notInTarget);
     const childModel = frame.resourceTreeModel()?.target().model(DOMModel);
-    if (childModel) {
-      return childModel.requestDocument();
-    }
-    return null;
+    return childModel?.requestDocument() || null;
   }
 
   isAdFrameNode(): boolean {

package/front_end/core/sdk/sdk-meta.ts

@@ -331,12 +331,14 @@ const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
   settingName: 'skipStackFramesPattern',
   settingType: Common.Settings.SettingType.REGEX,
   defaultValue: '',
 });
 
 Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
   settingName: 'skipContentScripts',
   settingType: Common.Settings.SettingType.BOOLEAN,
   defaultValue: false,
@@ -433,6 +435,7 @@ Common.Settings.registerSettingExtension({
 
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.ELEMENTS,
+  storageType: Common.Settings.SettingStorageType.Synced,
   title: i18nLazyString(UIStrings.showRulers),
   settingName: 'showMetricsRulers',
   settingType: Common.Settings.SettingType.BOOLEAN,

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -216,6 +216,7 @@ Common.Settings.registerSettingExtension({
 
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.GLOBAL,
+  storageType: Common.Settings.SettingStorageType.Synced,
   title: i18nLazyString(UIStrings.autoOpenDevTools),
   settingName: 'autoAttachToCreatedPages',
   settingType: Common.Settings.SettingType.BOOLEAN,

package/front_end/entrypoints/main/MainImpl.ts

@@ -151,13 +151,7 @@ export class MainImpl {
   }
 
   async requestAndRegisterLocaleData(): Promise<void> {
-    // The language setting is only available when the experiment is enabled.
-    // TODO(crbug.com/1163928): Remove the check when the experiment is gone.
-    let settingLanguage = 'en-US';
-    if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS)) {
-      settingLanguage = Common.Settings.Settings.instance().moduleSetting<string>('language').get();
-    }
-
+    const settingLanguage = Common.Settings.Settings.instance().moduleSetting<string>('language').get();
     const devToolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance({
       create: true,
       data: {
@@ -325,15 +319,11 @@ export class MainImpl {
     // Hide Issues Feature.
     Root.Runtime.experiments.register('groupAndHideIssuesByKind', 'Allow grouping and hiding of issues by IssueKind');
 
-    // Localized DevTools, hide "locale selector" setting behind an experiment.
-    Root.Runtime.experiments.register(Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS, 'Enable localized DevTools');
-
     // Checkbox in the Settings UI to enable Chrome Sync is behind this experiment.
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.SYNC_SETTINGS, 'Sync DevTools settings with Chrome Sync');
 
     Root.Runtime.experiments.enableExperimentsByDefault([
-      Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS,
       'sourceOrderViewer',
       'hideIssuesFeature',
       'bfcacheDebugging',

package/front_end/entrypoints/main/main-meta.ts

@@ -717,6 +717,7 @@ Common.Settings.registerSettingExtension({
 });
 
 Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
   settingName: 'activeKeybindSet',
   settingType: Common.Settings.SettingType.ENUM,
   defaultValue: 'devToolsDefault',
@@ -768,7 +769,6 @@ Common.Settings.registerSettingExtension({
     ...filterLocalesForSettings().map(locale => createOptionForLocale(locale)),
   ],
   reloadRequired: true,
-  experiment: Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS,
 });
 
 Common.Settings.registerSettingExtension({
@@ -783,6 +783,7 @@ Common.Settings.registerSettingExtension({
 });
 
 Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
   settingName: 'userShortcuts',
   settingType: Common.Settings.SettingType.ARRAY,
   defaultValue: [],

package/front_end/entrypoints/shell/shell.json

@@ -4,7 +4,6 @@
     { "name": "entrypoints/main", "type": "autostart" },
     { "name": "ui/legacy", "type": "autostart" },
 
-    { "name": "panels/changes" },
     { "name": "ui/legacy/components/color_picker" },
     { "name": "panels/console" },
     { "name": "panels/coverage" },
@@ -16,10 +15,8 @@
     { "name": "ui/legacy/components/perf_ui" },
     { "name": "panels/profiler" },
     { "name": "panels/protocol_monitor"},
-    { "name": "ui/legacy/components/quick_open" },
     { "name": "panels/search" },
     { "name": "panels/settings" },
-    { "name": "panels/snippets" },
     { "name": "ui/legacy/components/source_frame" },
     { "name": "panels/sources" },
     { "name": "ui/legacy/components/text_editor" }