chrome-devtools-frontend 1.0.932461 → 1.0.932859

package/config/gni/devtools_grd_files.gni

@@ -502,6 +502,7 @@ grd_files_release_sources = [
   "front_end/ui/components/render_coordinator/render_coordinator.js",
   "front_end/ui/components/report_view/report_view.js",
   "front_end/ui/components/request_link_icon/request_link_icon.js",
+  "front_end/ui/components/settings/settings.js",
   "front_end/ui/components/survey_link/survey_link.js",
   "front_end/ui/components/text_editor/text_editor.js",
   "front_end/ui/components/text_prompt/text_prompt.js",
@@ -1423,6 +1424,8 @@ grd_files_debug_sources = [
   "front_end/ui/components/report_view/reportValue.css.js",
   "front_end/ui/components/request_link_icon/RequestLinkIcon.js",
   "front_end/ui/components/request_link_icon/requestLinkIcon.css.js",
+  "front_end/ui/components/settings/SettingCheckbox.js",
+  "front_end/ui/components/settings/settingCheckbox.css.js",
   "front_end/ui/components/survey_link/SurveyLink.js",
   "front_end/ui/components/survey_link/surveyLink.css.js",
   "front_end/ui/components/text_editor/TextEditor.js",

package/front_end/core/i18n/locales/en-US.json

@@ -1694,6 +1694,9 @@
   "panels/accessibility/AccessibilityStrings.ts | fromCaption": {
     "message": "From caption"
   },
+  "panels/accessibility/AccessibilityStrings.ts | fromDescription": {
+    "message": "From description"
+  },
   "panels/accessibility/AccessibilityStrings.ts | fromLabel": {
     "message": "From label"
   },
@@ -1844,6 +1847,9 @@
   "panels/accessibility/AccessibilityStrings.ts | valueFromAttribute": {
     "message": "Value from attribute."
   },
+  "panels/accessibility/AccessibilityStrings.ts | valueFromDescriptionElement": {
+    "message": "Value from description element."
+  },
   "panels/accessibility/AccessibilityStrings.ts | valueFromElementContents": {
     "message": "Value from element contents."
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -1694,6 +1694,9 @@
   "panels/accessibility/AccessibilityStrings.ts | fromCaption": {
     "message": "F̂ŕôḿ caption"
   },
+  "panels/accessibility/AccessibilityStrings.ts | fromDescription": {
+    "message": "F̂ŕôḿ description"
+  },
   "panels/accessibility/AccessibilityStrings.ts | fromLabel": {
     "message": "F̂ŕôḿ label"
   },
@@ -1844,6 +1847,9 @@
   "panels/accessibility/AccessibilityStrings.ts | valueFromAttribute": {
     "message": "V̂ál̂úê f́r̂óm̂ át̂t́r̂íb̂út̂é."
   },
+  "panels/accessibility/AccessibilityStrings.ts | valueFromDescriptionElement": {
+    "message": "V̂ál̂úê f́r̂óm̂ description él̂ém̂én̂t́."
+  },
   "panels/accessibility/AccessibilityStrings.ts | valueFromElementContents": {
     "message": "V̂ál̂úê f́r̂óm̂ él̂ém̂én̂t́ ĉón̂t́êńt̂ś."
   },

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -592,10 +592,6 @@ export class TargetBase {
     return this.getAgent('Animation');
   }
 
-  applicationCacheAgent(): ProtocolProxyApi.ApplicationCacheApi {
-    return this.getAgent('ApplicationCache');
-  }
-
   auditsAgent(): ProtocolProxyApi.AuditsApi {
     return this.getAgent('Audits');
   }
@@ -768,10 +764,6 @@ export class TargetBase {
     this.registerDispatcher('Animation', dispatcher);
   }
 
-  registerApplicationCacheDispatcher(dispatcher: ProtocolProxyApi.ApplicationCacheDispatcher): void {
-    this.registerDispatcher('ApplicationCache', dispatcher);
-  }
-
   registerAuditsDispatcher(dispatcher: ProtocolProxyApi.AuditsDispatcher): void {
     this.registerDispatcher('Audits', dispatcher);
   }

package/front_end/generated/InspectorBackendCommands.js

@@ -46,6 +46,7 @@ export function registerCommands(inspectorBackend) {
     RelatedElement: 'relatedElement'
   });
   inspectorBackend.registerEnum('Accessibility.AXValueNativeSourceType', {
+    Description: 'description',
     Figcaption: 'figcaption',
     Label: 'label',
     Labelfor: 'labelfor',
@@ -172,19 +173,6 @@ export function registerCommands(inspectorBackend) {
       ],
       []);
 
-  // ApplicationCache.
-  inspectorBackend.registerEvent(
-      'ApplicationCache.applicationCacheStatusUpdated', ['frameId', 'manifestURL', 'status']);
-  inspectorBackend.registerEvent('ApplicationCache.networkStateUpdated', ['isNowOnline']);
-  inspectorBackend.registerCommand('ApplicationCache.enable', [], []);
-  inspectorBackend.registerCommand(
-      'ApplicationCache.getApplicationCacheForFrame', [{'name': 'frameId', 'type': 'string', 'optional': false}],
-      ['applicationCache']);
-  inspectorBackend.registerCommand('ApplicationCache.getFramesWithManifests', [], ['frameIds']);
-  inspectorBackend.registerCommand(
-      'ApplicationCache.getManifestForFrame', [{'name': 'frameId', 'type': 'string', 'optional': false}],
-      ['manifestURL']);
-
   // Audits.
   inspectorBackend.registerEnum('Audits.SameSiteCookieExclusionReason', {
     ExcludeSameSiteUnspecifiedTreatedAsLax: 'ExcludeSameSiteUnspecifiedTreatedAsLax',
@@ -255,7 +243,8 @@ export function registerCommands(inspectorBackend) {
     KEvalViolation: 'kEvalViolation',
     KURLViolation: 'kURLViolation',
     KTrustedTypesSinkViolation: 'kTrustedTypesSinkViolation',
-    KTrustedTypesPolicyViolation: 'kTrustedTypesPolicyViolation'
+    KTrustedTypesPolicyViolation: 'kTrustedTypesPolicyViolation',
+    KWasmEvalViolation: 'kWasmEvalViolation'
   });
   inspectorBackend.registerEnum(
       'Audits.SharedArrayBufferIssueType', {TransferIssue: 'TransferIssue', CreationIssue: 'CreationIssue'});
@@ -1539,6 +1528,7 @@ export function registerCommands(inspectorBackend) {
     RedirectContainsCredentials: 'RedirectContainsCredentials',
     InsecurePrivateNetwork: 'InsecurePrivateNetwork',
     InvalidPrivateNetworkAccess: 'InvalidPrivateNetworkAccess',
+    UnexpectedPrivateNetworkAccess: 'UnexpectedPrivateNetworkAccess',
     NoCorsRedirectModeNotFollow: 'NoCorsRedirectModeNotFollow'
   });
   inspectorBackend.registerEnum(
@@ -1608,7 +1598,9 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerEnum('Network.PrivateNetworkRequestPolicy', {
     Allow: 'Allow',
     BlockFromInsecureToMorePrivate: 'BlockFromInsecureToMorePrivate',
-    WarnFromInsecureToMorePrivate: 'WarnFromInsecureToMorePrivate'
+    WarnFromInsecureToMorePrivate: 'WarnFromInsecureToMorePrivate',
+    PreflightBlock: 'PreflightBlock',
+    PreflightWarn: 'PreflightWarn'
   });
   inspectorBackend.registerEnum(
       'Network.IPAddressSpace', {Local: 'Local', Private: 'Private', Public: 'Public', Unknown: 'Unknown'});
@@ -1991,6 +1983,7 @@ export function registerCommands(inspectorBackend) {
     Hid: 'hid',
     IdleDetection: 'idle-detection',
     InterestCohort: 'interest-cohort',
+    KeyboardMap: 'keyboard-map',
     Magnetometer: 'magnetometer',
     Microphone: 'microphone',
     Midi: 'midi',
@@ -2443,8 +2436,6 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerCommand(
       'Page.setWebLifecycleState', [{'name': 'state', 'type': 'string', 'optional': false}], []);
   inspectorBackend.registerCommand('Page.stopScreencast', [], []);
-  inspectorBackend.registerCommand(
-      'Page.setProduceCompilationCache', [{'name': 'enabled', 'type': 'boolean', 'optional': false}], []);
   inspectorBackend.registerCommand(
       'Page.produceCompilationCache', [{'name': 'scripts', 'type': 'object', 'optional': false}], []);
   inspectorBackend.registerCommand(

package/front_end/generated/protocol-mapping.d.ts

@@ -24,8 +24,6 @@ export namespace ProtocolMapping {
      * Event for animation that has been started.
      */
     'Animation.animationStarted': [Protocol.Animation.AnimationStartedEvent];
-    'ApplicationCache.applicationCacheStatusUpdated': [Protocol.ApplicationCache.ApplicationCacheStatusUpdatedEvent];
-    'ApplicationCache.networkStateUpdated': [Protocol.ApplicationCache.NetworkStateUpdatedEvent];
     'Audits.issueAdded': [Protocol.Audits.IssueAddedEvent];
     /**
      * Called when the recording state for the service has been updated.
@@ -765,30 +763,6 @@ export namespace ProtocolMapping {
      * Sets the timing of an animation node.
      */
     'Animation.setTiming': {paramsType: [Protocol.Animation.SetTimingRequest]; returnType: void;};
-    /**
-     * Enables application cache domain notifications.
-     */
-    'ApplicationCache.enable': {paramsType: []; returnType: void;};
-    /**
-     * Returns relevant application cache data for the document in given frame.
-     */
-    'ApplicationCache.getApplicationCacheForFrame': {
-      paramsType: [Protocol.ApplicationCache.GetApplicationCacheForFrameRequest];
-      returnType: Protocol.ApplicationCache.GetApplicationCacheForFrameResponse;
-    };
-    /**
-     * Returns array of frame identifiers with manifest urls for each frame containing a document
-     * associated with some application cache.
-     */
-    'ApplicationCache.getFramesWithManifests':
-        {paramsType: []; returnType: Protocol.ApplicationCache.GetFramesWithManifestsResponse;};
-    /**
-     * Returns manifest URL for document in the given frame.
-     */
-    'ApplicationCache.getManifestForFrame': {
-      paramsType: [Protocol.ApplicationCache.GetManifestForFrameRequest];
-      returnType: Protocol.ApplicationCache.GetManifestForFrameResponse;
-    };
     /**
      * Returns the response body and size if it were re-encoded with the specified settings. Only
      * applies to images.
@@ -2325,19 +2299,10 @@ export namespace ProtocolMapping {
      * Stops sending each frame in the `screencastFrame`.
      */
     'Page.stopScreencast': {paramsType: []; returnType: void;};
-    /**
-     * Forces compilation cache to be generated for every subresource script.
-     * See also: `Page.produceCompilationCache`.
-     */
-    'Page.setProduceCompilationCache':
-        {paramsType: [Protocol.Page.SetProduceCompilationCacheRequest]; returnType: void;};
     /**
      * Requests backend to produce compilation cache for the specified scripts.
-     * Unlike setProduceCompilationCache, this allows client to only produce cache
-     * for specific scripts. `scripts` are appeneded to the list of scripts
-     * for which the cache for would produced. Disabling compilation cache with
-     * `setProduceCompilationCache` would reset all pending cache requests.
-     * The list may also be reset during page navigation.
+     * `scripts` are appeneded to the list of scripts for which the cache
+     * would be produced. The list may be reset during page navigation.
      * When script with a matching URL is encountered, the cache is optionally
      * produced upon backend discretion, based on internal heuristics.
      * See also: `Page.compilationCacheProduced`.

package/front_end/generated/protocol-proxy-api.d.ts

@@ -21,8 +21,6 @@ declare namespace ProtocolProxyApi {
 
     Animation: AnimationApi;
 
-    ApplicationCache: ApplicationCacheApi;
-
     Audits: AuditsApi;
 
     BackgroundService: BackgroundServiceApi;
@@ -113,8 +111,6 @@ declare namespace ProtocolProxyApi {
 
     Animation: AnimationDispatcher;
 
-    ApplicationCache: ApplicationCacheDispatcher;
-
     Audits: AuditsDispatcher;
 
     BackgroundService: BackgroundServiceDispatcher;
@@ -317,36 +313,6 @@ declare namespace ProtocolProxyApi {
     animationStarted(params: Protocol.Animation.AnimationStartedEvent): void;
   }
 
-  export interface ApplicationCacheApi {
-    /**
-     * Enables application cache domain notifications.
-     */
-    invoke_enable(): Promise<Protocol.ProtocolResponseWithError>;
-
-    /**
-     * Returns relevant application cache data for the document in given frame.
-     */
-    invoke_getApplicationCacheForFrame(params: Protocol.ApplicationCache.GetApplicationCacheForFrameRequest):
-        Promise<Protocol.ApplicationCache.GetApplicationCacheForFrameResponse>;
-
-    /**
-     * Returns array of frame identifiers with manifest urls for each frame containing a document
-     * associated with some application cache.
-     */
-    invoke_getFramesWithManifests(): Promise<Protocol.ApplicationCache.GetFramesWithManifestsResponse>;
-
-    /**
-     * Returns manifest URL for document in the given frame.
-     */
-    invoke_getManifestForFrame(params: Protocol.ApplicationCache.GetManifestForFrameRequest):
-        Promise<Protocol.ApplicationCache.GetManifestForFrameResponse>;
-  }
-  export interface ApplicationCacheDispatcher {
-    applicationCacheStatusUpdated(params: Protocol.ApplicationCache.ApplicationCacheStatusUpdatedEvent): void;
-
-    networkStateUpdated(params: Protocol.ApplicationCache.NetworkStateUpdatedEvent): void;
-  }
-
   export interface AuditsApi {
     /**
      * Returns the response body and size if it were re-encoded with the specified settings. Only
@@ -2629,20 +2595,10 @@ declare namespace ProtocolProxyApi {
      */
     invoke_stopScreencast(): Promise<Protocol.ProtocolResponseWithError>;
 
-    /**
-     * Forces compilation cache to be generated for every subresource script.
-     * See also: `Page.produceCompilationCache`.
-     */
-    invoke_setProduceCompilationCache(params: Protocol.Page.SetProduceCompilationCacheRequest):
-        Promise<Protocol.ProtocolResponseWithError>;
-
     /**
      * Requests backend to produce compilation cache for the specified scripts.
-     * Unlike setProduceCompilationCache, this allows client to only produce cache
-     * for specific scripts. `scripts` are appeneded to the list of scripts
-     * for which the cache for would produced. Disabling compilation cache with
-     * `setProduceCompilationCache` would reset all pending cache requests.
-     * The list may also be reset during page navigation.
+     * `scripts` are appeneded to the list of scripts for which the cache
+     * would be produced. The list may be reset during page navigation.
      * When script with a matching URL is encountered, the cache is optionally
      * produced upon backend discretion, based on internal heuristics.
      * See also: `Page.compilationCacheProduced`.

package/front_end/generated/protocol.d.ts

@@ -64,6 +64,7 @@ declare namespace Protocol {
      * Enum of possible native property sources (as a subtype of a particular AXValueSourceType).
      */
     export const enum AXValueNativeSourceType {
+      Description = 'description',
       Figcaption = 'figcaption',
       Label = 'label',
       Labelfor = 'labelfor',
@@ -600,129 +601,6 @@ declare namespace Protocol {
     }
   }
 
-  /**
-   * The domain is deprecated as AppCache is being removed (see crbug.com/582750).
-   */
-  export namespace ApplicationCache {
-
-    /**
-     * Detailed application cache resource information.
-     */
-    export interface ApplicationCacheResource {
-      /**
-       * Resource url.
-       */
-      url: string;
-      /**
-       * Resource size.
-       */
-      size: integer;
-      /**
-       * Resource type.
-       */
-      type: string;
-    }
-
-    /**
-     * Detailed application cache information.
-     */
-    export interface ApplicationCache {
-      /**
-       * Manifest URL.
-       */
-      manifestURL: string;
-      /**
-       * Application cache size.
-       */
-      size: number;
-      /**
-       * Application cache creation time.
-       */
-      creationTime: number;
-      /**
-       * Application cache update time.
-       */
-      updateTime: number;
-      /**
-       * Application cache resources.
-       */
-      resources: ApplicationCacheResource[];
-    }
-
-    /**
-     * Frame identifier - manifest URL pair.
-     */
-    export interface FrameWithManifest {
-      /**
-       * Frame identifier.
-       */
-      frameId: Page.FrameId;
-      /**
-       * Manifest URL.
-       */
-      manifestURL: string;
-      /**
-       * Application cache status.
-       */
-      status: integer;
-    }
-
-    export interface GetApplicationCacheForFrameRequest {
-      /**
-       * Identifier of the frame containing document whose application cache is retrieved.
-       */
-      frameId: Page.FrameId;
-    }
-
-    export interface GetApplicationCacheForFrameResponse extends ProtocolResponseWithError {
-      /**
-       * Relevant application cache data for the document in given frame.
-       */
-      applicationCache: ApplicationCache;
-    }
-
-    export interface GetFramesWithManifestsResponse extends ProtocolResponseWithError {
-      /**
-       * Array of frame identifiers with manifest urls for each frame containing a document
-       * associated with some application cache.
-       */
-      frameIds: FrameWithManifest[];
-    }
-
-    export interface GetManifestForFrameRequest {
-      /**
-       * Identifier of the frame containing document whose manifest is retrieved.
-       */
-      frameId: Page.FrameId;
-    }
-
-    export interface GetManifestForFrameResponse extends ProtocolResponseWithError {
-      /**
-       * Manifest URL for document in the given frame.
-       */
-      manifestURL: string;
-    }
-
-    export interface ApplicationCacheStatusUpdatedEvent {
-      /**
-       * Identifier of the frame containing document whose application cache updated status.
-       */
-      frameId: Page.FrameId;
-      /**
-       * Manifest URL.
-       */
-      manifestURL: string;
-      /**
-       * Updated application cache status.
-       */
-      status: integer;
-    }
-
-    export interface NetworkStateUpdatedEvent {
-      isNowOnline: boolean;
-    }
-  }
-
   /**
    * Audits domain allows investigation of page violations and possible improvements.
    */
@@ -931,6 +809,7 @@ declare namespace Protocol {
       KURLViolation = 'kURLViolation',
       KTrustedTypesSinkViolation = 'kTrustedTypesSinkViolation',
       KTrustedTypesPolicyViolation = 'kTrustedTypesPolicyViolation',
+      KWasmEvalViolation = 'kWasmEvalViolation',
     }
 
     export interface SourceCodeLocation {
@@ -7195,6 +7074,7 @@ declare namespace Protocol {
       RedirectContainsCredentials = 'RedirectContainsCredentials',
       InsecurePrivateNetwork = 'InsecurePrivateNetwork',
       InvalidPrivateNetworkAccess = 'InvalidPrivateNetworkAccess',
+      UnexpectedPrivateNetworkAccess = 'UnexpectedPrivateNetworkAccess',
       NoCorsRedirectModeNotFollow = 'NoCorsRedirectModeNotFollow',
     }
 
@@ -7886,6 +7766,8 @@ declare namespace Protocol {
       Allow = 'Allow',
       BlockFromInsecureToMorePrivate = 'BlockFromInsecureToMorePrivate',
       WarnFromInsecureToMorePrivate = 'WarnFromInsecureToMorePrivate',
+      PreflightBlock = 'PreflightBlock',
+      PreflightWarn = 'PreflightWarn',
     }
 
     export const enum IPAddressSpace {
@@ -9929,6 +9811,7 @@ declare namespace Protocol {
       Hid = 'hid',
       IdleDetection = 'idle-detection',
       InterestCohort = 'interest-cohort',
+      KeyboardMap = 'keyboard-map',
       Magnetometer = 'magnetometer',
       Microphone = 'microphone',
       Midi = 'midi',
@@ -11311,10 +11194,6 @@ declare namespace Protocol {
       state: SetWebLifecycleStateRequestState;
     }
 
-    export interface SetProduceCompilationCacheRequest {
-      enabled: boolean;
-    }
-
     export interface ProduceCompilationCacheRequest {
       scripts: CompilationCacheParams[];
     }

package/front_end/models/issues_manager/CorsIssue.ts

@@ -42,6 +42,7 @@ export enum IssueCode {
   InvalidResponse = 'CorsIssue::InvalidResponse',
   NoCorsRedirectModeNotFollow = 'CorsIssue::NoCorsRedirectModeNotFollow',
   InvalidPrivateNetworkAccess = 'CorsIssue::InvalidPrivateNetworkAccess',
+  UnexpectedPrivateNetworkAccess = 'CorsIssue::UnexpectedPrivateNetworkAccess',
 }
 
 function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
@@ -90,6 +91,8 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
       return IssueCode.NoCorsRedirectModeNotFollow;
     case Protocol.Network.CorsError.InvalidPrivateNetworkAccess:
       return IssueCode.InvalidPrivateNetworkAccess;
+    case Protocol.Network.CorsError.UnexpectedPrivateNetworkAccess:
+      return IssueCode.UnexpectedPrivateNetworkAccess;
   }
 }
 
@@ -221,6 +224,7 @@ export class CorsIssue extends Issue<IssueCode> {
       case IssueCode.PreflightInvalidAllowExternal:
       case IssueCode.InvalidResponse:
       case IssueCode.InvalidPrivateNetworkAccess:
+      case IssueCode.UnexpectedPrivateNetworkAccess:
         return null;
     }
   }

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -1203,11 +1203,6 @@ export const NativeFunctions = [
     signatures: [['type', '?eventInitDict']],
     receiver: 'AnimationPlaybackEvent',
   },
-  {
-    name: 'null',
-    signatures: [['type', '?eventInitDict']],
-    receiver: 'ApplicationCacheErrorEvent',
-  },
   {
     name: 'null',
     signatures: [['type', '?eventInitDict']],

package/front_end/panels/accessibility/AccessibilityStrings.ts

@@ -380,6 +380,17 @@ const UIStrings = {
   /**
   * @description Accessibility attribute name that appears under the Computed Properties section in
   * the Accessibility pane of the Elements pane. Indicates that this element got assigned this
+  * attribute because there is a related description, hence it received it from the description.
+  * 'description' is part of the ARIA API and should not be translated.
+  */
+  fromDescription: 'From `description`',
+  /**
+  *@description Tooltip text that appears when hovering over the 'From description' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane
+  */
+  valueFromDescriptionElement: 'Value from `description` element.',
+  /**
+  * @description Accessibility attribute name that appears under the Computed Properties section in
+  * the Accessibility pane of the Elements pane. Indicates that this element got assigned this
   * attribute because there is a related label, hence it received it from the label. 'label'
   * is part of the ARIA API and should not be translated.
   */
@@ -656,6 +667,10 @@ export const AXSourceTypes = {
 };
 
 export const AXNativeSourceTypes = {
+  'description': {
+    name: i18nLazyString(UIStrings.fromDescription),
+    description: i18nLazyString(UIStrings.valueFromDescriptionElement),
+  },
   'figcaption':
       {name: i18nLazyString(UIStrings.fromCaption), description: i18nLazyString(UIStrings.valueFromFigcaptionElement)},
   'label': {name: i18nLazyString(UIStrings.fromLabel), description: i18nLazyString(UIStrings.valueFromLabelElement)},

package/front_end/panels/issues/CorsIssueDetailsView.ts

@@ -206,7 +206,8 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PreflightMissingAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.PreflightInvalidAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.InvalidResponse|
-                                 IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess>(issueCode);
+                                 IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess|
+                                 IssuesManager.CorsIssue.IssueCode.UnexpectedPrivateNetworkAccess>(issueCode);
     }
 
     this.affectedResources.appendChild(header);
@@ -431,7 +432,8 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PreflightMissingAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.PreflightInvalidAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.InvalidResponse|
-                                 IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess>(issueCode);
+                                 IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess|
+                                 IssuesManager.CorsIssue.IssueCode.UnexpectedPrivateNetworkAccess>(issueCode);
         break;
     }
 

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -117,16 +117,25 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
     toolbar.appendToolbarItem(this.typeSelector);
 
     const content = oldCondition || '';
+    const finishIfComplete = (view: CodeMirror.EditorView): boolean => {
+      if (modTextEditor.JavaScript.isExpressionComplete(view.state)) {
+        this.finishEditing(true, this.editor.state.doc.toString());
+        return true;
+      }
+      return false;
+    };
     const keymap = [
       {
         key: 'Mod-Enter',
-        run: (view: CodeMirror.EditorView): boolean => {
-          if (modTextEditor.JavaScript.isExpressionComplete(view.state)) {
-            this.finishEditing(true, this.editor.state.doc.toString());
-            return true;
-          }
-          return false;
-        },
+        run: finishIfComplete,
+      },
+      {
+        key: 'Enter',
+        run: finishIfComplete,
+      },
+      {
+        ...modCodeMirror.standardKeymap.find(binding => binding.key === 'Enter') as CodeMirror.KeyBinding,
+        key: 'Shift-Enter',
       },
       {
         key: 'Escape',
@@ -139,6 +148,9 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
     this.placeholderCompartment = new modCodeMirror.Compartment();
 
+    const editorWrapper = this.contentElement.appendChild(document.createElement('div'));
+    editorWrapper.classList.add('condition-editor');
+
     this.editor = new modTextEditor.TextEditor.TextEditor(modCodeMirror.EditorState.create({
       doc: content,
       selection: {anchor: 0, head: content.length},
@@ -148,10 +160,10 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
         editorConfig,
       ],
     }));
-    this.editor.classList.add('condition-editor');
+    editorWrapper.appendChild(this.editor);
 
     this.updateTooltip();
-    this.contentElement.appendChild(this.editor);
+
     this.element.addEventListener('blur', event => {
       if (!event.relatedTarget ||
           (event.relatedTarget && !(event.relatedTarget as Node).isSelfOrDescendant(this.element))) {

package/front_end/panels/sources/JavaScriptBreakpointsSidebarPane.ts

@@ -11,6 +11,7 @@ import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
+import {LogpointPrefix} from './BreakpointEditDialog.js';
 import javaScriptBreakpointsSidebarPaneStyles from './javaScriptBreakpointsSidebarPane.css.js';
 
 const UIStrings = {
@@ -292,6 +293,8 @@ export class JavaScriptBreakpointsSidebarPane extends UI.ThrottledWidget.Throttl
     const uiLocation = item.locations[0].uiLocation;
     const hasEnabled = item.locations.some(location => location.breakpoint.enabled());
     const hasDisabled = item.locations.some(location => !location.breakpoint.enabled());
+    const hasLogpoint = item.locations.some(location => location.breakpoint.condition().includes(LogpointPrefix));
+    const hasConditional = item.locations.some(location => Boolean(location.breakpoint.condition()));
     checkboxLabel.textElement.textContent = uiLocation.linkText() +
         (item.showColumn && typeof uiLocation.columnNumber === 'number' ? ':' + (uiLocation.columnNumber + 1) : '');
     checkboxLabel.checkboxElement.checked = hasEnabled;
@@ -319,7 +322,17 @@ export class JavaScriptBreakpointsSidebarPane extends UI.ThrottledWidget.Throttl
       }
     });
 
-    const snippetElement = element.createChild('div', 'source-text monospace');
+    const lineElement = element.createChild('div', 'decoration-and-source');
+    const decorationElement = lineElement.createChild('span', 'breakpoint');
+    if (hasDisabled) {
+      decorationElement.classList.add('disabled');
+    }
+    if (hasLogpoint) {
+      decorationElement.classList.add('logpoint');
+    } else if (hasConditional) {
+      decorationElement.classList.add('breakpoint-conditional');
+    }
+    const snippetElement = lineElement.createChild('div', 'source-text monospace');
     const lineNumber = uiLocation.lineNumber;
 
     if (item.text && lineNumber < item.text.lineCount()) {

package/front_end/panels/sources/javaScriptBreakpointsSidebarPane.css

@@ -24,12 +24,62 @@
   background-color: var(--color-background-elevation-1);
 }
 
-.breakpoint-entry > .source-text {
+.breakpoint-entry > .decoration-and-source {
+  display: flex;
+}
+
+.breakpoint-entry .breakpoint {
+  content: var(--inline-breakpoint-enabled);
+  height: 12px;
+  top: 1px;
+  position: relative;
+  width: 11px;
+  margin-left: 3px;
+  margin-right: 3px;
+
+  --inline-breakpoint-enabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.7549 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.7549 11.2583 6.29382 11.5 5.80139 11.5H0.5V0.5Z" fill="%234285F4" stroke="%231A73E8"/></svg>');
+  --inline-breakpoint-disabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.7549 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.7549 11.2583 6.29382 11.5 5.80139 11.5H0.5V0.5Z" fill="%234285F4" fill-opacity="0.2" stroke="%231A73E8"/></svg>');
+  --inline-conditional-breakpoint-enabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.75489 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.75489 11.2583 6.29382 11.5 5.80138 11.5H0.5V0.5Z" fill="%23F29900" stroke="%23E37400"/><path d="M3.51074 7.75635H4.68408V9H3.51074V7.75635ZM4.68408 7.23779H3.51074V6.56104C3.51074 6.271 3.55615 6.02344 3.64697 5.81836C3.73779 5.61328 3.90039 5.39648 4.13477 5.16797L4.53027 4.77686C4.71484 4.59814 4.83936 4.4502 4.90381 4.33301C4.97119 4.21582 5.00488 4.09424 5.00488 3.96826C5.00488 3.77197 4.9375 3.62402 4.80273 3.52441C4.66797 3.4248 4.46582 3.375 4.19629 3.375C3.9502 3.375 3.69238 3.42773 3.42285 3.5332C3.15625 3.63574 2.88232 3.78955 2.60107 3.99463V2.81689C2.88818 2.65283 3.17822 2.52979 3.47119 2.44775C3.76709 2.36279 4.06299 2.32031 4.35889 2.32031C4.95068 2.32031 5.41504 2.45801 5.75195 2.7334C6.08887 3.00879 6.25732 3.38818 6.25732 3.87158C6.25732 4.09424 6.20752 4.30225 6.10791 4.49561C6.0083 4.68604 5.8208 4.91602 5.54541 5.18555L5.15869 5.56348C4.95947 5.75684 4.83203 5.91504 4.77637 6.03809C4.7207 6.16113 4.69287 6.31201 4.69287 6.49072C4.69287 6.51709 4.69141 6.54785 4.68848 6.58301C4.68848 6.61816 4.68701 6.65625 4.68408 6.69727V7.23779Z" fill="white"/></svg>');
+  --inline-conditional-breakpoint-disabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.75489 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.75489 11.2583 6.29382 11.5 5.80138 11.5H0.5V0.5Z" fill="%23F9AB00" fill-opacity="0.2" stroke="%23E37400"/><path d="M3.51074 7.75635H4.68408V9H3.51074V7.75635ZM4.68408 7.23779H3.51074V6.56104C3.51074 6.271 3.55615 6.02344 3.64697 5.81836C3.73779 5.61328 3.90039 5.39648 4.13477 5.16797L4.53027 4.77686C4.71484 4.59814 4.83936 4.4502 4.90381 4.33301C4.97119 4.21582 5.00488 4.09424 5.00488 3.96826C5.00488 3.77197 4.9375 3.62402 4.80273 3.52441C4.66797 3.4248 4.46582 3.375 4.19629 3.375C3.9502 3.375 3.69238 3.42773 3.42285 3.5332C3.15625 3.63574 2.88232 3.78955 2.60107 3.99463V2.81689C2.88818 2.65283 3.17822 2.52979 3.47119 2.44775C3.76709 2.36279 4.06299 2.32031 4.35889 2.32031C4.95068 2.32031 5.41504 2.45801 5.75195 2.7334C6.08887 3.00879 6.25732 3.38818 6.25732 3.87158C6.25732 4.09424 6.20752 4.30225 6.10791 4.49561C6.0083 4.68604 5.8208 4.91602 5.54541 5.18555L5.15869 5.56348C4.95947 5.75684 4.83203 5.91504 4.77637 6.03809C4.7207 6.16113 4.69287 6.31201 4.69287 6.49072C4.69287 6.51709 4.69141 6.54785 4.68848 6.58301C4.68848 6.61816 4.68701 6.65625 4.68408 6.69727V7.23779Z" fill="%23E37400"/></svg>');
+  --inline-logpoint-enabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.7549 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.7549 11.2583 6.29382 11.5 5.80139 11.5H0.5V0.5Z" fill="%23F439A0" stroke="%23D01884"/><circle cx="3" cy="6" r="1" fill="white"/><circle cx="7" cy="6" r="1" fill="white"/></svg>');
+  --inline-logpoint-disabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.7549 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.7549 11.2583 6.29382 11.5 5.80139 11.5H0.5V0.5Z" fill="%23F439A0" fill-opacity="0.2" stroke="%23D01884"/><circle cx="3" cy="6" r="1" fill="%23D01884"/><circle cx="7" cy="6" r="1" fill="%23D01884"/></svg>');
+}
+
+.breakpoint-entry .breakpoint.disabled,
+.breakpoints-list-deactivated .breakpoint-entry .breakpoint {
+  content: var(--inline-breakpoint-disabled);
+}
+
+:host-context(.-theme-with-dark-background) .breakpoint-entry .breakpoint {
+  --inline-breakpoint-enabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.7549 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.7549 11.2583 6.29382 11.5 5.80139 11.5H0.5V0.5Z" fill="%235186EC" stroke="%231A73E8"/></svg>');
+  --inline-conditional-breakpoint-enabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.75489 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.75489 11.2583 6.29382 11.5 5.80138 11.5H0.5V0.5Z" fill="%23e9a33a" stroke="%23E37400"/><path d="M3.51074 7.75635H4.68408V9H3.51074V7.75635ZM4.68408 7.23779H3.51074V6.56104C3.51074 6.271 3.55615 6.02344 3.64697 5.81836C3.73779 5.61328 3.90039 5.39648 4.13477 5.16797L4.53027 4.77686C4.71484 4.59814 4.83936 4.4502 4.90381 4.33301C4.97119 4.21582 5.00488 4.09424 5.00488 3.96826C5.00488 3.77197 4.9375 3.62402 4.80273 3.52441C4.66797 3.4248 4.46582 3.375 4.19629 3.375C3.9502 3.375 3.69238 3.42773 3.42285 3.5332C3.15625 3.63574 2.88232 3.78955 2.60107 3.99463V2.81689C2.88818 2.65283 3.17822 2.52979 3.47119 2.44775C3.76709 2.36279 4.06299 2.32031 4.35889 2.32031C4.95068 2.32031 5.41504 2.45801 5.75195 2.7334C6.08887 3.00879 6.25732 3.38818 6.25732 3.87158C6.25732 4.09424 6.20752 4.30225 6.10791 4.49561C6.0083 4.68604 5.8208 4.91602 5.54541 5.18555L5.15869 5.56348C4.95947 5.75684 4.83203 5.91504 4.77637 6.03809C4.7207 6.16113 4.69287 6.31201 4.69287 6.49072C4.69287 6.51709 4.69141 6.54785 4.68848 6.58301C4.68848 6.61816 4.68701 6.65625 4.68408 6.69727V7.23779Z" fill="white"/></svg>');
+  --inline-logpoint-enabled: url('data:image/svg+xml,<svg width="11" height="12" viewBox="0 0 11 12" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M0.5 0.5H5.80139C6.29382 0.5 6.7549 0.741701 7.03503 1.14669L10.392 6L7.03503 10.8533C6.7549 11.2583 6.29382 11.5 5.80139 11.5H0.5V0.5Z" fill="%23E54D9B" stroke="%23D01884"/><circle cx="3" cy="6" r="1" fill="white"/><circle cx="7" cy="6" r="1" fill="white"/></svg>');
+}
+
+.breakpoint-entry .breakpoint-conditional {
+  content: var(--inline-conditional-breakpoint-enabled);
+}
+
+.breakpoint-entry .breakpoint-conditional.disabled,
+.breakpoints-list-deactivated .breakpoint-entry .breakpoint-conditional {
+  content: var(--inline-conditional-breakpoint-disabled);
+}
+
+.breakpoint-entry .logpoint {
+  content: var(--inline-logpoint-enabled);
+}
+
+.breakpoint-entry .logpoint.disabled,
+.breakpoints-list-deactivated .breakpoint-entry .logpoint {
+  content: var(--inline-logpoint-disabled);
+}
+
+.breakpoint-entry .source-text {
   cursor: pointer;
   text-overflow: ellipsis;
   overflow: hidden;
   white-space: nowrap;
-  margin-left: 22px;
+  margin-left: 4px;
 }
 
 .breakpoints-list-deactivated {

package/front_end/ui/components/settings/SettingCheckbox.ts

@@ -0,0 +1,69 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import type * as Common from '../../../core/common/common.js';
+import * as ComponentHelpers from '../../components/helpers/helpers.js';
+import * as LitHtml from '../../lit-html/lit-html.js';
+
+import settingCheckboxStyles from './settingCheckbox.css.js';
+
+export interface SettingCheckboxData {
+  setting: Common.Settings.Setting<boolean>;
+}
+
+/**
+ * A simple checkbox that is backed by a boolean setting.
+ */
+export class SettingCheckbox extends HTMLElement {
+  static readonly litTagName = LitHtml.literal`setting-checkbox`;
+  private readonly shadow = this.attachShadow({mode: 'open'});
+
+  private setting?: Common.Settings.Setting<boolean>;
+  private changeListenerDescriptor?: Common.EventTarget.EventDescriptor;
+
+  connectedCallback(): void {
+    this.shadow.adoptedStyleSheets = [settingCheckboxStyles];
+  }
+
+  set data(data: SettingCheckboxData) {
+    if (this.changeListenerDescriptor && this.setting) {
+      this.setting.removeChangeListener(this.changeListenerDescriptor.listener);
+    }
+
+    this.setting = data.setting;
+
+    this.changeListenerDescriptor = this.setting.addChangeListener(() => {
+      this.render();
+    });
+    this.render();
+  }
+
+  private render(): void {
+    if (!this.setting) {
+      throw new Error('No "Setting" object provided for rendering');
+    }
+
+    LitHtml.render(
+        LitHtml.html`
+      <p>
+        <label>
+          <input type="checkbox" ?checked=${this.setting.get()} @change="${this.checkboxChanged}" aria-label="${
+            this.setting.title()}" /> ${this.setting.title()}
+        </label>
+      </p>`,
+        this.shadow, {host: this});
+  }
+
+  private checkboxChanged(e: Event): void {
+    this.setting?.set((e.target as HTMLInputElement).checked);
+  }
+}
+
+ComponentHelpers.CustomElements.defineComponent('setting-checkbox', SettingCheckbox);
+
+declare global {
+  interface HTMLElementTagNameMap {
+    'setting-checkbox': SettingCheckbox;
+  }
+}

package/front_end/ui/components/settings/settingCheckbox.css

@@ -0,0 +1,31 @@
+/*
+ * Copyright 2021 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+:host {
+  padding: 0;
+  margin: 0;
+}
+
+input {
+  height: 12px;
+  width: 12px;
+}
+
+label {
+  display: inline-flex;
+  align-items: center;
+  overflow: hidden;
+  text-overflow: ellipsis;
+}
+
+p {
+  margin: 12px 0;
+}
+
+/* Preserve look of legacy checkboxes in dark mode */
+:host-context(.-theme-with-dark-background) input[type="checkbox"]:not(.-theme-preserve) {
+  filter: invert(80%);
+}

package/front_end/ui/components/settings/settings.ts

@@ -0,0 +1,7 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as SettingCheckbox from './SettingCheckbox.js';
+
+export {SettingCheckbox};

package/front_end/ui/components/text_editor/theme.ts

@@ -7,6 +7,9 @@ import * as CM from '../../../third_party/codemirror.next/codemirror.next.js';
 export const editorTheme = CM.EditorView.theme({
   '&.cm-editor': {
     color: 'color: var(--color-text-primary)',
+    '&.cm-focused': {
+      outline: 'none',
+    },
   },
 
   '.cm-scroller': {

package/front_end/ui/legacy/SettingsUI.ts

@@ -30,6 +30,7 @@
 
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Settings from '../components/settings/settings.js';
 
 import * as ARIAUtils from './ARIAUtils.js';
 import {InspectorView} from './InspectorView.js';
@@ -153,8 +154,11 @@ export const createControlForSetting = function(setting: Common.Settings.Setting
     null {
       const uiTitle = setting.title();
       switch (setting.type()) {
-        case Common.Settings.SettingType.BOOLEAN:
-          return createSettingCheckbox(uiTitle, (setting as Common.Settings.Setting<boolean>));
+        case Common.Settings.SettingType.BOOLEAN: {
+          const component = new Settings.SettingCheckbox.SettingCheckbox();
+          component.data = {setting: setting as Common.Settings.Setting<boolean>};
+          return component;
+        }
         case Common.Settings.SettingType.ENUM:
           if (Array.isArray(setting.options())) {
             return createSettingSelect(uiTitle, setting.options(), setting.reloadRequired(), setting, subtitle);

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -191,8 +191,6 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
 
     const headerContainer = this.element.createChild('div', 'header-container');
     this.headerTable = headerContainer.createChild('table', 'header');
-    // Hide the header table from screen readers since titles are also added to data table.
-    UI.ARIAUtils.markAsHidden(this.headerTable);
     this.headerTableHeaders = {};
     this.scrollContainerInternal = this.element.createChild('div', 'data-container');
     this.dataTable = this.scrollContainerInternal.createChild('table', 'data');

package/front_end/ui/legacy/components/quick_open/filteredListWidget.css

@@ -139,6 +139,7 @@ devtools-text-prompt {
   line-height: 24px;
   height: 24px;
   align-self: center;
+  flex-shrink: 0;
 }
 
 .filtered-list-widget-item-wrapper.selected .filtered-list-widget-item span.highlight {

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.932461"
+  "version": "1.0.932859"
 }