npm - chrome-devtools-frontend - Versions diffs - 1.0.930993 → 1.0.932348 - Mend

chrome-devtools-frontend 1.0.930993 → 1.0.932348

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (81) hide show

package/front_end/core/sdk/TracingModel.ts CHANGED Viewed

@@ -295,7 +295,7 @@ export class TracingModel {
   }
   sortedProcesses(): Process[] {
-    return Sorter.sort([...this.#processById.values()]);
+    return NamedObject.sort([...this.#processById.values()]);
   }
   getProcessByName(name: string): Process|null {
@@ -712,21 +712,6 @@ class ProfileEventsGroup {
     this.children.push(event);
   }
 }
-interface Sortable {
-  _sortIndex: number;
-  name: () => string;
-}
-class Sorter {
-  static sort<Item>(array: Item[]): Item[] {
-    function comparator(a: Sortable, b: Sortable): number {
-      return a._sortIndex !== b._sortIndex ? a._sortIndex - b._sortIndex : a.name().localeCompare(b.name());
-    }
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    return (array as any).sort(comparator);
-  }
-}
 class NamedObject {
   model: TracingModel;
@@ -740,6 +725,12 @@ class NamedObject {
     this.#sortIndex = 0;
   }
+  static sort<Item extends NamedObject>(array: Item[]): Item[] {
+    return array.sort((a, b) => {
+      return a.#sortIndex !== b.#sortIndex ? a.#sortIndex - b.#sortIndex : a.name().localeCompare(b.name());
+    });
+  }
   setName(name: string): void {
     this.#nameInternal = name;
   }
@@ -792,7 +783,7 @@ export class Process extends NamedObject {
   }
   sortedThreads(): Thread[] {
-    return Sorter.sort([...this.threads.values()]);
+    return NamedObject.sort([...this.threads.values()]);
   }
 }

package/front_end/entrypoint_template.html CHANGED Viewed

@@ -14,7 +14,7 @@
     }
   }
 </style>
-<meta http-equiv="Content-Security-Policy" content="object-src 'none'; script-src 'self' 'unsafe-eval' 'unsafe-inline' https://chrome-devtools-frontend.appspot.com">
+<meta http-equiv="Content-Security-Policy" content="object-src 'none'; script-src 'self' 'unsafe-eval' https://chrome-devtools-frontend.appspot.com">
 <meta name="referrer" content="no-referrer">
 <script type="module" src="./entrypoints/%ENTRYPOINT_NAME%/%ENTRYPOINT_NAME%.js"></script>
 <body class="undocked" id="-blink-dev-tools">

package/front_end/entrypoints/formatter_worker/ESTreeWalker.ts CHANGED Viewed

@@ -15,7 +15,7 @@ export class ESTreeWalker {
       beforeVisit: (arg0: Acorn.ESTree.Node) => (Object | undefined),
       afterVisit?: ((arg0: Acorn.ESTree.Node) => void)) {
     this.beforeVisit = beforeVisit;
-    this.afterVisit = afterVisit || new Function();
+    this.afterVisit = afterVisit || function(): void {};
     this.walkNulls = false;
   }

package/front_end/models/bindings/BreakpointManager.ts CHANGED Viewed

@@ -28,8 +28,11 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+// TODO(crbug.com/1253323): All casts to UrlString will be removed from this file when migration to branded types is complete.
 import * as Common from '../../core/common/common.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import type * as Platform from '../../core/platform/platform.js';
 import type * as Protocol from '../../generated/protocol.js';
 import type * as TextUtils from '../text_utils/text_utils.js';
 import * as Workspace from '../workspace/workspace.js';
@@ -627,7 +630,7 @@ export class ModelBreakpoint {
         const positions = debuggerLocations.map(loc => {
           const script = loc.script() as SDK.Script.Script;
           return {
-            url: script.sourceURL,
+            url: script.sourceURL as Platform.DevToolsPath.UrlString,
             scriptId: script.scriptId,
             scriptHash: script.hash,
             lineNumber: loc.lineNumber,
@@ -642,7 +645,7 @@ export class ModelBreakpoint {
         // at least signal a warning to the developer that this #breakpoint wasn't
         // really resolved.
         const position = {
-          url: this.#breakpoint.url(),
+          url: this.#breakpoint.url() as Platform.DevToolsPath.UrlString,
           scriptId: '' as Protocol.Runtime.ScriptId,
           scriptHash: '',
           lineNumber,
@@ -791,7 +794,7 @@ export class ModelBreakpoint {
 }
 interface Position {
-  url: string;
+  url: Platform.DevToolsPath.UrlString;
   scriptId: Protocol.Runtime.ScriptId;
   scriptHash: string;
   lineNumber: number;

package/front_end/models/bindings/ResourceMapping.ts CHANGED Viewed

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 import * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as TextUtils from '../text_utils/text_utils.js';
 import * as Workspace from '../workspace/workspace.js';
@@ -420,7 +421,7 @@ class Binding implements TextUtils.ContentProvider.ContentProvider {
     return this.resources.values().next().value;
   }
-  contentURL(): string {
+  contentURL(): Platform.DevToolsPath.UrlString {
     return this.firstResource().contentURL();
   }

package/front_end/models/bindings/StylesSourceMapping.ts CHANGED Viewed

@@ -29,6 +29,7 @@
  */
 import * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as TextUtils from '../text_utils/text_utils.js';
 import * as Workspace from '../workspace/workspace.js';
@@ -297,7 +298,7 @@ export class StyleFile implements TextUtils.ContentProvider.ContentProvider {
     Common.EventTarget.removeEventListeners(this.#eventListeners);
   }
-  contentURL(): string {
+  contentURL(): Platform.DevToolsPath.UrlString {
     console.assert(this.headers.size > 0);
     return this.headers.values().next().value.originalContentProvider().contentURL();
   }

package/front_end/models/emulation/DeviceModeModel.ts CHANGED Viewed

@@ -113,7 +113,7 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     this.#appliedDeviceScaleFactorInternal = window.devicePixelRatio;
     this.#appliedUserAgentTypeInternal = UA.Desktop;
     this.#experimentDualScreenSupport = Root.Runtime.experiments.isEnabled('dualScreenSupport');
-    this.#webPlatformExperimentalFeaturesEnabledInternal = Boolean(eval('"segments" in window.visualViewport'));
+    this.#webPlatformExperimentalFeaturesEnabledInternal = 'segments' in window.visualViewport;
     this.#scaleSettingInternal = Common.Settings.Settings.instance().createSetting('emulation.deviceScale', 1);
     // We've used to allow zero before.

package/front_end/models/persistence/IsolatedFileSystem.ts CHANGED Viewed

@@ -28,6 +28,8 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+// TODO(crbug.com/1253323): All casts to UrlString will be removed from this file when migration to branded types is complete.
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
@@ -81,7 +83,7 @@ export class IsolatedFileSystem extends PlatformFileSystem {
   constructor(
       manager: IsolatedFileSystemManager, path: string, embedderPath: string, domFileSystem: FileSystem, type: string) {
-    super(path, type);
+    super(path as Platform.DevToolsPath.UrlString, type);
     this.manager = manager;
     this.embedderPathInternal = embedderPath;
     this.domFileSystem = domFileSystem;
@@ -173,8 +175,8 @@ export class IsolatedFileSystem extends PlatformFileSystem {
               this.initialGitFoldersInternal.add(parentFolder);
             }
             if (this.isFileExcluded(entry.fullPath + '/')) {
-              this.excludedEmbedderFolders.push(
-                  Common.ParsedURL.ParsedURL.urlToPlatformPath(this.path() + entry.fullPath, Host.Platform.isWin()));
+              this.excludedEmbedderFolders.push(Common.ParsedURL.ParsedURL.urlToRawPathString(
+                  this.path() + entry.fullPath as Platform.DevToolsPath.UrlString, Host.Platform.isWin()));
               continue;
             }
             ++pendingRequests;
@@ -510,8 +512,8 @@ export class IsolatedFileSystem extends PlatformFileSystem {
       Host.InspectorFrontendHost.InspectorFrontendHostInstance.searchInPath(
           requestId, this.embedderPathInternal, query);
-      function innerCallback(files: string[]): void {
-        resolve(files.map(path => Common.ParsedURL.ParsedURL.platformPathToURL(path)));
+      function innerCallback(files: Platform.DevToolsPath.RawPathString[]): void {
+        resolve(files.map(path => Common.ParsedURL.ParsedURL.rawPathToUrlString(path)));
         progress.incrementWorked(1);
       }
     });
@@ -550,9 +552,9 @@ export class IsolatedFileSystem extends PlatformFileSystem {
                                              Common.ResourceType.resourceTypes.Document;
   }
-  tooltipForURL(url: string): string {
+  tooltipForURL(url: Platform.DevToolsPath.UrlString): string {
     const path = Platform.StringUtilities.trimMiddle(
-        Common.ParsedURL.ParsedURL.urlToPlatformPath(url, Host.Platform.isWin()), 150);
+        Common.ParsedURL.ParsedURL.urlToRawPathString(url, Host.Platform.isWin()), 150);
     return i18nString(UIStrings.linkedToS, {PH1: path});
   }

package/front_end/models/persistence/IsolatedFileSystemManager.ts CHANGED Viewed

@@ -51,7 +51,7 @@ let isolatedFileSystemManagerInstance: IsolatedFileSystemManager;
 export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   private readonly fileSystemsInternal: Map<string, PlatformFileSystem>;
-  private readonly callbacks: Map<number, (arg0: Array<string>) => void>;
+  private readonly callbacks: Map<number, (arg0: Array<Platform.DevToolsPath.RawPathString>) => void>;
   private readonly progresses: Map<number, Common.Progress.Progress>;
   private readonly workspaceFolderExcludePatternSettingInternal: Common.Settings.RegExpSetting;
   private fileSystemRequestResolve: ((arg0: IsolatedFileSystem|null) => void)|null;
@@ -173,7 +173,7 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
   private innerAddFileSystem(fileSystem: Host.InspectorFrontendHostAPI.DevToolsFileSystem, dispatchEvent: boolean):
       Promise<IsolatedFileSystem|null> {
     const embedderPath = fileSystem.fileSystemPath;
-    const fileSystemURL = Common.ParsedURL.ParsedURL.platformPathToURL(fileSystem.fileSystemPath);
+    const fileSystemURL = Common.ParsedURL.ParsedURL.rawPathToUrlString(fileSystem.fileSystemPath);
     const promise = IsolatedFileSystem.create(
         this, fileSystemURL, embedderPath, fileSystem.type, fileSystem.fileSystemName, fileSystem.rootURL);
     return promise.then(storeFileSystem.bind(this));
@@ -218,9 +218,9 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
     }
   }
-  private onFileSystemRemoved(event: Common.EventTarget.EventTargetEvent<string>): void {
+  private onFileSystemRemoved(event: Common.EventTarget.EventTargetEvent<Platform.DevToolsPath.RawPathString>): void {
     const embedderPath = event.data;
-    const fileSystemPath = Common.ParsedURL.ParsedURL.platformPathToURL(embedderPath);
+    const fileSystemPath = Common.ParsedURL.ParsedURL.rawPathToUrlString(embedderPath);
     const isolatedFileSystem = this.fileSystemsInternal.get(fileSystemPath);
     if (!isolatedFileSystem) {
       return;
@@ -241,10 +241,11 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
     this.dispatchEventToListeners(Events.FileSystemFilesChanged, urlPaths);
     function groupFilePathsIntoFileSystemPaths(
-        this: IsolatedFileSystemManager, embedderPaths: string[]): Platform.MapUtilities.Multimap<string, string> {
+        this: IsolatedFileSystemManager,
+        embedderPaths: Platform.DevToolsPath.RawPathString[]): Platform.MapUtilities.Multimap<string, string> {
       const paths = new Platform.MapUtilities.Multimap<string, string>();
       for (const embedderPath of embedderPaths) {
-        const filePath = Common.ParsedURL.ParsedURL.platformPathToURL(embedderPath);
+        const filePath = Common.ParsedURL.ParsedURL.rawPathToUrlString(embedderPath);
         for (const fileSystemPath of this.fileSystemsInternal.keys()) {
           const fileSystem = this.fileSystemsInternal.get(fileSystemPath);
           if (fileSystem && fileSystem.isFileExcluded(embedderPath)) {
@@ -273,7 +274,7 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
     return this.workspaceFolderExcludePatternSettingInternal;
   }
-  registerCallback(callback: (arg0: Array<string>) => void): number {
+  registerCallback(callback: (arg0: Array<Platform.DevToolsPath.RawPathString>) => void): number {
     const requestId = ++lastRequestId;
     this.callbacks.set(requestId, callback);
     return requestId;

package/front_end/models/persistence/PersistenceActions.ts CHANGED Viewed

@@ -92,7 +92,7 @@ export class ContextMenuProvider implements UI.ContextMenu.Provider {
     const binding = uiSourceCode && PersistenceImpl.instance().binding(uiSourceCode);
     const fileURL = binding ? binding.fileSystem.contentURL() : contentProvider.contentURL();
     if (fileURL.startsWith('file://')) {
-      const path = Common.ParsedURL.ParsedURL.urlToPlatformPath(fileURL, Host.Platform.isWin());
+      const path = Common.ParsedURL.ParsedURL.urlToRawPathString(fileURL, Host.Platform.isWin());
       contextMenu.revealSection().appendItem(
           i18nString(UIStrings.openInContainingFolder),
           () => Host.InspectorFrontendHost.InspectorFrontendHostInstance.showItemInFolder(path));

package/front_end/models/persistence/PlatformFileSystem.ts CHANGED Viewed

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 import type * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as TextUtils from '../text_utils/text_utils.js';
@@ -15,9 +16,9 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/persistence/PlatformFileSystem.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export class PlatformFileSystem {
-  private readonly pathInternal: string;
+  private readonly pathInternal: Platform.DevToolsPath.UrlString;
   private readonly typeInternal: string;
-  constructor(path: string, type: string) {
+  constructor(path: Platform.DevToolsPath.UrlString, type: string) {
     this.pathInternal = path;
     this.typeInternal = type;
   }
@@ -34,7 +35,7 @@ export class PlatformFileSystem {
     return [];
   }
-  path(): string {
+  path(): Platform.DevToolsPath.UrlString {
     return this.pathInternal;
   }

package/front_end/models/text_utils/ContentProvider.ts CHANGED Viewed

@@ -29,9 +29,10 @@
  */
 import type * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 export abstract class ContentProvider {
-  abstract contentURL(): string;
+  abstract contentURL(): Platform.DevToolsPath.UrlString;
   abstract contentType(): Common.ResourceType.ResourceType;
   abstract contentEncoded(): Promise<boolean>;
   abstract requestContent(): Promise<DeferredContent>;

package/front_end/models/text_utils/StaticContentProvider.ts CHANGED Viewed

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 import type * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 import type {ContentProvider, DeferredContent, SearchMatch} from './ContentProvider.js';
 import {performSearchInContent} from './TextUtils.js';
@@ -28,8 +29,9 @@ export class StaticContentProvider implements ContentProvider {
     return new StaticContentProvider(contentURL, contentType, lazyContent);
   }
-  contentURL(): string {
-    return this.contentURLInternal;
+  // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
+  contentURL(): Platform.DevToolsPath.UrlString {
+    return this.contentURLInternal as Platform.DevToolsPath.UrlString;
   }
   contentType(): Common.ResourceType.ResourceType {

package/front_end/models/workspace/UISourceCode.ts CHANGED Viewed

@@ -192,8 +192,9 @@ export class UISourceCode extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
         WorkspaceImplEvents.UISourceCodeRenamed, {oldURL: oldURL, uiSourceCode: this});
   }
-  contentURL(): string {
-    return this.url();
+  // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
+  contentURL(): Platform.DevToolsPath.UrlString {
+    return this.url() as Platform.DevToolsPath.UrlString;
   }
   contentType(): Common.ResourceType.ResourceType {

package/front_end/panels/animation/AnimationGroupPreviewUI.ts CHANGED Viewed

@@ -7,34 +7,34 @@ import type {AnimationGroup} from './AnimationModel.js';
 import {AnimationUI} from './AnimationUI.js';
 export class AnimationGroupPreviewUI {
-  private model: AnimationGroup;
+  #model: AnimationGroup;
   element: HTMLDivElement;
-  private readonly removeButtonInternal: HTMLElement;
-  private readonly replayOverlayElement: HTMLElement;
-  private readonly svg: Element;
-  private readonly viewBoxHeight: number;
+  readonly #removeButtonInternal: HTMLElement;
+  readonly #replayOverlayElement: HTMLElement;
+  readonly #svg: Element;
+  readonly #viewBoxHeight: number;
   constructor(model: AnimationGroup) {
-    this.model = model;
+    this.#model = model;
     this.element = document.createElement('div');
     this.element.classList.add('animation-buffer-preview');
     this.element.createChild('div', 'animation-paused fill');
-    this.removeButtonInternal = this.element.createChild('div', 'animation-remove-button');
-    this.removeButtonInternal.textContent = '\u2715';
-    this.replayOverlayElement = this.element.createChild('div', 'animation-buffer-preview-animation');
-    this.svg = UI.UIUtils.createSVGChild(this.element, 'svg');
-    this.svg.setAttribute('width', '100%');
-    this.svg.setAttribute('preserveAspectRatio', 'none');
-    this.svg.setAttribute('height', '100%');
-    this.viewBoxHeight = 32;
-    this.svg.setAttribute('viewBox', '0 0 100 ' + this.viewBoxHeight);
-    this.svg.setAttribute('shape-rendering', 'crispEdges');
+    this.#removeButtonInternal = this.element.createChild('div', 'animation-remove-button');
+    this.#removeButtonInternal.textContent = '\u2715';
+    this.#replayOverlayElement = this.element.createChild('div', 'animation-buffer-preview-animation');
+    this.#svg = UI.UIUtils.createSVGChild(this.element, 'svg');
+    this.#svg.setAttribute('width', '100%');
+    this.#svg.setAttribute('preserveAspectRatio', 'none');
+    this.#svg.setAttribute('height', '100%');
+    this.#viewBoxHeight = 32;
+    this.#svg.setAttribute('viewBox', '0 0 100 ' + this.#viewBoxHeight);
+    this.#svg.setAttribute('shape-rendering', 'crispEdges');
     this.render();
   }
   private groupDuration(): number {
     let duration = 0;
-    for (const anim of this.model.animations()) {
+    for (const anim of this.#model.animations()) {
       const animDuration = anim.source().delay() + anim.source().duration();
       if (animDuration > duration) {
         duration = animDuration;
@@ -44,11 +44,11 @@ export class AnimationGroupPreviewUI {
   }
   removeButton(): Element {
-    return this.removeButtonInternal;
+    return this.#removeButtonInternal;
   }
   replay(): void {
-    this.replayOverlayElement.animate(
+    this.#replayOverlayElement.animate(
         [
           {offset: 0, width: '0%', opacity: 1},
           {offset: 0.9, width: '100%', opacity: 1},
@@ -58,19 +58,19 @@ export class AnimationGroupPreviewUI {
   }
   private render(): void {
-    this.svg.removeChildren();
+    this.#svg.removeChildren();
     const maxToShow = 10;
-    const numberOfAnimations = Math.min(this.model.animations().length, maxToShow);
+    const numberOfAnimations = Math.min(this.#model.animations().length, maxToShow);
     const timeToPixelRatio = 100 / Math.max(this.groupDuration(), 750);
     for (let i = 0; i < numberOfAnimations; i++) {
-      const effect = this.model.animations()[i].source();
-      const line = UI.UIUtils.createSVGChild(this.svg, 'line') as SVGLineElement;
+      const effect = this.#model.animations()[i].source();
+      const line = UI.UIUtils.createSVGChild(this.#svg, 'line') as SVGLineElement;
       line.setAttribute('x1', String(effect.delay() * timeToPixelRatio));
       line.setAttribute('x2', String((effect.delay() + effect.duration()) * timeToPixelRatio));
-      const y = String(Math.floor(this.viewBoxHeight / Math.max(6, numberOfAnimations) * i + 1));
+      const y = String(Math.floor(this.#viewBoxHeight / Math.max(6, numberOfAnimations) * i + 1));
       line.setAttribute('y1', y);
       line.setAttribute('y2', y);
-      line.style.stroke = AnimationUI.colorForAnimation(this.model.animations()[i]);
+      line.style.stroke = AnimationUI.colorForAnimation(this.#model.animations()[i]);
     }
   }
 }