chrome-devtools-frontend 1.0.928589 → 1.0.929998

package/front_end/core/common/Trie.ts

@@ -3,78 +3,78 @@
 // found in the LICENSE file.
 
 export class Trie {
-  private size!: number;
-  private root: number;
-  private edges!: {
+  #size!: number;
+  #root: number;
+  #edges!: {
     [x: string]: number,
   }[];
-  private isWord!: boolean[];
-  private wordsInSubtree!: number[];
-  private freeNodes!: number[];
+  #isWord!: boolean[];
+  #wordsInSubtree!: number[];
+  #freeNodes!: number[];
 
   constructor() {
-    this.root = 0;
+    this.#root = 0;
     this.clear();
   }
 
   add(word: string): void {
-    let node: number = this.root;
-    ++this.wordsInSubtree[this.root];
+    let node: number = this.#root;
+    ++this.#wordsInSubtree[this.#root];
     for (let i = 0; i < word.length; ++i) {
       const edge = word[i];
-      let next: number = this.edges[node][edge];
+      let next: number = this.#edges[node][edge];
       if (!next) {
-        if (this.freeNodes.length) {
-          next = (this.freeNodes.pop() as number);
+        if (this.#freeNodes.length) {
+          next = (this.#freeNodes.pop() as number);
         } else {
-          next = this.size++;
-          this.isWord.push(false);
-          this.wordsInSubtree.push(0);
-          this.edges.push(Object.create(null));
+          next = this.#size++;
+          this.#isWord.push(false);
+          this.#wordsInSubtree.push(0);
+          this.#edges.push(Object.create(null));
         }
-        this.edges[node][edge] = next;
+        this.#edges[node][edge] = next;
       }
-      ++this.wordsInSubtree[next];
+      ++this.#wordsInSubtree[next];
       node = next;
     }
-    this.isWord[node] = true;
+    this.#isWord[node] = true;
   }
 
   remove(word: string): boolean {
     if (!this.has(word)) {
       return false;
     }
-    let node: number = this.root;
-    --this.wordsInSubtree[this.root];
+    let node: number = this.#root;
+    --this.#wordsInSubtree[this.#root];
     for (let i = 0; i < word.length; ++i) {
       const edge = word[i];
-      const next = this.edges[node][edge];
-      if (!--this.wordsInSubtree[next]) {
-        delete this.edges[node][edge];
-        this.freeNodes.push(next);
+      const next = this.#edges[node][edge];
+      if (!--this.#wordsInSubtree[next]) {
+        delete this.#edges[node][edge];
+        this.#freeNodes.push(next);
       }
       node = next;
     }
-    this.isWord[node] = false;
+    this.#isWord[node] = false;
     return true;
   }
 
   has(word: string): boolean {
-    let node: number = this.root;
+    let node: number = this.#root;
     for (let i = 0; i < word.length; ++i) {
-      node = this.edges[node][word[i]];
+      node = this.#edges[node][word[i]];
       if (!node) {
         return false;
       }
     }
-    return this.isWord[node];
+    return this.#isWord[node];
   }
 
   words(prefix?: string): string[] {
     prefix = prefix || '';
-    let node: number = this.root;
+    let node: number = this.#root;
     for (let i = 0; i < prefix.length; ++i) {
-      node = this.edges[node][prefix[i]];
+      node = this.#edges[node][prefix[i]];
       if (!node) {
         return [];
       }
@@ -85,24 +85,24 @@ export class Trie {
   }
 
   private dfs(node: number, prefix: string, results: string[]): void {
-    if (this.isWord[node]) {
+    if (this.#isWord[node]) {
       results.push(prefix);
     }
-    const edges = this.edges[node];
+    const edges = this.#edges[node];
     for (const edge in edges) {
       this.dfs(edges[edge], prefix + edge, results);
     }
   }
 
   longestPrefix(word: string, fullWordOnly: boolean): string {
-    let node: number = this.root;
+    let node: number = this.#root;
     let wordIndex = 0;
     for (let i = 0; i < word.length; ++i) {
-      node = this.edges[node][word[i]];
+      node = this.#edges[node][word[i]];
       if (!node) {
         break;
       }
-      if (!fullWordOnly || this.isWord[node]) {
+      if (!fullWordOnly || this.#isWord[node]) {
         wordIndex = i + 1;
       }
     }
@@ -110,11 +110,11 @@ export class Trie {
   }
 
   clear(): void {
-    this.size = 1;
-    this.root = 0;
-    this.edges = [Object.create(null)];
-    this.isWord = [false];
-    this.wordsInSubtree = [0];
-    this.freeNodes = [];
+    this.#size = 1;
+    this.#root = 0;
+    this.#edges = [Object.create(null)];
+    this.#isWord = [false];
+    this.#wordsInSubtree = [0];
+    this.#freeNodes = [];
   }
 }

package/front_end/core/common/WasmDisassembly.ts

@@ -5,7 +5,7 @@
 import * as Platform from '../platform/platform.js';
 
 /**
- * Metadata to map between bytecode offsets and line numbers in the
+ * Metadata to map between bytecode #offsets and line numbers in the
  * disassembly for WebAssembly modules.
  */
 
@@ -14,26 +14,26 @@ interface FunctionBodyOffset {
   end: number;
 }
 export class WasmDisassembly {
-  private readonly offsets: number[];
-  private functionBodyOffsets: FunctionBodyOffset[];
+  readonly #offsets: number[];
+  #functionBodyOffsets: FunctionBodyOffset[];
 
   constructor(offsets: number[], functionBodyOffsets: FunctionBodyOffset[]) {
-    this.offsets = offsets;
-    this.functionBodyOffsets = functionBodyOffsets;
+    this.#offsets = offsets;
+    this.#functionBodyOffsets = functionBodyOffsets;
   }
 
   get lineNumbers(): number {
-    return this.offsets.length;
+    return this.#offsets.length;
   }
 
   bytecodeOffsetToLineNumber(bytecodeOffset: number): number {
     return Platform.ArrayUtilities.upperBound(
-               this.offsets, bytecodeOffset, Platform.ArrayUtilities.DEFAULT_COMPARATOR) -
+               this.#offsets, bytecodeOffset, Platform.ArrayUtilities.DEFAULT_COMPARATOR) -
         1;
   }
 
   lineNumberToBytecodeOffset(lineNumber: number): number {
-    return this.offsets[lineNumber];
+    return this.#offsets[lineNumber];
   }
 
   /**
@@ -43,10 +43,10 @@ export class WasmDisassembly {
     let lineNumber = 0;
     let functionIndex = 0;
     while (lineNumber < this.lineNumbers) {
-      if (functionIndex < this.functionBodyOffsets.length) {
+      if (functionIndex < this.#functionBodyOffsets.length) {
         const offset = this.lineNumberToBytecodeOffset(lineNumber);
-        if (offset >= this.functionBodyOffsets[functionIndex].start) {
-          lineNumber = this.bytecodeOffsetToLineNumber(this.functionBodyOffsets[functionIndex++].end) + 1;
+        if (offset >= this.#functionBodyOffsets[functionIndex].start) {
+          lineNumber = this.bytecodeOffsetToLineNumber(this.#functionBodyOffsets[functionIndex++].end) + 1;
           continue;
         }
       }

package/front_end/core/common/Worker.ts

@@ -29,11 +29,11 @@
  */
 
 export class WorkerWrapper {
-  private readonly workerPromise: Promise<Worker>;
-  private disposed?: boolean;
+  readonly #workerPromise: Promise<Worker>;
+  #disposed?: boolean;
 
   private constructor(workerLocation: URL) {
-    this.workerPromise = new Promise(fulfill => {
+    this.#workerPromise = new Promise(fulfill => {
       const worker = new Worker(workerLocation, {type: 'module'});
       worker.onmessage = (event: MessageEvent<unknown>): void => {
         console.assert(event.data === 'workerReady');
@@ -48,16 +48,16 @@ export class WorkerWrapper {
   }
 
   postMessage(message: unknown): void {
-    this.workerPromise.then(worker => {
-      if (!this.disposed) {
+    this.#workerPromise.then(worker => {
+      if (!this.#disposed) {
         worker.postMessage(message);
       }
     });
   }
 
   dispose(): void {
-    this.disposed = true;
-    this.workerPromise.then(worker => worker.terminate());
+    this.#disposed = true;
+    this.#workerPromise.then(worker => worker.terminate());
   }
 
   terminate(): void {
@@ -65,13 +65,13 @@ export class WorkerWrapper {
   }
 
   set onmessage(listener: (event: MessageEvent) => void) {
-    this.workerPromise.then(worker => {
+    this.#workerPromise.then(worker => {
       worker.onmessage = listener;
     });
   }
 
   set onerror(listener: (event: Event) => void) {
-    this.workerPromise.then(worker => {
+    this.#workerPromise.then(worker => {
       worker.onerror = listener;
     });
   }

package/front_end/core/host/InspectorFrontendHost.ts

@@ -53,9 +53,9 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const MAX_RECORDED_HISTOGRAMS_SIZE = 100;
 
 export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
-  private readonly urlsBeingSaved: Map<string, string[]>;
+  readonly #urlsBeingSaved: Map<string, string[]>;
   events!: Common.EventTarget.EventTarget<EventTypes>;
-  private windowVisible?: boolean;
+  #windowVisible?: boolean;
 
   recordedEnumeratedHistograms: {actionName: EnumeratedHistogram, actionCode: number}[] = [];
   recordedPerformanceHistograms: {histogramName: string, duration: number}[] = [];
@@ -71,7 +71,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     document.addEventListener('keydown', event => {
       stopEventPropagation.call(this, (event as KeyboardEvent));
     }, true);
-    this.urlsBeingSaved = new Map();
+    this.#urlsBeingSaved = new Map();
   }
 
   platform(): string {
@@ -89,11 +89,11 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   }
 
   bringToFront(): void {
-    this.windowVisible = true;
+    this.#windowVisible = true;
   }
 
   closeWindow(): void {
-    this.windowVisible = false;
+    this.#windowVisible = false;
   }
 
   setIsDocked(isDocked: boolean, callback: () => void): void {
@@ -146,17 +146,17 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   }
 
   save(url: string, content: string, forceSaveAs: boolean): void {
-    let buffer = this.urlsBeingSaved.get(url);
+    let buffer = this.#urlsBeingSaved.get(url);
     if (!buffer) {
       buffer = [];
-      this.urlsBeingSaved.set(url, buffer);
+      this.#urlsBeingSaved.set(url, buffer);
     }
     buffer.push(content);
     this.events.dispatchEventToListeners(Events.SavedURL, {url, fileSystemPath: url});
   }
 
   append(url: string, content: string): void {
-    const buffer = this.urlsBeingSaved.get(url);
+    const buffer = this.#urlsBeingSaved.get(url);
     if (buffer) {
       buffer.push(content);
       this.events.dispatchEventToListeners(Events.AppendedToURL, url);
@@ -164,8 +164,8 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   }
 
   close(url: string): void {
-    const buffer = this.urlsBeingSaved.get(url) || [];
-    this.urlsBeingSaved.delete(url);
+    const buffer = this.#urlsBeingSaved.get(url) || [];
+    this.#urlsBeingSaved.delete(url);
     let fileName = '';
 
     if (url) {
@@ -357,10 +357,10 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
 export let InspectorFrontendHostInstance: InspectorFrontendHostStub = window.InspectorFrontendHost;
 
 class InspectorFrontendAPIImpl {
-  private readonly debugFrontend: boolean;
+  readonly #debugFrontend: boolean;
 
   constructor() {
-    this.debugFrontend = (Boolean(Root.Runtime.Runtime.queryParam('debugFrontend'))) ||
+    this.#debugFrontend = (Boolean(Root.Runtime.Runtime.queryParam('debugFrontend'))) ||
         // @ts-ignore Compatibility hacks
         (window['InspectorTest'] && window['InspectorTest']['debugTest']);
 
@@ -371,7 +371,7 @@ class InspectorFrontendAPIImpl {
   }
 
   private dispatch(name: symbol, signature: string[], runOnceLoaded: boolean, ...params: string[]): void {
-    if (this.debugFrontend) {
+    if (this.#debugFrontend) {
       setTimeout(() => innerDispatch(), 0);
     } else {
       innerDispatch();

package/front_end/core/host/UserMetrics.ts

@@ -32,13 +32,13 @@ import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
 import {EnumeratedHistogram} from './InspectorFrontendHostAPI.js';
 
 export class UserMetrics {
-  private panelChangedSinceLaunch: boolean;
-  private firedLaunchHistogram: boolean;
-  private launchPanelName: string;
+  #panelChangedSinceLaunch: boolean;
+  #firedLaunchHistogram: boolean;
+  #launchPanelName: string;
   constructor() {
-    this.panelChangedSinceLaunch = false;
-    this.firedLaunchHistogram = false;
-    this.launchPanelName = '';
+    this.#panelChangedSinceLaunch = false;
+    this.#firedLaunchHistogram = false;
+    this.#launchPanelName = '';
   }
 
   panelShown(panelName: string): void {
@@ -46,7 +46,7 @@ export class UserMetrics {
     const size = Object.keys(PanelCodes).length + 1;
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.PanelShown, code, size);
     // Store that the user has changed the panel so we know launch histograms should not be fired.
-    this.panelChangedSinceLaunch = true;
+    this.#panelChangedSinceLaunch = true;
   }
 
   /**
@@ -57,7 +57,7 @@ export class UserMetrics {
     const size = Object.keys(PanelCodes).length + 1;
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.PanelClosed, code, size);
     // Store that the user has changed the panel so we know launch histograms should not be fired.
-    this.panelChangedSinceLaunch = true;
+    this.#panelChangedSinceLaunch = true;
   }
 
   sidebarPaneShown(sidebarPaneName: string): void {
@@ -76,11 +76,11 @@ export class UserMetrics {
   }
 
   panelLoaded(panelName: string, histogramName: string): void {
-    if (this.firedLaunchHistogram || panelName !== this.launchPanelName) {
+    if (this.#firedLaunchHistogram || panelName !== this.#launchPanelName) {
       return;
     }
 
-    this.firedLaunchHistogram = true;
+    this.#firedLaunchHistogram = true;
     // Use rAF and setTimeout to ensure the marker is fired after layout and rendering.
     // This will give the most accurate representation of the tool being ready for a user.
     requestAnimationFrame(() => {
@@ -89,7 +89,7 @@ export class UserMetrics {
         performance.mark(histogramName);
         // If the user has switched panel before we finished loading, ignore the histogram,
         // since the launch timings will have been affected and are no longer valid.
-        if (this.panelChangedSinceLaunch) {
+        if (this.#panelChangedSinceLaunch) {
           return;
         }
         // This fires the event for the appropriate launch histogram.
@@ -100,7 +100,7 @@ export class UserMetrics {
   }
 
   setLaunchPanel(panelName: string|null): void {
-    this.launchPanelName = (panelName as string);
+    this.#launchPanelName = (panelName as string);
   }
 
   keybindSetSettingChanged(keybindSet: string): void {
@@ -545,7 +545,6 @@ export const DevtoolsExperiments: {
   'backgroundServicesPaymentHandler': 5,
   'backgroundServicesPushMessaging': 6,
   'blackboxJSFramesOnTimeline': 7,
-  'cssOverview': 8,
   'inputEventsOnTimelineOverview': 10,
   'liveHeapProfile': 11,
   'protocolMonitor': 13,

package/front_end/core/i18n/locales/en-US.json

@@ -2336,8 +2336,8 @@
   "panels/application/BackForwardCacheView.ts | bfcacheStatus": {
     "message": "Back-forward Cache Status"
   },
-  "panels/application/BackForwardCacheView.ts | chromeSupportNeeded": {
-    "message": "The last navigation was not cached because"
+  "panels/application/BackForwardCacheView.ts | circumstantial": {
+    "message": "Not Actionable"
   },
   "panels/application/BackForwardCacheView.ts | lastMainFrameNavigation": {
     "message": "Last Main Frame Navigation"
@@ -2346,14 +2346,17 @@
     "message": "Main Frame"
   },
   "panels/application/BackForwardCacheView.ts | normalNavigation": {
-    "message": "Normal navigation"
+    "message": "Normal navigation (Not restored from back-forward cache)"
   },
   "panels/application/BackForwardCacheView.ts | pageSupportNeeded": {
-    "message": "Features preventing back-forward cache"
+    "message": "Actionable"
   },
   "panels/application/BackForwardCacheView.ts | restoredFromBFCache": {
     "message": "Restored from back-forward cache"
   },
+  "panels/application/BackForwardCacheView.ts | supportPending": {
+    "message": "Pending Support"
+  },
   "panels/application/BackForwardCacheView.ts | unavailable": {
     "message": "unavailable"
   },
@@ -2363,9 +2366,6 @@
   "panels/application/BackForwardCacheView.ts | url": {
     "message": "URL"
   },
-  "panels/application/BackForwardCacheView.ts | willBeSupported": {
-    "message": "(Supported in a future version of Chrome)"
-  },
   "panels/application/BackgroundServiceView.ts | backgroundFetch": {
     "message": "Background Fetch"
   },
@@ -2612,6 +2612,9 @@
   "panels/application/components/OriginTrialTreeView.ts | tokens": {
     "message": "{PH1} tokens"
   },
+  "panels/application/components/OriginTrialTreeView.ts | trialName": {
+    "message": "Trial Name"
+  },
   "panels/application/components/OriginTrialTreeView.ts | usageRestriction": {
     "message": "Usage Restriction"
   },
@@ -3758,6 +3761,39 @@
   "panels/coverage/CoverageView.ts | urlFilter": {
     "message": "URL filter"
   },
+  "panels/css_overview/components/CSSOverviewStartView.ts | activelyWorkingAndLookingForS": {
+    "message": "Our team is actively working on this feature and we are looking for your {PH1}!"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | captureOverview": {
+    "message": "Capture overview"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | capturePageCSSOverview": {
+    "message": "Capture an overview of your page’s CSS"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | feedbackInline": {
+    "message": "feedback"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | feedbackStandalone": {
+    "message": "Feedback"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | identifyCSSImprovements": {
+    "message": "Identify potential CSS improvements"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | identifyCSSImprovementsWithExampleIssues": {
+    "message": "Identify potential CSS improvements (e.g. low contrast issues, unused declarations, color or font mismatches)"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | locateAffectedElements": {
+    "message": "Locate the affected elements in the Elements panel"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | previewFeature": {
+    "message": "Preview feature"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | quickStartWithCSSOverview": {
+    "message": "Quick start: get started with the new CSS Overview panel"
+  },
+  "panels/css_overview/components/CSSOverviewStartView.ts | videoAndDocumentation": {
+    "message": "Video and documentation"
+  },
   "panels/css_overview/css_overview-meta.ts | cssOverview": {
     "message": "CSS Overview"
   },
@@ -3875,12 +3911,6 @@
   "panels/css_overview/CSSOverviewSidebarPanel.ts | clearOverview": {
     "message": "Clear overview"
   },
-  "panels/css_overview/CSSOverviewStartView.ts | captureOverview": {
-    "message": "Capture overview"
-  },
-  "panels/css_overview/CSSOverviewStartView.ts | cssOverview": {
-    "message": "CSS Overview"
-  },
   "panels/css_overview/CSSOverviewUnusedDeclarations.ts | bottomAppliedToAStatically": {
     "message": "Bottom applied to a statically positioned element"
   },
@@ -4895,14 +4925,8 @@
   "panels/issues/AttributionReportingIssueDetailsView.ts | untrustworthyOrigin": {
     "message": "Untrustworthy origin"
   },
-  "panels/issues/components/HideIssuesMenu.ts | hideIssueByCode": {
-    "message": "Hide issues like this"
-  },
   "panels/issues/components/HideIssuesMenu.ts | tooltipTitle": {
-    "message": "Hide issues menu"
-  },
-  "panels/issues/components/HideIssuesMenu.ts | UnhideIssueByCode": {
-    "message": "Unhide issues like this"
+    "message": "Hide issues"
   },
   "panels/issues/CorsIssueDetailsView.ts | allowCredentialsValueFromHeader": {
     "message": "Access-Control-Allow-Credentials Header Value"
@@ -4997,6 +5021,9 @@
   "panels/issues/HiddenIssuesRow.ts | unhideAll": {
     "message": "Unhide all"
   },
+  "panels/issues/IssueKindView.ts | hideAllCurrent": {
+    "message": "Hide all current {PH1}"
+  },
   "panels/issues/issues-meta.ts | cspViolations": {
     "message": "CSP Violations"
   },
@@ -5078,6 +5105,9 @@
   "panels/issues/IssueView.ts | blocked": {
     "message": "blocked"
   },
+  "panels/issues/IssueView.ts | hideIssuesLikeThis": {
+    "message": "Hide issues like this"
+  },
   "panels/issues/IssueView.ts | learnMoreS": {
     "message": "Learn more: {PH1}"
   },
@@ -5093,6 +5123,9 @@
   "panels/issues/IssueView.ts | restrictionStatus": {
     "message": "Restriction Status"
   },
+  "panels/issues/IssueView.ts | unhideIssuesLikeThis": {
+    "message": "Unhide issues like this"
+  },
   "panels/issues/IssueView.ts | warned": {
     "message": "Warned"
   },