chrome-devtools-frontend 1.0.925655 → 1.0.927419

package/front_end/entrypoints/main/main-meta.ts

@@ -210,6 +210,11 @@ const UIStrings = {
    * Chrome's UI language.
    */
   browserLanguage: 'Browser UI language',
+  /**
+   * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
+   * of syncing DevTools settings via Chrome Sync.
+   */
+  enableSync: 'Enable settings sync',
 };
 const str_ = i18n.i18n.registerUIStrings('entrypoints/main/main-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
@@ -762,6 +767,17 @@ Common.Settings.registerSettingExtension({
   experiment: Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS,
 });
 
+Common.Settings.registerSettingExtension({
+  category: Common.Settings.SettingCategory.SYNC,
+  // This name must be kept in sync with DevToolsSettings::kSyncDevToolsPreferencesFrontendName.
+  settingName: 'sync_preferences',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  title: i18nLazyString(UIStrings.enableSync),
+  defaultValue: false,
+  reloadRequired: true,
+  experiment: Root.Runtime.ExperimentName.SYNC_SETTINGS,
+});
+
 Common.Settings.registerSettingExtension({
   settingName: 'userShortcuts',
   settingType: Common.Settings.SettingType.ARRAY,

package/front_end/generated/InspectorBackendCommands.js

@@ -271,6 +271,8 @@ export function registerCommands(inspectorBackend) {
     AttributionTriggerDataTooLarge: 'AttributionTriggerDataTooLarge',
     AttributionEventSourceTriggerDataTooLarge: 'AttributionEventSourceTriggerDataTooLarge'
   });
+  inspectorBackend.registerEnum(
+      'Audits.GenericIssueErrorType', {CrossOriginPortalPostMessageError: 'CrossOriginPortalPostMessageError'});
   inspectorBackend.registerEnum('Audits.InspectorIssueCode', {
     SameSiteCookieIssue: 'SameSiteCookieIssue',
     MixedContentIssue: 'MixedContentIssue',
@@ -284,7 +286,8 @@ export function registerCommands(inspectorBackend) {
     AttributionReportingIssue: 'AttributionReportingIssue',
     QuirksModeIssue: 'QuirksModeIssue',
     NavigatorUserAgentIssue: 'NavigatorUserAgentIssue',
-    WasmCrossOriginModuleSharingIssue: 'WasmCrossOriginModuleSharingIssue'
+    WasmCrossOriginModuleSharingIssue: 'WasmCrossOriginModuleSharingIssue',
+    GenericIssue: 'GenericIssue'
   });
   inspectorBackend.registerEvent('Audits.issueAdded', ['issue']);
   inspectorBackend.registerEnum('Audits.GetEncodedResponseRequestEncoding', {Webp: 'webp', Jpeg: 'jpeg', Png: 'png'});
@@ -1535,6 +1538,7 @@ export function registerCommands(inspectorBackend) {
     HeaderDisallowedByPreflightResponse: 'HeaderDisallowedByPreflightResponse',
     RedirectContainsCredentials: 'RedirectContainsCredentials',
     InsecurePrivateNetwork: 'InsecurePrivateNetwork',
+    InvalidPrivateNetworkAccess: 'InvalidPrivateNetworkAccess',
     NoCorsRedirectModeNotFollow: 'NoCorsRedirectModeNotFollow'
   });
   inspectorBackend.registerEnum(
@@ -1921,6 +1925,9 @@ export function registerCommands(inspectorBackend) {
       'Overlay.setShowViewportSizeOnResize', [{'name': 'show', 'type': 'boolean', 'optional': false}], []);
   inspectorBackend.registerCommand(
       'Overlay.setShowHinge', [{'name': 'hingeConfig', 'type': 'object', 'optional': true}], []);
+  inspectorBackend.registerCommand(
+      'Overlay.setShowIsolatedElements',
+      [{'name': 'isolatedElementHighlightConfigs', 'type': 'object', 'optional': false}], []);
 
   // Page.
   inspectorBackend.registerEnum('Page.AdFrameType', {None: 'none', Child: 'child', Root: 'root'});
@@ -3182,12 +3189,6 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerCommand('Profiler.stopTypeProfile', [], []);
   inspectorBackend.registerCommand('Profiler.takePreciseCoverage', [], ['result', 'timestamp']);
   inspectorBackend.registerCommand('Profiler.takeTypeProfile', [], ['result']);
-  inspectorBackend.registerCommand('Profiler.enableCounters', [], []);
-  inspectorBackend.registerCommand('Profiler.disableCounters', [], []);
-  inspectorBackend.registerCommand('Profiler.getCounters', [], ['result']);
-  inspectorBackend.registerCommand('Profiler.enableRuntimeCallStats', [], []);
-  inspectorBackend.registerCommand('Profiler.disableRuntimeCallStats', [], []);
-  inspectorBackend.registerCommand('Profiler.getRuntimeCallStats', [], ['result']);
 
   // Runtime.
   inspectorBackend.registerEnum('Runtime.RemoteObjectType', {

package/front_end/generated/SupportedCSSProperties.js

@@ -445,6 +445,12 @@ export const generatedProperties = [
     ]
   },
   {'name': 'font-style', 'inherited': true, 'keywords': ['normal', 'italic', 'oblique']},
+  {
+    'longhands': ['font-synthesis-weight', 'font-synthesis-style', 'font-synthesis-small-caps'],
+    'name': 'font-synthesis',
+    'inherited': true
+  },
+  {'name': 'font-synthesis-small-caps', 'inherited': true, 'keywords': ['auto', 'none']},
   {'name': 'font-synthesis-style', 'inherited': true, 'keywords': ['auto', 'none']},
   {'name': 'font-synthesis-weight', 'inherited': true, 'keywords': ['auto', 'none']},
   {
@@ -780,7 +786,6 @@ export const generatedProperties = [
   },
   {'name': 'text-underline-offset', 'inherited': true, 'keywords': ['auto']},
   {'name': 'text-underline-position', 'inherited': true, 'keywords': ['auto', 'from-font', 'under', 'left', 'right']},
-  {'name': 'time-range'},
   {'name': 'top', 'keywords': ['auto']},
   {
     'name': 'touch-action',
@@ -1010,6 +1015,7 @@ export const generatedPropertyValues = {
     ]
   },
   'font-style': {'values': ['normal', 'italic', 'oblique']},
+  'font-synthesis-small-caps': {'values': ['auto', 'none']},
   'font-synthesis-style': {'values': ['auto', 'none']},
   'font-synthesis-weight': {'values': ['auto', 'none']},
   'font-variant-caps': {

package/front_end/generated/protocol-mapping.d.ts

@@ -2098,6 +2098,11 @@ export namespace ProtocolMapping {
      * Add a dual screen device hinge
      */
     'Overlay.setShowHinge': {paramsType: [Protocol.Overlay.SetShowHingeRequest?]; returnType: void;};
+    /**
+     * Show elements in isolation mode with overlays.
+     */
+    'Overlay.setShowIsolatedElements':
+        {paramsType: [Protocol.Overlay.SetShowIsolatedElementsRequest]; returnType: void;};
     /**
      * Deprecated, please use addScriptToEvaluateOnNewDocument instead.
      */
@@ -2981,30 +2986,6 @@ export namespace ProtocolMapping {
      * Collect type profile.
      */
     'Profiler.takeTypeProfile': {paramsType: []; returnType: Protocol.Profiler.TakeTypeProfileResponse;};
-    /**
-     * Enable counters collection.
-     */
-    'Profiler.enableCounters': {paramsType: []; returnType: void;};
-    /**
-     * Disable counters collection.
-     */
-    'Profiler.disableCounters': {paramsType: []; returnType: void;};
-    /**
-     * Retrieve counters.
-     */
-    'Profiler.getCounters': {paramsType: []; returnType: Protocol.Profiler.GetCountersResponse;};
-    /**
-     * Enable run time call stats collection.
-     */
-    'Profiler.enableRuntimeCallStats': {paramsType: []; returnType: void;};
-    /**
-     * Disable run time call stats collection.
-     */
-    'Profiler.disableRuntimeCallStats': {paramsType: []; returnType: void;};
-    /**
-     * Retrieve run time call stats.
-     */
-    'Profiler.getRuntimeCallStats': {paramsType: []; returnType: Protocol.Profiler.GetRuntimeCallStatsResponse;};
     /**
      * Add handler to promise with given promise object id.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -2321,6 +2321,12 @@ declare namespace ProtocolProxyApi {
      * Add a dual screen device hinge
      */
     invoke_setShowHinge(params: Protocol.Overlay.SetShowHingeRequest): Promise<Protocol.ProtocolResponseWithError>;
+
+    /**
+     * Show elements in isolation mode with overlays.
+     */
+    invoke_setShowIsolatedElements(params: Protocol.Overlay.SetShowIsolatedElementsRequest):
+        Promise<Protocol.ProtocolResponseWithError>;
   }
   export interface OverlayDispatcher {
     /**
@@ -3873,35 +3879,6 @@ declare namespace ProtocolProxyApi {
      */
     invoke_takeTypeProfile(): Promise<Protocol.Profiler.TakeTypeProfileResponse>;
 
-    /**
-     * Enable counters collection.
-     */
-    invoke_enableCounters(): Promise<Protocol.ProtocolResponseWithError>;
-
-    /**
-     * Disable counters collection.
-     */
-    invoke_disableCounters(): Promise<Protocol.ProtocolResponseWithError>;
-
-    /**
-     * Retrieve counters.
-     */
-    invoke_getCounters(): Promise<Protocol.Profiler.GetCountersResponse>;
-
-    /**
-     * Enable run time call stats collection.
-     */
-    invoke_enableRuntimeCallStats(): Promise<Protocol.ProtocolResponseWithError>;
-
-    /**
-     * Disable run time call stats collection.
-     */
-    invoke_disableRuntimeCallStats(): Promise<Protocol.ProtocolResponseWithError>;
-
-    /**
-     * Retrieve run time call stats.
-     */
-    invoke_getRuntimeCallStats(): Promise<Protocol.Profiler.GetRuntimeCallStatsResponse>;
   }
   export interface ProfilerDispatcher {
     consoleProfileFinished(params: Protocol.Profiler.ConsoleProfileFinishedEvent): void;

package/front_end/generated/protocol.d.ts

@@ -1070,6 +1070,21 @@ declare namespace Protocol {
       isWarning: boolean;
     }
 
+    export const enum GenericIssueErrorType {
+      CrossOriginPortalPostMessageError = 'CrossOriginPortalPostMessageError',
+    }
+
+    /**
+     * Depending on the concrete errorType, different properties are set.
+     */
+    export interface GenericIssueDetails {
+      /**
+       * Issues with the same errorType are aggregated in the frontend.
+       */
+      errorType: GenericIssueErrorType;
+      frameId?: Page.FrameId;
+    }
+
     /**
      * A unique identifier for the type of issue. Each type may use one of the
      * optional fields in InspectorIssueDetails to convey more specific
@@ -1089,6 +1104,7 @@ declare namespace Protocol {
       QuirksModeIssue = 'QuirksModeIssue',
       NavigatorUserAgentIssue = 'NavigatorUserAgentIssue',
       WasmCrossOriginModuleSharingIssue = 'WasmCrossOriginModuleSharingIssue',
+      GenericIssue = 'GenericIssue',
     }
 
     /**
@@ -1110,6 +1126,7 @@ declare namespace Protocol {
       quirksModeIssueDetails?: QuirksModeIssueDetails;
       navigatorUserAgentIssueDetails?: NavigatorUserAgentIssueDetails;
       wasmCrossOriginModuleSharingIssue?: WasmCrossOriginModuleSharingIssueDetails;
+      genericIssueDetails?: GenericIssueDetails;
     }
 
     /**
@@ -7177,6 +7194,7 @@ declare namespace Protocol {
       HeaderDisallowedByPreflightResponse = 'HeaderDisallowedByPreflightResponse',
       RedirectContainsCredentials = 'RedirectContainsCredentials',
       InsecurePrivateNetwork = 'InsecurePrivateNetwork',
+      InvalidPrivateNetworkAccess = 'InvalidPrivateNetworkAccess',
       NoCorsRedirectModeNotFollow = 'NoCorsRedirectModeNotFollow',
     }
 
@@ -9465,6 +9483,32 @@ declare namespace Protocol {
       descendantBorder?: LineStyle;
     }
 
+    export interface IsolatedElementHighlightConfig {
+      /**
+       * A descriptor for the highlight appearance of an element in isolation mode.
+       */
+      isolationModeHighlightConfig: IsolationModeHighlightConfig;
+      /**
+       * Identifier of the isolated element to highlight.
+       */
+      nodeId: DOM.NodeId;
+    }
+
+    export interface IsolationModeHighlightConfig {
+      /**
+       * The fill color of the resizers (default: transparent).
+       */
+      resizerColor?: DOM.RGBA;
+      /**
+       * The fill color for resizer handles (default: transparent).
+       */
+      resizerHandleColor?: DOM.RGBA;
+      /**
+       * The fill color for the mask covering non-isolated elements (default: transparent).
+       */
+      maskColor?: DOM.RGBA;
+    }
+
     export const enum InspectMode {
       SearchForNode = 'searchForNode',
       SearchForUAShadowDOM = 'searchForUAShadowDOM',
@@ -9744,6 +9788,13 @@ declare namespace Protocol {
       hingeConfig?: HingeConfig;
     }
 
+    export interface SetShowIsolatedElementsRequest {
+      /**
+       * An array of node identifiers and descriptors for the highlight appearance.
+       */
+      isolatedElementHighlightConfigs: IsolatedElementHighlightConfig[];
+    }
+
     /**
      * Fired when the node should be inspected. This happens after call to `setInspectMode` or when
      * user manually inspects an element.
@@ -15343,38 +15394,6 @@ declare namespace Protocol {
       entries: TypeProfileEntry[];
     }
 
-    /**
-     * Collected counter information.
-     */
-    export interface CounterInfo {
-      /**
-       * Counter name.
-       */
-      name: string;
-      /**
-       * Counter value.
-       */
-      value: integer;
-    }
-
-    /**
-     * Runtime call counter information.
-     */
-    export interface RuntimeCallCounterInfo {
-      /**
-       * Counter name.
-       */
-      name: string;
-      /**
-       * Counter value.
-       */
-      value: number;
-      /**
-       * Counter time in seconds.
-       */
-      time: number;
-    }
-
     export interface GetBestEffortCoverageResponse extends ProtocolResponseWithError {
       /**
        * Coverage data for the current isolate.
@@ -15436,20 +15455,6 @@ declare namespace Protocol {
       result: ScriptTypeProfile[];
     }
 
-    export interface GetCountersResponse extends ProtocolResponseWithError {
-      /**
-       * Collected counters information.
-       */
-      result: CounterInfo[];
-    }
-
-    export interface GetRuntimeCallStatsResponse extends ProtocolResponseWithError {
-      /**
-       * Collected runtime call counter information.
-       */
-      result: RuntimeCallCounterInfo[];
-    }
-
     export interface ConsoleProfileFinishedEvent {
       id: string;
       /**

package/front_end/models/bindings/DebuggerWorkspaceBinding.ts

@@ -90,8 +90,6 @@ export class DebuggerWorkspaceBinding implements SDK.TargetManager.SDKModelObser
       return true;
     }
 
-    // TODO(crbug.com/1018234): Also take into account source maps here and remove the auto-stepping
-    // logic in the front-end (which is currently still an experiment) completely.
     const rawLocation = callFrame.location();
     if (!rawLocation) {
       return [];
@@ -118,10 +116,6 @@ export class DebuggerWorkspaceBinding implements SDK.TargetManager.SDKModelObser
       }
     }
 
-    if (!Root.Runtime.experiments.isEnabled('emptySourceMapAutoStepping')) {
-      return [];
-    }
-
     const compilerMapping = this.debuggerModelToData.get(rawLocation.debuggerModel)?.compilerMapping;
     if (!compilerMapping) {
       return [];

package/front_end/models/issues_manager/CorsIssue.ts

@@ -41,6 +41,7 @@ export enum IssueCode {
   PreflightInvalidAllowExternal = 'CorsIssue::PreflightInvalidAllowExternal',
   InvalidResponse = 'CorsIssue::InvalidResponse',
   NoCorsRedirectModeNotFollow = 'CorsIssue::NoCorsRedirectModeNotFollow',
+  InvalidPrivateNetworkAccess = 'CorsIssue::InvalidPrivateNetworkAccess',
 }
 
 function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
@@ -87,6 +88,8 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
                                                                      IssueCode.InsecurePrivateNetwork;
     case Protocol.Network.CorsError.NoCorsRedirectModeNotFollow:
       return IssueCode.NoCorsRedirectModeNotFollow;
+    case Protocol.Network.CorsError.InvalidPrivateNetworkAccess:
+      return IssueCode.InvalidPrivateNetworkAccess;
   }
 }
 
@@ -217,6 +220,7 @@ export class CorsIssue extends Issue<IssueCode> {
       case IssueCode.PreflightMissingAllowExternal:
       case IssueCode.PreflightInvalidAllowExternal:
       case IssueCode.InvalidResponse:
+      case IssueCode.InvalidPrivateNetworkAccess:
         return null;
     }
   }

package/front_end/models/logs/LogManager.ts

@@ -48,6 +48,7 @@ export class LogManager implements SDK.TargetManager.SDKModelObserver<SDK.LogMod
       stackTrace: entry.stackTrace,
       timestamp: entry.timestamp,
       workerId: entry.workerId,
+      category: entry.category,
     };
     const consoleMessage = new SDK.ConsoleModel.ConsoleMessage(
         target.model(SDK.RuntimeModel.RuntimeModel), entry.source, entry.level, entry.text, details);

package/front_end/models/persistence/WorkspaceSettingsTab.ts

@@ -49,6 +49,7 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
   private constructor() {
     super();
 
+    this.element.classList.add('workspace-settings-tab');
     const header = this.element.createChild('header');
     UI.UIUtils.createTextChild(header.createChild('h1'), i18nString(UIStrings.workspace));
 
@@ -93,6 +94,11 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
     return workspaceSettingsTabInstance;
   }
 
+  wasShown(): void {
+    super.wasShown();
+    this.registerCSSFiles([workspaceSettingsTabStyles]);
+  }
+
   private createFolderExcludePatternInput(): Element {
     const p = document.createElement('p');
     const labelElement = p.createChild('label');
@@ -191,8 +197,4 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
       element.remove();
     }
   }
-  wasShown(): void {
-    super.wasShown();
-    this.registerCSSFiles([workspaceSettingsTabStyles]);
-  }
 }

package/front_end/models/persistence/workspaceSettingsTab.css

@@ -4,18 +4,18 @@
  * found in the LICENSE file.
  */
 
-header {
+.workspace-settings-tab header {
   padding: 0 0 6px;
 }
 
-header > h1 {
+.workspace-settings-tab header > h1 {
   font-size: 18px;
   font-weight: normal;
   margin: 0;
   padding-bottom: 3px;
 }
 
-.settings-content {
+.workspace-settings-tab .settings-content {
   overflow-y: auto;
   overflow-x: hidden;
   margin: 8px 8px 8px 0;
@@ -23,21 +23,21 @@ header > h1 {
   flex: auto;
 }
 
-.settings-container {
+.workspace-settings-tab .settings-container {
   width: 100%;
   column-width: 288px;
 }
 
-.settings-tab.settings-container {
+.workspace-settings-tab .settings-tab.settings-container {
   column-width: 308px;
 }
 
-.settings-tab label {
+.workspace-settings-tab .settings-tab label {
   padding-right: 4px;
   display: inline-flex;
 }
 
-.settings-container-wrapper {
+.workspace-settings-tab .settings-container-wrapper {
   position: absolute;
   top: 31px;
   left: 0;
@@ -47,37 +47,37 @@ header > h1 {
   padding-top: 9px;
 }
 
-.settings-tab.settings-content {
+.workspace-settings-tab .settings-tab.settings-content {
   margin: 0;
   padding: 0;
 }
 
-.settings-tab p {
+.workspace-settings-tab .settings-tab p {
   margin: 12px 0;
 }
 
-p.folder-exclude-pattern {
+.workspace-settings-tab p.folder-exclude-pattern {
   display: flex;
   align-items: center;
 }
 
-p.folder-exclude-pattern > input {
+.workspace-settings-tab p.folder-exclude-pattern > input {
   flex: auto;
 }
 
-.settings-tab .file-system-container {
+.workspace-settings-tab .settings-tab .file-system-container {
   border-top: 1px solid var(--color-background-elevation-2);
   padding: 19px 0 10px;
   margin: 20px 0;
 }
 
-.settings-tab .file-system-header {
+.workspace-settings-tab .settings-tab .file-system-header {
   display: flex;
   flex-direction: row;
   align-items: center;
 }
 
-.settings-tab .file-system-name {
+.workspace-settings-tab .settings-tab .file-system-name {
   font-weight: bold;
   flex: none;
   margin-right: 10px;
@@ -87,20 +87,20 @@ p.folder-exclude-pattern > input {
   max-width: 70%;
 }
 
-.settings-tab .file-system-path {
+.workspace-settings-tab .settings-tab .file-system-path {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
   flex: auto;
 }
 
-.settings-info-message {
+.workspace-settings-tab .settings-info-message {
   background-color: var(--color-background-elevation-1);
   padding: 10px;
   margin: 20px 0;
 }
 
-.settings-tab.settings-content.settings-container {
+.workspace-settings-tab .settings-tab.settings-content.settings-container {
   column-width: initial;
   overflow: hidden;
   padding-right: 10px;
@@ -109,6 +109,6 @@ p.folder-exclude-pattern > input {
  * Always show an outline. Needed because we have a white background here.
  */
 
-.harmony-input[type=text]:not(.error-input):not(:invalid) {
+.workspace-settings-tab .harmony-input[type=text]:not(.error-input):not(:invalid) {
   box-shadow: var(--legacy-focus-ring-inactive-shadow);
 }