chrome-devtools-frontend 1.0.923302 → 1.0.925026

package/front_end/panels/profiler/HeapSnapshotView.ts

@@ -306,7 +306,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     this.linkifier = new Components.Linkifier.Linkifier();
     const profileType = profile.profileType();
 
-    profileType.addEventListener(HeapSnapshotProfileType.SnapshotReceived, this.onReceiveSnapshot, this);
+    profileType.addEventListener(HeapSnapshotProfileTypeEvents.SnapshotReceived, this.onReceiveSnapshot, this);
     profileType.addEventListener(ProfileTypeEvents.RemoveProfileHeader, this.onProfileHeaderRemoved, this);
 
     const isHeapTimeline = profileType.id === TrackingHeapSnapshotProfileType.TypeId;
@@ -429,7 +429,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     this.currentPerspectiveIndex = 0;
     this.currentPerspective = this.perspectives[0];
     this.currentPerspective.activate(this);
-    this.dataGrid = (this.currentPerspective.masterGrid(this) as HeapSnapshotSortableDataGrid | null);
+    this.dataGrid = this.currentPerspective.masterGrid(this);
 
     this.populate();
     this.searchThrottler = new Common.Throttler.Throttler(0);
@@ -444,26 +444,27 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     this.trackingOverviewGrid = new HeapTimelineOverview();
     this.trackingOverviewGrid.addEventListener(Events.IdsRangeChanged, this.onIdsRangeChanged.bind(this));
     if (!this.profile.fromFile() && profileType.profileBeingRecorded() === this.profile) {
-      profileType.addEventListener(TrackingHeapSnapshotProfileType.HeapStatsUpdate, this.onHeapStatsUpdate, this);
-      profileType.addEventListener(TrackingHeapSnapshotProfileType.TrackingStopped, this.onStopTracking, this);
+      (profileType as TrackingHeapSnapshotProfileType)
+          .addEventListener(TrackingHeapSnapshotProfileTypeEvents.HeapStatsUpdate, this.onHeapStatsUpdate, this);
+      (profileType as TrackingHeapSnapshotProfileType)
+          .addEventListener(TrackingHeapSnapshotProfileTypeEvents.TrackingStopped, this.onStopTracking, this);
       this.trackingOverviewGrid.start();
     }
   }
 
   onStopTracking(): void {
-    this.profile.profileType().removeEventListener(
-        TrackingHeapSnapshotProfileType.HeapStatsUpdate, this.onHeapStatsUpdate, this);
-    this.profile.profileType().removeEventListener(
-        TrackingHeapSnapshotProfileType.TrackingStopped, this.onStopTracking, this);
+    const profileType = this.profile.profileType() as TrackingHeapSnapshotProfileType;
+    profileType.removeEventListener(
+        TrackingHeapSnapshotProfileTypeEvents.HeapStatsUpdate, this.onHeapStatsUpdate, this);
+    profileType.removeEventListener(TrackingHeapSnapshotProfileTypeEvents.TrackingStopped, this.onStopTracking, this);
     if (this.trackingOverviewGrid) {
       this.trackingOverviewGrid.stop();
     }
   }
 
-  onHeapStatsUpdate(event: Common.EventTarget.EventTargetEvent): void {
-    const samples = event.data;
-    if (samples && this.trackingOverviewGrid) {
-      this.trackingOverviewGrid.setSamples(event.data);
+  onHeapStatsUpdate({data: samples}: Common.EventTarget.EventTargetEvent<Samples>): void {
+    if (this.trackingOverviewGrid) {
+      this.trackingOverviewGrid.setSamples(samples);
     }
   }
 
@@ -726,19 +727,22 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     return this.profile.profileType().getProfiles();
   }
 
-  selectionChanged(event: Common.EventTarget.EventTargetEvent): void {
+  selectionChanged(event: Common.EventTarget.EventTargetEvent<DataGrid.DataGrid.DataGridNode<HeapSnapshotGridNode>>):
+      void {
     const selectedNode = (event.data as HeapSnapshotGridNode);
     this.setSelectedNodeForDetailsView(selectedNode);
     this.inspectedObjectChanged(event);
   }
 
-  onSelectAllocationNode(event: Common.EventTarget.EventTargetEvent): void {
+  onSelectAllocationNode(
+      event: Common.EventTarget.EventTargetEvent<DataGrid.DataGrid.DataGridNode<HeapSnapshotGridNode>>): void {
     const selectedNode = (event.data as AllocationGridNode);
     this.constructorsDataGrid.setAllocationNodeId(selectedNode.allocationNodeId());
     this.setSelectedNodeForDetailsView(null);
   }
 
-  inspectedObjectChanged(event: Common.EventTarget.EventTargetEvent): void {
+  inspectedObjectChanged(
+      event: Common.EventTarget.EventTargetEvent<DataGrid.DataGrid.DataGridNode<HeapSnapshotGridNode>>): void {
     const selectedNode = (event.data as HeapSnapshotGridNode);
     const heapProfilerModel = this.profile.heapProfilerModel();
     if (heapProfilerModel && selectedNode instanceof HeapSnapshotGenericObjectNode) {
@@ -955,20 +959,20 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     this.updateFilterOptions();
   }
 
-  onReceiveSnapshot(event: Common.EventTarget.EventTargetEvent): void {
+  onReceiveSnapshot(event: Common.EventTarget.EventTargetEvent<ProfileHeader>): void {
     this.updateControls();
     const profile = event.data;
     profile.addEventListener(ProfileHeaderEvents.ProfileTitleChanged, this.updateControls, this);
   }
 
-  onProfileHeaderRemoved(event: Common.EventTarget.EventTargetEvent): void {
+  onProfileHeaderRemoved(event: Common.EventTarget.EventTargetEvent<ProfileHeader>): void {
     const profile = event.data;
     profile.removeEventListener(ProfileHeaderEvents.ProfileTitleChanged, this.updateControls, this);
 
     if (this.profile === profile) {
       this.detach();
       this.profile.profileType().removeEventListener(
-          HeapSnapshotProfileType.SnapshotReceived, this.onReceiveSnapshot, this);
+          HeapSnapshotProfileTypeEvents.SnapshotReceived, this.onReceiveSnapshot, this);
       this.profile.profileType().removeEventListener(
           ProfileTypeEvents.RemoveProfileHeader, this.onProfileHeaderRemoved, this);
       this.dispose();
@@ -1020,7 +1024,7 @@ export class Perspective {
     heapSnapshotView.splitWidget.detachChildWidgets();
   }
 
-  masterGrid(_heapSnapshotView: HeapSnapshotView): DataGrid.DataGrid.DataGridImpl<HeapSnapshotGridNode>|null {
+  masterGrid(_heapSnapshotView: HeapSnapshotView): HeapSnapshotSortableDataGrid|null {
     return null;
   }
 
@@ -1053,7 +1057,7 @@ export class SummaryPerspective extends Perspective {
     heapSnapshotView.trackingOverviewGrid.updateGrid();
   }
 
-  masterGrid(heapSnapshotView: HeapSnapshotView): DataGrid.DataGrid.DataGridImpl<HeapSnapshotGridNode>|null {
+  masterGrid(heapSnapshotView: HeapSnapshotView): HeapSnapshotSortableDataGrid {
     return heapSnapshotView.constructorsDataGrid;
   }
 
@@ -1075,7 +1079,7 @@ export class ComparisonPerspective extends Perspective {
     heapSnapshotView.classNameFilter.setVisible(true);
   }
 
-  masterGrid(heapSnapshotView: HeapSnapshotView): DataGrid.DataGrid.DataGridImpl<HeapSnapshotGridNode>|null {
+  masterGrid(heapSnapshotView: HeapSnapshotView): HeapSnapshotSortableDataGrid {
     return heapSnapshotView.diffDataGrid;
   }
 
@@ -1095,7 +1099,7 @@ export class ContainmentPerspective extends Perspective {
     heapSnapshotView.splitWidget.show(heapSnapshotView.searchableViewInternal.element);
   }
 
-  masterGrid(heapSnapshotView: HeapSnapshotView): DataGrid.DataGrid.DataGridImpl<HeapSnapshotGridNode>|null {
+  masterGrid(heapSnapshotView: HeapSnapshotView): HeapSnapshotSortableDataGrid {
     return heapSnapshotView.containmentDataGrid;
   }
 }
@@ -1143,7 +1147,7 @@ export class AllocationPerspective extends Perspective {
     super.deactivate(heapSnapshotView);
   }
 
-  masterGrid(heapSnapshotView: HeapSnapshotView): DataGrid.DataGrid.DataGridImpl<HeapSnapshotGridNode>|null {
+  masterGrid(heapSnapshotView: HeapSnapshotView): HeapSnapshotSortableDataGrid|null {
     return heapSnapshotView.allocationDataGrid;
   }
 }
@@ -1157,13 +1161,14 @@ export class StatisticsPerspective extends Perspective {
     heapSnapshotView.statisticsView.show(heapSnapshotView.searchableViewInternal.element);
   }
 
-  masterGrid(_heapSnapshotView: HeapSnapshotView): DataGrid.DataGrid.DataGridImpl<HeapSnapshotGridNode>|null {
+  masterGrid(_heapSnapshotView: HeapSnapshotView): HeapSnapshotSortableDataGrid|null {
     return null;
   }
 }
 
-export class HeapSnapshotProfileType extends ProfileType implements
-    SDK.TargetManager.SDKModelObserver<SDK.HeapProfilerModel.HeapProfilerModel> {
+export class HeapSnapshotProfileType extends
+    Common.ObjectWrapper.eventMixin<HeapSnapshotProfileTypeEventTypes, typeof ProfileType>(ProfileType)
+        implements SDK.TargetManager.SDKModelObserver<SDK.HeapProfilerModel.HeapProfilerModel> {
   readonly treatGlobalObjectsAsRoots: Common.Settings.Setting<boolean>;
   readonly captureNumericValue: Common.Settings.Setting<boolean>;
   customContentInternal: HTMLElement|null;
@@ -1313,16 +1318,27 @@ export class HeapSnapshotProfileType extends ProfileType implements
     if (this.profileBeingRecorded() === profile) {
       this.setProfileBeingRecorded(null);
     }
-    this.dispatchEventToListeners(HeapSnapshotProfileType.SnapshotReceived, profile);
+    this.dispatchEventToListeners(HeapSnapshotProfileTypeEvents.SnapshotReceived, profile);
   }
 
   // eslint-disable-next-line @typescript-eslint/naming-convention
   static readonly TypeId: string = 'HEAP';
+  // TODO(crbug.com/1228674): Remove event string once its no longer used in web tests.
   // eslint-disable-next-line @typescript-eslint/naming-convention
   static readonly SnapshotReceived = 'SnapshotReceived';
 }
 
-export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
+export const enum HeapSnapshotProfileTypeEvents {
+  SnapshotReceived = 'SnapshotReceived',
+}
+
+export type HeapSnapshotProfileTypeEventTypes = {
+  [HeapSnapshotProfileTypeEvents.SnapshotReceived]: ProfileHeader,
+};
+
+export class TrackingHeapSnapshotProfileType extends
+    Common.ObjectWrapper.eventMixin<TrackingHeapSnapshotProfileTypeEventTypes, typeof HeapSnapshotProfileType>(
+        HeapSnapshotProfileType) {
   readonly recordAllocationStacksSettingInternal: Common.Settings.Setting<boolean>;
   customContentInternal: UI.UIUtils.CheckboxLabel|null;
   recording: boolean;
@@ -1380,7 +1396,9 @@ export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
     if (profileSamples.totalTime < timestamp - profileSamples.timestamps[0]) {
       profileSamples.totalTime *= 2;
     }
-    this.dispatchEventToListeners(TrackingHeapSnapshotProfileType.HeapStatsUpdate, this.profileSamples);
+    if (this.profileSamples) {
+      this.dispatchEventToListeners(TrackingHeapSnapshotProfileTypeEvents.HeapStatsUpdate, this.profileSamples);
+    }
     const profile = this.profileBeingRecorded();
     if (profile) {
       profile.updateStatus(null, true);
@@ -1445,7 +1463,7 @@ export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
     this.recording = true;
     this.addProfile((this.profileBeingRecorded() as ProfileHeader));
     (this.profileBeingRecorded() as HeapProfileHeader).updateStatus(i18nString(UIStrings.recording));
-    this.dispatchEventToListeners(TrackingHeapSnapshotProfileType.TrackingStarted);
+    this.dispatchEventToListeners(TrackingHeapSnapshotProfileTypeEvents.TrackingStarted);
     return heapProfilerModel;
   }
 
@@ -1455,7 +1473,7 @@ export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
     const stopPromise =
         (profile.heapProfilerModel() as SDK.HeapProfilerModel.HeapProfilerModel).stopTrackingHeapObjects(true);
     this.recording = false;
-    this.dispatchEventToListeners(TrackingHeapSnapshotProfileType.TrackingStopped);
+    this.dispatchEventToListeners(TrackingHeapSnapshotProfileTypeEvents.TrackingStopped);
     await stopPromise;
     profile = (this.profileBeingRecorded() as HeapProfileHeader);
     if (!profile) {
@@ -1488,7 +1506,7 @@ export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
     return i18nString(UIStrings.AllocationTimelinesShowInstrumented);
   }
 
-  resetProfiles(event: Common.EventTarget.EventTargetEvent): void {
+  resetProfiles(event: Common.EventTarget.EventTargetEvent<SDK.HeapProfilerModel.HeapProfilerModel>): void {
     const wasRecording = this.recording;
     // Clear current profile to avoid stopping backend.
     this.setProfileBeingRecorded(null);
@@ -1506,6 +1524,7 @@ export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
 
   // eslint-disable-next-line @typescript-eslint/naming-convention
   static readonly TypeId = 'HEAP-RECORD';
+  // TODO(crbug.com/1228674): Remove event strings once they are no longer used in web tests.
   // eslint-disable-next-line @typescript-eslint/naming-convention
   static readonly HeapStatsUpdate = 'HeapStatsUpdate';
   // eslint-disable-next-line @typescript-eslint/naming-convention
@@ -1514,6 +1533,18 @@ export class TrackingHeapSnapshotProfileType extends HeapSnapshotProfileType {
   static readonly TrackingStopped = 'TrackingStopped';
 }
 
+export const enum TrackingHeapSnapshotProfileTypeEvents {
+  HeapStatsUpdate = 'HeapStatsUpdate',
+  TrackingStarted = 'TrackingStarted',
+  TrackingStopped = 'TrackingStopped',
+}
+
+export type TrackingHeapSnapshotProfileTypeEventTypes = {
+  [TrackingHeapSnapshotProfileTypeEvents.HeapStatsUpdate]: Samples,
+  [TrackingHeapSnapshotProfileTypeEvents.TrackingStarted]: void,
+  [TrackingHeapSnapshotProfileTypeEvents.TrackingStopped]: void,
+};
+
 export class HeapProfileHeader extends ProfileHeader {
   readonly heapProfilerModelInternal: SDK.HeapProfilerModel.HeapProfilerModel|null;
   maxJSObjectId: number;
@@ -1736,6 +1767,10 @@ export class HeapProfileHeader extends ProfileHeader {
     }
     return success ? null : reader.error();
   }
+
+  override profileType(): HeapSnapshotProfileType {
+    return super.profileType() as HeapSnapshotProfileType;
+  }
 }
 
 export class HeapSnapshotStatisticsView extends UI.Widget.VBox {

package/front_end/panels/profiler/LiveHeapProfileView.ts

@@ -183,8 +183,8 @@ export class LiveHeapProfileView extends UI.Widget.VBox {
     this.setting.removeChangeListener(this.settingChanged, this);
   }
 
-  settingChanged(value: Common.EventTarget.EventTargetEvent): void {
-    this.toggleRecordButton.setToggled((value.data as boolean));
+  settingChanged(value: Common.EventTarget.EventTargetEvent<boolean>): void {
+    this.toggleRecordButton.setToggled(value.data);
   }
 
   async poll(): Promise<void> {

package/front_end/panels/profiler/ProfileHeader.ts

@@ -104,7 +104,7 @@ export type EventTypes = {
   [Events.ProfileTitleChanged]: ProfileHeader,
 };
 
-export abstract class ProfileType extends Common.ObjectWrapper.ObjectWrapper {
+export class ProfileType extends Common.ObjectWrapper.ObjectWrapper<ProfileEventTypes> {
   readonly idInternal: string;
   readonly nameInternal: string;
   profiles: ProfileHeader[];
@@ -212,7 +212,9 @@ export abstract class ProfileType extends Common.ObjectWrapper.ObjectWrapper {
     return profile.loadFromFile(file);
   }
 
-  abstract createProfileLoadedFromFile(title: string): ProfileHeader;
+  createProfileLoadedFromFile(_title: string): ProfileHeader {
+    throw new Error('Not implemented');
+  }
 
   addProfile(profile: ProfileHeader): void {
     this.profiles.push(profile);
@@ -272,6 +274,13 @@ export enum ProfileEvents {
   ViewUpdated = 'view-updated',
 }
 
+export type ProfileEventTypes = {
+  [ProfileEvents.AddProfileHeader]: ProfileHeader,
+  [ProfileEvents.ProfileComplete]: ProfileHeader,
+  [ProfileEvents.RemoveProfileHeader]: ProfileHeader,
+  [ProfileEvents.ViewUpdated]: void,
+};
+
 export interface DataDisplayDelegate {
   showProfile(profile: ProfileHeader|null): UI.Widget.Widget|null;
   showObject(snapshotObjectId: string, perspectiveName: string): void;

package/front_end/panels/profiler/ProfileView.ts

@@ -480,7 +480,7 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
     this.excludeButton.setEnabled(selected);
   }
 
-  focusClicked(_event: Common.EventTarget.EventTargetEvent): void {
+  focusClicked(): void {
     if (!this.dataGrid.selectedNode) {
       return;
     }
@@ -495,7 +495,7 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.CpuProfileNodeFocused);
   }
 
-  excludeClicked(_event: Common.EventTarget.EventTargetEvent): void {
+  excludeClicked(): void {
     const selectedNode = this.dataGrid.selectedNode;
 
     if (!selectedNode) {
@@ -515,7 +515,7 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.CpuProfileNodeExcluded);
   }
 
-  resetClicked(_event: Common.EventTarget.EventTargetEvent): void {
+  resetClicked(): void {
     this.viewSelectComboBox.selectElement().focus();
     this.resetButton.setEnabled(false);
     if (this.profileDataGridTree) {

package/front_end/panels/profiler/ProfilesPanel.ts

@@ -327,16 +327,17 @@ export class ProfilesPanel extends UI.Panel.PanelWithSidebar implements DataDisp
     profileTypeSection.childrenListElement.addEventListener(
         'contextmenu', this.handleContextMenuEvent.bind(this), false);
 
-    function onAddProfileHeader(this: ProfilesPanel, event: Common.EventTarget.EventTargetEvent): void {
-      this.addProfileHeader((event.data as ProfileHeader));
+    function onAddProfileHeader(this: ProfilesPanel, event: Common.EventTarget.EventTargetEvent<ProfileHeader>): void {
+      this.addProfileHeader(event.data);
     }
 
-    function onRemoveProfileHeader(this: ProfilesPanel, event: Common.EventTarget.EventTargetEvent): void {
-      this.removeProfileHeader((event.data as ProfileHeader));
+    function onRemoveProfileHeader(
+        this: ProfilesPanel, event: Common.EventTarget.EventTargetEvent<ProfileHeader>): void {
+      this.removeProfileHeader(event.data);
     }
 
-    function profileComplete(this: ProfilesPanel, event: Common.EventTarget.EventTargetEvent): void {
-      this.showProfile((event.data as ProfileHeader));
+    function profileComplete(this: ProfilesPanel, event: Common.EventTarget.EventTargetEvent<ProfileHeader>): void {
+      this.showProfile(event.data);
     }
 
     profileType.addEventListener(ProfileTypeEvents.ViewUpdated, this.updateProfileTypeSpecificUI, this);

package/front_end/panels/screencast/InputModel.ts

@@ -6,7 +6,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import * as Protocol from '../../generated/protocol.js';
 
-export class InputModel extends SDK.SDKModel.SDKModel {
+export class InputModel extends SDK.SDKModel.SDKModel<void> {
   private readonly inputAgent: ProtocolProxyApi.InputApi;
   private activeTouchOffsetTop: number|null;
   private activeTouchParams: Protocol.Input.EmulateTouchFromMouseEventRequest|null;

package/front_end/panels/screencast/ScreencastView.ts

@@ -277,7 +277,7 @@ export class ScreencastView extends UI.Widget.VBox implements SDK.OverlayModel.H
     this.updateGlasspane();
   }
 
-  private onSuspendStateChange(_event: Common.EventTarget.EventTargetEvent): void {
+  private onSuspendStateChange(): void {
     if (SDK.TargetManager.TargetManager.instance().allTargetsSuspended()) {
       this.stopCasting();
     } else {

package/front_end/panels/security/SecurityModel.ts

@@ -41,7 +41,7 @@ const str_ = i18n.i18n.registerUIStrings('panels/security/SecurityModel.ts', UIS
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-export class SecurityModel extends SDK.SDKModel.SDKModel {
+export class SecurityModel extends SDK.SDKModel.SDKModel<EventTypes> {
   private readonly dispatcher: SecurityDispatcher;
   private readonly securityAgent: ProtocolProxyApi.SecurityApi;
   constructor(target: SDK.Target.Target) {
@@ -102,6 +102,10 @@ export enum Events {
   VisibleSecurityStateChanged = 'VisibleSecurityStateChanged',
 }
 
+export type EventTypes = {
+  [Events.VisibleSecurityStateChanged]: PageVisibleSecurityState,
+};
+
 export const SummaryMessages: {[x: string]: () => string} = {
   [Protocol.Security.SecurityState.Unknown]: i18nLazyString(UIStrings.theSecurityOfThisPageIsUnknown),
   [Protocol.Security.SecurityState.Insecure]: i18nLazyString(UIStrings.thisPageIsNotSecure),

package/front_end/panels/security/SecurityPanel.ts

@@ -540,8 +540,7 @@ export class SecurityPanel extends UI.Panel.PanelWithSidebar implements
     this.mainView.updateVisibleSecurityState(visibleSecurityState);
   }
 
-  private onVisibleSecurityStateChanged(event: Common.EventTarget.EventTargetEvent): void {
-    const data = event.data as PageVisibleSecurityState;
+  private onVisibleSecurityStateChanged({data}: Common.EventTarget.EventTargetEvent<PageVisibleSecurityState>): void {
     this.updateVisibleSecurityState(data);
   }
 

package/front_end/panels/sensors/SensorsView.ts

@@ -451,7 +451,7 @@ export class SensorsView extends UI.Widget.VBox {
       title: i18nString(UIStrings.presets),
       value: [
         {title: i18nString(UIStrings.portrait), orientation: '[0, 90, 0]'},
-        {title: i18nString(UIStrings.portraitUpsideDown), orientation: '[180, -90, 0]'},
+        {title: i18nString(UIStrings.portraitUpsideDown), orientation: '[-180, -90, 0]'},
         {title: i18nString(UIStrings.landscapeLeft), orientation: '[90, 0, -90]'},
         {title: i18nString(UIStrings.landscapeRight), orientation: '[90, -180, -90]'},
         {title: i18nString(UIStrings.displayUp), orientation: '[0, 0, 0]'},
@@ -518,6 +518,7 @@ export class SensorsView extends UI.Widget.VBox {
       this.enableOrientationFields(true);
     } else if (value === NonPresetOptions.Custom) {
       this.deviceOrientationOverrideEnabled = true;
+      this.resetDeviceOrientation();
       this.alphaElement.focus();
     } else {
       const parsedValue = JSON.parse(value);
@@ -777,7 +778,7 @@ export class PresetOrientations {
       title: i18nString(UIStrings.presets),
       value: [
         {title: i18nString(UIStrings.portrait), orientation: '[0, 90, 0]'},
-        {title: i18nString(UIStrings.portraitUpsideDown), orientation: '[180, -90, 0]'},
+        {title: i18nString(UIStrings.portraitUpsideDown), orientation: '[-180, -90, 0]'},
         {title: i18nString(UIStrings.landscapeLeft), orientation: '[90, 0, -90]'},
         {title: i18nString(UIStrings.landscapeRight), orientation: '[90, -180, -90]'},
         {title: i18nString(UIStrings.displayUp), orientation: '[0, 0, 0]'},

package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts

@@ -222,16 +222,19 @@ export class UserAgentClientHintsForm extends HTMLElement {
   }
 
   private handleTreeExpand = (event: KeyboardEvent): void => {
-    if (event.code === 'Space' || event.code === 'Enter') {
+    if (event.code === 'Space' || event.code === 'Enter' || event.code === 'ArrowLeft' || event.code === 'ArrowRight') {
       event.stopPropagation();
-      this.handleTreeClick();
+      this.handleTreeClick(event.code);
     }
   };
 
-  private handleTreeClick = (): void => {
+  private handleTreeClick = (key: string): void => {
     if (this.isFormDisabled) {
       return;
     }
+    if ((key === 'ArrowLeft' && !this.isFormOpened) || (key === 'ArrowRight' && this.isFormOpened)) {
+      return;
+    }
     this.isFormOpened = !this.isFormOpened;
     this.render();
   };

package/front_end/panels/sources/CSSPlugin.ts

@@ -261,7 +261,7 @@ export class CSSPlugin extends Plugin {
     this.swatchPopoverHelper.show(this.spectrum, swatch, this.swatchPopoverHidden.bind(this));
   }
 
-  private spectrumResized(_event: Common.EventTarget.EventTargetEvent<void>): void {
+  private spectrumResized(): void {
     this.swatchPopoverHelper.reposition();
   }
 

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -175,7 +175,8 @@ export class DebuggerPlugin extends Plugin {
   private readonly boundMouseDown: (arg0: Event) => void;
   private readonly boundBlur: (arg0: Event) => void;
   private readonly boundWheel: (arg0: Event) => void;
-  private readonly boundGutterClick: (arg0: Common.EventTarget.EventTargetEvent) => void;
+  private readonly boundGutterClick:
+      (arg0: Common.EventTarget.EventTargetEvent<SourceFrame.SourcesTextEditor.GutterClickEventData>) => void;
   private readonly breakpointDecorations: Set<BreakpointDecoration>;
   private readonly decorationByBreakpoint: Map<Bindings.BreakpointManager.Breakpoint, BreakpointDecoration>;
   private readonly possibleBreakpointsRequested: Set<number>;
@@ -270,9 +271,10 @@ export class DebuggerPlugin extends Plugin {
     this.textEditor.element.addEventListener('focusout', this.boundBlur, false);
     this.boundWheel = (this.onWheel.bind(this) as (arg0: Event) => void);
     this.textEditor.element.addEventListener('wheel', this.boundWheel, true);
-    this.boundGutterClick = (((e: Common.EventTarget.EventTargetEvent): void => {
-                               this.handleGutterClick(e);
-                             }) as (arg0: Common.EventTarget.EventTargetEvent) => void);
+    this.boundGutterClick =
+        (e: Common.EventTarget.EventTargetEvent<SourceFrame.SourcesTextEditor.GutterClickEventData>): void => {
+          this.handleGutterClick(e);
+        };
 
     this.textEditor.addEventListener(SourceFrame.SourcesTextEditor.Events.GutterClick, this.boundGutterClick, this);
 

package/front_end/panels/sources/InplaceFormatterEditorAction.ts

@@ -94,7 +94,7 @@ export class InplaceFormatterEditorAction implements EditorAction {
     return uiSourceCode.contentType().isStyleSheet();
   }
 
-  private formatSourceInPlace(_event: Common.EventTarget.EventTargetEvent): void {
+  private formatSourceInPlace(): void {
     const uiSourceCode = this.sourcesView.currentUISourceCode();
     if (!uiSourceCode || !this.isFormattable(uiSourceCode)) {
       return;

package/front_end/panels/sources/ScriptFormatterEditorAction.ts

@@ -126,7 +126,7 @@ export class ScriptFormatterEditorAction implements EditorAction {
     return this.isFormattableScript(uiSourceCode);
   }
 
-  private onFormatScriptButtonClicked(_event: Common.EventTarget.EventTargetEvent): void {
+  private onFormatScriptButtonClicked(): void {
     this.toggleFormatScriptSource();
   }
 

package/front_end/panels/sources/SourcesPanel.ts

@@ -684,7 +684,7 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
     return target ? target.model(SDK.DebuggerModel.DebuggerModel) : null;
   }
 
-  private longResume(_event: Common.EventTarget.EventTargetEvent): void {
+  private longResume(): void {
     const debuggerModel = this.prepareToResume();
     if (debuggerModel) {
       debuggerModel.skipAllPausesUntilReloadOrTimeout(500);
@@ -692,7 +692,7 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
     }
   }
 
-  private terminateExecution(_event: Common.EventTarget.EventTargetEvent): void {
+  private terminateExecution(): void {
     const debuggerModel = this.prepareToResume();
     if (debuggerModel) {
       debuggerModel.runtimeModel().terminateExecution();

package/front_end/panels/timeline/TimelineFlameChartView.ts

@@ -150,8 +150,8 @@ export class TimelineFlameChartView extends UI.Widget.VBox implements PerfUI.Fla
   private readonly countersView: CountersGraph;
   private readonly detailsSplitWidget: UI.SplitWidget.SplitWidget;
   private readonly detailsView: TimelineDetailsView;
-  private readonly onMainEntrySelected: (event?: Common.EventTarget.EventTargetEvent<number>) => void;
-  private readonly onNetworkEntrySelected: (event?: Common.EventTarget.EventTargetEvent<number>) => void;
+  private readonly onMainEntrySelected: (event: Common.EventTarget.EventTargetEvent<number>) => void;
+  private readonly onNetworkEntrySelected: (event: Common.EventTarget.EventTargetEvent<number>) => void;
   private nextExtensionIndex: number;
   private readonly boundRefresh: () => void;
   private selectedTrack: TimelineModel.TimelineModel.Track|null;
@@ -232,11 +232,7 @@ export class TimelineFlameChartView extends UI.Widget.VBox implements PerfUI.Fla
     this.detailsSplitWidget.setSidebarWidget(this.detailsView);
     this.detailsSplitWidget.show(this.element);
 
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // @ts-expect-error
     this.onMainEntrySelected = this.onEntrySelected.bind(this, this.mainDataProvider);
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // @ts-expect-error
     this.onNetworkEntrySelected = this.onEntrySelected.bind(this, this.networkDataProvider);
     this.mainFlameChart.addEventListener(PerfUI.FlameChart.Events.EntrySelected, this.onMainEntrySelected, this);
     this.mainFlameChart.addEventListener(PerfUI.FlameChart.Events.EntryInvoked, this.onMainEntrySelected, this);
@@ -428,8 +424,9 @@ export class TimelineFlameChartView extends UI.Widget.VBox implements PerfUI.Fla
   }
 
   private onEntrySelected(
-      dataProvider: PerfUI.FlameChart.FlameChartDataProvider, event: Common.EventTarget.EventTargetEvent): void {
-    const entryIndex = (event.data as number);
+      dataProvider: PerfUI.FlameChart.FlameChartDataProvider,
+      event: Common.EventTarget.EventTargetEvent<number>): void {
+    const entryIndex = event.data;
     if (Root.Runtime.experiments.isEnabled('timelineEventInitiators') && dataProvider === this.mainDataProvider) {
       if (this.mainDataProvider.buildFlowForInitiator(entryIndex)) {
         this.mainFlameChart.scheduleUpdate();

package/front_end/panels/timeline/TimelineUIUtils.ts

@@ -3605,7 +3605,7 @@ export class EventDispatchTypeDescriptor {
   }
 }
 
-export class TimelineCategory extends Common.ObjectWrapper.ObjectWrapper {
+export class TimelineCategory {
   name: string;
   title: string;
   visible: boolean;
@@ -3614,7 +3614,6 @@ export class TimelineCategory extends Common.ObjectWrapper.ObjectWrapper {
   private hiddenInternal?: boolean;
 
   constructor(name: string, title: string, visible: boolean, childColor: string, color: string) {
-    super();
     this.name = name;
     this.title = title;
     this.visible = visible;

package/front_end/panels/web_audio/AudioContextSelector.ts

@@ -59,8 +59,7 @@ export class AudioContextSelector extends Common.ObjectWrapper.ObjectWrapper<Eve
     }
   }
 
-  contextCreated(event: Common.EventTarget.EventTargetEvent): void {
-    const context = (event.data as Protocol.WebAudio.BaseAudioContext);
+  contextCreated({data: context}: Common.EventTarget.EventTargetEvent<Protocol.WebAudio.BaseAudioContext>): void {
     this.items.insert(this.items.length, context);
 
     // Select if this is the first item.
@@ -69,8 +68,7 @@ export class AudioContextSelector extends Common.ObjectWrapper.ObjectWrapper<Eve
     }
   }
 
-  contextDestroyed(event: Common.EventTarget.EventTargetEvent): void {
-    const contextId = (event.data as string);
+  contextDestroyed({data: contextId}: Common.EventTarget.EventTargetEvent<string>): void {
     const contextIndex =
         this.items.findIndex((context: Protocol.WebAudio.BaseAudioContext): boolean => context.contextId === contextId);
     if (contextIndex > -1) {
@@ -78,8 +76,8 @@ export class AudioContextSelector extends Common.ObjectWrapper.ObjectWrapper<Eve
     }
   }
 
-  contextChanged(event: Common.EventTarget.EventTargetEvent): void {
-    const changedContext = (event.data as Protocol.WebAudio.BaseAudioContext);
+  contextChanged({data: changedContext}: Common.EventTarget.EventTargetEvent<Protocol.WebAudio.BaseAudioContext>):
+      void {
     const contextIndex = this.items.findIndex(
         (context: Protocol.WebAudio.BaseAudioContext): boolean => context.contextId === changedContext.contextId);
     if (contextIndex > -1) {