chrome-devtools-frontend 1.0.922782 → 1.0.923788

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -118,7 +118,7 @@ const elementToPositionMap = new WeakMap<Element, number>();
 
 const elementToIndexMap = new WeakMap<Element, number>();
 
-export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper {
+export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTypes<T>> {
   element: HTMLDivElement;
   private displayName: string;
   private editCallback: ((arg0: any, arg1: string, arg2: any, arg3: any) => any)|undefined;
@@ -224,7 +224,7 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper {
     this.topFillerRow = (this.dataTableBody.createChild('tr', 'data-grid-filler-row revealed') as HTMLElement);
     this.bottomFillerRow = (this.dataTableBody.createChild('tr', 'data-grid-filler-row revealed') as HTMLElement);
 
-    this.setVerticalPadding(0, 0);
+    this.setVerticalPadding(0, 0, true);
     this.refreshHeader();
 
     this.editing = false;
@@ -455,7 +455,7 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper {
     this.dataTableColumnGroup.createChild('col', 'corner');
   }
 
-  protected setVerticalPadding(top: number, bottom: number): void {
+  protected setVerticalPadding(top: number, bottom: number, isConstructorTime: boolean = false): void {
     const topPx = top + 'px';
     const bottomPx = (top || bottom) ? bottom + 'px' : 'auto';
     if (this.topFillerRow.style.height === topPx && this.bottomFillerRow.style.height === bottomPx) {
@@ -463,7 +463,9 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper {
     }
     this.topFillerRow.style.height = topPx;
     this.bottomFillerRow.style.height = bottomPx;
-    this.dispatchEventToListeners(Events.PaddingChanged);
+    if (!isConstructorTime) {
+      this.dispatchEventToListeners(Events.PaddingChanged);
+    }
   }
 
   protected setRootNode(rootNode: DataGridNode<T>): void {
@@ -1516,6 +1518,14 @@ export enum Events {
   PaddingChanged = 'PaddingChanged',
 }
 
+export type EventTypes<T> = {
+  [Events.SelectedNode]: DataGridNode<T>,
+  [Events.DeselectedNode]: void,
+  [Events.OpenedNode]: DataGridNode<T>,
+  [Events.SortingChanged]: void,
+  [Events.PaddingChanged]: void,
+};
+
 // TODO(crbug.com/1167717): Make this a const enum again
 // eslint-disable-next-line rulesdir/const_enum
 export enum Order {
@@ -1552,7 +1562,7 @@ export type DataGridData = {
   [key: string]: any,
 };
 
-export class DataGridNode<T> extends Common.ObjectWrapper.ObjectWrapper {
+export class DataGridNode<T> {
   elementInternal: Element|null;
   expandedInternal: boolean;
   private selectedInternal: boolean;
@@ -1582,7 +1592,6 @@ export class DataGridNode<T> extends Common.ObjectWrapper.ObjectWrapper {
   isCreationNode: boolean;
 
   constructor(data?: DataGridData|null, hasChildren?: boolean) {
-    super();
     this.elementInternal = null;
     this.expandedInternal = false;
     this.selectedInternal = false;

package/front_end/ui/legacy/components/data_grid/ViewportDataGrid.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Common from '../../../../core/common/common.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import * as Platform from '../../../../core/platform/platform.js';
 import * as UI from '../../legacy.js';
@@ -18,7 +19,8 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/data_grid/ViewportDataGrid.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class ViewportDataGrid<T> extends DataGridImpl<ViewportDataGridNode<T>> {
+export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTypes, typeof DataGridImpl>(
+    DataGridImpl)<ViewportDataGridNode<T>> {
   private readonly onScrollBound: (event: Event|null) => void;
   private visibleNodes: ViewportDataGridNode<T>[];
   stickToBottom: boolean;
@@ -263,6 +265,10 @@ export enum Events {
   ViewportCalculated = 'ViewportCalculated',
 }
 
+export type EventTypes = {
+  [Events.ViewportCalculated]: void,
+};
+
 export class ViewportDataGridNode<T> extends DataGridNode<ViewportDataGridNode<T>> {
   private stale: boolean;
   private flatNodes: ViewportDataGridNode<T>[]|null;

package/front_end/ui/legacy/components/perf_ui/OverviewGrid.ts

@@ -101,8 +101,8 @@ export class OverviewGrid {
     this.window.setWindow(left, right);
   }
 
-  addEventListener(
-      eventType: string|symbol, listener: (arg0: Common.EventTarget.EventTargetEvent) => void,
+  addEventListener<T extends keyof EventTypes>(
+      eventType: T, listener: Common.EventTarget.EventListener<EventTypes, T>,
       thisObject?: Object): Common.EventTarget.EventDescriptor {
     return this.window.addEventListener(eventType, listener, thisObject);
   }
@@ -125,7 +125,7 @@ export const WindowScrollSpeedFactor = .3;
 export const ResizerOffset = 3.5;  // half pixel because offset values are not rounded but ceiled
 export const OffsetFromWindowEnds = 10;
 
-export class Window extends Common.ObjectWrapper.ObjectWrapper {
+export class Window extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   private parentElement: Element;
   private calculator: Calculator|undefined;
   private leftResizeElement: HTMLElement;

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -828,7 +828,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 }
 
-export interface LinkDecorator extends Common.EventTarget.EventTarget {
+export interface LinkDecorator extends Common.EventTarget.EventTarget<LinkDecorator.EventTypes> {
   linkIcon(uiSourceCode: Workspace.UISourceCode.UISourceCode): UI.Icon.Icon|null;
 }
 
@@ -838,6 +838,10 @@ export namespace LinkDecorator {
   export enum Events {
     LinkIconChanged = 'LinkIconChanged',
   }
+
+  export type EventTypes = {
+    [Events.LinkIconChanged]: Workspace.UISourceCode.UISourceCode,
+  };
 }
 
 let linkContextMenuProviderInstance: LinkContextMenuProvider;

package/front_end/ui/legacy/reportView.css

@@ -85,6 +85,7 @@
   flex: auto;
   padding: 0 6px;
   white-space: pre;
+  user-select: text;
 }
 
 .report-field-value-is-flexed {

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.922782"
+  "version": "1.0.923788"
 }

package/scripts/build/rollup.config.js

@@ -84,11 +84,6 @@ export default commandLineArgs => ({
       compress: {
         pure_funcs: commandLineArgs.configDCHECK ? ['Platform.DCHECK'] : [],
       },
-      mangle: {
-        properties: {
-          regex: /^#\w+/,
-        },
-      },
     }),
     {
       name: 'devtools-plugin',