chrome-devtools-frontend 1.0.1738725 → 1.0.1742811
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +44 -7
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +1 -1
- package/.agents/skills/code-review/SKILL.md +23 -6
- package/.agents/skills/devtools-verification/SKILL.md +2 -1
- package/.agents/skills/migrate-chromium-test/SKILL.md +1 -0
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -11
- package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +41 -23
- package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +12 -7
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +3 -0
- package/.agents/skills/ui-widgets/SKILL.md +22 -7
- package/.agents/skills/version-control/SKILL.md +10 -1
- package/.agents/skills/visual-regression-audit/SKILL.md +88 -0
- package/.gitallowed +2 -1
- package/.stylelintignore +1 -0
- package/.stylelintrc.json +5 -1
- package/AUTHORS +1 -0
- package/DIR_METADATA +2 -1
- package/PRESUBMIT_test.py +143 -0
- package/config/owner/INFRA_OWNERS +0 -1
- package/docs/contributing/infrastructure.md +2 -2
- package/docs/ui_engineering.md +14 -4
- package/eslint.config.mjs +119 -9
- package/front_end/application_tokens.css +0 -65
- package/front_end/core/host/AidaClient.ts +1 -1
- package/front_end/core/host/AidaClientTypes.ts +2 -0
- package/front_end/core/host/AidaErrors.ts +3 -3
- package/front_end/core/host/AidaGcaTranslation.ts +39 -0
- package/front_end/core/host/GcaClient.ts +32 -20
- package/front_end/core/host/GcaTypes.ts +4 -2
- package/front_end/core/host/InspectorFrontendHostAPI.ts +2 -0
- package/front_end/core/i18n/DevToolsLocale.ts +0 -1
- package/front_end/core/sdk/DebuggerModel.ts +25 -13
- package/front_end/core/sdk/PreloadingModel.ts +2 -2
- package/front_end/core/sdk/RehydratingConnection.ts +59 -30
- package/front_end/core/sdk/SourceMap.ts +30 -3
- package/front_end/core/sdk/SourceMapRangeMappings.ts +57 -0
- package/front_end/core/sdk/StorageKeyManager.ts +0 -1
- package/front_end/core/sdk/Target.ts +6 -0
- package/front_end/core/sdk/TargetManager.ts +10 -4
- package/front_end/entrypoints/formatter_worker/JavaScriptFormatter.ts +5 -9
- package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +12 -2
- package/front_end/entrypoints/inspector_main/OutermostTargetSelector.ts +159 -52
- package/front_end/entrypoints/inspector_main/outermostTargetSelector.css +77 -25
- package/front_end/entrypoints/main/MainImpl.ts +32 -15
- package/front_end/models/ai_assistance/AiAgent2.ts +95 -46
- package/front_end/models/ai_assistance/AiConversation.ts +1 -1
- package/front_end/models/ai_assistance/agents/AiAgent.ts +9 -2
- package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +3 -2
- package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +1 -1
- package/front_end/models/ai_assistance/data_formatters/FileFormatter.ts +1 -1
- package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +5 -4
- package/front_end/models/ai_assistance/performance/AICallTree.ts +7 -9
- package/front_end/models/ai_assistance/performance/AIQueries.ts +4 -8
- package/front_end/models/ai_assistance/skills/SkillRegistry.ts +11 -1
- package/front_end/models/ai_assistance/skills/lighthouse.md +1 -0
- package/front_end/models/ai_assistance/skills/network.md +3 -4
- package/front_end/models/ai_assistance/skills/sources.md +1 -2
- package/front_end/models/ai_assistance/skills/styling.md +3 -4
- package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +11 -3
- package/front_end/models/ai_assistance/tools/ListNetworkRequests.ts +84 -23
- package/front_end/models/ai_assistance/tools/ListSources.ts +41 -13
- package/front_end/models/badges/Badge.ts +0 -1
- package/front_end/models/bindings/ResourceMapping.ts +1 -1
- package/front_end/models/bindings/ResourceScriptMapping.ts +1 -1
- package/front_end/models/breakpoints/BreakpointManager.ts +2 -4
- package/front_end/models/breakpoints/RecurringPauseDetector.ts +140 -0
- package/front_end/models/breakpoints/breakpoints.ts +2 -1
- package/front_end/models/heap_snapshot/HeapSnapshotModel.ts +2 -2
- package/front_end/models/persistence/Automapping.ts +0 -1
- package/front_end/models/trace/Processor.ts +16 -7
- package/front_end/models/trace/README.md +17 -1
- package/front_end/models/trace/extras/ThirdParties.ts +4 -6
- package/front_end/models/trace/extras/TraceFilter.ts +16 -8
- package/front_end/models/trace/extras/TraceTree.ts +159 -125
- package/front_end/models/trace/handlers/ExtensionTraceDataHandler.ts +0 -5
- package/front_end/models/trace/handlers/MetaHandler.ts +3 -0
- package/front_end/models/trace/handlers/RendererHandler.ts +7 -6
- package/front_end/models/trace/handlers/SamplesHandler.ts +1 -1
- package/front_end/models/trace/handlers/types.ts +15 -0
- package/front_end/models/trace/helpers/Extensions.ts +1 -3
- package/front_end/models/trace/helpers/SamplesIntegrator.ts +155 -87
- package/front_end/models/trace/helpers/Trace.ts +19 -14
- package/front_end/models/trace/helpers/TreeHelpers.ts +38 -10
- package/front_end/models/trace/insights/SlowCSSSelector.ts +3 -3
- package/front_end/models/trace/lantern/metrics/LargestContentfulPaint.ts +19 -4
- package/front_end/models/trace/lantern/simulation/Simulator.ts +4 -1
- package/front_end/models/web_mcp/WebMCPModel.ts +19 -9
- package/front_end/panels/ai_assistance/AiAssistancePanel.ts +30 -3
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +2 -4
- package/front_end/panels/ai_assistance/components/chatMessage.css +1 -22
- package/front_end/panels/ai_assistance/components/chatView.css +0 -180
- package/front_end/panels/ai_assistance/components/exploreWidget.css +1 -19
- package/front_end/panels/ai_assistance/components/optInChangeDialog.css +1 -1
- package/front_end/panels/ai_assistance/components/walkthroughView.css +0 -13
- package/front_end/panels/animation/AnimationGroupPreviewUI.ts +3 -2
- package/front_end/panels/animation/AnimationTimeline.ts +5 -3
- package/front_end/panels/animation/animationTimeline.css +10 -8
- package/front_end/panels/application/ApplicationPanelSidebar.ts +14 -11
- package/front_end/panels/application/ApplicationPanelTreeElement.ts +66 -3
- package/front_end/panels/application/ReportingApiView.ts +0 -1
- package/front_end/panels/application/SubAppsView.ts +0 -1
- package/front_end/panels/application/WebMCPTreeElement.ts +3 -6
- package/front_end/panels/application/WebMCPView.ts +30 -0
- package/front_end/panels/application/components/ReportsGrid.ts +0 -1
- package/front_end/panels/application/components/backForwardCacheView.css +1 -8
- package/front_end/panels/application/components/permissionsPolicySection.css +2 -2
- package/front_end/panels/application/components/protocolHandlersView.css +46 -39
- package/front_end/panels/application/components/trustTokensView.css +0 -4
- package/front_end/panels/application/cookieItemsView.css +0 -7
- package/front_end/panels/application/indexedDBViews.css +0 -6
- package/front_end/panels/application/preloading/components/PreloadingDetailsReportView.ts +0 -2
- package/front_end/panels/application/preloading/components/PreloadingString.ts +0 -1
- package/front_end/panels/application/preloading/components/UsedPreloadingView.ts +4 -5
- package/front_end/panels/application/preloading/components/preloadingGrid.css +0 -9
- package/front_end/panels/application/resourcesPanel.css +0 -48
- package/front_end/panels/application/serviceWorkerUpdateCycleView.css +2 -9
- package/front_end/panels/application/serviceWorkersView.css +5 -4
- package/front_end/panels/application/storageView.css +0 -5
- package/front_end/panels/application/webMCPView.css +17 -0
- package/front_end/panels/browser_debugger/ObjectEventListenersSidebarPane.ts +15 -20
- package/front_end/panels/changes/changesView.css +0 -5
- package/front_end/panels/common/ExtensionServer.ts +80 -10
- package/front_end/panels/console/ConsolePanel.ts +92 -18
- package/front_end/panels/console/consoleContextSelector.css +1 -8
- package/front_end/panels/console/consoleInsightTeaser.css +10 -17
- package/front_end/panels/console/consolePinPane.css +3 -1
- package/front_end/panels/console/consoleView.css +14 -18
- package/front_end/panels/coverage/coverageListView.css +0 -4
- package/front_end/panels/css_overview/cssOverviewCompletedView.css +0 -22
- package/front_end/panels/css_overview/cssOverviewStartView.css +0 -43
- package/front_end/panels/developer_resources/developerResourcesListView.css +0 -4
- package/front_end/panels/elements/ColorSwatchPopoverIcon.ts +52 -45
- package/front_end/panels/elements/LayoutPane.ts +1 -3
- package/front_end/panels/elements/PropertiesWidget.ts +26 -8
- package/front_end/panels/elements/PropertyRenderer.ts +45 -21
- package/front_end/panels/elements/StandaloneStylesContainer.ts +6 -7
- package/front_end/panels/elements/StyleEditorWidget.ts +110 -63
- package/front_end/panels/elements/StylePropertiesSection.ts +18 -14
- package/front_end/panels/elements/StylePropertyTreeElement.ts +556 -527
- package/front_end/panels/elements/StylesContainer.ts +5 -6
- package/front_end/panels/elements/StylesSidebarPane.ts +12 -15
- package/front_end/panels/elements/classesPaneWidget.css +3 -7
- package/front_end/panels/elements/components/CSSQuery.ts +6 -5
- package/front_end/panels/elements/components/CSSVariableValueView.ts +17 -4
- package/front_end/panels/elements/components/StylePropertyEditor.ts +178 -140
- package/front_end/panels/elements/components/cssQuery.css +1 -1
- package/front_end/panels/elements/components/stylePropertyEditor.css +60 -56
- package/front_end/panels/elements/layoutPane.css +2 -2
- package/front_end/panels/elements/metricsSidebarPane.css +7 -8
- package/front_end/panels/elements/platformFontsWidget.css +1 -1
- package/front_end/panels/elements/stylePropertiesTreeOutline.css +1 -12
- package/front_end/panels/elements/stylesSidebarPane.css +3 -5
- package/front_end/panels/emulation/deviceModeView.css +1 -1
- package/front_end/panels/event_listeners/EventListenersView.ts +9 -2
- package/front_end/panels/event_listeners/eventListenersView.css +1 -1
- package/front_end/panels/explain/components/consoleInsight.css +1 -7
- package/front_end/panels/issues/AffectedBlockedByResponseView.ts +88 -46
- package/front_end/panels/issues/AffectedHeavyAdView.ts +72 -43
- package/front_end/panels/issues/AffectedResourcesView.ts +81 -13
- package/front_end/panels/issues/GenericIssueDetailsView.ts +112 -32
- package/front_end/panels/issues/issues.ts +2 -0
- package/front_end/panels/issues/issuesTree.css +13 -43
- package/front_end/panels/layer_viewer/PaintProfilerView.ts +1 -1
- package/front_end/panels/layer_viewer/layerDetailsView.css +1 -1
- package/front_end/panels/layer_viewer/paintProfiler.css +4 -3
- package/front_end/panels/lighthouse/LighthouseReportSelector.ts +1 -6
- package/front_end/panels/lighthouse/lighthousePanel.css +0 -9
- package/front_end/panels/lighthouse/lighthouseStartView.css +5 -16
- package/front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts +0 -1
- package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
- package/front_end/panels/linear_memory_inspector/components/linearMemoryValueInterpreter.css +2 -2
- package/front_end/panels/linear_memory_inspector/components/linearMemoryViewer.css +2 -2
- package/front_end/panels/linear_memory_inspector/components/valueInterpreterSettings.css +1 -1
- package/front_end/panels/media/playerListView.css +1 -2
- package/front_end/panels/media/playerPropertiesView.css +1 -1
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +4 -4
- package/front_end/panels/network/NetworkLogView.ts +603 -582
- package/front_end/panels/network/RequestCookiesView.ts +0 -1
- package/front_end/panels/network/RequestTimingView.ts +16 -2
- package/front_end/panels/network/networkConfigView.css +3 -4
- package/front_end/panels/network/networkLogView.css +363 -377
- package/front_end/panels/network/networkPanel.css +1 -7
- package/front_end/panels/network/networkTimingTable.css +12 -27
- package/front_end/panels/network/networkWaterfallColumn.css +1 -1
- package/front_end/panels/network/requestConditionsDrawer.css +0 -4
- package/front_end/panels/network/requestCookiesView.css +7 -1
- package/front_end/panels/network/requestPayloadTree.css +0 -4
- package/front_end/panels/profiler/HeapProfileView.ts +1 -3
- package/front_end/panels/profiler/HeapSnapshotView.ts +0 -7
- package/front_end/panels/profiler/profilesPanel.css +0 -11
- package/front_end/panels/recorder/ControlButton.ts +1 -1
- package/front_end/panels/recorder/RecorderPanel.ts +1 -1
- package/front_end/panels/recorder/RecordingView.ts +32 -11
- package/front_end/panels/recorder/StepView.ts +31 -5
- package/front_end/panels/recorder/TimelineSection.ts +22 -6
- package/front_end/panels/recorder/controlButton.css +2 -9
- package/front_end/panels/recorder/createRecordingView.css +1 -1
- package/front_end/panels/recorder/recorderPanel.css +0 -9
- package/front_end/panels/recorder/recordingListView.css +4 -4
- package/front_end/panels/recorder/recordingView.css +44 -52
- package/front_end/panels/recorder/replaySection.css +2 -0
- package/front_end/panels/recorder/stepEditor.css +4 -4
- package/front_end/panels/recorder/stepView.css +47 -21
- package/front_end/panels/recorder/timelineSection.css +63 -83
- package/front_end/panels/screencast/ScreencastApp.ts +0 -1
- package/front_end/panels/search/searchView.css +1 -1
- package/front_end/panels/security/mainView.css +1 -1
- package/front_end/panels/security/originView.css +2 -2
- package/front_end/panels/sensors/SensorsView.ts +273 -361
- package/front_end/panels/settings/BackendLinkingSettingsTab.ts +0 -1
- package/front_end/panels/settings/backendLinkingSettingsTab.css +7 -7
- package/front_end/panels/settings/components/syncSection.css +0 -1
- package/front_end/panels/settings/workspaceSettingsTab.css +0 -5
- package/front_end/panels/sources/CSSPlugin.ts +177 -98
- package/front_end/panels/sources/DebuggerPausedMessage.ts +100 -27
- package/front_end/panels/sources/NavigatorView.ts +926 -946
- package/front_end/panels/sources/SourcesPanel.ts +9 -2
- package/front_end/panels/sources/breakpointsView.css +6 -28
- package/front_end/panels/sources/components/HeadersView.css +2 -2
- package/front_end/panels/sources/debuggerPausedMessage.css +7 -0
- package/front_end/panels/sources/navigatorTree.css +7 -2
- package/front_end/panels/sources/sourcesNavigator.css +0 -9
- package/front_end/panels/sources/sourcesView.css +2 -1
- package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -10
- package/front_end/panels/timeline/CompatibilityTracksAppender.ts +3 -0
- package/front_end/panels/timeline/EventsTimelineTreeView.ts +18 -5
- package/front_end/panels/timeline/LayoutShiftsTrackAppender.ts +0 -10
- package/front_end/panels/timeline/ModificationsManager.ts +0 -1
- package/front_end/panels/timeline/ThreadAppender.ts +2 -6
- package/front_end/panels/timeline/TimelineController.ts +30 -26
- package/front_end/panels/timeline/TimelineDetailsView.ts +10 -9
- package/front_end/panels/timeline/TimelineFlameChartDataProvider.ts +4 -16
- package/front_end/panels/timeline/TimelineMiniMap.ts +132 -54
- package/front_end/panels/timeline/TimelinePanel.ts +2 -2
- package/front_end/panels/timeline/TimelineTreeView.ts +63 -50
- package/front_end/panels/timeline/TimelineUIUtils.ts +8 -10
- package/front_end/panels/timeline/components/DetailsView.ts +7 -14
- package/front_end/panels/timeline/components/LayoutShiftDetails.ts +0 -2
- package/front_end/panels/timeline/components/NetworkTrackWidget.ts +5 -1
- package/front_end/panels/timeline/components/fieldSettingsDialog.css +1 -6
- package/front_end/panels/timeline/components/insights/baseInsightComponent.css +0 -12
- package/front_end/panels/timeline/components/interactionBreakdown.css +1 -1
- package/front_end/panels/timeline/components/layoutShiftDetails.css +2 -9
- package/front_end/panels/timeline/components/liveMetricsView.css +0 -16
- package/front_end/panels/timeline/components/metricCard.css +1 -5
- package/front_end/panels/timeline/components/networkRequestDetails.css +3 -3
- package/front_end/panels/timeline/components/networkRequestTooltip.css +6 -4
- package/front_end/panels/timeline/components/networkTrackWidget.css +1 -1
- package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +1 -1
- package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
- package/front_end/panels/timeline/docs/profile_calls.md +7 -9
- package/front_end/panels/timeline/timelineDetailsView.css +1 -12
- package/front_end/panels/timeline/timelineFlamechartPopover.css +0 -4
- package/front_end/panels/timeline/timelineMiniMap.css +1 -4
- package/front_end/panels/timeline/timelinePanel.css +0 -4
- package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
- package/front_end/panels/timeline/timelineTreeView.css +0 -12
- package/front_end/panels/timeline/utils/EntryNodes.ts +1 -1
- package/front_end/panels/webauthn/webauthnPane.css +2 -8
- package/front_end/panels/whats_new/ReleaseNoteText.ts +1 -1
- package/front_end/third_party/axe-core/README.chromium +2 -3
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/puppeteer/README.chromium +2 -2
- package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.d.ts +328 -11
- package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.js +907 -588
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.d.ts +119 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/BrowserContext.d.ts +120 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/BrowserContext.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/BrowserContext.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.d.ts +16 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.js +5 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPResponse.d.ts +26 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPResponse.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPResponse.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.d.ts +23 -3
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.js +21 -14
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.d.ts +5 -5
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.js +4 -4
- package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Browser.d.ts +6 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Browser.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Browser.js +158 -67
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Browser.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/BrowserConnector.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/BrowserConnector.js +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/BrowserConnector.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Connection.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Connection.js +3 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Connection.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Frame.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Frame.js +28 -5
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Frame.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.d.ts +4 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.js +19 -11
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPResponse.d.ts +2 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPResponse.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPResponse.js +17 -5
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPResponse.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Input.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Input.js +62 -4
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Input.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/NetworkEvents.d.ts +29 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/NetworkEvents.d.ts.map +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/NetworkEvents.js +60 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/NetworkEvents.js.map +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.d.ts +9 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.js +24 -9
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Realm.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Realm.js +16 -7
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Realm.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Browser.d.ts +6 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Browser.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Browser.js +37 -20
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Browser.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/BrowsingContext.d.ts +2 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/BrowsingContext.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/BrowsingContext.js +10 -5
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/BrowsingContext.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Navigation.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Navigation.js +18 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Navigation.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.js +24 -5
- package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Binding.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Binding.js +6 -4
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Binding.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ExtensionTransport.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ExtensionTransport.js +30 -6
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ExtensionTransport.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/FrameManager.d.ts +2 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/FrameManager.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/FrameManager.js +3 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/FrameManager.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.d.ts +5 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.js +12 -2
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPResponse.d.ts +3 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPResponse.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPResponse.js +40 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPResponse.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.d.ts +23 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.js +37 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.d.ts +2 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.js +74 -16
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.d.ts +3 -2
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.js +34 -23
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ResponseBodyStream.d.ts +10 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ResponseBodyStream.d.ts.map +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ResponseBodyStream.js +94 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ResponseBodyStream.js.map +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.d.ts +2 -2
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.js +29 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/cdp.d.ts +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/cdp.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/cdp.js +1 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/cdp.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/utils.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/utils.js +6 -5
- package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/utils.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/ConsoleMessage.d.ts +4 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/ConsoleMessage.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/ConsoleMessage.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/EventEmitter.d.ts +4 -4
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/EventEmitter.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/EventEmitter.js +2 -2
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/EventEmitter.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.js +34 -15
- package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.d.ts +3 -0
- package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.d.ts.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.js +11 -7
- package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/node/ChromeLauncher.js +10 -7
- package/front_end/third_party/puppeteer/package/lib/puppeteer/node/ChromeLauncher.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.d.ts +3 -3
- package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.js +3 -3
- package/front_end/third_party/puppeteer/package/lib/puppeteer/util/decorators.js.map +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/util/version.d.ts +1 -1
- package/front_end/third_party/puppeteer/package/lib/puppeteer/util/version.js +1 -1
- package/front_end/third_party/puppeteer/package/lib/types.d.ts +328 -11
- package/front_end/third_party/puppeteer/package/package.json +10 -8
- package/front_end/third_party/puppeteer/package/src/api/Browser.ts +118 -0
- package/front_end/third_party/puppeteer/package/src/api/BrowserContext.ts +119 -0
- package/front_end/third_party/puppeteer/package/src/api/HTTPRequest.ts +25 -2
- package/front_end/third_party/puppeteer/package/src/api/HTTPResponse.ts +28 -0
- package/front_end/third_party/puppeteer/package/src/api/Page.ts +65 -38
- package/front_end/third_party/puppeteer/package/src/api/locators/locators.ts +27 -7
- package/front_end/third_party/puppeteer/package/src/bidi/Browser.ts +43 -7
- package/front_end/third_party/puppeteer/package/src/bidi/BrowserConnector.ts +1 -0
- package/front_end/third_party/puppeteer/package/src/bidi/Connection.ts +5 -1
- package/front_end/third_party/puppeteer/package/src/bidi/Frame.ts +38 -8
- package/front_end/third_party/puppeteer/package/src/bidi/HTTPRequest.ts +27 -12
- package/front_end/third_party/puppeteer/package/src/bidi/HTTPResponse.ts +19 -6
- package/front_end/third_party/puppeteer/package/src/bidi/Input.ts +72 -5
- package/front_end/third_party/puppeteer/package/src/bidi/NetworkEvents.ts +82 -0
- package/front_end/third_party/puppeteer/package/src/bidi/Page.ts +37 -13
- package/front_end/third_party/puppeteer/package/src/bidi/Realm.ts +26 -14
- package/front_end/third_party/puppeteer/package/src/bidi/core/Browser.ts +43 -22
- package/front_end/third_party/puppeteer/package/src/bidi/core/BrowsingContext.ts +13 -5
- package/front_end/third_party/puppeteer/package/src/bidi/core/Navigation.ts +21 -1
- package/front_end/third_party/puppeteer/package/src/bidi/core/Request.ts +27 -5
- package/front_end/third_party/puppeteer/package/src/cdp/Binding.ts +6 -4
- package/front_end/third_party/puppeteer/package/src/cdp/ExtensionTransport.ts +31 -6
- package/front_end/third_party/puppeteer/package/src/cdp/FrameManager.ts +5 -0
- package/front_end/third_party/puppeteer/package/src/cdp/HTTPRequest.ts +18 -1
- package/front_end/third_party/puppeteer/package/src/cdp/HTTPResponse.ts +48 -0
- package/front_end/third_party/puppeteer/package/src/cdp/NetworkEventManager.ts +58 -5
- package/front_end/third_party/puppeteer/package/src/cdp/NetworkManager.ts +94 -14
- package/front_end/third_party/puppeteer/package/src/cdp/Page.ts +50 -28
- package/front_end/third_party/puppeteer/package/src/cdp/ResponseBodyStream.ts +106 -0
- package/front_end/third_party/puppeteer/package/src/cdp/Target.ts +38 -3
- package/front_end/third_party/puppeteer/package/src/cdp/cdp.ts +1 -0
- package/front_end/third_party/puppeteer/package/src/cdp/utils.ts +6 -5
- package/front_end/third_party/puppeteer/package/src/common/ConsoleMessage.ts +5 -0
- package/front_end/third_party/puppeteer/package/src/common/EventEmitter.ts +17 -8
- package/front_end/third_party/puppeteer/package/src/common/util.ts +32 -15
- package/front_end/third_party/puppeteer/package/src/node/BrowserLauncher.ts +21 -13
- package/front_end/third_party/puppeteer/package/src/node/ChromeLauncher.ts +10 -10
- package/front_end/third_party/puppeteer/package/src/revisions.ts +3 -3
- package/front_end/third_party/puppeteer/package/src/util/decorators.ts +1 -1
- package/front_end/third_party/puppeteer/package/src/util/version.ts +1 -1
- package/front_end/third_party/puppeteer/puppeteer-tsconfig.json +2 -0
- package/front_end/ui/components/adorners/adorner.css +1 -1
- package/front_end/ui/components/buttons/button.css +0 -28
- package/front_end/ui/components/buttons/textButton.css +1 -45
- package/front_end/ui/components/diff_view/diffView.css +0 -2
- package/front_end/ui/components/input/checkbox.css +3 -3
- package/front_end/ui/components/issue_counter/issueLinkIcon.css +2 -2
- package/front_end/ui/components/menus/Menu.ts +14 -0
- package/front_end/ui/components/menus/menu.css +2 -14
- package/front_end/ui/components/menus/menuItem.css +0 -4
- package/front_end/ui/components/request_link_icon/requestLinkIcon.css +2 -2
- package/front_end/ui/components/survey_link/SurveyLink.ts +1 -1
- package/front_end/ui/components/survey_link/surveyLink.css +3 -3
- package/front_end/ui/components/switch/switch.css +3 -2
- package/front_end/ui/components/text_editor/theme.ts +1 -1
- package/front_end/ui/components/tooltips/Tooltip.ts +29 -0
- package/front_end/ui/components/tree_outline/treeOutline.css +1 -24
- package/front_end/ui/legacy/ContextMenu.ts +5 -5
- package/front_end/ui/legacy/SoftContextMenu.ts +24 -8
- package/front_end/ui/legacy/Toolbar.ts +1 -1
- package/front_end/ui/legacy/Treeoutline.ts +31 -78
- package/front_end/ui/legacy/UIUtils.ts +9 -17
- package/front_end/ui/legacy/checkboxTextLabel.css +2 -44
- package/front_end/ui/legacy/components/color_picker/Spectrum.ts +39 -27
- package/front_end/ui/legacy/components/color_picker/spectrum.css +2 -10
- package/front_end/ui/legacy/components/data_grid/dataGrid.css +2 -6
- package/front_end/ui/legacy/components/inline_editor/BezierEditor.ts +34 -26
- package/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts +1 -0
- package/front_end/ui/legacy/components/inline_editor/cssShadowEditor.css +1 -1
- package/front_end/ui/legacy/components/inline_editor/swatchPopover.css +1 -1
- package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +83 -21
- package/front_end/ui/legacy/components/object_ui/objectPopover.css +0 -4
- package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +41 -14
- package/front_end/ui/legacy/components/perf_ui/chartViewport.css +1 -9
- package/front_end/ui/legacy/components/perf_ui/filmStripView.css +1 -1
- package/front_end/ui/legacy/components/perf_ui/overviewGrid.css +2 -1
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +0 -5
- package/front_end/ui/legacy/components/settings_ui/SettingsUI.ts +6 -3
- package/front_end/ui/legacy/components/source_frame/JSONView.ts +95 -1
- package/front_end/ui/legacy/components/source_frame/imageView.css +2 -2
- package/front_end/ui/legacy/filter.css +7 -3
- package/front_end/ui/legacy/inspectorCommon.css +7 -81
- package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +1 -1
- package/front_end/ui/legacy/listWidget.css +2 -2
- package/front_end/ui/legacy/progressIndicator.css +1 -1
- package/front_end/ui/legacy/tabbedPane.css +6 -10
- package/front_end/ui/visual_logging/KnownContextValues.ts +2 -0
- package/front_end/ui/visual_logging/LoggingDriver.ts +4 -0
- package/front_end/ui/visual_logging/visual_logging.ts +1 -1
- package/inspector_overlay/common.ts +0 -3
- package/inspector_overlay/main.ts +1 -3
- package/inspector_overlay/tool_highlight.css +0 -7
- package/inspector_overlay/tool_highlight.ts +0 -1
- package/inspector_overlay/tool_source_order.css +0 -4
- package/package.json +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +0 -9689
|
@@ -22,9 +22,15 @@ git new-branch <branch-name>
|
|
|
22
22
|
*Note: This automatically sets the upstream to `origin/main`.*
|
|
23
23
|
|
|
24
24
|
### Making Changes
|
|
25
|
-
1. Make your changes.
|
|
25
|
+
1. Make your changes (keeping each CL `<= 350` lines of `insertions + deletions`, with 100% of new code called in production and tested in the same CL).
|
|
26
26
|
2. Stage them: `git add <files>`.
|
|
27
27
|
3. Create the commit: `git commit -m "Your message"`.
|
|
28
|
+
* Follow public commit message conventions: a concise summary line (`<= 72` characters) describing *what the CL changes functionally* (never migration pass/step labels such as `Pass 1:` or `(2/6)` in the subject line), a blank line, an explanatory body wrapping at 72 characters, and Git trailers (`Bug:`, `Fixed:`) in the footer. When splitting a migration into a stack, preserve the target Buganizer ID across every CL (`Bug: <id>` on intermediate CLs, `Fixed: <id>` only on the final complete CL).
|
|
29
|
+
* **Never add Piper `KEY=VALUE` tags** (such as `TAG=agy`, `CONV=...`, `BUG=...`, `FIXED=...`, or `MARKDOWN=true`). Commit messages must use Git trailers only; `PRESUBMIT.py` rejects Piper tags because they break Git trailer parsing and can cause duplicate `Change-Id:` footers.
|
|
30
|
+
* To associate agent conversations out of band without polluting commit descriptions with `CONV=`, configure:
|
|
31
|
+
```bash
|
|
32
|
+
git config --global cl.upload-conversation-id true
|
|
33
|
+
```
|
|
28
34
|
|
|
29
35
|
### Updating a CL (Amending)
|
|
30
36
|
To update your CL after feedback or more work:
|
|
@@ -79,6 +85,7 @@ Or, if the WIP patchset is already uploaded, vote `Commit-Queue+1` via `/google/
|
|
|
79
85
|
* Use the same writing style as the current committer.
|
|
80
86
|
* Keep line length below 72.
|
|
81
87
|
* Add a `Bug: <issue number>` (or `Fixed: <issue number>` / `Bug: None`) trailer on a separate line.
|
|
88
|
+
* Use Git trailers only; never add Piper `KEY=VALUE` tags (`TAG=`, `CONV=`, etc.), which are rejected by `PRESUBMIT.py`. Ensure `cl.upload-conversation-id` is enabled (`git config --global cl.upload-conversation-id true`) to link conversation metadata out of band.
|
|
82
89
|
* Amend formatter/linter changes and fix linter issues before uploading.
|
|
83
90
|
* For a brand new stack of CLs, perform the initial WIP upload on each branch individually in parent-to-child order so each CL receives its own commit description.
|
|
84
91
|
|
|
@@ -128,6 +135,7 @@ To upload an updated CL:
|
|
|
128
135
|
git cl upload -f --cq-dry-run -t "<one sentence patch set description>"
|
|
129
136
|
```
|
|
130
137
|
* **Updating an existing stack of CLs:** Once all CLs in a stack have been initially created, **only run `git cl upload` from the leaf (latest) branch in the chain** for subsequent updates. Uploading from the leaf branch automatically runs presubmit checks and uploads new patchsets for all parent CLs in the stack simultaneously. Never upload intermediate CLs one by one when updating a stack.
|
|
138
|
+
* **Cog (`citc`) Workspaces & Continuous Stack CQ/CRUAS Checks:** In Cog workspaces (`/google/cog/cloud/...`), use `cog_api.py` / `vcs.sh` instead of raw `git new-branch`, and **always finish on a clean, empty working copy `@`** (`The working copy has no changes`) by squashing or abandoning temporary `@` commits immediately. After publishing a stack from its leaf commit, trigger `Commit-Queue+1` (`"notify": "NONE"`, never `Commit-Queue+2`) and check `ChromiumCodeReviewAgent` (`gerrit findings --all` and inline comments) across **every** CL in the stack throughout development rather than waiting until human review.
|
|
131
139
|
|
|
132
140
|
## Release and Roll Status
|
|
133
141
|
|
|
@@ -154,6 +162,7 @@ To check whether a DevTools commit (`devtools/devtools-frontend`) has rolled int
|
|
|
154
162
|
| Check release & roll status | Query `https://chromiumdash.appspot.com/fetch_commit?commit=<sha>` |
|
|
155
163
|
|
|
156
164
|
## Common Mistakes
|
|
165
|
+
- **Adding Piper `KEY=VALUE` tags to commit messages:** Never add `TAG=agy`, `CONV=...`, `BUG=...`, `FIXED=...`, or other Piper metadata tags to commit descriptions. DevTools is a public Git repository; internal Piper tags break Git trailer parsing and Gerrit `Change-Id` handling, and are rejected by `PRESUBMIT.py`. Use Git trailers (`Bug:`, `Fixed:`) instead, and enable `git config --global cl.upload-conversation-id true` so `git cl upload` attaches conversation IDs out of band.
|
|
157
166
|
- **Starting human review before resolving `ChromiumCodeReviewAgent` findings:** Never pass `--send-mail` (`-s`) or `-c` (`--use-commit-queue`) on the initial upload, or add human reviewers to the attention set before AI review finishes. Upload in WIP with `--cq-dry-run`, wait for `ChromiumCodeReviewAgent` to complete, and address all `ERROR` and `WARNING` findings first.
|
|
158
167
|
- **Multiple commits on one branch:** Gerrit expects one commit per CL. Always `commit --amend`.
|
|
159
168
|
- **Using `git checkout -b`:** Does not set up tracking information correctly for `depot_tools`. Use `git new-branch`.
|
|
@@ -0,0 +1,88 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: visual-regression-audit
|
|
3
|
+
description: >-
|
|
4
|
+
Audits UI Engineering Vision migrations, CSS @scope conversions, widget
|
|
5
|
+
refactorings, and UI layout or styling changes for visual, layout, and
|
|
6
|
+
interaction regressions before merge. Use when reviewing changes touching
|
|
7
|
+
front_end/(panels|ui)/**/*.{ts,css} or whenever a CL changes UI layout or
|
|
8
|
+
rendered appearance.
|
|
9
|
+
---
|
|
10
|
+
|
|
11
|
+
# Visual & Interaction Regression Audit
|
|
12
|
+
|
|
13
|
+
Apply this checklist whenever a CL migrates imperative DOM to `UI.Widget` +
|
|
14
|
+
`lit-html`, wraps Light DOM styles in `@scope`, swaps `TreeOutline`,
|
|
15
|
+
`DataGrid`, `ListControl`, or `ListWidget` to declarative components, or
|
|
16
|
+
whenever a CL changes UI layout, styling, or rendered appearance.
|
|
17
|
+
|
|
18
|
+
## 1. Screenshot Golden Gate (`assertScreenshot`)
|
|
19
|
+
|
|
20
|
+
- **Require visual baselines on layout-affecting diffs:** Flag any CL that
|
|
21
|
+
wraps a `.css` file in `@scope to (devtools-widget > *)`, promotes a class to
|
|
22
|
+
`UI.Widget`, swaps a legacy tree/grid/list widget, or otherwise changes UI
|
|
23
|
+
layout or styling without either existing or newly added
|
|
24
|
+
`assertScreenshot(...)` tests covering its non-empty rendered state (and dark
|
|
25
|
+
mode or overflow state when styling colors/scrollbars). Check sibling
|
|
26
|
+
`*.test.ts` files before flagging standalone CSS CLs whose existing
|
|
27
|
+
`assertScreenshot(...)` tests are not modified in the diff.
|
|
28
|
+
- **Do not flag** pure Pass 0.5 `#private`/dead-code prefactors, presenter-only
|
|
29
|
+
logic moves that leave DOM structure and CSS untouched, or removals of
|
|
30
|
+
provably unreferenced CSS selectors or files (which touch CSS without
|
|
31
|
+
changing rendered appearance).
|
|
32
|
+
|
|
33
|
+
## 2. Flex, Sizing, and Overflow Clipping (`<devtools-widget>` & Popovers)
|
|
34
|
+
|
|
35
|
+
- **Host vs. `contentElement` classes:** When removing `super(..., {classes})`
|
|
36
|
+
or imperative `this.element.classList.add(...)`, verify every layout class
|
|
37
|
+
(`vbox`, `hbox`, `flex-auto`, `overflow-auto`, custom root classes) moved to
|
|
38
|
+
`render(..., target, {container: {classes: [...]}})` (or `:scope` in CSS).
|
|
39
|
+
Dropping `vbox` or `min-height: 0` on a flex child collapses height to `0` or
|
|
40
|
+
clips scrollbars (e.g. popover and sidebar panes). Also check two manual
|
|
41
|
+
`@devtools/no-widget-constructor-classes` traps:
|
|
42
|
+
- **`useShadowDom: true` vs. `'pure'`:** Under `useShadowDom: true` (unlike
|
|
43
|
+
Light DOM or `useShadowDom: 'pure'`), `this.contentElement` is an inner
|
|
44
|
+
`<div>` inside the shadow root while `Widget` adds `vbox flex-auto` to
|
|
45
|
+
`this.element`. Moving host classes (such as `flex-none`) to
|
|
46
|
+
`render(..., target, {container: {classes}})` without switching to
|
|
47
|
+
`useShadowDom: 'pure'` applies them to the inner `<div>` instead of the
|
|
48
|
+
host element.
|
|
49
|
+
- **Multi-branch `render(..., target)` views:** Every `render(..., target)`
|
|
50
|
+
branch in a view function must pass `{container: {classes: [...]}}`, or
|
|
51
|
+
`render()` will strip those classes when switching branches/states.
|
|
52
|
+
- **`WrapperWidget` uses `display: contents`:** Flag any width, height, flex,
|
|
53
|
+
overflow, border, or background styling placed on a `<devtools-widget>` host
|
|
54
|
+
that mounts `UI.Widget.WrapperWidget`. Wrap it in a sized `<div>` instead.
|
|
55
|
+
- **`<devtools-tree>` overflow:** Check `?hide-overflow` vs. scrollable parent
|
|
56
|
+
containers so horizontal/vertical scrollbars are neither double-rendered nor
|
|
57
|
+
clipped at container edges.
|
|
58
|
+
|
|
59
|
+
## 3. `<devtools-tree>` Parity Traps (Top Source of M152/M156 Regressions)
|
|
60
|
+
|
|
61
|
+
- **Event name is `@expand`, never `@expanded`:** `TreeViewElement` dispatches
|
|
62
|
+
`new ExpandEvent(...)` with type `'expand'` (`e.detail.expanded`,
|
|
63
|
+
`e.detail.recursively`). Flag any `@expanded=${...}` listener on
|
|
64
|
+
`<li role="treeitem">` as a dead handler that silently drops expansion state.
|
|
65
|
+
- **Lazy child population & `ifExpanded`:** When migrating recursive trees
|
|
66
|
+
(`DOMTreeWidget`, `ObjectTree`, `NavigatorView`), verify expanding a parent
|
|
67
|
+
populates child data *and* triggers `requestUpdate()`, and verify initial
|
|
68
|
+
root/default-open nodes render their children on first paint.
|
|
69
|
+
- **Context menus (`@contextmenu`):** Verify every legacy
|
|
70
|
+
`appendApplicableItems` / `treeElement.oncontextmenu` path (such as *Reveal
|
|
71
|
+
in Elements*, *Copy value*, *Expand recursively*) is wired on the migrated
|
|
72
|
+
`<li role="treeitem">` or root container, and check `event.target` assumptions
|
|
73
|
+
across `<devtools-tree>`'s shadow clone boundary.
|
|
74
|
+
- **Keyboard `@select` vs. mouse `@click`:** Ensure arrow-key navigation
|
|
75
|
+
triggers the same preview/highlight side effects (e.g. DOM node overlay
|
|
76
|
+
highlight) as clicking the row, respecting `e.detail.selectedByUser`.
|
|
77
|
+
- **Inline text selection & editing:** Check that `user-select` rules inside
|
|
78
|
+
tree rows still allow partial token selection where expected, and keep
|
|
79
|
+
editable `<devtools-prompt ?editing>` inside a child `${widget(...)}` so
|
|
80
|
+
attribute mutations do not re-clone the row and blur focus.
|
|
81
|
+
|
|
82
|
+
## 4. `@scope` Visual Parity Checks
|
|
83
|
+
|
|
84
|
+
- Verify `@scope` wrapping is landed in a standalone CSS CL rather than mixed
|
|
85
|
+
with template or widget-promotion changes.
|
|
86
|
+
- Check removed selectors for layout side effects on legacy imperative child
|
|
87
|
+
widgets (`childWidget.show(container)` renders `<div class="widget">`, which
|
|
88
|
+
is *not* stopped by the `(devtools-widget > *)` lower boundary).
|
package/.gitallowed
CHANGED
package/.stylelintignore
CHANGED
package/.stylelintrc.json
CHANGED
|
@@ -3,18 +3,22 @@
|
|
|
3
3
|
"plugins": [
|
|
4
4
|
"./scripts/stylelint_rules/lib/use_theme_colors.mjs",
|
|
5
5
|
"./scripts/stylelint_rules/lib/check_highlight_scope.mjs",
|
|
6
|
-
"./scripts/stylelint_rules/lib/use_monospace_font.mjs"
|
|
6
|
+
"./scripts/stylelint_rules/lib/use_monospace_font.mjs",
|
|
7
|
+
"./scripts/stylelint_rules/lib/check_scope_selectors.mjs"
|
|
7
8
|
],
|
|
8
9
|
"rules": {
|
|
9
10
|
"plugin/use_theme_colors": true,
|
|
10
11
|
"plugin/check_highlight_scope": true,
|
|
11
12
|
"plugin/use_monospace_font": true,
|
|
13
|
+
"plugin/check_scope_selectors": true,
|
|
12
14
|
"alpha-value-notation": "percentage",
|
|
13
15
|
"color-function-notation": "modern",
|
|
14
16
|
"hue-degree-notation": "angle",
|
|
15
17
|
"comment-empty-line-before": null,
|
|
16
18
|
"declaration-no-important": true,
|
|
19
|
+
"declaration-block-no-duplicate-properties": true,
|
|
17
20
|
"color-named": "never",
|
|
21
|
+
"selector-no-unmatchable": true,
|
|
18
22
|
"selector-type-no-unknown": [
|
|
19
23
|
true,
|
|
20
24
|
{
|
package/AUTHORS
CHANGED
|
@@ -75,6 +75,7 @@ Karntino Areros <karntino.c.areros@gmail.com>
|
|
|
75
75
|
Kohei Ueno <kohei.ueno119@gmail.com>
|
|
76
76
|
Krishnal Ciccolella <ciccolella.krishnal@gmail.com>
|
|
77
77
|
Liam DeBeasi <ldebeasi@gmail.com>
|
|
78
|
+
Lisha Guo <guolisha@kylinos.cn>
|
|
78
79
|
Luke Swiderski <luke.swiderski@gmail.com>
|
|
79
80
|
Luke Warlow <luke@warlow.dev>
|
|
80
81
|
Lyra Rebane <rebane2001@gmail.com>
|
package/DIR_METADATA
CHANGED
|
@@ -47,7 +47,8 @@ agentic_review: {
|
|
|
47
47
|
path_expression_exclusion: [".*\\.test\\.ts"]
|
|
48
48
|
review_capability_skills: [
|
|
49
49
|
".agents/skills/ui-widgets/SKILL.md",
|
|
50
|
-
".agents/skills/ui-eng-vision-orchestrator/SKILL.md"
|
|
50
|
+
".agents/skills/ui-eng-vision-orchestrator/SKILL.md",
|
|
51
|
+
".agents/skills/visual-regression-audit/SKILL.md"
|
|
51
52
|
]
|
|
52
53
|
rules: [
|
|
53
54
|
".agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md",
|
|
@@ -0,0 +1,143 @@
|
|
|
1
|
+
# Copyright 2026 The Chromium Authors
|
|
2
|
+
# Use of this source code is governed by a BSD-style license that can be
|
|
3
|
+
# found in the LICENSE file.
|
|
4
|
+
|
|
5
|
+
import unittest
|
|
6
|
+
import PRESUBMIT
|
|
7
|
+
|
|
8
|
+
|
|
9
|
+
class MockChange:
|
|
10
|
+
|
|
11
|
+
def __init__(self, description):
|
|
12
|
+
self._description = description
|
|
13
|
+
|
|
14
|
+
def FullDescriptionText(self):
|
|
15
|
+
return self._description
|
|
16
|
+
|
|
17
|
+
|
|
18
|
+
class MockInputApi:
|
|
19
|
+
|
|
20
|
+
def __init__(self, description):
|
|
21
|
+
self.change = MockChange(description)
|
|
22
|
+
|
|
23
|
+
|
|
24
|
+
class MockOutputApi:
|
|
25
|
+
|
|
26
|
+
class PresubmitResult:
|
|
27
|
+
|
|
28
|
+
def __init__(self, message, items=None, long_text=''):
|
|
29
|
+
self.message = message
|
|
30
|
+
self.items = items or []
|
|
31
|
+
self.long_text = long_text
|
|
32
|
+
|
|
33
|
+
def __repr__(self):
|
|
34
|
+
return f'{self.__class__.__name__}({self.message!r})'
|
|
35
|
+
|
|
36
|
+
class PresubmitError(PresubmitResult):
|
|
37
|
+
pass
|
|
38
|
+
|
|
39
|
+
|
|
40
|
+
class PiperTagsPresubmitTest(unittest.TestCase):
|
|
41
|
+
|
|
42
|
+
def testValidCleanDescription(self):
|
|
43
|
+
description = (
|
|
44
|
+
'[devtools] Add cool feature\n\n'
|
|
45
|
+
'This is a clean commit description.\n\n'
|
|
46
|
+
'Bug: 123456\n'
|
|
47
|
+
'Change-Id: I1234567890abcdef1234567890abcdef12345678\n')
|
|
48
|
+
input_api = MockInputApi(description)
|
|
49
|
+
output_api = MockOutputApi()
|
|
50
|
+
|
|
51
|
+
errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
|
|
52
|
+
self.assertEqual(errors, [])
|
|
53
|
+
|
|
54
|
+
def testValidWithFixedAndNone(self):
|
|
55
|
+
description = ('[devtools] Fix issue\n\n'
|
|
56
|
+
'Fixed: 123456, 7890\n')
|
|
57
|
+
input_api = MockInputApi(description)
|
|
58
|
+
output_api = MockOutputApi()
|
|
59
|
+
|
|
60
|
+
errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
|
|
61
|
+
self.assertEqual(errors, [])
|
|
62
|
+
|
|
63
|
+
description_none = ('[devtools] Minor cleanup\n\n'
|
|
64
|
+
'Bug: None\n')
|
|
65
|
+
input_api_none = MockInputApi(description_none)
|
|
66
|
+
errors_none = PRESUBMIT.CheckNoPiperTagsInDescription(
|
|
67
|
+
input_api_none, output_api)
|
|
68
|
+
self.assertEqual(errors_none, [])
|
|
69
|
+
|
|
70
|
+
def testValidMidLineTags(self):
|
|
71
|
+
description = (
|
|
72
|
+
'[devtools] Update docs\n\n'
|
|
73
|
+
'We previously fixed a bug where TAG=agy was incorrectly emitted.\n'
|
|
74
|
+
'Also noted that BUG=123 is discussed in comments.\n\n'
|
|
75
|
+
'Bug: 123456\n')
|
|
76
|
+
input_api = MockInputApi(description)
|
|
77
|
+
output_api = MockOutputApi()
|
|
78
|
+
|
|
79
|
+
errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
|
|
80
|
+
self.assertEqual(errors, [])
|
|
81
|
+
|
|
82
|
+
def testValidExcludedKeys(self):
|
|
83
|
+
description = (
|
|
84
|
+
'[devtools] Roll deps\n\n'
|
|
85
|
+
'Roll third_party/something\n\n'
|
|
86
|
+
'R=chrome-devtools-waterfall-gardener-emea-oncall@google.com\n'
|
|
87
|
+
'TBR=someone@chromium.org\n'
|
|
88
|
+
'CC=someone@chromium.org\n'
|
|
89
|
+
'Bug: None\n')
|
|
90
|
+
input_api = MockInputApi(description)
|
|
91
|
+
output_api = MockOutputApi()
|
|
92
|
+
|
|
93
|
+
errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
|
|
94
|
+
self.assertEqual(errors, [])
|
|
95
|
+
|
|
96
|
+
def testRejectsPiperTags(self):
|
|
97
|
+
rejected_keys = [
|
|
98
|
+
'TAG=agy',
|
|
99
|
+
'CONV=c29008c7-cac9-4486-adb8-a74b42bd015e',
|
|
100
|
+
'BUG=123456',
|
|
101
|
+
'FIXED=123456',
|
|
102
|
+
'MARKDOWN=true',
|
|
103
|
+
'ORIGINAL_AUTHOR=author@example.com',
|
|
104
|
+
'WANT_LGTM=1',
|
|
105
|
+
'AUTOSUBMIT_BEHAVIOR=1',
|
|
106
|
+
'R_FUTURE=someone@example.com',
|
|
107
|
+
]
|
|
108
|
+
output_api = MockOutputApi()
|
|
109
|
+
|
|
110
|
+
for tag in rejected_keys:
|
|
111
|
+
with self.subTest(tag=tag):
|
|
112
|
+
description = f'[devtools] Change\n\nExplanation.\n\n{tag}\nBug: 123\n'
|
|
113
|
+
input_api = MockInputApi(description)
|
|
114
|
+
errors = PRESUBMIT.CheckNoPiperTagsInDescription(
|
|
115
|
+
input_api, output_api)
|
|
116
|
+
self.assertEqual(len(errors), 1,
|
|
117
|
+
f'Expected {tag} to be rejected')
|
|
118
|
+
self.assertIsInstance(errors[0], output_api.PresubmitError)
|
|
119
|
+
self.assertIn(tag, errors[0].message)
|
|
120
|
+
self.assertIn('Bug:', errors[0].message)
|
|
121
|
+
self.assertIn('Fixed:', errors[0].message)
|
|
122
|
+
self.assertIn('cl.upload-conversation-id', errors[0].message)
|
|
123
|
+
|
|
124
|
+
def testRejectsMultipleOffendingLines(self):
|
|
125
|
+
description = ('[devtools] Change\n\n'
|
|
126
|
+
'Explanation.\n\n'
|
|
127
|
+
'TAG=agy\n'
|
|
128
|
+
'CONV=c29008c7-cac9-4486-adb8-a74b42bd015e\n'
|
|
129
|
+
'BUG=12345\n'
|
|
130
|
+
'Bug: 12345\n')
|
|
131
|
+
input_api = MockInputApi(description)
|
|
132
|
+
output_api = MockOutputApi()
|
|
133
|
+
|
|
134
|
+
errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
|
|
135
|
+
self.assertEqual(len(errors), 1)
|
|
136
|
+
self.assertIn('TAG=agy', errors[0].message)
|
|
137
|
+
self.assertIn('CONV=c29008c7-cac9-4486-adb8-a74b42bd015e',
|
|
138
|
+
errors[0].message)
|
|
139
|
+
self.assertIn('BUG=12345', errors[0].message)
|
|
140
|
+
|
|
141
|
+
|
|
142
|
+
if __name__ == '__main__':
|
|
143
|
+
unittest.main()
|
|
@@ -130,8 +130,8 @@ and extended branch numbers in infra/config (example [CL](https://crrev.com/c/68
|
|
|
130
130
|
- otherwise update it to the current stable number
|
|
131
131
|
- stable number updates to the current beta number
|
|
132
132
|
- beta number updates to the Chromium beta brunch number ([see](https://chromiumdash.appspot.com/branches))
|
|
133
|
-
- regenerate the cfg files (`lucicfg main.star`), commit, upload and add
|
|
134
|
-
|
|
133
|
+
- regenerate the cfg files (`lucicfg main.star`), commit, upload and add an
|
|
134
|
+
infra team member as reviewer
|
|
135
135
|
|
|
136
136
|
Changing these numbers will reconfigure the CI and CQ for [beta](https://ci.chromium.org/p/devtools-frontend/g/beta/console),
|
|
137
137
|
[stable](https://ci.chromium.org/p/devtools-frontend/g/stable/console) and
|
package/docs/ui_engineering.md
CHANGED
|
@@ -119,9 +119,18 @@ render(html`
|
|
|
119
119
|
`, this.element);
|
|
120
120
|
```
|
|
121
121
|
|
|
122
|
-
In this example, the `.title` style will apply within the parent widget but will not leak into the nested widget.
|
|
122
|
+
In this example, the `.title` style will apply within the parent widget but will not leak into the nested widget. Two automated lint rules enforce this encapsulation:
|
|
123
123
|
|
|
124
|
-
|
|
124
|
+
- `@devtools/no-unscoped-light-dom-styles` (ESLint): checks stylesheets injected by Light DOM widgets (`<style>${styles}</style>`, `this.registerRequiredCSS()`, and `appendStyle()`) and requires every style rule to sit inside a top-level `@scope` block. Pre-existing outliers are tracked in a self-cleaning `burndown` list in `eslint.config.mjs` (never add new files to that list).
|
|
125
|
+
- `plugin/check_scope_selectors` (stylelint): unconditionally forbids `:host` inside `@scope` (even with `:scope` or `&`), and flags ancestor selectors that receive an implicit `:scope ` descendant combinator and never match without `:scope` or `&` (`:host-context()`, `:root`, `html`, `body`, `.theme-with-dark-background`, `.platform-*`, and `.overlay-scrollbar-enabled`).
|
|
126
|
+
|
|
127
|
+
### Key `@scope` Traps and Best Practices
|
|
128
|
+
|
|
129
|
+
1. **`:scope` instead of `:host`**: `:host` is Shadow DOM-only and never matches inside `@scope`. Style the widget's root container element with `:scope`.
|
|
130
|
+
2. **Theme-aware tokens instead of theme or platform classes**: Because selectors inside `@scope` without `:scope` or `&` receive an implicit `:scope ` descendant prefix, selectors like `.theme-with-dark-background .foo` or `:host-context(.theme-with-dark-background) .foo` look for ancestor theme classes *inside* the scoped subtree and never match. Use theme-aware design tokens (`--sys-color-*` / `--app-color-*`) instead.
|
|
131
|
+
3. **Shared stylesheets**: Do not inject `inspectorCommonStyles` or `textButtonStyles` into Light DOM views (`installComponentRootStyles()` already applies them to the document and shadow roots). Wrap other shared stylesheets inline as `<style>@scope to (devtools-widget > *) { ${styles} }</style>` so their Shadow DOM consumers stay unaffected. Note that inline wrapping disables CSS hot reload in DevTools-on-DevTools for that `<style>` element.
|
|
132
|
+
4. **Lower boundary and imperative child widgets**: The `(devtools-widget > *)` lower boundary stops cascading into declarative `<devtools-widget>` children (`${widget(...)}`), but it does **not** stop at legacy imperatively attached `<div class="widget">` children (`childWidget.show(container)`).
|
|
133
|
+
5. **`<devtools-data-grid>`**: Inside a `<devtools-data-grid>`, any `<style>` tags must be placed as direct children of the `<table>` element. `<style>` tags inside `<devtools-data-grid>` stay connected in Light DOM, so their stylesheets still require `@scope`.
|
|
125
134
|
|
|
126
135
|
## Examples
|
|
127
136
|
|
|
@@ -587,7 +596,7 @@ export const DEFAULT_VIEW = (input, _output, target) => {
|
|
|
587
596
|
|
|
588
597
|
## Migrating `UI.Toolbar.ToolbarButton`
|
|
589
598
|
|
|
590
|
-
Replace the imperative creation of a `ToolbarButton` with the declarative `<devtools-button>` component.
|
|
599
|
+
Replace the imperative creation of a `ToolbarButton` with the declarative `<devtools-button>` component. For icon-only buttons, always bind `.accessibleLabel` (in addition to `title`) because `<devtools-button>` sets `role="presentation"` on its host element and forwards `.accessibleLabel` to its inner `<button>`.
|
|
591
600
|
|
|
592
601
|
**Before:**
|
|
593
602
|
```typescript
|
|
@@ -611,7 +620,8 @@ export const DEFAULT_VIEW = (input, _output, target) => {
|
|
|
611
620
|
render(html`
|
|
612
621
|
<div>
|
|
613
622
|
<devtools-toolbar>
|
|
614
|
-
<devtools-button title=${i18nString(UIStrings.editName)}
|
|
623
|
+
<devtools-button title=${i18nString(UIStrings.editName)}
|
|
624
|
+
.accessibleLabel=${i18nString(UIStrings.editName)} @click=${this.onClick.bind(this)}
|
|
615
625
|
.variant=${Buttons.Button.Variant.TOOLBAR} .iconName=${'edit'}
|
|
616
626
|
.jslogContext=${'edit-name'}></devtools-button>
|
|
617
627
|
</devtools-toolbar>
|
package/eslint.config.mjs
CHANGED
|
@@ -25,6 +25,7 @@ export default defineConfig([
|
|
|
25
25
|
'out/',
|
|
26
26
|
// Don't include third party code
|
|
27
27
|
'third_party/',
|
|
28
|
+
'for_agents/',
|
|
28
29
|
|
|
29
30
|
'front_end/diff/diff_match_patch.js',
|
|
30
31
|
'front_end/models/javascript_metadata/NativeFunctions.ts',
|
|
@@ -735,6 +736,7 @@ export default defineConfig([
|
|
|
735
736
|
'front_end/**/*.docs.ts',
|
|
736
737
|
'test/**/*.ts',
|
|
737
738
|
'**/testing/*.ts',
|
|
739
|
+
'scripts/build/tests/**/*.ts',
|
|
738
740
|
'scripts/eslint_rules/tests/**/*',
|
|
739
741
|
'scripts/gn_deps_verifier/tests/**/*',
|
|
740
742
|
'extensions/cxx_debugging/e2e/**/*.ts',
|
|
@@ -810,6 +812,19 @@ export default defineConfig([
|
|
|
810
812
|
],
|
|
811
813
|
},
|
|
812
814
|
},
|
|
815
|
+
{
|
|
816
|
+
name: 'JavaScript script test files',
|
|
817
|
+
// The 'TypeScript test files' rules need type information, so JS tests
|
|
818
|
+
// only get the mocha rules. Missing mocha imports fail at runtime (see
|
|
819
|
+
// test/scripts/run_mocha.ts).
|
|
820
|
+
files: ['scripts/build/tests/**/*.js'],
|
|
821
|
+
rules: {
|
|
822
|
+
'mocha/no-exclusive-tests': 'error',
|
|
823
|
+
'mocha/no-async-describe': 'error',
|
|
824
|
+
'mocha/no-global-tests': 'error',
|
|
825
|
+
'mocha/no-nested-tests': 'error',
|
|
826
|
+
},
|
|
827
|
+
},
|
|
813
828
|
{
|
|
814
829
|
name: 'API test files',
|
|
815
830
|
files: ['**/*.test.api.ts'],
|
|
@@ -833,6 +848,110 @@ export default defineConfig([
|
|
|
833
848
|
'@devtools/prefer-private-class-members': 'error',
|
|
834
849
|
},
|
|
835
850
|
},
|
|
851
|
+
{
|
|
852
|
+
name: 'Enforce scoped light DOM styles rule',
|
|
853
|
+
files: [
|
|
854
|
+
'front_end/**/*.ts',
|
|
855
|
+
],
|
|
856
|
+
ignores: [
|
|
857
|
+
'front_end/**/*.test.ts',
|
|
858
|
+
'front_end/**/*.test.api.ts',
|
|
859
|
+
'front_end/**/*.docs.ts',
|
|
860
|
+
'front_end/testing/**',
|
|
861
|
+
'front_end/third_party/**',
|
|
862
|
+
],
|
|
863
|
+
|
|
864
|
+
rules: {
|
|
865
|
+
'@devtools/no-unscoped-light-dom-styles': [
|
|
866
|
+
'error',
|
|
867
|
+
{
|
|
868
|
+
// Burndown list of Light DOM widgets with unscoped styles. Do NOT add files to this list.
|
|
869
|
+
// New Light DOM widgets must wrap their styles in '@scope' (see docs/ui_engineering.md#styling).
|
|
870
|
+
burndown: [
|
|
871
|
+
'front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts',
|
|
872
|
+
'front_end/panels/accessibility/AccessibilityNodeView.ts',
|
|
873
|
+
'front_end/panels/ai_assistance/AiAssistancePanel.ts',
|
|
874
|
+
'front_end/panels/ai_assistance/components/ChatInput.ts',
|
|
875
|
+
'front_end/panels/ai_assistance/components/ChatMessage.ts',
|
|
876
|
+
'front_end/panels/ai_assistance/components/RelevantDataDisclaimer.ts',
|
|
877
|
+
'front_end/panels/ai_assistance/components/WalkthroughView.ts',
|
|
878
|
+
'front_end/panels/application/BackgroundServiceView.ts',
|
|
879
|
+
'front_end/panels/application/CrashReportContextView.ts',
|
|
880
|
+
'front_end/panels/application/DeviceBoundSessionsView.ts',
|
|
881
|
+
'front_end/panels/application/IndexedDBViews.ts',
|
|
882
|
+
'front_end/panels/application/KeyValueStorageItemsView.ts',
|
|
883
|
+
'front_end/panels/application/ResourcesPanel.ts',
|
|
884
|
+
'front_end/panels/application/ServiceWorkerCacheViews.ts',
|
|
885
|
+
'front_end/panels/application/ServiceWorkersView.ts',
|
|
886
|
+
'front_end/panels/application/WebMCPView.ts',
|
|
887
|
+
'front_end/panels/application/components/EndpointsGrid.ts',
|
|
888
|
+
'front_end/panels/application/components/ProtocolHandlersView.ts',
|
|
889
|
+
'front_end/panels/changes/CombinedDiffView.ts',
|
|
890
|
+
'front_end/panels/common/CommentThreadWidget.ts',
|
|
891
|
+
'front_end/panels/console/ConsolePinPane.ts',
|
|
892
|
+
'front_end/panels/console/ConsolePrompt.ts',
|
|
893
|
+
'front_end/panels/console/ConsoleView.ts',
|
|
894
|
+
'front_end/panels/css_overview/CSSOverviewProcessingView.ts',
|
|
895
|
+
'front_end/panels/elements/AccessibilityTreeView.ts',
|
|
896
|
+
'front_end/panels/elements/ElementsPanel.ts',
|
|
897
|
+
'front_end/panels/elements/LayersWidget.ts',
|
|
898
|
+
'front_end/panels/event_listeners/EventListenersView.ts',
|
|
899
|
+
'front_end/panels/explain/components/ConsoleInsight.ts',
|
|
900
|
+
'front_end/panels/layer_viewer/Layers3DView.ts',
|
|
901
|
+
'front_end/panels/lighthouse/LighthousePanel.ts',
|
|
902
|
+
'front_end/panels/linear_memory_inspector/components/LinearMemoryNavigator.ts',
|
|
903
|
+
'front_end/panels/linear_memory_inspector/components/ValueInterpreterDisplay.ts',
|
|
904
|
+
'front_end/panels/media/EventDisplayTable.ts',
|
|
905
|
+
'front_end/panels/media/PlayerMessagesView.ts',
|
|
906
|
+
'front_end/panels/media/PlayerPropertiesView.ts',
|
|
907
|
+
'front_end/panels/network/NetworkLogView.ts',
|
|
908
|
+
'front_end/panels/network/NetworkPanel.ts',
|
|
909
|
+
'front_end/panels/network/NetworkWaterfallColumn.ts',
|
|
910
|
+
'front_end/panels/network/RequestDeviceBoundSessionsView.ts',
|
|
911
|
+
'front_end/panels/network/RequestHeadersView.ts',
|
|
912
|
+
'front_end/panels/network/RequestPayloadView.ts',
|
|
913
|
+
'front_end/panels/network/RequestTimingView.ts',
|
|
914
|
+
'front_end/panels/profiler/HeapProfileView.ts',
|
|
915
|
+
'front_end/panels/profiler/ProfileLauncherView.ts',
|
|
916
|
+
'front_end/panels/profiler/ProfilesPanel.ts',
|
|
917
|
+
'front_end/panels/settings/AISettingsTab.ts',
|
|
918
|
+
'front_end/panels/settings/emulation/DevicesSettingsTab.ts',
|
|
919
|
+
'front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts',
|
|
920
|
+
'front_end/panels/sources/FilteredUISourceCodeListProvider.ts',
|
|
921
|
+
'front_end/panels/sources/SourcesNavigator.ts',
|
|
922
|
+
'front_end/panels/sources/SourcesPanel.ts',
|
|
923
|
+
'front_end/panels/sources/ThreadsSidebarPane.ts',
|
|
924
|
+
'front_end/panels/sources/UISourceCodeFrame.ts',
|
|
925
|
+
'front_end/panels/timeline/ThirdPartyTreeView.ts',
|
|
926
|
+
'front_end/panels/timeline/TimelineFlameChartDataProvider.ts',
|
|
927
|
+
'front_end/panels/timeline/TimelineFlameChartView.ts',
|
|
928
|
+
'front_end/panels/timeline/TimelineMiniMap.ts',
|
|
929
|
+
'front_end/panels/timeline/TimelinePaintProfilerView.ts',
|
|
930
|
+
'front_end/panels/timeline/TimelinePanel.ts',
|
|
931
|
+
'front_end/panels/timeline/TimelineSelectorStatsView.ts',
|
|
932
|
+
'front_end/panels/timeline/TimelineTreeView.ts',
|
|
933
|
+
'front_end/panels/webauthn/WebauthnPane.ts',
|
|
934
|
+
'front_end/ui/components/dialogs/FreDialog.ts',
|
|
935
|
+
'front_end/ui/components/text_editor/AiCodeGenerationUpgradeDialog.ts',
|
|
936
|
+
'front_end/ui/legacy/FilterBar.ts',
|
|
937
|
+
'front_end/ui/legacy/RootView.ts',
|
|
938
|
+
'front_end/ui/legacy/components/cookie_table/CookiesTable.ts',
|
|
939
|
+
'front_end/ui/legacy/components/data_grid/DataGrid.ts',
|
|
940
|
+
'front_end/ui/legacy/components/inline_editor/CSSAngle.ts',
|
|
941
|
+
'front_end/ui/legacy/components/inline_editor/LinkSwatch.ts',
|
|
942
|
+
'front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts',
|
|
943
|
+
'front_end/ui/legacy/components/perf_ui/ChartViewport.ts',
|
|
944
|
+
'front_end/ui/legacy/components/perf_ui/OverviewGrid.ts',
|
|
945
|
+
'front_end/ui/legacy/components/perf_ui/TimelineGrid.ts',
|
|
946
|
+
'front_end/ui/legacy/components/source_frame/FontView.ts',
|
|
947
|
+
'front_end/ui/legacy/components/source_frame/JSONView.ts',
|
|
948
|
+
'front_end/ui/legacy/components/source_frame/XMLView.ts',
|
|
949
|
+
],
|
|
950
|
+
},
|
|
951
|
+
],
|
|
952
|
+
},
|
|
953
|
+
},
|
|
954
|
+
|
|
836
955
|
{
|
|
837
956
|
name: 'Ignore private class members rule',
|
|
838
957
|
// The list below is an explicit burndown list of legacy files that have not
|
|
@@ -997,7 +1116,6 @@ export default defineConfig([
|
|
|
997
1116
|
'front_end/panels/network/EventSourceMessagesView.ts',
|
|
998
1117
|
'front_end/panels/network/NetworkDataGridNode.ts',
|
|
999
1118
|
'front_end/panels/network/NetworkFrameGrouper.ts',
|
|
1000
|
-
'front_end/panels/network/NetworkLogView.ts',
|
|
1001
1119
|
'front_end/panels/network/NetworkLogViewColumns.ts',
|
|
1002
1120
|
'front_end/panels/network/NetworkManageCustomHeadersView.ts',
|
|
1003
1121
|
'front_end/panels/network/NetworkOverview.ts',
|
|
@@ -1032,7 +1150,6 @@ export default defineConfig([
|
|
|
1032
1150
|
'front_end/panels/sources/EditingLocationHistoryManager.ts',
|
|
1033
1151
|
'front_end/panels/sources/FilePathScoreFunction.ts',
|
|
1034
1152
|
'front_end/panels/sources/FilteredUISourceCodeListProvider.ts',
|
|
1035
|
-
'front_end/panels/sources/NavigatorView.ts',
|
|
1036
1153
|
'front_end/panels/sources/OutlineQuickOpen.ts',
|
|
1037
1154
|
'front_end/panels/sources/SourcesPanel.ts',
|
|
1038
1155
|
'front_end/panels/sources/SourcesSearchScope.ts',
|
|
@@ -1146,13 +1263,6 @@ export default defineConfig([
|
|
|
1146
1263
|
'@devtools/prefer-private-class-members': 'off',
|
|
1147
1264
|
},
|
|
1148
1265
|
},
|
|
1149
|
-
{
|
|
1150
|
-
name: 'Supported CSS properties rules',
|
|
1151
|
-
files: ['front_end/generated/SupportedCSSProperties.ts'],
|
|
1152
|
-
rules: {
|
|
1153
|
-
'@devtools/jslog-context-list': 'error',
|
|
1154
|
-
},
|
|
1155
|
-
},
|
|
1156
1266
|
{
|
|
1157
1267
|
name: 'EsLint rules test',
|
|
1158
1268
|
files: ['scripts/eslint_rules/tests/**/*'],
|