chrome-devtools-frontend 1.0.1721762 → 1.0.1724140

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (195) hide show
  1. package/docs/cookbook/dependencies.md +55 -11
  2. package/docs/get_the_code.md +15 -0
  3. package/front_end/core/i18n/collect-ui-strings.js +58 -12
  4. package/front_end/core/sdk/WebAuthnModel.ts +17 -10
  5. package/front_end/generated/InspectorBackendCommands.ts +2 -2
  6. package/front_end/generated/protocol.ts +16 -0
  7. package/front_end/models/comment_manager/CD4ABridge.ts +4 -0
  8. package/front_end/models/comment_manager/CommentThread.ts +16 -0
  9. package/front_end/models/trace/handlers/NetworkRequestsHandler.ts +13 -6
  10. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +92 -0
  11. package/front_end/panels/accessibility/accessibilityAnnouncementRecordingListView.css +3 -1
  12. package/front_end/panels/accessibility/accessibilityAnnouncementRecordingView.css +12 -1
  13. package/front_end/panels/application/StorageView.ts +250 -178
  14. package/front_end/panels/application/SubAppsView.ts +159 -0
  15. package/front_end/panels/application/application.ts +2 -0
  16. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +1 -1
  17. package/front_end/panels/application/subAppsView.css +21 -0
  18. package/front_end/panels/elements/ClassesPaneWidget.ts +3 -1
  19. package/front_end/panels/elements/DOMTreeElementWidget.ts +3 -1
  20. package/front_end/panels/elements/DOMTreeWidget.ts +12 -0
  21. package/front_end/panels/elements/StyleEditorWidget.ts +29 -0
  22. package/front_end/panels/elements/StylesSidebarPane.ts +1 -0
  23. package/front_end/panels/layer_viewer/Layers3DView.ts +21 -37
  24. package/front_end/panels/network/NetworkConfigView.ts +12 -10
  25. package/front_end/panels/network/networkConfigView.css +8 -8
  26. package/front_end/panels/screencast/ScreencastView.ts +3 -6
  27. package/front_end/panels/security/SecurityPanelSidebar.ts +0 -31
  28. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +9 -16
  29. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +358 -345
  30. package/front_end/panels/settings/emulation/components/userAgentClientHintsForm.css +136 -121
  31. package/front_end/panels/sources/SourcesPanel.ts +3 -1
  32. package/front_end/panels/sources/TabbedEditorContainer.ts +41 -18
  33. package/front_end/panels/sources/UISourceCodeFrame.ts +1 -1
  34. package/front_end/panels/timeline/TimelineCommentContext.ts +171 -0
  35. package/front_end/panels/timeline/TimelineCommentController.ts +36 -0
  36. package/front_end/panels/timeline/timeline.ts +2 -0
  37. package/front_end/panels/webauthn/WebauthnPane.ts +15 -13
  38. package/front_end/third_party/chromium/README.chromium +1 -1
  39. package/front_end/third_party/puppeteer/README.chromium +2 -2
  40. package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.d.ts +113 -3
  41. package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.js +21311 -20981
  42. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.d.ts +36 -0
  43. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.d.ts.map +1 -1
  44. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.js +22 -0
  45. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Browser.js.map +1 -1
  46. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/BrowserContext.d.ts.map +1 -1
  47. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/BrowserContext.js +20 -18
  48. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/BrowserContext.js.map +1 -1
  49. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.d.ts +20 -1
  50. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.d.ts.map +1 -1
  51. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.js +2 -2
  52. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/HTTPRequest.js.map +1 -1
  53. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.d.ts +40 -1
  54. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.d.ts.map +1 -1
  55. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.js +3 -1
  56. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/Page.js.map +1 -1
  57. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.d.ts +2 -0
  58. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.d.ts.map +1 -1
  59. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.js +41 -5
  60. package/front_end/third_party/puppeteer/package/lib/puppeteer/api/locators/locators.js.map +1 -1
  61. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.d.ts +2 -1
  62. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.d.ts.map +1 -1
  63. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.js +23 -2
  64. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/HTTPRequest.js.map +1 -1
  65. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Input.js +1 -1
  66. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.d.ts +3 -2
  67. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.d.ts.map +1 -1
  68. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.js +13 -1
  69. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/Page.js.map +1 -1
  70. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.d.ts +1 -0
  71. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.d.ts.map +1 -1
  72. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.js +18 -11
  73. package/front_end/third_party/puppeteer/package/lib/puppeteer/bidi/core/Request.js.map +1 -1
  74. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Accessibility.d.ts +2 -1
  75. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Accessibility.d.ts.map +1 -1
  76. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Accessibility.js +8 -1
  77. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Accessibility.js.map +1 -1
  78. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Browser.d.ts +2 -1
  79. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Browser.d.ts.map +1 -1
  80. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Browser.js +24 -12
  81. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Browser.js.map +1 -1
  82. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/EmulationManager.d.ts +1 -1
  83. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/EmulationManager.d.ts.map +1 -1
  84. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/EmulationManager.js +13 -7
  85. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/EmulationManager.js.map +1 -1
  86. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Frame.d.ts.map +1 -1
  87. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Frame.js +5 -1
  88. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Frame.js.map +1 -1
  89. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.d.ts +22 -1
  90. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.d.ts.map +1 -1
  91. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.js +75 -9
  92. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/HTTPRequest.js.map +1 -1
  93. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.d.ts +18 -4
  94. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.d.ts.map +1 -1
  95. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.js +8 -4
  96. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkEventManager.js.map +1 -1
  97. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.d.ts.map +1 -1
  98. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.js +65 -26
  99. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/NetworkManager.js.map +1 -1
  100. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.d.ts +3 -2
  101. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.d.ts.map +1 -1
  102. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.js +19 -0
  103. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Page.js.map +1 -1
  104. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ScreenRecording.d.ts.map +1 -1
  105. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ScreenRecording.js +4 -3
  106. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ScreenRecording.js.map +1 -1
  107. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.d.ts +1 -0
  108. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.d.ts.map +1 -1
  109. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.js +4 -0
  110. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Target.js.map +1 -1
  111. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/TargetManager.d.ts +2 -0
  112. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/TargetManager.d.ts.map +1 -1
  113. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/TargetManager.js +95 -8
  114. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/TargetManager.js.map +1 -1
  115. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserConnector.d.ts +0 -8
  116. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserConnector.d.ts.map +1 -1
  117. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserConnector.js +8 -24
  118. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserConnector.js.map +1 -1
  119. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserWebSocketTransport.d.ts +1 -0
  120. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserWebSocketTransport.d.ts.map +1 -1
  121. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserWebSocketTransport.js +5 -4
  122. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/BrowserWebSocketTransport.js.map +1 -1
  123. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/ConnectOptions.d.ts +9 -0
  124. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/ConnectOptions.d.ts.map +1 -1
  125. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/WaitTask.d.ts.map +1 -1
  126. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/WaitTask.js +10 -0
  127. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/WaitTask.js.map +1 -1
  128. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.d.ts +10 -0
  129. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.d.ts.map +1 -1
  130. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.js +30 -5
  131. package/front_end/third_party/puppeteer/package/lib/puppeteer/common/util.js.map +1 -1
  132. package/front_end/third_party/puppeteer/package/lib/puppeteer/generated/injected.d.ts +1 -1
  133. package/front_end/third_party/puppeteer/package/lib/puppeteer/generated/injected.d.ts.map +1 -1
  134. package/front_end/third_party/puppeteer/package/lib/puppeteer/generated/injected.js +1 -1
  135. package/front_end/third_party/puppeteer/package/lib/puppeteer/generated/injected.js.map +1 -1
  136. package/front_end/third_party/puppeteer/package/lib/puppeteer/injected/Poller.d.ts +2 -0
  137. package/front_end/third_party/puppeteer/package/lib/puppeteer/injected/Poller.d.ts.map +1 -1
  138. package/front_end/third_party/puppeteer/package/lib/puppeteer/injected/Poller.js +33 -3
  139. package/front_end/third_party/puppeteer/package/lib/puppeteer/injected/Poller.js.map +1 -1
  140. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.d.ts.map +1 -1
  141. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.js +1 -2
  142. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/BrowserLauncher.js.map +1 -1
  143. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/NodeWebSocketTransport.d.ts +4 -0
  144. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/NodeWebSocketTransport.d.ts.map +1 -1
  145. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/NodeWebSocketTransport.js +1 -0
  146. package/front_end/third_party/puppeteer/package/lib/puppeteer/node/NodeWebSocketTransport.js.map +1 -1
  147. package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.d.ts +3 -3
  148. package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.js +3 -3
  149. package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.js.map +1 -1
  150. package/front_end/third_party/puppeteer/package/lib/puppeteer/util/encoding.d.ts +2 -2
  151. package/front_end/third_party/puppeteer/package/lib/puppeteer/util/encoding.d.ts.map +1 -1
  152. package/front_end/third_party/puppeteer/package/lib/puppeteer/util/version.d.ts +1 -1
  153. package/front_end/third_party/puppeteer/package/lib/puppeteer/util/version.js +1 -1
  154. package/front_end/third_party/puppeteer/package/lib/types.d.ts +113 -3
  155. package/front_end/third_party/puppeteer/package/package.json +4 -4
  156. package/front_end/third_party/puppeteer/package/src/api/Browser.ts +42 -0
  157. package/front_end/third_party/puppeteer/package/src/api/BrowserContext.ts +25 -22
  158. package/front_end/third_party/puppeteer/package/src/api/HTTPRequest.ts +22 -2
  159. package/front_end/third_party/puppeteer/package/src/api/Page.ts +45 -2
  160. package/front_end/third_party/puppeteer/package/src/api/locators/locators.ts +79 -32
  161. package/front_end/third_party/puppeteer/package/src/bidi/HTTPRequest.ts +32 -12
  162. package/front_end/third_party/puppeteer/package/src/bidi/Input.ts +1 -1
  163. package/front_end/third_party/puppeteer/package/src/bidi/Page.ts +18 -2
  164. package/front_end/third_party/puppeteer/package/src/bidi/core/Request.ts +21 -13
  165. package/front_end/third_party/puppeteer/package/src/cdp/Accessibility.ts +12 -2
  166. package/front_end/third_party/puppeteer/package/src/cdp/Browser.ts +37 -16
  167. package/front_end/third_party/puppeteer/package/src/cdp/EmulationManager.ts +14 -11
  168. package/front_end/third_party/puppeteer/package/src/cdp/Frame.ts +7 -1
  169. package/front_end/third_party/puppeteer/package/src/cdp/HTTPRequest.ts +101 -14
  170. package/front_end/third_party/puppeteer/package/src/cdp/NetworkEventManager.ts +26 -6
  171. package/front_end/third_party/puppeteer/package/src/cdp/NetworkManager.ts +111 -29
  172. package/front_end/third_party/puppeteer/package/src/cdp/Page.ts +37 -1
  173. package/front_end/third_party/puppeteer/package/src/cdp/ScreenRecording.ts +5 -4
  174. package/front_end/third_party/puppeteer/package/src/cdp/Target.ts +5 -0
  175. package/front_end/third_party/puppeteer/package/src/cdp/TargetManager.ts +122 -7
  176. package/front_end/third_party/puppeteer/package/src/common/BrowserConnector.ts +13 -33
  177. package/front_end/third_party/puppeteer/package/src/common/BrowserWebSocketTransport.ts +10 -5
  178. package/front_end/third_party/puppeteer/package/src/common/ConnectOptions.ts +10 -0
  179. package/front_end/third_party/puppeteer/package/src/common/WaitTask.ts +12 -0
  180. package/front_end/third_party/puppeteer/package/src/common/util.ts +39 -5
  181. package/front_end/third_party/puppeteer/package/src/generated/injected.ts +1 -1
  182. package/front_end/third_party/puppeteer/package/src/injected/Poller.ts +35 -3
  183. package/front_end/third_party/puppeteer/package/src/node/BrowserLauncher.ts +4 -2
  184. package/front_end/third_party/puppeteer/package/src/node/NodeWebSocketTransport.ts +5 -0
  185. package/front_end/third_party/puppeteer/package/src/revisions.ts +3 -3
  186. package/front_end/third_party/puppeteer/package/src/util/encoding.ts +2 -2
  187. package/front_end/third_party/puppeteer/package/src/util/version.ts +1 -1
  188. package/front_end/ui/helpers/OpenInNewTab.ts +8 -0
  189. package/front_end/ui/legacy/LinkContextMenuProvider.ts +1 -1
  190. package/front_end/ui/legacy/ListWidget.ts +14 -18
  191. package/front_end/ui/legacy/TabbedPane.ts +46 -3
  192. package/front_end/ui/legacy/Treeoutline.ts +3 -1
  193. package/front_end/ui/legacy/UIUtils.ts +1 -1
  194. package/front_end/ui/visual_logging/KnownContextValues.ts +4 -0
  195. package/package.json +1 -1
@@ -57,6 +57,8 @@ import * as SDK from '../../core/sdk/sdk.js';
57
57
  * Chrome ("stable", "beta", "dev", or "canary").
58
58
  *
59
59
  * @param url the URL to open in a new tab.
60
+ * @param allowPrivileged whether to also open URLs with privileged or other non-web-safe schemes. By default,
61
+ * only URLs with web-safe schemes (see `Common.ParsedURL.hasWebSafeScheme`) are opened.
60
62
  * @throws TypeError if `url` is not a valid URL.
61
63
  * @see https://en.wikipedia.org/wiki/UTM_parameters
62
64
  */
@@ -66,6 +68,12 @@ export function openInNewTab(url: URL|string, allowPrivileged?: boolean): void {
66
68
  return;
67
69
  }
68
70
 
71
+ // Only open URLs with privileged or other non-web-safe schemes (such as `chrome:`, `devtools:`, or `file:`)
72
+ // when the caller explicitly allows it.
73
+ if (!allowPrivileged && !Common.ParsedURL.hasWebSafeScheme(url)) {
74
+ return;
75
+ }
76
+
69
77
  // Navigating to a chrome:// link via a normal anchor doesn't work, so we "navigate"
70
78
  // there using CDP if explicitly requested.
71
79
  if (allowPrivileged && Common.ParsedURL.schemeIs(url, 'chrome:')) {
@@ -28,7 +28,7 @@ export class LinkContextMenuProvider implements Provider<Node> {
28
28
  const node: Link = targetNode;
29
29
  contextMenu.revealSection().appendItem(openLinkExternallyLabel(), () => {
30
30
  if (node.href) {
31
- UIHelpers.openInNewTab(node.href);
31
+ UIHelpers.openInNewTab(node.href, node.allowPrivileged);
32
32
  }
33
33
  }, {jslogContext: 'open-in-new-tab'});
34
34
  contextMenu.revealSection().appendItem(copyLinkAddressLabel(), () => {
@@ -351,12 +351,7 @@ export interface Delegate<T> {
351
351
  commitEdit(item: T, editor: Editor<T>, isNew: boolean): void;
352
352
  }
353
353
 
354
- export interface CustomEditorControl<T> extends HTMLElement {
355
- value: T;
356
- validate: () => ValidatorResult;
357
- }
358
-
359
- export type EditorControl<T = string> = (HTMLInputElement|HTMLSelectElement|CustomEditorControl<T>);
354
+ export type EditorControl = HTMLInputElement|HTMLSelectElement;
360
355
 
361
356
  export class Editor<T> {
362
357
  element: HTMLDivElement;
@@ -364,9 +359,9 @@ export class Editor<T> {
364
359
  private commitButton: Buttons.Button.Button;
365
360
  private readonly cancelButton: Buttons.Button.Button;
366
361
  private errorMessageContainer: HTMLElement;
367
- private readonly controls: EditorControl[] = [];
362
+ private readonly controls: HTMLElement[] = [];
368
363
  private readonly controlByName = new Map<string, EditorControl>();
369
- private readonly validators: Array<(arg0: T, arg1: number, arg2: EditorControl) => ValidatorResult> = [];
364
+ private readonly validators: Array<(item: T, index: number) => ValidatorResult> = [];
370
365
  private commit: (() => void)|null = null;
371
366
  private cancel: (() => void)|null = null;
372
367
  private item: T|null = null;
@@ -429,7 +424,7 @@ export class Editor<T> {
429
424
  ARIAUtils.setLabel(input, title);
430
425
  this.controlByName.set(name, input);
431
426
  this.controls.push(input);
432
- this.validators.push(validator);
427
+ this.validators.push((item, index) => validator(item, index, input));
433
428
  return input;
434
429
  }
435
430
 
@@ -453,18 +448,19 @@ export class Editor<T> {
453
448
  select.addEventListener('blur', this.validateControls.bind(this, false), false);
454
449
  this.controlByName.set(name, select);
455
450
  this.controls.push(select);
456
- this.validators.push(validator);
451
+ this.validators.push((item, index) => validator(item, index, select));
457
452
  return select;
458
453
  }
459
454
 
460
- createCustomControl<S, U extends CustomEditorControl<S>>(
461
- name: string, ctor: {new(): U},
462
- validator: (arg0: T, arg1: number, arg2: EditorControl) => ValidatorResult): CustomEditorControl<S> {
463
- const control = new ctor();
464
- this.controlByName.set(name, control as unknown as CustomEditorControl<string>);
465
- this.controls.push(control as unknown as CustomEditorControl<string>);
455
+ /**
456
+ * Adds an existing element, for example the element of a widget, as an
457
+ * editor control. The editor marks the element as invalid when the
458
+ * validator fails. The caller keeps its own reference to the control to
459
+ * read and write its value.
460
+ */
461
+ addCustomControl(element: HTMLElement, validator: (item: T, index: number) => ValidatorResult): void {
462
+ this.controls.push(element);
466
463
  this.validators.push(validator);
467
- return control;
468
464
  }
469
465
 
470
466
  control(name: string): EditorControl {
@@ -480,7 +476,7 @@ export class Editor<T> {
480
476
  this.errorMessageContainer.textContent = '';
481
477
  for (let index = 0; index < this.controls.length; ++index) {
482
478
  const input = this.controls[index];
483
- const {valid, errorMessage} = this.validators[index].call(null, (this.item as T), this.index, input);
479
+ const {valid, errorMessage} = this.validators[index].call(null, (this.item as T), this.index);
484
480
 
485
481
  input.classList.toggle('error-input', !valid && !forceValid);
486
482
  if (valid || forceValid) {
@@ -816,7 +816,10 @@ export class TabbedPane extends TabbedPaneBase {
816
816
  if (this.tabsElement.children[i] !== tab.tabElement) {
817
817
  this.tabsElement.insertBefore(tab.tabElement, this.tabsElement.children[i] ?? null);
818
818
  }
819
- tab.shown = true;
819
+ if (!tab.shown) {
820
+ tab.shown = true;
821
+ tab.slotsAttached();
822
+ }
820
823
  }
821
824
 
822
825
  this.maybeShowDropDown(tabsToShowIndexes.length !== this.#tabs.length);
@@ -1429,13 +1432,53 @@ export class TabbedPaneTab {
1429
1432
  // next slot assignment recalc, so anything retained by the <slot> stays
1430
1433
  // alive after the tab is closed if no recalc follows.
1431
1434
  container.addEventListener('slotchange', () => {
1432
- this.#hasSlottedContent[kind] = slot.assignedElements().length > 0;
1433
- container.style.display = this.#hasSlottedContent[kind] ? '' : 'none';
1435
+ // A detached <slot> has no assigned nodes, so `slotchange` also fires
1436
+ // when the tab header is removed from the DOM (e.g. moved into the
1437
+ // overflow drop-down). That doesn't reflect a change to the slotted
1438
+ // content, so keep the current state (and the cached width) so that
1439
+ // the tab keeps measuring the same while hidden. The state is synced
1440
+ // again in `slotsAttached` once the header is re-attached.
1441
+ if (!slot.isConnected) {
1442
+ return;
1443
+ }
1444
+ this.#updateSlottedContent(kind, container, slot);
1434
1445
  delete this.measuredWidth;
1435
1446
  this.tabbedPane.requestUpdate();
1436
1447
  });
1437
1448
  }
1438
1449
 
1450
+ #updateSlottedContent(kind: 'icon'|'suffix', container: HTMLElement, slot: HTMLSlotElement): boolean {
1451
+ const hasSlottedContent = slot.assignedElements().length > 0;
1452
+ if (hasSlottedContent === this.#hasSlottedContent[kind]) {
1453
+ return false;
1454
+ }
1455
+ this.#hasSlottedContent[kind] = hasSlottedContent;
1456
+ container.style.display = hasSlottedContent ? '' : 'none';
1457
+ return true;
1458
+ }
1459
+
1460
+ /**
1461
+ * Called when the tab header is (re-)attached to the DOM. If the slotted
1462
+ * content changed while the header was detached, no `slotchange` fires
1463
+ * on re-attachment when the slot is still empty afterwards (its assigned
1464
+ * nodes were already cleared on detach), so sync the state explicitly.
1465
+ */
1466
+ slotsAttached(): void {
1467
+ let changed = false;
1468
+ for (const kind of ['icon', 'suffix'] as const) {
1469
+ const container = this.#slotContainers[kind];
1470
+ const slot = container?.querySelector('slot');
1471
+ if (container && slot?.isConnected) {
1472
+ const updated = this.#updateSlottedContent(kind, container, slot);
1473
+ changed = updated || changed;
1474
+ }
1475
+ }
1476
+ if (changed) {
1477
+ delete this.measuredWidth;
1478
+ this.tabbedPane.requestUpdate();
1479
+ }
1480
+ }
1481
+
1439
1482
  clearSlots(): void {
1440
1483
  // Detach the <slot> elements from the tab header so that Blink's
1441
1484
  // SlotAssignment cache cannot retain the tab element (and through its
@@ -1242,7 +1242,9 @@ export class TreeElement {
1242
1242
  select(omitFocus?: boolean, selectedByUser?: boolean): boolean {
1243
1243
  omitFocus = omitFocus || this.disableSelectFocus;
1244
1244
  if (!this.treeOutline || !this.selectable || this.selected) {
1245
- if (!omitFocus) {
1245
+ // An inline editor or other interactive child may already hold the focus
1246
+ // inside this row; re-selecting must not take it away from them.
1247
+ if (!omitFocus && !this.listItemElement.hasFocus()) {
1246
1248
  this.listItemElement.focus();
1247
1249
  }
1248
1250
  return false;
@@ -345,7 +345,7 @@ export function isBeingEdited(node?: Node|null): boolean {
345
345
 
346
346
  let currentElement: (Element|null)|Element = element;
347
347
  while (currentElement) {
348
- if (elementsBeingEdited.has(element)) {
348
+ if (elementsBeingEdited.has(currentElement)) {
349
349
  return true;
350
350
  }
351
351
  currentElement = currentElement.parentElementOrShadowHost();
@@ -284,6 +284,7 @@ export const knownContextValues: Set<string> = new Set([
284
284
  'accept-execute-code',
285
285
  'access-control-allow-origin',
286
286
  'accessibility-announcements.filter-by-type',
287
+ 'accessibility-announcements.resizer',
287
288
  'accessibility-default',
288
289
  'accessibility-tree',
289
290
  'accessibility.clear-announcements',
@@ -2817,6 +2818,8 @@ export const knownContextValues: Set<string> = new Set([
2817
2818
  'manage-settings',
2818
2819
  'manager-custom-headers',
2819
2820
  'manifest',
2821
+ 'manifest-id',
2822
+ 'manifest-id-start-url',
2820
2823
  'manifest.copy-id',
2821
2824
  'margin',
2822
2825
  'margin-block',
@@ -4173,6 +4176,7 @@ export const knownContextValues: Set<string> = new Set([
4173
4176
  'stylesheet',
4174
4177
  'styling',
4175
4178
  'styling-default',
4179
+ 'sub-apps',
4176
4180
  'subdomain',
4177
4181
  'subgrid',
4178
4182
  'subgrid-how',
package/package.json CHANGED
@@ -91,5 +91,5 @@
91
91
  "yargs": "18.1.0",
92
92
  "yargs-unparser": "2.0.0"
93
93
  },
94
- "version": "1.0.1721762"
94
+ "version": "1.0.1724140"
95
95
  }