chrome-devtools-frontend 1.0.1716465 → 1.0.1717196

package/front_end/core/sdk/PageResourceLoader.ts

@@ -18,6 +18,7 @@ import {
   ResourceTreeModel,
 } from './ResourceTreeModel.js';
 import {cacheDisabledSettingDescriptor, enableRemoteFileLoadingSettingDescriptor} from './SDKSettings.js';
+import {SecurityOrigin} from './SecurityOrigin.js';
 import type {Target} from './Target.js';
 import {TargetManager} from './TargetManager.js';
 
@@ -26,6 +27,17 @@ const UIStrings = {
    * @description Error message for canceled source map loads.
    */
   loadCanceledDueToReloadOf: 'Load canceled due to reload of inspected page',
+  /**
+   * @description Error message in the Developer resources panel when DevTools refuses to load a
+   * resource (e.g. a source map) for a frame that is no longer available and is cross-origin with
+   * the page.
+   */
+  crossOriginFrameLoadBlocked: 'Can’t load resource for an unavailable cross-origin frame',
+  /**
+   * @description Error message in the Developer resources panel when an http(s) resource cannot be
+   * loaded because no target is available.
+   */
+  noTargetForHttpLoad: 'Can’t load http(s) resource without a target',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/PageResourceLoader.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -280,20 +292,34 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
     if (isExtensionInitiator(initiator)) {
       throw new Error('Invalid initiator');
     }
-    const key = PageResourceLoader.makeKey(url, initiator);
+    const hasExplicitTarget = Boolean(initiator.target);
+    // Fall back to the primary page target when the initiator has no explicit target
+    // so that resources loaded for detached frames remain scoped to the primary page
+    // and go through target-based CSP checks instead of host bindings.
+    let effectiveInitiator: PageResourceLoadInitiator = initiator;
+    if (!initiator.target) {
+      const primaryTarget = this.#targetManager.primaryPageTarget();
+      if (primaryTarget) {
+        effectiveInitiator = {
+          ...initiator,
+          target: primaryTarget,
+        };
+      }
+    }
+    const key = PageResourceLoader.makeKey(url, effectiveInitiator);
     const pageResource: PageResource = {
       success: null,
       size: null,
       duration: null,
       url,
-      initiator,
+      initiator: effectiveInitiator,
     };
     this.#pageResources.set(key, pageResource);
     this.dispatchEventToListeners(Events.UPDATE);
     const startTime = performance.now();
     try {
-      await this.acquireLoadSlot(initiator.target);
-      const resultPromise = this.dispatchLoad(url, initiator, isBinary);
+      await this.acquireLoadSlot(effectiveInitiator.target);
+      const resultPromise = this.dispatchLoad(url, effectiveInitiator, isBinary, hasExplicitTarget);
       const result = await resultPromise;
       pageResource.errorMessage = result.errorDescription.message;
       pageResource.success = result.success;
@@ -312,7 +338,7 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       throw e;
     } finally {
       pageResource.duration = performance.now() - startTime;
-      this.releaseLoadSlot(initiator.target);
+      this.releaseLoadSlot(effectiveInitiator.target);
       this.dispatchEventToListeners(Events.UPDATE);
     }
   }
@@ -320,6 +346,8 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
   #resolveFrameTarget(initiator: PageResourceLoadInitiator): {
     frameTarget: Target|null,
     frameId: Protocol.Page.FrameId|null,
+    initiatorFrameId: Protocol.Page.FrameId|null,
+    usedFallbackMainFrame: boolean,
   } {
     let frameTarget: Target|null = initiator.target;
     let parentFrameId: Protocol.Page.FrameId|null = null;
@@ -327,21 +355,88 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       parentFrameId = parentFrameId ?? frameTarget.targetInfo()?.parentFrameId ?? null;
       frameTarget = frameTarget.parentTarget();
     }
-    const frameId = initiator.frameId ?? parentFrameId ?? frameTarget?.model(ResourceTreeModel)?.mainFrame?.id ?? null;
-    return {frameTarget, frameId};
+    const resourceTreeModel = frameTarget?.model(ResourceTreeModel);
+    const mainFrameId = resourceTreeModel?.mainFrame?.id ?? null;
+
+    // Normalize empty-string frame IDs (used by ScriptsHandler for unassociated scripts)
+    // to null and fall back to the parent frame ID discovered from a worker or subtarget.
+    let candidateFrameId: Protocol.Page.FrameId|null = null;
+    if (initiator.frameId) {
+      candidateFrameId = initiator.frameId;
+    } else if (parentFrameId) {
+      candidateFrameId = parentFrameId;
+    }
+
+    if (frameTarget && frameTarget !== initiator.target && !candidateFrameId) {
+      // The initiator is a non-frame target (e.g. a service worker or a shared worker) that is not
+      // owned by any single frame. Don't attribute the load to the page's main frame, as the browser
+      // would then issue the request with the main frame's origin and credentials. Load through the
+      // initiator's own target instead, where the browser attributes the request to the worker's origin.
+      return {frameTarget: initiator.target, frameId: null, initiatorFrameId: null, usedFallbackMainFrame: false};
+    }
+
+    // Keep candidateFrameId only if ResourceTreeModel has not populated frames yet
+    // (mainFrame is null) or if candidateFrameId still exists in the active frame tree.
+    let validFrameId: Protocol.Page.FrameId|null = null;
+    if (candidateFrameId) {
+      if (!resourceTreeModel?.mainFrame || resourceTreeModel.frameForId(candidateFrameId)) {
+        validFrameId = candidateFrameId;
+      }
+    }
+
+    // Track whether we had to fall back to the main frame because the initiator's
+    // frame was missing or detached, so dispatchLoad can verify same-origin before
+    // issuing a network load in the main frame's context.
+    let usedFallbackMainFrame = false;
+    if (!validFrameId && mainFrameId) {
+      usedFallbackMainFrame = true;
+    }
+
+    // Use the validated frame ID if available; otherwise fall back to the main frame ID
+    // so that CDP's Network.loadNetworkResource and getSecurityIsolationStatus can
+    // enforce the page's CSP even after the original frame was detached.
+    const frameId = validFrameId ?? mainFrameId;
+    // Preserve the candidate frame ID (before mainFrameId fallback) so
+    // #isSameOriginWithPrimaryPage can detect detached or unassociated frames and
+    // disallow host-bindings fallback.
+    return {frameTarget, frameId, initiatorFrameId: candidateFrameId, usedFallbackMainFrame};
   }
 
-  #isSameOriginWithPrimaryPage(frameTarget: Target|null, frameId: Protocol.Page.FrameId|null): boolean {
+  #isSameOriginWithPrimaryPage(
+      hasExplicitTarget: boolean,
+      frameTarget: Target|null,
+      initiatorFrameId: Protocol.Page.FrameId|null,
+      ): boolean {
+    // Disallow host-bindings fallback when the initiator had no explicit target.
+    if (!hasExplicitTarget) {
+      return false;
+    }
     const primaryFrame = this.#targetManager.primaryPageTarget()?.model(ResourceTreeModel)?.mainFrame;
-    const initiatorFrame = frameId ? frameTarget?.model(ResourceTreeModel)?.frameForId(frameId) : null;
+    // Look up the original initiator frame in frameTarget's active frame tree; if the frame
+    // was detached, frameForId returns null and we fail closed below.
+    const initiatorFrame =
+        initiatorFrameId ? frameTarget?.model(ResourceTreeModel)?.frameForId(initiatorFrameId) : null;
     if (!primaryFrame || !initiatorFrame) {
       return false;
     }
     return initiatorFrame.securityOrigin().isSameOriginWith(primaryFrame.securityOrigin());
   }
 
-  private async dispatchLoad(
-      url: Platform.DevToolsPath.UrlString, initiator: PageResourceLoadInitiator, isBinary: boolean): Promise<{
+  #isInitiatorUrlSameOriginWithMainFrame(
+      initiator: PageResourceLoadInitiator,
+      frameTarget: Target|null,
+      ): boolean {
+    const mainFrame = frameTarget?.model(ResourceTreeModel)?.mainFrame;
+    if (!mainFrame || !initiator.initiatorUrl) {
+      return false;
+    }
+    // Compare the target main frame's security origin against the initiator script's URL origin
+    // to ensure cross-origin detached frame requests are not loaded under mainFrame.id.
+    return mainFrame.securityOrigin().isSameOriginWith(SecurityOrigin.create(initiator.initiatorUrl));
+  }
+
+  private async dispatchLoad(url: Platform.DevToolsPath.UrlString, initiator: PageResourceLoadInitiator,
+                             isBinary: boolean, hasExplicitTarget: boolean): Promise<{
     success: boolean,
     content: string|Uint8Array<ArrayBuffer>,
     errorDescription: Host.ResourceLoader.LoadErrorDescription,
@@ -355,18 +450,32 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       return await this.#loadOverride(url);
     }
     const parsedURL = new Common.ParsedURL.ParsedURL(url);
-    const eligibleForLoadFromTarget = this.getLoadThroughTargetSetting().get() && parsedURL &&
-        parsedURL.scheme !== 'file' && parsedURL.scheme !== 'data' && parsedURL.scheme !== 'devtools' &&
-        initiator.target;
+    const isHttp = Boolean(parsedURL && (parsedURL.scheme === 'http' || parsedURL.scheme === 'https'));
+    const loadThroughTarget = this.getLoadThroughTargetSetting().get();
+    const eligibleForLoadFromTarget =
+        Boolean(loadThroughTarget && parsedURL && parsedURL.scheme !== 'file' && parsedURL.scheme !== 'data' &&
+                parsedURL.scheme !== 'devtools' && initiator.target);
     Host.userMetrics.developerResourceScheme(this.getDeveloperResourceScheme(parsedURL));
-    if (eligibleForLoadFromTarget) {
-      const isHttp = parsedURL.scheme === 'http' || parsedURL.scheme === 'https';
+    if (eligibleForLoadFromTarget && initiator.target) {
       // Default to enforcing CSP for http(s) resources (fail-closed). Only relax
       // if the isolation-status query positively confirms no connect-src/default-src
       // directive is present. A null/error response keeps the guard armed so that a
       // detached-frame or protocol-error path cannot fall through to loadFromHostBindings.
       let mustEnforceCSP = isHttp;
-      const {frameTarget, frameId} = this.#resolveFrameTarget(initiator);
+      const {frameTarget, frameId, initiatorFrameId, usedFallbackMainFrame} = this.#resolveFrameTarget(initiator);
+      // Do not execute network loads under mainFrame.id (which uses the main frame's origin,
+      // cookies, and CSP) if a detached frame's initiatorUrl is cross-origin with the main frame.
+      if (usedFallbackMainFrame && !this.#isInitiatorUrlSameOriginWithMainFrame(initiator, frameTarget)) {
+        Host.userMetrics.developerResourceLoaded(Host.UserMetrics.DeveloperResourceLoaded.LOAD_THROUGH_PAGE_FAILURE);
+        return {
+          success: false,
+          content: '',
+          errorDescription: {
+            statusCode: 0,
+            message: i18nString(UIStrings.crossOriginFrameLoadBlocked),
+          },
+        };
+      }
       if (isHttp && frameTarget) {
         const networkManager = frameTarget.model(NetworkManager);
         if (networkManager) {
@@ -385,7 +494,7 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       } catch (e) {
         if (e instanceof Error) {
           Host.userMetrics.developerResourceLoaded(Host.UserMetrics.DeveloperResourceLoaded.LOAD_THROUGH_PAGE_FAILURE);
-          if (mustEnforceCSP || !this.#isSameOriginWithPrimaryPage(frameTarget, frameId) ||
+          if (mustEnforceCSP || !this.#isSameOriginWithPrimaryPage(hasExplicitTarget, frameTarget, initiatorFrameId) ||
               e.message.includes('CSP violation')) {
             return {
               success: false,
@@ -400,10 +509,21 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       }
       Host.userMetrics.developerResourceLoaded(Host.UserMetrics.DeveloperResourceLoaded.LOAD_THROUGH_PAGE_FALLBACK);
     } else {
-      const code = this.getLoadThroughTargetSetting().get() ?
-          Host.UserMetrics.DeveloperResourceLoaded.FALLBACK_PER_PROTOCOL :
-          Host.UserMetrics.DeveloperResourceLoaded.FALLBACK_PER_OVERRIDE;
+      const code = loadThroughTarget ? Host.UserMetrics.DeveloperResourceLoaded.FALLBACK_PER_PROTOCOL :
+                                       Host.UserMetrics.DeveloperResourceLoaded.FALLBACK_PER_OVERRIDE;
       Host.userMetrics.developerResourceLoaded(code);
+      // Fail closed for HTTP(S) loads when target-based loading is enabled but no target is available,
+      // preventing unauthenticated fallback to privileged host bindings.
+      if (loadThroughTarget && isHttp && !initiator.target) {
+        return {
+          success: false,
+          content: '',
+          errorDescription: {
+            statusCode: 0,
+            message: i18nString(UIStrings.noTargetForHttpLoad),
+          },
+        };
+      }
     }
 
     const result = await this.loadFromHostBindings(url);

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -32,6 +32,7 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
   #pendingReloadOptions: {
     ignoreCache: (boolean|undefined),
     scriptToEvaluateOnLoad: (string|undefined),
+    loaderId: Protocol.Network.LoaderId,
   }|null = null;
   #reloadSuspensionCount = 0;
   isInterstitialShowing = false;
@@ -209,6 +210,11 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
   }
 
   frameNavigated(framePayload: Protocol.Page.Frame, type: Protocol.Page.NavigationType|undefined): void {
+    this.#frameNavigated(framePayload, type, /* isDocumentOpened */ false);
+  }
+
+  #frameNavigated(framePayload: Protocol.Page.Frame, type: Protocol.Page.NavigationType|undefined,
+                  isDocumentOpened: boolean): void {
     const sameTargetParentFrame =
         framePayload.parentId ? (this.framesInternal.get(framePayload.parentId) || null) : null;
     // Do nothing unless cached resource tree is processed - it will overwrite everything.
@@ -245,6 +251,23 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
       this.dispatchEventToListeners(Events.ResourceAdded, resources[i]);
     }
 
+    // The document resource is normally added once the Network domain reports
+    // the document request as finished. Clients that run without the Network
+    // domain never get it, so inline scripts and styles can't be mapped to the
+    // document. Unless the request is still in flight, add the document
+    // resource right away, like `addFramesRecursively()` does for loaded frames.
+    // Documents created by `document.open()` have no request of their own and
+    // their content is not available.
+    const networkManager = this.target().model(NetworkManager);
+    if (!frame.getResourcesMap().get(framePayload.url as Platform.DevToolsPath.UrlString) &&
+        (isDocumentOpened || !networkManager?.requestForLoaderId(framePayload.loaderId))) {
+      const frameResource = this.createResourceFromFramePayload(
+          framePayload, framePayload.url as Platform.DevToolsPath.UrlString, Common.ResourceType.resourceTypes.Document,
+          framePayload.mimeType, null, null);
+      frameResource.isGenerated = isDocumentOpened;
+      frame.addResource(frameResource);
+    }
+
     this.updateSecurityOrigins();
     void this.updateStorageKeys();
 
@@ -265,17 +288,10 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
   }
 
   documentOpened(framePayload: Protocol.Page.Frame): void {
-    this.frameNavigated(framePayload, undefined);
+    this.#frameNavigated(framePayload, undefined, /* isDocumentOpened */ true);
     const frame = this.framesInternal.get(framePayload.id);
     if (frame) {
       this.dispatchEventToListeners(Events.DocumentOpened, frame);
-      if (!frame.getResourcesMap().get(framePayload.url)) {
-        const frameResource = this.createResourceFromFramePayload(
-            framePayload, framePayload.url as Platform.DevToolsPath.UrlString,
-            Common.ResourceType.resourceTypes.Document, framePayload.mimeType, null, null);
-        frameResource.isGenerated = true;
-        frame.addResource(frameResource);
-      }
     }
   }
 
@@ -434,7 +450,15 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
     this.#reloadSuspensionCount--;
     console.assert(this.#reloadSuspensionCount >= 0, 'Unbalanced call to ResourceTreeModel.resumeReload()');
     if (!this.#reloadSuspensionCount && this.#pendingReloadOptions) {
-      const {ignoreCache, scriptToEvaluateOnLoad} = this.#pendingReloadOptions;
+      const {ignoreCache, scriptToEvaluateOnLoad, loaderId} = this.#pendingReloadOptions;
+      // A deferred reload (and its scriptToEvaluateOnLoad) only applies to the
+      // document it was requested against. If the main frame has since
+      // navigated to another document, drop the stale request instead of
+      // replaying it against the new document.
+      if (loaderId !== this.mainFrame?.loaderId) {
+        this.#pendingReloadOptions = null;
+        return;
+      }
       this.reloadPage(ignoreCache, scriptToEvaluateOnLoad);
     }
   }
@@ -449,7 +473,7 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
       this.dispatchEventToListeners(Events.PageReloadRequested, this);
     }
     if (this.#reloadSuspensionCount) {
-      this.#pendingReloadOptions = {ignoreCache, scriptToEvaluateOnLoad};
+      this.#pendingReloadOptions = {ignoreCache, scriptToEvaluateOnLoad, loaderId};
       return;
     }
     this.#pendingReloadOptions = null;

package/front_end/generated/Deprecation.ts

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // This file is auto-generated, do not edit manually.
-// Re-generate with: npm run generate-protocol-resources
+// Re-generate with: scripts/tools/dt.py generate-protocol-resources
 
 export const UIStrings = {
   /**

package/front_end/generated/InspectorBackendCommands.ts

@@ -1180,6 +1180,7 @@ inspectorBackend.registerCommand("Page.waitForDebugger", [], [], "Pauses page ex
 inspectorBackend.registerCommand("Page.setInterceptFileChooserDialog", [{"name": "enabled", "type": "boolean", "optional": false, "description": "", "typeRef": null}, {"name": "cancel", "type": "boolean", "optional": true, "description": "If true, cancels the dialog by emitting relevant events (if any) in addition to not showing it if the interception is enabled (default: false).", "typeRef": null}], [], "Intercept file chooser requests and transfer control to protocol clients. When file chooser interception is enabled, native file chooser dialog is not shown. Instead, a protocol event `Page.fileChooserOpened` is emitted.");
 inspectorBackend.registerCommand("Page.setPrerenderingAllowed", [{"name": "isAllowed", "type": "boolean", "optional": false, "description": "", "typeRef": null}], [], "Enable/disable prerendering manually.  This command is a short-term solution for https://crbug.com/1440085. See https://docs.google.com/document/d/12HVmFxYj5Jc-eJr5OmWsa2bqTJsbgGLKI6ZIyx0_wpA for more details.  TODO(https://crbug.com/1440085): Remove this once Puppeteer supports tab targets.");
 inspectorBackend.registerCommand("Page.getAnnotatedPageContent", [{"name": "includeActionableInformation", "type": "boolean", "optional": true, "description": "Whether to include actionable information. Defaults to true.", "typeRef": null}], ["content"], "Get the annotated page content for the main frame. This is an experimental command that is subject to change.");
+inspectorBackend.registerCommand("Page.setInputVisualization", [{"name": "clicks", "type": "boolean", "optional": true, "description": "Whether to enable click visualization.", "typeRef": null}], [], "Configures input visualization on the page.");
 inspectorBackend.registerType("Page.AdFrameStatus", [{"name": "adFrameType", "type": "string", "optional": false, "description": "", "typeRef": "Page.AdFrameType"}, {"name": "explanations", "type": "array", "optional": true, "description": "", "typeRef": "Page.AdFrameExplanation"}]);
 inspectorBackend.registerType("Page.PermissionsPolicyBlockLocator", [{"name": "frameId", "type": "string", "optional": false, "description": "", "typeRef": "Page.FrameId"}, {"name": "blockReason", "type": "string", "optional": false, "description": "", "typeRef": "Page.PermissionsPolicyBlockReason"}]);
 inspectorBackend.registerType("Page.PermissionsPolicyFeatureState", [{"name": "feature", "type": "string", "optional": false, "description": "", "typeRef": "Page.PermissionsPolicyFeature"}, {"name": "allowed", "type": "boolean", "optional": false, "description": "", "typeRef": null}, {"name": "locator", "type": "object", "optional": true, "description": "", "typeRef": "Page.PermissionsPolicyBlockLocator"}]);

package/front_end/generated/protocol-mapping.d.ts

@@ -4,7 +4,7 @@
 
 /**
  * This file is auto-generated, do not edit manually. *
- * Re-generate with: npm run generate-protocol-resources.
+ * Re-generate with: scripts/tools/dt.py generate-protocol-resources.
  */
 
 
@@ -4582,6 +4582,13 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Page.GetAnnotatedPageContentRequest?];
       returnType: Protocol.Page.GetAnnotatedPageContentResponse;
     };
+    /**
+     * Configures input visualization on the page.
+     */
+    'Page.setInputVisualization': {
+      paramsType: [Protocol.Page.SetInputVisualizationRequest?];
+      returnType: void;
+    };
     /**
      * Disable collecting and reporting metrics.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -4,7 +4,7 @@
 
 /**
  * This file is auto-generated, do not edit manually. *
- * Re-generate with: npm run generate-protocol-resources.
+ * Re-generate with: scripts/tools/dt.py generate-protocol-resources.
  */
 
 
@@ -2258,6 +2258,7 @@ declare namespace ProtocolProxyApi {
 
     /**
      * Return UUID of Blob object specified by a remote object id.
+     * @deprecated
      */
     invoke_resolveBlob(params: Protocol.IO.ResolveBlobRequest): Promise<Protocol.IO.ResolveBlobResponse>;
 
@@ -3688,6 +3689,11 @@ declare namespace ProtocolProxyApi {
      */
     invoke_getAnnotatedPageContent(params: Protocol.Page.GetAnnotatedPageContentRequest): Promise<Protocol.Page.GetAnnotatedPageContentResponse>;
 
+    /**
+     * Configures input visualization on the page.
+     */
+    invoke_setInputVisualization(params: Protocol.Page.SetInputVisualizationRequest): Promise<Protocol.ProtocolResponseWithError>;
+
   }
   export interface PageDispatcher {
     domContentEventFired(params: Protocol.Page.DomContentEventFiredEvent): void;

package/front_end/generated/protocol.ts

@@ -4,7 +4,7 @@
 
 /**
  * This file is auto-generated, do not edit manually. *
- * Re-generate with: npm run generate-protocol-resources.
+ * Re-generate with: scripts/tools/dt.py generate-protocol-resources.
  */
 
 
@@ -16683,6 +16683,13 @@ export namespace Page {
     content: binary;
   }
 
+  export interface SetInputVisualizationRequest {
+    /**
+     * Whether to enable click visualization.
+     */
+    clicks?: boolean;
+  }
+
   export interface DomContentEventFiredEvent {
     timestamp: Network.MonotonicTime;
   }

package/front_end/models/ai_assistance/README.md

@@ -120,10 +120,10 @@ Once it's working, it's a good idea to manually experiment with the new Insight
 
 ## Debugging & Local Development
 
-To test the AI code, you must be running DevTools in a branded Chrome (e.g. official Chrome Canary) and be signed in. You can use the `npm start` with a canary flag in this repository to run against Chromium, or by running Chrome Canary and pointing it to your local DevTools:
+To test the AI code, you must be running DevTools in a branded Chrome (e.g. official Chrome Canary) and be signed in. You can use the `./dt start` command with a canary flag in this repository to run against Chromium, or by running Chrome Canary and pointing it to your local DevTools:
 
 ```
-npm start -- --browser=canary
+./dt start --browser=canary
 ```
 
 or

package/front_end/models/ai_assistance/agents/NetworkAgent.snapshot.txt

@@ -10,7 +10,7 @@ Content:
       },
       {
         "title": "Response",
-        "text": "Response headers:\ncontent-type: bar2\nx-forwarded-for: bar3\n\nResponse body:\n{\"request\":\"body\"}\n\nResponse status: 200\nNetwork request status: pending\n"
+        "text": "Response headers:\ncontent-type: bar2\nx-forwarded-for: bar3\n\nResponse body:\n{\"request\":\"body\"}\n\nResponse status: 200\nNetwork request status: finished\n"
       },
       {
         "title": "Timing",
@@ -59,7 +59,7 @@ Content:
   {
     "parts": [
       {
-        "text": "# Selected network request\nRequest: https://www.example.com\nRequest headers:\ncontent-type: bar1\n\nResponse headers:\ncontent-type: bar2\nx-forwarded-for: bar3\n\nResponse body:\n{\"request\":\"body\"}\n\nResponse status: 200\nNetwork request status: pending\n\nRequest timing:\nQueued at (timestamp): 0 s\nStarted at (timestamp): 501 s\nQueueing (duration): 501 s\nConnection start (stalled) (duration): 800 ms\nRequest sent (duration): 100 ms\nDuration (duration): 501 s\n\nRequest initiator chain:\n- URL: <redacted cross-origin initiator URL>\n\t- URL: https://www.example.com\n\t\t- URL: https://www.example.com/1\n\t\t- URL: https://www.example.com/2\n\n# User request\n\ntest"
+        "text": "# Selected network request\nRequest: https://www.example.com\nRequest headers:\ncontent-type: bar1\n\nResponse headers:\ncontent-type: bar2\nx-forwarded-for: bar3\n\nResponse body:\n{\"request\":\"body\"}\n\nResponse status: 200\nNetwork request status: finished\n\nRequest timing:\nQueued at (timestamp): 0 s\nStarted at (timestamp): 501 s\nQueueing (duration): 501 s\nConnection start (stalled) (duration): 800 ms\nRequest sent (duration): 100 ms\nDuration (duration): 501 s\n\nRequest initiator chain:\n- URL: <redacted cross-origin initiator URL>\n\t- URL: https://www.example.com\n\t\t- URL: https://www.example.com/1\n\t\t- URL: https://www.example.com/2\n\n# User request\n\ntest"
       }
     ],
     "role": 1

package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt

@@ -78,7 +78,7 @@ Content:
         "properties": {
           "code": {
             "type": 1,
-            "description": "JavaScript code snippet to run on the inspected page. Make sure the code is formatted for readability.\n\n# Instructions\n\n* To return data, define a top-level `data` variable and populate it with data you want to get. Only JSON-serializable objects can be assigned to `data`.\n* $0 refers to the currently selected DOM node (or document body if none selected).\n* **CRITICAL** Never assume a selector for the elements unless you verified your knowledge.\n* **CRITICAL** Variables from previous function calls are not available in subsequent calls.\n* **CRITICAL** Keep code concise (max 40 lines and 2,500 characters). Split complex logic into multiple steps.\n* **CRITICAL** Network requests (e.g., fetch, XMLHttpRequest) are disabled and cannot be made.\n\nFor example, to query DOM elements:\n\n```\nconst data = {\n  title: document.title,\n  elementText: $0?.textContent?.trim(),\n  childCount: $0?.children.length,\n};\n```\n"
+            "description": "JavaScript code snippet to run on the inspected page. Make sure the code is formatted for readability.\n\n# Instructions\n\n* To return data, define a top-level `data` variable and populate it with data you want to get. Only JSON-serializable objects can be assigned to `data`.\n* $0 refers to the currently selected DOM node (or document body if none selected).\n* **CRITICAL** Never assume a selector for the elements unless you verified your knowledge.\n* **CRITICAL** Variables from previous function calls are not available in subsequent calls.\n* **CRITICAL** Keep code concise (max 40 lines, 120 characters per line, and 2,500 characters). Split complex logic into multiple steps.\n* **CRITICAL** Network requests (e.g., fetch, XMLHttpRequest) are disabled and cannot be made.\n\nFor example, to query DOM elements:\n\n```\nconst data = {\n  title: document.title,\n  elementText: $0?.textContent?.trim(),\n  childCount: $0?.children.length,\n};\n```\n"
           },
           "explanation": {
             "type": 1,

package/front_end/models/ai_assistance/contexts/RequestContext.snapshot.txt

@@ -12,7 +12,7 @@ Response body:
 {}
 
 Response status: 200
-Network request status: pending
+Network request status: finished
 
 Request timing:
 Queued at (timestamp): 0 s
@@ -33,7 +33,7 @@ Content:
   },
   {
     "title": "Response",
-    "text": "Response headers:\nContent-Type: application/json\n\nResponse body:\n{}\n\nResponse status: 200\nNetwork request status: pending\n"
+    "text": "Response headers:\nContent-Type: application/json\n\nResponse body:\n{}\n\nResponse status: 200\nNetwork request status: finished\n"
   },
   {
     "title": "Timing",

package/front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -98,6 +98,13 @@ export class NetworkRequestFormatter {
 
   static async formatBody(title: string, request: SDK.NetworkRequest.NetworkRequest, maxBodySize: number):
       Promise<string> {
+    // requestContentData() waits until the request finishes. Some requests
+    // never finish: Chrome does not send loadingFinished for a
+    // `Cache-Control: no-store` fetch() whose body the page never reads.
+    if (!request.finished) {
+      return `${title}\n<not available: the request has not finished loading>`;
+    }
+
     const data = await request.requestContentData();
 
     if (TextUtils.ContentData.ContentData.isError(data)) {

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts

@@ -472,8 +472,9 @@ export class PerformanceTraceFormatter {
       description: this.#getSerializeBottomUpRootNodeFormat(limit),
       empty: 'no activity',
       cb: async insightSet => {
+        const navigationId = Trace.Helpers.Trace.navigationIDForEvent(insightSet.navigation);
         const rootNode = AIQueries.mainThreadActivityBottomUpSingleNavigation(
-            insightSet.navigation?.args.data?.navigationId,
+            navigationId,
             insightSet.bounds,
             parsedTrace,
         );
@@ -519,8 +520,8 @@ export class PerformanceTraceFormatter {
       title: 'Longest tasks',
       empty: 'none',
       cb: async insightSet => {
-        const longestTaskTrees =
-            AIQueries.longestTasks(insightSet.navigation?.args.data?.navigationId, insightSet.bounds, parsedTrace, 3);
+        const navigationId = Trace.Helpers.Trace.navigationIDForEvent(insightSet.navigation);
+        const longestTaskTrees = AIQueries.longestTasks(navigationId, insightSet.bounds, parsedTrace, 3);
         if (!longestTaskTrees?.length) {
           return null;
         }
@@ -585,7 +586,7 @@ export class PerformanceTraceFormatter {
     if (Trace.Types.Events.isSyntheticNetworkRequest(event)) {
       const safeUrl = filteredUrl(event, this.#parsedTrace);
       if (safeUrl !== event.args.data.url) {
-        return Trace.Name.forEntry({
+        const syntheticEvent: Trace.Types.Events.SyntheticNetworkRequest = {
           ...event,
           args: {
             ...event.args,
@@ -594,7 +595,8 @@ export class PerformanceTraceFormatter {
               url: safeUrl,
             },
           },
-        });
+        };
+        return Trace.Name.forEntry(syntheticEvent);
       }
     }
     return Trace.Name.forEntry(event);
@@ -609,8 +611,9 @@ export class PerformanceTraceFormatter {
 
     const insightSet = this.#parsedTrace.insights?.values().find(
         insightSet => Trace.Helpers.Timing.boundsIncludeTimeRange({bounds, timeRange: insightSet.bounds}));
+    const navigationId = Trace.Helpers.Trace.navigationIDForEvent(insightSet?.navigation);
     const topDownTree = AIQueries.mainThreadActivityTopDown(
-        insightSet?.navigation?.args.data?.navigationId,
+        navigationId,
         bounds,
         this.#parsedTrace,
     );

package/front_end/models/ai_assistance/performance/AIQueries.ts

@@ -89,7 +89,8 @@ export class AIQueries {
     const threads: Trace.Handlers.Threads.ThreadData[] = [];
     if (parsedTrace.insights) {
       for (const insightSet of parsedTrace.insights?.values()) {
-        const thread = this.findMainThread(insightSet.navigation?.args.data?.navigationId, parsedTrace);
+        const navigationId = Trace.Helpers.Trace.navigationIDForEvent(insightSet.navigation);
+        const thread = this.findMainThread(navigationId, parsedTrace);
         if (thread) {
           threads.push(thread);
         }