chrome-devtools-frontend 1.0.1711155 → 1.0.1715126

package/.agents/skills/code-review/SKILL.md

@@ -10,17 +10,21 @@ Use it for self-review before upload and for reviewing other people's CLs.
 
 ## 1. Gather context
 
-- **Local change:** `git diff origin/main...HEAD` (or `git show HEAD` for a
-  single-commit branch). To learn about the branch and upload workflow, see the
-  `devtools-version-control` skill.
-- **Gerrit CL:** strip the leading `)]}'` line from each response to get JSON:
-  - Diff: `git cl diff` (for the current branch), or fetch the patch set.
-  - Inline comments:
-    `curl -s https://chromium-review.googlesource.com/changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/comments | tail -n +2`
-  - Messages:
-    `.../changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/messages`
-- Read the CL description first. Then check that the diff does what the
-  description says, and nothing else.
+- **Automated Review Agent (diff already in prompt):** Do not run shell
+  commands. Use `read_file` to inspect enclosing classes/functions/tests and
+  `search_files` to verify callers or conventions across the repository.
+- **Local CLI / Interactive session (no diff in prompt):**
+  - **Local change:** `git diff origin/main...HEAD` (or `git show HEAD` for a
+    single-commit branch). To learn about the branch and upload workflow, see the
+    `devtools-version-control` skill.
+  - **Gerrit CL:** strip the leading `)]}'` line from each response to get JSON:
+    - Diff: `git cl diff` (for the current branch), or fetch the patch set.
+    - Inline comments:
+      `curl -s https://chromium-review.googlesource.com/changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/comments | tail -n +2`
+    - Messages:
+      `.../changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/messages`
+  - Read the CL description first. Then check that the diff does what the
+    description says, and nothing else.
 
 ## 2. Consult the specialized skills
 
@@ -29,7 +33,7 @@ Load the skill that matches what the diff touches, and apply its rules:
 | If the diff touches… | Use skill |
 | :--- | :--- |
 | Any `import` statement, or a new cross-module dependency | `devtools-imports` |
-| `UI.Widget`, lit-html views, components, CSS | `devtools-ui-widgets` |
+| `UI.Widget`, lit-html views, components, CSS | `ui-widgets` |
 | Migration of legacy imperative DOM to widgets or Lit | `ui-eng-vision-orchestrator` (and its sub-skills) |
 | New or changed tests: choosing unit, API, or E2E | `devtools-testing-guidance` |
 | Tests that use `describeWithEnvironment` or `describeWithMockConnection`, or foundation modules | `foundation-test-migration` |

package/AUTHORS

@@ -53,6 +53,7 @@ Han Xu <suyanhanx@gmail.com>
 Helmut Januschka <helmut@januschka.com>
 Henry Lim <henry@limhenry.xyz>
 Hojeong Park <parkhj062@gmail.com>
+Hubert Gajewski <hubert@hubertgajewski.com>
 Ivan Akulov <gxoptg@gmail.com>
 Jacky Hu <flameddd@gmail.com>
 Jake Mulhern <mulherje@gmail.com>
@@ -108,6 +109,7 @@ Sergio Avalos <sergio.avalos@gmail.com>
 Shelley Vohr <shelley.vohr@gmail.com>
 Simon Siefke <simon.siefke@gmail.com>
 Stephen Tsoi-A-Sue <stsoiasue@gmail.com>
+Steve Harrison <steve@steveharrison.dev>
 Sunnylost <sunnylost@gmail.com>
 Suyoung Jung <tdhitbtd@gmail.com>
 TaegeonKim <aksen5240@gmail.com>

package/DIR_METADATA

@@ -2,3 +2,35 @@ team_email: "devtools-dev@chromium.org"
 buganizer_public: {
   component_id: 1457055
 }
+agentic_review: {
+  capability_groups: {
+    review_capability_skills: [".agents/skills/code-review/SKILL.md"]
+  }
+  capability_groups: {
+    path_expression: ["front_end/.*\\.ts", ".*BUILD\\.gn", ".*\\.gni"]
+    path_expression_exclusion: [".*\\.test\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/devtools-imports/SKILL.md",
+      ".agents/skills/devtools-model-management/SKILL.md",
+      ".agents/skills/devtools-setting-migration/SKILL.md",
+      ".agents/skills/devtools-unicode-escaping/SKILL.md",
+      ".agents/skills/devtools-ux-writing-refactor/SKILL.md"
+    ]
+  }
+  capability_groups: {
+    path_expression: ["front_end/(panels|ui)/.*\\.(ts|css)"]
+    path_expression_exclusion: [".*\\.test\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/ui-widgets/SKILL.md",
+      ".agents/skills/ui-eng-vision-orchestrator/SKILL.md"
+    ]
+  }
+  capability_groups: {
+    path_expression: [".*\\.test\\.ts", "test/.*\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/devtools-testing-guidance/SKILL.md",
+      ".agents/skills/foundation-test-migration/SKILL.md",
+      ".agents/skills/fix-tests/SKILL.md"
+    ]
+  }
+}

package/eslint.config.mjs

@@ -375,6 +375,7 @@ export default defineConfig([
         'error',
         {
           argsIgnorePattern: '^_',
+          ignoreUsingDeclarations: true,
         },
       ],
 

package/front_end/core/sdk/CSSPropertyParserMatchers.ts

@@ -85,7 +85,10 @@ export class BaseVariableMatcher extends BaseVariableMatcherBase {
       return null;
     }
     const nameNode = args[0][0];
-    const fallback = args.length === 2 ? args[1] : undefined;
+    // Skip the first comma and closing parenthesis, preserving commas in the fallback.
+    const fallback = args.length > 1 ?
+        Array.from(ASTUtils.stripComments(ASTUtils.siblings(nameNode.nextSibling))).slice(1, -1) :
+        undefined;
 
     if (!isVariableNameNode(nameNode, matching.ast)) {
       return null;

package/front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -19,11 +19,11 @@ const UIStrings = {
   /**
    * @description Error message for when a CSS file can't be loaded.
    */
-  couldNotFindTheOriginalStyle: 'Could not find the original style sheet',
+  couldNotFindTheOriginalStyle: 'Couldn’t find the original style sheet',
   /**
    * @description Error message to display when a source CSS file could not be retrieved.
    */
-  couldNotRetrieveSourceStyles: 'Could not retrieve source styles',
+  couldNotRetrieveSourceStyles: 'Couldn’t retrieve source styles',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CSSStyleSheetHeader.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

package/front_end/core/sdk/CompilerSourceMappingContentProvider.ts

@@ -15,7 +15,7 @@ const UIStrings = {
    * @example {https://example.com/sourcemap.map} PH1
    * @example {An error occurred} PH2
    */
-  couldNotLoadContentForSS: 'Could not load content for {PH1} ({PH2})',
+  couldNotLoadContentForSS: 'Couldn’t load content for {PH1} ({PH2})',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CompilerSourceMappingContentProvider.ts', UIStrings);

package/front_end/core/sdk/DebuggerModel.ts

@@ -134,10 +134,14 @@ export const enum StepMode {
   STEP_OVER = 'StepOver',
 }
 
-/** A CDP step command. `ranges` is passed as `skipList` to stepInto/stepOver, and ignored for stepOut. */
+/**
+ * A CDP step command. `ranges` is passed as `skipList` to stepInto/stepOver, and ignored for stepOut. `enterRanges` is
+ * passed as `enterRanges` to stepOver: functions within them are entered as if by stepInto.
+ */
 export interface AutoStep {
   readonly command: StepMode;
   readonly ranges: readonly LocationRange[];
+  readonly enterRanges?: readonly LocationRange[];
 }
 
 /**
@@ -478,20 +482,25 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     this.#issueStep(step, breakOnAsyncCall);
   }
 
-  #issueStep({command, ranges}: AutoStep, breakOnAsyncCall = false): void {
-    const skipList =
-        sortAndMergeRanges(ranges.map(({start, end}) => ({
-                                        scriptId: start.scriptId,
-                                        start: {lineNumber: start.lineNumber, columnNumber: start.columnNumber},
-                                        end: {lineNumber: end.lineNumber, columnNumber: end.columnNumber},
-                                      })));
+  #issueStep({command, ranges, enterRanges}: AutoStep, breakOnAsyncCall = false): void {
+    const toProtocolRange = ({start, end}: LocationRange): Protocol.Debugger.LocationRange => ({
+      scriptId: start.scriptId,
+      start: {lineNumber: start.lineNumber, columnNumber: start.columnNumber},
+      end: {lineNumber: end.lineNumber, columnNumber: end.columnNumber},
+    });
+    const skipList = sortAndMergeRanges(ranges.map(toProtocolRange));
     switch (command) {
       case StepMode.STEP_INTO:
         void this.agent.invoke_stepInto({breakOnAsyncCall, skipList});
         break;
-      case StepMode.STEP_OVER:
-        void this.agent.invoke_stepOver({skipList});
+      case StepMode.STEP_OVER: {
+        const request: Protocol.Debugger.StepOverRequest = {skipList};
+        if (enterRanges?.length) {
+          request.enterRanges = sortAndMergeRanges(enterRanges.map(toProtocolRange));
+        }
+        void this.agent.invoke_stepOver(request);
         break;
+      }
       case StepMode.STEP_OUT:
         void this.agent.invoke_stepOut();
         break;

package/front_end/core/sdk/NetworkRequest.ts

@@ -30,11 +30,11 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  secureOnly: 'This cookie was blocked because it had the "`Secure`" attribute and the connection was not secure',
+  secureOnly: 'This cookie was blocked because it had the "`Secure`" attribute and the connection wasn’t secure',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  notOnPath: 'This cookie was blocked because its path was not an exact match for or a superdirectory of the request URL’s path',
+  notOnPath: 'This cookie was blocked because its path wasn’t an exact match for or a superdirectory of the request URL’s path',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -46,15 +46,15 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteLax: 'This cookie was blocked because it had the "`SameSite=Lax`" attribute and the request was made from a different site and was not initiated by a top-level navigation',
+  sameSiteLax: 'This cookie was blocked because it had the "`SameSite=Lax`" attribute and the request was made from a different site and wasn’t initiated by a top-level navigation',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteUnspecifiedTreatedAsLax: 'This cookie didn’t specify a "`SameSite`" attribute when it was stored and was defaulted to "`SameSite=Lax`", and was blocked because the request was made from a different site and was not initiated by a top-level navigation. The cookie had to have been set with "`SameSite=None`" to enable cross-site usage.',
+  sameSiteUnspecifiedTreatedAsLax: 'This cookie didn’t specify a "`SameSite`" attribute when it was stored and was defaulted to "`SameSite=Lax`", and was blocked because the request was made from a different site and wasn’t initiated by a top-level navigation. The cookie had to have been set with "`SameSite=None`" to enable cross-site usage.',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteNoneInsecure: 'This cookie was blocked because it had the "`SameSite=None`" attribute but was not marked "`Secure`". Cookies without SameSite restrictions must be marked "`Secure`" and sent over a secure connection.',
+  sameSiteNoneInsecure: 'This cookie was blocked because it had the "`SameSite=None`" attribute but wasn’t marked "`Secure`". Cookies without SameSite restrictions must be marked "`Secure`" and sent over a secure connection.',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -90,7 +90,7 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  theSchemeOfThisConnectionIsNot: 'The scheme of this connection is not allowed to store cookies',
+  theSchemeOfThisConnectionIsNot: 'The scheme of this connection isn’t allowed to store cookies',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -98,24 +98,24 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSecureOnly: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`Secure`" attribute but was not received over a secure connection',
+  blockedReasonSecureOnly: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`Secure`" attribute but wasn’t received over a secure connection',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    * @example {SameSite=Strict} PH1
    */
-  blockedReasonSameSiteStrictLax: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "{PH1}" attribute but came from a cross-site response which was not the response to a top-level navigation',
+  blockedReasonSameSiteStrictLax: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "{PH1}" attribute but came from a cross-site response which wasn’t the response to a top-level navigation',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSameSiteUnspecifiedTreatedAsLax: 'This "`Set-Cookie`" header didn’t specify a "`SameSite`" attribute and was defaulted to "`SameSite=Lax`", and was blocked because it came from a cross-site response which was not the response to a top-level navigation. The "`Set-Cookie`" header had to have been set with "`SameSite=None`" to enable cross-site usage.',
+  blockedReasonSameSiteUnspecifiedTreatedAsLax: 'This "`Set-Cookie`" header didn’t specify a "`SameSite`" attribute and was defaulted to "`SameSite=Lax`", and was blocked because it came from a cross-site response which wasn’t the response to a top-level navigation. The "`Set-Cookie`" header had to have been set with "`SameSite=None`" to enable cross-site usage.',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSameSiteNoneInsecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`SameSite=None`" attribute but did not have the "`Secure`" attribute, which is required in order to use "`SameSite=None`"',
+  blockedReasonSameSiteNoneInsecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`SameSite=None`" attribute but didn’t have the "`Secure`" attribute, which is required in order to use "`SameSite=None`"',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonOverwriteSecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it was not sent over a secure connection and would have overwritten a cookie with the "`Secure`" attribute',
+  blockedReasonOverwriteSecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it wasn’t sent over a secure connection and would have overwritten a cookie with the "`Secure`" attribute',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */

package/front_end/core/sdk/PageFunctions.ts

@@ -109,7 +109,12 @@ export function toggleClassAndInjectStyleRule(this: Element, pseudoElementName:
   const classNamePrefix = '__web-inspector-hide';
   const classNameSuffix = '-shortcut__';
   const styleTagId = '__web-inspector-hide-shortcut-style__';
-  const pseudoElementNameEscaped = pseudoElementName ? pseudoElementName.replace(/[^a-zA-Z0-9_-]/g, '_') : '';
+  let pseudoElementNameEscaped = '';
+  if (pseudoElementName) {
+    pseudoElementNameEscaped = pseudoElementName.replace(/[^a-zA-Z0-9-]/g, function(c) {
+      return '_' + c.charCodeAt(0).toString(16) + '_';
+    });
+  }
   const className = classNamePrefix + pseudoElementNameEscaped + classNameSuffix;
   this.classList.toggle(className, hidden);
 
@@ -117,7 +122,7 @@ export function toggleClassAndInjectStyleRule(this: Element, pseudoElementName:
   while (localRoot.parentNode) {
     localRoot = (localRoot.parentNode as Element);
   }
-  if (localRoot.nodeType === Node.DOCUMENT_NODE) {
+  if (localRoot.nodeType === 9 /* Node.DOCUMENT_NODE */) {
     localRoot = document.head;
   }
 

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -291,6 +291,21 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
     this.dispatchEventToListeners(Events.FrameNavigatedWithinDocument, frame);
   }
 
+  frameStoppedLoading(frameId: Protocol.Page.FrameId): void {
+    const frame = this.framesInternal.get(frameId);
+    if (!frame) {
+      return;
+    }
+    // The renderer sends `Page.frameNavigated` before it tells the browser
+    // process about the commit, so the `Storage.getStorageKey` request issued
+    // from `ResourceTreeFrame.navigate()` may be answered for the previous
+    // document (and fails outright if that document had an opaque origin, e.g.
+    // the initial about:blank). `Page.frameStoppedLoading` comes from the
+    // browser process after the commit, so re-fetch the storage key here.
+    void frame.getStorageKey(/* forceFetch */ true);
+    void this.updateStorageKeys();
+  }
+
   frameDetached(frameId: Protocol.Page.FrameId, isSwap: boolean): void {
     // Do nothing unless cached resource tree is processed - it will overwrite everything.
     if (!this.#cachedResourcesProcessed) {
@@ -1145,7 +1160,8 @@ export class PageDispatcher implements ProtocolProxyApi.PageDispatcher {
   frameStartedLoading({}: Protocol.Page.FrameStartedLoadingEvent): void {
   }
 
-  frameStoppedLoading({}: Protocol.Page.FrameStoppedLoadingEvent): void {
+  frameStoppedLoading({frameId}: Protocol.Page.FrameStoppedLoadingEvent): void {
+    this.#resourceTreeModel.frameStoppedLoading(frameId);
   }
 
   frameRequestedNavigation({}: Protocol.Page.FrameRequestedNavigationEvent): void {

package/front_end/core/sdk/ServerSentEventsProtocol.ts

@@ -95,8 +95,10 @@ export class ServerSentEventsParser {
       this.#data += '\n';
     }
     if (fieldName === 'id') {
-      // We should do a check here whether the id field contains "\0" and ignore it.
-      this.#id = this.#line.substring(fieldValueStart);
+      const id = this.#line.substring(fieldValueStart);
+      if (!id.includes('\0')) {
+        this.#id = id;
+      }
     }
     // Ignore all other fields. Also ignore "retry", we won't forward that to the backend.
   }

package/front_end/core/sdk/SourceMap.ts

@@ -900,9 +900,10 @@ export class SourceMap {
                                         [];
   }
 
-  /** See {@link SourceMapScopesInfo.hasOutlinedFunctions}. False without encoded scopes. */
-  hasOutlinedFunctions(): boolean {
-    return this.hasEncodedScopeInfo() && (this.#scopesInfo?.hasOutlinedFunctions() ?? false);
+  /** See {@link SourceMapScopesInfo.outlinedFunctionRanges}. Empty without encoded scopes. */
+  outlinedFunctionRanges(generatedLine: number, generatedColumn: number): PositionRange[] {
+    return this.hasEncodedScopeInfo() ? this.#scopesInfo?.outlinedFunctionRanges(generatedLine, generatedColumn) ?? [] :
+                                        [];
   }
 
   /** See {@link SourceMapScopesInfo.artificialFunctionRanges}. Empty without encoded scopes. */

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -614,14 +614,28 @@ export class SourceMapScopesInfo {
   }
 
   /**
-   * @returns true, iff any generated function is outlined, i.e. marked as "hidden" but with a definition (see
-   *          {@link GeneratedFrameKind.OUTLINED}). Hidden functions without a definition are compiler helpers.
+   * @returns the outlined parts of the authored function at the position: the hidden generated functions whose
+   *          original scope lies within that function's original scope (see {@link GeneratedFrameKind.OUTLINED}).
+   *          Includes the outlined part the position itself is in, if any. Sorted by start position.
    */
-  hasOutlinedFunctions(): boolean {
-    const hasOutlined = (ranges: ScopesCodec.GeneratedRange[]): boolean =>
-        ranges.some(range => (range.isStackFrame && range.isHidden && range.originalScope !== undefined) ||
-                        hasOutlined(range.children));
-    return hasOutlined(this.#generatedRanges);
+  outlinedFunctionRanges(generatedLine: number, generatedColumn: number): PositionRange[] {
+    const rangeChain = this.#findGeneratedRangeChain(generatedLine, generatedColumn);
+    const functionScope = this.#findFunctionScopeInOriginalScopeChain(rangeChain.at(-1)?.originalScope);
+    if (!functionScope) {
+      return [];
+    }
+    const isWithinFunction = (scope: ScopesCodec.OriginalScope|undefined): boolean =>
+        scope !== undefined && (scope === functionScope || isWithinFunction(scope.parent));
+    const result: PositionRange[] = [];
+    (function walk(ranges: ScopesCodec.GeneratedRange[]) {
+      for (const range of ranges) {
+        if (range.isStackFrame && range.isHidden && isWithinFunction(range.originalScope)) {
+          result.push({start: range.start, end: range.end});
+        }
+        walk(range.children);
+      }
+    })(this.#generatedRanges);
+    return result;
   }
 
   /**

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -39,7 +39,7 @@ const UIStrings = {
   /**
    * @description Title of an option under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotHighlightAdFrames: 'Do not highlight ad frames',
+  doNotHighlightAdFrames: 'Don’t highlight ad frames',
   /**
    * @description Title of an option under the Rendering category that can be invoked through the Command Menu.
    */
@@ -71,11 +71,11 @@ const UIStrings = {
   /**
    * @description Title of a Rendering setting that can be invoked through the Command Menu.
    */
-  doNotEmulateAFocusedPage: 'Do not emulate a focused page',
+  doNotEmulateAFocusedPage: 'Don’t emulate a focused page',
   /**
    * @description Title of a setting under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotEmulateCssMediaType: 'Do not emulate CSS media type',
+  doNotEmulateCssMediaType: 'Don’t emulate CSS media type',
   /**
    * @description A drop-down menu option to do not emulate css media type.
    */
@@ -108,7 +108,7 @@ const UIStrings = {
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    * @example {prefers-color-scheme} PH1
    */
-  doNotEmulateCss: 'Do not emulate CSS {PH1}',
+  doNotEmulateCss: 'Don’t emulate CSS {PH1}',
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    * @example {prefers-color-scheme: light} PH1
@@ -172,7 +172,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    */
-  doNotEmulateAnyVisionDeficiency: 'Do not emulate any vision deficiency',
+  doNotEmulateAnyVisionDeficiency: 'Don’t emulate any vision deficiency',
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    */
@@ -232,7 +232,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotEmulateOsTextScale: 'Do not emulate OS text scale',
+  doNotEmulateOsTextScale: 'Don’t emulate OS text scale',
   /**
    * @description A drop-down menu option to not emulate OS text scale.
    */
@@ -340,7 +340,7 @@ const UIStrings = {
    * @description A command available in the command menu to stop automatically opening DevTools when
    * webpages create new popup windows.
    */
-  doNotAutoOpen: 'Do not auto-open DevTools for popups',
+  doNotAutoOpen: 'Don’t auto-open DevTools for popups',
   /**
    * @description Title of an action that toggles the "forces CSS prefers-color-scheme" media feature.
    */

package/front_end/generated/Deprecation.ts

@@ -242,6 +242,10 @@ export const UIStrings = {
    * @description A deprecation warning shown in the DevTools Issues tab. It's shown when a video conferencing website uses a non-standard API for controlling the crypto method used, but is not having an effect because the desired behavior is already enabled-by-default.
    */
   RTCConstraintEnableDtlsSrtpTrue: "The constraint `DtlsSrtpKeyAgreement` is removed. You have specified a `true` value for this constraint, which had no effect, but you can remove this constraint for tidiness.",
+  /**
+   * @description Warning displayed to developers when the non-standard RTCPeerConnection.createDTMFSender() method is used. Developers should use the standard RTCRtpSender.dtmf attribute instead.
+   */
+  RTCPeerConnectionCreateDTMFSender: "RTCPeerConnection.createDTMFSender() is deprecated and will be removed. Please use RTCRtpSender.dtmf instead.",
   /**
    * @description WebRTC is set of JavaScript APIs for sending and receiving data, audio and video. getStats() is a method used to obtain network and quality metrics. There are two versions of this method, one is being deprecated because it is non-standard.
    */
@@ -427,6 +431,10 @@ export const DEPRECATIONS_METADATA: Partial<Record<string, DeprecationDescriptor
   "RTCConstraintEnableDtlsSrtpTrue": {
     "milestone": 97
   },
+  "RTCPeerConnectionCreateDTMFSender": {
+    "chromeStatusFeature": 5160724576993280,
+    "milestone": 160
+  },
   "RTCPeerConnectionGetStatsLegacyNonCompliant": {
     "chromeStatusFeature": 4631626228695040,
     "milestone": 117

package/front_end/generated/InspectorBackendCommands.ts

@@ -89,7 +89,7 @@ inspectorBackend.registerEnum("Audits.SharedDictionaryError", {UseErrorCrossOrig
 inspectorBackend.registerEnum("Audits.SRIMessageSignatureError", {MissingSignatureHeader: "MissingSignatureHeader", MissingSignatureInputHeader: "MissingSignatureInputHeader", InvalidSignatureHeader: "InvalidSignatureHeader", InvalidSignatureInputHeader: "InvalidSignatureInputHeader", SignatureHeaderValueIsNotByteSequence: "SignatureHeaderValueIsNotByteSequence", SignatureHeaderValueIsParameterized: "SignatureHeaderValueIsParameterized", SignatureHeaderValueIsIncorrectLength: "SignatureHeaderValueIsIncorrectLength", SignatureInputHeaderMissingLabel: "SignatureInputHeaderMissingLabel", SignatureInputHeaderValueNotInnerList: "SignatureInputHeaderValueNotInnerList", SignatureInputHeaderValueMissingComponents: "SignatureInputHeaderValueMissingComponents", SignatureInputHeaderInvalidComponentType: "SignatureInputHeaderInvalidComponentType", SignatureInputHeaderInvalidComponentName: "SignatureInputHeaderInvalidComponentName", SignatureInputHeaderInvalidHeaderComponentParameter: "SignatureInputHeaderInvalidHeaderComponentParameter", SignatureInputHeaderInvalidDerivedComponentParameter: "SignatureInputHeaderInvalidDerivedComponentParameter", SignatureInputHeaderKeyIdLength: "SignatureInputHeaderKeyIdLength", SignatureInputHeaderInvalidParameter: "SignatureInputHeaderInvalidParameter", SignatureInputHeaderMissingRequiredParameters: "SignatureInputHeaderMissingRequiredParameters", ValidationFailedSignatureExpired: "ValidationFailedSignatureExpired", ValidationFailedInvalidLength: "ValidationFailedInvalidLength", ValidationFailedSignatureMismatch: "ValidationFailedSignatureMismatch", ValidationFailedIntegrityMismatch: "ValidationFailedIntegrityMismatch", SignatureBaseUnknownDerivedComponent: "SignatureBaseUnknownDerivedComponent", SignatureBaseMissingHeader: "SignatureBaseMissingHeader", SignatureBaseInvalidUnencodedDigest: "SignatureBaseInvalidUnencodedDigest", SignatureBaseUnsupportedComponent: "SignatureBaseUnsupportedComponent"});
 inspectorBackend.registerEnum("Audits.UnencodedDigestError", {MalformedDictionary: "MalformedDictionary", UnknownAlgorithm: "UnknownAlgorithm", IncorrectDigestType: "IncorrectDigestType", IncorrectDigestLength: "IncorrectDigestLength"});
 inspectorBackend.registerEnum("Audits.ConnectionAllowlistError", {InvalidHeader: "InvalidHeader", MoreThanOneList: "MoreThanOneList", ItemNotInnerList: "ItemNotInnerList", InvalidAllowlistItemType: "InvalidAllowlistItemType", ReportingEndpointNotToken: "ReportingEndpointNotToken", InvalidUrlPattern: "InvalidUrlPattern", IFrameAttributeLoosensEmbeddingRequirement: "IFrameAttributeLoosensEmbeddingRequirement", InvalidAllowConnectionAllowlistFrom: "InvalidAllowConnectionAllowlistFrom", EmbeddingRequirementNotSatisfied: "EmbeddingRequirementNotSatisfied"});
-inspectorBackend.registerEnum("Audits.GenericIssueErrorType", {FormLabelForNameError: "FormLabelForNameError", FormDuplicateIdForInputError: "FormDuplicateIdForInputError", FormInputWithNoLabelError: "FormInputWithNoLabelError", FormAutocompleteAttributeEmptyError: "FormAutocompleteAttributeEmptyError", FormEmptyIdAndNameAttributesForInputError: "FormEmptyIdAndNameAttributesForInputError", FormAriaLabelledByToNonExistingIdError: "FormAriaLabelledByToNonExistingIdError", FormInputAssignedAutocompleteValueToIdOrNameAttributeError: "FormInputAssignedAutocompleteValueToIdOrNameAttributeError", FormLabelHasNeitherForNorNestedInputError: "FormLabelHasNeitherForNorNestedInputError", FormLabelForMatchesNonExistingIdError: "FormLabelForMatchesNonExistingIdError", FormInputHasWrongButWellIntendedAutocompleteValueError: "FormInputHasWrongButWellIntendedAutocompleteValueError", ResponseWasBlockedByORB: "ResponseWasBlockedByORB", NavigationEntryMarkedSkippable: "NavigationEntryMarkedSkippable", BackUINavigationWouldSkipAd: "BackUINavigationWouldSkipAd", AutofillAndManualTextPolicyControlledFeaturesInfo: "AutofillAndManualTextPolicyControlledFeaturesInfo", AutofillPolicyControlledFeatureInfo: "AutofillPolicyControlledFeatureInfo", ManualTextPolicyControlledFeatureInfo: "ManualTextPolicyControlledFeatureInfo", FormModelContextParameterMissingTitleAndDescription: "FormModelContextParameterMissingTitleAndDescription", FormModelContextMissingToolName: "FormModelContextMissingToolName", FormModelContextMissingToolDescription: "FormModelContextMissingToolDescription", FormModelContextRequiredParameterMissingName: "FormModelContextRequiredParameterMissingName", FormModelContextParameterMissingName: "FormModelContextParameterMissingName"});
+inspectorBackend.registerEnum("Audits.GenericIssueErrorType", {FormLabelForNameError: "FormLabelForNameError", FormDuplicateIdForInputError: "FormDuplicateIdForInputError", FormInputWithNoLabelError: "FormInputWithNoLabelError", FormAutocompleteAttributeEmptyError: "FormAutocompleteAttributeEmptyError", FormEmptyIdAndNameAttributesForInputError: "FormEmptyIdAndNameAttributesForInputError", FormAriaLabelledByToNonExistingIdError: "FormAriaLabelledByToNonExistingIdError", FormInputAssignedAutocompleteValueToIdOrNameAttributeError: "FormInputAssignedAutocompleteValueToIdOrNameAttributeError", FormLabelHasNeitherForNorNestedInputError: "FormLabelHasNeitherForNorNestedInputError", FormLabelForMatchesNonExistingIdError: "FormLabelForMatchesNonExistingIdError", FormInputHasWrongButWellIntendedAutocompleteValueError: "FormInputHasWrongButWellIntendedAutocompleteValueError", ResponseWasBlockedByORB: "ResponseWasBlockedByORB", NavigationEntryMarkedSkippable: "NavigationEntryMarkedSkippable", BackUINavigationWouldSkipAd: "BackUINavigationWouldSkipAd", AutofillAndManualTextPolicyControlledFeaturesInfo: "AutofillAndManualTextPolicyControlledFeaturesInfo", AutofillPolicyControlledFeatureInfo: "AutofillPolicyControlledFeatureInfo", ManualTextPolicyControlledFeatureInfo: "ManualTextPolicyControlledFeatureInfo", FormModelContextParameterMissingTitleAndDescription: "FormModelContextParameterMissingTitleAndDescription", FormModelContextMissingToolName: "FormModelContextMissingToolName", FormModelContextMissingToolDescription: "FormModelContextMissingToolDescription", FormModelContextRequiredParameterMissingName: "FormModelContextRequiredParameterMissingName", FormModelContextParameterMissingName: "FormModelContextParameterMissingName", GeolocationPromptWithoutUserGesture: "GeolocationPromptWithoutUserGesture"});
 inspectorBackend.registerEnum("Audits.ClientHintIssueReason", {MetaTagAllowListInvalidOrigin: "MetaTagAllowListInvalidOrigin", MetaTagModifiedHTML: "MetaTagModifiedHTML"});
 inspectorBackend.registerEnum("Audits.FederatedAuthRequestIssueReason", {ShouldEmbargo: "ShouldEmbargo", TooManyRequests: "TooManyRequests", WellKnownHttpNotFound: "WellKnownHttpNotFound", WellKnownNoResponse: "WellKnownNoResponse", WellKnownBlockedByConnectionAllowlist: "WellKnownBlockedByConnectionAllowlist", WellKnownInvalidResponse: "WellKnownInvalidResponse", WellKnownListEmpty: "WellKnownListEmpty", WellKnownInvalidContentType: "WellKnownInvalidContentType", ConfigNotInWellKnown: "ConfigNotInWellKnown", WellKnownTooBig: "WellKnownTooBig", ConfigHttpNotFound: "ConfigHttpNotFound", ConfigNoResponse: "ConfigNoResponse", ConfigBlockedByConnectionAllowlist: "ConfigBlockedByConnectionAllowlist", ConfigInvalidResponse: "ConfigInvalidResponse", ConfigInvalidContentType: "ConfigInvalidContentType", IdpNotPotentiallyTrustworthy: "IdpNotPotentiallyTrustworthy", DisabledInSettings: "DisabledInSettings", DisabledInFlags: "DisabledInFlags", ErrorFetchingSignin: "ErrorFetchingSignin", InvalidSigninResponse: "InvalidSigninResponse", AccountsHttpNotFound: "AccountsHttpNotFound", AccountsNoResponse: "AccountsNoResponse", AccountsBlockedByConnectionAllowlist: "AccountsBlockedByConnectionAllowlist", AccountsInvalidResponse: "AccountsInvalidResponse", AccountsListEmpty: "AccountsListEmpty", AccountsInvalidContentType: "AccountsInvalidContentType", IdTokenHttpNotFound: "IdTokenHttpNotFound", IdTokenNoResponse: "IdTokenNoResponse", IdTokenBlockedByConnectionAllowlist: "IdTokenBlockedByConnectionAllowlist", IdTokenInvalidResponse: "IdTokenInvalidResponse", IdTokenIdpErrorResponse: "IdTokenIdpErrorResponse", IdTokenCrossSiteIdpErrorResponse: "IdTokenCrossSiteIdpErrorResponse", IdTokenInvalidRequest: "IdTokenInvalidRequest", IdTokenInvalidContentType: "IdTokenInvalidContentType", ErrorIdToken: "ErrorIdToken", Canceled: "Canceled", RpPageNotVisible: "RpPageNotVisible", SilentMediationFailure: "SilentMediationFailure", NotSignedInWithIdp: "NotSignedInWithIdp", MissingTransientUserActivation: "MissingTransientUserActivation", ReplacedByActiveMode: "ReplacedByActiveMode", RelyingPartyOriginIsOpaque: "RelyingPartyOriginIsOpaque", TypeNotMatching: "TypeNotMatching", UiDismissedNoEmbargo: "UiDismissedNoEmbargo", CorsError: "CorsError", SuppressedBySegmentationPlatform: "SuppressedBySegmentationPlatform", PopupBlockedByConnectionAllowlist: "PopupBlockedByConnectionAllowlist"});
 inspectorBackend.registerEnum("Audits.FederatedAuthUserInfoRequestIssueReason", {NotSameOrigin: "NotSameOrigin", NotIframe: "NotIframe", NotPotentiallyTrustworthy: "NotPotentiallyTrustworthy", NoAPIPermission: "NoApiPermission", NotSignedInWithIdp: "NotSignedInWithIdp", NoAccountSharingPermission: "NoAccountSharingPermission", InvalidConfigOrWellKnown: "InvalidConfigOrWellKnown", InvalidAccountsResponse: "InvalidAccountsResponse", NoReturningUserFromFetchedAccounts: "NoReturningUserFromFetchedAccounts"});
@@ -1126,6 +1126,7 @@ inspectorBackend.registerCommand("Page.getAppId", [], ["appId", "recommendedId",
 inspectorBackend.registerCommand("Page.getSubApps", [], ["subApps"], "Returns the list of installed child Sub-Apps for the inspected parent app.");
 inspectorBackend.registerCommand("Page.getSiblingSubApps", [], ["subApps"], "Returns the list of sibling Sub-Apps sharing the same parent app if the inspected context is a Sub-App.");
 inspectorBackend.registerCommand("Page.getAdScriptAncestry", [{"name": "frameId", "type": "string", "optional": false, "description": "", "typeRef": "Page.FrameId"}], ["adScriptAncestry"], "");
+inspectorBackend.registerCommand("Page.getSpellCheckCustomDictionary", [{"name": "frameId", "type": "string", "optional": false, "description": "", "typeRef": "Page.FrameId"}], ["words"], "Returns the words that the frame's document added to its spell check custom dictionary with `document.spellCheckCustomDictionary.addWords()`, sorted. Page script cannot read the dictionary back; this lets developers inspect it.");
 inspectorBackend.registerCommand("Page.getFrameTree", [], ["frameTree"], "Returns present frame tree structure.");
 inspectorBackend.registerCommand("Page.getLayoutMetrics", [], ["layoutViewport", "visualViewport", "contentSize", "cssLayoutViewport", "cssVisualViewport", "cssContentSize"], "Returns metrics relating to the layouting of the page, such as viewport bounds/scale.");
 inspectorBackend.registerCommand("Page.getNavigationHistory", [], ["currentIndex", "entries"], "Returns navigation history for the current page.");
@@ -1567,7 +1568,7 @@ inspectorBackend.registerCommand("Debugger.setSkipAllPauses", [{"name": "skip",
 inspectorBackend.registerCommand("Debugger.setVariableValue", [{"name": "scopeNumber", "type": "number", "optional": false, "description": "0-based number of scope as was listed in scope chain. Only 'local', 'closure' and 'catch' scope types are allowed. Other scopes could be manipulated manually.", "typeRef": null}, {"name": "variableName", "type": "string", "optional": false, "description": "Variable name.", "typeRef": null}, {"name": "newValue", "type": "object", "optional": false, "description": "New variable value.", "typeRef": "Runtime.CallArgument"}, {"name": "callFrameId", "type": "string", "optional": false, "description": "Id of callframe that holds variable.", "typeRef": "Debugger.CallFrameId"}], [], "Changes value of variable in a callframe. Object-based scopes are not supported and must be mutated manually.");
 inspectorBackend.registerCommand("Debugger.stepInto", [{"name": "breakOnAsyncCall", "type": "boolean", "optional": true, "description": "Debugger will pause on the execution of the first async task which was scheduled before next pause.", "typeRef": null}, {"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step into.", "typeRef": "Debugger.LocationRange"}], [], "Steps into the function call.");
 inspectorBackend.registerCommand("Debugger.stepOut", [], [], "Steps out of the function call.");
-inspectorBackend.registerCommand("Debugger.stepOver", [{"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step over.", "typeRef": "Debugger.LocationRange"}], [], "Steps over the statement.");
+inspectorBackend.registerCommand("Debugger.stepOver", [{"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step over.", "typeRef": "Debugger.LocationRange"}, {"name": "enterRanges", "type": "array", "optional": true, "description": "Functions whose source range lies within one of the enterRanges are entered as if by stepInto, even when they are called (directly or indirectly) from a call that is stepped over.", "typeRef": "Debugger.LocationRange"}], [], "Steps over the statement.");
 inspectorBackend.registerType("Debugger.Location", [{"name": "scriptId", "type": "string", "optional": false, "description": "Script identifier as reported in the `Debugger.scriptParsed`.", "typeRef": "Runtime.ScriptId"}, {"name": "lineNumber", "type": "number", "optional": false, "description": "Line number in the script (0-based).", "typeRef": null}, {"name": "columnNumber", "type": "number", "optional": true, "description": "Column number in the script (0-based).", "typeRef": null}]);
 inspectorBackend.registerType("Debugger.ScriptPosition", [{"name": "lineNumber", "type": "number", "optional": false, "description": "", "typeRef": null}, {"name": "columnNumber", "type": "number", "optional": false, "description": "", "typeRef": null}]);
 inspectorBackend.registerType("Debugger.LocationRange", [{"name": "scriptId", "type": "string", "optional": false, "description": "", "typeRef": "Runtime.ScriptId"}, {"name": "start", "type": "object", "optional": false, "description": "", "typeRef": "Debugger.ScriptPosition"}, {"name": "end", "type": "object", "optional": false, "description": "", "typeRef": "Debugger.ScriptPosition"}]);

package/front_end/generated/protocol-mapping.d.ts

@@ -4228,6 +4228,16 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Page.GetAdScriptAncestryRequest];
       returnType: Protocol.Page.GetAdScriptAncestryResponse;
     };
+    /**
+     * Returns the words that the frame's document added to its spell check custom
+     * dictionary with `document.spellCheckCustomDictionary.addWords()`, sorted.
+     * Page script cannot read the dictionary back; this lets developers inspect
+     * it.
+     */
+    'Page.getSpellCheckCustomDictionary': {
+      paramsType: [Protocol.Page.GetSpellCheckCustomDictionaryRequest];
+      returnType: Protocol.Page.GetSpellCheckCustomDictionaryResponse;
+    };
     /**
      * Returns present frame tree structure.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -3422,6 +3422,14 @@ declare namespace ProtocolProxyApi {
 
     invoke_getAdScriptAncestry(params: Protocol.Page.GetAdScriptAncestryRequest): Promise<Protocol.Page.GetAdScriptAncestryResponse>;
 
+    /**
+     * Returns the words that the frame's document added to its spell check custom
+     * dictionary with `document.spellCheckCustomDictionary.addWords()`, sorted.
+     * Page script cannot read the dictionary back; this lets developers inspect
+     * it.
+     */
+    invoke_getSpellCheckCustomDictionary(params: Protocol.Page.GetSpellCheckCustomDictionaryRequest): Promise<Protocol.Page.GetSpellCheckCustomDictionaryResponse>;
+
     /**
      * Returns present frame tree structure.
      */

package/front_end/generated/protocol.ts

@@ -1291,6 +1291,7 @@ export namespace Audits {
     FormModelContextMissingToolDescription = 'FormModelContextMissingToolDescription',
     FormModelContextRequiredParameterMissingName = 'FormModelContextRequiredParameterMissingName',
     FormModelContextParameterMissingName = 'FormModelContextParameterMissingName',
+    GeolocationPromptWithoutUserGesture = 'GeolocationPromptWithoutUserGesture',
   }
 
   /**
@@ -16027,6 +16028,14 @@ export namespace Page {
     adScriptAncestry?: Network.AdAncestry;
   }
 
+  export interface GetSpellCheckCustomDictionaryRequest {
+    frameId: FrameId;
+  }
+
+  export interface GetSpellCheckCustomDictionaryResponse extends ProtocolResponseWithError {
+    words: string[];
+  }
+
   export interface GetFrameTreeResponse extends ProtocolResponseWithError {
     /**
      * Present frame tree structure.
@@ -21405,6 +21414,12 @@ export namespace Debugger {
      * The skipList specifies location ranges that should be skipped on step over.
      */
     skipList?: LocationRange[];
+    /**
+     * Functions whose source range lies within one of the enterRanges are
+     * entered as if by stepInto, even when they are called (directly or
+     * indirectly) from a call that is stepped over.
+     */
+    enterRanges?: LocationRange[];
   }
 
   /**