chrome-devtools-frontend 1.0.1711155 → 1.0.1713292

package/.agents/skills/code-review/SKILL.md

@@ -10,17 +10,21 @@ Use it for self-review before upload and for reviewing other people's CLs.
 
 ## 1. Gather context
 
-- **Local change:** `git diff origin/main...HEAD` (or `git show HEAD` for a
-  single-commit branch). To learn about the branch and upload workflow, see the
-  `devtools-version-control` skill.
-- **Gerrit CL:** strip the leading `)]}'` line from each response to get JSON:
-  - Diff: `git cl diff` (for the current branch), or fetch the patch set.
-  - Inline comments:
-    `curl -s https://chromium-review.googlesource.com/changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/comments | tail -n +2`
-  - Messages:
-    `.../changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/messages`
-- Read the CL description first. Then check that the diff does what the
-  description says, and nothing else.
+- **Automated Review Agent (diff already in prompt):** Do not run shell
+  commands. Use `read_file` to inspect enclosing classes/functions/tests and
+  `search_files` to verify callers or conventions across the repository.
+- **Local CLI / Interactive session (no diff in prompt):**
+  - **Local change:** `git diff origin/main...HEAD` (or `git show HEAD` for a
+    single-commit branch). To learn about the branch and upload workflow, see the
+    `devtools-version-control` skill.
+  - **Gerrit CL:** strip the leading `)]}'` line from each response to get JSON:
+    - Diff: `git cl diff` (for the current branch), or fetch the patch set.
+    - Inline comments:
+      `curl -s https://chromium-review.googlesource.com/changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/comments | tail -n +2`
+    - Messages:
+      `.../changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/messages`
+  - Read the CL description first. Then check that the diff does what the
+    description says, and nothing else.
 
 ## 2. Consult the specialized skills
 
@@ -29,7 +33,7 @@ Load the skill that matches what the diff touches, and apply its rules:
 | If the diff touches… | Use skill |
 | :--- | :--- |
 | Any `import` statement, or a new cross-module dependency | `devtools-imports` |
-| `UI.Widget`, lit-html views, components, CSS | `devtools-ui-widgets` |
+| `UI.Widget`, lit-html views, components, CSS | `ui-widgets` |
 | Migration of legacy imperative DOM to widgets or Lit | `ui-eng-vision-orchestrator` (and its sub-skills) |
 | New or changed tests: choosing unit, API, or E2E | `devtools-testing-guidance` |
 | Tests that use `describeWithEnvironment` or `describeWithMockConnection`, or foundation modules | `foundation-test-migration` |

package/AUTHORS

@@ -108,6 +108,7 @@ Sergio Avalos <sergio.avalos@gmail.com>
 Shelley Vohr <shelley.vohr@gmail.com>
 Simon Siefke <simon.siefke@gmail.com>
 Stephen Tsoi-A-Sue <stsoiasue@gmail.com>
+Steve Harrison <steve@steveharrison.dev>
 Sunnylost <sunnylost@gmail.com>
 Suyoung Jung <tdhitbtd@gmail.com>
 TaegeonKim <aksen5240@gmail.com>

package/DIR_METADATA

@@ -2,3 +2,39 @@ team_email: "devtools-dev@chromium.org"
 buganizer_public: {
   component_id: 1457055
 }
+agentic_review: {
+  capability_groups: {
+    name: "core-review"
+    review_capability_skills: [".agents/skills/code-review/SKILL.md"]
+  }
+  capability_groups: {
+    name: "typescript-and-models"
+    path_expression: ["front_end/.*\\.ts", ".*BUILD\\.gn", ".*\\.gni"]
+    path_expression_exclusion: [".*\\.test\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/devtools-imports/SKILL.md",
+      ".agents/skills/devtools-model-management/SKILL.md",
+      ".agents/skills/devtools-setting-migration/SKILL.md",
+      ".agents/skills/devtools-unicode-escaping/SKILL.md",
+      ".agents/skills/devtools-ux-writing-refactor/SKILL.md"
+    ]
+  }
+  capability_groups: {
+    name: "ui-and-widgets"
+    path_expression: ["front_end/(panels|ui)/.*\\.(ts|css)"]
+    path_expression_exclusion: [".*\\.test\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/ui-widgets/SKILL.md",
+      ".agents/skills/ui-eng-vision-orchestrator/SKILL.md"
+    ]
+  }
+  capability_groups: {
+    name: "tests"
+    path_expression: [".*\\.test\\.ts", "test/.*\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/devtools-testing-guidance/SKILL.md",
+      ".agents/skills/foundation-test-migration/SKILL.md",
+      ".agents/skills/fix-tests/SKILL.md"
+    ]
+  }
+}

package/front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -19,11 +19,11 @@ const UIStrings = {
   /**
    * @description Error message for when a CSS file can't be loaded.
    */
-  couldNotFindTheOriginalStyle: 'Could not find the original style sheet',
+  couldNotFindTheOriginalStyle: 'Couldn’t find the original style sheet',
   /**
    * @description Error message to display when a source CSS file could not be retrieved.
    */
-  couldNotRetrieveSourceStyles: 'Could not retrieve source styles',
+  couldNotRetrieveSourceStyles: 'Couldn’t retrieve source styles',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CSSStyleSheetHeader.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

package/front_end/core/sdk/CompilerSourceMappingContentProvider.ts

@@ -15,7 +15,7 @@ const UIStrings = {
    * @example {https://example.com/sourcemap.map} PH1
    * @example {An error occurred} PH2
    */
-  couldNotLoadContentForSS: 'Could not load content for {PH1} ({PH2})',
+  couldNotLoadContentForSS: 'Couldn’t load content for {PH1} ({PH2})',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CompilerSourceMappingContentProvider.ts', UIStrings);

package/front_end/core/sdk/NetworkRequest.ts

@@ -30,11 +30,11 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  secureOnly: 'This cookie was blocked because it had the "`Secure`" attribute and the connection was not secure',
+  secureOnly: 'This cookie was blocked because it had the "`Secure`" attribute and the connection wasn’t secure',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  notOnPath: 'This cookie was blocked because its path was not an exact match for or a superdirectory of the request URL’s path',
+  notOnPath: 'This cookie was blocked because its path wasn’t an exact match for or a superdirectory of the request URL’s path',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -46,15 +46,15 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteLax: 'This cookie was blocked because it had the "`SameSite=Lax`" attribute and the request was made from a different site and was not initiated by a top-level navigation',
+  sameSiteLax: 'This cookie was blocked because it had the "`SameSite=Lax`" attribute and the request was made from a different site and wasn’t initiated by a top-level navigation',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteUnspecifiedTreatedAsLax: 'This cookie didn’t specify a "`SameSite`" attribute when it was stored and was defaulted to "`SameSite=Lax`", and was blocked because the request was made from a different site and was not initiated by a top-level navigation. The cookie had to have been set with "`SameSite=None`" to enable cross-site usage.',
+  sameSiteUnspecifiedTreatedAsLax: 'This cookie didn’t specify a "`SameSite`" attribute when it was stored and was defaulted to "`SameSite=Lax`", and was blocked because the request was made from a different site and wasn’t initiated by a top-level navigation. The cookie had to have been set with "`SameSite=None`" to enable cross-site usage.',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteNoneInsecure: 'This cookie was blocked because it had the "`SameSite=None`" attribute but was not marked "`Secure`". Cookies without SameSite restrictions must be marked "`Secure`" and sent over a secure connection.',
+  sameSiteNoneInsecure: 'This cookie was blocked because it had the "`SameSite=None`" attribute but wasn’t marked "`Secure`". Cookies without SameSite restrictions must be marked "`Secure`" and sent over a secure connection.',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -90,7 +90,7 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  theSchemeOfThisConnectionIsNot: 'The scheme of this connection is not allowed to store cookies',
+  theSchemeOfThisConnectionIsNot: 'The scheme of this connection isn’t allowed to store cookies',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -98,24 +98,24 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSecureOnly: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`Secure`" attribute but was not received over a secure connection',
+  blockedReasonSecureOnly: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`Secure`" attribute but wasn’t received over a secure connection',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    * @example {SameSite=Strict} PH1
    */
-  blockedReasonSameSiteStrictLax: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "{PH1}" attribute but came from a cross-site response which was not the response to a top-level navigation',
+  blockedReasonSameSiteStrictLax: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "{PH1}" attribute but came from a cross-site response which wasn’t the response to a top-level navigation',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSameSiteUnspecifiedTreatedAsLax: 'This "`Set-Cookie`" header didn’t specify a "`SameSite`" attribute and was defaulted to "`SameSite=Lax`", and was blocked because it came from a cross-site response which was not the response to a top-level navigation. The "`Set-Cookie`" header had to have been set with "`SameSite=None`" to enable cross-site usage.',
+  blockedReasonSameSiteUnspecifiedTreatedAsLax: 'This "`Set-Cookie`" header didn’t specify a "`SameSite`" attribute and was defaulted to "`SameSite=Lax`", and was blocked because it came from a cross-site response which wasn’t the response to a top-level navigation. The "`Set-Cookie`" header had to have been set with "`SameSite=None`" to enable cross-site usage.',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSameSiteNoneInsecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`SameSite=None`" attribute but did not have the "`Secure`" attribute, which is required in order to use "`SameSite=None`"',
+  blockedReasonSameSiteNoneInsecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`SameSite=None`" attribute but didn’t have the "`Secure`" attribute, which is required in order to use "`SameSite=None`"',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonOverwriteSecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it was not sent over a secure connection and would have overwritten a cookie with the "`Secure`" attribute',
+  blockedReasonOverwriteSecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it wasn’t sent over a secure connection and would have overwritten a cookie with the "`Secure`" attribute',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -291,6 +291,21 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
     this.dispatchEventToListeners(Events.FrameNavigatedWithinDocument, frame);
   }
 
+  frameStoppedLoading(frameId: Protocol.Page.FrameId): void {
+    const frame = this.framesInternal.get(frameId);
+    if (!frame) {
+      return;
+    }
+    // The renderer sends `Page.frameNavigated` before it tells the browser
+    // process about the commit, so the `Storage.getStorageKey` request issued
+    // from `ResourceTreeFrame.navigate()` may be answered for the previous
+    // document (and fails outright if that document had an opaque origin, e.g.
+    // the initial about:blank). `Page.frameStoppedLoading` comes from the
+    // browser process after the commit, so re-fetch the storage key here.
+    void frame.getStorageKey(/* forceFetch */ true);
+    void this.updateStorageKeys();
+  }
+
   frameDetached(frameId: Protocol.Page.FrameId, isSwap: boolean): void {
     // Do nothing unless cached resource tree is processed - it will overwrite everything.
     if (!this.#cachedResourcesProcessed) {
@@ -1145,7 +1160,8 @@ export class PageDispatcher implements ProtocolProxyApi.PageDispatcher {
   frameStartedLoading({}: Protocol.Page.FrameStartedLoadingEvent): void {
   }
 
-  frameStoppedLoading({}: Protocol.Page.FrameStoppedLoadingEvent): void {
+  frameStoppedLoading({frameId}: Protocol.Page.FrameStoppedLoadingEvent): void {
+    this.#resourceTreeModel.frameStoppedLoading(frameId);
   }
 
   frameRequestedNavigation({}: Protocol.Page.FrameRequestedNavigationEvent): void {

package/front_end/core/sdk/SourceMap.ts

@@ -905,6 +905,12 @@ export class SourceMap {
     return this.hasEncodedScopeInfo() && (this.#scopesInfo?.hasOutlinedFunctions() ?? false);
   }
 
+  /** See {@link SourceMapScopesInfo.outlinedFunctionRanges}. Empty without encoded scopes. */
+  outlinedFunctionRanges(generatedLine: number, generatedColumn: number): PositionRange[] {
+    return this.hasEncodedScopeInfo() ? this.#scopesInfo?.outlinedFunctionRanges(generatedLine, generatedColumn) ?? [] :
+                                        [];
+  }
+
   /** See {@link SourceMapScopesInfo.artificialFunctionRanges}. Empty without encoded scopes. */
   artificialFunctionRanges(): PositionRange[] {
     return this.hasEncodedScopeInfo() ? this.#scopesInfo?.artificialFunctionRanges() ?? [] : [];

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -624,6 +624,31 @@ export class SourceMapScopesInfo {
     return hasOutlined(this.#generatedRanges);
   }
 
+  /**
+   * @returns the outlined parts of the authored function at the position: the hidden generated functions whose
+   *          original scope lies within that function's original scope (see {@link GeneratedFrameKind.OUTLINED}).
+   *          Includes the outlined part the position itself is in, if any. Sorted by start position.
+   */
+  outlinedFunctionRanges(generatedLine: number, generatedColumn: number): PositionRange[] {
+    const rangeChain = this.#findGeneratedRangeChain(generatedLine, generatedColumn);
+    const functionScope = this.#findFunctionScopeInOriginalScopeChain(rangeChain.at(-1)?.originalScope);
+    if (!functionScope) {
+      return [];
+    }
+    const isWithinFunction = (scope: ScopesCodec.OriginalScope|undefined): boolean =>
+        scope !== undefined && (scope === functionScope || isWithinFunction(scope.parent));
+    const result: PositionRange[] = [];
+    (function walk(ranges: ScopesCodec.GeneratedRange[]) {
+      for (const range of ranges) {
+        if (range.isStackFrame && range.isHidden && isWithinFunction(range.originalScope)) {
+          result.push({start: range.start, end: range.end});
+        }
+        walk(range.children);
+      }
+    })(this.#generatedRanges);
+    return result;
+  }
+
   /**
    * @returns the "artificial" generated functions (in the DWARF sense): functions that contain no authored code at all
    *          (no original scope anywhere in their subtree), e.g. compiler helpers. Sorted by start position,

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -39,7 +39,7 @@ const UIStrings = {
   /**
    * @description Title of an option under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotHighlightAdFrames: 'Do not highlight ad frames',
+  doNotHighlightAdFrames: 'Don’t highlight ad frames',
   /**
    * @description Title of an option under the Rendering category that can be invoked through the Command Menu.
    */
@@ -71,11 +71,11 @@ const UIStrings = {
   /**
    * @description Title of a Rendering setting that can be invoked through the Command Menu.
    */
-  doNotEmulateAFocusedPage: 'Do not emulate a focused page',
+  doNotEmulateAFocusedPage: 'Don’t emulate a focused page',
   /**
    * @description Title of a setting under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotEmulateCssMediaType: 'Do not emulate CSS media type',
+  doNotEmulateCssMediaType: 'Don’t emulate CSS media type',
   /**
    * @description A drop-down menu option to do not emulate css media type.
    */
@@ -108,7 +108,7 @@ const UIStrings = {
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    * @example {prefers-color-scheme} PH1
    */
-  doNotEmulateCss: 'Do not emulate CSS {PH1}',
+  doNotEmulateCss: 'Don’t emulate CSS {PH1}',
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    * @example {prefers-color-scheme: light} PH1
@@ -172,7 +172,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    */
-  doNotEmulateAnyVisionDeficiency: 'Do not emulate any vision deficiency',
+  doNotEmulateAnyVisionDeficiency: 'Don’t emulate any vision deficiency',
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    */
@@ -232,7 +232,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotEmulateOsTextScale: 'Do not emulate OS text scale',
+  doNotEmulateOsTextScale: 'Don’t emulate OS text scale',
   /**
    * @description A drop-down menu option to not emulate OS text scale.
    */
@@ -340,7 +340,7 @@ const UIStrings = {
    * @description A command available in the command menu to stop automatically opening DevTools when
    * webpages create new popup windows.
    */
-  doNotAutoOpen: 'Do not auto-open DevTools for popups',
+  doNotAutoOpen: 'Don’t auto-open DevTools for popups',
   /**
    * @description Title of an action that toggles the "forces CSS prefers-color-scheme" media feature.
    */

package/front_end/generated/InspectorBackendCommands.ts

@@ -1567,7 +1567,7 @@ inspectorBackend.registerCommand("Debugger.setSkipAllPauses", [{"name": "skip",
 inspectorBackend.registerCommand("Debugger.setVariableValue", [{"name": "scopeNumber", "type": "number", "optional": false, "description": "0-based number of scope as was listed in scope chain. Only 'local', 'closure' and 'catch' scope types are allowed. Other scopes could be manipulated manually.", "typeRef": null}, {"name": "variableName", "type": "string", "optional": false, "description": "Variable name.", "typeRef": null}, {"name": "newValue", "type": "object", "optional": false, "description": "New variable value.", "typeRef": "Runtime.CallArgument"}, {"name": "callFrameId", "type": "string", "optional": false, "description": "Id of callframe that holds variable.", "typeRef": "Debugger.CallFrameId"}], [], "Changes value of variable in a callframe. Object-based scopes are not supported and must be mutated manually.");
 inspectorBackend.registerCommand("Debugger.stepInto", [{"name": "breakOnAsyncCall", "type": "boolean", "optional": true, "description": "Debugger will pause on the execution of the first async task which was scheduled before next pause.", "typeRef": null}, {"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step into.", "typeRef": "Debugger.LocationRange"}], [], "Steps into the function call.");
 inspectorBackend.registerCommand("Debugger.stepOut", [], [], "Steps out of the function call.");
-inspectorBackend.registerCommand("Debugger.stepOver", [{"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step over.", "typeRef": "Debugger.LocationRange"}], [], "Steps over the statement.");
+inspectorBackend.registerCommand("Debugger.stepOver", [{"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step over.", "typeRef": "Debugger.LocationRange"}, {"name": "enterRanges", "type": "array", "optional": true, "description": "Functions whose source range lies within one of the enterRanges are entered as if by stepInto, even when they are called (directly or indirectly) from a call that is stepped over.", "typeRef": "Debugger.LocationRange"}], [], "Steps over the statement.");
 inspectorBackend.registerType("Debugger.Location", [{"name": "scriptId", "type": "string", "optional": false, "description": "Script identifier as reported in the `Debugger.scriptParsed`.", "typeRef": "Runtime.ScriptId"}, {"name": "lineNumber", "type": "number", "optional": false, "description": "Line number in the script (0-based).", "typeRef": null}, {"name": "columnNumber", "type": "number", "optional": true, "description": "Column number in the script (0-based).", "typeRef": null}]);
 inspectorBackend.registerType("Debugger.ScriptPosition", [{"name": "lineNumber", "type": "number", "optional": false, "description": "", "typeRef": null}, {"name": "columnNumber", "type": "number", "optional": false, "description": "", "typeRef": null}]);
 inspectorBackend.registerType("Debugger.LocationRange", [{"name": "scriptId", "type": "string", "optional": false, "description": "", "typeRef": "Runtime.ScriptId"}, {"name": "start", "type": "object", "optional": false, "description": "", "typeRef": "Debugger.ScriptPosition"}, {"name": "end", "type": "object", "optional": false, "description": "", "typeRef": "Debugger.ScriptPosition"}]);

package/front_end/generated/protocol.ts

@@ -21405,6 +21405,12 @@ export namespace Debugger {
      * The skipList specifies location ranges that should be skipped on step over.
      */
     skipList?: LocationRange[];
+    /**
+     * Functions whose source range lies within one of the enterRanges are
+     * entered as if by stepInto, even when they are called (directly or
+     * indirectly) from a call that is stepped over.
+     */
+    enterRanges?: LocationRange[];
   }
 
   /**

package/front_end/models/bindings/SourceMapStepping.ts

@@ -7,6 +7,10 @@
  *
  * Mirrors the Wasm auto-stepping: user steps get a skip list (see `DebuggerWorkspaceBinding.computeAutoStep`), and
  * pauses that don't correspond to a "logical" step are continued automatically ({@link nextAutoStep}).
+ *
+ * Outlined code is code of an authored function that the compiler moved into a separate generated function marked as
+ * "hidden". A run of outlined frames on top of the stack is one logical frame together with the frame below them (the
+ * "owner"), see {@link logicalDepth}.
  */
 
 import * as Root from '../../core/root/root.js';
@@ -51,6 +55,29 @@ export function isScopedFrame(frame: SDK.DebuggerModel.CallFrame): boolean {
   return scopedPosition(frame) !== null;
 }
 
+/** @returns the number of leading frames that are outlined parts of the (logical) frame below them. */
+function outlinedPrefixLength(callFrames: readonly SDK.DebuggerModel.CallFrame[]): number {
+  let length = 0;
+  for (const frame of callFrames) {
+    const position = scopedPosition(frame);
+    if (!position ||
+        position.sourceMap.translateRawFrame(position.line, position.column)?.kind !==
+            SDK.SourceMapScopesInfo.GeneratedFrameKind.OUTLINED) {
+      break;
+    }
+    ++length;
+  }
+  return length;
+}
+
+/**
+ * @returns the stack depth that doesn't count outlined frames on top of the stack. Entering or leaving an outlined
+ *          part of a function doesn't change it, while calling a function increases it.
+ */
+export function logicalDepth(callFrames: readonly SDK.DebuggerModel.CallFrame[]): number {
+  return callFrames.length - outlinedPrefixLength(callFrames);
+}
+
 /** @returns true iff {@link frame} has encoded scopes, and its position is not mapped to any source. */
 export function isUnmapped(frame: SDK.DebuggerModel.CallFrame): boolean {
   const position = scopedPosition(frame);
@@ -105,8 +132,8 @@ export async function nextAutoStep(
       return isUnmapped(frames[0]) ? await computeAutoStep(SDK.DebuggerModel.StepMode.STEP_INTO, frames) : null;
 
     case SDK.DebuggerModel.StepMode.STEP_OVER: {
-      const startDepth = start.length;
-      const depth = frames.length;
+      const startDepth = logicalDepth(start);
+      const depth = logicalDepth(frames);
       if (isUnmapped(frames[0]) || (depth === startDepth && isSameOriginalLocation(frames[0], start[0]))) {
         // Unmapped code, or still on the same original location (the skip list only covers the generated ranges that
         // contain the start position): keep stepping over.

package/front_end/models/issues_manager/Issue.ts

@@ -27,7 +27,7 @@ const UIStrings = {
   /**
    * @description A description for a kind of issue we display in the Issues tab.
    */
-  pageErrorIssue: 'A page error issue: the page is not working correctly',
+  pageErrorIssue: 'A page error issue: the page isn’t working correctly',
   /**
    * @description A description for a kind of issue we display in the Issues tab.
    */

package/front_end/models/javascript_metadata/NativeFunctions.ts

@@ -227,7 +227,7 @@ export const NativeFunctions: readonly NativeFunctionValue[] = [
   {
     name: "create",
     signatures: [["?options"]],
-    receivers: ["CredentialsContainer","SemanticEmbedder"]
+    receivers: ["CredentialsContainer","DecisionModel","SemanticEmbedder"]
   },
   {
     name: "defineProperty",
@@ -8089,6 +8089,10 @@ export const NativeFunctions: readonly NativeFunctionValue[] = [
     name: "decapsulateBits",
     signatures: [["decapsulationAlgorithm","decapsulationKey","ciphertext"]]
   },
+  {
+    name: "requestFileHandle",
+    signatures: [["hash","?options"]]
+  },
   {
     name: "userAgentAllowsProtocol",
     signatures: [["protocol"]]
@@ -8305,6 +8309,14 @@ export const NativeFunctions: readonly NativeFunctionValue[] = [
     name: "WorkletAnimation",
     signatures: [["animatorName","effects","?timeline","?options"]]
   },
+  {
+    name: "availability",
+    signatures: [["?options"]]
+  },
+  {
+    name: "decide",
+    signatures: [["input","?options"]]
+  },
   {
     name: "LanguageModelToolCall",
     signatures: [["init"]]
@@ -8317,10 +8329,6 @@ export const NativeFunctions: readonly NativeFunctionValue[] = [
     name: "LanguageModelToolError",
     signatures: [["init"]]
   },
-  {
-    name: "availability",
-    signatures: [["?options"]]
-  },
   {
     name: "embed",
     signatures: [["input","?options"]]
@@ -8399,7 +8407,7 @@ export const NativeFunctions: readonly NativeFunctionValue[] = [
   },
   {
     name: "createParserOptions",
-    signatures: [["input"]]
+    signatures: [["?input","...args"]]
   },
   {
     name: "createPolicy",

package/front_end/models/trace/Processor.ts

@@ -202,6 +202,13 @@ export class TraceProcessor extends EventTarget {
 
     options.logger?.start('parse:handleEvent');
 
+    // In bundled builds each handler is a module namespace object whose exports are getters, and every handler has a
+    // different shape. V8 can't optimise a `handler.handleEvent` read that sees all these shapes, so reading it inside the
+    // loop costs a slow getter call for every event and handler.
+    // On a 1M-event trace that is about 30M getter calls per parse. Reading each `handleEvent` once here cut the
+    // handleEvent loop from ~2.9s to ~2.1s (-25%) and total parse time by ~10%, so keep this read outside the loop.
+    const handleEventFns = sortedHandlers.map(([, handler]) => handler.handleEvent);
+
     // Handle each event.
     for (let i = 0; i < traceEvents.length; ++i) {
       // Every so often we take a break just to render.
@@ -213,9 +220,8 @@ export class TraceProcessor extends EventTarget {
         await new Promise(resolve => setTimeout(resolve, 0));
       }
       const event = traceEvents[i];
-      for (let j = 0; j < sortedHandlers.length; ++j) {
-        const [, handler] = sortedHandlers[j];
-        handler.handleEvent(event);
+      for (let j = 0; j < handleEventFns.length; ++j) {
+        handleEventFns[j](event);
       }
     }
 

package/front_end/models/trace/extras/TraceTree.ts

@@ -497,7 +497,7 @@ export class BottomUpRootNode extends Node {
 
     function onEndEvent(event: Types.Events.Event): void {
       const id = idStack.pop();
-      if (!id) {
+      if (id === undefined) {
         return;
       }
 

package/front_end/models/trace/insights/CLSCulprits.ts

@@ -68,7 +68,7 @@ export const UIStrings = {
   /**
    * @description Text status when no layout shift culprits or root causes were found.
    */
-  noCulprits: 'Could not detect any layout shift culprits',
+  noCulprits: 'Couldn’t detect any layout shift culprits',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/CLSCulprits.ts', UIStrings);

package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingListView.ts

@@ -4,6 +4,7 @@
 
 import '../../ui/legacy/components/data_grid/data_grid.js';
 
+import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
@@ -54,6 +55,14 @@ const UIStrings = {
    * @description Context menu item for copying the announcement element HTML snippet to the clipboard.
    */
   copyElementHtml: 'Copy element HTML',
+  /**
+   * @description Context menu item to reveal the announcement source element in the Elements panel DOM tree.
+   */
+  revealInElements: 'Reveal in Elements panel',
+  /**
+   * @description Context menu item to reveal the announcement source element in the full Accessibility tree.
+   */
+  revealInA11yTree: 'Reveal in Accessibility tree',
 } as const;
 const str_ =
     i18n.i18n.registerUIStrings('panels/accessibility/AccessibilityAnnouncementRecordingListView.ts', UIStrings);
@@ -124,10 +133,13 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
   // clang-format on
 };
 
-export class AccessibilityAnnouncementRecordingListView extends UI.Widget.VBox {
+const AccessibilityAnnouncementRecordingListViewBase:
+    Common.ObjectWrapper.EventMixin<AccessibilityAnnouncementRecordingListView.EventTypes, typeof UI.Widget.VBox> =
+    Common.ObjectWrapper.eventMixin(UI.Widget.VBox);
+
+export class AccessibilityAnnouncementRecordingListView extends AccessibilityAnnouncementRecordingListViewBase {
   #items: readonly A11yAnnouncement[] = [];
   #selectedItem: A11yAnnouncement|null = null;
-  #onSelect: ((item: A11yAnnouncement|null) => void)|null = null;
   readonly #view: View;
 
   constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
@@ -164,10 +176,6 @@ export class AccessibilityAnnouncementRecordingListView extends UI.Widget.VBox {
     return this.#selectedItem;
   }
 
-  set onSelect(onSelect: (item: A11yAnnouncement|null) => void) {
-    this.#onSelect = onSelect;
-  }
-
   reset(): void {
     this.#items = [];
     this.#selectedItem = null;
@@ -175,6 +183,16 @@ export class AccessibilityAnnouncementRecordingListView extends UI.Widget.VBox {
   }
 
   #populateContextMenu(contextMenu: UI.ContextMenu.ContextMenu, item: A11yAnnouncement): void {
+    if (item.element) {
+      const revealSection = contextMenu.revealSection();
+      revealSection.appendItem(i18nString(UIStrings.revealInElements), () => {
+        this.dispatchEventToListeners(AccessibilityAnnouncementRecordingListView.Events.REVEAL_IN_ELEMENTS, item);
+      }, {jslogContext: 'reveal-in-elements'});
+      revealSection.appendItem(i18nString(UIStrings.revealInA11yTree), () => {
+        this.dispatchEventToListeners(AccessibilityAnnouncementRecordingListView.Events.REVEAL_IN_A11Y_TREE, item);
+      }, {jslogContext: 'reveal-in-a11y-tree'});
+    }
+
     if (item.message) {
       contextMenu.clipboardSection().appendItem(i18nString(UIStrings.copyMessage), () => {
         Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(item.message);
@@ -197,13 +215,27 @@ export class AccessibilityAnnouncementRecordingListView extends UI.Widget.VBox {
       },
       onSelect: (item: A11yAnnouncement) => {
         this.selectedItem = item;
-        this.#onSelect?.(item);
+        this.dispatchEventToListeners(AccessibilityAnnouncementRecordingListView.Events.ANNOUNCEMENT_SELECTED, item);
       },
       onDeselect: () => {
         this.selectedItem = null;
-        this.#onSelect?.(null);
+        this.dispatchEventToListeners(AccessibilityAnnouncementRecordingListView.Events.ANNOUNCEMENT_SELECTED, null);
       },
     };
     this.#view(input, undefined, this.contentElement);
   }
 }
+
+export namespace AccessibilityAnnouncementRecordingListView {
+  export const enum Events {
+    ANNOUNCEMENT_SELECTED = 'announcement-selected',
+    REVEAL_IN_ELEMENTS = 'reveal-in-elements',
+    REVEAL_IN_A11Y_TREE = 'reveal-in-a11y-tree',
+  }
+
+  export interface EventTypes {
+    [Events.ANNOUNCEMENT_SELECTED]: A11yAnnouncement|null;
+    [Events.REVEAL_IN_ELEMENTS]: A11yAnnouncement;
+    [Events.REVEAL_IN_A11Y_TREE]: A11yAnnouncement;
+  }
+}